Bug#913099: lintian: autopkgtests fail on !(amd64)

2018-11-07 Thread Adam Conrad
I looked into the failure mentioned in this bug (as well as two other
failures on !amd64), and committed the following patch in Ubuntu, which
solves all outstanding issues and gets autopkgtests passing on all six
of our architectures again:

http://launchpadlibrarian.net/396411616/lintian_2.5.111ubuntu1_2.5.111ubuntu2.diff.gz

The changelog explains which upstream commits regressed these three
tests, and the fixes should be fairly obvious using those commits as
references.

I will note that this doesn't fix files-multiarch-foreign-files to work
on other arches, it just restricts it to amd64, but that's the state it
was in before debian bug #886163 was regressed.  I suspect it would be
more "correct" to figure out why that test doesn't pass on other arches
as it might mean the check also doesn't work on other arches, but for
now, it seemed that reverting to the pre-regression behaviour was the
path of least resistance.

... Adam



Bug#913099: Possible triage

2018-11-07 Thread Adam D. Barratt
On Tue, 2018-11-06 at 14:49 -0800, Felix Lechner wrote:
> Thank you for identifying the offending commit. The error you are
> seeing could be caused by the second assignment in:

By default, nnn...@bugs.debian.org does not get sent to the submitter -
you'll need to CC them explicitly.

Regards,

Adam



Bug#912292: Fixed in master?

2018-11-07 Thread Felix Lechner
Hi,

On Lintian master (which includes the pending commit) and with
default-jdk 2:1.11-70 and javahelper 0.71 installed, I get

tests::java-class-format: diff -u t/tests/java-class-format/tags
/lcl/lechner/lintian/git/debian/test-out/tests/java-class-format/tags.java-class-format
--- t/tests/java-class-format/tags2018-11-05 05:43:01.455447409 -0800
+++ 
/lcl/lechner/lintian/git/debian/test-out/tests/java-class-format/tags.java-class-format
   2018-11-07 07:32:39.427605662 -0800
@@ -1,2 +1,2 @@
-W: libtest-java: incompatible-java-bytecode-format Java12 version
(Class format: 56)
 W: libtest-java: unknown-java-class-version
usr/share/java/testa-1.0.jar (org/debian/lintian/TestA.class -> 42)
+W: libtest-java: unknown-java-class-version
usr/share/java/testb-1.0.jar (org/debian/lintian/TestB.class -> 56)
fail tests::java-class-format: output differs!

If the existing tags are correct, what would a good version
requirement look like for Extra-Build-Depends: in 'desc', please?
Thank you!

Kind regards,
Felix Lechner



Build failed in Jenkins: lintian-tests_sid #3412

2018-11-07 Thread jenkins
See 

--
Started by GitLab push by Chris Lamb
Started by GitLab push by Chris Lamb
Started by GitLab push by Chris Lamb
[EnvInject] - Loading node environment variables.
Building on master in workspace 

Wiping out workspace first.
Cloning the remote Git repository
Cloning repository https://salsa.debian.org/lintian/lintian
 > git init  # timeout=10
Fetching upstream changes from https://salsa.debian.org/lintian/lintian
 > git --version # timeout=10
 > git fetch --tags --progress https://salsa.debian.org/lintian/lintian 
 > +refs/heads/*:refs/remotes/origin/*
ERROR: Error cloning remote repo 'origin'
hudson.plugins.git.GitException: Command "git fetch --tags --progress 
https://salsa.debian.org/lintian/lintian +refs/heads/*:refs/remotes/origin/*" 
returned status code 128:
stdout: 
stderr: fatal: unable to access 'https://salsa.debian.org/lintian/lintian/': 
The requested URL returned error: 502

at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2016)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1735)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:420)
at 
org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:629)
at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1146)
at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1186)
at hudson.scm.SCM.checkout(SCM.java:504)
at hudson.model.AbstractProject.checkout(AbstractProject.java:1208)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:574)
at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
at 
hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:499)
at hudson.model.Run.execute(Run.java:1819)
at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
at hudson.model.ResourceController.execute(ResourceController.java:97)
at hudson.model.Executor.run(Executor.java:429)
ERROR: Error cloning remote repo 'origin'



Bug#913078: Please warn if PIDFile in a .service unit contains /var/run

2018-11-07 Thread Chris Lamb
tags 913078 + pending
thanks

Implemented in Git, pending upload:

  
https://salsa.debian.org/lintian/lintian/commit/d21e749edf43fe2c60aee3b70fcb3d027aff60ba

  checks/systemd.desc  | 12 
  checks/systemd.pm|  5 +
  debian/changelog |  3 +++
  .../systemd-service-file-pidfile-refers-to-var-run.service   | 10 ++
  t/tests/systemd-service-file-pidfile-refers-to-var-run/desc  |  5 +
  t/tests/systemd-service-file-pidfile-refers-to-var-run/tags  |  1 +
  6 files changed, 36 insertions(+)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Processed: Re: Please warn if PIDFile in a .service unit contains /var/run

2018-11-07 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 913078 + pending
Bug #913078 [lintian] Please warn if PIDFile in a .service unit contains 
/var/run
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
913078: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=913078
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Jenkins build is back to normal : lintian-tests_buster #1231

2018-11-07 Thread jenkins
See