from:"rra"

[Git][lintian/lintian][master] Fix false-positive for missing-prerequisite-for-pyproject-backend when the...

2022-12-23 Thread Russ Allbery (@rra)



Russ Allbery pushed to branch master at lintian / lintian


Commits:
8509a3f2 by Louis-Philippe Véronneau at 2022-12-23T18:04:42+00:00
Fix false-positive for missing-prerequisite-for-pyproject-backend when the 
backend is specified as a Build-Depends-Indep. Closes: #1025164

- - - - -


4 changed files:

- lib/Lintian/Check/Languages/Python.pm
- 
t/recipes/checks/languages/python/python-wrong-poetry/build-spec/debian/control.in
- t/recipes/checks/languages/python/python-wrong-poetry/build-spec/fill-values
- t/recipes/checks/languages/python/python-wrong-poetry/eval/hints


Changes:

=
lib/Lintian/Check/Languages/Python.pm
=
@@ -254,7 +254,7 @@ sub source {
 $self->pointed_hint(
 'missing-prerequisite-for-pyproject-backend',
 $pointer, $backend,"(does not satisfy $prerequisites)")
-  if !$build_depends->satisfies($prerequisites);
+  if !$build_all->satisfies($prerequisites);
 }
 }
 


=
t/recipes/checks/languages/python/python-wrong-poetry/build-spec/debian/control.in
=
@@ -3,7 +3,8 @@ Priority: optional
 Section: python
 Maintainer: [% $author %]
 Standards-Version: [% $standards_version %]
-Build-Depends: [% $build_depends %], python3-poetry
+Build-Depends: [% $build_depends %], python3-poetry, pybuild-plugin-pyproject
+Build-Depends-Indep: python3-poetry-core
 Rules-Requires-Root: no
 
 Package: python3-[% $source %]


=
t/recipes/checks/languages/python/python-wrong-poetry/build-spec/fill-values
=
@@ -1,3 +1,4 @@
 Skeleton: source-native
 Testname: python-wrong-poetry
-Description: Check packages that build-depend on python3-poetry.
+Description: Check packages that build-depend on python3-poetry. Also acts as a
+ test for packages that have the pyproject dependencies in Build-Depends-Indep.


=
t/recipes/checks/languages/python/python-wrong-poetry/eval/hints
=
@@ -1,2 +1 @@
 python-wrong-poetry (source): uses-poetry-cli [pyproject.toml:3]
-python-wrong-poetry (source): missing-prerequisite-for-pyproject-backend 
poetry.core.masonry.api (does not satisfy python3-poetry-core:any, 
pybuild-plugin-pyproject:any) [pyproject.toml:3]



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/8509a3f2dc93a08bcd4b0a5db5d9394b3b9d807d

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/8509a3f2dc93a08bcd4b0a5db5d9394b3b9d807d
You're receiving this email because of your account on salsa.debian.org.

[Git][lintian/lintian][master] Mark 'very-long-line-length-in-source-file' as experimental, because of the...

2022-12-22 Thread Russ Allbery (@rra)



Russ Allbery pushed to branch master at lintian / lintian


Commits:
899bd1b6 by Louis-Philippe Véronneau at 2022-12-23T04:00:07+00:00
Mark very-long-line-length-in-source-file as experimental, because of 
the high number of false-positives

- - - - -


2 changed files:

- t/recipes/odd-inputs/file-info-errors/eval/literal
- tags/v/very-long-line-length-in-source-file.tag


Changes:

=
t/recipes/odd-inputs/file-info-errors/eval/literal
=
@@ -1,2 +1,2 @@
 W: file-info-errors: empty-binary-package
-P: file-info-errors source: very-long-line-length-in-source-file 2741 > 512 
[split.clam.ole.docaa:9]
+X: file-info-errors source: very-long-line-length-in-source-file 2741 > 512 
[split.clam.ole.docaa:9]


=
tags/v/very-long-line-length-in-source-file.tag
=
@@ -1,4 +1,5 @@
 Tag: very-long-line-length-in-source-file
+Experimental: yes
 Severity: pedantic
 Check: files/contents/line-length
 Explanation: The source file includes a line length that is well beyond



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/899bd1b683c479e166ebd465ff0ad101fbd04ee2

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/899bd1b683c479e166ebd465ff0ad101fbd04ee2
You're receiving this email because of your account on salsa.debian.org.

[Git][lintian/lintian][master] Add "yirmiuc" as a known Pardus distribution

2022-11-26 Thread Russ Allbery (@rra)



Russ Allbery pushed to branch master at lintian / lintian


Commits:
306bab23 by Fatih Altun at 2022-11-27T00:28:23+00:00
Add yirmiuc as a known Pardus distribution

- - - - -


1 changed file:

- vendors/pardus/main/data/changes-file/known-dists


Changes:

=
vendors/pardus/main/data/changes-file/known-dists
=
@@ -3,3 +3,4 @@
 onyedi
 ondokuz
 yirmibir
+yirmiuc



View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/306bab237462b35d8ac4a07806a4d25826c069d6

-- 
View it on GitLab: 
https://salsa.debian.org/lintian/lintian/-/commit/306bab237462b35d8ac4a07806a4d25826c069d6
You're receiving this email because of your account on salsa.debian.org.

lintian: r1358 - in trunk: checks debian lib/Lintian lib/Lintian/Collect

2008-06-07 Thread rra

Author: rra
Date: 2008-06-07 09:47:11 +0200 (Sat, 07 Jun 2008)
New Revision: 1358

Added:
   trunk/lib/Lintian/Collect.pm
   trunk/lib/Lintian/Collect/
   trunk/lib/Lintian/Collect/Source.pm
Modified:
   trunk/checks/cruft
   trunk/debian/changelog
Log:
* checks/cruft:
  + [RA] Use the new Lintian::Collect interface to check whether a
package is native.
* lib/Lintian/Collect.pm:
  + [RA] New module to retrieve package information.
* lib/Lintian/Collect/Source.pm:
  + [RA] New module to retrieve source package information.


Modified: trunk/checks/cruft
===
--- trunk/checks/cruft  2008-06-07 04:59:05 UTC (rev 1357)
+++ trunk/checks/cruft  2008-06-07 07:47:11 UTC (rev 1358)
@@ -78,13 +78,17 @@
 my $native;
 
 my $dir;
-my $pkg;
 my $atdinbd;
 
+# Used in the find function.
+my $pkg;
+my $collect;
+
 sub run {
 
 $pkg = shift;
 my $type = shift;
+$collect = Lintian::Collect-new($pkg, $type);
 
 if (-e debfiles/files and not -z debfiles/files) {
 tag 'debian-files-list-in-source';
@@ -92,21 +96,9 @@
 
 # This doens't really belong here, but there isn't a better place at the
 # moment to put this check.
-open (FORMAT, '', fields/format)
-or fail(cannot open fields/format: $!);
-my $format = FORMAT;
-chomp $format;
-close FORMAT;
-if ($format =~ /^\s*3\.0\s+\(quilt\)\s*$/) {
-$native = 0;
-} else {
-open (VERSION, '', fields/version)
-or fail(cannot open fields/version: $!);
-chomp(my $version = VERSION);
-close VERSION;
-$version =~ s/^\d+://; #Remove epoch
-$native = (! -f ${pkg}_${version}.diff.gz);
-if ($native and $version =~ /-/ and $version !~ /-0\.[^-]+$/) {
+if ($collect-native) {
+my $version = $collect-field('version');
+if ($version =~ /-/ and $version !~ /-0\.[^-]+$/) {
 tag 'native-package-with-dash-version';
 }
 }
@@ -199,7 +191,7 @@
 # than creating yet a third set of tags, and this gets the severity right.
 sub find_cruft {
 (my $name = $File::Find::name) =~ s,^(\./)?unpacked/,,;
-my $prefix = ($native ? diff-contains : source-contains);
+my $prefix = ($collect-native ? diff-contains : source-contains);
 if (-d and not $warned{$name}) {
 for my $rule (@directory_checks) {
 if ($name =~ /$rule-[0]/) {
@@ -211,7 +203,7 @@
 
 unless ($warned{$name}) {
 for my $rule (@file_checks) {
-next if ($rule-[2] and not $native);
+next if ($rule-[2] and not $collect-native);
 if ($name =~ /$rule-[0]/) {
 tag ${prefix}-$rule-[1], $name unless $pkg eq 'lintian';
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 04:59:05 UTC (rev 1357)
+++ trunk/debian/changelog  2008-06-07 07:47:11 UTC (rev 1358)
@@ -18,6 +18,8 @@
   * checks/cruft:
 + [RA] Format: 3.0 (quilt) packages are not native even though they
   have no *.diff.gz.  Thanks, Raphael Hertzog.  (Closes: #483384)
++ [RA] Use the new Lintian::Collect interface to check whether a
+  package is native.
   * checks/fields:
 + [RA] Syntax-check Breaks like other relationship fields.  Warn if
   any packages use Breaks for right now.  Only check for duplicate
@@ -81,7 +83,12 @@
   * debian/control:
 + [RA] Update standards version to 3.8.0.
 + [RA] Depend on libtimedate-perl for convenient date parsing.
-  
+
+  * lib/Lintian/Collect.pm:
++ [RA] New module to retrieve package information.
+  * lib/Lintian/Collect/Source.pm:
++ [RA] New module to retrieve source package information.
+
   * reporting/html_reports:
 + [RA] Copy over images.  Set the maintainer name to Unknown
   Maintainer if not known.  Pass the code for a tag into the per-tag

Added: trunk/lib/Lintian/Collect/Source.pm
===
--- trunk/lib/Lintian/Collect/Source.pm (rev 0)
+++ trunk/lib/Lintian/Collect/Source.pm 2008-06-07 07:47:11 UTC (rev 1358)
@@ -0,0 +1,115 @@
+# -*- perl -*-
+# Lintian::Collect::Source -- interface to source package data collection
+
+# Copyright (C) 2008 Russ Allbery
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by the Free
+# Software Foundation; either version 2 of the License, or (at your option)
+# any later version.
+#
+# This program is distributed in the hope that it will be useful, but WITHOUT
+# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
+# FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
+# more details.
+#
+# You should have received a copy of the GNU General Public License along with
+# this program.  If not, see http://www.gnu.org/licenses/.
+
+package Lintian::Collect::Source;
+use strict;
+
+our @ISA = qw(Lintian::Collect);
+
+# Initialize

lintian: r1359 - in trunk: checks debian testset testset/cdbs-test/debian testset/dh7-test/debian

2008-06-07 Thread rra

Author: rra
Date: 2008-06-07 09:50:41 +0200 (Sat, 07 Jun 2008)
New Revision: 1359

Added:
   trunk/checks/watch-file
   trunk/checks/watch-file.desc
   trunk/testset/cdbs-test/debian/watch
   trunk/testset/cdbs-test_1.orig.tar.gz
   trunk/testset/dh7-test/debian/watch
   trunk/testset/dh7-test_1.dfsg.orig.tar.gz
Modified:
   trunk/debian/changelog
   trunk/testset/dh7-test/debian/changelog
   trunk/testset/tags.cdbs-test
   trunk/testset/tags.dh7-test
   trunk/testset/tags.diffs
Log:
* checks/watch-file{.desc,}:
  + [RA] New checks for watch files, based on work by Patrick
Schoenfeld.  (Closes: #234202, #409104, #456629, #472499)

Added: trunk/checks/watch-file
===
--- trunk/checks/watch-file (rev 0)
+++ trunk/checks/watch-file 2008-06-07 07:50:41 UTC (rev 1359)
@@ -0,0 +1,91 @@
+# watch-file -- lintian check script -*- perl -*-
+#
+# Copyright (C) 2008 Patrick Schoenfeld
+# Copyright (C) 2008 Russ Allbery
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, you can find it on the World Wide
+# Web at http://www.gnu.org/copyleft/gpl.html, or write to the Free
+# Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston,
+# MA 02110-1301, USA.
+
+package Lintian::watch_file;
+use strict;
+
+use Lintian::Collect;
+use Tags;
+
+sub run {
+
+my $pkg = shift;
+my $type = shift;
+my $collect = Lintian::Collect-new($pkg, $type);
+
+unless ($collect-native) {
+unless (-f debfiles/watch) {
+tag 'debian-watch-file-is-missing';
+return;
+}
+
+# Gather information from the watch file and look for problems we can
+# diagnose on the first time through.
+open(WATCH, '', 'debfiles/watch') or fail(cannot open watch file: $!);
+local $_;
+my ($watchver, $mangle);
+while (WATCH) {
+next if /^\s*\#/;
+next if /^\s*$/;
+if (/^version=(\d+)(\s|\Z)/) {
+if (defined $watchver) {
+tag 'debian-watch-file-declares-multiple-versions', line $.;
+}
+$watchver = $1;
+if ($watchver ne '2' and $watchver ne '3') {
+tag 'debian-watch-file-unknown-version', $watchver;
+}
+} else {
+unless ($watchver) {
+tag 'debian-watch-file-missing-version';
+$watchver = 1;
+}
+while (s/\\\s*$//) {
+$_ .= WATCH;
+}
+chomp;
+my ($opts, @opts);
+if (s/^opts=(\S+)\s*// || s/^opts=\([^\]+)\//) {
+$opts = $1;
+@opts = split(',', $opts);
+$mangle = 1 if grep { /^[ud]versionmangle/ } @opts;
+}
+}
+}
+close WATCH;
+
+# If the version of the package contains dfsg, assume that it needs to be
+# mangled to get reasonable matches with upstream.
+my $version = $collect-field('version');
+if ($version =~ /dfsg/ and not $mangle) {
+tag 'debian-watch-file-should-mangle-version';
+}
+}
+
+}
+
+1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 ts=4 et shiftround

Added: trunk/checks/watch-file.desc
===
--- trunk/checks/watch-file.desc(rev 0)
+++ trunk/checks/watch-file.desc2008-06-07 07:50:41 UTC (rev 1359)
@@ -0,0 +1,52 @@
+Check-Script: watch-file
+Author: Patrick Schoenfeld [EMAIL PROTECTED]
+Abbrev: watch
+Type: source
+Unpack-Level: 1
+Needs-Info: debfiles
+Info: Check debian/watch files in source packages.
+
+Tag: debian-watch-file-is-missing
+Type: info
+Ref: policy 4.11, uscan(1)
+Info: This source package is not Debian-native but it does not have a
+ ttdebian/watch/tt file.  This file is used for automatic detection of
+ new upstream versions by the Debian External Health Status project and
+ other project infrastructure.  If this package is maintained upstream,
+ please consider adding a ttdebian/watch/tt file to detect new
+ releases.  If the package is not maintained upstream, consider adding a
+ ttdebian/watch/tt file containing only comments to document this.
+
+Tag: debian-watch-file-declares-multiple-versions
+Type: warning
+Ref: uscan(1)
+Info: The ttdebian/watch/tt file in this package contains multiple
+ lines starting with ttversion=/tt

lintian: r1360 - in trunk: checks debian frontend lib

2008-06-07 Thread rra

Author: rra
Date: 2008-06-07 10:01:34 +0200 (Sat, 07 Jun 2008)
New Revision: 1360

Modified:
   trunk/checks/cruft
   trunk/checks/watch-file
   trunk/debian/changelog
   trunk/frontend/lintian
   trunk/lib/Checker.pm
Log:
* frontend/lintian:
  + [RA] Create a new Lintian::Collect object for each package being
checked and pass it into Checker::runcheck.
* lib/Checker.pm:
  + [RA] Pass a Lintian::Collect object as the third argument to the run
function of each check.

Modified: trunk/checks/cruft
===
--- trunk/checks/cruft  2008-06-07 07:50:41 UTC (rev 1359)
+++ trunk/checks/cruft  2008-06-07 08:01:34 UTC (rev 1360)
@@ -88,7 +88,7 @@
 
 $pkg = shift;
 my $type = shift;
-$collect = Lintian::Collect-new($pkg, $type);
+$collect = shift;
 
 if (-e debfiles/files and not -z debfiles/files) {
 tag 'debian-files-list-in-source';

Modified: trunk/checks/watch-file
===
--- trunk/checks/watch-file 2008-06-07 07:50:41 UTC (rev 1359)
+++ trunk/checks/watch-file 2008-06-07 08:01:34 UTC (rev 1360)
@@ -29,7 +29,7 @@
 
 my $pkg = shift;
 my $type = shift;
-my $collect = Lintian::Collect-new($pkg, $type);
+my $collect = shift;
 
 unless ($collect-native) {
 unless (-f debfiles/watch) {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 07:50:41 UTC (rev 1359)
+++ trunk/debian/changelog  2008-06-07 08:01:34 UTC (rev 1360)
@@ -87,6 +87,13 @@
 + [RA] Update standards version to 3.8.0.
 + [RA] Depend on libtimedate-perl for convenient date parsing.
 
+  * frontend/lintian:
++ [RA] Create a new Lintian::Collect object for each package being
+  checked and pass it into Checker::runcheck.
+
+  * lib/Checker.pm:
++ [RA] Pass a Lintian::Collect object as the third argument to the run
+  function of each check.
   * lib/Lintian/Collect.pm:
 + [RA] New module to retrieve package information.
   * lib/Lintian/Collect/Source.pm:

Modified: trunk/frontend/lintian
===
--- trunk/frontend/lintian  2008-06-07 07:50:41 UTC (rev 1359)
+++ trunk/frontend/lintian  2008-06-07 08:01:34 UTC (rev 1360)
@@ -1185,6 +1185,7 @@
 }
 
 require Checker;
+require Lintian::Collect;
 
 # for each package (the `reverse sort' is to make sure that source packages are
 # before the corresponding binary packages--this has the advantage that binary
@@ -1356,6 +1357,7 @@
 }
 
# perform checks
+   my $collect = Lintian::Collect-new($pkg, $long_type);
for my $check (keys %checks) {
my $ci = $check_info{$check};
 
@@ -1379,7 +1381,7 @@
next PACKAGE;
}
 
-   my $returnvalue = Checker::runcheck($pkg, $long_type, $check);
+   my $returnvalue = Checker::runcheck($pkg, $long_type, $collect, 
$check);
# Set exit_code correctly if there was not yet an exit code
$exit_code = $returnvalue unless $exit_code;
 

Modified: trunk/lib/Checker.pm
===
--- trunk/lib/Checker.pm2008-06-07 07:50:41 UTC (rev 1359)
+++ trunk/lib/Checker.pm2008-06-07 08:01:34 UTC (rev 1360)
@@ -51,9 +51,7 @@
 }
 
 sub runcheck {
-   my $pkg = shift;
-   my $type = shift;
-   my $name = shift;
+   my ($pkg, $type, $collect, $name) = @_;
 
# Will be set to 2 if error is encountered
my $return = 0;
@@ -67,7 +65,7 @@
 
#print STDERR Now running $name...\n;
$name =~ s/[-.]/_/g;
-   eval { {'Lintian::'.$name.'::run'}($pkg, $type) };
+   eval { {'Lintian::'.$name.'::run'}($pkg, $type, $collect) };
if ( $@ ) {
print STDERR $@;
print STDERR internal error: cannot run $name check on package 
$pkg\n;
@@ -79,4 +77,8 @@
 
 1;
 
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 8
+# End:
 # vim: ts=4 sw=4 noet


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1361 - in trunk: checks lib/Lintian/Collect

2008-06-07 Thread rra

Author: rra
Date: 2008-06-07 10:14:30 +0200 (Sat, 07 Jun 2008)
New Revision: 1361

Modified:
   trunk/checks/standards-version
   trunk/lib/Lintian/Collect/Source.pm
Log:
Add a function to Lintian::Collect::Source to retrieve the source
package changelog as a Parse::DebianChangelog object and use that
function in checks/standards-version.


Modified: trunk/checks/standards-version
===
--- trunk/checks/standards-version  2008-06-07 08:01:34 UTC (rev 1360)
+++ trunk/checks/standards-version  2008-06-07 08:14:30 UTC (rev 1361)
@@ -77,16 +77,15 @@
 
 my $pkg = shift;
 my $type = shift;
+my $collect = shift;
 
 # udebs aren't required to conform to policy, so they don't need
 # Standards-Version. (If they have it, though, it should be valid.)
-unless (open(STANDARD, '', 'fields/standards-version')) {
+my $version = $collect-field('standards-version');
+if (not defined $version) {
 tag 'no-standards-version-field' unless $type eq 'udeb';
 return 0;
 }
-my $version = STANDARD;
-close STANDARD;
-chomp $version;
 
 # Check basic syntax and strip off the fourth digit.  People are allowed to
 # include the fourth digit if they want, but it indicates a non-normative
@@ -99,13 +98,14 @@
 my $stdver = $1;
 my ($major, $minor, $patch) = $stdver =~ m/^(\d+)\.(\d+)\.(\d+)/;
 
+my $tag = $version (current is $current);
 if (not exists $standards{$stdver}) {
 # Unknown standards version.  Perhaps newer?
 if (   ($major  $current[0])
 or ($major == $current[0] and $minor  $current[1])
 or ($major == $current[0] and $minor == $current[1]
 and $patch  $current[2])) {
-tag 'newer-standards-version', $version (current is $current);
+tag 'newer-standards-version', $tag;
 } else {
 tag 'invalid-standards-version', $version;
 }
@@ -118,24 +118,21 @@
 # time the package was uploaded.
 my $stddate = $standards{$stdver};
 if (str2time($stddate)  time - (60 * 60 * 24 * 365 * 2)) {
-tag 'ancient-standards-version', $version (current is $current);
+tag 'ancient-standards-version', $tag;
 } else {
 # We have to get the package date from the changelog file.  If we
 # can't find the changelog file, always issue the tag.
-if (-l 'debfiles/changelog' || ! -f 'debfiles/changelog') {
-tag 'out-of-date-standards-version',
-$version (current is $current);
+my $changes = $collect-changelog;
+if (not defined $changes) {
+tag 'out-of-date-standards-version', $tag;
 return 0;
 }
-my %opts = (infile = 'debfiles/changelog', quiet = 1);
-my $changes = Parse::DebianChangelog-init(\%opts);
 my ($entry) = $changes-data;
 my $timestamp = $entry ? $entry-Timestamp : 0;
 for my $standard (@standards) {
 last if $standard-[0] eq $stdver;
 if (str2time($standard-[1])  $timestamp) {
-tag 'out-of-date-standards-version',
-$version (current is $current);
+tag 'out-of-date-standards-version', $tag;
 }
 }
 }

Modified: trunk/lib/Lintian/Collect/Source.pm
===
--- trunk/lib/Lintian/Collect/Source.pm 2008-06-07 08:01:34 UTC (rev 1360)
+++ trunk/lib/Lintian/Collect/Source.pm 2008-06-07 08:14:30 UTC (rev 1361)
@@ -19,6 +19,9 @@
 package Lintian::Collect::Source;
 use strict;
 
+use Lintian::Collect;
+use Parse::DebianChangelog;
+
 our @ISA = qw(Lintian::Collect);
 
 # Initialize a new source package collect object.  Takes the package name,
@@ -30,6 +33,20 @@
 return $self;
 }
 
+# Get the changelog file of a source package as a Parse::DebianChangelog
+# object.  Returns undef if the changelog file couldn't be found.
+sub changelog {
+my ($self) = @_;
+return $self-{changelog} if exists $self-{changelog};
+if (-l 'debfiles/changelog' || ! -f 'debfiles/changelog') {
+$self-{changelog} = undef;
+} else {
+my %opts = (infile = 'debfiles/changelog', quiet = 1);
+$self-{changelog} = Parse::DebianChangelog-init(\%opts);
+}
+return $self-{changelog};
+}
+
 # Returns whether the package is a native package.  For everything except
 # format 3.0 (quilt) packages, we base this on whether we have a Debian
 # *.diff.gz file.  3.0 (quilt) packages are always non-native.  Returns true
@@ -90,6 +107,13 @@
 
 =over 4
 
+=item changelog()
+
+Returns the changelog of the source package as a Parse::DebianChangelog
+object, or undef if the changelog is a symlink or doesn't exist.  The
+debfiles collection script must have been run to create the changelog
+file, which this method expects to find in Fdebfiles/changelog.
+
 =item native()
 
 Returns true if the source package is native and false otherwise.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject

lintian: r1362 - in trunk: checks debian testset

2008-06-07 Thread rra

Author: rra
Date: 2008-06-07 10:44:14 +0200 (Sat, 07 Jun 2008)
New Revision: 1362

Modified:
   trunk/checks/binaries
   trunk/checks/binaries.desc
   trunk/debian/changelog
   trunk/testset/tags.libbaz
Log:
  + [RA] Remove several-sonames-in-same-package.  This is frequently not
an error and Lintian doesn't have enough information to know.

Modified: trunk/checks/binaries
===
--- trunk/checks/binaries   2008-06-07 08:14:30 UTC (rev 1361)
+++ trunk/checks/binaries   2008-06-07 08:44:14 UTC (rev 1362)
@@ -133,7 +133,6 @@
 return 0;
 }
 my @sonames = sort grep { lib_soname_path (@{$SONAME{$_}}) } keys %SONAME;
-tag several-sonames-in-same-package, @sonames if @sonames  1;
 
 # try to identify transition strings
 my $base_pkg = $pkg;

Modified: trunk/checks/binaries.desc
===
--- trunk/checks/binaries.desc  2008-06-07 08:14:30 UTC (rev 1361)
+++ trunk/checks/binaries.desc  2008-06-07 08:44:14 UTC (rev 1362)
@@ -115,12 +115,6 @@
 Type: error
 Info: Debian does not allow binaries to be compressed by UPX.
 
-Tag: several-sonames-in-same-package
-Type: info
-Info: There are several shared libraries in this package and they
- have different sonames. This is usually discouraged because it is
- inherently error-prone.
-
 Tag: package-name-doesnt-match-sonames
 Type: warning
 Info: The package name of a library package should usually reflect

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 08:14:30 UTC (rev 1361)
+++ trunk/debian/changelog  2008-06-07 08:44:14 UTC (rev 1362)
@@ -5,6 +5,8 @@
 + [RA] When checking SONAMEs against package names, convert all
   underscores to dashes, not just the first one.  Thanks, Gonéri Le
   Bouder.  (Closes: #482450)
++ [RA] Remove several-sonames-in-same-package.  This is frequently not
+  an error and Lintian doesn't have enough information to know.
   * checks/common_data.pm:
 + [RA] armel is now a standard architecture.
 + [RA] Remove %known_obsolete_packages, now handled via data.

Modified: trunk/testset/tags.libbaz
===
--- trunk/testset/tags.libbaz   2008-06-07 08:14:30 UTC (rev 1361)
+++ trunk/testset/tags.libbaz   2008-06-07 08:44:14 UTC (rev 1362)
@@ -27,7 +27,6 @@
 I: libbaz1-dev: no-md5sums-control-file
 I: libbaz1: binary-has-unneeded-section ./usr/lib/perl5/auto/Foo/Foo.so 
.comment
 I: libbaz1: no-md5sums-control-file
-I: libbaz1: several-sonames-in-same-package libbaz2.so.1.0 libbaz3.so.1
 I: libbaz2-dbg: no-md5sums-control-file
 I: libbaz2-dev: no-md5sums-control-file
 I: libbaz2: no-md5sums-control-file


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1363 - in trunk: checks debian testset testset/relations/debian

2008-06-07 Thread rra

Author: rra
Date: 2008-06-07 11:00:44 +0200 (Sat, 07 Jun 2008)
New Revision: 1363

Modified:
   trunk/checks/common_data.pm
   trunk/checks/fields
   trunk/checks/fields.desc
   trunk/debian/changelog
   trunk/testset/relations/debian/control
   trunk/testset/tags.debug
Log:
  + [RA] Merge %non_standard_archs into %known_archs.
  + [RA] Remove non-standard-architecture-in-source-relation and
non-standard-architecture.  These aren't bugs.

Modified: trunk/checks/common_data.pm
===
--- trunk/checks/common_data.pm 2008-06-07 08:44:14 UTC (rev 1362)
+++ trunk/checks/common_data.pm 2008-06-07 09:00:44 UTC (rev 1363)
@@ -21,21 +21,15 @@
   %known_archs %known_sections %known_non_us_parts %known_archive_parts
   %known_prios %known_source_fields %known_binary_fields %known_udeb_fields
   %known_obsolete_fields %known_essential %known_build_essential
-  %known_obsolete_packages %known_obsolete_emacs %known_virtual_packages
+  %known_obsolete_emacs %known_virtual_packages
   %known_libstdcs %known_tcls %known_tclxs %known_tks %known_tkxs
   %known_libpngs %known_x_metapackages
-  %non_standard_archs %all_cpus %all_oses
+  %all_cpus %all_oses
   %known_doc_base_formats
 );
 
 # simple defines for commonly needed data
 
-# From /usr/share/dpkg/archtable, included here to make lintian results
-# consistent no matter what dpkg one has installed.
-%known_archs = map { $_ = 1 }
-('i386', 'ia64', 'alpha', 'amd64', 'arm', 'armel', 'hppa', 'm68k', 'mips',
- 'mipsel', 'powerpc', 's390', 'sparc', 'hurd-i386', 'any', 'all');
-
 # From /usr/share/dpkg/cputable, included here to make lintian results
 # consistent no matter what dpkg one has installed.
 %all_cpus = map { $_ = 1 }
@@ -56,14 +50,14 @@
 # this reduces the necessary updating.
 #
 # armel and lpia are special cases, so handle them separately here.  (They're
-# handled separately in /usr/share/dpkg/triplettable.)
-%non_standard_archs = map { $_ = 1 }
+# handled separately in /usr/share/dpkg/triplettable.)  any and all are also
+# special cases.
+%known_archs = map { $_ = 1 }
 grep { !$known_archs{$_} }
 (keys %all_cpus,
  map { my $os = $_; map { $os-$_ } keys %all_cpus } keys %all_oses),
-('armel', 'lpia');
+('armel', 'lpia', 'any', 'all');
 
-
 %known_sections = map { $_ = 1 }
 ('admin', 'comm', 'devel', 'doc', 'editors', 'electronics',
  'embedded', 'games', 'gnome', 'graphics', 'hamradio', 'interpreters',

Modified: trunk/checks/fields
===
--- trunk/checks/fields 2008-06-07 08:44:14 UTC (rev 1362)
+++ trunk/checks/fields 2008-06-07 09:00:44 UTC (rev 1363)
@@ -201,11 +201,7 @@
}
 
for my $arch (@archs) {
-   if ($non_standard_archs{$arch}) {
-   tag non-standard-architecture, $arch;
-   } elsif (! $known_archs{$arch}) {
-   tag unknown-architecture, $arch;
-   }
+   tag unknown-architecture, $arch unless $known_archs{$arch};
}
 
if ($type eq binary) {
@@ -672,9 +668,7 @@
my ($d_pkg, $d_version, $d_arch, $rest, 
$part_d_orig) = @$part_d;
 
for my $arch (@{$d_arch-[0]}) {
-   if ($non_standard_archs{$arch}) 
{
-   tag 
non-standard-arch-in-source-relation, $arch [$field: $part_d_orig];
-   } elsif (!$known_archs{$arch} 
 $arch ne any  $arch ne all) {
+   if (!$known_archs{$arch}) {
tag 
invalid-arch-string-in-source-relation, $arch [$field: $part_d_orig]
}
}

Modified: trunk/checks/fields.desc
===
--- trunk/checks/fields.desc2008-06-07 08:44:14 UTC (rev 1362)
+++ trunk/checks/fields.desc2008-06-07 09:00:44 UTC (rev 1363)
@@ -67,20 +67,12 @@
 
 Tag: unknown-architecture
 Type: warning
-Info: In addition to the special values `all' and `any', the architecture
- names alpha, arm, hppa, hurd-i386, i386, ia64, m68k, mips, mipsel, powerpc,
- s390, and sparc are currently in use.  The special value `source' is only 
- used in .changes files and does not make sense in a binary package or a 
- .dsc file.
+Info: This package claims to be for an unknown architecture.  The
+ architecture should be one of the values supported by dpkg or one of the
+ special values all or any.  The special value source is only used
+ in *.changes files and does not make sense in a binary package or a *.dsc
+ file.
 
-Tag: non-standard-architecture
-Type: info
-Info: In addition to the special values `all', `any' and the names

lintian: r1364 - in trunk: checks debian testset testset/debconf/debian

2008-06-07 Thread rra

Author: rra
Date: 2008-06-07 11:21:50 +0200 (Sat, 07 Jun 2008)
New Revision: 1364

Added:
   trunk/testset/debconf/debian/debconf-test-postinst.postinst
   trunk/testset/debconf/debian/debconf-test-postinst.postrm
   trunk/testset/debconf/debian/debconf-test-postinst.templates
Modified:
   trunk/checks/debconf
   trunk/debian/changelog
   trunk/testset/debconf/debian/control
   trunk/testset/debconf/debian/rules
   trunk/testset/tags.debconf
Log:
* checks/debconf:
  + [RA] Don't warn about using db_input in postinst if a config script
also exists and uses db_input.  The package maintainer probably
knows what they're doing.

Modified: trunk/checks/debconf
===
--- trunk/checks/debconf2008-06-07 09:00:44 UTC (rev 1363)
+++ trunk/checks/debconf2008-06-07 09:21:50 UTC (rev 1364)
@@ -330,6 +330,7 @@
 
 # Check the maintainer scripts.
 
+my $config_calls_db_input;
 for my $file (qw(config postinst)) {
 my $potential_makedev = {};
 if (open(IN, '', control/$file)) {
@@ -354,18 +355,22 @@
last unless $next;
$_ .= $next;
}
-   if (m#(?:\.|source)\s+/usr/share/debconf/confmodule# ||
+   if (m,(?:\.|source)\s+/usr/share/debconf/confmodule, ||
m/(use|require)\s+Debconf::Client::ConfModule/) {
$usesconfmodule=1;
}
if (not $obsoleteconfmodule and
-   m#(/usr/share/debconf/confmodule\.sh|
-  Debian::DebConf::Client::ConfModule)#x) {
+   m,(/usr/share/debconf/confmodule\.sh|
+  Debian::DebConf::Client::ConfModule),x) {
tag $file-loads-obsolete-confmodule, $1;
$usesconfmodule=1;
$obsoleteconfmodule=1;
}
-   if ($file eq 'postinst' and not $db_input and m/db_input/) {
+   if ($file eq 'config' and m/db_input/) {
+   $config_calls_db_input = 1;
+   }
+   if ($file eq 'postinst' and not $db_input and m/db_input/
+   and not $config_calls_db_input) {
# TODO: Perl?
tag postinst-uses-db-input, 
unless $type eq 'udeb';
@@ -492,4 +497,8 @@
 
 1;
 
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 4
+# End:
 # vim: syntax=perl ts=8

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 09:00:44 UTC (rev 1363)
+++ trunk/debian/changelog  2008-06-07 09:21:50 UTC (rev 1364)
@@ -23,6 +23,10 @@
   have no *.diff.gz.  Thanks, Raphael Hertzog.  (Closes: #483384)
 + [RA] Use the new Lintian::Collect interface to check whether a
   package is native.
+  * checks/debconf:
++ [RA] Don't warn about using db_input in postinst if a config script
+  also exists and uses db_input.  The package maintainer probably
+  knows what they're doing.
   * checks/fields:
 + [RA] Syntax-check Breaks like other relationship fields.  Warn if
   any packages use Breaks for right now.  Only check for duplicate

Modified: trunk/testset/debconf/debian/control
===
--- trunk/testset/debconf/debian/control2008-06-07 09:00:44 UTC (rev 
1363)
+++ trunk/testset/debconf/debian/control2008-06-07 09:21:50 UTC (rev 
1364)
@@ -22,6 +22,12 @@
 Description: Test package for the debconf checks of lintian
  Package uses debconf only in preinst
 
+Package: debconf-test-postinst
+Architecture: any
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: Test package for the debconf checks of lintian
+ Package uses debconf only in postinst
+
 Package: debconf-udeb
 Section: debian-installer
 XC-Package-Type: udeb

Copied: trunk/testset/debconf/debian/debconf-test-postinst.postinst (from rev 
1343, trunk/testset/debconf/debian/debconf-test-preinst.preinst)
===
--- trunk/testset/debconf/debian/debconf-test-postinst.postinst 
(rev 0)
+++ trunk/testset/debconf/debian/debconf-test-postinst.postinst 2008-06-07 
09:21:50 UTC (rev 1364)
@@ -0,0 +1,10 @@
+#!/bin/sh
+set -e
+
+. /usr/share/debconf/confmodule
+
+db_input medium debconf/test
+
+#DEBHELPER#
+
+true

Copied: trunk/testset/debconf/debian/debconf-test-postinst.postrm (from rev 
1343, trunk/testset/debconf/debian/debconf-test-preinst.postrm)
===
--- trunk/testset/debconf/debian/debconf-test-postinst.postrm   
(rev 0)
+++ trunk/testset/debconf/debian/debconf-test-postinst.postrm   2008-06-07 
09:21:50 UTC (rev 1364)
@@ -0,0 +1,7 @@
+#!/bin/sh
+set -e
+if [ $1 = purge ]  [ -e /usr/share/debconf/confmodule ]; then
+. /usr/share/debconf/confmodule
+db_purge
+fi
+#DEBHELPER#

Copied: trunk/testset/debconf

lintian: r1365 - in trunk: checks frontend lib

2008-06-07 Thread rra

Author: rra
Date: 2008-06-08 05:51:27 +0200 (Sun, 08 Jun 2008)
New Revision: 1365

Modified:
   trunk/checks/cruft
   trunk/checks/standards-version
   trunk/checks/watch-file
   trunk/frontend/lintian
   trunk/lib/Checker.pm
Log:
Use $info rather than $collect as the name for the Lintian::Collect
object, since it's still early and I can change my mind about what
to name things.


Modified: trunk/checks/cruft
===
--- trunk/checks/cruft  2008-06-07 09:21:50 UTC (rev 1364)
+++ trunk/checks/cruft  2008-06-08 03:51:27 UTC (rev 1365)
@@ -82,13 +82,13 @@
 
 # Used in the find function.
 my $pkg;
-my $collect;
+my $info;
 
 sub run {
 
 $pkg = shift;
 my $type = shift;
-$collect = shift;
+$info = shift;
 
 if (-e debfiles/files and not -z debfiles/files) {
 tag 'debian-files-list-in-source';
@@ -96,8 +96,8 @@
 
 # This doens't really belong here, but there isn't a better place at the
 # moment to put this check.
-if ($collect-native) {
-my $version = $collect-field('version');
+if ($info-native) {
+my $version = $info-field('version');
 if ($version =~ /-/ and $version !~ /-0\.[^-]+$/) {
 tag 'native-package-with-dash-version';
 }
@@ -191,7 +191,7 @@
 # than creating yet a third set of tags, and this gets the severity right.
 sub find_cruft {
 (my $name = $File::Find::name) =~ s,^(\./)?unpacked/,,;
-my $prefix = ($collect-native ? diff-contains : source-contains);
+my $prefix = ($info-native ? diff-contains : source-contains);
 if (-d and not $warned{$name}) {
 for my $rule (@directory_checks) {
 if ($name =~ /$rule-[0]/) {
@@ -203,7 +203,7 @@
 
 unless ($warned{$name}) {
 for my $rule (@file_checks) {
-next if ($rule-[2] and not $collect-native);
+next if ($rule-[2] and not $info-native);
 if ($name =~ /$rule-[0]/) {
 tag ${prefix}-$rule-[1], $name unless $pkg eq 'lintian';
 }

Modified: trunk/checks/standards-version
===
--- trunk/checks/standards-version  2008-06-07 09:21:50 UTC (rev 1364)
+++ trunk/checks/standards-version  2008-06-08 03:51:27 UTC (rev 1365)
@@ -77,11 +77,11 @@
 
 my $pkg = shift;
 my $type = shift;
-my $collect = shift;
+my $info = shift;
 
 # udebs aren't required to conform to policy, so they don't need
 # Standards-Version. (If they have it, though, it should be valid.)
-my $version = $collect-field('standards-version');
+my $version = $info-field('standards-version');
 if (not defined $version) {
 tag 'no-standards-version-field' unless $type eq 'udeb';
 return 0;
@@ -122,7 +122,7 @@
 } else {
 # We have to get the package date from the changelog file.  If we
 # can't find the changelog file, always issue the tag.
-my $changes = $collect-changelog;
+my $changes = $info-changelog;
 if (not defined $changes) {
 tag 'out-of-date-standards-version', $tag;
 return 0;

Modified: trunk/checks/watch-file
===
--- trunk/checks/watch-file 2008-06-07 09:21:50 UTC (rev 1364)
+++ trunk/checks/watch-file 2008-06-08 03:51:27 UTC (rev 1365)
@@ -29,9 +29,9 @@
 
 my $pkg = shift;
 my $type = shift;
-my $collect = shift;
+my $info = shift;
 
-unless ($collect-native) {
+unless ($info-native) {
 unless (-f debfiles/watch) {
 tag 'debian-watch-file-is-missing';
 return;
@@ -74,7 +74,7 @@
 
 # If the version of the package contains dfsg, assume that it needs to be
 # mangled to get reasonable matches with upstream.
-my $version = $collect-field('version');
+my $version = $info-field('version');
 if ($version =~ /dfsg/ and not $mangle) {
 tag 'debian-watch-file-should-mangle-version';
 }

Modified: trunk/frontend/lintian
===
--- trunk/frontend/lintian  2008-06-07 09:21:50 UTC (rev 1364)
+++ trunk/frontend/lintian  2008-06-08 03:51:27 UTC (rev 1365)
@@ -1357,7 +1357,7 @@
 }
 
# perform checks
-   my $collect = Lintian::Collect-new($pkg, $long_type);
+   my $info = Lintian::Collect-new($pkg, $long_type);
for my $check (keys %checks) {
my $ci = $check_info{$check};
 
@@ -1381,7 +1381,7 @@
next PACKAGE;
}
 
-   my $returnvalue = Checker::runcheck($pkg, $long_type, $collect, 
$check);
+   my $returnvalue = Checker::runcheck($pkg, $long_type, $info, 
$check);
# Set exit_code correctly if there was not yet an exit code
$exit_code = $returnvalue unless $exit_code;
 

Modified: trunk/lib/Checker.pm
===
--- trunk/lib/Checker.pm2008-06-07 09:21:50 UTC (rev 1364)
+++ trunk/lib/Checker.pm2008-06

lintian: r1366 - trunk/debian

2008-06-07 Thread rra

Author: rra
Date: 2008-06-08 06:11:56 +0200 (Sun, 08 Jun 2008)
New Revision: 1366

Modified:
   trunk/debian/changelog
Log:
Finalize changes for 1.24.0.


Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-08 03:51:27 UTC (rev 1365)
+++ trunk/debian/changelog  2008-06-08 04:11:56 UTC (rev 1366)
@@ -1,5 +1,8 @@
-lintian (1.23.50) unstable; urgency=low
+lintian (1.24.0) unstable; urgency=low
 
+  The Policy 3.8.0, infrastructure evolution, and real web design
+  release.
+  
   * checks/binaries:
 + [RA] Fix code for filtering out NSS modules from SONAME checks.
 + [RA] When checking SONAMEs against package names, convert all
@@ -122,7 +125,7 @@
 + [FL] Include link to full maintainer report.  Suggested by
   Kartik Mistry.
 
- -- Frank Lichtenheld [EMAIL PROTECTED]  Thu, 29 May 2008 17:31:41 +0200
+ -- Russ Allbery [EMAIL PROTECTED]  Sat, 07 Jun 2008 21:09:54 -0700
 
 lintian (1.23.49) unstable; urgency=low
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1367 - releases

2008-06-07 Thread rra

Author: rra
Date: 2008-06-08 06:36:35 +0200 (Sun, 08 Jun 2008)
New Revision: 1367

Added:
   releases/1.24.0/
Log:
Tag 1.24.0 release.


Copied: releases/1.24.0 (from rev 1366, trunk)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1341 - in trunk: checks debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-06 23:48:39 +0200 (Fri, 06 Jun 2008)
New Revision: 1341

Modified:
   trunk/checks/init.d
   trunk/debian/changelog
Log:
* checks/init.d:
  + [RA] Try to allow for postinst scripts written in Perl and still
recognize the update-rc.d calls.

Modified: trunk/checks/init.d
===
--- trunk/checks/init.d 2008-06-05 05:52:56 UTC (rev 1340)
+++ trunk/checks/init.d 2008-06-06 21:48:39 UTC (rev 1341)
@@ -59,7 +59,7 @@
 while (IN) {
next if /$exclude_r/o;
s/\#.*$//o;
-   next unless /^(?:.+;)?\s*update-rc\.d\s+
+   next unless /^(?:.+;|^\s*system[\s\(\']+)?\s*update-rc\.d\s+
(?:$opts_r)*($name_r)\s+($action_r)/xo;
my ($name,$opt) = ($1,$2);
next if $opt eq 'remove';

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-05 05:52:56 UTC (rev 1340)
+++ trunk/debian/changelog  2008-06-06 21:48:39 UTC (rev 1341)
@@ -16,6 +16,9 @@
   Conflicts, and other similar fields.  Warn if Breaks is used without
   a version.  Check that Breaks is not inconsistent with other
   dependency fields.
+  * checks/init.d:
++ [RA] Try to allow for postinst scripts written in Perl and still
+  recognize the update-rc.d calls.
   * checks/manpages:
 + [RA] Only ignore errors about wrapping lines for Asian locale man
   pages, since that's where the groff trouble lies.  Ignore character


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1342 - trunk/checks

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 00:24:57 +0200 (Sat, 07 Jun 2008)
New Revision: 1342

Modified:
   trunk/checks/manpages
   trunk/checks/manpages.desc
Log:
Properly generalize the exclusion of zh_* locales from the prohibition
on country names in man page locale directories to allow for any zh_*
country-based locale.


Modified: trunk/checks/manpages
===
--- trunk/checks/manpages   2008-06-06 21:48:39 UTC (rev 1341)
+++ trunk/checks/manpages   2008-06-06 22:24:57 UTC (rev 1342)
@@ -121,7 +121,7 @@
 # The country should not be part of the man page locale directory unless
 # it's one of the known cases where the language is significantly
 # different between countries.
-if ($lang =~ /_/  $lang !~ /^(pt_BR|zh_(CN|TW))$/) {
+if ($lang =~ /_/  $lang !~ /^(pt_BR|zh_[A-Z][A-Z])$/) {
tag manpage-locale-dir-country-specific, $file;
 }
 

Modified: trunk/checks/manpages.desc
===
--- trunk/checks/manpages.desc  2008-06-06 21:48:39 UTC (rev 1341)
+++ trunk/checks/manpages.desc  2008-06-06 22:24:57 UTC (rev 1342)
@@ -247,6 +247,6 @@
 Info: This package installs a manual page in a locale directory that
  includes the country name.  A country name should not be included in the
  directory name unless it indicates a significant difference in the
- language.  The known cases where country names are appropriate are pt_BR,
- zh_CN, zh_TW, and zh_SG.  Please file a bug against Lintian if this is
- another case where a country name is appropriate.
+ language.  The known cases where country names are appropriate are pt_BR
+ and zh_*.  Please file a bug against Lintian if this is another case
+ where a country name is appropriate.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1344 - in trunk: checks debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 01:29:03 +0200 (Sat, 07 Jun 2008)
New Revision: 1344

Modified:
   trunk/checks/binaries
   trunk/debian/changelog
Log:
* checks/binaries:
  + [RA] Fix code for filtering out NSS modules from SONAME checks.

Modified: trunk/checks/binaries
===
--- trunk/checks/binaries   2008-06-06 22:37:26 UTC (rev 1343)
+++ trunk/checks/binaries   2008-06-06 23:29:03 UTC (rev 1344)
@@ -125,10 +125,10 @@
 sub lib_soname_path {
 my (@paths) = @_;
 foreach my $path (@paths) {
+   next if $path =~ m%^(\.?/)?lib/libnss_[^.]+\.so(\.[0-9]+)$%;
return 1 if $path =~ m%^(\.?/)?lib/[^/]+$%;
return 1 if $path =~ m%^(\.?/)?usr/lib/[^/]+$%;
return 1 if $path =~ m%^(\.?/)?usr/X11R6/lib/[^/]+$%;
-   return 1 if $path =~ m%^(\.?/)?lib/libnss_[^.]+\.so(\.[0-9]+)$%;
 }
 return 0;
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-06 22:37:26 UTC (rev 1343)
+++ trunk/debian/changelog  2008-06-06 23:29:03 UTC (rev 1344)
@@ -1,5 +1,7 @@
 lintian (1.23.50) unstable; urgency=low
 
+  * checks/binaries:
++ [RA] Fix code for filtering out NSS modules from SONAME checks.
   * checks/common_data.pm:
 + [RA] armel is now a standard architecture.
   * checks/control-file{.desc,}:


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1345 - in trunk: checks data data/fields debian testset testset/relations/debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 01:56:59 +0200 (Sat, 07 Jun 2008)
New Revision: 1345

Added:
   trunk/data/fields/
   trunk/data/fields/obsolete-packages
Modified:
   trunk/checks/common_data.pm
   trunk/checks/fields
   trunk/debian/changelog
   trunk/testset/relations/debian/control
   trunk/testset/tags.relations
Log:
  + [RA] Remove %known_obsolete_packages, now handled via data.
  + [RA] Use Lintian::Data to load the obsolete package list.
* data/fields/obsolete-packages:
  + [RA] Moved from common_data.pm.  Removed many very old packages that
nothing depends on and added many new packages identified by Riku
Voipio.  (Closes: #475400)

Modified: trunk/checks/common_data.pm
===
--- trunk/checks/common_data.pm 2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/checks/common_data.pm 2008-06-06 23:56:59 UTC (rev 1345)
@@ -119,11 +119,6 @@
 %known_build_essential = map { $_ = 1 }
 ('libc6-dev', 'libc-dev', 'gcc', 'g++', 'make', 'dpkg-dev');
 
-%known_obsolete_packages = map { $_ = 1 }
-('libstdc++2.8', 'ncurses3.4', 'slang0.99.38', 'newt0.25', 'mesag2',
- 'libjpegg6a', 'gmp2', 'libgtop0', 'libghttp0', 'libpgsql', 'tk4.2',
- 'tcl7.6', 'libpng0g', 'xbase', 'xlibs-dev', 'debmake', 'gcc-2.95');
-
 # Still in the archive but shouldn't be the primary Emacs dependency.
 %known_obsolete_emacs = map { $_ = 1 }
 ('emacs21');

Modified: trunk/checks/fields
===
--- trunk/checks/fields 2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/checks/fields 2008-06-06 23:56:59 UTC (rev 1345)
@@ -24,11 +24,13 @@
 
 package Lintian::fields;
 use strict;
+
 use lib $ENV{'LINTIAN_ROOT'}/checks/;
 use common_data;
 use Dep;
 use Tags;
 use Util;
+use Lintian::Data;
 
 # The allowed Python dependencies currently.  This is the list of alternatives
 # that, either directly or through transitive dependencies that can be relied
@@ -121,6 +123,9 @@
 my $version;
 my $arch_indep;
 
+# Load obsolete packages list.
+my $obsolete_packages = Lintian::Data-new ('fields/obsolete-packages');
+
 local $/ = undef; #Read everything in one go
 
 unless (-d fields) {
@@ -494,7 +499,7 @@
if $rest;
 
tag depends-on-obsolete-package, 
$field: $part_d_orig
-   if 
($known_obsolete_packages{$d_pkg}  $is_dep_field($field));
+   if 
($obsolete_packages-known($d_pkg)  $is_dep_field($field));
 
tag depends-on-x-metapackage, 
$field: $part_d_orig
if ($known_x_metapackages{$d_pkg} 
 ! $metapackage  $is_dep_field($field));
@@ -683,7 +688,7 @@
tag 
build-depends-on-essential-package-without-using-version, $field: 
$part_d_orig
if ($d_pkg ne coreutils  
$known_essential{$d_pkg}  ! $d_version-[0]);
tag 
build-depends-on-obsolete-package, $field: $part_d_orig
-   if 
($known_obsolete_packages{$d_pkg}  $is_dep_field($field));
+   if 
($obsolete_packages-known($d_pkg)  $is_dep_field($field));
 
tag build-depends-on-x-metapackage, 
$field: $part_d_orig
if ($known_x_metapackages{$d_pkg} 
 $is_dep_field($field));

Added: trunk/data/fields/obsolete-packages
===
--- trunk/data/fields/obsolete-packages (rev 0)
+++ trunk/data/fields/obsolete-packages 2008-06-06 23:56:59 UTC (rev 1345)
@@ -0,0 +1,45 @@
+# Known obsolete packages.  Not all packages are added to this list, only
+# ones for which it's helpful for Lintian to warn about, such as
+# significant transitions or transitional packages that we're trying to
+# remove from the archive.
+#
+# Each list of packages should be tagged with the last Debian release in
+# which the package appeared so that we can remove long-obsolete entries
+# that are no longer worth checking for.
+
+# Last seen in sarge.
+xlibs-dev
+
+# Last seen in etch.
+debmake
+gcc-2.95
+
+# Last seen in lenny.
+cdrecord
+gaim
+gnomemeeting
+gs
+gs-aladdin
+gs-esp
+gs-gpl
+libglu1-xorg
+libglu1-xorg-dev
+libmime-perl
+libungif4-dev
+libxerces28
+libxerces28-dev
+mailx
+mkisofs
+netcdfg-dev
+pcmcia-cs
+python-pyopenssl
+ssh-krb5
+tetex-base
+tetex-bin
+tetex-extra
+x-dev
+xbase-clients
+xlibmesa-gl
+xlibmesa-gl-dev
+xlibmesa-glu
+xutils

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-06 23:29:03 UTC (rev 1344)
+++ trunk/debian/changelog  2008-06-06 23:56:59 UTC (rev 1345)
@@ -4,6 +4,7 @@
 + [RA] Fix code

lintian: r1346 - in trunk: checks debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 01:58:09 +0200 (Sat, 07 Jun 2008)
New Revision: 1346

Modified:
   trunk/checks/manpages.desc
   trunk/debian/changelog
Log:
* checks/manpages{.desc,}:
  + [RA] Mention in binary-without-manpage that the case of the man page
should match the case of the binary even if man can find it anyway.
(Closes: #484028)

Modified: trunk/checks/manpages.desc
===
--- trunk/checks/manpages.desc  2008-06-06 23:56:59 UTC (rev 1345)
+++ trunk/checks/manpages.desc  2008-06-06 23:58:09 UTC (rev 1346)
@@ -41,6 +41,10 @@
  manual page is sufficient) because other manual page viewers such as
  xman or tkman don't support this.
  .
+ If the name of the man page differs from the binary by case, man may
+ be able to find it anyway; however, it is still best practice to make the
+ case of the man page match the case of the binary.
+ .
  If the man pages are provided by another package on which this package
  depends, lintian may not be able to determine that man pages are
  available.  In this case, after confirming that all binaries do have

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-06 23:56:59 UTC (rev 1345)
+++ trunk/debian/changelog  2008-06-06 23:58:09 UTC (rev 1346)
@@ -23,7 +23,7 @@
   * checks/init.d:
 + [RA] Try to allow for postinst scripts written in Perl and still
   recognize the update-rc.d calls.
-  * checks/manpages:
+  * checks/manpages{.desc,}:
 + [RA] Only ignore errors about wrapping lines for Asian locale man
   pages, since that's where the groff trouble lies.  Ignore character
   set errors for all man pages with old versions of man and no man
@@ -32,6 +32,9 @@
 + [FL] Ignore more unicode issues with old man.
 + [RA] Warn about inclusion of the country name in the localized man
   page directory unless it's one of the known exceptions.
++ [RA] Mention in binary-without-manpage that the case of the man page
+  should match the case of the binary even if man can find it anyway.
+  (Closes: #484028)
   * checks/md5sums:
 + [FL] Don't complain about missing md5sums file if the
   package only contains conffiles.  (Closes: #482869)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1348 - in trunk: checks debian testset testset/maintainer-scripts/debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 02:07:24 +0200 (Sat, 07 Jun 2008)
New Revision: 1348

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
   trunk/testset/maintainer-scripts/debian/postinst
   trunk/testset/tags.maintainer-scripts
Log:
* checks/scripts:
  + [RA] Catch deprecated chown syntax even when options are given to
chown.  Patch by Raphael Geissert.  (Closes: #483775)

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-06-07 00:01:08 UTC (rev 1347)
+++ trunk/checks/scripts2008-06-07 00:07:24 UTC (rev 1348)
@@ -635,7 +635,7 @@
tag 'start-stop-daemon-in-maintainer-script', $file:$.;
}
# Don't use chown foo.bar
-   if (/(chown\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+/) {
+   if 
(/(chown(\s+--?[A-Za-z-]+)*\s+[-_A-Za-z0-9]+\.[-_A-Za-z0-9]+)\s+/) {
tag deprecated-chown-usage, $file:$. \'$1\';
}
if (/invoke-rc.d.*\|\| exit 0/) {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:01:08 UTC (rev 1347)
+++ trunk/debian/changelog  2008-06-07 00:07:24 UTC (rev 1348)
@@ -47,6 +47,9 @@
   * checks/rules{.desc,}:
 + [RA] Add some basic checks for whether debhelper programs are called
   in a reasonable order.  (Closes: #471869)
+  * checks/scripts:
++ [RA] Catch deprecated chown syntax even when options are given to
+  chown.  Patch by Raphael Geissert.  (Closes: #483775)
   * checks/standards-version:
 + [RA] Policy 3.8.0 is now current and anything older than 3.7.2 is
   now ancient.

Modified: trunk/testset/maintainer-scripts/debian/postinst
===
--- trunk/testset/maintainer-scripts/debian/postinst2008-06-07 00:01:08 UTC 
(rev 1347)
+++ trunk/testset/maintainer-scripts/debian/postinst2008-06-07 00:07:24 UTC 
(rev 1348)
@@ -133,3 +133,6 @@
 
 # But stopping it is fine -- we may be working around something else.
 start-stop-daemon --stop --quiet --name foo --startas /usr/bin/foo
+
+# Deprecated chown use with flags.
+chown -R root.root /usr/share/doc/maintainer-scripts

Modified: trunk/testset/tags.maintainer-scripts
===
--- trunk/testset/tags.maintainer-scripts   2008-06-07 00:01:08 UTC (rev 
1347)
+++ trunk/testset/tags.maintainer-scripts   2008-06-07 00:07:24 UTC (rev 
1348)
@@ -37,6 +37,7 @@
 W: maintainer-scripts: ancient-dpkg-multi-conrep-check preinst:10
 W: maintainer-scripts: ancient-dpkg-predepends-check preinst:7
 W: maintainer-scripts: config-does-not-load-confmodule
+W: maintainer-scripts: deprecated-chown-usage postinst:138 'chown -R root.root'
 W: maintainer-scripts: deprecated-chown-usage postinst:33 'chown root.root'
 W: maintainer-scripts: gconftool-used-in-maintainer-script postinst:68
 W: maintainer-scripts: init.d-script-not-marked-as-conffile /etc/init.d/foo


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1349 - in trunk: checks debian testset testset/filenames/debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 02:14:01 +0200 (Sat, 07 Jun 2008)
New Revision: 1349

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/filenames/debian/rules
   trunk/testset/tags.filenames
Log:
* checks/filenames{.desc,}:
  + [RA] Warn about BTS data directories in packages (.be and
.ditrack).  Patch by Ben Finney.  (Closes: #481787)

Modified: trunk/checks/files
===
--- trunk/checks/files  2008-06-07 00:07:24 UTC (rev 1348)
+++ trunk/checks/files  2008-06-07 00:14:01 UTC (rev 1349)
@@ -757,6 +757,9 @@
|| ($file =~ m,/\{arch\}/?$,)) {
tag package-contains-vcs-control-dir, $file;
}
+   if ($file =~ m,/\.(be|ditrack)/?$,) {
+   tag package-contains-bts-control-dir, $file;
+   }
if ($file =~ m,/.xvpics/?$,) {
tag package-contains-xvpics-dir, $file;
}

Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2008-06-07 00:07:24 UTC (rev 1348)
+++ trunk/checks/files.desc 2008-06-07 00:14:01 UTC (rev 1349)
@@ -578,6 +578,12 @@
  .
  A better solution might be using symlinks here.
 
+Tag: package-contains-bts-control-dir
+Type: warning
+Info: The package contains a control directory for a bug tracking system.
+ It was most likely installed by accident, since bug tracking directories
+ usually don't belong in packages.
+
 Tag: package-contains-vcs-control-dir
 Type: warning
 Info: The package contains a control directory for a version control system.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:07:24 UTC (rev 1348)
+++ trunk/debian/changelog  2008-06-07 00:14:01 UTC (rev 1349)
@@ -23,6 +23,9 @@
   a version.  Check that Breaks is not inconsistent with other
   dependency fields.
 + [RA] Use Lintian::Data to load the obsolete package list.
+  * checks/filenames{.desc,}:
++ [RA] Warn about BTS data directories in packages (.be and
+  .ditrack).  Patch by Ben Finney.  (Closes: #481787)
   * checks/init.d:
 + [RA] Try to allow for postinst scripts written in Perl and still
   recognize the update-rc.d calls.

Modified: trunk/testset/filenames/debian/rules
===
--- trunk/testset/filenames/debian/rules2008-06-07 00:07:24 UTC (rev 
1348)
+++ trunk/testset/filenames/debian/rules2008-06-07 00:14:01 UTC (rev 
1349)
@@ -52,6 +52,8 @@
mkdir debian/tmp/usr/lib/perl5/{arch}
mkdir debian/tmp/usr/lib/perl5/.arch-ids
mkdir debian/tmp/usr/lib/perl5/.bzr
+   mkdir debian/tmp/usr/lib/perl5/.be
+   mkdir debian/tmp/usr/lib/perl5/.ditrack
install -d debian/tmp/usr/share/perl5
echo foo  debian/tmp/usr/lib/perl5/foo/.gitignore
echo foo  debian/tmp/usr/lib/perl5/foo/.hgignore

Modified: trunk/testset/tags.filenames
===
--- trunk/testset/tags.filenames2008-06-07 00:07:24 UTC (rev 1348)
+++ trunk/testset/tags.filenames2008-06-07 00:14:01 UTC (rev 1349)
@@ -85,9 +85,13 @@
 W: filenames: no-priority-field
 W: filenames: no-section-field
 W: filenames: non-standard-dir-perm usr/lib/filenames/readonly/ 0555 != 0755
+W: filenames: package-contains-bts-control-dir usr/lib/perl5/.be/
+W: filenames: package-contains-bts-control-dir usr/lib/perl5/.ditrack/
 W: filenames: package-contains-devhelp-file-without-symlink 
usr/share/doc/filenames/bad-devhelp/c.devhelp.gz
 W: filenames: package-contains-empty-directory usr/lib/perl5/.arch-ids/
+W: filenames: package-contains-empty-directory usr/lib/perl5/.be/
 W: filenames: package-contains-empty-directory usr/lib/perl5/.bzr/
+W: filenames: package-contains-empty-directory usr/lib/perl5/.ditrack/
 W: filenames: package-contains-empty-directory usr/lib/perl5/.svn/
 W: filenames: package-contains-empty-directory usr/lib/perl5/CVS/
 W: filenames: package-contains-empty-directory usr/lib/perl5/{arch}/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1350 - in trunk: checks debian testset

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 02:16:47 +0200 (Sat, 07 Jun 2008)
New Revision: 1350

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
   trunk/testset/tags.maintainer-scripts
Log:
  + [RA] $((var+1)) now works in dash and is in POSIX, so remove it from
bashisms.  Patch by Adam D. Barratt.  (Closes: #473156)

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-06-07 00:14:01 UTC (rev 1349)
+++ trunk/checks/scripts2008-06-07 00:16:47 UTC (rev 1350)
@@ -571,7 +571,6 @@
  '(\|\)\s*((-|\d+)[^\s;|\)\`]|[^-\d])', # should be word 
21
  '\[\[(?!:)', # alternative test command
  '(?:^|\s+)select\s+\w+', # 'select' is not POSIX
- '\$\(\([A-Za-z]',# cnt=$((cnt + 1)) does not work 
in dash
  '(?:^|\s+)echo\s+-e',# echo -e
  '(?:^|\s+)exec\s+-[acl]',# exec -c/-l/-a name
  '(?:^|\s+)let\s',# let ...

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:14:01 UTC (rev 1349)
+++ trunk/debian/changelog  2008-06-07 00:16:47 UTC (rev 1350)
@@ -53,6 +53,8 @@
   * checks/scripts:
 + [RA] Catch deprecated chown syntax even when options are given to
   chown.  Patch by Raphael Geissert.  (Closes: #483775)
++ [RA] $((var+1)) now works in dash and is in POSIX, so remove it from
+  bashisms.  Patch by Adam D. Barratt.  (Closes: #473156)
   * checks/standards-version:
 + [RA] Policy 3.8.0 is now current and anything older than 3.7.2 is
   now ancient.

Modified: trunk/testset/tags.maintainer-scripts
===
--- trunk/testset/tags.maintainer-scripts   2008-06-07 00:14:01 UTC (rev 
1349)
+++ trunk/testset/tags.maintainer-scripts   2008-06-07 00:16:47 UTC (rev 
1350)
@@ -53,7 +53,6 @@
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:116 
'echo -e'
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:117 
'${!foo}'
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:119 
'select foo'
-W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:120 
'$((c'
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:122 '
exec -l'
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:123 '
exec -c'
 W: maintainer-scripts: possible-bashism-in-maintainer-script postinst:124 '
exec -a'


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1351 - in trunk: checks debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 02:19:29 +0200 (Sat, 07 Jun 2008)
New Revision: 1351

Modified:
   trunk/checks/fields
   trunk/debian/changelog
Log:
  + [RA] When checking whether a debug package has proper dependencies,
allow a dependency on any package name that starts the same as the
debug package up to the first dash.  This will hopefully produce
fewer false positives.  Thanks, Josselin Mouette.  (Closes: #476587)

Modified: trunk/checks/fields
===
--- trunk/checks/fields 2008-06-07 00:16:47 UTC (rev 1350)
+++ trunk/checks/fields 2008-06-07 00:19:29 UTC (rev 1351)
@@ -422,7 +422,7 @@
my (%deps, %fields, %parsed);
my $debugpackage = 0;
my ($debugbase, $debugfound);
-   if ($pkg =~ /^(.*)-dbg$/) {
+   if ($pkg =~ /^([^-]+)(?:-.*)?-dbg$/) {
$debugpackage = 1;
$debugbase = $1;
}

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:16:47 UTC (rev 1350)
+++ trunk/debian/changelog  2008-06-07 00:19:29 UTC (rev 1351)
@@ -23,6 +23,10 @@
   a version.  Check that Breaks is not inconsistent with other
   dependency fields.
 + [RA] Use Lintian::Data to load the obsolete package list.
++ [RA] When checking whether a debug package has proper dependencies,
+  allow a dependency on any package name that starts the same as the
+  debug package up to the first dash.  This will hopefully produce
+  fewer false positives.  Thanks, Josselin Mouette.  (Closes: #476587)
   * checks/filenames{.desc,}:
 + [RA] Warn about BTS data directories in packages (.be and
   .ditrack).  Patch by Ben Finney.  (Closes: #481787)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1352 - in trunk: checks debian testset testset/dh7-minimal testset/dh7-minimal/debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 02:37:13 +0200 (Sat, 07 Jun 2008)
New Revision: 1352

Added:
   trunk/testset/dh7-minimal/
   trunk/testset/dh7-minimal/debian/
   trunk/testset/dh7-minimal/debian/changelog
   trunk/testset/dh7-minimal/debian/compat
   trunk/testset/dh7-minimal/debian/control
   trunk/testset/dh7-minimal/debian/copyright
   trunk/testset/dh7-minimal/debian/rules
   trunk/testset/tags.dh7-minimal
Modified:
   trunk/checks/rules
   trunk/debian/changelog
Log:
  + [RA] Support pattern rules.  (Closes: #483475)

Modified: trunk/checks/rules
===
--- trunk/checks/rules  2008-06-07 00:19:29 UTC (rev 1351)
+++ trunk/checks/rules  2008-06-07 00:37:13 UTC (rev 1352)
@@ -124,10 +124,18 @@
 }
 }
 
-if (/^([^\s:][^:]+):/) {
+if (/^([^\s:][^:]*):/) {
@current_targets = split (' ', $1);
for (@current_targets) {
-   $seen{$_}++ if $required{$_};
+if (m/%/) {
+my $pattern = quotemeta $_;
+$pattern =~ s/\\%/.*/g;
+for my $target (keys %required) {
+$seen{$target}++ if $target =~ m/$pattern/;
+}
+} else {
+$seen{$_}++ if $required{$_};
+}
}
 $debhelper_group = 0;
 } else {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:19:29 UTC (rev 1351)
+++ trunk/debian/changelog  2008-06-07 00:37:13 UTC (rev 1352)
@@ -54,6 +54,7 @@
   * checks/rules{.desc,}:
 + [RA] Add some basic checks for whether debhelper programs are called
   in a reasonable order.  (Closes: #471869)
++ [RA] Support pattern rules.  (Closes: #483475)
   * checks/scripts:
 + [RA] Catch deprecated chown syntax even when options are given to
   chown.  Patch by Raphael Geissert.  (Closes: #483775)

Added: trunk/testset/dh7-minimal/debian/changelog
===
--- trunk/testset/dh7-minimal/debian/changelog  (rev 0)
+++ trunk/testset/dh7-minimal/debian/changelog  2008-06-07 00:37:13 UTC (rev 
1352)
@@ -0,0 +1,6 @@
+dh7-minimal (1) unstable; urgency=low
+
+  * Initial release
+
+ -- Russ Allbery [EMAIL PROTECTED]  Fri, 06 Jun 2008 17:20:53 -0700
+

Added: trunk/testset/dh7-minimal/debian/compat
===
--- trunk/testset/dh7-minimal/debian/compat (rev 0)
+++ trunk/testset/dh7-minimal/debian/compat 2008-06-07 00:37:13 UTC (rev 
1352)
@@ -0,0 +1 @@
+7

Added: trunk/testset/dh7-minimal/debian/control
===
--- trunk/testset/dh7-minimal/debian/control(rev 0)
+++ trunk/testset/dh7-minimal/debian/control2008-06-07 00:37:13 UTC (rev 
1352)
@@ -0,0 +1,12 @@
+Source: dh7-minimal
+Section: devel
+Priority: optional
+Maintainer: Russ Allbery [EMAIL PROTECTED]
+Build-Depends: debhelper (= 7)
+Standards-Version: 3.9.0
+
+Package: dh7-test
+Architecture: all
+Depends: ${shlibs:Depends}, ${misc:Depends}
+Description: Checks related to debhelper rule minimization
+ New in debhelper 7.

Added: trunk/testset/dh7-minimal/debian/copyright
===
--- trunk/testset/dh7-minimal/debian/copyright  (rev 0)
+++ trunk/testset/dh7-minimal/debian/copyright  2008-06-07 00:37:13 UTC (rev 
1352)
@@ -0,0 +1 @@
+Copyright 2008 Russ Allbery

Added: trunk/testset/dh7-minimal/debian/rules
===
--- trunk/testset/dh7-minimal/debian/rules  (rev 0)
+++ trunk/testset/dh7-minimal/debian/rules  2008-06-07 00:37:13 UTC (rev 
1352)
@@ -0,0 +1,3 @@
+#!/usr/bin/make -f
+%:
+   dh $@


Property changes on: trunk/testset/dh7-minimal/debian/rules
___
Name: svn:executable
   + *

Added: trunk/testset/tags.dh7-minimal
===
--- trunk/testset/tags.dh7-minimal  (rev 0)
+++ trunk/testset/tags.dh7-minimal  2008-06-07 00:37:13 UTC (rev 1352)
@@ -0,0 +1 @@
+W: dh7-minimal source: newer-standards-version 3.9.0 (current is 3.8.0)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1353 - in trunk: checks debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 02:48:49 +0200 (Sat, 07 Jun 2008)
New Revision: 1353

Modified:
   trunk/checks/cruft
   trunk/debian/changelog
Log:
* checks/cruft:
  + [RA] Format: 3.0 (quilt) packages are not native even though they
have no *.diff.gz.  Thanks, Raphael Hertzog.  (Closes: #483384)

Modified: trunk/checks/cruft
===
--- trunk/checks/cruft  2008-06-07 00:37:13 UTC (rev 1352)
+++ trunk/checks/cruft  2008-06-07 00:48:49 UTC (rev 1353)
@@ -92,14 +92,23 @@
 
 # This doens't really belong here, but there isn't a better place at the
 # moment to put this check.
-open (VERSION, '', fields/version)
-or fail(cannot open fields/version: $!);
-chomp(my $version = VERSION);
-close VERSION;
-$version =~ s/^\d+://; #Remove epoch
-$native = (! -f ${pkg}_${version}.diff.gz);
-if ($native and $version =~ /-/ and $version !~ /-0\.[^-]+$/) {
-tag 'native-package-with-dash-version';
+open (FORMAT, '', fields/format)
+or fail(cannot open fields/format: $!);
+my $format = FORMAT;
+chomp $format;
+close FORMAT;
+if ($format =~ /^\s*3\.0\s+\(quilt\)\s*$/) {
+$native = 0;
+} else {
+open (VERSION, '', fields/version)
+or fail(cannot open fields/version: $!);
+chomp(my $version = VERSION);
+close VERSION;
+$version =~ s/^\d+://; #Remove epoch
+$native = (! -f ${pkg}_${version}.diff.gz);
+if ($native and $version =~ /-/ and $version !~ /-0\.[^-]+$/) {
+tag 'native-package-with-dash-version';
+}
 }
 
 # Check if this is a documentation package that's not arch: all.  This doesn't

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:37:13 UTC (rev 1352)
+++ trunk/debian/changelog  2008-06-07 00:48:49 UTC (rev 1353)
@@ -15,6 +15,9 @@
   * checks/copyright-file{.desc,}:
 + [RA] Check for copyright files containing the Apache 2.0 license,
   which is now in common-licenses.
+  * checks/cruft:
++ [RA] Format: 3.0 (quilt) packages are not native even though they
+  have no *.diff.gz.  Thanks, Raphael Hertzog.  (Closes: #483384)
   * checks/fields:
 + [RA] Syntax-check Breaks like other relationship fields.  Warn if
   any packages use Breaks for right now.  Only check for duplicate


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1354 - in trunk: checks debian

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 02:49:18 +0200 (Sat, 07 Jun 2008)
New Revision: 1354

Modified:
   trunk/checks/nmu
   trunk/debian/changelog
Log:
  + [RA] Binary NMUs of QA-maintained packages are fine.

Modified: trunk/checks/nmu
===
--- trunk/checks/nmu2008-06-07 00:48:49 UTC (rev 1353)
+++ trunk/checks/nmu2008-06-07 00:49:18 UTC (rev 1354)
@@ -90,7 +90,7 @@
tag orphaned-package-should-not-have-uploaders, 
if defined $uploaders;
tag qa-upload-has-incorrect-version-number, $version
-   if $version_nmuness;
+   if $version_nmuness == 1;
tag changelog-should-mention-qa, 
if !$changelog_mentions_qa;
 } else {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:48:49 UTC (rev 1353)
+++ trunk/debian/changelog  2008-06-07 00:49:18 UTC (rev 1354)
@@ -54,6 +54,7 @@
   * checks/nmu:
 + [RA] Don't treat Ack NMU as an NMU declaration.  Thanks, Joe
   Nahmias.  (Closes: #484600)
++ [RA] Binary NMUs of QA-maintained packages are fine.
   * checks/rules{.desc,}:
 + [RA] Add some basic checks for whether debhelper programs are called
   in a reasonable order.  (Closes: #471869)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1355 - in trunk: debian reporting reporting/images reporting/templates

2008-06-06 Thread rra

Author: rra
Date: 2008-06-07 05:32:17 +0200 (Sat, 07 Jun 2008)
New Revision: 1355

Added:
   trunk/reporting/images/
   trunk/reporting/images/ico.png
   trunk/reporting/images/l.png
   trunk/reporting/images/logo-small.png
Modified:
   trunk/debian/changelog
   trunk/reporting/html_reports
   trunk/reporting/lintian.css
   trunk/reporting/templates/clean.tmpl
   trunk/reporting/templates/index.tmpl
   trunk/reporting/templates/maintainer.tmpl
   trunk/reporting/templates/maintainers.tmpl
   trunk/reporting/templates/packages.tmpl
   trunk/reporting/templates/tag.tmpl
   trunk/reporting/templates/tags.tmpl
Log:
* reporting/html_reports:
  + [RA] Copy over images.  Set the maintainer name to Unknown
Maintainer if not known.  Pass the code for a tag into the per-tag
page.  Based on a patch by Jord?\195?\160 Polo.
* reporting/images/*:
  + [RA] New logo images from Jord?\195?\160 Polo.
* reporting/lintian.css:
  + [RA] Significant overhaul of the lintian.d.o design by Jord?\195?\160 Polo.
* reporting/templates/*:
  + [RA] Significant overhaul of the lintian.d.o design by Jord?\195?\160 Polo.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-07 00:49:18 UTC (rev 1354)
+++ trunk/debian/changelog  2008-06-07 03:32:17 UTC (rev 1355)
@@ -76,6 +76,16 @@
   * debian/control:
 + [RA] Update standards version to 3.8.0.
   
+  * reporting/html_reports:
++ [RA] Copy over images.  Set the maintainer name to Unknown
+  Maintainer if not known.  Pass the code for a tag into the per-tag
+  page.  Based on a patch by Jordà Polo.
+  * reporting/images/*:
++ [RA] New logo images from Jordà Polo.
+  * reporting/lintian.css:
++ [RA] Significant overhaul of the lintian.d.o design by Jordà Polo.
+  * reporting/templates/*:
++ [RA] Significant overhaul of the lintian.d.o design by Jordà Polo.
   * reporting/templates/clean.tmpl:
 + [FL] Include link to full maintainer report.  Suggested by
   Kartik Mistry.

Modified: trunk/reporting/html_reports
===
--- trunk/reporting/html_reports2008-06-07 00:49:18 UTC (rev 1354)
+++ trunk/reporting/html_reports2008-06-07 03:32:17 UTC (rev 1355)
@@ -108,6 +108,10 @@
 or die cannot create output directory $HTML_TMP_DIR/tags: $!\n;
 copy($LINTIAN_ROOT/reporting/lintian.css, $HTML_TMP_DIR/lintian.css)
 or die cannot copy lintian.css to $HTML_TMP_DIR: $!\n;
+for my $image (qw/ico.png l.png logo-small.png/) {
+copy($LINTIAN_ROOT/reporting/images/$image, $HTML_TMP_DIR/$image)
+or die cannot copy images/$image to $HTML_TMP_DIR: $!\n;
+}
 
 # This variable will accumulate statistics.  For tags: errors, warnings,
 # experimental, overridden, and info are the keys holding the count of tags of
@@ -320,6 +324,7 @@
 # Determine the parts of the maintainer and the file name for the
 # maintainer page.
 my ($name, $email) = ($maintainer =~ /^(.*) ([^]+)/);
+$name = 'Unknown Maintainer' unless $name;
 $email = 'unknown' unless $email;
 my $regular = maintainer/$id;
 my $full = full/$id;
@@ -398,6 +403,7 @@
 my %data = (
 description = $description,
 tag = html_quote ($tag),
+code= $by_tag{$tag}[0]-{code},
 tags= $by_tag{$tag},
 timestamp   = $timestamp,
 version = $LINTIAN_VERSION

Added: trunk/reporting/images/ico.png
===
(Binary files differ)


Property changes on: trunk/reporting/images/ico.png
___
Name: svn:mime-type
   + image/png

Added: trunk/reporting/images/l.png
===
(Binary files differ)


Property changes on: trunk/reporting/images/l.png
___
Name: svn:mime-type
   + image/png

Added: trunk/reporting/images/logo-small.png
===
(Binary files differ)


Property changes on: trunk/reporting/images/logo-small.png
___
Name: svn:mime-type
   + image/png

Modified: trunk/reporting/lintian.css
===
--- trunk/reporting/lintian.css 2008-06-07 00:49:18 UTC (rev 1354)
+++ trunk/reporting/lintian.css 2008-06-07 03:32:17 UTC (rev 1355)
@@ -1,9 +1,337 @@
 /* lintian.css -- Style sheet for lintian.debian.org pages. */
 
-h1 {
+/*
+ # Table of Contents:
+ #
+ # 1. General styles (links, lists, titles, tables...)
+ # 2. Header
+ # 3. Navigation
+ # 4. Main content
+ # 5. Footer
+ # 6. Other
+ */
+
+/*
+ # Order:
+ #
+ # example {
+ #   display
+ #   position
+ #   width
+ #   height
+ #   margin
+ #   padding
+ #   background
+ #   color

lintian: r1332 - in trunk: checks debian

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 02:47:48 +0200 (Thu, 05 Jun 2008)
New Revision: 1332

Modified:
   trunk/checks/standards-version
   trunk/debian/changelog
   trunk/debian/control
Log:
* checks/standards-version:
  + [RA] Policy 3.8.0 is now current and anything older than 3.7.2 is
now ancient.
* debian/control:
  + [RA] Update standards version to 3.8.0.

Modified: trunk/checks/standards-version
===
--- trunk/checks/standards-version  2008-06-03 17:14:09 UTC (rev 1331)
+++ trunk/checks/standards-version  2008-06-05 00:47:48 UTC (rev 1332)
@@ -29,11 +29,12 @@
 # 2 means old
 # 3 means ancient
 my %valid_standard = (
-  '3.7.3', 1,
+  '3.8.0', 1,
+  '3.7.3', 2,
   '3.7.2', 2,
   '3.7.1', 2,
   '3.7.0', 2,
-  '3.6.2', 2,
+  '3.6.2', 3,
   '3.6.1', 3,
   '3.6.0', 3,
   '3.5.10', 3,
@@ -71,8 +72,8 @@
 
 # version lintian is programmed for. ($valid_standard[0]?)
 my $MAJOR = 3;
-my $MINOR = 7;
-my $PATCH = 3;
+my $MINOR = 8;
+my $PATCH = 0;
 
 my $pkg = shift;
 my $type = shift;
@@ -134,4 +135,8 @@
 
 1;
 
-# vim: syntax=perl
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 ts=8

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-03 17:14:09 UTC (rev 1331)
+++ trunk/debian/changelog  2008-06-05 00:47:48 UTC (rev 1332)
@@ -12,6 +12,12 @@
   * checks/rules{.desc,}:
 + [RA] Add some basic checks for whether debhelper programs are called
   in a reasonable order.  (Closes: #471869)
+  * checks/standards-version:
++ [RA] Policy 3.8.0 is now current and anything older than 3.7.2 is
+  now ancient.
+
+  * debian/control:
++ [RA] Update standards version to 3.8.0.
   
   * reporting/templates/clean.tmpl:
 + [FL] Include link to full maintainer report.  Suggested by

Modified: trunk/debian/control
===
--- trunk/debian/control2008-06-03 17:14:09 UTC (rev 1331)
+++ trunk/debian/control2008-06-05 00:47:48 UTC (rev 1332)
@@ -9,7 +9,7 @@
  Colin Watson [EMAIL PROTECTED], Russ Allbery [EMAIL PROTECTED]
 Build-Depends: debhelper (= 5)
 Build-Depends-Indep: debiandoc-sgml, sed (= 4.1-4)
-Standards-Version: 3.7.3
+Standards-Version: 3.8.0
 Vcs-Svn: http://svn.wolffelaar.nl/lintian/trunk/
 Vcs-Browser: http://svn.wolffelaar.nl/wsvn/lintian/
 
@@ -36,4 +36,4 @@
  should check packages with this tool before uploading them to the
  archive.
  .
- This version of Lintian is calibrated for policy version 3.7.3.
+ This version of Lintian is calibrated for policy version 3.8.0.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1333 - trunk/checks

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 02:52:02 +0200 (Thu, 05 Jun 2008)
New Revision: 1333

Modified:
   trunk/checks/control-file
Log:
Fix formatting to make it consistent.


Modified: trunk/checks/control-file
===
--- trunk/checks/control-file   2008-06-05 00:47:48 UTC (rev 1332)
+++ trunk/checks/control-file   2008-06-05 00:52:02 UTC (rev 1333)
@@ -87,20 +87,20 @@
 # another problem.
 my @dep_fields = qw(pre-depends depends recommends suggests);
 for my $control (@binary_controls) {
-for my $strong (0 .. ($#dep_fields - 1)) {
-next unless $control-{$dep_fields[$strong]};
-my $parsed = Dep::parse ($control-{$dep_fields[$strong]});
-tag package-depends-on-itself, $control-{package}, 
$dep_fields[$strong]
-if Dep::implies($parsed, Dep::parse($control-{package}));
-for my $weak (($strong + 1) .. $#dep_fields) {
-next unless $control-{$dep_fields[$weak]};
-for my $dependency (split /\s*,\s*/, 
$control-{$dep_fields[$weak]}) {
-next unless $dependency;
-tag stronger-dependency-implies-weaker, $control-{package}, 
$dep_fields[$strong] - $dep_fields[$weak], $dependency
-if Dep::implies($parsed, Dep::parse($dependency));
-}
-}
-}
+   for my $strong (0 .. ($#dep_fields - 1)) {
+   next unless $control-{$dep_fields[$strong]};
+   my $parsed = Dep::parse ($control-{$dep_fields[$strong]});
+   tag package-depends-on-itself, $control-{package}, 
$dep_fields[$strong]
+   if Dep::implies($parsed, Dep::parse($control-{package}));
+   for my $weak (($strong + 1) .. $#dep_fields) {
+   next unless $control-{$dep_fields[$weak]};
+   for my $dependency (split /\s*,\s*/, 
$control-{$dep_fields[$weak]}) {
+   next unless $dependency;
+   tag stronger-dependency-implies-weaker, 
$control-{package}, $dep_fields[$strong] - $dep_fields[$weak], $dependency
+   if Dep::implies($parsed, 
Dep::parse($dependency));
+   }
+   }
+   }
 }
 
 # Check that every package is in the same archive category, except that
@@ -139,4 +139,8 @@
 
 1;
 
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 8
+# End:
 # vim: syntax=perl sw=4 ts=4 noet shiftround


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1334 - in trunk/testset: . copyright/debian description/debian dh7-test/debian relations/debian

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 03:21:28 +0200 (Thu, 05 Jun 2008)
New Revision: 1334

Modified:
   trunk/testset/copyright/debian/control
   trunk/testset/description/debian/control
   trunk/testset/dh7-test/debian/control
   trunk/testset/relations/debian/control
   trunk/testset/tags.binary
   trunk/testset/tags.debconf
   trunk/testset/tags.debug
   trunk/testset/tags.dh-test
   trunk/testset/tags.diffs
   trunk/testset/tags.etcfiles
   trunk/testset/tags.filenames
   trunk/testset/tags.foo++
   trunk/testset/tags.libbaz
   trunk/testset/tags.maintainer-scripts
   trunk/testset/tags.manpages
   trunk/testset/tags.non-us
   trunk/testset/tags.relations
   trunk/testset/tags.scripts
Log:
Update for the new standards version.


Modified: trunk/testset/copyright/debian/control
===
--- trunk/testset/copyright/debian/control  2008-06-05 00:52:02 UTC (rev 
1333)
+++ trunk/testset/copyright/debian/control  2008-06-05 01:21:28 UTC (rev 
1334)
@@ -4,7 +4,7 @@
 Maintainer: Lintian Maintainers [EMAIL PROTECTED]
 Uploaders: Tobias Toedter [EMAIL PROTECTED]
 Build-Depends-Indep: debhelper (5)
-Standards-Version: 3.7.3
+Standards-Version: 3.8.0
 
 Package: copyright.iso-8859-1
 Architecture: all

Modified: trunk/testset/description/debian/control
===
--- trunk/testset/description/debian/control2008-06-05 00:52:02 UTC (rev 
1333)
+++ trunk/testset/description/debian/control2008-06-05 01:21:28 UTC (rev 
1334)
@@ -3,7 +3,7 @@
 Priority: extra
 Maintainer: Lintian Maintainers [EMAIL PROTECTED]
 Uploaders: Tobias Toedter [EMAIL PROTECTED]
-Standards-Version: 3.7.3
+Standards-Version: 3.8.0
 
 Package: description
 Architecture: all

Modified: trunk/testset/dh7-test/debian/control
===
--- trunk/testset/dh7-test/debian/control   2008-06-05 00:52:02 UTC (rev 
1333)
+++ trunk/testset/dh7-test/debian/control   2008-06-05 01:21:28 UTC (rev 
1334)
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Lintian Maintainers debian-lint-maint@lists.debian.org
 Build-Depends: debhelper (= 6)
-Standards-Version: 3.7.3
+Standards-Version: 3.8.0
 
 Package: dh7-test
 Architecture: all

Modified: trunk/testset/relations/debian/control
===
--- trunk/testset/relations/debian/control  2008-06-05 00:52:02 UTC (rev 
1333)
+++ trunk/testset/relations/debian/control  2008-06-05 01:21:28 UTC (rev 
1334)
@@ -37,6 +37,7 @@
 Depends: libstdc++2.10, libstdc++2.10-glibc2.2, libstdc++3.0, tk8.2, tk8.3, 
tcl8.0, tcl8.2, tkx8.2, tkx8.3, tclx8.2, libpng2, libpng3, xorg, 
${shlibs:Depends}
 Provides: awk
 Recommends: ${shlibs:Depends}, relations-multiple-libs
+Breaks: libpng3 ( 1.0), libpng2
 Description: Duplicate library dependency relationships.
  Duplicate library dependency relationships.
  This tests the depending on different versions of the same library

Modified: trunk/testset/tags.binary
===
--- trunk/testset/tags.binary   2008-06-05 00:52:02 UTC (rev 1333)
+++ trunk/testset/tags.binary   2008-06-05 01:21:28 UTC (rev 1334)
@@ -50,7 +50,7 @@
 I: binary: desktop-entry-contains-encoding-key 
/usr/share/applications/goodbye.desktop:11 Encoding
 I: binary: desktop-entry-contains-encoding-key 
/usr/share/applications/hello.desktop:13 Encoding
 I: binary: no-md5sums-control-file
-W: binary source: ancient-standards-version 3.2.1 (current is 3.7.3)
+W: binary source: ancient-standards-version 3.2.1 (current is 3.8.0)
 W: binary source: debian-rules-ignores-make-clean-error line 12
 W: binary source: debian-rules-uses-pwd line 9
 W: binary source: maintainer-upload-has-incorrect-version-number 4-1.1

Modified: trunk/testset/tags.debconf
===
--- trunk/testset/tags.debconf  2008-06-05 00:52:02 UTC (rev 1333)
+++ trunk/testset/tags.debconf  2008-06-05 01:21:28 UTC (rev 1334)
@@ -19,7 +19,7 @@
 W: debconf source: misnamed-po-file debian/po/lang.po
 W: debconf source: misnamed-po-file debian/po/sample-file.po
 W: debconf source: newer-debconf-templates
-W: debconf source: out-of-date-standards-version 3.7.2 (current is 3.7.3)
+W: debconf source: out-of-date-standards-version 3.7.2 (current is 3.8.0)
 W: debconf source: stray-translated-debconf-templates debconf-test.templates.de
 W: debconf source: translated-default-field debconf-test.templates: 67
 W: debconf source: translated-default-field debconf-test.templates: 72

Modified: trunk/testset/tags.debug
===
--- trunk/testset/tags.debug2008-06-05 00:52:02 UTC (rev 1333)
+++ trunk/testset/tags.debug2008-06-05 01:21:28 UTC (rev 1334)
@@ -10,7 +10,7 @@
 W: debug source: changelog-should-not-mention-nmu
 W: debug source: debhelper-script

lintian: r1335 - trunk/testset

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 03:30:14 +0200 (Thu, 05 Jun 2008)
New Revision: 1335

Modified:
   trunk/testset/tags.cdbs-test
Log:
One more fix for the new Policy version.


Modified: trunk/testset/tags.cdbs-test
===
--- trunk/testset/tags.cdbs-test2008-06-05 01:21:28 UTC (rev 1334)
+++ trunk/testset/tags.cdbs-test2008-06-05 01:30:14 UTC (rev 1335)
@@ -4,5 +4,6 @@
 I: cdbs-test source: package-lacks-versioned-build-depends-on-debhelper 5
 W: cdbs-test source: native-package-with-dash-version
 W: cdbs-test source: no-human-maintainers
+W: cdbs-test source: out-of-date-standards-version 3.7.3 (current is 3.8.0)
 W: cdbs-test source: package-has-a-duplicate-build-relation cdbs, cdbs
 W: cdbs-test: debian-changelog-line-too-long line 1


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1336 - in trunk: checks debian testset

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 03:42:59 +0200 (Thu, 05 Jun 2008)
New Revision: 1336

Modified:
   trunk/checks/fields
   trunk/checks/fields.desc
   trunk/debian/changelog
   trunk/testset/tags.relations
Log:
* checks/fields:
  + [RA] Syntax-check Breaks like other relationship fields.  Warn if
any packages use Breaks for right now.  Only check for duplicate
libraries and Tcl versions in dependency fields, not Breaks,
Conflicts, and other similar fields.  Warn if Breaks is used without
a version.  Check that Breaks is not inconsistent with other
dependency fields.

Modified: trunk/checks/fields
===
--- trunk/checks/fields 2008-06-05 01:30:14 UTC (rev 1335)
+++ trunk/checks/fields 2008-06-05 01:42:59 UTC (rev 1336)
@@ -421,7 +421,7 @@
$debugpackage = 1;
$debugbase = $1;
}
-   for my $field (qw(depends pre-depends recommends suggests conflicts 
provides replaces)) {
+   for my $field (qw(depends pre-depends recommends suggests conflicts 
provides replaces breaks)) {
if (open(FH, '', fields/$field)) {
#Get data and clean it
my $data = FH;
@@ -434,6 +434,8 @@
 
my $is_dep_field = sub { grep { $_ eq $_[0] } 
qw(depends pre-depends recommends suggests) };
 
+   tag package-uses-breaks if $field eq breaks;
+
tag alternates-not-allowed, $field
if ($data =~ /\|/  ! $is_dep_field($field));
 
@@ -441,12 +443,20 @@
my @alternatives;
push @alternatives, [_split_dep($_), $_] for 
(split /\s*\|\s*/, $dep);
 
-   push @seen_libstdcs, $alternatives[0]-[0] if 
defined $known_libstdcs{$alternatives[0]-[0]};
-   push @seen_tcls, $alternatives[0]-[0] if 
defined $known_tcls{$alternatives[0]-[0]};
-   push @seen_tclxs, $alternatives[0]-[0] if 
defined $known_tclxs{$alternatives[0]-[0]};
-   push @seen_tks, $alternatives[0]-[0] if 
defined $known_tks{$alternatives[0]-[0]};
-   push @seen_tkxs, $alternatives[0]-[0] if 
defined $known_tkxs{$alternatives[0]-[0]};
-   push @seen_libpngs, $alternatives[0]-[0] if 
defined $known_libpngs{$alternatives[0]-[0]};
+   if ($is_dep_field($field)) {
+   push @seen_libstdcs, 
$alternatives[0]-[0]
+   if defined 
$known_libstdcs{$alternatives[0]-[0]};
+   push @seen_tcls, $alternatives[0]-[0]
+   if defined 
$known_tcls{$alternatives[0]-[0]};
+   push @seen_tclxs, $alternatives[0]-[0]
+   if defined 
$known_tclxs{$alternatives[0]-[0]};
+   push @seen_tks, $alternatives[0]-[0]
+   if defined 
$known_tks{$alternatives[0]-[0]};
+   push @seen_tkxs, $alternatives[0]-[0]
+   if defined 
$known_tkxs{$alternatives[0]-[0]};
+   push @seen_libpngs, 
$alternatives[0]-[0]
+   if defined 
$known_libpngs{$alternatives[0]-[0]};
+   }
 
# Only for (Pre-)?Depends.
tag 
virtual-package-depends-without-real-package-depends, $field: 
$alternatives[0]-[0]
@@ -468,6 +478,9 @@
tag versioned-provides, $part_d_orig
if ($field eq provides  
$d_version-[0]);
 
+   tag breaks-without-version, 
$part_d_orig
+   if ($field eq breaks  
!$d_version-[0]);
+
tag obsolete-relation-form, $field: 
$part_d_orig
if ($d_version  grep { 
$d_version-[0] eq $_ } (, ));
 
@@ -528,14 +541,15 @@
tag dbg-package-missing-depends, $debugbase
if ($debugpackage  !$debugfound);
 
-   # If Conflicts is set, make sure it's not inconsistent with the other
-   # dependency fields.
-   if ($fields{conflicts}) {
+   # If Conflicts or Breaks is set, make sure it's not inconsistent with
+   # the other dependency fields.
+   for my $conflict (qw/conflicts breaks/) {
+   next unless $fields{$conflict};
for my $field (qw(depends pre-depends recommends suggests)) {
next unless $parsed{$field};
-   for my $conflict (split

lintian: r1337 - in trunk: checks debian testset testset/copyright/debian

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 04:23:00 +0200 (Thu, 05 Jun 2008)
New Revision: 1337

Added:
   trunk/testset/copyright/debian/copyright.full-apache-2
Modified:
   trunk/checks/copyright-file
   trunk/checks/copyright-file.desc
   trunk/debian/changelog
   trunk/testset/copyright/debian/control
   trunk/testset/tags.copyright
Log:
* checks/copyright-file{.desc,}:
  + [RA] Check for copyright files containing the Apache 2.0 license,
which is now in common-licenses.

Modified: trunk/checks/copyright-file
===
--- trunk/checks/copyright-file 2008-06-05 01:42:59 UTC (rev 1336)
+++ trunk/checks/copyright-file 2008-06-05 02:23:00 UTC (rev 1337)
@@ -194,6 +194,12 @@
 tag copyright-file-contains-full-gfdl-license;
 }
 
+if (length($_)  1
+and m/\bApache License\s+Version 2\.0,/
+and m/TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION/) {
+tag copyright-file-contains-full-apache-2-license;
+}
+
 if (m/^This copyright info was automatically extracted from the perl 
module\./) {
 tag helper-templates-in-copyright, ;
 }

Modified: trunk/checks/copyright-file.desc
===
--- trunk/checks/copyright-file.desc2008-06-05 01:42:59 UTC (rev 1336)
+++ trunk/checks/copyright-file.desc2008-06-05 02:23:00 UTC (rev 1337)
@@ -52,6 +52,13 @@
  tt/usr/share/common-licenses/GFDL-1.2/tt instead.
 Ref: policy 12.5
 
+Tag: copyright-file-contains-full-apache-2-license
+Type: error
+Info: The copyright file /usr/share/doc/ipkg/i/copyright contains the
+ complete text of the Apache 2.0 license.  It should refer to the file
+ tt/usr/share/common-licenses/Apache-2.0/tt instead.
+Ref: policy 12.5
+
 Tag: usr-share-doc-symlink-without-dependency
 Type: error
 Info: If the package installs a symbolic link /usr/share/doc/ipkg1/i -gt;

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-05 01:42:59 UTC (rev 1336)
+++ trunk/debian/changelog  2008-06-05 02:23:00 UTC (rev 1337)
@@ -6,6 +6,9 @@
 + [RA] Check for self-dependencies in the source package since the
   current dpkg-gencontrol silently fixes them but they may indicate
   other problems.  Thanks, Patrick Matthäi.  (Closes: #471740)
+  * checks/copyright-file{.desc,}:
++ [RA] Check for copyright files containing the Apache 2.0 license,
+  which is now in common-licenses.
   * checks/fields:
 + [RA] Syntax-check Breaks like other relationship fields.  Warn if
   any packages use Breaks for right now.  Only check for duplicate

Modified: trunk/testset/copyright/debian/control
===
--- trunk/testset/copyright/debian/control  2008-06-05 01:42:59 UTC (rev 
1336)
+++ trunk/testset/copyright/debian/control  2008-06-05 02:23:00 UTC (rev 
1337)
@@ -21,6 +21,11 @@
 Description: checks inclusion of GFDL in full text
  This is just a sentence.
 
+Package: copyright.full-apache-2
+Architecture: all
+Description: checks inclusion of Apache 2.0 in full text
+ This is just a sentence.
+
 Package: copyright.misc-errors
 Architecture: all
 Description: checks various errors in copyright files

Added: trunk/testset/copyright/debian/copyright.full-apache-2
===
--- trunk/testset/copyright/debian/copyright.full-apache-2  
(rev 0)
+++ trunk/testset/copyright/debian/copyright.full-apache-2  2008-06-05 
02:23:00 UTC (rev 1337)
@@ -0,0 +1,202 @@
+
+ Apache License
+   Version 2.0, January 2004
+http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+  License shall mean the terms and conditions for use, reproduction,
+  and distribution as defined by Sections 1 through 9 of this document.
+
+  Licensor shall mean the copyright owner or entity authorized by
+  the copyright owner that is granting the License.
+
+  Legal Entity shall mean the union of the acting entity and all
+  other entities that control, are controlled by, or are under common
+  control with that entity. For the purposes of this definition,
+  control means (i) the power, direct or indirect, to cause the
+  direction or management of such entity, whether by contract or
+  otherwise, or (ii) ownership of fifty percent (50%) or more of the
+  outstanding shares, or (iii) beneficial ownership of such entity.
+
+  You (or Your) shall mean an individual or Legal Entity
+  exercising permissions granted by this License.
+
+  Source form shall mean the preferred form for making modifications,
+  including but not limited to software source code, documentation
+  source, and configuration files

lintian: r1338 - in trunk: checks debian testset/manpages testset/manpages/debian

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 06:22:31 +0200 (Thu, 05 Jun 2008)
New Revision: 1338

Added:
   trunk/testset/manpages/test.1p.utf-8
Modified:
   trunk/checks/manpages
   trunk/debian/changelog
   trunk/testset/manpages/debian/rules
Log:
* checks/manpages:
  + [RA] Only ignore errors about wrapping lines for Asian locale man
pages, since that's where the groff trouble lies.  Ignore character
set errors for all man pages with old versions of man and no man
pages with current versions of man since the new character set
handling should cope.  (Closes: #474052)

Modified: trunk/checks/manpages
===
--- trunk/checks/manpages   2008-06-05 02:23:00 UTC (rev 1337)
+++ trunk/checks/manpages   2008-06-05 04:22:31 UTC (rev 1338)
@@ -292,12 +292,15 @@
next if /^\s*$/;
# ignore errors from gzip, will be dealt with at other places
next if /^(man|gzip)/;
-   # ignore 8bit character errors on localized man pages
-   if ($lang ne ) {
-   next if /warning: can\'t find numbered character/;
+   # ignore wrapping failures for Asian man pages (groff problem)
+   if ($lang =~ /^(?:ja|ko|zh)/) {
next if /warning \[.*\]: cannot adjust line/;
next if /warning \[.*\]: can\'t break line/;
}
+   # ignore charset issues with old versions of man for all man pages
+   # since we can't know, with old versions, whether that was just a
+   # Unicode issue
+   next if !$MAN_WARNINGS  /warning: can\'t find numbered character/;
# ignore common undefined macros from pod2man  Perl 5.10
next if /warning: \`(Tr|IX)\' not defined/;
chomp;

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-05 02:23:00 UTC (rev 1337)
+++ trunk/debian/changelog  2008-06-05 04:22:31 UTC (rev 1338)
@@ -16,6 +16,12 @@
   Conflicts, and other similar fields.  Warn if Breaks is used without
   a version.  Check that Breaks is not inconsistent with other
   dependency fields.
+  * checks/manpages:
++ [RA] Only ignore errors about wrapping lines for Asian locale man
+  pages, since that's where the groff trouble lies.  Ignore character
+  set errors for all man pages with old versions of man and no man
+  pages with current versions of man since the new character set
+  handling should cope.  (Closes: #474052)
   * checks/md5sums:
 + [FL] Don't complain about missing md5sums file if the
   package only contains conffiles.  (Closes: #482869)

Modified: trunk/testset/manpages/debian/rules
===
--- trunk/testset/manpages/debian/rules 2008-06-05 02:23:00 UTC (rev 1337)
+++ trunk/testset/manpages/debian/rules 2008-06-05 04:22:31 UTC (rev 1338)
@@ -50,6 +50,9 @@
chmod 755 $(tmp)/usr/share/man/de/man1/binary-without-english-manpage.1
gzip -c9 test.1p.de 
$(tmp)/usr/share/man/de/man1/test-latin1-chars.1p.gz
 
+   install -d $(tmp)/usr/share/man/de_DE/man1
+   gzip -c9 test.1p.utf-8 
$(tmp)/usr/share/man/de_DE/man1/test-utf8-chars.1p.gz
+
gzip -c9 include.3 $(tmp)/usr/share/man/man3/include.3.gz
gzip -c9 included.3 $(tmp)/usr/share/man/man3/included.3.gz
 

Added: trunk/testset/manpages/test.1p.utf-8
===
--- trunk/testset/manpages/test.1p.utf-8(rev 0)
+++ trunk/testset/manpages/test.1p.utf-82008-06-05 04:22:31 UTC (rev 
1338)
@@ -0,0 +1,10 @@
+.IX Title TEST 1
+.TH TEST 1P 2004-12-18 Debian Project Debian GNU/Linux Handbuch
+.SH NAME
+\\fBTEST\fR \- Eine Test-Manpage mit .1P Erweiterung.
+.SH DESCRIPTION
+.IX Header DESCRIPTION
+\\fBTEST\fR tests lintian.
+.PP
+Diese Seite dient hauptsächlich dem Testen von latin1-Buchstaben, wie äöüß
+in Manpages.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1339 - in trunk: checks debian testset

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 06:34:24 +0200 (Thu, 05 Jun 2008)
New Revision: 1339

Modified:
   trunk/checks/manpages
   trunk/checks/manpages.desc
   trunk/debian/changelog
   trunk/testset/tags.manpages
Log:
  + [RA] Warn about inclusion of the country name in the localized man
page directory unless it's one of the known exceptions.

Modified: trunk/checks/manpages
===
--- trunk/checks/manpages   2008-06-05 04:22:31 UTC (rev 1338)
+++ trunk/checks/manpages   2008-06-05 04:34:24 UTC (rev 1339)
@@ -118,6 +118,13 @@
 my $lang = ;
$lang = $1 if $t =~ m,^/([^/]+)/man\d/$,o;
 
+# The country should not be part of the man page locale directory unless
+# it's one of the known cases where the language is significantly
+# different between countries.
+if ($lang =~ /_/  $lang !~ /^(pt_BR|zh_(CN|TW))$/) {
+   tag manpage-locale-dir-country-specific, $file;
+}
+
 my @pieces = split(/\./, $name);
 my $ext = pop @pieces;
 if ($ext ne 'gz') {

Modified: trunk/checks/manpages.desc
===
--- trunk/checks/manpages.desc  2008-06-05 04:22:31 UTC (rev 1338)
+++ trunk/checks/manpages.desc  2008-06-05 04:34:24 UTC (rev 1339)
@@ -240,3 +240,13 @@
  provide an english, only a translated manpage. Since english is fallback,
  shipping only a non-english man page leaves most users without a man page
  at all.
+
+Tag: manpage-locale-dir-country-specific
+Type: warning
+Ref: policy 12.1
+Info: This package installs a manual page in a locale directory that
+ includes the country name.  A country name should not be included in the
+ directory name unless it indicates a significant difference in the
+ language.  The known cases where country names are appropriate are pt_BR,
+ zh_CN, zh_TW, and zh_SG.  Please file a bug against Lintian if this is
+ another case where a country name is appropriate.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-05 04:22:31 UTC (rev 1338)
+++ trunk/debian/changelog  2008-06-05 04:34:24 UTC (rev 1339)
@@ -22,6 +22,8 @@
   set errors for all man pages with old versions of man and no man
   pages with current versions of man since the new character set
   handling should cope.  (Closes: #474052)
++ [RA] Warn about inclusion of the country name in the localized man
+  page directory unless it's one of the known exceptions.
   * checks/md5sums:
 + [FL] Don't complain about missing md5sums file if the
   package only contains conffiles.  (Closes: #482869)

Modified: trunk/testset/tags.manpages
===
--- trunk/testset/tags.manpages 2008-06-05 04:22:31 UTC (rev 1338)
+++ trunk/testset/tags.manpages 2008-06-05 04:34:24 UTC (rev 1339)
@@ -64,4 +64,5 @@
 W: manpages: manpage-has-errors-from-man usr/share/man/man1/test.1p.gz 12: 
warning: `dep' not defined (probable missing space after `de')
 W: manpages: manpage-has-errors-from-man usr/share/man/man3/included.3.gz 6: 
warning: `zY' not defined
 W: manpages: manpage-has-useless-whatis-entry usr/share/man/man1/true.1.gz
+W: manpages: manpage-locale-dir-country-specific 
usr/share/man/de_DE/man1/test-utf8-chars.1p.gz
 W: manpages: package-contains-empty-directory 
usr/share/man/man1/not-a-man-page.1.gz/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1340 - in trunk: checks debian

2008-06-04 Thread rra

Author: rra
Date: 2008-06-05 07:52:56 +0200 (Thu, 05 Jun 2008)
New Revision: 1340

Modified:
   trunk/checks/nmu
   trunk/debian/changelog
Log:
* checks/nmu:
  + [RA] Don't treat Ack NMU as an NMU declaration.  Thanks, Joe
Nahmias.  (Closes: #484600)

Modified: trunk/checks/nmu
===
--- trunk/checks/nmu2008-06-05 04:34:24 UTC (rev 1339)
+++ trunk/checks/nmu2008-06-05 05:52:56 UTC (rev 1340)
@@ -47,7 +47,7 @@
 while (CHANGELOG) {
if ($firstline) {
$changelog_mentions_nmu = 1
-   if (/\bnmu\b/i or /non-maintainer upload/i) and not 
/(ackno|confir|incorporat)/i;
+   if (/\bnmu\b/i or /non-maintainer upload/i) and not 
/(ackno|\back\b|confir|incorporat)/i;
$changelog_mentions_qa = 1 if /orphan/i or /qa (?:group 
)?upload/i;
$firstline = 0 if /^\s+\S/;
}

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-05 04:34:24 UTC (rev 1339)
+++ trunk/debian/changelog  2008-06-05 05:52:56 UTC (rev 1340)
@@ -27,6 +27,9 @@
   * checks/md5sums:
 + [FL] Don't complain about missing md5sums file if the
   package only contains conffiles.  (Closes: #482869)
+  * checks/nmu:
++ [RA] Don't treat Ack NMU as an NMU declaration.  Thanks, Joe
+  Nahmias.  (Closes: #484600)
   * checks/rules{.desc,}:
 + [RA] Add some basic checks for whether debhelper programs are called
   in a reasonable order.  (Closes: #471869)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1331 - in trunk: checks debian

2008-06-03 Thread rra

Author: rra
Date: 2008-06-03 19:14:09 +0200 (Tue, 03 Jun 2008)
New Revision: 1331

Modified:
   trunk/checks/common_data.pm
   trunk/debian/changelog
Log:
* checks/common_data.pm:
  + [RA] armel is now a standard architecture.

Modified: trunk/checks/common_data.pm
===
--- trunk/checks/common_data.pm 2008-06-03 01:18:41 UTC (rev 1330)
+++ trunk/checks/common_data.pm 2008-06-03 17:14:09 UTC (rev 1331)
@@ -33,7 +33,7 @@
 # From /usr/share/dpkg/archtable, included here to make lintian results
 # consistent no matter what dpkg one has installed.
 %known_archs = map { $_ = 1 }
-('i386', 'ia64', 'alpha', 'amd64', 'arm', 'hppa', 'm68k', 'mips',
+('i386', 'ia64', 'alpha', 'amd64', 'arm', 'armel', 'hppa', 'm68k', 'mips',
  'mipsel', 'powerpc', 's390', 'sparc', 'hurd-i386', 'any', 'all');
 
 # From /usr/share/dpkg/cputable, included here to make lintian results

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-03 01:18:41 UTC (rev 1330)
+++ trunk/debian/changelog  2008-06-03 17:14:09 UTC (rev 1331)
@@ -1,5 +1,7 @@
 lintian (1.23.50) unstable; urgency=low
 
+  * checks/common_data.pm:
++ [RA] armel is now a standard architecture.
   * checks/control-file{.desc,}:
 + [RA] Check for self-dependencies in the source package since the
   current dpkg-gencontrol silently fixes them but they may indicate


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1327 - trunk/testset/etcfiles/debian

2008-06-02 Thread rra

Author: rra
Date: 2008-06-02 23:31:54 +0200 (Mon, 02 Jun 2008)
New Revision: 1327

Added:
   trunk/testset/etcfiles/debian/conffiles.only
Log:
Add missing test suite file for md5sum check.


Added: trunk/testset/etcfiles/debian/conffiles.only
===
--- trunk/testset/etcfiles/debian/conffiles.only
(rev 0)
+++ trunk/testset/etcfiles/debian/conffiles.only2008-06-02 21:31:54 UTC 
(rev 1327)
@@ -0,0 +1,2 @@
+/etc/etcfiles/foo
+/etc/etcfiles/bar


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1329 - trunk/checks

2008-06-02 Thread rra

Author: rra
Date: 2008-06-03 00:02:51 +0200 (Tue, 03 Jun 2008)
New Revision: 1329

Modified:
   trunk/checks/rules
Log:
Help Emacs syntax highlighting.


Modified: trunk/checks/rules
===
--- trunk/checks/rules  2008-06-02 22:00:00 UTC (rev 1328)
+++ trunk/checks/rules  2008-06-02 22:02:51 UTC (rev 1329)
@@ -120,7 +120,7 @@
}
 } else {
#if we have non-empty, non-comment lines, store them for all current 
targets:
-   if (m/^\s+[^#]/) {
+   if (m/^\s+[^\#]/) {
foreach my $target (@current_targets) {
$rules_per_target{$target} ||= [];
push @{$rules_per_target{$target}}, $_;


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1330 - in trunk: checks debian testset testset/debconf/debian

2008-06-02 Thread rra

Author: rra
Date: 2008-06-03 03:18:41 +0200 (Tue, 03 Jun 2008)
New Revision: 1330

Modified:
   trunk/checks/rules
   trunk/checks/rules.desc
   trunk/debian/changelog
   trunk/testset/debconf/debian/rules
   trunk/testset/tags.debconf
Log:
* checks/rules{.desc,}:
  + [RA] Add some basic checks for whether debhelper programs are called
in a reasonable order.  (Closes: #471869)

Modified: trunk/checks/rules
===
--- trunk/checks/rules  2008-06-02 22:02:51 UTC (rev 1329)
+++ trunk/checks/rules  2008-06-03 01:18:41 UTC (rev 1330)
@@ -23,6 +23,16 @@
 my %required = map { $_ = 1 }
 qw(build binary binary-arch binary-indep clean);
 
+# Rules about required debhelper command ordering.  Each command is put into a
+# class and the tag is issued if they're called in the wrong order for the
+# classes.  Unknown commands won't trigger this flag.
+my %debhelper_order =
+(dh_makeshlibs = 1,
+ dh_shlibdeps  = 2,
+ dh_installdeb = 2,
+ dh_gencontrol = 2,
+ dh_builddeb   = 3);
+
 sub run {
 
 my $pkg = shift;
@@ -83,6 +93,7 @@
 local $_;
 my @current_targets;
 my %rules_per_target;
+my $debhelper_group;
 while (RULES) {
 next if /^\s*\#/;
 $includes = 1 if /^ *[s-]?include\s+/;
@@ -118,13 +129,26 @@
for (@current_targets) {
$seen{$_}++ if $required{$_};
}
+$debhelper_group = 0;
 } else {
-   #if we have non-empty, non-comment lines, store them for all current 
targets:
+   # If we have non-empty, non-comment lines, store them for all current
+   # targets and check whether debhelper programs are called in a
+   # reasonable order.
if (m/^\s+[^\#]/) {
foreach my $target (@current_targets) {
$rules_per_target{$target} ||= [];
push @{$rules_per_target{$target}}, $_;
}
+if (m/^\s+(dh_\S+)\b/ and $debhelper_order{$1}) {
+my $command = $1;
+my $group = $debhelper_order{$command};
+if ($group  $debhelper_group) {
+tag debian-rules-calls-debhelper-in-odd-order,
+$command, (line $.);
+} else {
+$debhelper_group = $group;
+}
+}
}
 }
 }

Modified: trunk/checks/rules.desc
===
--- trunk/checks/rules.desc 2008-06-02 22:02:51 UTC (rev 1329)
+++ trunk/checks/rules.desc 2008-06-03 01:18:41 UTC (rev 1330)
@@ -83,3 +83,12 @@
 Info: It looks like your package includes a .desktop file and you use
  debhelper to build it, but you don't call dh_desktop in your rules
  file.
+
+Tag: debian-rules-calls-debhelper-in-odd-order
+Type: warning
+Info: One of the targets in the ttdebian/rules/tt file for this
+ package calls debhelper programs in an odd order.  Normally,
+ dh_makeshlibs should be called before dh_shlibdeps or dh_installdeb,
+ dh_shlibdeps should be called before dh_gencontrol, and all should be
+ called before dh_builddeb.  Calling them in the wrong order may cause
+ incorrect or missing package files and metadata.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-06-02 22:02:51 UTC (rev 1329)
+++ trunk/debian/changelog  2008-06-03 01:18:41 UTC (rev 1330)
@@ -7,6 +7,9 @@
   * checks/md5sums:
 + [FL] Don't complain about missing md5sums file if the
   package only contains conffiles.  (Closes: #482869)
+  * checks/rules{.desc,}:
++ [RA] Add some basic checks for whether debhelper programs are called
+  in a reasonable order.  (Closes: #471869)
   
   * reporting/templates/clean.tmpl:
 + [FL] Include link to full maintainer report.  Suggested by

Modified: trunk/testset/debconf/debian/rules
===
--- trunk/testset/debconf/debian/rules  2008-06-02 22:02:51 UTC (rev 1329)
+++ trunk/testset/debconf/debian/rules  2008-06-03 01:18:41 UTC (rev 1330)
@@ -41,11 +41,15 @@
dh_compress -a
dh_fixperms -a
 
+# The shlibs stuff doesn't matter here so do it in a weird order to
+# test wwarnings.
dh_installdeb -a
dh_shlibdeps -a
+   dh_makeshlibs -a
dh_gencontrol -a
dh_md5sums
dh_builddeb -a
+   dh_makeshlibs -a
 
 # Below here is fairly generic really
 

Modified: trunk/testset/tags.debconf
===
--- trunk/testset/tags.debconf  2008-06-02 22:02:51 UTC (rev 1329)
+++ trunk/testset/tags.debconf  2008-06-03 01:18:41 UTC (rev 1330)
@@ -9,6 +9,8 @@
 E: debconf-udeb udeb: udeb-postinst-must-not-call-ldconfig
 I: debconf source: package-needs-python-policy-debhelper
 I: debconf-test: debconf-error-requires-versioned-depends debconf/error
+W: debconf source: debian-rules-calls-debhelper-in-odd-order

lintian: r1308 - trunk/private

2008-05-15 Thread rra

Author: rra
Date: 2008-05-15 22:58:34 +0200 (Thu, 15 May 2008)
New Revision: 1308

Modified:
   trunk/private/tags-never-seen
Log:
Update tags-never-seen.  Thanks, Tobias Toedter.


Modified: trunk/private/tags-never-seen
===
--- trunk/private/tags-never-seen   2008-05-11 21:10:15 UTC (rev 1307)
+++ trunk/private/tags-never-seen   2008-05-15 20:58:34 UTC (rev 1308)
@@ -1,4 +1,4 @@
-Last generated 2008-01-04 for lintian 1.23.42
+Last generated 2008-05-15 for lintian 1.23.48
 
 binaries.desc apparently-corrupted-elf-binary
 binaries.desc arch-dependent-file-in-usr-share
@@ -6,14 +6,9 @@
 binaries.desc binary-file-compressed-with-upx
 binaries.desc binary-in-etc
 binaries.desc binary-or-shlib-defines-rpath
-binaries.desc binary-or-shlib-with-obsolete-c++-abi
-binaries.desc compiled-with-bad-libc
-binaries.desc libc5-binary
 binaries.desc library-in-debug-or-profile-should-not-be-stripped
 binaries.desc library-not-linked-against-libc
 binaries.desc program-not-linked-against-libc
-changelog-file.desc changelog-not-compressed-with-max-compression
-changelog-file.desc debian-changelog-file-contains-obsolete-user-emacs-settings
 changelog-file.desc html-changelog-without-text-version
 changelog-file.desc no-upstream-changelog
 changelog-file.desc spelling-error-in-changelog
@@ -24,27 +19,18 @@
 conffiles.desc file-in-usr-marked-as-conffile
 conffiles.desc relative-conffile
 control-file.desc debian-control-file-is-a-symlink
+control-file.desc debian-control-with-duplicate-fields
 control-files.desc control-file-has-bad-owner
 control-files.desc not-allowed-control-file
 control-files.desc unknown-control-file
 copyright-file.desc 
cannot-check-whether-usr-share-doc-symlink-points-to-foreign-package
 copyright-file.desc copyright-does-not-refer-to-common-license-file
-copyright-file.desc copyright-file-compressed
-copyright-file.desc copyright-file-contains-full-gfdl-license
-copyright-file.desc copyright-file-contains-full-gpl-license
-copyright-file.desc copyright-file-is-symlink
-copyright-file.desc copyright-lists-upstream-authors-with-dh_make-boilerplate
-copyright-file.desc copyright-refers-to-compressed-license
-copyright-file.desc copyright-refers-to-incorrect-directory
-copyright-file.desc copyright-refers-to-old-directory
-copyright-file.desc copyright-should-refer-to-common-license-file-for-gfdl
-copyright-file.desc copyright-should-refer-to-common-license-file-for-gpl
 copyright-file.desc copyright-should-refer-to-common-license-file-for-lgpl
-copyright-file.desc old-style-copyright-file
 copyright-file.desc spelling-error-in-copyright
 copyright-file.desc usr-share-doc-symlink-points-outside-of-usr-share-doc
 copyright-file.desc usr-share-doc-symlink-to-foreign-package
 cruft.desc diff-contains-git-control-dir
+cruft.desc diff-contains-hg-control-dir
 cruft.desc diff-contains-patch-failure-file
 cruft.desc documentation-package-not-architecture-independent
 cruft.desc outdated-autotools-helper-file
@@ -53,6 +39,7 @@
 cruft.desc source-contains-bzr-control-dir
 cruft.desc source-contains-cvs-conflict-copy
 cruft.desc source-contains-cvs-control-dir
+cruft.desc source-contains-hg-control-dir
 cruft.desc source-contains-svk-commit-file
 cruft.desc source-contains-svn-conflict-file
 cruft.desc source-contains-svn-control-dir
@@ -70,19 +57,10 @@
 debconf.desc unknown-field-in-templates
 debconf.desc unknown-template-type
 debhelper.desc debhelper-compat-file-is-empty
-debhelper.desc dh-make-template-in-source
 debhelper.desc dh_dhelp-is-deprecated
+debhelper.desc dh-make-template-in-source
 debian-readme.desc spelling-error-in-readme-debian
-description.desc description-contains-invalid-control-statement
-description.desc description-contains-tabs
-description.desc description-is-debmake-template
-description.desc description-starts-with-leading-spaces
-description.desc description-starts-with-package-name
 description.desc description-synopsis-has-leading-spaces
-description.desc description-synopsis-is-empty
-description.desc description-too-long
-description.desc extended-description-line-too-long
-description.desc possible-unindented-list-in-extended-description
 fields.desc alternates-not-allowed
 fields.desc arch-any-in-binary-pkg
 fields.desc aspell-package-not-arch-all
@@ -109,29 +87,27 @@
 fields.desc new-essential-package
 fields.desc no-architecture-field
 fields.desc no-maintainer-field
+fields.desc non-standard-arch-in-source-relation
 fields.desc no-package-name
 fields.desc no-source-field
 fields.desc no-version-field
-fields.desc non-standard-arch-in-source-relation
 fields.desc obsolete-field
 fields.desc obsolete-relation-form
 fields.desc old-versioned-python-dependency
 fields.desc package-depends-on-an-x-font-package
 fields.desc package-depends-on-multiple-tclx-versions
-fields.desc package-has-a-duplicate-relation
 fields.desc package-not-lowercase
 fields.desc source-field-does-not-match-pkg-name
 fields.desc

lintian: r1296 - in trunk: debian frontend

2008-05-04 Thread rra

Author: rra
Date: 2008-05-04 21:14:09 +0200 (Sun, 04 May 2008)
New Revision: 1296

Modified:
   trunk/debian/changelog
   trunk/frontend/lintian
Log:
* frontend/lintian:
  + [RA] Work around a Perl 5.10 bug with Getopt::Long and sub handlers.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-05-04 18:18:18 UTC (rev 1295)
+++ trunk/debian/changelog  2008-05-04 19:14:09 UTC (rev 1296)
@@ -12,6 +12,9 @@
 + [FL] Also apply the not-binnmuable-* checks to Pre-Depends.
   (Closes: #472247)
 
+  * frontend/lintian:
++ [RA] Work around a Perl 5.10 bug with Getopt::Long and sub handlers.
+
  -- Frank Lichtenheld [EMAIL PROTECTED]  Thu, 01 May 2008 22:13:07 +0200
 
 lintian (1.23.47) unstable; urgency=low

Modified: trunk/frontend/lintian
===
--- trunk/frontend/lintian  2008-05-04 18:18:18 UTC (rev 1295)
+++ trunk/frontend/lintian  2008-05-04 19:14:09 UTC (rev 1296)
@@ -182,7 +182,7 @@
 if ($action) {
die(too many actions specified: $_[0]);
 }
-$action = $_[0];
+$action = $_[0];
 }
 
 # Record Parts requested for checking
@@ -198,7 +198,7 @@
die(too many actions specified: $_[0]);
 }
 $action = 'check';
-$checks = $_[1];
+$checks = $_[1];
 }
 
 # Record Parts requested not to check
@@ -214,7 +214,7 @@
die(too many actions specified: $_[0]);
 }
 $action = 'check';
-$dont_check = $_[1];
+$dont_check = $_[1];
 }
 
 
@@ -223,7 +223,7 @@
 if ($unpack_info) {
die(multiple -U or --unpack-info options not allowed);
 }
-$unpack_info = $_[1];
+$unpack_info = $_[1];
 }
 
 # Record what type of data is specified
@@ -330,7 +330,7 @@
 }
 
 # check specified action
-$action = 'check' if not $action;
+$action = 'check' unless $action;
 
 # check for arguments
 if ($action =~ /^(check|unpack|remove)$/ and $#ARGV == -1 and not 
$check_everything and not $packages_file) {


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1297 - in trunk: checks debian

2008-05-04 Thread rra

Author: rra
Date: 2008-05-04 21:20:49 +0200 (Sun, 04 May 2008)
New Revision: 1297

Modified:
   trunk/checks/shared-libs
   trunk/debian/changelog
Log:
* checks/shared-libs:
  + [RA] Fix an unescaped | in the regular expression parsing postinst
files for ldconfig invocation.  The regex had always been broken,
but in Perl 5.10 it causes a recursion error in the regex engine.

Modified: trunk/checks/shared-libs
===
--- trunk/checks/shared-libs2008-05-04 19:14:09 UTC (rev 1296)
+++ trunk/checks/shared-libs2008-05-04 19:20:49 UTC (rev 1297)
@@ -475,9 +475,8 @@
 s/^if\[.?remove.?=\$1\];?\n*then\n*BldconfigB//gm;
 s/^\[\$1=.?remove.?\]\BldconfigB//gm;
 s/^\[.?remove.?=\$1\]BldconfigB//gm;
+s/remove(?:\|[^)]+)*\).*?BldconfigB.*?(;;|esac)//s;
 
-   s!remove(?:|[^)]+)*\).*?BldconfigB.*?(;;|esac)!!s;
-
 if (/^[^\#]*BldconfigB/m) {
 tag postrm-unsafe-ldconfig, ;
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-05-04 19:14:09 UTC (rev 1296)
+++ trunk/debian/changelog  2008-05-04 19:20:49 UTC (rev 1297)
@@ -8,6 +8,10 @@
   * checks/menus:
 + [RA] Stop using a deprecated Perl construct that Perl 5.10 no longer
   supports.  Patch from Adam D. Barratt.  (Closes: #479318)
+  * checks/shared-libs:
++ [RA] Fix an unescaped | in the regular expression parsing postinst
+  files for ldconfig invocation.  The regex had always been broken,
+  but in Perl 5.10 it causes a recursion error in the regex engine.
   * checks/version-substvars:
 + [FL] Also apply the not-binnmuable-* checks to Pre-Depends.
   (Closes: #472247)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1298 - in trunk: debian testset

2008-05-04 Thread rra

Author: rra
Date: 2008-05-04 21:29:40 +0200 (Sun, 04 May 2008)
New Revision: 1298

Modified:
   trunk/debian/changelog
   trunk/testset/runtests
Log:
* testset/runtests:
  + [RA] dpkg-source now enables the -i and -I regexes by default.
Replace the defaults with ones that never match so that we can
continue testing for cruft left in source packages.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-05-04 19:20:49 UTC (rev 1297)
+++ trunk/debian/changelog  2008-05-04 19:29:40 UTC (rev 1298)
@@ -19,6 +19,11 @@
   * frontend/lintian:
 + [RA] Work around a Perl 5.10 bug with Getopt::Long and sub handlers.
 
+  * testset/runtests:
++ [RA] dpkg-source now enables the -i and -I regexes by default.
+  Replace the defaults with ones that never match so that we can
+  continue testing for cruft left in source packages.
+
  -- Frank Lichtenheld [EMAIL PROTECTED]  Thu, 01 May 2008 22:13:07 +0200
 
 lintian (1.23.47) unstable; urgency=low

Modified: trunk/testset/runtests
===
--- trunk/testset/runtests  2008-05-04 19:20:49 UTC (rev 1297)
+++ trunk/testset/runtests  2008-05-04 19:29:40 UTC (rev 1298)
@@ -119,7 +119,8 @@
 # --- Set the ways to call lintian and dpkg-buildpackage
 my $lintian_options = '-I';
 my $lintian_info_options = '-I -i';
-my $dpkg_buildpackage_options = '-rfakeroot -us -uc -d';
+my $dpkg_buildpackage_options = '-rfakeroot -us -uc -d -iNEVER_MATCH_ANYTHING'
+. ' -INEVER_MATCH_ANYTHING';
 my $lintian_path = $LINTIAN_ROOT . /frontend/lintian;
 
 my $testok = 0;


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1299 - trunk/testset

2008-05-04 Thread rra

Author: rra
Date: 2008-05-04 21:34:07 +0200 (Sun, 04 May 2008)
New Revision: 1299

Modified:
   trunk/testset/tags.empty
Log:
dpkg-genchanges now invents a description even if one isn't avaliable,
so we can't test for a missing one here.


Modified: trunk/testset/tags.empty
===
--- trunk/testset/tags.empty2008-05-04 19:29:40 UTC (rev 1298)
+++ trunk/testset/tags.empty2008-05-04 19:34:07 UTC (rev 1299)
@@ -7,7 +7,6 @@
 E: empty: maintainer-address-missing empty
 E: empty: no-copyright-file
 E: empty: package-has-no-description
-E: empty_2_i386.changes: no-description-in-changes-file
 E: libempty-perl: maintainer-address-missing empty
 E: libempty-perl: no-copyright-file
 E: libempty-perl: package-has-no-description


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1300 - trunk/debian

2008-05-04 Thread rra

Author: rra
Date: 2008-05-04 21:58:33 +0200 (Sun, 04 May 2008)
New Revision: 1300

Modified:
   trunk/debian/changelog
Log:
Finalize changes for 1.23.48.


Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-05-04 19:34:07 UTC (rev 1299)
+++ trunk/debian/changelog  2008-05-04 19:58:33 UTC (rev 1300)
@@ -1,5 +1,7 @@
-lintian (1.23.48) UNRELEASED; urgency=low
+lintian (1.23.48) unstable; urgency=low
 
+  The Perl 5.10 compatibility release.
+
   * checks/common_data.pm:
 + [FL] Add 8.5 versions to known_tcls and known_tks.
   * checks/copyright-file:
@@ -24,7 +26,7 @@
   Replace the defaults with ones that never match so that we can
   continue testing for cruft left in source packages.
 
- -- Frank Lichtenheld [EMAIL PROTECTED]  Thu, 01 May 2008 22:13:07 +0200
+ -- Russ Allbery [EMAIL PROTECTED]  Sun, 04 May 2008 12:57:48 -0700
 
 lintian (1.23.47) unstable; urgency=low
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1301 - releases

2008-05-04 Thread rra

Author: rra
Date: 2008-05-04 22:10:47 +0200 (Sun, 04 May 2008)
New Revision: 1301

Added:
   releases/1.23.48/
Log:
Tag 1.23.48 release.


Copied: releases/1.23.48 (from rev 1300, trunk)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1289 - trunk/lib

2008-04-30 Thread rra

Author: rra
Date: 2008-04-30 23:55:59 +0200 (Wed, 30 Apr 2008)
New Revision: 1289

Modified:
   trunk/lib/Spelling.pm
Log:
Really only trigger the meta package correction for descriptions.


Modified: trunk/lib/Spelling.pm
===
--- trunk/lib/Spelling.pm   2008-04-30 21:27:07 UTC (rev 1288)
+++ trunk/lib/Spelling.pm   2008-04-30 21:55:59 UTC (rev 1289)
@@ -420,9 +420,6 @@
 if ($text =~ m,Debian/GNU\s+Linux,) {
 _tag($tag, $filename, Debian/GNU Linux, Debian GNU/Linux);
 }
-if ($text =~ m,meta\s+package,) {
-_tag($tag, $filename, meta package, metapackage);
-}
 }
 
 # Check spelling of $text against pickier corrections, such as common
@@ -441,6 +438,9 @@
 next;
 }
 }
+if ($text =~ m,meta\s+package,) {
+_tag($tag, $filename, meta package, metapackage);
+}
 }
 
 1;


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1285 - in trunk: checks debian

2008-04-28 Thread rra

Author: rra
Date: 2008-04-29 02:52:38 +0200 (Tue, 29 Apr 2008)
New Revision: 1285

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
  + [RA] If the call to some supporting program like update-inetd is
conditional on the existence of the program, assume the maintainer
knows what they're doing and don't warn.

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-04-26 04:30:46 UTC (rev 1284)
+++ trunk/checks/scripts2008-04-29 00:52:38 UTC (rev 1285)
@@ -691,12 +691,16 @@
for my $rule (@depends_needed) {
my ($package, $regex) = @$rule;
if ($pkg ne $package and /$regex/ and ! $warned{$package}) {
-my $needed = Dep::parse($package);
-unless (Dep::implies($deps{depends}, $needed) || 
Dep::implies($deps{'pre-depends'}, $needed)) {
-   my $shortpackage = $package;
-   $shortpackage =~ s/[ \(].*//;
-   tag maintainer-script-needs-depends-on-$shortpackage, 
$file;
+   if (m,-x\s+\S*$regex, or m,which\s+$regex, or 
m,command\s+.*?$regex,) {
$warned{$package} = 1;
+   } else {
+   my $needed = Dep::parse($package);
+   unless (Dep::implies($deps{depends}, $needed) || 
Dep::implies($deps{'pre-depends'}, $needed)) {
+   my $shortpackage = $package;
+   $shortpackage =~ s/[ \(].*//;
+   tag 
maintainer-script-needs-depends-on-$shortpackage, $file;
+   $warned{$package} = 1;
+   }
}
}
}

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-26 04:30:46 UTC (rev 1284)
+++ trunk/debian/changelog  2008-04-29 00:52:38 UTC (rev 1285)
@@ -59,6 +59,9 @@
   Hideki Yamane.  (Closes: #476417)
 + [RA] Add inetutils-inetd and xinetd as additional update-inetd
   providers.  Patch from Guillem Jover.  (Closes: #474077)
++ [RA] If the call to some supporting program like update-inetd is
+  conditional on the existence of the program, assume the maintainer
+  knows what they're doing and don't warn.
   * checks/shared-libs:
 + [RA] Move the default ld.so search path into data.  Drop obsolete
   /usr/lib/libg++-dbg, /usr/X11R6/lib/Xaw3d, and libc5 compatibility


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1282 - in trunk: checks debian

2008-04-25 Thread rra

Author: rra
Date: 2008-04-26 03:26:10 +0200 (Sat, 26 Apr 2008)
New Revision: 1282

Modified:
   trunk/checks/nmu
   trunk/debian/changelog
Log:
  + [RA] Don't consider an NMU changelog entries that mention NMU with
a variation of the word incorporate.

Modified: trunk/checks/nmu
===
--- trunk/checks/nmu2008-04-25 09:32:26 UTC (rev 1281)
+++ trunk/checks/nmu2008-04-26 01:26:10 UTC (rev 1282)
@@ -47,7 +47,7 @@
 while (CHANGELOG) {
if ($firstline) {
$changelog_mentions_nmu = 1
-   if (/\bnmu\b/i or /non-maintainer upload/i) and not 
/(ackno|confir)/i;
+   if (/\bnmu\b/i or /non-maintainer upload/i) and not 
/(ackno|confir|incorporat)/i;
$changelog_mentions_qa = 1 if /orphan/i or /qa (?:group 
)?upload/i;
$firstline = 0 if /^\s+\S/;
}

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-25 09:32:26 UTC (rev 1281)
+++ trunk/debian/changelog  2008-04-26 01:26:10 UTC (rev 1282)
@@ -45,6 +45,8 @@
   * checks/nmu{.desc,}:
 + [RA] Add support for +nmuX versioning for NMUs of native packages.
   Patch from James Vega.  (Closes: #475026)
++ [RA] Don't consider an NMU changelog entries that mention NMU with
+  a variation of the word incorporate.
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
 + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1283 - in trunk: debian reporting

2008-04-25 Thread rra

Author: rra
Date: 2008-04-26 06:03:43 +0200 (Sat, 26 Apr 2008)
New Revision: 1283

Modified:
   trunk/debian/changelog
   trunk/reporting/html_reports
Log:
* reporting/html_reports:
  + [RA] Base the generation of clean report pages on the maintainer URL
rather than the full maintainer string so that maintainers with
different forms of their name won't have clean reports that
overwrite dirty ones.
  + [RA] Fix the counts in qa-list.txt, which were broken in several
respects.
  + [RA] Don't consider a maintainer's page error/warning free if there
are errors or warnings in their co-maintained packages.


Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-26 01:26:10 UTC (rev 1282)
+++ trunk/debian/changelog  2008-04-26 04:03:43 UTC (rev 1283)
@@ -84,6 +84,16 @@
   * man/lintian.1:
 + [FL] Drop linda from SEE ALSO since it is obsolete now. Suggested
   by Hideki Yamane. (Closes: #474478)
+
+  * reporting/html_reports:
++ [RA] Base the generation of clean report pages on the maintainer URL
+  rather than the full maintainer string so that maintainers with
+  different forms of their name won't have clean reports that
+  overwrite dirty ones.
++ [RA] Fix the counts in qa-list.txt, which were broken in several
+  respects.
++ [RA] Don't consider a maintainer's page error/warning free if there
+  are errors or warnings in their co-maintained packages.
   
   * testset/copyright:
 + [FL] New testcases by Tobias Toedter.  (Closes: #472665)

Modified: trunk/reporting/html_reports
===
--- trunk/reporting/html_reports2008-04-26 01:26:10 UTC (rev 1282)
+++ trunk/reporting/html_reports2008-04-26 04:03:43 UTC (rev 1283)
@@ -262,7 +262,9 @@
 # Lintian-clean.
 my %clean;
 for my $source (keys %source_info) {
-$clean{$source_info{$source}-{maintainer}} = 1;
+my $maintainer = $source_info{$source}-{maintainer};
+my $id = maintainer_url ($maintainer);
+$clean{$id} = $maintainer;
 }
 
 # Now, walk through the tags by source package (sorted by maintainer).  Output
@@ -277,14 +279,15 @@
 sort grep { !$seen{$_}++ } keys (%by_maint), keys (%by_uploader);
 }
 for my $maintainer (@maintainers) {
-delete $clean{$maintainer};
+my $id = maintainer_url ($maintainer);
+delete $clean{$id};
 
 # For each of this maintainer's packages, add statistical information
 # about warnings and errors to the QA list and build the packages hash
 # used for the package index.  We only do this for the maintainer
 # packages, not the uploader packages, to avoid double-counting.
-my ($errors, $warnings) = (0, 0);
 for my $source (keys %{ $by_maint{$maintainer} }) {
+my ($errors, $warnings) = (0, 0);
 for my $version (keys %{ $by_maint{$maintainer}{$source} }) {
 my $tags = $by_maint{$maintainer}{$source}{$version};
 for my $tag (@$tags) {
@@ -296,16 +299,33 @@
 $qa{$source} = [ $errors, $warnings ];
 }
 
+# Determine if the maintainer's page is clean.  Check all packages for
+# which they're either maintainer or uploader and set $error_clean if
+# they have no errors or warnings.
+my $error_clean = 1;
+for my $source (keys %{ $by_maint{$maintainer} },
+keys %{ $by_uploader{$maintainer} }) {
+my $versions = $by_maint{$maintainer}{$source}
+|| $by_uploader{$maintainer}{$source};
+for my $version (keys %$versions) {
+my $tags = $versions-{$version};
+for my $tag (@$tags) {
+$error_clean = 0 if ($tag-{code} eq 'E');
+$error_clean = 0 if ($tag-{code} eq 'W');
+}
+}
+}
+
 # Determine the parts of the maintainer and the file name for the
 # maintainer page.
 my ($name, $email) = ($maintainer =~ /^(.*) ([^]+)/);
 $email = 'unknown' unless $email;
-my $id = maintainer_url ($maintainer);
 my $regular = maintainer/$id;
 my $full = full/$id;
 
 # Create the regular maintainer page (only errors and warnings) and the
 # full maintainer page (all tags, including overrides and info tags).
+print Generating page for $id\n;
 my %data = (
 email  = html_quote ($email),
 errors = 1,
@@ -318,10 +338,10 @@
 version= $LINTIAN_VERSION
 );
 my $template;
-if ($errors || $warnings) {
+if ($error_clean) {
+$template = $templates{clean};
+} else {
 $template = $templates{maintainer};
-} else {
-$template = $templates{clean};
 }
 output_template ($regular, $template, \%data);
 $template = $templates{maintainer};
@@ -349,7 +369,8 @@
 close QA or die cannot write to qa-list: $!\n;
 
 # Now, generate stub pages for every maintainer who has only clean packages

lintian: r1284 - in trunk: debian reporting/templates

2008-04-25 Thread rra

Author: rra
Date: 2008-04-26 06:30:46 +0200 (Sat, 26 Apr 2008)
New Revision: 1284

Modified:
   trunk/debian/changelog
   trunk/reporting/templates/maintainer.tmpl
Log:
* reporting/templates/maintainer.tmpl:
  + [RA] Always add anchors to the package names even for uploaders.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-26 04:03:43 UTC (rev 1283)
+++ trunk/debian/changelog  2008-04-26 04:30:46 UTC (rev 1284)
@@ -94,6 +94,8 @@
   respects.
 + [RA] Don't consider a maintainer's page error/warning free if there
   are errors or warnings in their co-maintained packages.
+  * reporting/templates/maintainer.tmpl:
++ [RA] Always add anchors to the package names even for uploaders.
   
   * testset/copyright:
 + [FL] New testcases by Tobias Toedter.  (Closes: #472665)

Modified: trunk/reporting/templates/maintainer.tmpl
===
--- trunk/reporting/templates/maintainer.tmpl   2008-04-26 04:03:43 UTC (rev 
1283)
+++ trunk/reporting/templates/maintainer.tmpl   2008-04-26 04:30:46 UTC (rev 
1284)
@@ -55,7 +55,7 @@
 next unless $info-{code} eq 'E' or $info-{code} eq 'W';
 }
 unless ($last) {
-if ($anchored || $upload) {
+if ($anchored) {
 $OUT .= qq(dt);
 } else {
 $OUT .= qq(dt id=$sourcea name=$source);
@@ -63,7 +63,7 @@
 $OUT .= strong$source ($version);
 $OUT .= ' (Uploader)' if $upload;
 $OUT .= '/strong';
-if ($anchored || $upload) {
+if ($anchored) {
 $OUT .= qq(/dt\ndd\n);
 } else {
 $OUT .= qq(/a/dt\ndd\n);


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1280 - in trunk: checks debian testset testset/description/debian

2008-04-23 Thread rra

Author: rra
Date: 2008-04-23 20:56:57 +0200 (Wed, 23 Apr 2008)
New Revision: 1280

Modified:
   trunk/checks/description
   trunk/debian/changelog
   trunk/testset/description/debian/changelog
   trunk/testset/description/debian/control
   trunk/testset/description/debian/rules
   trunk/testset/tags.description
Log:
  + [FL] New testcases by Tobias Toedter.  (Closes: #471838, #477471)

Modified: trunk/checks/description
===
--- trunk/checks/description2008-04-21 22:27:51 UTC (rev 1279)
+++ trunk/checks/description2008-04-23 18:56:57 UTC (rev 1280)
@@ -54,6 +54,8 @@
 if ($synopsis =~ m/^\s*$/) {
 tag description-synopsis-is-empty, ;
 } else {
+# Current dpkg-gencontrol appears to fix this automatically so this
+# tag will never trigger with a current dpkg-dev.
 if ($synopsis =~ m/^\s/) {
tag description-synopsis-has-leading-spaces, ;
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-21 22:27:51 UTC (rev 1279)
+++ trunk/debian/changelog  2008-04-23 18:56:57 UTC (rev 1280)
@@ -85,7 +85,7 @@
   * testset/copyright:
 + [FL] New testcases by Tobias Toedter.  (Closes: #472665)
   * testset/description:
-+ [FL] New testcases by Tobias Toedter.  (Closes: #471838)
++ [FL] New testcases by Tobias Toedter.  (Closes: #471838, #477471)
 
   * unpack/list-srcpkg:
 + [RA] Fix syntax error introduced by Uploaders support.

Modified: trunk/testset/description/debian/changelog
===
--- trunk/testset/description/debian/changelog  2008-04-21 22:27:51 UTC (rev 
1279)
+++ trunk/testset/description/debian/changelog  2008-04-23 18:56:57 UTC (rev 
1280)
@@ -1,3 +1,12 @@
+description (1.1-1) unstable; urgency=low
+
+  * Add the following tests of tags never seen:
+- description-synopsis-has-leading-spaces
+  This is not yet recognized by Lintian, so the testset currently
+  fails.
+
+ -- Tobias Toedter [EMAIL PROTECTED]  Wed, 23 Apr 2008 13:12:32 +0200
+
 description (1.0-1) unstable; urgency=low
 
   * Initial release.

Modified: trunk/testset/description/debian/control
===
--- trunk/testset/description/debian/control2008-04-21 22:27:51 UTC (rev 
1279)
+++ trunk/testset/description/debian/control2008-04-23 18:56:57 UTC (rev 
1280)
@@ -2,7 +2,7 @@
 Section: text
 Priority: extra
 Maintainer: Lintian Maintainers [EMAIL PROTECTED]
-Uploaders: Tobias Toedter [EMAIL PROTECTED]
+Uploaders: Tobias Toedter [EMAIL PROTECTED]
 Standards-Version: 3.7.3
 
 Package: description
@@ -32,3 +32,8 @@
  . and please avoid control statements in the long description.
  The line in an extended description should be less than 80 characters, 
otherwise you'll get
  a Lintian warning.
+
+Package: description-baz
+Architecture: all
+Description:the synopsis starts with spaces
+ This is a real Lintian bug which has been discovered with this testset.

Modified: trunk/testset/description/debian/rules
===
--- trunk/testset/description/debian/rules  2008-04-21 22:27:51 UTC (rev 
1279)
+++ trunk/testset/description/debian/rules  2008-04-23 18:56:57 UTC (rev 
1280)
@@ -3,6 +3,7 @@
 description=debian/description
 description-foo=debian/description-foo
 description-bar=debian/description-bar
+description-baz=debian/description-baz
 
 build:
 
@@ -36,11 +37,21 @@
gzip -9 $(description-bar)/usr/share/doc/description/changelog.Debian
dpkg-gencontrol -pdescription-bar -P$(description-bar)
dpkg --build $(description-bar) ..
+   
+   # Create package description-baz
+   install -d $(description-baz)
+   install -d $(description-baz)/DEBIAN
+   install -d $(description-baz)/usr/share/doc/description
+   install -m 644 debian/changelog \
+ $(description-baz)/usr/share/doc/description/changelog.Debian
+   gzip -9 $(description-baz)/usr/share/doc/description/changelog.Debian
+   dpkg-gencontrol -pdescription-baz -P$(description-baz)
+   dpkg --build $(description-baz) ..
 
 binary: binary-indep
 
 clean:
rm -rf debian/files $(description) $(description-foo) \
- $(description-bar) debian/substvars
+ $(description-bar) $(description-baz) debian/substvars
 
 .PHONY: build binary-indep binary clean

Modified: trunk/testset/tags.description
===
--- trunk/testset/tags.description  2008-04-21 22:27:51 UTC (rev 1279)
+++ trunk/testset/tags.description  2008-04-23 18:56:57 UTC (rev 1280)
@@ -2,6 +2,7 @@
 E: description-bar: description-contains-invalid-control-statement
 E: description-bar: description-synopsis-is-empty
 E: description-bar: no-copyright-file
+E: description-baz: no-copyright

lintian: r1275 - in trunk: checks debian

2008-04-21 Thread rra

Author: rra
Date: 2008-04-22 00:00:37 +0200 (Tue, 22 Apr 2008)
New Revision: 1275

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
  + [RA] Expect unversioned dependencies on OCaml packages rather than
versioned dependencies since the version changes frequently and
unversioned dependencies are what people are already using.  Thanks,
Hideki Yamane.  (Closes: #476417)

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-04-17 21:16:23 UTC (rev 1274)
+++ trunk/checks/scripts2008-04-21 22:00:37 UTC (rev 1275)
@@ -70,9 +70,7 @@
  make  = [ '/usr/bin', 'make | build-essential' ],
  mawk  = [ '/usr/bin' ],
  ocamlrun  = [ '/usr/bin',
-join (' | ', map { $_-3.10.0 }
-  qw/ocaml-base-nox ocaml-base ocaml-nox ocaml/)
-  ],
+'ocaml-base-nox | ocaml-base | ocaml-nox | ocaml' ],
  pagsh = [ '/usr/bin', 'openafs-client | heimdal-clients' ],
  parrot= [ '/usr/bin' ],
  perl  = [ '/usr/bin', '' ],

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-17 21:16:23 UTC (rev 1274)
+++ trunk/debian/changelog  2008-04-21 22:00:37 UTC (rev 1275)
@@ -46,6 +46,10 @@
   files do not need to be executable even if they look like scripts.
 + [RA] Add clisp, procmail, and rrdcgi, and another way interpretors
   are templated in *.in files.
++ [RA] Expect unversioned dependencies on OCaml packages rather than
+  versioned dependencies since the version changes frequently and
+  unversioned dependencies are what people are already using.  Thanks,
+  Hideki Yamane.  (Closes: #476417)
   * checks/shared-libs:
 + [RA] Move the default ld.so search path into data.  Drop obsolete
   /usr/lib/libg++-dbg, /usr/X11R6/lib/Xaw3d, and libc5 compatibility


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1276 - in trunk: checks debian

2008-04-21 Thread rra

Author: rra
Date: 2008-04-22 00:12:59 +0200 (Tue, 22 Apr 2008)
New Revision: 1276

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
  + [RA] Add inetutils-inetd and xinetd as additional update-inetd
providers.  Patch from Guillem Jover.  (Closes: #474077)

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-04-21 22:00:37 UTC (rev 1275)
+++ trunk/checks/scripts2008-04-21 22:12:59 UTC (rev 1276)
@@ -165,7 +165,8 @@
 
 # Any of the following packages can satisfy an update-inetd dependency.
 our $update_inetd
-= join (' | ', qw(update-inetd inet-superserver openbsd-inetd rlinetd));
+= join (' | ', qw(update-inetd inet-superserver openbsd-inetd
+  inetutils-inetd rlinetd xinetd));
 
 # Appearance of one of these regexes in a maintainer script means that there
 # must be a dependency (or pre-dependency) on the given package.  The tag

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-21 22:00:37 UTC (rev 1275)
+++ trunk/debian/changelog  2008-04-21 22:12:59 UTC (rev 1276)
@@ -50,6 +50,8 @@
   versioned dependencies since the version changes frequently and
   unversioned dependencies are what people are already using.  Thanks,
   Hideki Yamane.  (Closes: #476417)
++ [RA] Add inetutils-inetd and xinetd as additional update-inetd
+  providers.  Patch from Guillem Jover.  (Closes: #474077)
   * checks/shared-libs:
 + [RA] Move the default ld.so search path into data.  Drop obsolete
   /usr/lib/libg++-dbg, /usr/X11R6/lib/Xaw3d, and libc5 compatibility


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1277 - in trunk: checks debian

2008-04-21 Thread rra

Author: rra
Date: 2008-04-22 00:15:42 +0200 (Tue, 22 Apr 2008)
New Revision: 1277

Modified:
   trunk/checks/nmu
   trunk/checks/nmu.desc
   trunk/debian/changelog
Log:
* checks/nmu{.desc,}:
  + [RA] Add support for +nmuX versioning for NMUs of native packages.
Patch from James Vega.  (Closes: #475026)

Modified: trunk/checks/nmu
===
--- trunk/checks/nmu2008-04-21 22:12:59 UTC (rev 1276)
+++ trunk/checks/nmu2008-04-21 22:15:42 UTC (rev 1277)
@@ -67,6 +67,9 @@
$version_nmuness = 1 if defined $1;
$version_nmuness = 2 if defined $2;
 }
+if ($version =~ /\+nmu\d+$/) {
+   $version_nmuness = 1;
+}
 if ($version =~ /\+b\d+$/) {
$version_nmuness = 2;
 }

Modified: trunk/checks/nmu.desc
===
--- trunk/checks/nmu.desc   2008-04-21 22:12:59 UTC (rev 1276)
+++ trunk/checks/nmu.desc   2008-04-21 22:15:42 UTC (rev 1277)
@@ -19,8 +19,9 @@
 
 Tag: source-nmu-has-incorrect-version-number
 Type: warning
-Info: A source NMU should have a Debian revision of -x.x. This is to prevent
- stealing version numbers from the maintainer.
+Info: A source NMU should have a Debian revision of -x.x (or +nmuX for a
+ native package). This is to prevent stealing version numbers from the
+ maintainer.
  .
  Maybe you didn't intend this upload to be a NMU, in that case, please
  doublecheck that the most recent entry in the changelog is byte-for-byte

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-21 22:12:59 UTC (rev 1276)
+++ trunk/debian/changelog  2008-04-21 22:15:42 UTC (rev 1277)
@@ -40,6 +40,9 @@
 + [FL] Don't complain about empty directories under
   /usr/share/python-support since those might be needed.  Thanks,
   Josselin Mouette.  (Closes: #473428)
+  * checks/nmu{.desc,}:
++ [RA] Add support for +nmuX versioning for NMUs of native packages.
+  Patch from James Vega.  (Closes: #475026)
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
 + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1278 - in trunk: checks debian

2008-04-21 Thread rra

Author: rra
Date: 2008-04-22 00:19:03 +0200 (Tue, 22 Apr 2008)
New Revision: 1278

Modified:
   trunk/checks/files
   trunk/debian/changelog
Log:
  + [RA] Ignore extra license files in examples subdirectories of
/usr/share/doc.  Thanks, Daniel Jacobowitz.  (Closes: #476149)

Modified: trunk/checks/files
===
--- trunk/checks/files  2008-04-21 22:15:42 UTC (rev 1277)
+++ trunk/checks/files  2008-04-21 22:19:03 UTC (rev 1278)
@@ -593,10 +593,14 @@
# DTD files are excluded at the request of the Mozilla suite
# maintainers.  Zope products include license files for runtime
# display.  underXXXlicense.docbook files are from KDE.
+   #
+   # Ignore extra license files in examples, since various package
+   # building software includes example packages with licenses.
and not $file =~ 
m/\.(el|c|h|py|cc|pl|pm|html|php|rb|xpm|png|jpe?g|gif|svg|dtd)$/
and not $file =~ m,^usr/share/zope/Products/.*\.(dtml|pt|cpt)$,
and not $file =~ m,/under\S+License\.docbook$,
and not $file =~ m,^(usr/)?s?bin/,
+   and not $file =~ m,^usr/share/doc/[^/]+/examples/,
and not defined $link) {
tag extra-license-file, $file;
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-21 22:15:42 UTC (rev 1277)
+++ trunk/debian/changelog  2008-04-21 22:19:03 UTC (rev 1278)
@@ -40,6 +40,8 @@
 + [FL] Don't complain about empty directories under
   /usr/share/python-support since those might be needed.  Thanks,
   Josselin Mouette.  (Closes: #473428)
++ [RA] Ignore extra license files in examples subdirectories of
+  /usr/share/doc.  Thanks, Daniel Jacobowitz.  (Closes: #476149)
   * checks/nmu{.desc,}:
 + [RA] Add support for +nmuX versioning for NMUs of native packages.
   Patch from James Vega.  (Closes: #475026)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1279 - in trunk: debian lib

2008-04-21 Thread rra

Author: rra
Date: 2008-04-22 00:27:51 +0200 (Tue, 22 Apr 2008)
New Revision: 1279

Modified:
   trunk/debian/changelog
   trunk/lib/Spelling.pm
Log:
  + [RA] Correct meta package and meta-package in descriptions to
metapackage.  Thanks, Frank S. Thomas.  (Closes: #476681)

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-04-21 22:19:03 UTC (rev 1278)
+++ trunk/debian/changelog  2008-04-21 22:27:51 UTC (rev 1279)
@@ -75,6 +75,8 @@
 
   * lib/Spelling.pm:
 + [RA] Avoid Perl warnings when called with an uninitialized value.
++ [RA] Correct meta package and meta-package in descriptions to
+  metapackage.  Thanks, Frank S. Thomas.  (Closes: #476681)
 
   * man/lintian.1:
 + [FL] Drop linda from SEE ALSO since it is obsolete now. Suggested

Modified: trunk/lib/Spelling.pm
===
--- trunk/lib/Spelling.pm   2008-04-21 22:19:03 UTC (rev 1278)
+++ trunk/lib/Spelling.pm   2008-04-21 22:27:51 UTC (rev 1279)
@@ -342,6 +342,7 @@
GTK GTK+
gtk+ GTK+
kde KDE
+   meta-package metapackage
MYSQL MySQL
Mysql MySQL
mysql MySQL
@@ -416,9 +417,12 @@
 }
 
 # Special case for correcting a multi-word string.
-if ($text =~ m,Debian/GNU Linux,) {
+if ($text =~ m,Debian/GNU\s+Linux,) {
 _tag($tag, $filename, Debian/GNU Linux, Debian GNU/Linux);
 }
+if ($text =~ m,meta\s+package,) {
+_tag($tag, $filename, meta package, metapackage);
+}
 }
 
 # Check spelling of $text against pickier corrections, such as common


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1267 - in trunk: checks debian

2008-03-20 Thread rra

Author: rra
Date: 2008-03-20 21:25:22 +0100 (Thu, 20 Mar 2008)
New Revision: 1267

Modified:
   trunk/checks/files
   trunk/debian/changelog
Log:
  + [RA] Don't consider files in bin directories that contain copying
or license to be extra license files.

Modified: trunk/checks/files
===
--- trunk/checks/files  2008-03-14 21:17:47 UTC (rev 1266)
+++ trunk/checks/files  2008-03-20 20:25:22 UTC (rev 1267)
@@ -580,9 +580,9 @@
 
 #  license files
 if ($file =~ m,(copying|licen[cs]e)(\.[^/]+)?$,i
-   # Ignore some common extensions; there was at least one file
-   # named license.el.  These are probably license-displaying
-   # code, not license files.
+   # Ignore some common extensions; there was at least one file named
+   # license.el.  These are probably license-displaying code, not
+   # license files.  Also ignore binaries in /usr/bin and friends.
#
# Another exception is made for .html and .php because preserving
# working links is more important than saving some bytes, and
@@ -596,6 +596,7 @@
and not $file =~ 
m/\.(el|c|h|py|cc|pl|pm|html|php|rb|xpm|png|jpe?g|gif|svg|dtd)$/
and not $file =~ m,^usr/share/zope/Products/.*\.(dtml|pt|cpt)$,
and not $file =~ m,/under\S+License\.docbook$,
+   and not $file =~ m,^(usr/)?s?bin/,
and not defined $link) {
tag extra-license-file, $file;
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-14 21:17:47 UTC (rev 1266)
+++ trunk/debian/changelog  2008-03-20 20:25:22 UTC (rev 1267)
@@ -26,6 +26,8 @@
 + [RA] Issue errors for installing files under /var/www.  This isn't
   in FHS, may not be the document root, and may break local files if
   it is the document root.  Thanks, Joerg Jaspert.  (Closes: #470403)
++ [RA] Don't consider files in bin directories that contain copying
+  or license to be extra license files.
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
 + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1266 - trunk/lib

2008-03-14 Thread rra

Author: rra
Date: 2008-03-14 22:17:47 +0100 (Fri, 14 Mar 2008)
New Revision: 1266

Modified:
   trunk/lib/Spelling.pm
Log:
Perl syntax fix.


Modified: trunk/lib/Spelling.pm
===
--- trunk/lib/Spelling.pm   2008-03-13 01:39:19 UTC (rev 1265)
+++ trunk/lib/Spelling.pm   2008-03-14 21:17:47 UTC (rev 1266)
@@ -398,7 +398,7 @@
 # not defined, it will be omitted.
 sub spelling_check {
 my ($tag, $text, $filename) = @_;
-next unless $text;
+return unless $text;
 
 for my $word (split(/\s+/, $text)) {
 $word = lc $word;


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1257 - in trunk: debian unpack

2008-03-12 Thread rra

Author: rra
Date: 2008-03-12 07:55:15 +0100 (Wed, 12 Mar 2008)
New Revision: 1257

Modified:
   trunk/debian/changelog
   trunk/unpack/list-srcpkg
Log:
* unpack/list-srcpkg:
  + [RA] Fix syntax error introduced by Uploaders support.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-07 09:05:37 UTC (rev 1256)
+++ trunk/debian/changelog  2008-03-12 06:55:15 UTC (rev 1257)
@@ -35,6 +35,9 @@
   * data/shared-libs/ldconfig-dirs:
 + [RA] New file listing directories searched by ld.so.
 
+  * unpack/list-srcpkg:
++ [RA] Fix syntax error introduced by Uploaders support.
+
  -- Russ Allbery [EMAIL PROTECTED]  Tue, 04 Mar 2008 13:07:18 -0800
 
 lintian (1.23.46) unstable; urgency=low

Modified: trunk/unpack/list-srcpkg
===
--- trunk/unpack/list-srcpkg2008-03-07 09:05:37 UTC (rev 1256)
+++ trunk/unpack/list-srcpkg2008-03-12 06:55:15 UTC (rev 1257)
@@ -161,7 +161,7 @@
 $pkg,
 $data-{'version'},
 $data-{'maintainer'},
- $data-{'uploaders'} || '';
+ $data-{'uploaders'} || '',
  $data-{'architecture'},
  $data-{'standards-version'},
  $data-{'binary'},


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1258 - in trunk: checks debian testset testset/filenames/debian

2008-03-12 Thread rra

Author: rra
Date: 2008-03-12 08:13:25 +0100 (Wed, 12 Mar 2008)
New Revision: 1258

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/filenames/debian/rules
   trunk/testset/tags.filenames
Log:
* checks/files{.desc,}:
  + [RA] Warn about linda overrides since linda has been removed from
the archive.  Thanks, Y Giridhar Appaji Nag.  (Closes: #469603)

Modified: trunk/checks/files
===
--- trunk/checks/files  2008-03-12 06:55:15 UTC (rev 1257)
+++ trunk/checks/files  2008-03-12 07:13:25 UTC (rev 1258)
@@ -376,6 +376,10 @@
tag documentation-file, $file;
}
}
+   #  /usr/share/linda/overrides
+   elsif ($file =~ m,^usr/share/linda/overrides/\S+,) {
+   tag package-contains-linda-override, $file;
+   }
#  /usr/share
elsif ($file =~ m,^usr/share/[^/]+$,) {
if ($perm =~ m/^-/) {

Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2008-03-12 06:55:15 UTC (rev 1257)
+++ trunk/checks/files.desc 2008-03-12 07:13:25 UTC (rev 1258)
@@ -725,3 +725,10 @@
  which is intended for detached debugging symbols, but the package name
  does not end in -dbg.  Detached debugging symbols should be put into a
  separate package, Priority: extra, with a package name ending in -dbg.
+
+Tag: package-contains-linda-override
+Type: warning
+Info: This package contains a linda override file in
+ tt/usr/share/linda/overrides/tt.  Linda is obsolete and has been
+ removed from the archive as of 2008-03-04.  Linda overrides should
+ probably be dropped from packages.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-12 06:55:15 UTC (rev 1257)
+++ trunk/debian/changelog  2008-03-12 07:13:25 UTC (rev 1258)
@@ -15,8 +15,10 @@
   * checks/etcfiles:
 + [RA] /etc/init.d/{skeleton,rc,rcS} are not conffiles, and README
   files in /etc need not be.
-  * checks/files:
+  * checks/files{.desc,}:
 + [RA] /etc/init.d/{skeleton,README} don't need to be executable.
++ [RA] Warn about linda overrides since linda has been removed from
+  the archive.  Thanks, Y Giridhar Appaji Nag.  (Closes: #469603)
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
 + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex

Modified: trunk/testset/filenames/debian/rules
===
--- trunk/testset/filenames/debian/rules2008-03-12 06:55:15 UTC (rev 
1257)
+++ trunk/testset/filenames/debian/rules2008-03-12 07:13:25 UTC (rev 
1258)
@@ -75,6 +75,9 @@
touch debian/tmp/usr/share/pixmaps/license.foo
touch debian/tmp/usr/share/pixmaps/COPYING
 
+   install -d debian/tmp/usr/share/linda/overrides
+   echo 'foo'  debian/tmp/usr/share/linda/overrides/filenames
+
install -d debian/tmp/usr/share/doc/filenames
touch debian/tmp/usr/share/doc/filenames/README.macosx
 

Modified: trunk/testset/tags.filenames
===
--- trunk/testset/tags.filenames2008-03-12 06:55:15 UTC (rev 1257)
+++ trunk/testset/tags.filenames2008-03-12 07:13:25 UTC (rev 1258)
@@ -86,6 +86,7 @@
 W: filenames: package-contains-empty-directory usr/lib/perl5/.svn/
 W: filenames: package-contains-empty-directory usr/lib/perl5/CVS/
 W: filenames: package-contains-empty-directory usr/lib/perl5/{arch}/
+W: filenames: package-contains-linda-override 
usr/share/linda/overrides/filenames
 W: filenames: package-contains-readme-for-other-platform-or-distro 
usr/share/doc/filenames/README.macosx
 W: filenames: package-contains-vcs-control-dir usr/lib/perl5/.arch-ids/
 W: filenames: package-contains-vcs-control-dir usr/lib/perl5/.bzr/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1259 - in trunk: checks debian testset testset/filenames/debian unpack

2008-03-12 Thread rra

Author: rra
Date: 2008-03-12 08:45:30 +0100 (Wed, 12 Mar 2008)
New Revision: 1259

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/filenames/debian/rules
   trunk/testset/tags.filenames
   trunk/unpack/unpack-binpkg-l1
Log:
  + [RA] Check for numeric owners or groups outside of the reserved
static ranges.  Patch from H?\195?\165kon Stordahl.  (Closes: #469924)
* unpack/unpack-binpkg-l1:
  + [RA] Extract a tar listing with numeric owners and groups into
index-owner-id in the lab.

Modified: trunk/checks/files
===
--- trunk/checks/files  2008-03-12 07:13:25 UTC (rev 1258)
+++ trunk/checks/files  2008-03-12 07:45:30 UTC (rev 1259)
@@ -90,6 +90,8 @@
 
 # Read package contents...
 open(IN, '', index) or fail(cannot open index file index: $!);
+open(NUMERIC, '', index-owner-id)
+or fail(cannot open index file index-owner-id: $!);
 while (IN) {
 chop;
 
@@ -97,6 +99,13 @@
 my $link;
 my $operm;
 
+my $numeric = NUMERIC;
+chop $numeric;
+fail(cannot read index file index-owner-id) unless defined $numeric;
+my ($owner_id, $file_chk) = (split(' ', $numeric, 6))[1, 5];
+fail(mismatching contents of index files: $file $file_chk)
+   if $file ne $file_chk;
+
 $file =~ s,^\./,,;
 
 if ($file =~ s/ link to (.*)//) {
@@ -128,6 +137,14 @@
tag package-contains-ancient-file, $file $date;
 }
 
+my ($owner_uid, $owner_gid) = split ('/', $owner_id);
+if (!($owner_uid  100 || $owner_uid == 65534
+ || ($owner_uid = 6  $owner_uid  65000))
+   || !($owner_gid  100 || $owner_gid == 65534
+|| ($owner_gid = 6  $owner_gid  65000))) {
+   tag wrong-file-owner-uid-or-gid, $file, $owner_id;
+}
+
 # *.devhelp and *.devhelp2 files must be accessible from a directory in
 # the devhelp search path: /usr/share/devhelp/books and
 # /usr/share/gtk-doc/html.  We therefore look for any links in one of
@@ -860,6 +877,9 @@
 }
 close(IN);
 
+fail(mismatching contents of index files) if NUMERIC;
+close(NUMERIC);
+
 #check for sect: games but nothing in /usr/games. Check for any binary to
 #save ourselves from game-data false positives:
 if ($pkg_section =~ m,games$,

Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2008-03-12 07:13:25 UTC (rev 1258)
+++ trunk/checks/files.desc 2008-03-12 07:45:30 UTC (rev 1259)
@@ -732,3 +732,13 @@
  tt/usr/share/linda/overrides/tt.  Linda is obsolete and has been
  removed from the archive as of 2008-03-04.  Linda overrides should
  probably be dropped from packages.
+
+Tag: wrong-file-owner-uid-or-gid
+Type: error
+Info: The user or group ID of the owner of the file is invalid. The
+ owner user and group IDs must be in the set of globally allocated
+ IDs, because other IDs are dynamically allocated and might be used
+ for varying purposes on different systems, or are reserved. The set
+ of the allowed, globally allocated IDs consists of the ranges 0-99,
+ 64000-64999 and 65534.
+Ref: policy 9.2

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-12 07:13:25 UTC (rev 1258)
+++ trunk/debian/changelog  2008-03-12 07:45:30 UTC (rev 1259)
@@ -19,6 +19,8 @@
 + [RA] /etc/init.d/{skeleton,README} don't need to be executable.
 + [RA] Warn about linda overrides since linda has been removed from
   the archive.  Thanks, Y Giridhar Appaji Nag.  (Closes: #469603)
++ [RA] Check for numeric owners or groups outside of the reserved
+  static ranges.  Patch from Håkon Stordahl.  (Closes: #469924)
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
 + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex
@@ -39,6 +41,9 @@
 
   * unpack/list-srcpkg:
 + [RA] Fix syntax error introduced by Uploaders support.
+  * unpack/unpack-binpkg-l1:
++ [RA] Extract a tar listing with numeric owners and groups into
+  index-owner-id in the lab.
 
  -- Russ Allbery [EMAIL PROTECTED]  Tue, 04 Mar 2008 13:07:18 -0800
 

Modified: trunk/testset/filenames/debian/rules
===
--- trunk/testset/filenames/debian/rules2008-03-12 07:13:25 UTC (rev 
1258)
+++ trunk/testset/filenames/debian/rules2008-03-12 07:45:30 UTC (rev 
1259)
@@ -125,6 +125,13 @@
touch debian/tmp/usr/bin/bin/bad
chmod 755 debian/tmp/usr/bin/bin/bad
 
+   # Create some files with invalid ownership.
+   set -e; for owner in 100:0 0:2001 30001:65535 65535:65001; do \
+ touch debian/tmp/usr/lib/filenames/wrong-owner-$$owner ; \
+ chmod 644 debian/tmp/usr/lib/filenames/wrong-owner-$$owner ; \
+ chown $$owner debian/tmp/usr/lib/filenames/wrong-owner-$$owner

lintian: r1260 - in trunk: debian frontend

2008-03-12 Thread rra

Author: rra
Date: 2008-03-12 08:48:39 +0100 (Wed, 12 Mar 2008)
New Revision: 1260

Modified:
   trunk/debian/changelog
   trunk/frontend/lintian
Log:
* frontend/lintian:
  + [RA] Qualify relative --root directories so that we don't break
later.  Patch from H?\195?\165kon Stordahl.  (Closes: #469925)

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-12 07:45:30 UTC (rev 1259)
+++ trunk/debian/changelog  2008-03-12 07:48:39 UTC (rev 1260)
@@ -39,6 +39,10 @@
   * data/shared-libs/ldconfig-dirs:
 + [RA] New file listing directories searched by ld.so.
 
+  * frontend/lintian:
++ [RA] Qualify relative --root directories so that we don't break
+  later.  Patch from Håkon Stordahl.  (Closes: #469925)
+
   * unpack/list-srcpkg:
 + [RA] Fix syntax error introduced by Uploaders support.
   * unpack/unpack-binpkg-l1:

Modified: trunk/frontend/lintian
===
--- trunk/frontend/lintian  2008-03-12 07:45:30 UTC (rev 1259)
+++ trunk/frontend/lintian  2008-03-12 07:48:39 UTC (rev 1260)
@@ -295,9 +295,16 @@
 GetOptions(%opthash)
 or die(error parsing options\n);
 
+# determine current working directory--we'll need this later
+chop($cwd = `pwd`);
+
 # determine LINTIAN_ROOT if it was not set with --root.
 $LINTIAN_ROOT = $LINTIAN_ROOT || $ENV{'LINTIAN_ROOT'};
-if (defined $LINTIAN_ROOT) { # see if it has a frontend directory
+if (defined $LINTIAN_ROOT) {
+unless ($LINTIAN_ROOT =~ m,^/,) {
+   $LINTIAN_ROOT = $cwd/$LINTIAN_ROOT;
+}
+# see if it has a frontend directory
 if (-d $LINTIAN_ROOT/frontend) {
 $lintian_info_cmd = $LINTIAN_ROOT/frontend/lintian-info;
 }
@@ -340,9 +347,6 @@
 print STDERR warning: lintian's authors do not recommend running it with 
root privileges!\n;
 }
 
-# determine current working directory--we'll need this later
-chop($cwd = `pwd`);
-
 # search for configuration file if it was not set with --cfg
 # do not search the default locations if it was set.
 if ($LINTIAN_CFG) {


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1262 - in trunk: checks debian testset testset/filenames/debian

2008-03-12 Thread rra

Author: rra
Date: 2008-03-12 09:24:21 +0100 (Wed, 12 Mar 2008)
New Revision: 1262

Modified:
   trunk/checks/files
   trunk/checks/files.desc
   trunk/debian/changelog
   trunk/testset/filenames/debian/rules
   trunk/testset/tags.filenames
Log:
  + [RA] Issue errors for installing files under /var/www.  This isn't
in FHS, may not be the document root, and may break local files if
it is the document root.  Thanks, Joerg Jaspert.  (Closes: #470403)

Modified: trunk/checks/files
===
--- trunk/checks/files  2008-03-12 07:56:07 UTC (rev 1261)
+++ trunk/checks/files  2008-03-12 08:24:21 UTC (rev 1262)
@@ -458,6 +458,13 @@
 elsif ($type ne 'udeb' and $file =~ m,^var/lib/games/.,) {
tag non-standard-dir-in-var, $file;
 }
+#  /var/www
+# Packages are allowed to create /var/www since it's historically been the
+# default document root, but they shouldn't be installing stuff under that
+# directory.
+elsif ($file =~ m,^var/www/\S+,) {
+   tag dir-or-file-in-var-www, $file;
+}
 #  /opt
 elsif ($file =~ m,^opt/.,) {
tag dir-or-file-in-opt, $file;

Modified: trunk/checks/files.desc
===
--- trunk/checks/files.desc 2008-03-12 07:56:07 UTC (rev 1261)
+++ trunk/checks/files.desc 2008-03-12 08:24:21 UTC (rev 1262)
@@ -377,6 +377,25 @@
 Type: error
 Info: Documentation files should be owned by ttroot/root/tt.
 
+Tag: dir-or-file-in-var-www
+Type: error
+Ref: fhs 5
+Info: Debian packages should not install files under tt/var/www/tt.
+ This is not one of the tt/var/tt directories in the File Hierarchy
+ Standard and is under the control of the local administrator.  Packages
+ should not assume that it is the document root for a web server; it is
+ very common for users to change the default document root and packages
+ should not assume that users will keep any particular setting.
+ .
+ Packages that want to make files available via an installed web server
+ should instead put instructions for the local administrator in a
+ README.Debian file and ideally include configuration fragments for common
+ web servers such as Apache.
+ .
+ As an exception, packages are permitted to create the tt/var/www/tt
+ directory due to its past history as the default document root, but
+ should at most copy over a default file in postinst for a new install.
+
 Tag: dir-or-file-in-tmp
 Type: error
 Info: Packages should not install into tt/tmp/tt or tt/var/tmp/tt.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-12 07:56:07 UTC (rev 1261)
+++ trunk/debian/changelog  2008-03-12 08:24:21 UTC (rev 1262)
@@ -21,6 +21,9 @@
   the archive.  Thanks, Y Giridhar Appaji Nag.  (Closes: #469603)
 + [RA] Check for numeric owners or groups outside of the reserved
   static ranges.  Patch from Håkon Stordahl.  (Closes: #469924)
++ [RA] Issue errors for installing files under /var/www.  This isn't
+  in FHS, may not be the document root, and may break local files if
+  it is the document root.  Thanks, Joerg Jaspert.  (Closes: #470403)
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
 + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex

Modified: trunk/testset/filenames/debian/rules
===
--- trunk/testset/filenames/debian/rules2008-03-12 07:56:07 UTC (rev 
1261)
+++ trunk/testset/filenames/debian/rules2008-03-12 08:24:21 UTC (rev 
1262)
@@ -136,6 +136,9 @@
gzip -9 debian/tmp/usr/share/doc/filenames/Changes
ln -s Changes.gz debian/tmp/usr/share/doc/filenames/changelog.gz
 
+   install -d debian/tmp/var/www
+   echo foo  debian/tmp/var/www/foo
+
install -d debian/tmp/srv/foo
touch debian/tmp/srv/foo/bar
 

Modified: trunk/testset/tags.filenames
===
--- trunk/testset/tags.filenames2008-03-12 07:56:07 UTC (rev 1261)
+++ trunk/testset/tags.filenames2008-03-12 08:24:21 UTC (rev 1262)
@@ -4,6 +4,7 @@
 E: filenames: bad-menu-file-name usr/share/menu/menu
 E: filenames: dir-or-file-in-srv srv/foo/
 E: filenames: dir-or-file-in-srv srv/foo/bar
+E: filenames: dir-or-file-in-var-www var/www/foo
 E: filenames: file-in-etc-not-marked-as-conffile /etc/gconf/schemas/test.schema
 E: filenames: lengthy-symlink usr/lib/filenames/symlink4wrong 
../filenames/symlink2
 E: filenames: lengthy-symlink usr/share/doc/filenames/version.txt.gz 
../filenames/doc/version6.txt.gz


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1263 - in trunk: checks debian

2008-03-12 Thread rra

Author: rra
Date: 2008-03-12 18:52:44 +0100 (Wed, 12 Mar 2008)
New Revision: 1263

Modified:
   trunk/checks/changelog-file
   trunk/debian/changelog
Log:
* checks/changelog-file:
  + [RA] Quash more Perl warnings on badly malformed NEWS.Debian files.

Modified: trunk/checks/changelog-file
===
--- trunk/checks/changelog-file 2008-03-12 08:24:21 UTC (rev 1262)
+++ trunk/checks/changelog-file 2008-03-12 17:52:44 UTC (rev 1263)
@@ -172,9 +172,9 @@
 }
 
 # Some checks on the most recent entry.
-if ($changes-data) {
+if ($changes-data and defined (($changes-data)[0])) {
 ($news) = $changes-data;
-if ($news-Distribution =~ /unreleased/i) {
+if ($news-Distribution  $news-Distribution =~ /unreleased/i) {
 tag debian-news-entry-has-strange-distribution, 
$news-Distribution;
 }
 spelling_check('spelling-error-in-news-debian', $news-Changes);
@@ -320,7 +320,7 @@
 }
 
 # Compare against NEWS.Debian if available.
-if ($news and $entry-Version eq $news-Version) {
+if ($news and $news-Version and $entry-Version eq $news-Version) {
 for my $field (qw/Distribution Urgency/) {
 if ($entry-$field ne $news-$field) {
 tag 'changelog-news-debian-mismatch', lc ($field),

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-12 08:24:21 UTC (rev 1262)
+++ trunk/debian/changelog  2008-03-12 17:52:44 UTC (rev 1263)
@@ -5,6 +5,8 @@
   multiarch directories.  (Closes: #469301)
 + [RA] Suggest an override for arch: all packages containing binaries
   independent of the host architecture (such as for cross-compiles).
+  * checks/changelog-file:
++ [RA] Quash more Perl warnings on badly malformed NEWS.Debian files.
   * checks/copyright-file{.desc,}:
 + [RA] Document handling of false positives for GPL, GFDL, and LGPL
   license references and catch the GFDL 1.1 false positive.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1264 - in trunk: debian lib

2008-03-12 Thread rra

Author: rra
Date: 2008-03-13 00:01:25 +0100 (Thu, 13 Mar 2008)
New Revision: 1264

Modified:
   trunk/debian/changelog
   trunk/lib/Spelling.pm
Log:
* lib/Spelling.pm:
  + [RA] Avoid Perl warnings when called with an uninitialized value.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-12 17:52:44 UTC (rev 1263)
+++ trunk/debian/changelog  2008-03-12 23:01:25 UTC (rev 1264)
@@ -48,6 +48,9 @@
 + [RA] Qualify relative --root directories so that we don't break
   later.  Patch from Håkon Stordahl.  (Closes: #469925)
 
+  * lib/Spelling.pm:
++ [RA] Avoid Perl warnings when called with an uninitialized value.
+
   * unpack/list-srcpkg:
 + [RA] Fix syntax error introduced by Uploaders support.
   * unpack/unpack-binpkg-l1:

Modified: trunk/lib/Spelling.pm
===
--- trunk/lib/Spelling.pm   2008-03-12 17:52:44 UTC (rev 1263)
+++ trunk/lib/Spelling.pm   2008-03-12 23:01:25 UTC (rev 1264)
@@ -398,6 +398,7 @@
 # not defined, it will be omitted.
 sub spelling_check {
 my ($tag, $text, $filename) = @_;
+next unless $text;
 
 for my $word (split(/\s+/, $text)) {
 $word = lc $word;


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1265 - trunk/checks

2008-03-12 Thread rra

Author: rra
Date: 2008-03-13 02:39:19 +0100 (Thu, 13 Mar 2008)
New Revision: 1265

Modified:
   trunk/checks/files
Log:
Minor improvement to handle a trailing 0 in the numeric ID index.


Modified: trunk/checks/files
===
--- trunk/checks/files  2008-03-12 23:01:25 UTC (rev 1264)
+++ trunk/checks/files  2008-03-13 01:39:19 UTC (rev 1265)
@@ -884,7 +884,7 @@
 }
 close(IN);
 
-fail(mismatching contents of index files) if NUMERIC;
+fail(mismatching contents of index files) if defined NUMERIC;
 close(NUMERIC);
 
 #check for sect: games but nothing in /usr/games. Check for any binary to


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1251 - in trunk: checks debian

2008-03-07 Thread rra

Author: rra
Date: 2008-03-07 09:24:46 +0100 (Fri, 07 Mar 2008)
New Revision: 1251

Modified:
   trunk/checks/copyright-file
   trunk/checks/copyright-file.desc
   trunk/debian/changelog
Log:
* checks/copyright-file{.desc,}:
  + [RA] Document handling of false positives for GPL, GFDL, and LGPL
license references and catch the GFDL 1.1 false positive.

Modified: trunk/checks/copyright-file
===
--- trunk/checks/copyright-file 2008-03-05 17:49:53 UTC (rev 1250)
+++ trunk/checks/copyright-file 2008-03-07 08:24:46 UTC (rev 1251)
@@ -219,6 +219,7 @@
 || m/LaTeX Project Public License/
 || m/(^From:.*^To:|^To:.*^From:).*(GNU General Public License|GPL)/ms
 || m/AFFERO GENERAL PUBLIC LICENSE/
+|| m/GNU Free Documentation License\s*Version 1\.1/
 || $wrong_directory_detected) {
 # False positive or correct reference.  Ignore.
 } elsif (m/GNU Free Documentation License/i or m/\bGFDL\b/) {

Modified: trunk/checks/copyright-file.desc
===
--- trunk/checks/copyright-file.desc2008-03-05 17:49:53 UTC (rev 1250)
+++ trunk/checks/copyright-file.desc2008-03-07 08:24:46 UTC (rev 1251)
@@ -142,6 +142,11 @@
  copyright file for this package, but the copyright file does not
  reference tt/usr/share/common-licenses/tt as the location of the GPL
  on Debian systems.
+ .
+ If the package uses some other license that just mentions the GPL and
+ that Lintian should detect as an exception, please file a Lintian bug.
+ If the copyright file must mention the GPL for reasons other than stating
+ the license of the package, please add a Lintian override.
 
 Tag: copyright-should-refer-to-common-license-file-for-gfdl
 Type: error
@@ -150,6 +155,11 @@
  copyright file for this package, but the copyright file does not
  reference tt/usr/share/common-licenses/tt as the location of the GFDL
  on Debian systems.
+ .
+ If the package uses some other license that just mentions the GFDL and
+ that Lintian should detect as an exception, please file a Lintian bug.
+ If the copyright file must mention the GPL for reasons other than stating
+ the license of the package, please add a Lintian override.
 
 Tag: copyright-should-refer-to-common-license-file-for-lgpl
 Type: error
@@ -159,6 +169,11 @@
  package, but the copyright file does not reference
  tt/usr/share/common-licenses/tt as the location of the LGPL on Debian
  systems.
+ .
+ If the package uses some other license that just mentions the LGPL and
+ that Lintian should detect as an exception, please file a Lintian bug.
+ If the copyright file must mention the GPL for reasons other than stating
+ the license of the package, please add a Lintian override.
 
 Tag: copyright-lists-upstream-authors-with-dh_make-boilerplate
 Type: warning

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-05 17:49:53 UTC (rev 1250)
+++ trunk/debian/changelog  2008-03-07 08:24:46 UTC (rev 1251)
@@ -5,6 +5,9 @@
   multiarch directories.  (Closes: #469301)
 + [RA] Suggest an override for arch: all packages containing binaries
   independent of the host architecture (such as for cross-compiles).
+  * checks/copyright-file{.desc,}:
++ [RA] Document handling of false positives for GPL, GFDL, and LGPL
+  license references and catch the GFDL 1.1 false positive.
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
   * checks/shared-libs:


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1252 - in trunk: checks debian

2008-03-07 Thread rra

Author: rra
Date: 2008-03-07 09:30:06 +0100 (Fri, 07 Mar 2008)
New Revision: 1252

Modified:
   trunk/checks/cruft
   trunk/debian/changelog
Log:
* checks/cruft:
  + [RA] Subversion conflicts generate three files, two with revision
numbers and one with .mine.  Only warn about the revision numbers;
.mine probably won't occur alone and may be a false positive.

Modified: trunk/checks/cruft
===
--- trunk/checks/cruft  2008-03-07 08:24:46 UTC (rev 1251)
+++ trunk/checks/cruft  2008-03-07 08:30:06 UTC (rev 1252)
@@ -65,7 +65,7 @@
  [ qr,^(.+/)?svk-commit.+\.tmp$,  = 'svk-commit-file'],
  [ qr,^(.+/)?\.arch-inventory$,   = 'arch-inventory-file'],
  [ qr,^(.+/)?\.\#(.+?)\.\d+(\.\d+)*$, = 'cvs-conflict-copy'  ],
- [ qr,^(.+/)?(.+?)\.(r\d+|mine)$, = 'svn-conflict-file'  ],
+ [ qr,^(.+/)?(.+?)\.(r\d+)$,  = 'svn-conflict-file'  ],
  [ qr,\.(orig|rej)$,  = 'patch-failure-file',  1 ],
  [ qr,((^|/)\.[^/]+\.swp|~)$, = 'editor-backup-file',  1 ],
 );

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-07 08:24:46 UTC (rev 1251)
+++ trunk/debian/changelog  2008-03-07 08:30:06 UTC (rev 1252)
@@ -8,6 +8,10 @@
   * checks/copyright-file{.desc,}:
 + [RA] Document handling of false positives for GPL, GFDL, and LGPL
   license references and catch the GFDL 1.1 false positive.
+  * checks/cruft:
++ [RA] Subversion conflicts generate three files, two with revision
+  numbers and one with .mine.  Only warn about the revision numbers;
+  .mine probably won't occur alone and may be a false positive.
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
   * checks/shared-libs:


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1253 - trunk/testset

2008-03-07 Thread rra

Author: rra
Date: 2008-03-07 09:36:23 +0100 (Fri, 07 Mar 2008)
New Revision: 1253

Modified:
   trunk/testset/tags.filenames
Log:
We no longer signal *.mine files as conflict files.


Modified: trunk/testset/tags.filenames
===
--- trunk/testset/tags.filenames2008-03-07 08:30:06 UTC (rev 1252)
+++ trunk/testset/tags.filenames2008-03-07 08:36:23 UTC (rev 1253)
@@ -47,7 +47,6 @@
 W: filenames source: diff-contains-svk-commit-file files/svk-commitsEr9P.tmp
 W: filenames source: diff-contains-svn-commit-file files/svn-commit.tmp
 W: filenames source: diff-contains-svn-conflict-file files/Maelstrom 
Sounce.r121
-W: filenames source: diff-contains-svn-conflict-file files/Maelstrom Sound.mine
 W: filenames source: diff-contains-svn-control-dir .svn
 W: filenames source: no-section-field-for-source
 W: filenames: bad-permissions-for-ali-file usr/lib/ada/adalib/test.ali


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1254 - in trunk: checks debian testset

2008-03-07 Thread rra

Author: rra
Date: 2008-03-07 09:37:05 +0100 (Fri, 07 Mar 2008)
New Revision: 1254

Modified:
   trunk/checks/etcfiles
   trunk/debian/changelog
   trunk/testset/tags.scripts
Log:
* checks/etcfiles:
  + [RA] /etc/init.d/{skeleton,rc,rcS} are not conffiles, and README
files in /etc need not be.

Modified: trunk/checks/etcfiles
===
--- trunk/checks/etcfiles   2008-03-07 08:36:23 UTC (rev 1253)
+++ trunk/checks/etcfiles   2008-03-07 08:37:05 UTC (rev 1254)
@@ -61,8 +61,12 @@
 # skip it unless it is a file in /etc
 next unless $file =~ m,^etc, and $perm =~ m,^-,;
 
-# if there is a /etc/foo, it must be a conffile
-if (not exists($conffiles{$file})) {
+# If there is a /etc/foo, it must be a conffile (with a few exceptions).
+if (not exists($conffiles{$file})
+   and $file !~ m,/README$,
+   and $file ne 'etc/init.d/skeleton'
+   and $file ne 'etc/init.d/rc'
+   and $file ne 'etc/init.d/rcS') {
tag file-in-etc-not-marked-as-conffile, /$file;
 }
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-07 08:36:23 UTC (rev 1253)
+++ trunk/debian/changelog  2008-03-07 08:37:05 UTC (rev 1254)
@@ -12,6 +12,9 @@
 + [RA] Subversion conflicts generate three files, two with revision
   numbers and one with .mine.  Only warn about the revision numbers;
   .mine probably won't occur alone and may be a false positive.
+  * checks/etcfiles:
++ [RA] /etc/init.d/{skeleton,rc,rcS} are not conffiles, and README
+  files in /etc need not be.
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
   * checks/shared-libs:

Modified: trunk/testset/tags.scripts
===
--- trunk/testset/tags.scripts  2008-03-07 08:36:23 UTC (rev 1253)
+++ trunk/testset/tags.scripts  2008-03-07 08:37:05 UTC (rev 1254)
@@ -3,7 +3,6 @@
 E: scripts: calls-suidperl-directly ./usr/bin/suidperlfoo
 E: scripts: copyright-file-lacks-pointer-to-perl-license
 E: scripts: duplicate-updaterc.d-calls-in-postrm lsb-other
-E: scripts: file-in-etc-not-marked-as-conffile /etc/init.d/skeleton
 E: scripts: init.d-script-does-not-implement-required-option 
/etc/init.d/lsb-broken force-reload
 E: scripts: init.d-script-does-not-implement-required-option 
/etc/init.d/lsb-broken restart
 E: scripts: init.d-script-has-duplicate-lsb-section /etc/init.d/lsb-broken


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1255 - in trunk: checks debian testset/scripts/debian

2008-03-07 Thread rra

Author: rra
Date: 2008-03-07 09:59:34 +0100 (Fri, 07 Mar 2008)
New Revision: 1255

Modified:
   trunk/checks/files
   trunk/checks/scripts
   trunk/debian/changelog
   trunk/testset/scripts/debian/rules
Log:
* checks/files:
  + [RA] /etc/init.d/{skeleton,README} don't need to be executable.
  + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex
files do not need to be executable even if they look like scripts.

Modified: trunk/checks/files
===
--- trunk/checks/files  2008-03-07 08:37:05 UTC (rev 1254)
+++ trunk/checks/files  2008-03-07 08:59:34 UTC (rev 1255)
@@ -173,7 +173,9 @@
tag package-installs-into-etc-gconf-schemas, $file;
}
#  /etc/init.d
-   elsif ($file =~ m,^etc/init\.d/\S, and $operm != 0755
+   elsif ($file =~ m,^etc/init\.d/\S,
+  and $file !~ m,^etc/init\.d/(README|skeleton)$,
+  and $operm != 0755
   and $perm =~ m/^-/) {
tag non-standard-file-permissions-for-etc-init.d-script,
sprintf($file %04o != 0755,$operm);

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-03-07 08:37:05 UTC (rev 1254)
+++ trunk/checks/scripts2008-03-07 08:59:34 UTC (rev 1255)
@@ -269,11 +269,14 @@
unless $is_absolute;
 tag(script-not-executable, $filename)
unless ($executable{$filename}
-   or $filename =~ m,usr/(lib|share)/.*\.pm,
-   or $filename =~ m,usr/(lib|share)/ruby/.*\.rb,
+   or $filename =~ m,^\./usr/(lib|share)/.*\.pm,
+   or $filename =~ m,^\./usr/(lib|share)/.*\.py,
+   or $filename =~ m,^\./usr/(lib|share)/ruby/.*\.rb,
or $filename =~ m,\.in$,
-   or $filename =~ m,etc/menu-methods,
-   or $filename =~ m,etc/X11/Xsession.d,);
+   or $filename =~ m,\.ex$,
+   or $filename eq './etc/init.d/skeleton'
+   or $filename =~ m,^\./etc/menu-methods,
+   or $filename =~ m,^\./etc/X11/Xsession.d,);
 
 # Warn about csh scripts.
 tag(csh-considered-harmful, $filename)

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-07 08:37:05 UTC (rev 1254)
+++ trunk/debian/changelog  2008-03-07 08:59:34 UTC (rev 1255)
@@ -15,8 +15,12 @@
   * checks/etcfiles:
 + [RA] /etc/init.d/{skeleton,rc,rcS} are not conffiles, and README
   files in /etc need not be.
+  * checks/files:
++ [RA] /etc/init.d/{skeleton,README} don't need to be executable.
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
++ [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex
+  files do not need to be executable even if they look like scripts.
   * checks/shared-libs:
 + [RA] Move the default ld.so search path into data.  Drop obsolete
   /usr/lib/libg++-dbg, /usr/X11R6/lib/Xaw3d, and libc5 compatibility

Modified: trunk/testset/scripts/debian/rules
===
--- trunk/testset/scripts/debian/rules  2008-03-07 08:37:05 UTC (rev 1254)
+++ trunk/testset/scripts/debian/rules  2008-03-07 08:59:34 UTC (rev 1255)
@@ -48,7 +48,7 @@
install -m 755 gccbug.dpatch $(tmp)/usr/share/scripts/
install -m 755 gccbug.dpatch $(tmp)/usr/src/scripts/
 
-   install -m 755 init-skeleton $(tmp)/etc/init.d/skeleton
+   install -m 644 init-skeleton $(tmp)/etc/init.d/skeleton
install -m 755 init-no-lsb $(tmp)/etc/init.d/no-lsb
install -m 755 init-lsb-broken $(tmp)/etc/init.d/lsb-broken
install -m 755 init-lsb-other $(tmp)/etc/init.d/lsb-other


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1256 - in trunk: checks debian

2008-03-07 Thread rra

Author: rra
Date: 2008-03-07 10:05:37 +0100 (Fri, 07 Mar 2008)
New Revision: 1256

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
  + [RA] Add clisp, procmail, and rrdcgi, and another way interpretors
are templated in *.in files.

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-03-07 08:59:34 UTC (rev 1255)
+++ trunk/checks/scripts2008-03-07 09:05:37 UTC (rev 1256)
@@ -47,6 +47,7 @@
  awk   = [ '/usr/bin', '' ],
  bash  = [ '/bin', '' ],
  bltwish   = [ '/usr/bin', 'blt' ],
+ clisp = [ '/usr/bin' ],
  csh   = [ '/bin', 'tcsh | csh | c-shell' ],
  dash  = [ '/bin' ],
  expect= [ '/usr/bin' ],
@@ -75,11 +76,13 @@
  pagsh = [ '/usr/bin', 'openafs-client | heimdal-clients' ],
  parrot= [ '/usr/bin' ],
  perl  = [ '/usr/bin', '' ],
+ procmail  = [ '/usr/bin' ],
  python= [ '/usr/bin', 'python | python-minimal' ],
  pforth= [ '/usr/bin' ],
  rc= [ '/usr/bin' ],
  regina= [ '/usr/bin', 'regina-rexx' ],
  rexx  = [ '/usr/bin', 'regina-rexx' ],
+ rrdcgi= [ '/usr/bin', 'rrdtool' ],
  ruby  = [ '/usr/bin' ],
  runhugs   = [ '/usr/bin', 'hugs | hugs98' ],
  sed   = [ '/bin', '' ],
@@ -249,7 +252,7 @@
 my ($base) = $interpreter =~ m,([^/]*)$,;
 
 # allow exception for .in files that have stuff like [EMAIL PROTECTED]@
-next if ($filename =~ m,\.in$, and $interpreter =~ m,[EMAIL PROTECTED]@$,);
+next if ($filename =~ m,\.in$, and $interpreter =~ 
m,^(\@|\)[A-Z_]+(\@|\)$,);
 
 my $is_absolute = ($interpreter =~ m,^/, or defined $calls_env);
 

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-07 08:59:34 UTC (rev 1255)
+++ trunk/debian/changelog  2008-03-07 09:05:37 UTC (rev 1256)
@@ -21,6 +21,8 @@
 + [RA] Attempt to quash some Perl warnings.
 + [RA] *.py files in /usr/{lib,share}, /etc/init.d/skeleton, and *.ex
   files do not need to be executable even if they look like scripts.
++ [RA] Add clisp, procmail, and rrdcgi, and another way interpretors
+  are templated in *.in files.
   * checks/shared-libs:
 + [RA] Move the default ld.so search path into data.  Drop obsolete
   /usr/lib/libg++-dbg, /usr/X11R6/lib/Xaw3d, and libc5 compatibility


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1250 - in trunk: checks debian

2008-03-05 Thread rra

Author: rra
Date: 2008-03-05 18:49:53 +0100 (Wed, 05 Mar 2008)
New Revision: 1250

Modified:
   trunk/checks/binaries.desc
   trunk/debian/changelog
Log:
* checks/binaries{.desc,}
  + [RA] Suggest an override for arch: all packages containing binaries
independent of the host architecture (such as for cross-compiles).

Modified: trunk/checks/binaries.desc
===
--- trunk/checks/binaries.desc  2008-03-05 02:25:32 UTC (rev 1249)
+++ trunk/checks/binaries.desc  2008-03-05 17:49:53 UTC (rev 1250)
@@ -9,7 +9,11 @@
 Tag: arch-independent-package-contains-binary-or-object
 Type: error
 Info: The package contains a binary or object file but is tagged
- `Architecture: all'.
+ Architecture: all.
+ .
+ If this package contains binaries or objects for cross-compiling or
+ binary blobs for other purposes independent of the host architecture
+ (such as BIOS updates or firmware), please add a Lintian override.
 
 Tag: unstripped-binary-or-object
 Type: error

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-05 02:25:32 UTC (rev 1249)
+++ trunk/debian/changelog  2008-03-05 17:49:53 UTC (rev 1250)
@@ -1,8 +1,10 @@
 lintian (1.23.47) UNRELEASED; urgency=low
 
-  * checks/binaries:
+  * checks/binaries{.desc,}
 + [RA] Permit architecture: all packages to have binaries in the
   multiarch directories.  (Closes: #469301)
++ [RA] Suggest an override for arch: all packages containing binaries
+  independent of the host architecture (such as for cross-compiles).
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
   * checks/shared-libs:


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1247 - in trunk: checks debian

2008-03-04 Thread rra

Author: rra
Date: 2008-03-04 22:13:58 +0100 (Tue, 04 Mar 2008)
New Revision: 1247

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
* checks/scripts:
  + [RA] Attempt to quash some Perl warnings.


Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-03-04 02:30:52 UTC (rev 1246)
+++ trunk/checks/scripts2008-03-04 21:13:58 UTC (rev 1247)
@@ -302,12 +302,12 @@
 my $versioned = 0;
 if (not defined $data) {
$data = $versioned_interpreters{$base};
-   undef $data if ($data  not defined ($data-[1]));
+   undef $data if ($data and not defined ($data-[1]));
if (not defined ($data) and $base =~ /^(.*[^\d.-])-?[\d.]+$/) {
$data = $versioned_interpreters{$1};
-   undef $data unless $base =~ /$data-[2]/;
+   undef $data unless ($data and $base =~ /$data-[2]/);
}
-   $versioned = 1;
+   $versioned = 1 if $data;
 }
 if ($data) {
my $expected = $data-[0] . '/' . $base;
@@ -578,25 +578,27 @@
# since this test is ugly, I have to do it by itself
# detect source (.) trying to pass args to the command it runs
if (not $found and m/^\s*(\.\s+[^\s;\`]+\s+([^\s;]+))/) {
-   if ($2 =~ /^(\|\||\d?|)/) {
+   my $extra;
+   ($match, $extra) = ($1, $2);
+   if ($extra =~ /^(\|\||\d?|)/) {
# everything is ok
;
} else {
$found = 1;
-   $match = $1;
}
}
 
# Ignore anything inside single quotes; it could be an
# argument to grep or the like.
my $line = $_;
-   $line =~ s/(^|[^\\](?:)*)\'(?:\\.|[^\\\'])+\'/$1''/g;
-
-   for my $re (@bashism_string_regexs) {
-   if ($line =~ m/($re)/) {
-   $found = 1;
-($match) = m/($re)/;
-   last;
+   unless ($found) {
+   $line =~ s/(^|[^\\](?:)*)\'(?:\\.|[^\\\'])+\'/$1''/g;
+   for my $re (@bashism_string_regexs) {
+   if ($line =~ m/($re)/) {
+   $found = 1;
+   ($match) = m/($re)/;
+   last;
+   }
}
}
 

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-04 02:30:52 UTC (rev 1246)
+++ trunk/debian/changelog  2008-03-04 21:13:58 UTC (rev 1247)
@@ -1,3 +1,10 @@
+lintian (1.23.47) UNRELEASED; urgency=low
+
+  * checks/scripts:
++ [RA] Attempt to quash some Perl warnings.
+
+ -- Russ Allbery [EMAIL PROTECTED]  Tue, 04 Mar 2008 13:07:18 -0800
+
 lintian (1.23.46) unstable; urgency=low
 
   The five Lintian committers! release.


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1248 - in trunk: checks data data/shared-libs debian

2008-03-04 Thread rra

Author: rra
Date: 2008-03-04 22:20:41 +0100 (Tue, 04 Mar 2008)
New Revision: 1248

Added:
   trunk/data/shared-libs/
   trunk/data/shared-libs/ldconfig-dirs
Modified:
   trunk/checks/shared-libs
   trunk/debian/changelog
Log:
* checks/shared-libs:
  + [RA] Move the default ld.so search path into data.  Drop obsolete
/usr/lib/libg++-dbg, /usr/X11R6/lib/Xaw3d, and libc5 compatibility
directories in the process.
* data/shared-libs/ldconfig-dirs:
  + [RA] New file listing directories searched by ld.so.

Modified: trunk/checks/shared-libs
===
--- trunk/checks/shared-libs2008-03-04 21:13:58 UTC (rev 1247)
+++ trunk/checks/shared-libs2008-03-04 21:20:41 UTC (rev 1248)
@@ -20,30 +20,16 @@
 
 package Lintian::shared_libs;
 use strict;
+
+use File::Basename;
+
+use Lintian::Data;
 use Dep;
 use Tags;
-use File::Basename;
 use Util;
 
 sub run {
 
-my %ldso_dir = map { $_ = 1 }
-qw( lib
-   lib32
-   lib64
-usr/lib
-   usr/lib32
-   usr/lib64
-usr/lib/libg++-dbg
-usr/X11R6/lib/Xaw3d
-usr/local/lib
-usr/X11R6/lib
-usr/lib/libc5-compat
-lib/libc5-compat
-   emul/ia32-linux/lib
-   emul/ia32-linux/usr/lib
-  );
-
 # Libraries that should only be used in the presence of certain capabilities
 # may be located in subdirectories of the standard ldconfig search path with
 # one of the following names.
@@ -63,6 +49,7 @@
sparc
   );
 
+my $ldconfig_dirs = Lintian::Data-new('shared-libs/ldconfig-dirs');
 my $file;
 my $must_call_ldconfig;
 my $postrm = control/postrm;
@@ -198,7 +185,7 @@
$last = $1;
} while ($last  $hwcap_dir{$last});
$dirname .= /$last if $last;
-   if (exists $ldso_dir{$dirname}) {
+   if ($ldconfig_dirs-known($dirname)) {
# yes! so postinst must call ldconfig
$must_call_ldconfig = $real_file;
}
@@ -219,9 +206,9 @@
tag shlib-with-executable-stack, $cur_file;
}
}
-} elsif (exists $objsomething{$cur_file} 
-exists $ldso_dir{dirname($cur_file)} 
-exists $sharedobject{$cur_file}) {
+} elsif (exists $objsomething{$cur_file}
+ $ldconfig_dirs-known(dirname($cur_file))
+ exists $sharedobject{$cur_file}) {
tag sharedobject-in-library-directory-missing-soname, $cur_file;
 }
 }
@@ -238,7 +225,7 @@
 my ($dir, $shlib_name) = $shlib_file =~ m,(.*)/([^/]+)$,;
 
 # not a public shared library, skip it
-next unless defined $ldso_dir{$dir};
+next unless $ldconfig_dirs-known($dir);
 
 # symlink found?
 my $link_file = $dir/$SONAME{$shlib_file};
@@ -313,7 +300,7 @@
if ($type ne 'udeb') {
for my $shlib (@shlibs) {
# skip it if it's not a public shared library
-   next unless defined $ldso_dir{dirname($shlib)};
+   next unless $ldconfig_dirs-known(dirname($shlib));
tag no-shlibs-control-file, $shlib;
}
}
@@ -357,7 +344,7 @@
$shlibs_control_used{udeb: .$shlib_name} = 1;
unless (exists $shlibs_control{$shlib_name}) {
# skip it if it's not a public shared library
-   next unless defined $ldso_dir{dirname($shlib)};
+   next unless $ldconfig_dirs-known(dirname($shlib));
# no!!
tag shlib-missing-in-control-file, $shlib_name, 'for', $shlib;
}

Added: trunk/data/shared-libs/ldconfig-dirs
===
--- trunk/data/shared-libs/ldconfig-dirs(rev 0)
+++ trunk/data/shared-libs/ldconfig-dirs2008-03-04 21:20:41 UTC (rev 
1248)
@@ -0,0 +1,31 @@
+# The list of directories searched by default by the dynamic linker.
+# Packages installing shared libraries into these directories must call
+# ldconfig, must have shlibs files, and must ensure those libraries have
+# proper SONAMEs.
+#
+# Directories listed here must not have leading slashes.
+
+# Standard library directories.
+lib
+usr/lib
+usr/local/lib
+
+# For 32-bit/64-bit multiarch support.
+lib32
+lib64
+usr/lib32
+usr/lib64
+
+# Used by the Debian amd64 port for 32-bit libraries.
+emul/ia32-linux/lib
+emul/ia32-linux/usr/lib
+
+# This is now obsolete, but is still in the standard ld.so.conf.
+usr/X11R6/lib
+
+# We intentionally do not include the multiarch directories like
+# /lib/i486-linux-gnu since libraries installed there may be only for
+# cross-compilation and not intended for the host operating system.  To
+# determine whether they're for the host, we'd need to apply more complex
+# logic to map the architecture of the Debian package to the appropriate
+# multiarch directory name.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-04

lintian: r1249 - in trunk: checks data data/binaries data/shared-libs debian testset testset/libbaz/debian

2008-03-04 Thread rra

Author: rra
Date: 2008-03-05 03:25:32 +0100 (Wed, 05 Mar 2008)
New Revision: 1249

Added:
   trunk/data/binaries/
   trunk/data/binaries/multiarch
Modified:
   trunk/checks/binaries
   trunk/data/shared-libs/ldconfig-dirs
   trunk/debian/changelog
   trunk/testset/libbaz/debian/control
   trunk/testset/libbaz/debian/rules
   trunk/testset/tags.libbaz
Log:
* checks/binaries:
  + [RA] Permit architecture: all packages to have binaries in the
multiarch directories.  (Closes: #469301)
  + [RA] Allow and expect ldconfig, SONAMEs, and shlibs treatment of
libraries in multiarch directories.
* data/binaries/multiarch:
  + [RA] New file listing multiarch binary directories.

Modified: trunk/checks/binaries
===
--- trunk/checks/binaries   2008-03-04 21:20:41 UTC (rev 1248)
+++ trunk/checks/binaries   2008-03-05 02:25:32 UTC (rev 1249)
@@ -170,9 +170,15 @@
 # binary or object file?
 next unless ($info =~ m/^[^,]*\bELF\b/) or ($info =~ m/\bcurrent ar 
archive\b/);
 
+# Warn about Architecture: all packages that contain shared libraries, but
+# only if those libraries aren't installed in a multiarch directory.  The
+# package may be a support package for cross-compiles.
 if ($arch eq 'all') {
-   # package is `Architecture: all' but contains libs!?
-   tag arch-independent-package-contains-binary-or-object, $file;
+   my ($arch) = ($file =~ m,^\./(?:usr/)?lib/([^/]+)/,);
+   my $multiarch = Lintian::Data-new('binaries/multiarch');
+   unless ($arch and $multiarch-known($arch)) {
+   tag arch-independent-package-contains-binary-or-object, $file;
+   }
 }
 
 # ELF?

Added: trunk/data/binaries/multiarch
===
--- trunk/data/binaries/multiarch   (rev 0)
+++ trunk/data/binaries/multiarch   2008-03-05 02:25:32 UTC (rev 1249)
@@ -0,0 +1,18 @@
+# Known multiarch directories.  Binaries under one of these directories
+# under /lib or /usr/lib are permitted in Architecture: all packages since
+# the package may be for multiarch support in a related architecture.
+#
+# See Bug#469301 and Bug#464796 for more details.
+
+# Regular Debian ports.
+arm-linux-gnu
+arm-linux-gnueabi
+i486-linux-gnu
+hppa-linux-gnu
+m68k-linux-gnu
+mips-linux-gnu
+mipsel-linux-gnu
+powerpc-linux-gnu
+s390-linux-gnu
+sparc-linux-gnu
+x86_64-linux-gnu

Modified: trunk/data/shared-libs/ldconfig-dirs
===
--- trunk/data/shared-libs/ldconfig-dirs2008-03-04 21:20:41 UTC (rev 
1248)
+++ trunk/data/shared-libs/ldconfig-dirs2008-03-05 02:25:32 UTC (rev 
1249)
@@ -23,9 +23,31 @@
 # This is now obsolete, but is still in the standard ld.so.conf.
 usr/X11R6/lib
 
-# We intentionally do not include the multiarch directories like
-# /lib/i486-linux-gnu since libraries installed there may be only for
-# cross-compilation and not intended for the host operating system.  To
-# determine whether they're for the host, we'd need to apply more complex
-# logic to map the architecture of the Debian package to the appropriate
-# multiarch directory name.
+# Multiarch directories.  Currently, these aren't used officially by the
+# project but ld.so looks in the ones native to the local platform.
+# Hopefully including the ones not native to the local platform won't
+# hurt.
+#
+# See Bug#469301 and Bug#464796 for more details.
+lib/arm-linux-gnu
+lib/arm-linux-gnueabi
+lib/i486-linux-gnu
+lib/hppa-linux-gnu
+lib/m68k-linux-gnu
+lib/mips-linux-gnu
+lib/mipsel-linux-gnu
+lib/powerpc-linux-gnu
+lib/s390-linux-gnu
+lib/sparc-linux-gnu
+lib/x86_64-linux-gnu
+usr/lib/arm-linux-gnu
+usr/lib/arm-linux-gnueabi
+usr/lib/i486-linux-gnu
+usr/lib/hppa-linux-gnu
+usr/lib/m68k-linux-gnu
+usr/lib/mips-linux-gnu
+usr/lib/mipsel-linux-gnu
+usr/lib/powerpc-linux-gnu
+usr/lib/s390-linux-gnu
+usr/lib/sparc-linux-gnu
+usr/lib/x86_64-linux-gnu

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-04 21:20:41 UTC (rev 1248)
+++ trunk/debian/changelog  2008-03-05 02:25:32 UTC (rev 1249)
@@ -1,12 +1,19 @@
 lintian (1.23.47) UNRELEASED; urgency=low
 
+  * checks/binaries:
++ [RA] Permit architecture: all packages to have binaries in the
+  multiarch directories.  (Closes: #469301)
   * checks/scripts:
 + [RA] Attempt to quash some Perl warnings.
   * checks/shared-libs:
 + [RA] Move the default ld.so search path into data.  Drop obsolete
   /usr/lib/libg++-dbg, /usr/X11R6/lib/Xaw3d, and libc5 compatibility
   directories in the process.
++ [RA] Allow and expect ldconfig, SONAMEs, and shlibs treatment of
+  libraries in multiarch directories.
 
+  * data/binaries/multiarch:
++ [RA] New file listing multiarch binary directories.
   * data/shared-libs/ldconfig-dirs

lintian: r1239 - in trunk: checks debian testset

2008-03-03 Thread rra

Author: rra
Date: 2008-03-03 22:52:56 +0100 (Mon, 03 Mar 2008)
New Revision: 1239

Modified:
   trunk/checks/shared-libs
   trunk/checks/shared-libs.desc
   trunk/debian/changelog
   trunk/testset/tags.debug
   trunk/testset/tags.libbaz
Log:
* checks/shared-libs{,desc}:
  + [RA] Rename sharedobject-in-library-directory-not-actually-a-shlib
to sharedobject-in-library-directory-missing-soname for clarity.
Thanks, Peter Eisentraut.  (Closes: #467425)

Modified: trunk/checks/shared-libs
===
--- trunk/checks/shared-libs2008-03-03 10:48:59 UTC (rev 1238)
+++ trunk/checks/shared-libs2008-03-03 21:52:56 UTC (rev 1239)
@@ -222,7 +222,7 @@
 } elsif (exists $objsomething{$cur_file} 
 exists $ldso_dir{dirname($cur_file)} 
 exists $sharedobject{$cur_file}) {
-   tag sharedobject-in-library-directory-not-actually-a-shlib, 
$cur_file;
+   tag sharedobject-in-library-directory-missing-soname, $cur_file;
 }
 }
 

Modified: trunk/checks/shared-libs.desc
===
--- trunk/checks/shared-libs.desc   2008-03-03 10:48:59 UTC (rev 1238)
+++ trunk/checks/shared-libs.desc   2008-03-03 21:52:56 UTC (rev 1239)
@@ -179,7 +179,7 @@
  in its postrm script.
 Ref: policy 8.1.1
 
-Tag: sharedobject-in-library-directory-not-actually-a-shlib
+Tag: sharedobject-in-library-directory-missing-soname
 Type: error
 Info: A shared object was identified in a library directory (i.e. a
  directory in the standard linker path) which doesn't have a SONAME.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 10:48:59 UTC (rev 1238)
+++ trunk/debian/changelog  2008-03-03 21:52:56 UTC (rev 1239)
@@ -66,6 +66,10 @@
 + [RA] Add warnings for dpkg --assert* flags for features that have
   been guaranteed for nearly a decade.  Thanks, Bernhard R. Link.
   (Closes: #467642)
+  * checks/shared-libs{,desc}:
++ [RA] Rename sharedobject-in-library-directory-not-actually-a-shlib
+  to sharedobject-in-library-directory-missing-soname for clarity.
+  Thanks, Peter Eisentraut.  (Closes: #467425)
 
   * frontend/lintian:
 + [CW] Make the presence of an Ubuntu release name in the version number

Modified: trunk/testset/tags.debug
===
--- trunk/testset/tags.debug2008-03-03 10:48:59 UTC (rev 1238)
+++ trunk/testset/tags.debug2008-03-03 21:52:56 UTC (rev 1239)
@@ -4,7 +4,7 @@
 E: hello: unstripped-binary-or-object ./usr/bin/hello.dbg
 E: libhello0-dbg: binary-with-bad-dynamic-table ./usr/lib/libhello.so.dbg
 E: libhello0-dbg: missing-dependency-on-libc needed by 
./usr/lib/debug/lib/libhello.so.0.0 and 1 others
-E: libhello0-dbg: sharedobject-in-library-directory-not-actually-a-shlib 
usr/lib/libhello.so.dbg
+E: libhello0-dbg: sharedobject-in-library-directory-missing-soname 
usr/lib/libhello.so.dbg
 I: debug source: non-standard-architecture kfreebsd-i386
 I: debug source: non-standard-architecture ppc64
 W: debug source: changelog-should-not-mention-nmu

Modified: trunk/testset/tags.libbaz
===
--- trunk/testset/tags.libbaz   2008-03-03 10:48:59 UTC (rev 1238)
+++ trunk/testset/tags.libbaz   2008-03-03 21:52:56 UTC (rev 1239)
@@ -11,7 +11,7 @@
 E: libbaz1: maintainer-shell-script-fails-syntax-check postinst
 E: libbaz1: missing-dependency-on-perlapi
 E: libbaz1: postinst-must-call-ldconfig usr/lib/libfoo2.so.1.0.3b
-E: libbaz1: sharedobject-in-library-directory-not-actually-a-shlib 
usr/lib/libbaz1.so.1.0.3b
+E: libbaz1: sharedobject-in-library-directory-missing-soname 
usr/lib/libbaz1.so.1.0.3b
 E: libbaz1: shlib-missing-in-control-file libbaz2 1.0 for 
usr/lib/libfoo2.so.1.0.3b
 E: libbaz1: shlib-with-executable-bit usr/lib/libfoo2.so.1.0.3b 0755
 E: libbaz1: shlib-with-non-pic-code usr/lib/libbaz3.so.1.0.3b


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1240 - in trunk: checks debian testset testset/binary/debian

2008-03-03 Thread rra

Author: rra
Date: 2008-03-03 23:06:16 +0100 (Mon, 03 Mar 2008)
New Revision: 1240

Modified:
   trunk/checks/menus
   trunk/checks/menus.desc
   trunk/debian/changelog
   trunk/testset/binary/debian/doc-base
   trunk/testset/tags.binary
Log:
* checks/menus{,desc}:
  + [RA] Check that doc-base files are encoded in UTF-8.  Thanks, Robert
Luberda.  (Closes: #468759)

Modified: trunk/checks/menus
===
--- trunk/checks/menus  2008-03-03 21:52:56 UTC (rev 1239)
+++ trunk/checks/menus  2008-03-03 22:06:16 UTC (rev 1240)
@@ -122,7 +122,6 @@
if ($perm =~ m,x,o) {
tag executable-in-usr-share-docbase, $file, 
sprintf(%04o,$operm);
}
-
$docbase_file = $file;
}
#menu-methods file?
@@ -180,7 +179,7 @@
 while (defined ($dbfile = readdir DOCBASEDIR)) {
# don't try to parse executables, plus we already warned about it
next if -x doc-base/$dbfile;
-   check_doc_base_file($dbfile);
+   check_doc_base_file($dbfile, $pkg, $type);
 }
 closedir DOCBASEDIR;
 } else {
@@ -217,14 +216,19 @@
 # ---
 
 sub check_doc_base_file {
-my $dbfile = shift;
+my ($dbfile, $pkg, $type) = @_;
 
+my $line = file_is_encoded_in_non_utf8(doc-base/$dbfile, $type, $pkg);
+if ($line) {
+   tag 'doc-base-file-uses-obsolete-national-encoding', $dbfile:$line;
+}
+
 open (IN, '', doc-base/$dbfile)
 or fail(cannot open doc-base file $dbfile for reading.);
 
 my (@files, $field, @vals);
 my $knownfields = \%known_docbase_main_fields;
-my $line= 0;  # global
+$line   = 0;  # global
 my %sawfields   = (); # local for each section of control file
 my %sawformats  = (); # global for control file
 

Modified: trunk/checks/menus.desc
===
--- trunk/checks/menus.desc 2008-03-03 21:52:56 UTC (rev 1239)
+++ trunk/checks/menus.desc 2008-03-03 22:06:16 UTC (rev 1240)
@@ -288,3 +288,14 @@
  separator.  The section separator is an empty line and should not contain
  any whitespace.
 Ref: Debian doc-base Manual section 2.3.2
+
+Tag: doc-base-file-uses-obsolete-national-encoding
+Type: error
+Info: doc-base files must be valid UTF-8, an encoding of the Unicode
+ character set.
+ .
+ There are many ways to convert a doc-base file from an obsolete encoding
+ like ISO-8859-1.  You may, for example, use iconv like:
+ .
+  $ iconv -f ISO-8859-1 -t UTF-8 doc-base gt; doc-base.new
+  $ mv doc-base.new doc-base

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 21:52:56 UTC (rev 1239)
+++ trunk/debian/changelog  2008-03-03 22:06:16 UTC (rev 1240)
@@ -50,6 +50,9 @@
 + [RA] When the menu or desktop file invokes a quoted command via an
   su program, don't try to check whether the command is in the
   package.  Thanks, Paul Wise.  (Closes: #45)
+  * checks/menus{,desc}:
++ [RA] Check that doc-base files are encoded in UTF-8.  Thanks, Robert
+  Luberda.  (Closes: #468759)
   * check/patch-systems:
 + [HE] Warn if the .diff.gz contains changes while the package uses
   a patch system. (Closes: #452215)

Modified: trunk/testset/binary/debian/doc-base
===
--- trunk/testset/binary/debian/doc-base2008-03-03 21:52:56 UTC (rev 
1239)
+++ trunk/testset/binary/debian/doc-base2008-03-03 22:06:16 UTC (rev 
1240)
@@ -5,7 +5,7 @@
   files, including several things that aren't tested yet.  The third and
   fourth one has trailing whitespace.
   .
- This section has a speling error.
+ This section has a speling error and bad � character.
  .
  The above separator was fine.
 Section: Non/Existant

Modified: trunk/testset/tags.binary
===
--- trunk/testset/tags.binary   2008-03-03 21:52:56 UTC (rev 1239)
+++ trunk/testset/tags.binary   2008-03-03 22:06:16 UTC (rev 1240)
@@ -18,6 +18,7 @@
 E: binary: doc-base-file-references-missing-file binary:34 
/usr/share/info/binary.info.gz
 E: binary: doc-base-file-unknown-field binary:12 unknown
 E: binary: doc-base-file-unknown-field binary:18 unknown
+E: binary: doc-base-file-uses-obsolete-national-encoding binary:8
 E: binary: doc-base-index-references-multiple-files binary:25
 E: binary: doc-base-invalid-document-field binary:1 binary!docs  
 E: binary: executable-desktop-file /usr/share/applications/goodbye.desktop 0755


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1241 - in trunk: checks debian lib testset/relations/debian

2008-03-03 Thread rra

Author: rra
Date: 2008-03-03 23:53:46 +0100 (Mon, 03 Mar 2008)
New Revision: 1241

Modified:
   trunk/checks/control-file
   trunk/debian/changelog
   trunk/lib/Dep.pm
   trunk/testset/relations/debian/control
Log:
* checks/control-file:
  + [RA] Skip empty dependencies for stronger-dependency-implies-weaker.
* lib/Dep.pm:
  + [RA] Skip empty dependencies, avoiding false positives for
stronger-dependency-implies-weaker.  Patch from Adam D. Barratt.
(Closes: #469222)

Modified: trunk/checks/control-file
===
--- trunk/checks/control-file   2008-03-03 22:06:16 UTC (rev 1240)
+++ trunk/checks/control-file   2008-03-03 22:53:46 UTC (rev 1241)
@@ -89,6 +89,7 @@
 for my $weak (($strong + 1) .. $#dep_fields) {
 next unless $control-{$dep_fields[$weak]};
 for my $dependency (split /\s*,\s*/, 
$control-{$dep_fields[$weak]}) {
+next unless $dependency;
 tag stronger-dependency-implies-weaker, $control-{package}, 
$dep_fields[$strong] - $dep_fields[$weak], $dependency
 if Dep::implies($parsed, Dep::parse($dependency));
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 22:06:16 UTC (rev 1240)
+++ trunk/debian/changelog  2008-03-03 22:53:46 UTC (rev 1241)
@@ -13,6 +13,8 @@
 + [RA] Accept (and ignore for now) the new Checksums-Sha1,
   Checksums-Sha256, and Checksums-Md5 fields in source packages.
   Thanks, Raphael Hertzog.  (Closes: #466979)
+  * checks/control-file:
++ [RA] Skip empty dependencies for stronger-dependency-implies-weaker.
   * checks/control-files{.desc,}:
 + [FL] Warn about empty control files. I can't see any use for
   them. Exclude udebs though, since they might differ there.
@@ -80,6 +82,10 @@
 + [RA] Fix option parsing bug leading lintian to incorrectly reject -a
   or -p without a package.
 
+  * lib/Dep.pm:
++ [RA] Skip empty dependencies, avoiding false positives for
+  stronger-dependency-implies-weaker.  Patch from Adam D. Barratt.
+  (Closes: #469222)
   * lib/Spelling.pm:
 + [RA] Add another spelling correction.
 + [RA] Merriam-Webster and the OED have both given up on publically

Modified: trunk/lib/Dep.pm
===
--- trunk/lib/Dep.pm2008-03-03 22:06:16 UTC (rev 1240)
+++ trunk/lib/Dep.pm2008-03-03 22:53:46 UTC (rev 1241)
@@ -67,6 +67,7 @@
 sub parse {
 my @deps;
 for (split(/\s*,\s*/, $_[0])) {
+   next if /^$/;
my @alts;
if (/^perl\s+\|\s+perl5$/ or /^perl5\s+\|\s+perl\s+/) {
$_ = 'perl5';
@@ -615,3 +616,9 @@
 }
 
 1;
+
+# Local Variables:
+# indent-tabs-mode: t
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 ts=8

Modified: trunk/testset/relations/debian/control
===
--- trunk/testset/relations/debian/control  2008-03-03 22:06:16 UTC (rev 
1240)
+++ trunk/testset/relations/debian/control  2008-03-03 22:53:46 UTC (rev 
1241)
@@ -17,7 +17,7 @@
 Architecture: all
 Section: contrib/misc
 Pre-Depends: awk|gawk
-Depends: relations( 3), dpkg, bash ( 2.0 ), mail-transport-agent, gawk | 
awk, foo ( 2.0), foo ( 2.2), coreutils, null (= 0), ${misc:Depends}
+Depends: relations( 3), dpkg, bash ( 2.0 ), mail-transport-agent, gawk | 
awk, foo ( 2.0), foo ( 2.2), coreutils, ,null (= 0), ${misc:Depends}
 Provides: mail-reader
 Replaces: relations
 Conflicts: foobar ( 55), foo, relations,


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1242 - in trunk: . checks data data/doc-base debian lib lib/Lintian testset testset/filenames/debian

2008-03-03 Thread rra

Author: rra
Date: 2008-03-04 01:39:52 +0100 (Tue, 04 Mar 2008)
New Revision: 1242

Added:
   trunk/data/
   trunk/data/README
   trunk/data/doc-base/
   trunk/data/doc-base/sections
   trunk/lib/Lintian/
   trunk/lib/Lintian/Data.pm
   trunk/testset/filenames/debian/doc-base
Modified:
   trunk/checks/menus
   trunk/checks/menus.desc
   trunk/debian/changelog
   trunk/debian/dirs
   trunk/debian/rules
   trunk/testset/filenames/debian/rules
   trunk/testset/tags.binary
   trunk/testset/tags.filenames
Log:
  + [RA] Check doc-base sections against the new canonical list.
Thanks, Robert Luberda.  (Closes: #463474)
* data/doc-base/sections:
  + [RA] New file listing known doc-base sections.
* debian/dirs:
  + [RA] Install the base directory for the Lintian root here.
* debian/rules:
  + [RA] Redo the installation rules to support arbitrary nesting under
the copied directories.  As a side effect, install
lib/Tags/ColonSeparated.pm, unbreaking the experimental
colon-separated output format.
* lib/Lintian/Data.pm:
  + [RA] New module for loading and querying lists of keywords.

Modified: trunk/checks/menus
===
--- trunk/checks/menus  2008-03-03 22:53:46 UTC (rev 1241)
+++ trunk/checks/menus  2008-03-04 00:39:52 UTC (rev 1242)
@@ -24,6 +24,8 @@
 use strict;
 use lib $ENV{'LINTIAN_ROOT'}/checks/;
 use common_data;
+
+use Lintian::Data;
 use Spelling;
 use Tags;
 use Util;
@@ -384,6 +386,13 @@
  join (' ', @$vals), $dbfile:$line);
 }
 
+# Section field.
+} elsif ($field eq 'section') {
+   my $sections = Lintian::Data-new('doc-base/sections');
+   $_ = join (' ', @$vals);
+   tag doc-base-unknown-section, $dbfile:$line, $_
+   unless $sections-known($_);
+
 # Abstract field.
 } elsif ($field eq 'abstract') {
 # The three following variables are used for checking if the field is

Modified: trunk/checks/menus.desc
===
--- trunk/checks/menus.desc 2008-03-03 22:53:46 UTC (rev 1241)
+++ trunk/checks/menus.desc 2008-03-04 00:39:52 UTC (rev 1242)
@@ -299,3 +299,11 @@
  .
   $ iconv -f ISO-8859-1 -t UTF-8 doc-base gt; doc-base.new
   $ mv doc-base.new doc-base
+Ref: Debian doc-base Manual section 2.3.2
+
+Tag: doc-base-unknown-section
+Type: warning
+Info: The section indicated in this doc-base control file is not one of
+ the standard doc-base sections.  The doc-base sections are based on the
+ menu sections but are not exactly the same.
+Ref: Debian doc-base Manual section 2.3.3

Added: trunk/data/README
===
--- trunk/data/README   (rev 0)
+++ trunk/data/README   2008-03-04 00:39:52 UTC (rev 1242)
@@ -0,0 +1,12 @@
+This directory contains files loaded by the Lintian::Data module,
+specifically lists of keywords used in various Lintian checks.  For all
+files in this directory, blank lines are ignored, as are lines beginning
+with #.
+
+For each list of keywords, please include in a comment the origin of the
+list, any information about how to resynchronize the list with that
+origin, and any special exceptions or caveats.
+
+Files should generally be organized into subdirectory by check or by
+general class of lists (for example, all lists related to doc-base files
+should go into a doc-base subdirectory).

Added: trunk/data/doc-base/sections
===
--- trunk/data/doc-base/sections(rev 0)
+++ trunk/data/doc-base/sections2008-03-04 00:39:52 UTC (rev 1242)
@@ -0,0 +1,73 @@
+# Taken from /usr/share/doc-base/data/sections.list.
+#
+# Last synchronized with doc-base 0.8.10 (2008-02-22).
+
+Accessibility
+Amateur Radio
+Data Management
+Debian
+Editors
+Education
+Emulators
+File Management
+Games/Action
+Games/Adventure
+Games/Blocks
+Games/Board
+Games/Card
+Games/Puzzles
+Games/Simulation
+Games/Strategy
+Games/Tools
+Games/Toys
+Graphics
+Help
+Help/Books
+Help/FAQ
+Help/HOWTO
+Help/RFC
+Help/Standards
+Mobile Devices
+Network/Communication
+Network/File Transfer
+Network/Monitoring
+Network/Web Browsing
+Network/Web News
+Office
+Programming
+Programming/C
+Programming/C++
+Programming/Java
+Programming/Perl
+Programming/Python
+Programming/Ruby
+Project Management
+Science/Astronomy
+Science/Biology
+Science/Chemistry
+Science/Data Analysis
+Science/Electronics
+Science/Engineering
+Science/Geoscience
+Science/Mathematics
+Science/Medicine
+Science/Physics
+Science/Social
+Screen
+Screen/Saving
+Screen/Locking
+Shells
+Sound
+System/Administration
+System/Hardware
+System/Language Environment
+System/Monitoring
+System/Package Management
+System/Security
+Terminal Emulators
+Text
+TV and Radio
+Viewers
+Video
+Web Development
+Window Managers

Modified: trunk/debian/changelog

lintian: r1243 - in trunk: debian lib reporting reporting/templates unpack

2008-03-03 Thread rra

Author: rra
Date: 2008-03-04 03:14:23 +0100 (Tue, 04 Mar 2008)
New Revision: 1243

Modified:
   trunk/debian/changelog
   trunk/lib/Read_pkglists.pm
   trunk/reporting/html_reports
   trunk/reporting/templates/maintainer.tmpl
   trunk/unpack/list-srcpkg
Log:
* lib/Read_pkglists.pm:
  + [RA] Extract Uploaders from the source package list.
  + [RA] Include packages for which one is an uploader in one's
maintainer page, marked accordingly.  (Closes: #421011)
* reporting/templates/*:
* reporting/templates/maintainer.html:
  + [RA] Include packages for which the maintainer is an uploader.
* unpack/list-srcpkg:
  + [RA] Include Uploaders in the package list.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-04 00:39:52 UTC (rev 1242)
+++ trunk/debian/changelog  2008-03-04 02:14:23 UTC (rev 1243)
@@ -101,6 +101,8 @@
   (Closes: #469222)
   * lib/Lintian/Data.pm:
 + [RA] New module for loading and querying lists of keywords.
+  * lib/Read_pkglists.pm:
++ [RA] Extract Uploaders from the source package list.
   * lib/Spelling.pm:
 + [RA] Add another spelling correction.
 + [RA] Merriam-Webster and the OED have both given up on publically
@@ -108,9 +110,15 @@
 
   * reporting/html_reports:
 + [RA] Load the correct configuration file.
-  * reporting/templates:
++ [RA] Include packages for which one is an uploader in one's
+  maintainer page, marked accordingly.  (Closes: #421011)
+  * reporting/templates/*:
 + [TK] Correct Lintian maintainers address in page footers.
+  * reporting/templates/maintainer.html:
++ [RA] Include packages for which the maintainer is an uploader.
 
+  * unpack/list-srcpkg:
++ [RA] Include Uploaders in the package list.
   * unpack/unpack-srcpkg-l2:
 + [RA] Don't rely on the output format of dpkg-source to learn the
   source directory and create a symlink.  Instead, tell dpkg-source to

Modified: trunk/lib/Read_pkglists.pm
===
--- trunk/lib/Read_pkglists.pm  2008-03-04 00:39:52 UTC (rev 1242)
+++ trunk/lib/Read_pkglists.pm  2008-03-04 02:14:23 UTC (rev 1243)
@@ -29,7 +29,7 @@
 # these banner lines have to be changed with every incompatible change of the
 # binary and source list file formats
 $BINLIST_FORMAT = Lintian's list of binary packages in the archive--V2;
-$SRCLIST_FORMAT = Lintian's list of source packages in the archive--V2;
+$SRCLIST_FORMAT = Lintian's list of source packages in the archive--V3;
 $UDEBLIST_FORMAT = Lintian's list of udeb packages in the archive--V1;
 
 %source_info = ();
@@ -64,7 +64,7 @@
   while (IN) {
 chop;
 next if /^\s*$/o;
-my ($src,$ver,$maint,$arch,$std,$bin,$files,$file,$timestamp) = 
split(/\;/,$_);
+my ($src,$ver,$maint,$uploaders,$arch,$std,$bin,$files,$file,$timestamp) = 
split(/\;/,$_);
 
 my $src_struct;
 %$src_struct =
@@ -72,6 +72,7 @@
'source' = $src,
'version' = $ver,
'maintainer' = $maint,
+   'uploaders' = $uploaders,
'architecture' = $arch,
'standards-version' = $std,
'binary' = $bin,
@@ -190,3 +191,9 @@
 }
 
 1;
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 2
+# End:
+# vim: syntax=perl sw=2 sts=2 ts=2 et shiftround

Modified: trunk/reporting/html_reports
===
--- trunk/reporting/html_reports2008-03-04 00:39:52 UTC (rev 1242)
+++ trunk/reporting/html_reports2008-03-04 02:14:23 UTC (rev 1243)
@@ -139,9 +139,12 @@
 #
 # and then stored under the key 'Russ Allbery [EMAIL PROTECTED]'
 #
+# %by_uploader holds the same thing except for packages for which the person
+# is only an uploader.
+#
 # %by_tag is a hash of tag names to an anonymous array of tag information
 # hashes just like the inside-most data structure above.
-my (%by_maint, %by_tag);
+my (%by_maint, %by_uploader, %by_tag);
 
 # We take a lintian log file on either standard input or as the first
 # argument.  This log file contains all the tags lintian found, plus N: tags
@@ -153,7 +156,7 @@
 # each other's pages.  If we find two maintainers who map to the same URL,
 # just assume that the second maintainer is the same as the first (but warn
 # about it).
-my (%seen, %urlmap, %warned);
+my (%seen, %saw_maintainer);
 while () {
 chomp;
 next unless /^([EWIXO]): (\S+)(?: (\S+))?: (\S+)(?:\s+(.*))?/;
@@ -179,12 +182,13 @@
 # to be no source package in the archive.  Determine the maintainer and
 # version.  Work around a missing source package by pulling information
 # from a binary package or udeb of the same name if there is any.
-my ($source, $version, $maintainer);
+my ($source, $version, $maintainer, $uploaders);
 if ($type eq 'source') {
 $source = $package;
 if (exists $source_info{$source}) {
 $version = $source_info{$source

lintian: r1244 - in trunk: checks debian

2008-03-03 Thread rra

Author: rra
Date: 2008-03-04 03:18:03 +0100 (Tue, 04 Mar 2008)
New Revision: 1244

Modified:
   trunk/checks/copyright-file.desc
   trunk/debian/changelog
Log:
  + [RA] Suggest an override if only the Debian packaging or some other
part of the package not linked with OpenSSL is covered by the GPL.
Thanks, Andrew Pollock.  (Closes: #469106)

Modified: trunk/checks/copyright-file.desc
===
--- trunk/checks/copyright-file.desc2008-03-04 02:14:23 UTC (rev 1243)
+++ trunk/checks/copyright-file.desc2008-03-04 02:18:03 UTC (rev 1244)
@@ -222,3 +222,8 @@
  3) is incompatible with some terms of the OpenSSL license, and therefore
  Debian does not allow GPL-licensed code linked with OpenSSL libraries
  unless there is a license exception explicitly permitting this.
+ .
+ If only the Debian packaging, or some other part of the package not
+ linked with OpenSSL, is covered by the GNU GPL, please add a lintian
+ override for this tag.  Lintian currently has no good way of
+ distinguishing between that case and problematic packages.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-04 02:14:23 UTC (rev 1243)
+++ trunk/debian/changelog  2008-03-04 02:18:03 UTC (rev 1244)
@@ -26,6 +26,9 @@
   Michael Meskes.  (Closes: #465258)
 + [RA] Further explain why lintian looks for a valid copyright notice.
   (Closes: #466714)
++ [RA] Suggest an override if only the Debian packaging or some other
+  part of the package not linked with OpenSSL is covered by the GPL.
+  Thanks, Andrew Pollock.  (Closes: #469106)
   * checks/cruft{.desc,}:
 + [FL] Add hg to the list of vcs-control-dir tags.
 + [RA] In the long description of outdated-autotools-helper-file,


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1245 - trunk/debian

2008-03-03 Thread rra

Author: rra
Date: 2008-03-04 03:22:10 +0100 (Tue, 04 Mar 2008)
New Revision: 1245

Modified:
   trunk/debian/changelog
Log:
Finalize changes for 1.23.46.


Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-04 02:18:03 UTC (rev 1244)
+++ trunk/debian/changelog  2008-03-04 02:22:10 UTC (rev 1245)
@@ -1,5 +1,7 @@
-lintian (1.23.46) UNRELEASED; urgency=low
+lintian (1.23.46) unstable; urgency=low
 
+  The five Lintian committers! release.
+
   * checks/binaries:
 + [RA] Anchor file matches for Perl libraries and debugging symbols so
   as to not match partial paths.  Based on a patch from Niko Tyni.
@@ -130,7 +132,7 @@
   things even with -q (fixed in later versions).  Thanks, Raphael
   Hertzog.  (Closes: #468927)
 
- -- Thijs Kinkhorst [EMAIL PROTECTED]  Tue, 19 Feb 2008 11:31:41 +0100
+ -- Russ Allbery [EMAIL PROTECTED]  Mon, 03 Mar 2008 18:21:32 -0800
 
 lintian (1.23.45) unstable; urgency=low
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1246 - releases

2008-03-03 Thread rra

Author: rra
Date: 2008-03-04 03:30:52 +0100 (Tue, 04 Mar 2008)
New Revision: 1246

Added:
   releases/1.23.46/
Log:
Tag 1.23.46 release.


Copied: releases/1.23.46 (from rev 1245, trunk)


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1230 - in trunk: checks debian

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 05:30:12 +0100 (Mon, 03 Mar 2008)
New Revision: 1230

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
  + [RA] Allow zsh-beta as an alternative to zsh.  Thanks, Joost van
Baal.  (Closes: #468362)

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-03-03 04:28:46 UTC (rev 1229)
+++ trunk/checks/scripts2008-03-03 04:30:12 UTC (rev 1230)
@@ -91,7 +91,7 @@
  trs   = [ '/usr/bin', 'konwert' ],
  xjed  = [ '/usr/bin', 'xjed' ],
  yforth= [ '/usr/bin', 'yforth' ],
- zsh   = [ '/bin' ],
+ zsh   = [ '/bin', 'zsh | zsh-beta' ],
 );
 
 # The more complex case of interpreters that may have a version number.

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 04:28:46 UTC (rev 1229)
+++ trunk/debian/changelog  2008-03-03 04:30:12 UTC (rev 1230)
@@ -53,6 +53,8 @@
 + [RA] Update regexes based on checkbashisms to remove additional
   false positives and add additional checks.  Thanks, Adam D. Barratt.
 + [RA] Add kaptain.  Thanks, Tobias Toedter.  (Closes: #466701)
++ [RA] Allow zsh-beta as an alternative to zsh.  Thanks, Joost van
+  Baal.  (Closes: #468362)
 
   * frontend/lintian:
 + [CW] Make the presence of an Ubuntu release name in the version number


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1231 - in trunk: checks debian

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 05:31:46 +0100 (Mon, 03 Mar 2008)
New Revision: 1231

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
  + [RA] Add yorick.  Thanks, Thibaut Paumard.  (Closes: #468370)

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-03-03 04:30:12 UTC (rev 1230)
+++ trunk/checks/scripts2008-03-03 04:31:46 UTC (rev 1231)
@@ -91,6 +91,7 @@
  trs   = [ '/usr/bin', 'konwert' ],
  xjed  = [ '/usr/bin', 'xjed' ],
  yforth= [ '/usr/bin', 'yforth' ],
+ yorick= [ '/usr/bin' ],
  zsh   = [ '/bin', 'zsh | zsh-beta' ],
 );
 

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 04:30:12 UTC (rev 1230)
+++ trunk/debian/changelog  2008-03-03 04:31:46 UTC (rev 1231)
@@ -55,6 +55,7 @@
 + [RA] Add kaptain.  Thanks, Tobias Toedter.  (Closes: #466701)
 + [RA] Allow zsh-beta as an alternative to zsh.  Thanks, Joost van
   Baal.  (Closes: #468362)
++ [RA] Add yorick.  Thanks, Thibaut Paumard.  (Closes: #468370)
 
   * frontend/lintian:
 + [CW] Make the presence of an Ubuntu release name in the version number


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1229 - in trunk: checks debian

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 05:28:46 +0100 (Mon, 03 Mar 2008)
New Revision: 1229

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
Update regexes from checkbashisms.


Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-02-22 17:18:57 UTC (rev 1228)
+++ trunk/checks/scripts2008-03-03 04:28:46 UTC (rev 1229)
@@ -541,8 +541,12 @@
  '[EMAIL PROTECTED]',# bash arrays, ${name[0|*|@]}
  '[EMAIL PROTECTED]', # ${!prefix[*|@]}
  '\$\{!\w+\}',# ${!name}
- '(\$\(|\`)\s*\\s*\S.+(\)|\`)', # $(\ foo) should be $(cat 
foo)
+ '(\$\(|\`)\s*\\s*\S+\s*(\)|\`)', # $(\ foo) should be $(cat 
foo)
  '\$RANDOM\b',# $RANDOM
+ '\$(OS|MACH)TYPE\b', # $(OS|MACH)TYPE
+ '\$HOST(TYPE|NAME)\b',   # $HOST(TYPE|NAME)
+ '\$DIRSTACK\b',  # $DIRSTACK
+ '\$EUID\b',  # $EUID should be id -u
);
my @bashism_regexs = (
  'function \w+\(\s*\)',   # function is useless
@@ -556,6 +560,7 @@
  '(?:^|\s+)kill\s+-[^sl]\w*', # kill -[0-9] or -[A-Z]
  '(?:^|\s+)trap\s+[\']?.*[\']?\s+.*[1-9]', # trap with 
signal numbers
  '\',   # cshism
+ '(\|\)\s*((-|\d+)[^\s;|\)\`]|[^-\d])', # should be word 
21
  '\[\[(?!:)', # alternative test command
  '(?:^|\s+)select\s+\w+', # 'select' is not POSIX
  '\$\(\([A-Za-z]',# cnt=$((cnt + 1)) does not work 
in dash
@@ -564,6 +569,7 @@
  '(?:^|\s+)let\s',# let ...
  '(?![\$\(])\(\(.*\)\)', # '((' should be '$(('
  '(\[|test)\s+-a',# test with unary -a (should be 
-e)
+ '',   #  here string
);
 
# since this test is ugly, I have to do it by itself
@@ -610,7 +616,7 @@
 
# Only look for the beginning of a heredoc here, after we've
# stripped out quoted material, to avoid false positives.
-   if (m/\\\s*[\'\]?(\w+)[\'\]?/) {
+   if (m/(?:^|[^])\\\s*[\'\]?(\w+)[\'\]?/) {
$cat_string = $1;
}
}

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-02-22 17:18:57 UTC (rev 1228)
+++ trunk/debian/changelog  2008-03-03 04:28:46 UTC (rev 1229)
@@ -51,7 +51,7 @@
   doesn't seem to have any actual code.  Based on an idea
   by Justin Pryzby.  (Closes: #410042)
 + [RA] Update regexes based on checkbashisms to remove additional
-  false positives.  Thanks, Adam D. Barratt.
+  false positives and add additional checks.  Thanks, Adam D. Barratt.
 + [RA] Add kaptain.  Thanks, Tobias Toedter.  (Closes: #466701)
 
   * frontend/lintian:


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1232 - in trunk: checks debian unpack

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 06:06:59 +0100 (Mon, 03 Mar 2008)
New Revision: 1232

Modified:
   trunk/checks/cruft
   trunk/debian/changelog
   trunk/unpack/unpack-srcpkg-l2
Log:
  + [RA] Remove now-unnecessary workarounds for calling File::Find with
symlink starting directory.
* unpack/unpack-srcpkg-l2:
  + [RA] Don't rely on the output format of dpkg-source to learn the
source directory and create a symlink.  Instead, tell dpkg-source to
unpack the source directly into the unpacked directory.  Discard
output of dpkg-source to allow for the current version, which prints
things even with -q (fixed in later versions).  Thanks, Raphael
Hertzog.  (Closes: #468927)

Modified: trunk/checks/cruft
===
--- trunk/checks/cruft  2008-03-03 04:31:46 UTC (rev 1231)
+++ trunk/checks/cruft  2008-03-03 05:06:59 UTC (rev 1232)
@@ -125,11 +125,8 @@
 $atdinbd = 1 if Dep::implies(Dep::parse($bd), Dep::parse($autotools_pkgs));
 }
 
-my $cwd = cwd;
-$dir = readlink $cwd/unpacked; # File::Find in Perl 5.8 appears to need it
-
 check_diffstat(diffstat);
-find(\find_cruft, $dir);
+find(\find_cruft, 'unpacked');
 
 } # /run
 
@@ -192,7 +189,7 @@
 # source-contains tag.  The tag isn't entirely accurate, but it's better
 # than creating yet a third set of tags, and this gets the severity right.
 sub find_cruft {
-(my $name = $File::Find::name) =~ s,^\Q$dir\E/,,;
+(my $name = $File::Find::name) =~ s,^(\./)?unpacked/,,;
 my $prefix = ($native ? diff-contains : source-contains);
 if (-d and not $warned{$name}) {
 for my $rule (@directory_checks) {

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 04:31:46 UTC (rev 1231)
+++ trunk/debian/changelog  2008-03-03 05:06:59 UTC (rev 1232)
@@ -26,6 +26,8 @@
 + [FL] Add hg to the list of vcs-control-dir tags.
 + [RA] In the long description of outdated-autotools-helper-file,
   point to autotool-dev's documentation.  (Closes: #465132)
++ [RA] Remove now-unnecessary workarounds for calling File::Find with
+  symlink starting directory.
   * checks/debian-readme{.desc,}:
 + [RA] Warn of references to /usr/doc in README.Debian.  Thanks,
   Guillem Jover.  (Closes: #465192)
@@ -73,6 +75,14 @@
   * reporting/templates:
 + [TK] Correct Lintian maintainers address in page footers.
 
+  * unpack/unpack-srcpkg-l2:
++ [RA] Don't rely on the output format of dpkg-source to learn the
+  source directory and create a symlink.  Instead, tell dpkg-source to
+  unpack the source directly into the unpacked directory.  Discard
+  output of dpkg-source to allow for the current version, which prints
+  things even with -q (fixed in later versions).  Thanks, Raphael
+  Hertzog.  (Closes: #468927)
+
  -- Thijs Kinkhorst [EMAIL PROTECTED]  Tue, 19 Feb 2008 11:31:41 +0100
 
 lintian (1.23.45) unstable; urgency=low

Modified: trunk/unpack/unpack-srcpkg-l2
===
--- trunk/unpack/unpack-srcpkg-l2   2008-03-03 04:31:46 UTC (rev 1231)
+++ trunk/unpack/unpack-srcpkg-l2   2008-03-03 05:06:59 UTC (rev 1232)
@@ -30,31 +30,27 @@
 
 ($#ARGV == 0) or fail(syntax: unpack-srcpkg-l2 base-dir);
 my $base_dir = shift;
-my $unpack_dir;
 
 print N: Unpacking source package in directory $base_dir ...\n if $verbose;
-chdir($base_dir);
 
-my $IN = FileHandle-new;
-pipeline_open($IN, sub {
-   my $ret=exec 'dpkg-source', '-q', '-x', 'dsc';
-   $ret;
-}) or fail(cannot run dpkg-source: $!);
-
-while ($IN) {
-chop;
-$unpack_dir = $1
-   if (/^dpkg-source: extracting [^\s]+ in (\S+)/);
+# We can't use spawn yet because older versions of dpkg-source print things
+# out even with -q.  This can be fixed to use spawn once that newer version of
+# dpkg is in oldstable.
+my $pid = fork;
+if (not defined $pid) {
+fail(cannot fork: $!);
+} elsif ($pid == 0) {
+open(STDOUT, '', '/dev/null');
+exec('dpkg-source', '-q', '-x', $base_dir/dsc, $base_dir/unpacked);
+} else {
+waitpid($pid, 0);
+unless ($? == 0) {
+fail(cannot run dpkg-source: $!);
+}
 }
-close($IN) or fail(error occured during execution of dpkg-source in 
$base_dir: $!);
-$unpack_dir or fail(dpkg-source didn't report unpack directory);
 
-# create link to unpack directory
-symlink($unpack_dir, unpacked)
-or fail(cannot symlink to unpack directory $unpack_dir);
-
 # fix permissions
-spawn('chmod', '-R', 'u+rwX,o+rX,o-w', $unpack_dir) == 0 or fail();
+spawn('chmod', '-R', 'u+rwX,o+rX,o-w', $base_dir/unpacked) == 0 or fail();
 
 exit 0;
 
@@ -70,3 +66,9 @@
   }
   exit 1;
 }
+
+# Local Variables:
+# indent-tabs-mode: nil
+# cperl-indent-level: 4
+# End:
+# vim: syntax=perl sw=4 sts=4 ts=4 et shiftround


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact

lintian: r1233 - in trunk: debian frontend

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 06:09:56 +0100 (Mon, 03 Mar 2008)
New Revision: 1233

Modified:
   trunk/debian/changelog
   trunk/frontend/lintian
Log:
Fix more problems with the option parsing in lintian.


Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 05:06:59 UTC (rev 1232)
+++ trunk/debian/changelog  2008-03-03 05:09:56 UTC (rev 1233)
@@ -63,7 +63,7 @@
 + [CW] Make the presence of an Ubuntu release name in the version number
   trigger the Ubuntu distribution field checks.
 + [RA] Fix option parsing bug leading lintian to incorrectly reject -a
-  without a package.
+  or -p without a package.
 
   * lib/Spelling.pm:
 + [RA] Add another spelling correction.

Modified: trunk/frontend/lintian
===
--- trunk/frontend/lintian  2008-03-03 05:06:59 UTC (rev 1232)
+++ trunk/frontend/lintian  2008-03-03 05:09:56 UTC (rev 1233)
@@ -326,7 +326,7 @@
 $action = 'check' if not $action;
 
 # check for arguments
-if ($action =~ /^(check|unpack|remove)$/ and $#ARGV == -1 and not 
$check_everything) {
+if ($action =~ /^(check|unpack|remove)$/ and $#ARGV == -1 and not 
$check_everything and not $packages_file) {
 syntax();
 }
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1234 - in trunk: checks debian testset testset/binary/debian testset/diffs/debian

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 06:21:41 +0100 (Mon, 03 Mar 2008)
New Revision: 1234

Modified:
   trunk/checks/rules
   trunk/checks/rules.desc
   trunk/debian/changelog
   trunk/testset/binary/debian/rules
   trunk/testset/diffs/debian/rules
   trunk/testset/tags.binary
Log:
  + [RA] Also check for make -i when checking if errors from make clean or
distclean are ignored.  Thanks, J?\195?\182rg Sommer.  (Closes: #469024)

Modified: trunk/checks/rules
===
--- trunk/checks/rules  2008-03-03 05:09:56 UTC (rev 1233)
+++ trunk/checks/rules  2008-03-03 05:21:41 UTC (rev 1234)
@@ -98,7 +98,8 @@
 if (/\$[\(\{]PWD[\)\}]/) {
 tag debian-rules-uses-pwd, line $.;
 }
-if (/^\t\s*-(?:\$[\(\{]MAKE[\}\)]|make)\s.*(?:dist)?clean/) {
+if (/^\t\s*-(?:\$[\(\{]MAKE[\}\)]|make)\s.*(?:dist)?clean/ ||
+   /^\t\s*(?:\$[\(\{]MAKE[\}\)]|make)\s(?:.*\s)?-\w*i.*(?:dist)?clean/) {
 tag debian-rules-ignores-make-clean-error, line $.;
 }
 

Modified: trunk/checks/rules.desc
===
--- trunk/checks/rules.desc 2008-03-03 05:09:56 UTC (rev 1233)
+++ trunk/checks/rules.desc 2008-03-03 05:21:41 UTC (rev 1234)
@@ -51,11 +51,13 @@
  package's clean or distclean target with a line like:
  .
   -$(MAKE) distclean
+ or
+  $(MAKE) -i distclean
  .
- The leading - tells make to ignore all errors.  Normally this is done
- for packages using Autoconf since Makefile may not exist.  However, this
- line ignores all other error messages, not just the missing Makefile
- error.  It's better to use:
+ The leading - or the option -i tells make to ignore all errors.
+ Normally this is done for packages using Autoconf since Makefile may not
+ exist.  However, this line ignores all other error messages, not just
+ the missing Makefile error.  It's better to use:
  .
   [ ! -f Makefile ] || $(MAKE) distclean
  .

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-03-03 05:09:56 UTC (rev 1233)
+++ trunk/debian/changelog  2008-03-03 05:21:41 UTC (rev 1234)
@@ -4,6 +4,8 @@
 + [RA] Anchor file matches for Perl libraries and debugging symbols so
   as to not match partial paths.  Based on a patch from Niko Tyni.
   (Closes: #466501)
++ [RA] Also check for make -i when checking if errors from make clean or
+  distclean are ignored.  Thanks, Jörg Sommer.  (Closes: #469024)
   * checks/changelog-file:
 + [RA] Adjust for the extra space added by Parse::DebianChangelog when
   checking line length.  Thanks, Robert Millan.  (Closes: #467019)

Modified: trunk/testset/binary/debian/rules
===
--- trunk/testset/binary/debian/rules   2008-03-03 05:09:56 UTC (rev 1233)
+++ trunk/testset/binary/debian/rules   2008-03-03 05:21:41 UTC (rev 1234)
@@ -9,7 +9,7 @@
echo $(PWD)
 
 clean:
-   make clean
+   make -i clean
rm -f debian/files debian/substvars
 
 binary-arch: build

Modified: trunk/testset/diffs/debian/rules
===
--- trunk/testset/diffs/debian/rules2008-03-03 05:09:56 UTC (rev 1233)
+++ trunk/testset/diffs/debian/rules2008-03-03 05:21:41 UTC (rev 1234)
@@ -24,7 +24,7 @@
 
 clean:
rm -rf $(tmp)
-#  make clean
+   make clean
rm -f subdir-good/config.cache subdir-good/config.log 
subdir-good/config.status
 
 .PHONY: build binary-arch binary-indep binary clean

Modified: trunk/testset/tags.binary
===
--- trunk/testset/tags.binary   2008-03-03 05:09:56 UTC (rev 1233)
+++ trunk/testset/tags.binary   2008-03-03 05:21:41 UTC (rev 1234)
@@ -50,6 +50,7 @@
 I: binary: desktop-entry-contains-encoding-key 
/usr/share/applications/hello.desktop:13 Encoding
 I: binary: no-md5sums-control-file
 W: binary source: ancient-standards-version 3.2.1 (current is 3.7.3)
+W: binary source: debian-rules-ignores-make-clean-error line 12
 W: binary source: debian-rules-uses-pwd line 9
 W: binary source: maintainer-upload-has-incorrect-version-number 4-1.1
 W: binary source: native-package-with-dash-version


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1235 - trunk/testset

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 06:37:39 +0100 (Mon, 03 Mar 2008)
New Revision: 1235

Modified:
   trunk/testset/runtests
Log:
Add a -d option that enables debug.


Modified: trunk/testset/runtests
===
--- trunk/testset/runtests  2008-03-03 05:21:41 UTC (rev 1234)
+++ trunk/testset/runtests  2008-03-03 05:37:39 UTC (rev 1235)
@@ -22,7 +22,7 @@
 
 sub usage {
 print END;
-Usage: $0 [-k] [-v] testset-directory testing-directory [test]
+Usage: $0 [-k] [-v] [-d] testset-directory testing-directory [test]
 
 The -k option means do not stop after one failed test, but try
 them all and report all errors.
@@ -30,6 +30,8 @@
 The -v option will also display those tests that have a description, but are
 not tested in any testset-package.
 
+The -d option will display debugging information.
+
 The optional 3rd parameter causes runtests to only run that particular test.
 END
 exit 2;
@@ -70,6 +72,8 @@
$run_all_tests = 1;
 } elsif ($ARGV[0] eq '-v') {
$verbose = 1;
+} elsif ($ARGV[0] eq '-d') {
+   $debug = 1;
 } else {
usage;
 }


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1236 - trunk/unpack

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 06:38:12 +0100 (Mon, 03 Mar 2008)
New Revision: 1236

Modified:
   trunk/unpack/unpack-srcpkg-l2
Log:
We still have to do the chdir to work around a bug in the current
dpkg-source.


Modified: trunk/unpack/unpack-srcpkg-l2
===
--- trunk/unpack/unpack-srcpkg-l2   2008-03-03 05:37:39 UTC (rev 1235)
+++ trunk/unpack/unpack-srcpkg-l2   2008-03-03 05:38:12 UTC (rev 1236)
@@ -32,6 +32,7 @@
 my $base_dir = shift;
 
 print N: Unpacking source package in directory $base_dir ...\n if $verbose;
+chdir($base_dir);
 
 # We can't use spawn yet because older versions of dpkg-source print things
 # out even with -q.  This can be fixed to use spawn once that newer version of
@@ -41,7 +42,7 @@
 fail(cannot fork: $!);
 } elsif ($pid == 0) {
 open(STDOUT, '', '/dev/null');
-exec('dpkg-source', '-q', '-x', $base_dir/dsc, $base_dir/unpacked);
+exec('dpkg-source', '-q', '-x', 'dsc', 'unpacked');
 } else {
 waitpid($pid, 0);
 unless ($? == 0) {
@@ -50,7 +51,7 @@
 }
 
 # fix permissions
-spawn('chmod', '-R', 'u+rwX,o+rX,o-w', $base_dir/unpacked) == 0 or fail();
+spawn('chmod', '-R', 'u+rwX,o+rX,o-w', 'unpacked') == 0 or fail();
 
 exit 0;
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1237 - in trunk: checks debian testset testset/dh-test/debian testset/maintainer-scripts/debian

2008-03-02 Thread rra

Author: rra
Date: 2008-03-03 07:03:37 +0100 (Mon, 03 Mar 2008)
New Revision: 1237

Added:
   trunk/testset/dh-test/debian/postinst
Modified:
   trunk/checks/scripts
   trunk/checks/scripts.desc
   trunk/debian/changelog
   trunk/testset/maintainer-scripts/debian/preinst
   trunk/testset/tags.dh-test
   trunk/testset/tags.maintainer-scripts
Log:
* checks/scripts{.desc,}:
  + [RA] Add warnings for dpkg --assert* flags for features that have
been guaranteed for nearly a decade.  Thanks, Bernhard R. Link.
(Closes: #467642)

Also enhance maintainer-script-empty to catch scripts that contain only
boilerplate for option parsing.


Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-03-03 05:38:12 UTC (rev 1236)
+++ trunk/checks/scripts2008-03-03 06:03:37 UTC (rev 1237)
@@ -470,11 +470,6 @@
}
 }
 
-# the control-files check already has an unknown-control-file error
-# so there's no need for anything like this here:
-# my %maintainer_scripts = map { $_ = 1 } qw(preinst postinst prerm postrm 
config);
-# print E: something unless exists $maintainer_scripts{$file}
-
 # now scan the file contents themselves
 open (C, '', $filename)
or fail(cannot open maintainer script $filename for reading: $!);
@@ -489,9 +484,16 @@
s/\#.*$//; # eat comments
chomp();
 
+   # Don't consider the standard dh-make boilerplate to be code.  This
+   # means ignoring the framework of a case statement, the labels, the
+   # echo complaining about unknown arguments, and an exit.
unless ($has_code
+   || m/^\s*set\s+-\w+\s*$/
+   || m/^\s*case\s+\?\$1\?\s+in\s*$/
+   || m/^\s*(?:[a-z|-]+|\*)\)\s*$/
|| m/^\s*[:;]+\s*$/
-   || m/^\s*set\s+-\w+\s*$/
+   || m/^\s*echo\s+\[^\]+\(?:\s*2)?\s*$/
+   || m/^\s*esac\s*$/
|| m/^\s*exit\s+\d+\s*$/) {
$has_code = 1;
}
@@ -655,6 +657,20 @@
tag maintainer-script-modifies-inetd-conf, $file:$.
unless Dep::implies($deps{provides}, 
Dep::parse('inet-superserver'));
}
+
+   # Ancient dpkg feature tests.
+   if (m/^\s*dpkg\s+--assert-support-predepends\b/) {
+   tag ancient-dpkg-predepends-check, $file:$.;
+   }
+   if (m/^\s*dpkg\s+--assert-working-epoch\b/) {
+   tag ancient-dpkg-epoch-check, $file:$.;
+   }
+   if (m/^dpkg\s+--assert-long-filenames\b/) {
+   tag ancient-dpkg-long-filenames-check, $file:$.;
+   }
+   if (m/^dpkg\s+--assert-multi-conrep\b/) {
+   tag ancient-dpkg-multi-conrep-check, $file:$.;
+   }
}
}
if (m,\bsuidregister\b,) {

Modified: trunk/checks/scripts.desc
===
--- trunk/checks/scripts.desc   2008-03-03 05:38:12 UTC (rev 1236)
+++ trunk/checks/scripts.desc   2008-03-03 06:03:37 UTC (rev 1237)
@@ -391,7 +391,36 @@
 
 Tag: maintainer-script-empty
 Type: warning
-Info: The maintainer script doesn't seem to contain any code. While this
- is harmless in most cases it is probably not what you wanted and may even
- lead to problems in rare situations where dpkg would fail if no maintainer
- script was present.
+Info: The maintainer script doesn't seem to contain any code other than
+ comments and boilerplate (set -e, exit statements, and the case statement
+ to parse options).  While this is harmless in most cases, it is probably
+ not what you wanted, may mean the package will leave unnecessary files
+ behind until purged, and may even lead to problems in rare situations
+ where dpkg would fail if no maintainer script was present.
+ .
+ If the package currently doesn't need to do anything in this maintainer
+ script, it shouldn't be included in the package.
+
+Tag: ancient-dpkg-predepends-check
+Type: warning
+Info: The package calls dpkg --assert-support-predepends in a maintainer
+ script.  This check is obsolete and has always returned true since dpkg
+ 1.1.0, released 1996-02-11.
+
+Tag: ancient-dpkg-epoch-check
+Type: warning
+Info: The package calls dpkg --assert-working-epoch in a maintainer
+ script.  This check is obsolete and has always returned true since dpkg
+ 1.4.0.7, released 1997-01-25.
+
+Tag: ancient-dpkg-long-filenames-check
+Type: warning
+Info: The package calls dpkg --assert-long-filenames in a maintainer
+ script.  This check is obsolete and has always returned true since dpkg
+ 1.4.1.17, released 1999-10-21.
+
+Tag: ancient-dpkg-multi-conrep-check
+Type: warning
+Info: The package calls dpkg --assert-multi-conrep in a maintainer
+ script.  This check is obsolete and has always returned true since dpkg
+ 1.4.1.19, released 1999-10-30.

Modified: trunk/debian

lintian: r1227 - in trunk: checks debian testset/debconf/debian

2008-02-22 Thread rra

Author: rra
Date: 2008-02-22 18:15:33 +0100 (Fri, 22 Feb 2008)
New Revision: 1227

Modified:
   trunk/checks/changelog-file
   trunk/debian/changelog
   trunk/testset/debconf/debian/changelog
Log:
* checks/changelog-file:
  + [RA] Adjust for the extra space added by Parse::DebianChangelog when
checking line length.  Thanks, Robert Millan.  (Closes: #467019)

Modified: trunk/checks/changelog-file
===
--- trunk/checks/changelog-file 2008-02-21 02:47:58 UTC (rev 1226)
+++ trunk/checks/changelog-file 2008-02-22 17:15:33 UTC (rev 1227)
@@ -333,9 +333,12 @@
 # check.  For some reason, use open ':utf8' isn't sufficient.  If the
 # changelog uses a non-UTF-8 encoding, this will mangle it, but it doesn't
 # matter for the length check.
-my @lines = split ('\n', decode ('utf-8', $changes));
+#
+# Parse::DebianChangelog adds an additional space to the beginning of each
+# line, so we have to adjust for that in the length check.
+my @lines = split (\n, decode ('utf-8', $changes));
 for my $i (0 .. $#lines) {
-if (length ($lines[$i])  80  $lines[$i] !~ /^[\s.o*+-]*\S+$/) {
+if (length ($lines[$i])  81  $lines[$i] !~ /^[\s.o*+-]*\S+$/) {
 tag 'debian-changelog-line-too-long', line  . ($i + 1);
 }
 }

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-02-21 02:47:58 UTC (rev 1226)
+++ trunk/debian/changelog  2008-02-22 17:15:33 UTC (rev 1227)
@@ -4,6 +4,9 @@
 + [RA] Anchor file matches for Perl libraries and debugging symbols so
   as to not match partial paths.  Based on a patch from Niko Tyni.
   (Closes: #466501)
+  * checks/changelog-file:
++ [RA] Adjust for the extra space added by Parse::DebianChangelog when
+  checking line length.  Thanks, Robert Millan.  (Closes: #467019)
   * checks/control-files{.desc,}:
 + [FL] Warn about empty control files. I can't see any use for
   them. Exclude udebs though, since they might differ there.

Modified: trunk/testset/debconf/debian/changelog
===
--- trunk/testset/debconf/debian/changelog  2008-02-21 02:47:58 UTC (rev 
1226)
+++ trunk/testset/debconf/debian/changelog  2008-02-22 17:15:33 UTC (rev 
1227)
@@ -1,5 +1,6 @@
 debconf (1~rc1) unstable; urgency=low
 
   * Initial Release
+  * Changelog line with exactly 80 characters which tests the line-too-long 
tag.
 
  -- Lintian Maintainers [EMAIL PROTECTED]  Sat, 13 Nov 2004 22:45:05 +0100


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1223 - in trunk: checks debian

2008-02-20 Thread rra

Author: rra
Date: 2008-02-20 19:02:53 +0100 (Wed, 20 Feb 2008)
New Revision: 1223

Modified:
   trunk/checks/copyright-file.desc
   trunk/debian/changelog
Log:
* checks/copyright-file{.desc,}:
  + [RA] Further explain why lintian looks for a valid copyright notice.
(Closes: #466714)

Modified: trunk/checks/copyright-file.desc
===
--- trunk/checks/copyright-file.desc2008-02-20 00:32:56 UTC (rev 1222)
+++ trunk/checks/copyright-file.desc2008-02-20 18:02:53 UTC (rev 1223)
@@ -197,7 +197,10 @@
  copyright notice.  You should copy the copyright notice from the upstream
  source (or add one of your own for a native package).  A copyright notice
  must consist of Copyright, Copr., or the Unicode symbol of C in a circle
- followed by the years and the copyright holder.
+ followed by the years and the copyright holder.  A copyright notice is
+ not required for a work to be copyrighted, but Debian requires the
+ copyright file include the authors and years of copyright, and including
+ a valid copyright notice is the best way to do that.
  .
  If the package is in the public domain rather than copyrighted, be sure
  to mention public domain in the copyright file.  Please be aware that

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-02-20 00:32:56 UTC (rev 1222)
+++ trunk/debian/changelog  2008-02-20 18:02:53 UTC (rev 1223)
@@ -7,12 +7,14 @@
   * checks/control-files{.desc,}:
 + [FL] Warn about empty control files. I can't see any use for
   them. Exclude udebs though, since they might differ there.
-  * checks/copyright-file:
+  * checks/copyright-file{.desc,}:
 + [RA] Tests for copyright notices must be case-insensitive.  Patch
   from Chris Lamb.  (Closes: #464992)
 + [RA] When looking for cases where Copyright is separated from a year
   by a newline, also allow (C) before or after the newline.  Thanks,
   Michael Meskes.  (Closes: #465258)
++ [RA] Further explain why lintian looks for a valid copyright notice.
+  (Closes: #466714)
   * checks/cruft{.desc,}:
 + [FL] Add hg to the list of vcs-control-dir tags.
 + [RA] In the long description of outdated-autotools-helper-file,


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1224 - in trunk: checks debian

2008-02-20 Thread rra

Author: rra
Date: 2008-02-20 19:04:17 +0100 (Wed, 20 Feb 2008)
New Revision: 1224

Modified:
   trunk/checks/scripts
   trunk/debian/changelog
Log:
  + [RA] Add kaptain.  Thanks, Tobias Toedter.  (Closes: #466701)

Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-02-20 18:02:53 UTC (rev 1223)
+++ trunk/checks/scripts2008-02-20 18:04:17 UTC (rev 1224)
@@ -62,6 +62,7 @@
  'install-menu' = [ '/usr/bin', '' ],
  jed   = [ '/usr/bin' ],
  'jed-script'   = [ '/usr/bin', 'jed | xjed' ],
+ kaptain= [ '/usr/bin' ],
  ksh   = [ '/bin', 'mksh | pdksh' ],
  lefty = [ '/usr/bin', 'graphviz' ],
  magicfilter= [ '/usr/sbin' ],

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-02-20 18:02:53 UTC (rev 1223)
+++ trunk/debian/changelog  2008-02-20 18:04:17 UTC (rev 1224)
@@ -41,6 +41,7 @@
   by Justin Pryzby.  (Closes: #410042)
 + [RA] Update regexes based on checkbashisms to remove additional
   false positives.  Thanks, Adam D. Barratt.
++ [RA] Add kaptain.  Thanks, Tobias Toedter.  (Closes: #466701)
 
   * frontend/lintian:
 + [CW] Make the presence of an Ubuntu release name in the version number


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1226 - trunk/debian

2008-02-20 Thread rra

Author: rra
Date: 2008-02-21 03:47:58 +0100 (Thu, 21 Feb 2008)
New Revision: 1226

Modified:
   trunk/debian/copyright
Log:
Add Thijs Kinkhorst to debian/copyright so that users can expand the
TK abbreviation.


Modified: trunk/debian/copyright
===
--- trunk/debian/copyright  2008-02-21 02:46:21 UTC (rev 1225)
+++ trunk/debian/copyright  2008-02-21 02:47:58 UTC (rev 1226)
@@ -12,6 +12,7 @@
  Marc 'HE' Brockschmidt [EMAIL PROTECTED]
  Colin Watson [EMAIL PROTECTED]
  Russ Allbery [EMAIL PROTECTED]
+ Thijs Kinkhorst [EMAIL PROTECTED]
 Contact address is [EMAIL PROTECTED].
 
 Lintian is maintained in Subversion.  The current development version may


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1221 - trunk/checks

2008-02-19 Thread rra

Author: rra
Date: 2008-02-19 20:19:41 +0100 (Tue, 19 Feb 2008)
New Revision: 1221

Modified:
   trunk/checks/scripts
Log:
One more regex update from checkbashisms.


Modified: trunk/checks/scripts
===
--- trunk/checks/scripts2008-02-19 10:45:45 UTC (rev 1220)
+++ trunk/checks/scripts2008-02-19 19:19:41 UTC (rev 1221)
@@ -561,7 +561,7 @@
  '(?:^|\s+)echo\s+-e',# echo -e
  '(?:^|\s+)exec\s+-[acl]',# exec -c/-l/-a name
  '(?:^|\s+)let\s',# let ...
- '(?!\$)\(\(.*\)\)', # '((' should be '$(('
+ '(?![\$\(])\(\(.*\)\)', # '((' should be '$(('
  '(\[|test)\s+-a',# test with unary -a (should be 
-e)
);
 


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

lintian: r1222 - in trunk: debian lib

2008-02-19 Thread rra

Author: rra
Date: 2008-02-20 01:32:56 +0100 (Wed, 20 Feb 2008)
New Revision: 1222

Modified:
   trunk/debian/changelog
   trunk/lib/Spelling.pm
Log:
  + [RA] Merriam-Webster and the OED have both given up on publically
vs. publicly, so we should as well.  (Closes: #466617)

Modified: trunk/debian/changelog
===
--- trunk/debian/changelog  2008-02-19 19:19:41 UTC (rev 1221)
+++ trunk/debian/changelog  2008-02-20 00:32:56 UTC (rev 1222)
@@ -48,6 +48,8 @@
 
   * lib/Spelling.pm:
 + [RA] Add another spelling correction.
++ [RA] Merriam-Webster and the OED have both given up on publically
+  vs. publicly, so we should as well.  (Closes: #466617)
 
   * reporting/html_reports:
 + [RA] Load the correct configuration file.

Modified: trunk/lib/Spelling.pm
===
--- trunk/lib/Spelling.pm   2008-02-19 19:19:41 UTC (rev 1221)
+++ trunk/lib/Spelling.pm   2008-02-20 00:32:56 UTC (rev 1222)
@@ -250,7 +250,6 @@
   pronouce pronounce
   protcol protocol
   protocoll protocol
-  publically publicly
   recieve receive
   recieved received
   redircet redirect


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

1 2 3 4 5 6 >

1 - 100 of 561 matches

Mail list logo