Processed: Re: Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-15 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 895674 + pending
Bug #895674 [src:lintian] lintian: maybe-not-arch-all-binnmuable emitted for (= 
${source:Version})
Added tag(s) pending.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
895674: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895674
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-15 Thread Chris Lamb
tags 895674 + pending
thanks

> I guess I'd want to know if the source format were not 3.0 (quilt) but
> that's a rare enough issue that it's probably not worth the noise

Indeed. Whilst we have things like:

  unknown-source-format
  unsupported-source-format
  missing-debian-source-format

... I think you are really after a check for "Format: 1.0"
packages here. There is a proof-of-concept of this in #884498.

Anyway, I've fixed this tag as it stands to avoid any confusion:

  
https://salsa.debian.org/lintian/lintian/commit/37f460a1d2d9886e611f17142cbbfa055a8e93b0

  checks/version-substvars.desc   | 9 +++--
  debian/changelog| 4 
  t/tests/version-substvars-general/desc  | 2 +-
  t/tests/version-substvars-general/tags  | 2 +-
  t/tests/version-substvars-obsolete/desc | 2 +-
  t/tests/version-substvars-obsolete/tags | 2 +-
  6 files changed, 15 insertions(+), 6 deletions(-)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-14 Thread Jeremy Bicha
On Sat, Apr 14, 2018 at 5:49 PM, Chris Lamb  wrote:
> I don't see how any of these (*) are useful to some wishing to
> uncover hidden problems with their packages.

I guess I'd want to know if the source format were not 3.0 (quilt) but
that's a rare enough issue that it's probably not worth the noise.
I'll go ahead and turn off classification on my system.

Thanks,
Jeremy Bicha



Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-14 Thread Chris Lamb
Hi Jeremy,

> Do you have a list of all the classification checks to
> help me reconsider?

  control-tarball-compression-format
  ctrl-script
  data-tarball-compression-format
  debhelper-autoscript-in-maintainer-scripts
  debian-build-system
  elf-maintainer-script
  maintainer-script-interpreter
  maybe-not-arch-all-binnmuable
  no-ctrl-scripts
  rules-does-not-require-root
  rules-requires-root-explicitly
  rules-requires-root-implicitly
  source-format

I don't see how any of these (*) are useful to some wishing to
uncover hidden problems with their packages. Indeed, it is almost
certianly a net negative due to the additional output they would
emit, leading to stronger errors and warnings being potentially
hidden from human eyes.

> I don't show experimental tags.

To show classification tags yet not experimental ones is very rare
way of regularly using Lintian IMHO. Classification tags are designed
for reporting/statistics purposes, eg. generating pretty graphs on
lintian.debian.org.

Putting it another way, if you are using a classification tag for
_actionable_ advice, then it suggests that tag should not be a
classification tag.

(*) This, I believe, is the case for maybe-not-arch-all-binnmuable.
As I see it, it should be moved to a experimental severity and,
perhaps, something added to the text to underline that it should
not be blindly followed.


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-14 Thread Jeremy Bicha
On Sat, Apr 14, 2018 at 3:32 PM, Chris Lamb  wrote:
>   
> https://salsa.debian.org/lintian/lintian/commit/800b1344880b70995c5a26754d2a891ae0ef7d5d
>
> … in particular:
>
>  At this time, please do not attempt to "fix" the problem.  It
>  is not clear what the solution is (if any at all).  Nor is it clear
>  that this is something that will be supported.

Note that that text was *removed* from the tag description in that commit (!!).

> So, alas, changes may even be incorrect (!). I am unsure, hence
> tagging as moreinfo for the time being.
>
> (As an aside, how come you show classification checks? Surely they
> are far too noisy/useless..? I also wonder if this should be an
> X "experimental" tag instead as that would have been less strange.)

I thought some of the classification tags were useful. Do you have a
list of all the classification checks to help me reconsider? I don't
show experimental tags.

This particular tag is problematic because it encourages people who
see the tag to change the packaging so that the tag isn't emitted. ( I
have done that in several packages but will undo it as I touch the
packages again and notice.)

Thanks,
Jeremy Bicha



Processed: Re: Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-14 Thread Debian Bug Tracking System
Processing commands for cont...@bugs.debian.org:

> tags 895674 + moreinfo
Bug #895674 [src:lintian] lintian: maybe-not-arch-all-binnmuable emitted for (= 
${source:Version})
Added tag(s) moreinfo.
> thanks
Stopping processing here.

Please contact me if you need assistance.
-- 
895674: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=895674
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems



Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-14 Thread Chris Lamb
tags 895674 + moreinfo
thanks

Hi Jeremy,

First, thanks for filing this; so much easier to work with these
various arch/any tags in email in my experience...

> C: gnome-shell source: maybe-not-arch-all-binnmuable gnome-shell ->
>gnome-shell-common

Next, have you noticed that that this is a C-level classification
tag, not even a pedantic warning? :)

Anyway, if you look at:

  
https://salsa.debian.org/lintian/lintian/commit/800b1344880b70995c5a26754d2a891ae0ef7d5d

… in particular:

 At this time, please do not attempt to "fix" the problem.  It
 is not clear what the solution is (if any at all).  Nor is it clear
 that this is something that will be supported.

So, alas, changes may even be incorrect (!). I am unsure, hence
tagging as moreinfo for the time being.

(As an aside, how come you show classification checks? Surely they
are far too noisy/useless..? I also wonder if this should be an
X "experimental" tag instead as that would have been less strange.)


Regards,

-- 
  ,''`.
 : :'  : Chris Lamb
 `. `'`  la...@debian.org / chris-lamb.co.uk
   `-



Bug#895674: lintian: maybe-not-arch-all-binnmuable emitted for (= ${source:Version})

2018-04-14 Thread Jeremy Bicha
Source: lintian
Version: 2.5.82

Test Case

When I build gnome-shell, lintian emits this:

C: gnome-shell source: maybe-not-arch-all-binnmuable gnome-shell ->
gnome-shell-common

But gnome-shell depends on
gnome-shell-common (= ${source:Version}),

I am told that is a correct dependency relationship despite some of
the confusing Lintian descriptions.

I have however been changing these to (>= ${source:Version}) which
makes the lintian output go away.

https://salsa.debian.org/gnome-team/gnome-shell

Thanks,
Jeremy Bicha