Re: lintian.d.o improvements
Marc 'HE' Brockschmidt [EMAIL PROTECTED] writes: Russ Allbery [EMAIL PROTECTED] writes: This looks great to me. Unless any of the other maintainers have any remaining issues, I plan on integrating this patch the next time I sit down and do lintian work. Just remembered this open issue when I saw your recent commits - I would have done this myself, but I have nearly no experience with the lintian.d.o setup. Don't worry, it's on my list. I'll commit it in this batch. Just cleaning out some other easier stuff first. :) Thank you for the reminder, though! -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
On Mon, Apr 28, 2008 at 03:44:44PM -0700, Russ Allbery wrote: Jordà Polo [EMAIL PROTECTED] writes: 1. http://ettin.org/tmp/ldo-mockup/v12/index.html 2. http://ettin.org/tmp/ldo-mockup/v12/full/unsorted.html 3. http://ettin.org/tmp/ldo-mockup/v12/lintian.d.o_v12.patch This looks great to me. Unless any of the other maintainers have any remaining issues, I plan on integrating this patch the next time I sit down and do lintian work. Fine with me. But I don't plan to work on it myself, will leave it to you. Gruesse, -- Frank Lichtenheld [EMAIL PROTECTED] www: http://www.djpig.de/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
On Sun, Apr 27, 2008 at 01:05:58PM -0700, Russ Allbery wrote: Hm, yes, that's a problem. I think I slightly prefer [4] in that case, but another possible change to [3] would be to just add the E/W/I in that case without any additional text (meaning probably text of just nbsp;). It would look a little weird, but it would be consistent and allow you to use the current layout. However, [4] is in some sense more accurate since the severity is a property of the tag and not of the extra information. Right. I also think it is more accurate - and leaving the E/W/I without the extra info looks really weird. So welcome v12[1][2][3]. 1. http://ettin.org/tmp/ldo-mockup/v12/index.html 2. http://ettin.org/tmp/ldo-mockup/v12/full/unsorted.html 3. http://ettin.org/tmp/ldo-mockup/v12/lintian.d.o_v12.patch -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
Jordà Polo [EMAIL PROTECTED] writes: Right. I also think it is more accurate - and leaving the E/W/I without the extra info looks really weird. So welcome v12[1][2][3]. 1. http://ettin.org/tmp/ldo-mockup/v12/index.html 2. http://ettin.org/tmp/ldo-mockup/v12/full/unsorted.html 3. http://ettin.org/tmp/ldo-mockup/v12/lintian.d.o_v12.patch This looks great to me. Unless any of the other maintainers have any remaining issues, I plan on integrating this patch the next time I sit down and do lintian work. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
On Sat, Apr 12, 2008 at 10:47:17PM +0200, Marc 'HE' Brockschmidt wrote: Have you had the time to look at the web pages generation to implement these changes already? It would be just nice to get rid of the current non-design :-) I have been polishing the last proposal and made a few more changes, including an updated front page/logo[1]. There is still room for improvement, but I think it is now getting to the point where it can be reviewed and included in svn trunk, so a patch is also available[2]. As far as I can tell, the only problem with the new layout are tags with no extra information, for which no E/W/I is displayed in the maintainer view[3] (I completely missed it until I tried the real log file). The only way I can think to fix this is moving the E/W/I back to the tag name, as in the v4 proposal[4], but I'm not sure if it is really needed. Any thoughts? 1. http://ettin.org/tmp/ldo-mockup/v11/index.html 2. http://ettin.org/tmp/ldo-mockup/v11/lintian.d.o.patch 3. http://ettin.org/tmp/ldo-mockup/v11/full/unsorted.html 4. http://ettin.org/tmp/ldo-mockup/v4/unsorted.html -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
Jordà Polo [EMAIL PROTECTED] writes: As far as I can tell, the only problem with the new layout are tags with no extra information, for which no E/W/I is displayed in the maintainer view[3] (I completely missed it until I tried the real log file). The only way I can think to fix this is moving the E/W/I back to the tag name, as in the v4 proposal[4], but I'm not sure if it is really needed. Any thoughts? 1. http://ettin.org/tmp/ldo-mockup/v11/index.html 2. http://ettin.org/tmp/ldo-mockup/v11/lintian.d.o.patch 3. http://ettin.org/tmp/ldo-mockup/v11/full/unsorted.html 4. http://ettin.org/tmp/ldo-mockup/v4/unsorted.html Hm, yes, that's a problem. I think I slightly prefer [4] in that case, but another possible change to [3] would be to just add the E/W/I in that case without any additional text (meaning probably text of just nbsp;). It would look a little weird, but it would be consistent and allow you to use the current layout. However, [4] is in some sense more accurate since the severity is a property of the tag and not of the extra information. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
On Sat, Apr 12, 2008 at 10:47:17PM +0200, Marc 'HE' Brockschmidt wrote: I wonder if there should be a big version of the small error/warning/info symbol [1] next to the tag name in the title instead of very many little ones - just imagine how http://lintian.debian.org/reports/tags/ancient-standards-version.html would look like with more than a thousand little, yellow Ws... It would look exactly like this[1] ;) So, you are right, it makes sense to use a single E/W/I, either in the title[2] or in some other place[3]. Have you had the time to look at the web pages generation to implement these changes already? It would be just nice to get rid of the current non-design :-) Hmm, I have been using `reporting/html_reports' since the beginning, if that's what you mean, so all the proposed changes are already implemented. I'm using a small log file[4] instead of the real lintian.log because I still don't have the maintainer info (lintian's list of source packages) and thus `html_reports' only generates a single, huge, hardly usable HTML file (unsorted.html). 1. http://ettin.org/tmp/ldo-mockup/v7/tags/ancient-standards-version.html 2. http://ettin.org/tmp/ldo-mockup/v8/tags/doc-base-unknown-section.html 3. http://ettin.org/tmp/ldo-mockup/v9/tags/doc-base-unknown-section.html 4. http://ettin.org/tmp/ldo-mockup/example.log -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
On Wed, Apr 09, 2008 at 12:39:21PM +0200, Marc 'HE' Brockschmidt wrote: Well, having the swirl somewhere (on the left?) would be nice. And why not leave the maintainer name where it is in the header, just add navigation items on the other side? I thought it would be a good idea because 1) maintainer name and navigation items aren't related at all, and 2) it can be a problem with lower resolutions (if the maintainer name is long enough). In v7[1] I made some minor changes to the header (they swirl is back!) and updated the tag pages: error[2], warning[3] and info[4]. Are tag pages too colorful now? 1. http://ettin.org/tmp/ldo-mockup/v7/full/unsorted.html 2. http://ettin.org/tmp/ldo-mockup/v7/tags/invalid-arch-string-in-source-relation.html 3. http://ettin.org/tmp/ldo-mockup/v7/tags/patch-system-but-direct-changes-in-diff.html 4. http://ettin.org/tmp/ldo-mockup/v7/tags/non-standard-arch-in-source-relation.html -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
Jordà Polo [EMAIL PROTECTED] writes: On Wed, Apr 09, 2008 at 12:39:21PM +0200, Marc 'HE' Brockschmidt wrote: Well, having the swirl somewhere (on the left?) would be nice. And why not leave the maintainer name where it is in the header, just add navigation items on the other side? I thought it would be a good idea because 1) maintainer name and navigation items aren't related at all, and 2) it can be a problem with lower resolutions (if the maintainer name is long enough). Hmmm, yeah, that work's too. It would just save a bit of vertical space, but I guess that's not really so important. In v7[1] I made some minor changes to the header (they swirl is back!) Looks very nice. and updated the tag pages: error[2], warning[3] and info[4]. Are tag pages too colorful now? I wonder if there should be a big version of the small error/warning/info symbol [1] next to the tag name in the title instead of very many little ones - just imagine how http://lintian.debian.org/reports/tags/ancient-standards-version.html would look like with more than a thousand little, yellow Ws... Have you had the time to look at the web pages generation to implement these changes already? It would be just nice to get rid of the current non-design :-) Marc Footnotes: [1] The E|W|I with color, I mean -- BOFH #285: Telecommunications is upgrading. pgpKf7tbw6lBY.pgp Description: PGP signature
Re: lintian.d.o improvements
On Mon, Apr 07, 2008 at 01:58:06AM +0200, Marc 'HE' Brockschmidt wrote: What about using list-style-image to set the bullet point to the litte W/E graphics? When doing so, li class=type-? instead of lispan class=type-? might also be a nice change. I guess you mean something like this[1]. It looks good, probably even better than the previous proposal, but I somehow feel it isn't right to repeat those E/W/I after removing all duplicated info, so I'm not sure about it. Another idea I have been thinking about is, does it make sense to have a common header to make navigation easier? See v6[2]. Again, note that it is still a work in progress, the final header will not necessarily look like that, it is just an idea. Finally, I would like to know if the files used to generate lintian.d.o (log file, package info) are available somewhere. I just want to make sure everything works as expected. I know I could do it myself creating a laboratory, but I don't have a mirror at the moment (and not enough HD space either), so it will take a while. 1. http://ettin.org/tmp/ldo-mockup/v5/unsorted.html 2. http://ettin.org/tmp/ldo-mockup/v6/unsorted.html -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
=?utf-8?B?Sm9yZMOg?= Polo [EMAIL PROTECTED] writes: On Mon, Apr 07, 2008 at 01:58:06AM +0200, Marc 'HE' Brockschmidt wrote: What about using list-style-image to set the bullet point to the litte W/E graphics? When doing so, li class=type-? instead of lispan class=type-? might also be a nice change. I guess you mean something like this[1]. It looks good, probably even better than the previous proposal, but I somehow feel it isn't right to repeat those E/W/I after removing all duplicated info, so I'm not sure about it. Well, the idea is to convey the information how often a certain error happens in a graphical way, that is not really duplicated information. Another idea I have been thinking about is, does it make sense to have a common header to make navigation easier? See v6[2]. Again, note that it is still a work in progress, the final header will not necessarily look like that, it is just an idea. Well, having the swirl somewhere (on the left?) would be nice. And why not leave the maintainer name where it is in the header, just add navigation items on the other side? Finally, I would like to know if the files used to generate lintian.d.o (log file, package info) are available somewhere. http://lintian.debian.org/lintian.log gives you a full log file for the run. Marc -- BOFH #321: Scheduled global CPU outage pgpHzUfzqrBj9.pgp Description: PGP signature
Re: lintian.d.o improvements
Jordà Polo [EMAIL PROTECTED] writes: On Sun, Apr 06, 2008 at 03:06:59PM +0200, Marc 'HE' Brockschmidt wrote: I don't see how displaying the tag name more than once would help. This would require some postprocessing of the results, though, but shouldn't be too hard. Well, displaying the tag name more than once can help to identify the number of E/W/I more clearly. But I still think it is worth trying, see v4[1]. What about using list-style-image to set the bullet point to the litte W/E graphics? When doing so, li class=type-? instead of lispan class=type-? might also be a nice change. Marc -- Fachbegriffe der Informatik - Einfach erklärt 274: Nikoma-Newsserver Museum für prähistorische Gruppen. (Ulrich Mindrup) pgpicTOeRjAE8.pgp Description: PGP signature
Re: lintian.d.o improvements
=?utf-8?B?Sm9yZMOg?= Polo [EMAIL PROTECTED] writes: On Fri, Apr 04, 2008 at 04:17:52PM -0700, Russ Allbery wrote: The reason why the tags were still in pre was because when the extra information wraps, it looks really odd and often hinders readability. That's right, though I'm not sure using the horizontal scrollbar is so much better: it can be annoying if one package has both, long and short lines. Anyway, is there reason to keep all the info in the same line? I agree wrapping hinders readability in the current proposal, but how about moving the extra info below the tag[1]? Hmmm, while we are at reformatting: What about merging all extra-information for a given tag, without outputting the tag-name again? As example, instead of this: |binary | |* W patch-system-but-direct-changes-in-diff | config.guess |* W patch-system-but-direct-changes-in-diff | config.sub ... we could display this: |binary | |* W patch-system-but-direct-changes-in-diff | config.guess | config.sub I don't see how displaying the tag name more than once would help. This would require some postprocessing of the results, though, but shouldn't be too hard. Marc -- BOFH #432: Borg nanites have infested the server pgpDoDeMBN6O9.pgp Description: PGP signature
Re: lintian.d.o improvements
On Sun, Apr 06, 2008 at 03:06:59PM +0200, Marc 'HE' Brockschmidt wrote: Hmmm, while we are at reformatting: What about merging all extra-information for a given tag, without outputting the tag-name again? Good idea. I don't see how displaying the tag name more than once would help. This would require some postprocessing of the results, though, but shouldn't be too hard. Well, displaying the tag name more than once can help to identify the number of E/W/I more clearly. But I still think it is worth trying, see v4[1]. 1. http://ettin.org/tmp/ldo-mockup/v4/unsorted.html -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
Jordà Polo [EMAIL PROTECTED] writes: On Sun, Apr 06, 2008 at 03:06:59PM +0200, Marc 'HE' Brockschmidt wrote: I don't see how displaying the tag name more than once would help. This would require some postprocessing of the results, though, but shouldn't be too hard. Well, displaying the tag name more than once can help to identify the number of E/W/I more clearly. But I still think it is worth trying, see v4[1]. 1. http://ettin.org/tmp/ldo-mockup/v4/unsorted.html I think that looks great! -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/
Re: lintian.d.o improvements
On Fri, Apr 04, 2008 at 04:17:52PM -0700, Russ Allbery wrote: The reason why the tags were still in pre was because when the extra information wraps, it looks really odd and often hinders readability. That's right, though I'm not sure using the horizontal scrollbar is so much better: it can be annoying if one package has both, long and short lines. Anyway, is there reason to keep all the info in the same line? I agree wrapping hinders readability in the current proposal, but how about moving the extra info below the tag[1]? This would also have another advantage: keeping the extra info always in the same place instead of some variable position that depends on the length of the tag. I didn't have the time to try to research how to use CSS to tell it to not wrap. If there's some way to do that that works reasonably portably, I think not having it be pre is okay (although the results may look odd on text-mode browsers). It looks like «white-space: nowrap;» does the job, though it is far from perfect: headers and titles aren't resized, so it looks a bit weird with the current layout[2]. 1. http://ettin.org/tmp/ldo-mockup/v3/unsorted.html 2. http://ettin.org/tmp/ldo-mockup/v2/unsorted.html -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Re: lintian.d.o improvements
Jordà Polo [EMAIL PROTECTED] writes: On Fri, Apr 04, 2008 at 04:17:52PM -0700, Russ Allbery wrote: The reason why the tags were still in pre was because when the extra information wraps, it looks really odd and often hinders readability. That's right, though I'm not sure using the horizontal scrollbar is so much better: it can be annoying if one package has both, long and short lines. Anyway, is there reason to keep all the info in the same line? I agree wrapping hinders readability in the current proposal, but how about moving the extra info below the tag[1]? Huh, that actually looks better than I expected it to. I think that would work rather well. And then it doesn't matter if it wraps. I think I'd go with this. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/
Re: lintian.d.o improvements
Jordà Polo [EMAIL PROTECTED] writes: I haven't changed the representation of tags yet, but I liked the idea of using colors, so I have been playing a bit with the templates and the CSS stylesheet to get more familiar with the code (right, it isn't the most relevant part of code for the GSoC project, but it can't hurt either). The changes I made to templates/maintainer.tmpl and lintian.css include: * Colorized severities * Summary of source packages * Convert tags inside pre to real lists * Add subtitles for binary packages and remove the source/binary part since it is now more obvious * More Debian-themed (it has a swirl now!) If you are interested, a first mock-up is already available[1]. Since it is still a work in progress and there may be some glitches, I made a screenshot[2] so you can see how it is supposed to look. This is pretty! The reason why the tags were still in pre was because when the extra information wraps, it looks really odd and often hinders readability. I didn't have the time to try to research how to use CSS to tell it to not wrap. If there's some way to do that that works reasonably portably, I think not having it be pre is okay (although the results may look odd on text-mode browsers). The subtitles look good here, as does the summary. I think this looks like a great change. -- Russ Allbery ([EMAIL PROTECTED]) http://www.eyrie.org/~eagle/
