Re: RFS: pacman-package-manager/6.0.1-1 [ITP] -- Simple library-based package manager

2022-07-28 Thread Ben Westover
Hello Luca and Michel,

On 7/28/22 5:50 PM, Michel Alexandre Salim wrote:
> Hi Ben,
> I was independently working on pacman, and (thanks to the name
> collision with the existing pacman package) didn't notice this until
> it's mostly done.

That existing package is orphaned anyway, so it's annoying that it's
already there and not even being maintained. I do think it's still a
good idea to keep the current package name so people don't get confused
and accidentally install a potentially dangerous package manager for
another distribution instead of an arcade game.

> My use case is helping make systemd/mkosi CI easier (since it's hosted
> on GitHub, which provides Ubuntu LTS builders) - I'll flag this to
> some relevant people so they can help get this sponsored.
>
> PS archlinux-keyring is on its way to unstable, and per some feedback
> the keyring target directory is moved to the standard Debian path:
>
> https://salsa.debian.org/michel/archlinux-keyring/-/blob/main/debian
> /patches/use_std_keyring_dir.diff
>
> might want to apply this to your pacman, and configure pacman to use
> this path:
>
> https://gitlab.archlinux.org/pacman/pacman/-/merge_requests/11

Okay, I've added the patch to my package and configured the keyringdir
option in debian/rules.

On 7/28/22 6:27 PM, Luca Boccassi wrote:
> Hi,
> 
> I can sponsor this.
> 
> A few remarks, aside from the keyring change mentioned by Michel:
> 
> - all the doc build-dependencies (asciidoc, doxygen, help2man) can be
> marked with  so that nodoc builds can be done
> - are curl and fakechroot really needed to build the package, or are
> they just used by self tests? if they are used only by tests, mark them
> as 
> - is pkgconf really needed instead of pkgconfig, which is the default?
> - you need to add a libalpm-dev and ship the headers, pkgconfig file,
> unversioned .so and manpage in it, instead of in libalpm13, and remove
> the lintian override
> - libalpm13 is missing Pre-Depends: ${misc:Pre-Depends}
> - no need to specify the libarchive-tools and libgpgme11 dependencies
> on libalpm13, they will be autogenerated
> - does libalpm13 really need to depend on the binary curl executable?

Thanks, all of those have been fixed.

> - makepkg should not depend on build-essential nor on sudo

I was under the impression that makepkg depended on sudo, but after a
deeper look into the code, it appears to fall back on su if sudo is not
detected. I put build-essential there since makepkg expects base-devel,
the Arch Linux equivalent of build-essential, to be installed. I've now
removed sudo from Depends and moved build-essential to Recommends since
in most cases you would want it installed but it's not required.

> - no need to manually specify the dependency on libalpm13 in makepkg,
> it will be autogenerated
> - libalpm13 is missing the symbols file, you can generate it after
> building the library with:
>dpkg-gensymbols -plibalpm13 
> -edebian/tmp/usr/lib/x86_64-linux-gnu/libalpm.so.13.0.1 
> -Odebian/libalpm13.symbols
> - makepkg is missing a dependency on ${perl:Depends}

Fixed

> - are you sure all of these can run on GNU/Hurd and debian/kFreeBSD? If
> not, use 'linux-any' instead of 'any' as the architecture

Funny you should say that; I actually have a Debian GNU/kFreeBSD system
that I installed out of curiosity last year. When I was originally
making this package, I tested it out on that system and it worked.

> - it is not necessary anymore to specify the build system in
> debian/rules, meson is autodetected
> - use execute_before_dh_auto_clean instead of override_

Fixed

> - 228 tests fail when running in a pbuilder chroot, this is a strong
> hint that the build might fail once uploaded

I use sbuild instead of pbuilder since it's considered to be legacy at
this point. As Michel noted, these failures are solved by two additional
build depends (one of which you should've already had) which I've added.

> - you should try and fix the reproducible build, rather than disabling
> it in the CI

I've tested reproducibility with reprotest and it's perfectly
reproducible. Salsa CI fails a bunch of tests on its second
reproducibility build, and I haven't been able to find the root cause.
It's been suggested to me that Salsa CI's reprotest job might be faulty.
I'll do some more research into the topic when I have time.

> - the GPL-2+ in debian/copyright says in the last paragraph:
>"On Debian systems, the full text of the GNU General Public
> License version 3 can be found in the file"
>   instead of version 2

Fixed

Thank you both for your interest and deep review of this package! I
learned a lot of minor Debian things that I didn't know about before.
I've published my changes to Salsa and Mentors. You've helped me to
address the weaker points of my package that I wasn't so sure about
(dependencies and packaging a library) and I've learned more in my
Debian packaging journey as a result!

Thanks,
--
Ben Westover


OpenPGP_signature
Description: 

Bug#1016107: marked as done (RFS: dh-nss/1 [ITP] -- debhelper addon to inject NSS services into /etc/nsswitch.conf)

2022-07-28 Thread Debian Bug Tracking System
Your message dated Fri, 29 Jul 2022 02:15:50 +0200
with message-id <20220729001550.ms4uazdweeqv6...@zeha.at>
and subject line #1016107: dh-nss
has caused the Debian Bug report #1016107,
regarding RFS: dh-nss/1 [ITP] -- debhelper addon to inject NSS services into 
/etc/nsswitch.conf
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1016107: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016107
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---

Package: sponsorship-requests
Severity: wishlist

Dear mentors,

I am looking for a sponsor for my package "dh-nss":

 * Package name: dh-nss
   Version : 1
   Upstream Author : Gioele Barabucci
 * URL : https://salsa.debian.org/gioele/dh-nss
 * License : ISC
 * Vcs : https://salsa.debian.org/gioele/dh-nss
   Section : devel
 * ITP : https://bugs.debian.org/1016100

The source builds the following binary packages:

  dh-nss - debhelper addon to inject NSS services into /etc/nsswitch.conf

To access further information about this package, please visit the 
following URL:


  https://mentors.debian.net/package/dh-nss/

Alternatively, you can download the package with 'dget' using this command:

  dget -x https://mentors.debian.net/debian/pool/main/d/dh-nss/dh-nss_1.dsc

Changes for the initial release:

 dh-nss (1) unstable; urgency=medium
 .
   * Initial release (Closes: #1016100)

Regards,

--
Gioele Barabucci
--- End Message ---
--- Begin Message ---
I've uploaded dh-nss_1, but its obviously now in NEW.

Chris--- End Message ---


Re: RFS: pacman-package-manager/6.0.1-1 [ITP] -- Simple library-based package manager

2022-07-28 Thread Michel Alexandre Salim
On Thu, Jul 28, 2022 at 11:27:37PM +0100, Luca Boccassi wrote:
> On Sat, 19 Feb 2022 00:13:37 -0500 Ben Westover
>  wrote:
> > Package: sponsorship-requests
> > Severity: wishlist
> > 
> > Dear mentors,
> > 
> > I am looking for a sponsor for my package "pacman-package-manager":
> > 
> 
> Hi,
> 
> I can sponsor this.
> 
> - 228 tests fail when running in a pbuilder chroot, this is a strong
> hint that the build might fail once uploaded

I spent this morning bashing those tests: to get them to pass, both
fakeroot (fixes ~ 200 tests; not needed if running meson test interactively)
and fakechroot (for the last ~ 19 tests) need to be added to BuildDepends.

Best regards,

-- 
Michel Alexandre Salim
identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2


signature.asc
Description: PGP signature


Re: RFS: pacman-package-manager/6.0.1-1 [ITP] -- Simple library-based package manager

2022-07-28 Thread Luca Boccassi
On Sat, 19 Feb 2022 00:13:37 -0500 Ben Westover
 wrote:
> Package: sponsorship-requests
> Severity: wishlist
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "pacman-package-manager":
> 
>   * Package name    : pacman-package-manager
> Version : 6.0.1-1
> Upstream Author : Pacman Development Team

>   * URL : https://archlinux.org/pacman/
>   * License : GPL-2+, MIT, curl, unlicense, public-domain
>   * Vcs : https://salsa.debian.org/benthetechguy/pacman
> Section : admin
> 
> It builds those binary packages:
> 
>    pacman-package-manager - Simple library-based package manager
>    libalpm13 - Arch Linux Package Management library
>    makepkg - Arch Linux package build utility
> 
> To access further information about this package, please visit the 
> following URL:
> 
>    https://mentors.debian.net/package/pacman-package-manager/
> 
> Alternatively, one can download the package with dget using this
command:
> 
>    dget -x 
>
https://mentors.debian.net/debian/pool/main/p/pacman-package-manager/pacman-package-manager_6.0.1-1.dsc
> 
> Changes for the initial release:
> 
>   pacman-package-manager (6.0.1-1) unstable; urgency=medium
>   .
> * Initial Package (Closes: #511994)

Hi,

I can sponsor this.

A few remarks, aside from the keyring change mentioned by Michel:

- all the doc build-dependencies (asciidoc, doxygen, help2man) can be
marked with  so that nodoc builds can be done
- are curl and fakechroot really needed to build the package, or are
they just used by self tests? if they are used only by tests, mark them
as 
- is pkgconf really needed instead of pkgconfig, which is the default?
- you need to add a libalpm-dev and ship the headers, pkgconfig file,
unversioned .so and manpage in it, instead of in libalpm13, and remove
the lintian override
- libalpm13 is missing Pre-Depends: ${misc:Pre-Depends}
- no need to specify the libarchive-tools and libgpgme11 dependencies
on libalpm13, they will be autogenerated
- does libalpm13 really need to depend on the binary curl executable?
- makepkg should not depend on build-essential nor on sudo
- no need to manually specify the dependency on libalpm13 in makepkg,
it will be autogenerated
- libalpm13 is missing the symbols file, you can generate it after
building the library with:
   dpkg-gensymbols -plibalpm13 
-edebian/tmp/usr/lib/x86_64-linux-gnu/libalpm.so.13.0.1 
-Odebian/libalpm13.symbols
- makepkg is missing a dependency on ${perl:Depends}
- are you sure all of these can run on GNU/Hurd and debian/kFreeBSD? If
not, use 'linux-any' instead of 'any' as the architecture
- it is not necessary anymore to specify the build system in
debian/rules, meson is autodetected
- use execute_before_dh_auto_clean instead of override_
- 228 tests fail when running in a pbuilder chroot, this is a strong
hint that the build might fail once uploaded
- you should try and fix the reproducible build, rather than disabling
it in the CI
- the GPL-2+ in debian/copyright says in the last paragraph:
   "On Debian systems, the full text of the GNU General Public
License version 3 can be found in the file"
  instead of version 2

-- 
Kind regards,
Luca Boccassi


signature.asc
Description: This is a digitally signed message part


Re: RFS: pacman-package-manager/6.0.1-1 [ITP] -- Simple library-based package manager

2022-07-28 Thread Michel Alexandre Salim
Hi Ben,

I was independently working on packaging pacman, and (thanks to the name
collision with the preexisting pacman package) didn't notice this until
it's mostly done.

My use case is helping make systemd/mkosi CI easier (since it's hosted
on GitHub, and GitHub provides Ubuntu LTS builders) - I'll flag this to
some relevant people so they can help get this sponsored.

PS archlinux-keyring is on its way to unstable, and per review feedback
the keyring target directory is moved to the standard Debian path:

https://salsa.debian.org/michel/archlinux-keyring/-/blob/main/debian/patches/use_std_keyring_dir.diff

might want to apply this to your pacman, and configure pacman to use
this path:

https://gitlab.archlinux.org/pacman/pacman/-/merge_requests/11

Best regards,

-- 
Michel Alexandre Salim
identities: https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2


signature.asc
Description: PGP signature


Bug#1015169: RFS: mir-eval/0.7-1 [ITP] -- Common metrics for common audio/music processing tasks

2022-07-28 Thread Bastian Germann

Control: tags -1 moreinfo

On Fri, 22 Jul 2022 04:13:39 +0200 Bastian Germann  wrote:

Disabling all of the tests is a bit of an overkill. Please only disable the 
ones that need those deprecated classes.
It should be enough to disable test_display and mpl_ic.


What you are doing is running the tests and do not care how if they fail. This is against the idea of running a test 
suite. Please only untag moreinfo when you have dealt with this. It is not hard to figure out how to skip a Python test.

Repeating: "man pybuild should give you the environment variables to override the 
default test runner's arguments."



Bug#1015968: RFS: xbase64/3.1.2-14 -- xbase compatible C++ class library

2022-07-28 Thread Jörg Frings-Fürst
Hello Adam,

thanks for your review.


Am Mittwoch, dem 27.07.2022 um 04:26 +0200 schrieb Adam Borowski:
> On Sun, Jul 24, 2022 at 04:53:52PM +0200, Jörg Frings-Fürst wrote:
> >    Package name    : xbase64
> >    Version : 3.1.2-14
> 
> >  xbase64 (3.1.2-14) unstable; urgency=medium
> >  .
> >    * Migrate to debhelper-compat 13:
> >  - debian/control: Add debhelper-compat (= 13).
> >  - Remove debian/compat.
> >  - Add usr/bin/xbase64-config into new debian/not-installed.
> >  - Add usr/lib/${DEB_HOST_MULTIARCH}/libxbase64.la to
> >  debian/libxbase64-bin.install.
> >    * Declare compliance with Debian Policy 4.6.1.0 (No changes
> > needed).
> >    * debian/copyright:
> >  - Add year 2022 to myself.
> >    * Disable Link time optimization (Closes: #1015707):
> >  - debian/rules: Add optimize=-lto to DEB_BUILD_MAINT_OPTIONS.
> >    * debian/control: Add Rules-Requires-Root: no.
> 
> Is there a reason you include the .la file?  From my experience it
> being
> needed for anything suggests severe borkage, and the Policy concurs:
> 
[...]

That was my mistake. I only paid attention to the messages from
dh_missing and installed the la file without thinking too much.

Once again, thank you for your advice.

The error is corrected and uploaded to git and mentors.

> 
> 
> Meow!

CU
Jörg


-- 
New:
GPG Fingerprint: 63E0 075F C8D4 3ABB 35AB  30EE 09F8 9F3C 8CA1 D25D
GPG key (long) : 09F89F3C8CA1D25D
GPG Key: 8CA1D25D
CAcert Key S/N : 0E:D4:56

Old pgp Key: BE581B6E (revoked since 2014-12-31).

Jörg Frings-Fürst
D-54470 Lieser


git:  https://jff.email/cgit/

Threema: SYR8SJXB
Wire: @joergfringsfuerst
Skype: joergpenguin
Ring: jff
Telegram: @joergfringsfuerst


My wish list: 
 - Please send me a picture from the nature at your home.



signature.asc
Description: This is a digitally signed message part


Bug#1002295: Uploaded the files

2022-07-28 Thread Evangelos Ribeiro Tzaras
Hi,

On Thu, 2022-07-28 at 14:49 +, Scorpion2185 wrote:
> I updated the watch file. Is it correct now?

You can always try
$ uscan --verbose --no-download

This can also help greatly with debugging issues with the name mangling.

-- 
Cheers,

Evangelos
PGP: B938 6554 B7DD 266B CB8E 29A9 90F0 C9B1 8A6B 4A19


signature.asc
Description: This is a digitally signed message part


Bug#1002295: Uploaded the files

2022-07-28 Thread Bastian Germann

Am 28.07.22 um 16:49 schrieb Scorpion2185:

I see "multi-timer (0.2.0-0.1) unstable; urgency=medium" in the changelog, what 
version should I use instead?
The upstream version is 0.2.0.
Mentor's warning wanted me to use a -x.x format.


You have to use 0.2.0-1, as I have already pointed out in my previous email 
(Debian revision has to be -1).
The lintian warning about the NMU was because of the "" around realroot.


I removed the "".


Fine, so now lintian generates a maintainer-upload-has-incorrect-version-number 
because of the -0.1 revision.


I updated the watch file. Is it correct now?


Nope. Please read man uscan.


Sent with Proton Mail secure email.

--- Original Message ---
On Wednesday, July 27th, 2022 at 8:18 PM, Bastian Germann 
 wrote:



Control: tags -1 moreinfo

On Wed, 18 May 2022 14:34:23 +0200 Bastian Germann b...@debian.org wrote:


On Fri, 29 Apr 2022 14:57:13 + Scorpion2185 scorpion2...@proton.me wrote:


I updated the files again, no lintian errors.
There is warning about man page, the author changed the name of the bin the man 
page is there.


There is still 1 lintian error:
debian-rules-is-dh_make-template

...and several warnings:
source-nmu-has-incorrect-version-number (Please use the same name/email in 
changelog and Maintainer)



d/changelog:
There is also the problem of a bad Debian revision. This has to be -1 for an 
initial package version.
Please also remove the ”” around realroot.


syntax-error-in-dep5-copyright

For me, the following lintian information is also a blocker:
debian-watch-file-is-missing



The provided watch file does not work because there are no git tags.




Bug#1016152: marked as done (RFS: libxml-dumper-perl/0.81-1.4 [NMU] [RC] -- Perl module for dumping Perl objects from/to XML)

2022-07-28 Thread Debian Bug Tracking System
Your message dated Thu, 28 Jul 2022 13:25:58 +0200
with message-id 
and subject line Re: Bug#1016152: RFS: libxml-dumper-perl/0.81-1.4 [NMU] [RC] 
-- Perl module for dumping Perl objects from/to XML
has caused the Debian Bug report #1016152,
regarding RFS: libxml-dumper-perl/0.81-1.4 [NMU] [RC] -- Perl module for 
dumping Perl objects from/to XML
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1016152: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016152
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for my package "libxml-dumper-perl":

 * Package name: libxml-dumper-perl
   Version : 0.81-1.4
   Upstream Author :
 * URL :
 * License :
 * Vcs :
   Section : perl

The source builds the following binary packages:

  libxml-dumper-perl - Perl module for dumping Perl objects from/to XML

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/libxml-dumper-perl/

Alternatively, you can download the package with 'dget' using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/libx/libxml-dumper-perl/libxml-dumper-perl_0.81-1.4.dsc

Changes since the last upload:

 libxml-dumper-perl (0.81-1.4) unstable; urgency=medium
 .
   * Non-maintainer upload.
   * Include missing build target. (Closes: #999310)
  - Using dh sequencer.
  - Add libxml-parser-perl as build dependency, for testsuite.
  - Add runtime dependency on ${misc:Depends}.
   * d/watch
 - Bump to version 4.
 - Update URI.
   * Remove superfluous dot '.' in package description
   * d/copyright: Change to UTF-8 encoding.

Regards,
Håvard
--- End Message ---
--- Begin Message ---
Control: tag 999310 + pending

On Thu, 28 Jul 2022 08:25:47 +0200, Håvard F. Aasen wrote:

>  libxml-dumper-perl (0.81-1.4) unstable; urgency=medium
>  .
>* Non-maintainer upload.
>* Include missing build target. (Closes: #999310)
>   - Using dh sequencer.
>   - Add libxml-parser-perl as build dependency, for testsuite.
>   - Add runtime dependency on ${misc:Depends}.
>* d/watch
>  - Bump to version 4.
>  - Update URI.
>* Remove superfluous dot '.' in package description
>* d/copyright: Change to UTF-8 encoding.

Uploaded to DELAYED/5, thanks for fixing this RC bug.

(For future reference: You changed a bit more than what is necessary
to fix th ebug, which is a bit unusual for NMUs. But is the changes
are all sane, I just went ahead with the upload.)

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   


signature.asc
Description: Digital Signature
--- End Message ---


Bug#1016161: marked as done (RFS: dsdp/5.8-10 [QA] [RC] -- Software for Semidefinite Programming)

2022-07-28 Thread Debian Bug Tracking System
Your message dated Thu, 28 Jul 2022 12:17:24 +0200
with message-id <2205d9d2-9a8c-bccd-232f-eab16c0ff...@debian.org>
and subject line Re: RFS: dsdp/5.8-10 [QA] [RC] -- Software for Semidefinite 
Programming
has caused the Debian Bug report #1016161,
regarding RFS: dsdp/5.8-10 [QA] [RC] -- Software for Semidefinite Programming
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact ow...@bugs.debian.org
immediately.)


-- 
1016161: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1016161
Debian Bug Tracking System
Contact ow...@bugs.debian.org with problems
--- Begin Message ---
Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for my package "dsdp":

 * Package name: dsdp
   Version : 5.8-10
   Upstream Author :
 * URL : http://www-unix.mcs.anl.gov/DSDP/
 * License :
 * Vcs : https://salsa.debian.org/debian/dsdp
   Section : science

The source builds the following binary packages:

  dsdp - Software for Semidefinite Programming
  dsdp-doc - Software for Semidefinite Programming
  libdsdp-dev - Software for Semidefinite Programming
  libdsdp-5.8gf - Software for Semidefinite Programming

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/dsdp/

Alternatively, you can download the package with 'dget' using this command:

  dget -x https://mentors.debian.net/debian/pool/main/d/dsdp/dsdp_5.8-10.dsc

Changes since the last upload:

 dsdp (5.8-10) unstable; urgency=medium
 .
   * QA upload.
   * Mark package as orphaned, see #881843.
   * d/control:
 - Bump debhelper to 7. Closes: #965498
 - Change section, extra -> optional.
 - Change Vcs-* fields, point to salsa.
 - Add Multi-Arch: foreign, to dsdp-doc package.
   * Make package build reproducible, don't install log files in *-doc package.
 Thanks to Chris Lamb. Closes: #939548
   * d/rules:
 - Make sure directory 'lib' actually exist before use.
   * Add d/gbp.conf, specify branch layout.

Regards,
Håvard
--- End Message ---
--- Begin Message ---

Thanks for your QA work.--- End Message ---