Bug#675701: RFS: ptop/3.6.2-7
Hi Bas, I see that the package at mentors is still the one uploaded there on 2012-06-23 20:07, so there are comments on the RFS that are not yet processed. Are you still working on this, or can this RFS be closed ? Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120729065122.ge18...@master.debian.org
Bug#675701: RFS: ptop/3.6.2-7
Hi Bas, I'm not sure about removing that the Debian packaging is Copyright (C) 2007, Adam Majer ad...@zombino.com from debian/copyright. Are you ? The files port.h and sprompt.c also have a copyright notice with PostgreSQL Global Development Group but that is not mentioned in debian/copyright. As I said before, please scan the upstream source code for copyright notices and licenses. Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120608054804.gb8...@master.debian.org
Bug#675701: RFS: ptop/3.6.2-7
On Tue, Jun 05, 2012 at 05:20:29AM +, Bart Martens wrote: Hi Bas, Hi Bas, I'm now reviewing your upload of 2012-06-05 07:30. I suggest to do the following changes: - Remove machine/m_gnu.c from debian/patches/ptop_hurd, OK. - Add cp -f machine/m_linux.c machine/m_gnu.c to debian/rules, I don't find any cp in debian/rules. Did you use a different approach ? - Add debian/clean containing machine/m_gnu.c, I don't see any file that matches debian/*clean. Did you use a different approach ? - Add similar changes for the other arch(s) with the same problem, - Rename debian/patches/ptop_hurd to debian/patches/archs, The patch debian/patches/archs contains this line: + kfrebsd-gnu*) MODULE=linux;; Is that a typing mistake ? - Update Architecture: in debian/control. It's set to Architecture: any now. Are all architecture related problems solved ? I'm not sure about removing hppa and powerpcspe from ptop's archs list because I don't know the issue with debhelper on these archs. Is it really a permanent problem ? Maybe ptop can have Architecture: any. This page http://buildd.debian-ports.org/status/package.php?p=debhelpersuite=sid states No entry in hppa database, check Packages-arch-specific but this page https://buildd.debian-ports.org/quinn-diff/sid/Packages-arch-specific seems to fail at this time. You seem to have decided to include both hppa and powerpcspe. Is the problem with debhelper on hppa and powerpcspe solved or not permanent ? I see that you have updated debian/copyright, but it is not ready yet. Please look at the file LICENSE and compare that to debian/copyright. They currently don't match. Also, please scan the upstream source code for copyright notices and licenses. For example, the file pg_trace.h contains Copyright (c) 2006, PostgreSQL Global Development Group and that is not yet mentioned in debian/copyright, and it is not clear whether pg_trace.h has the same license as the one in the file LICENSE. Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120605174321.gh9...@master.debian.org
Bug#675701: RFS: ptop/3.6.2-7
Hi Bas, I suggest to do the following changes: - Remove machine/m_gnu.c from debian/patches/ptop_hurd, - Add cp -f machine/m_linux.c machine/m_gnu.c to debian/rules, - Add debian/clean containing machine/m_gnu.c, - Add similar changes for the other arch(s) with the same problem, - Rename debian/patches/ptop_hurd to debian/patches/archs, - Update Architecture: in debian/control. I'm not sure about removing hppa and powerpcspe from ptop's archs list because I don't know the issue with debhelper on these archs. Is it really a permanent problem ? Maybe ptop can have Architecture: any. This page http://buildd.debian-ports.org/status/package.php?p=debhelpersuite=sid states No entry in hppa database, check Packages-arch-specific but this page https://buildd.debian-ports.org/quinn-diff/sid/Packages-arch-specific seems to fail at this time. I looked this up: http://www.debian.org/doc/debian-policy/ch-docs.html#s-copyrightfile must be accompanied by a verbatim copy of its copyright information should name the original authors I see in the file LICENSE that William LeFebvre is copyright holder but that is not yet mentioned in debian/copyright. That's a must for debian-policy. I see that there are quite some authors. Mentioning them in debian/copyright is a should for debian-policy. To help you with listing them, I found these authors so far: Andrew Herbert Andrew S. Townley Anthony Baxter Ariel Faigon Christos Zoulas Joep Vesseur John Haxby John Schimmel Kevin Schmidt Larry McVoy Mike Hopkirk Richard Henderson Sandeep Cariapa Thorsten Lockert Torsten Kasch William LeFebvre Rich Holland Mark Wong I think that the list is pretty complete, but it's possible that I've missed a few. I have left out the e-mail addresses to prevent complaints about spam. I suggest to add this list to debian/copyright. It's a should for debian-policy. Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120605052029.gb21...@master.debian.org
Bug#675701: RFS: ptop/3.6.2-7
Package: sponsorship-requests Severity: minor Dear mentors, I am looking for a sponsor for my package ptop * Package name: ptop Version : 3.6.2-7 Upstream Author : Mark Wong mark...@gmail.com * URL : http://ptop.projects.postgresql.org/ * License : BSD Section : misc It builds those binary packages: ptop - PostgreSQL performance monitoring tool akin to top To access further information about this package, please visit the following URL: http://mentors.debian.net/package/ptop Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/p/ptop/ptop_3.6.2-7.dsc More information about hello can be obtained from http://www.example.com. Changes since the last upload: * Remove architechtures hurd-i386, kfreebsd-amd64 and kfreebsd-i386 because they alway fail * Changed Standards-Version to 3.9.3 Regards, Bas van den Dikkenberg -- System Information: Debian Release: wheezy/sid APT prefers testing-proposed-updates APT policy: (500, 'testing-proposed-updates'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-2-amd64 (SMP w/2 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/0866c4da-5ce8-4d67-bc3a-12b6dbebd826@srv01.dikkenberg.local
Bug#675701: RFS: ptop/3.6.2-7
Hi Bastiaan, Please have another look at the list of architectures. http://mentors.debian.net/package/ptop Uploaded: 2012-06-02 19:35 * Remove architechtures hurd-i386, kfreebsd-amd64 and kfreebsd-i386 because they alway fail Architecture: amd64 armel armhf i386 ia64 mips mipsel powerpc s390 s390x sparc sparc64 sh4 ppc64 powerpcspe m68k m68k armhf alpha https://buildd.debian.org/status/package.php?p=ptop http://buildd.debian-ports.org/status/package.php?p=ptop Also, have you tried asking help on debian-...@lists.debian.org and debian-h...@lists.debian.org ? Maybe you want to open a bug in the BTS to log all related information. Regards, Bart Martens -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20120603055009.ga30...@master.debian.org
