Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi mentors, Thanks to some help from the folk over at debian-bsd i've now managed to solve the bugs surrounding GNU/kFreeBSD. As usual the package details can be found at https://mentors.debian.net/package/vpcs Alternatively downloaded via dget -x http://mentors.debian.net/debian/pool/main/v/vpcs/vpcs_0.5b0-1.dsc Regards, Daniel Lintott On 02/10/13 21:25, Daniel Lintott wrote: Hi Juhani, Juhani Numminen juhaninummin...@gmail.com wrote: I can confirm this. While trying to reproduce the bug, I found something rather strange (affecting Linux and GNU/kFreeBSD): the code wants the user to call it by the full name of the binary.[1] # This one doesn’t work vpcs -H 23456 # This works $(which vpcs) -H 23456 # or /usr/bin/vpcs -H 23456 Not sure if this is a bug to report, as I can see upstream is already working with this in their repository. Yes, I did find this bug as well, which the upstream author has now fixed. I've created the appropriate patch so it will be fixed in the next upload Regards, Daniel Lintott -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSU+lyAAoJEMw/9yOWzAkJBjcH/jEwZ37U3H49qIT6qpSXSa90 0sSWWj8BxuNKTq16x0WRgdsf0JRRqSqOPxm/WLGiRI9LTFaa8y+YD7Yq+D7Mjr4q x/OIfCyovESS6iLrg9SkpPP417XwSEkt7YprVJ6Y8jLiEflm78pddkno0sgUGQe+ QauQk3uUTdfGiDYsYOJo3Yp1Bh1+hZoLMm++6jgKR2d+chiWaTYD2NYtvy2NZTy+ IYSdt33FwXPxQpNrXVxzL3JYgdrXCzyJMSts5hyTv0qLNtJ7qI0WISFtw5Oy9yYR FVJyifa4QoyxhZd/GU+ot4MeiA0wCQMT45X8kNGahc+we0+TtaSb2HL+J5CL42s= =wdxK -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/5253e972.8030...@serverb.co.uk
Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
Tue, 01 Oct 2013 22:47:03 +0100 Daniel Lintott dan...@serverb.co.uk kirjoitti: Hi Juhani, I honestly wasn't aware that version of Debian exited, till you told me! I have setup a virtual machine to test the software under kFreeBSD, to ensure there are no obvious bugs... At the moment I have found a bug and have contacted the upstream author for advice, but thought I'd ask here as well in case you know the answer. At line 163 [1] hv.c calls openpty. This works fine on my main computer, but under the kFreeBSD VM it fails with the following error: Create pseudo-terminal: No child processes I can confirm this. While trying to reproduce the bug, I found something rather strange (affecting Linux and GNU/kFreeBSD): the code wants the user to call it by the full name of the binary.[1] # This one doesn’t work vpcs -H 23456 # This works $(which vpcs) -H 23456 # or /usr/bin/vpcs -H 23456 Not sure if this is a bug to report, as I can see upstream is already working with this in their repository. Any ideas what the problem may be? No, I’m not an actual user or a porter of kFreeBSD. :) Best regards, -- Juhani Numminen https://github.com/dlintott/vpcs/blob/master/src/hv.c#L133 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20131002215930.0a4f81f3@deadfish.hostile
Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Juhani, Juhani Numminen juhaninummin...@gmail.com wrote: I can confirm this. While trying to reproduce the bug, I found something rather strange (affecting Linux and GNU/kFreeBSD): the code wants the user to call it by the full name of the binary.[1] # This one doesn’t work vpcs -H 23456 # This works $(which vpcs) -H 23456 # or /usr/bin/vpcs -H 23456 Not sure if this is a bug to report, as I can see upstream is already working with this in their repository. Yes, I did find this bug as well, which the upstream author has now fixed. I've created the appropriate patch so it will be fixed in the next upload Regards, Daniel Lintott -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSTIFOAAoJEMw/9yOWzAkJzRYH/1b7q3PjciEcJQLQ5uL5gpJ0 rDPGXgAOwxpkW1DxKINif9B7+uGN+70Yr6aEYh1jUUi6HwDuXxxMRvgMNNo5iCzn oeu72dvp7F2USZGp7KuHQ/K42UctV7zidxpgAJBSnQryHJgrRRM3/a6ybBp52vNW SA2/qLH4YHdLFVDukWFdV7Z3vmqgVygbGrUWyqPDzW+5fNZ0dwyIVIGrVirxp4eO CF17bLpBi6XknFgaTFcZjgDy0FywjNyyVUbnwVE6LboLde7wg+os+v+lgSpkDu1R cRSHd2l2ZLyfOjvnlki6/+3D0YlwQe4ns2XBa0NiFYxq2FInZ5PXlIxnpjj2Yuk= =Ov+y -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/524c8152.5010...@serverb.co.uk
Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Juhani, I honestly wasn't aware that version of Debian exited, till you told me! I have setup a virtual machine to test the software under kFreeBSD, to ensure there are no obvious bugs... At the moment I have found a bug and have contacted the upstream author for advice, but thought I'd ask here as well in case you know the answer. At line 163 [1] hv.c calls openpty. This works fine on my main computer, but under the kFreeBSD VM it fails with the following error: Create pseudo-terminal: No child processes Any ideas what the problem may be? Regards, Daniel Lintott [1] https://github.com/dlintott/vpcs/blob/master/src/hv.c#L163 On 28/09/13 09:40, Juhani Numminen wrote: Fri, 27 Sep 2013 12:52:38 +0100 Daniel Lintott dan...@serverb.co.uk kirjoitti: I managed to my own question in the end regarding DESTDIR, thanks to the following post on the list http://lists.debian.org/debian-mentors/2011/03/msg00127.html That’s good. I still see problems with the assumptions the build system has about the operating system. The source itself also needs patching if that platform is wanted to be supported. Here are my changes to build on kfreebsd: * In d/rules, detect GNU/kFreeBSD and define macros GNUkFreeBSD and FreeBSD. * Add a patch to adjust a few lines if GNUkFreeBSD is defined. I’ll attach a patch that can be applied to the git repository, so you can see the actual modifications. Cheers, Juhani Numminen -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSS0LXAAoJEMw/9yOWzAkJu5wH/3mdN6RPjMKG1SN2L/4ci727 wLyoea6nBTuZl2HsX/qexy+/6Cl8bjOIHDrGPBv44aITo1JCMR7taI0UkjN+ByRJ Ci8h3jKYcrmGiU+KfOeVuwdVKRoXKzwHD4K35vKRUNqknbPzHZEuBOrZUxmP2RJ/ ly8zsuH/DOVqzO87y2xSVmbPLkWRjSCz5oTLYyHCTuQWKvosaThH6CDS+07i7XdK vtEBjhKyQO4JV9zEMbWJzyWgYFgOfyKyp9Vkn9HCYAP33gTVXPZNLLhNPTWJeagc uHyu1RNQ59JZWAgIMn0/taRTKeeLK2krgvRWoXbUisfh8ZjX9/LQb9/lmtuxSao= =SNWC -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/524b42d7.6050...@serverb.co.uk
Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA512
Fri, 27 Sep 2013 12:52:38 +0100
Daniel Lintott dan...@serverb.co.uk kirjoitti:
I managed to my own question in the end regarding DESTDIR, thanks to
the following post on the list
http://lists.debian.org/debian-mentors/2011/03/msg00127.html
That’s good.
I still see problems with the assumptions the build system
has about the operating system. The source itself also
needs patching if that platform is wanted to be supported.
Here are my changes to build on kfreebsd:
* In d/rules, detect GNU/kFreeBSD and define macros GNUkFreeBSD and
FreeBSD.
* Add a patch to adjust a few lines if GNUkFreeBSD is defined.
I’ll attach a patch that can be applied to the git repository, so you
can see the actual modifications.
Cheers,
Juhani Numminen
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.20 (GNU/Linux)
iQEcBAEBCgAGBQJSRpX3AAoJEICGa2KP4xPG1q0IAMIWbk0N8nSrDrZNxYJSXC7E
WzmeVQ2daLUPWTuCUZT0gNM8xWfGP/XHYJUwfvBzz+GhcPAGAfaPWC/7cLM9c9Ek
OE2z3VmZjRghqQLFQ+RiVXRuV/+9bNEHpkoluFUmlPcABos3Qbh9oWk/BDyYAPBS
d5O8DANeO8lIrwEF5KjhO1V6k7+zTjkgymbvDLgq6ZhQVDTIbii2H95T/6BGJKK6
guH/GZsy0b1DRm+3fZkzL+2GvVau8gPlVUiduUGIpP0bsd7d+HpOuzZ3y8Sz299X
0kWy0KazojjGWUZi6ogVPrlMRmIvyHITWL1HznmzjYhIn8o55SNhgqpo+zr5//g=
=utuP
-END PGP SIGNATURE-
From d9a793696c9bb9595335fc3349b716188356e4ce Mon Sep 17 00:00:00 2001
From: Juhani Numminen juhaninummin...@gmail.com
Date: Sat, 28 Sep 2013 14:25:21 +0300
Subject: [PATCH] Build on Debian GNU/kFreeBSD
---
debian/patches/BuildOnGNUkFreeBSD | 34 ++
debian/patches/series | 1 +
debian/rules | 4
3 files changed, 39 insertions(+)
create mode 100644 debian/patches/BuildOnGNUkFreeBSD
diff --git a/debian/patches/BuildOnGNUkFreeBSD b/debian/patches/BuildOnGNUkFreeBSD
new file mode 100644
index 000..9d62d9e
--- /dev/null
+++ b/debian/patches/BuildOnGNUkFreeBSD
@@ -0,0 +1,34 @@
+Description: Build also on GNU/kfreeBSD
+Author: Juhani Numminen juhaninummin...@gmail.com
+
+--- vpcs-0.5b0.orig/src/daemon.c
vpcs-0.5b0/src/daemon.c
+@@ -51,7 +51,7 @@
+
+ #ifdef Darwin
+ #include util.h
+-#elif Linux
++#elif Linux || GNUkFreeBSD
+ #include pty.h
+ #elif FreeBSD
+ #include libutil.h
+--- vpcs-0.5b0.orig/src/hv.c
vpcs-0.5b0/src/hv.c
+@@ -55,7 +55,7 @@
+
+ #ifdef Darwin
+ #include util.h
+-#elif Linux
++#elif Linux || GNUkFreeBSD
+ #include pty.h
+ #elif FreeBSD
+ #include libutil.h
+@@ -389,7 +389,7 @@ run_vpcs(int ac, char **av)
+
+ /* reinitialized, maybe call getopt twice */
+ optind = 1;
+-#if (defined(FreeBSD) || defined(Darwin))
++#if ((!defined(GNUkFreeBSD) defined(FreeBSD)) || defined(Darwin))
+ optreset = 1;
+ #endif
+ while ((c = getopt(ac, av, p:m:s:c:)) != -1) {
diff --git a/debian/patches/series b/debian/patches/series
index 19d3446..d54252f 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
ManpageFix
LinuxMakefilePatch
CreateTopLevelMakefile
+BuildOnGNUkFreeBSD
diff --git a/debian/rules b/debian/rules
index 6645f38..6676cb0 100755
--- a/debian/rules
+++ b/debian/rules
@@ -5,7 +5,11 @@
# To enable all, uncomment following line
export DEB_BUILD_MAINT_OPTIONS = hardening=+all
+ifeq ($(DEB_HOST_ARCH_OS),kfreebsd)
+export DEB_CFLAGS_MAINT_APPEND = -DGNUkFreeBSD -DFreeBSD -Wall -I. -DHV -Wno-strict-aliasing
+else
export DEB_CFLAGS_MAINT_APPEND = -DLinux -Wall -I. -DTAP -DHV -Wno-strict-aliasing
+endif
export DEB_LDFLAGS_MAINT_APPEND = -lpthread -lutil -s
%:
--
1.8.4.rc3
Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 I managed to my own question in the end regarding DESTDIR, thanks to the following post on the list http://lists.debian.org/debian-mentors/2011/03/msg00127.html So I have updated the vpcs package on mentors, to use this new information. I have also fixed the items pointed out to me by Juhani. As usual the package is on: http://mentors.debian.net/package/vpcs Alternatively, one can download the package with dget using this command: dget -x http://mentors.debian.net/debian/pool/main/v/vpcs/vpcs_0.5b0-1.dsc Regards Daniel Lintott On 26/09/13 21:34, Daniel Lintott wrote: On 26/09/13 19:19, Juhani Numminen wrote: Hello, Daniel, Here’s my review of vpcs 0.5b0-1. I’m not a DD, so I can’t upload. Because this package hasn’t been in Debian, the d/changelog entries should merged. Okay, I shall merge the two entries. Your d/rules isn’t a ”sample debian/rules” anymore and those comment can be removed. Also, the ”commands to install the package into debian/vpcs/usr” have been already added as far as I can see :) Oddly, I thought about removing the comments... But didn't, I shall remove them for the next upload. With regards to the DESTDIR, I'm hitting a stumbling block. It got me thinking that I shouldn't need to manually override dh_auto_install, so have removed that. pbuilder calls make with DESTDIR=/tmp/buildd/vpcs-0.5b0/debian/vpcs, which wipes out the current DESTDIR?=/usr or DESTDIR+=/usr Is it then okay to change the install lines of the Makefile to include the /usr directory? Example: install vpcs$(BIN_EXT) $(DESTDIR)/usr/bin/ In d/control: this is a minor thing, Build-Depends: debhelper (= 9.0.0) could also be ( 9). Will be changed in the next upload. Have you sent your patches to upstream consideration? At least you should probably send the ManpageFix. I have sent the patches from the previous version upstream. The manpage was patched, but when it was edited new errors were introduced. The two makefile patches, are more difficult to integrate upstream as the author builds using BSD-Make as opposed to GNU-Make. Regards, Daniel Lintott -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSRXGGAAoJEMw/9yOWzAkJeeUH+gP1H0znB+PHJ/f9lcFwNEmj Xppe7LqkHBCh5Grz+xPFCyqMWFYi3iDWw5rnru4htzSxjk64i1v49HkGzVzZ86UJ OuY2G6tZew5UIhI3NfnxZFT6nPNu4hjyOyGPMT+E2vy3fLTDXuEikU0Uhyw5jE6f rdHtH8z9G8JJHCeNHC4moKBzEhfP/zTt7q6gs3jBGbwQuExuolRIkrvBx6NbqbqR harWRET7Cud6ITqx541LiYGz9teIrjvejPIx1h633IttCj9a30dKkHw4/cPr4J4j kPGnCAhTVrtt3Dvu1vpKXrjoxFXkL2vKT6hyXxlkhvMHSukOrSycOSqbl9bFvIE= =8dyq -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52457186.8030...@serverb.co.uk
Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
Hello, Daniel, Here’s my review of vpcs 0.5b0-1. I’m not a DD, so I can’t upload. Because this package hasn’t been in Debian, the d/changelog entries should merged. Your d/rules isn’t a ”sample debian/rules” anymore and those comment can be removed. Also, the ”commands to install the package into debian/vpcs/usr” have been already added as far as I can see :) In d/control: this is a minor thing, Build-Depends: debhelper (= 9.0.0) could also be ( 9). Have you sent your patches to upstream consideration? At least you should probably send the ManpageFix. Best regards, -- Juhani Numminen -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/20130926211925.749db453@deadfish.hostile
Bug#721080: RFS: vpcs/0.5b0-1 [ITP]
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 26/09/13 19:19, Juhani Numminen wrote: Hello, Daniel, Here’s my review of vpcs 0.5b0-1. I’m not a DD, so I can’t upload. Because this package hasn’t been in Debian, the d/changelog entries should merged. Okay, I shall merge the two entries. Your d/rules isn’t a ”sample debian/rules” anymore and those comment can be removed. Also, the ”commands to install the package into debian/vpcs/usr” have been already added as far as I can see :) Oddly, I thought about removing the comments... But didn't, I shall remove them for the next upload. With regards to the DESTDIR, I'm hitting a stumbling block. It got me thinking that I shouldn't need to manually override dh_auto_install, so have removed that. pbuilder calls make with DESTDIR=/tmp/buildd/vpcs-0.5b0/debian/vpcs, which wipes out the current DESTDIR?=/usr or DESTDIR+=/usr Is it then okay to change the install lines of the Makefile to include the /usr directory? Example: install vpcs$(BIN_EXT) $(DESTDIR)/usr/bin/ In d/control: this is a minor thing, Build-Depends: debhelper (= 9.0.0) could also be ( 9). Will be changed in the next upload. Have you sent your patches to upstream consideration? At least you should probably send the ManpageFix. I have sent the patches from the previous version upstream. The manpage was patched, but when it was edited new errors were introduced. The two makefile patches, are more difficult to integrate upstream as the author builds using BSD-Make as opposed to GNU-Make. Regards, Daniel Lintott -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with undefined - http://www.enigmail.net/ iQEcBAEBAgAGBQJSRJpvAAoJEMw/9yOWzAkJCJAH/iCKJbhddXj7NOmdvhIOLgDV zMIgF86LHmkPuxPqdD/khSrrxeX28uRHXO0tqpZRUiv9JVLqnl6O+n8z8C62y45q nq3h41UWPckRKeHWFDO5H8u4amZJKPMNpERgWYJkPKdhq4IhP3nrIZpjEdNyKlO5 ptKZLJMT62/NBoSIAW8ZF7jVW/DEgFZkvaAMIykrIR3F4JvCYHLNU9RVyx2tcgBJ ehH0pJPHf+1hQ2TmcDRMckjckWmR+/YmLVuUmXpEEieGQ5Fnu10t0v+WKBwQ+teX jYKK2I8G/v3tXt/9TAsM/xn0oyJC7k/ucKfcm4TSIU0OonGI4T5JnNiCABqEsio= =DSzt -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: http://lists.debian.org/52449a70.1080...@serverb.co.uk
