Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Gianfranco Costamagna]

control: tags -1 moreinfo
>https://mentors.debian.net/package/lsvpd



can you please remove moreinfo once the package enters unstable?


thanks

G.


> the same for libvpd applies here
> 
> "License: GPL-2+ with librtas exception"
> 
> maybe something like
> License: GPL-2+-with-librtas-exception
> 
> is better (check lintian if complains)

Fixed and lintian doesn't complain.
Also, as for libvpd, I added all autoconf files and others.
I checked with license-reconcile and I think I forgot nobody.

> abort-upgrade|abort-remove|abort-deconfigure)
> ;;
> 
> useless ^^

done

> apt-get install -t experimental check-all-the-things:

pity, I just realize, this is really a command ..

> check-all-the-things
> 
> 
> $ codespell --quiet-level=3
> 
> 
> $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or 
> open any of the paths given.'
> 
> 
> # Parsing /proc/cpuinfo is not portable at all, use /sys instead.
> $ grep -rF /proc/cpuinfo .
> 
> 
> 
> package outdated

... updated.
I also trimmed d/rules.

Remaining lintians :
P: lsvpd source: debian-watch-may-check-gpg-signature
I: lsvpd: hardening-no-fortify-functions usr/sbin/lscfg

For the latter CPPFLAGS is given to the compiler :
$ dpkg-buildflags --get CPPFLAGS
-Wdate-time -D_FORTIFY_SOURCE=2

g++ -DHAVE_CONFIG_H -I. -I./config  -I./src/include -Wall -fstack-protector-all
-Wstack-protector -Wdate-time -D_FORTIFY_SOURCE=2 -DDEST_DIR='"/usr"'
-DVPD_VERSION='"1.7.7"' -g -O2 -fPIE -fstack-protector-strong -Wformat
-Werror=format-security -c -o src/output/lsvpd.o src/output/lsvpd.cpp$


F.

> other stuff LGTM
> 
> G.
> 
> 
> Il Giovedì 2 Giugno 2016 18:00, Frederic Bonnard  
> ha scritto:
> 
> 
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "lsvpd"
> 
> Package name: lsvpd
> Version : 1.7.6-1
> Upstream Author : lsvpd team
> URL : http://sourceforge.net/projects/linux-diag/files/lsvpd/
> License : GPL-2+
> Section : misc
> 
> It builds those binary packages:
> 
>   lsvpd - Utility to List Device Vital Product Data (VPD)
> 
> To access further information about this package, please visit the following 
> URL:
> 
> https://mentors.debian.net/package/lsvpd
> 
> 
> Alternatively, one can download the package with dget using this command:
> 
>   dget -x 
> https://mentors.debian.net/debian/pool/main/l/lsvpd/lsvpd_1.7.6-1.dsc
> 
> More information about lsvpd can be obtained from 
> http://sourceforge.net/projects/linux-diag/files/lsvpd/ 
> 
> Note:
>   This is for Power architectures.
>   I initially packaged this for Ubuntu Trusty. I pulled it from Ubuntu did a 
> few
>   changes and here it is. It would need to be synced with Ubuntu.
> 
> 
> Regards,
> Frederic Bonnard
> 

Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Frederic Bonnard]

Hi,

new packaging uploaded : 
https://mentors.debian.net/package/lsvpd
https://mentors.debian.net/debian/pool/main/l/lsvpd/lsvpd_1.7.7-1.dsc

> the same for libvpd applies here
> 
> "License: GPL-2+ with librtas exception"
> 
> maybe something like
> License: GPL-2+-with-librtas-exception
> 
> is better (check lintian if complains)

Fixed and lintian doesn't complain.
Also, as for libvpd, I added all autoconf files and others.
I checked with license-reconcile and I think I forgot nobody.

> abort-upgrade|abort-remove|abort-deconfigure)
> ;;
> 
> useless ^^

done

> apt-get install -t experimental check-all-the-things:

pity, I just realize, this is really a command ..

> check-all-the-things
> 
> 
> $ codespell --quiet-level=3
> 
> 
> $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or 
> open any of the paths given.'
> 
> 
> # Parsing /proc/cpuinfo is not portable at all, use /sys instead.
> $ grep -rF /proc/cpuinfo .
> 
> 
> 
> package outdated

... updated.
I also trimmed d/rules.

Remaining lintians :
P: lsvpd source: debian-watch-may-check-gpg-signature
I: lsvpd: hardening-no-fortify-functions usr/sbin/lscfg

For the latter CPPFLAGS is given to the compiler :
$ dpkg-buildflags --get CPPFLAGS
-Wdate-time -D_FORTIFY_SOURCE=2

g++ -DHAVE_CONFIG_H -I. -I./config  -I./src/include -Wall -fstack-protector-all
-Wstack-protector -Wdate-time -D_FORTIFY_SOURCE=2 -DDEST_DIR='"/usr"'
-DVPD_VERSION='"1.7.7"' -g -O2 -fPIE -fstack-protector-strong -Wformat
-Werror=format-security -c -o src/output/lsvpd.o src/output/lsvpd.cpp$

F.

> other stuff LGTM
> 
> G.
> 
> 
> Il Giovedì 2 Giugno 2016 18:00, Frederic Bonnard  
> ha scritto:
> 
> 
> Package: sponsorship-requests
> Severity: normal
> 
> Dear mentors,
> 
> I am looking for a sponsor for my package "lsvpd"
> 
> Package name: lsvpd
> Version : 1.7.6-1
> Upstream Author : lsvpd team
> URL : http://sourceforge.net/projects/linux-diag/files/lsvpd/
> License : GPL-2+
> Section : misc
> 
> It builds those binary packages:
> 
>   lsvpd - Utility to List Device Vital Product Data (VPD)
> 
> To access further information about this package, please visit the following 
> URL:
> 
> https://mentors.debian.net/package/lsvpd
> 
> 
> Alternatively, one can download the package with dget using this command:
> 
>   dget -x 
> https://mentors.debian.net/debian/pool/main/l/lsvpd/lsvpd_1.7.6-1.dsc
> 
> More information about lsvpd can be obtained from 
> http://sourceforge.net/projects/linux-diag/files/lsvpd/ 
> 
> Note:
>   This is for Power architectures.
>   I initially packaged this for Ubuntu Trusty. I pulled it from Ubuntu did a 
> few
>   changes and here it is. It would need to be synced with Ubuntu.
> 
> 
> Regards,
> Frederic Bonnard
> 

Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Gianfranco Costamagna]

Hi

>Spaces are not allowed in license names. But here the license name is 

>just “GPL-2+”.
>
>Let me quote the relevant part of the spec:
>“An exception or clarification to a license is signalled in plain text, 
>by appending ‘with  exception’ to the short name.”


probably when I tried
a) this wasn't implemented
b) I made some typo that triggered lintian warning.

Happy to see this works correctly, so to the sponsoree, nevermind this part :)

Thanks Jakub!

Gianfranco

Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Jakub Wilk]

* Gianfranco Costamagna , 2016-06-02, 17:07:

"License: GPL-2+ with librtas exception"

maybe something like
License: GPL-2+-with-librtas-exception


"FOO with BAR exception" is a valid licence syntax in DEP-5.
If it is not appropriate to use it in this case, then you should 
explain why, because it's not obvious.


the difference is just removing the spaces, IIRC lintian was triggering 
issues on dep-5 format when spaces were used.


Spaces are not allowed in license names. But here the license name is 
just “GPL-2+”.


Let me quote the relevant part of the spec:
“An exception or clarification to a license is signalled in plain text, 
by appending ‘with  exception’ to the short name.”


--
Jakub Wilk

mail formatting (was: Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD))

[gregor herrmann]

On Thu, 02 Jun 2016 17:07:08 +, Gianfranco Costamagna wrote:

> [I didn't read rest of thi>s mail because it made my head hurt. 
> >Gianfranco, please write complete sentences, and please don't top-post.]

> yes, sorry :)
> (I have a bad MUA, sometimes top-posting is necessary :( )

No, it's not.
Please get a sane MUA or wait with your replies until you have access
to one.

I really appreciate the work you do on mentoring but I basically
stopped reading your mails months ago because they make my head
explode.


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Tanita Tikaram: Happy Taxi


signature.asc
Description: Digital Signature


signature.asc
Description: Digital Signature

Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Gianfranco Costamagna]

Hi,



>The same... what? I can't parse this sentence.


the same review done for the other packages applies to this one
(yes, indeed I should have written it better, I explained it somewhere else)

>"FOO with BAR exception" is a valid licence syntax in DEP-5.>If it is not 
>appropriate to use it in this case, then you should explain 
>why, because it's not obvious.



>"License: GPL-2+ with librtas exception"
>
>maybe something like
>License: GPL-2+-with-librtas-exception

the difference is just removing the spaces, IIRC lintian was triggering issues
on dep-5 format when spaces were used.
Isn't it the case anymore?

[I didn't read rest of thi>s mail because it made my head hurt. 
>Gianfranco, please write complete sentences, and please don't top-post.]


yes, sorry :)
(I have a bad MUA, sometimes top-posting is necessary :( )


G.

Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Jakub Wilk]

* Gianfranco Costamagna , 2016-06-02, 16:19:

the same for libvpd applies here


The same... what? I can't parse this sentence.


"License: GPL-2+ with librtas exception"

maybe something like
License: GPL-2+-with-librtas-exception


"FOO with BAR exception" is a valid licence syntax in DEP-5.
If it is not appropriate to use it in this case, then you should explain 
why, because it's not obvious.


[I didn't read rest of this mail because it made my head hurt. 
Gianfranco, please write complete sentences, and please don't top-post.]


--
Jakub Wilk

Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo

the same for libvpd applies here

"License: GPL-2+ with librtas exception"

maybe something like
License: GPL-2+-with-librtas-exception

is better (check lintian if complains)

abort-upgrade|abort-remove|abort-deconfigure)
;;


useless ^^

apt-get install -t experimental check-all-the-things:

check-all-the-things


$ codespell --quiet-level=3


$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open 
any of the paths given.'


# Parsing /proc/cpuinfo is not portable at all, use /sys instead.
$ grep -rF /proc/cpuinfo .



package outdated

other stuff LGTM

G.


Il Giovedì 2 Giugno 2016 18:00, Frederic Bonnard  ha 
scritto:


Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "lsvpd"

Package name: lsvpd
Version : 1.7.6-1
Upstream Author : lsvpd team
URL : http://sourceforge.net/projects/linux-diag/files/lsvpd/
License : GPL-2+
Section : misc

It builds those binary packages:

  lsvpd - Utility to List Device Vital Product Data (VPD)

To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/lsvpd


Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/l/lsvpd/lsvpd_1.7.6-1.dsc

More information about lsvpd can be obtained from 
http://sourceforge.net/projects/linux-diag/files/lsvpd/ 

Note:
  This is for Power architectures.
  I initially packaged this for Ubuntu Trusty. I pulled it from Ubuntu did a few
  changes and here it is. It would need to be synced with Ubuntu.


Regards,
Frederic Bonnard

Bug#826135: RFS: lsvpd/1.7.6-1 ITP: lsvpd -- Utility to List Device Vital Product Data (VPD)

[Frederic Bonnard]

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "lsvpd"

 Package name: lsvpd
 Version : 1.7.6-1
 Upstream Author : lsvpd team
 URL : http://sourceforge.net/projects/linux-diag/files/lsvpd/
 License : GPL-2+
 Section : misc

It builds those binary packages:

  lsvpd - Utility to List Device Vital Product Data (VPD)

To access further information about this package, please visit the following 
URL:

https://mentors.debian.net/package/lsvpd


Alternatively, one can download the package with dget using this command:

  dget -x https://mentors.debian.net/debian/pool/main/l/lsvpd/lsvpd_1.7.6-1.dsc

More information about lsvpd can be obtained from 
http://sourceforge.net/projects/linux-diag/files/lsvpd/ 

Note:
  This is for Power architectures.
  I initially packaged this for Ubuntu Trusty. I pulled it from Ubuntu did a few
  changes and here it is. It would need to be synced with Ubuntu.


Regards,
 Frederic Bonnard