Bug#841017: RFS: openbox/3.5.2-8+deb8u1

2016-10-23 Thread Mateusz Łukasik 

On 17.10.2016 01:45 +0200, Adam Borowski wrote:


A stable update.

Reading the bug report for #838326, I don't quite understand why the
severity is so high.  But hey, as the maintainer you probably know better
and it's not me but the SRMs you need to persuade.

The rules for stable updates have changed: the devref still claims one needs
"a truly critical functionality problem" while the SRMs have since relaxed
that to "severity:important, but really it depends".  As this bug claims to
be "important", we may give it a try.

However, you are required to ask the SRMs first.  The proper procedure is
described in developers-reference 5.5.1.  All you're missing is an ok from
the release team: please file a bug on "release.debian.org", we need them to
allow the upload.  Please attach a debdiff between 3.5.2-8 and
3.5.2-8+deb8u1 to that bug.

But here we have an issue: there's already a bug report on
release.debian.org asking for a stable update, even with the same version
(3.5.2-8+deb8u1): #840378.  It's a NMU from Salvatore Bonaccorso fixing a
different problem.  That bug is 6 days old, hasn't been responded to yet.
You guys need to coordinate...


Meow!



Apologise for waiting. I have no time.

Debdiff is attached.

Also I add NMU from Salvatore Bonaccorso. I don't see his changes before.

Mateusz
diff -Nru openbox-3.5.2/debian/changelog openbox-3.5.2/debian/changelog
--- openbox-3.5.2/debian/changelog  2014-10-25 14:39:18.0 +0200
+++ openbox-3.5.2/debian/changelog  2016-10-23 18:36:47.0 +0200
@@ -1,3 +1,17 @@
+openbox (3.5.2-8+deb8u1) jessie; urgency=medium
+
+  [ Mateusz Łukasik ]
+  * debian/control:
++  Add libxcursor-dev to B-D for fix load startup notifications.
+(Closes: #838326)
+
+  [ Salvatore Bonaccorso ]
+  * Add 808138_Replace-getgrent-with-getgroups.patch patch.
+Replace getgrent with getgroups for not enumerate all groups at startup.
+Thanks to Simon  (Closes: #808138)
+
+ -- Mateusz Łukasik   Sun, 23 Oct 2016 18:36:47 +0200
+
 openbox (3.5.2-8) unstable; urgency=high
 
   * debian/openbox.install:
diff -Nru openbox-3.5.2/debian/control openbox-3.5.2/debian/control
--- openbox-3.5.2/debian/control2014-09-23 11:08:38.0 +0200
+++ openbox-3.5.2/debian/control2016-10-15 13:59:38.0 +0200
@@ -6,7 +6,7 @@
  libxrender-dev, pkg-config, libglib2.0-dev, libxml2-dev (>= 2.6.0), perl, 
  libxt-dev, libxinerama-dev, libxrandr-dev, libpango1.0-dev, libx11-dev, 
  autoconf, automake (>= 1:1.11), python-xdg, libimlib2-dev, dh-autoreconf, 
- autopoint, librsvg2-dev, libxi-dev
+ autopoint, librsvg2-dev, libxi-dev, libxcursor-dev
 Standards-Version: 3.9.6
 Homepage: http://www.openbox.org
 Vcs-Browser: https://github.com/mati75/openbox-debian
diff -Nru 
openbox-3.5.2/debian/patches/808138_Replace-getgrent-with-getgroups.patch 
openbox-3.5.2/debian/patches/808138_Replace-getgrent-with-getgroups.patch
--- openbox-3.5.2/debian/patches/808138_Replace-getgrent-with-getgroups.patch   
1970-01-01 01:00:00.0 +0100
+++ openbox-3.5.2/debian/patches/808138_Replace-getgrent-with-getgroups.patch   
2016-10-23 18:36:04.0 +0200
@@ -0,0 +1,63 @@
+>From e0cb404f53c9b21a521ea2f14c8cd66fdfb68ea7 Mon Sep 17 00:00:00 2001
+From: Simon 
+Date: Tue, 15 Dec 2015 15:46:18 +0100
+Subject: [PATCH] Replace getgrent with getgroups. Fixes #5978.
+
+---
+ obt/paths.c | 34 +-
+ 1 file changed, 21 insertions(+), 13 deletions(-)
+
+diff --git a/obt/paths.c b/obt/paths.c
+index 25cb6b0..d526936 100644
+--- a/obt/paths.c
 b/obt/paths.c
+@@ -108,25 +108,33 @@ static void find_uid_gid(uid_t *u, gid_t **g, guint *n)
+ const gchar *name;
+ struct group *gr;
+ 
++gid_t gmain;
++unsigned int maininc;
++int i;
++
+ *u = getuid();
+ pw = getpwuid(*u);
+ name = pw->pw_name;
+ 
+-*g = g_new(gid_t, *n=1);
+-(*g)[0] = getgid();
+-
+-while ((gr = getgrent())) {
+-if (gr->gr_gid != (*g)[0]) { /* skip the main group */
+-gchar **c;
+-for (c = gr->gr_mem; *c; ++c)
+-if (strcmp(*c, name) == 0) {
+-*g = g_renew(gid_t, *g, ++(*n)); /* save the group */
+-(*g)[*n-1] = gr->gr_gid;
+-break;
+-}
++gmain = getgid();
++
++*n = getgroups(0, *g);
++*g = g_new(gid_t, *n);
++*n = getgroups(*n, *g);
++
++/* Check if the effective group ID of the calling process is already
++   included in the returned list. Add it otherwise. */
++maininc = 0;
++for (i = 0; i < *n; i++) {
++if ( (*g)[i] == gmain ) {
++maininc = 1;
++break;
+ }
+ }
+-endgrent();
++if (!maininc) {
++*g = g_renew(gid_t, *g, ++(*n));
++(*g)[*n-1] = gmain;
++}
+ 
+ qsort(*g, *n, sizeof(gid_t), gid_cmp);
+ }
+-- 
+2.1.4
+
diff -Nru

Bug#841017: RFS: openbox/3.5.2-8+deb8u1

2016-10-16 Thread Adam Borowski 
Control: tags -1 +moreinfo

On Sun, Oct 16, 2016 at 11:21:10PM +0200, Mateusz Łukasik wrote:
> Package: sponsorship-requests
> Severity: normal [important for RC bugs, wishlist for new packages]
> 
>  * Package name: openbox
>Version : 3.5.2-8+deb8u1

> * debian/control:
> +  Add libxcursor-dev to B-D for fix load startup notifications.
> (Closes: #838326)

A stable update.

Reading the bug report for #838326, I don't quite understand why the
severity is so high.  But hey, as the maintainer you probably know better
and it's not me but the SRMs you need to persuade.

The rules for stable updates have changed: the devref still claims one needs
"a truly critical functionality problem" while the SRMs have since relaxed
that to "severity:important, but really it depends".  As this bug claims to
be "important", we may give it a try.

However, you are required to ask the SRMs first.  The proper procedure is
described in developers-reference 5.5.1.  All you're missing is an ok from
the release team: please file a bug on "release.debian.org", we need them to
allow the upload.  Please attach a debdiff between 3.5.2-8 and
3.5.2-8+deb8u1 to that bug.

But here we have an issue: there's already a bug report on
release.debian.org asking for a stable update, even with the same version
(3.5.2-8+deb8u1): #840378.  It's a NMU from Salvatore Bonaccorso fixing a
different problem.  That bug is 6 days old, hasn't been responded to yet.
You guys need to coordinate...


Meow!
-- 
A MAP07 (Dead Simple) raspberry tincture recipe: 0.5l 95% alcohol, 1kg
raspberries, 0.4kg sugar; put into a big jar for 1 month.  Filter out and
throw away the fruits (can dump them into a cake, etc), let the drink age
at least 3-6 months.

Bug#841017: RFS: openbox/3.5.2-8+deb8u1

2016-10-16 Thread Mateusz Łukasik 

Package: sponsorship-requests
Severity: normal [important for RC bugs, wishlist for new packages]

  Dear mentors,

  I am looking for a sponsor for my package "openbox"

 * Package name: openbox
   Version : 3.5.2-8+deb8u1
   Upstream Author : Dana Jansens 
 * URL : openbox.org
 * License : GPL-2+
   Section : x11

  It builds those binary packages:

gnome-panel-control - command line utility to invoke GNOME panel 
run dialog/menu

 libobrender29 - rendering library for openbox themes
 libobt2- parsing library for openbox
 openbox- standards-compliant, fast, light-weight and extensible 
window man

 openbox-dev - development files for the openbox window manager
 openbox-gnome-session - command line utility to run Openbox as GNOME 
session
 openbox-kde-session - command line utility to run Openbox as KDE SC 
session


  To access further information about this package, please visit the 
following URL:


  https://mentors.debian.net/package/openbox


  Alternatively, one can download the package with dget using this command:

dget -x 
https://mentors.debian.net/debian/pool/main/o/openbox/openbox_3.5.2-8+deb8u1.dsc


  Changes since the last upload:

* debian/control:
+  Add libxcursor-dev to B-D for fix load startup notifications.
(Closes: #838326)


  Regards,
   Mateusz Łukasik