Re: RFS: sl-modem (updated package)
On Mon, Jan 26, 2009 at 09:04:42PM -0600, Raphael Geissert wrote: أحمد المحمودي wrote: I think that it is fine too, because that package actually builds another package (if module-assistant is used), or just builds some module files (if DKMS is used). Have you read the tag's description? it is not as to what the package does. You mean the long description ? I fixed it uploaded. I fixed uploaded, except for one patch (04_sregs_init.diff). That was introduced by previous maintainer. And I don't know what it does. Then that's your homework :) Thanks for the push ! I found out that it is an obsolete patch ! Previous maintainer had to remove it since 2.9.9e-pre1a. (I had to dig into snapshot.debian.net to find out). Again, please advise me about the use of usermod in the postinst. Looks fine, but I have one question: why did you disable the version check? Was trying something, and forgot to uncomment it back ! Sorry ! Anyways, it is fixed now in the current upload. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net) GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: sl-modem (updated package)
أحمد المحمودي wrote:
On Mon, Jan 26, 2009 at 09:04:42PM -0600, Raphael Geissert wrote:
Have you read the tag's description? it is not as to what the package does.
You mean the long description ? I fixed it uploaded.
No, I mean this:
$ lintian-info -t debhelper-but-no-misc-depends
N: debhelper-but-no-misc-depends
N:
N: The source package uses debhelper but it does not use ${misc:Depends}
N: in the given binary package's debian/control entry. This is required
N: so the dependencies are set correctly in case the result of a call to
N: any of the dh_ commands cause the package to depend on another
N: package.
N:
N: Refer to the debhelper(7) manual page for details.
N:
N: Severity: normal; Certainty: certain
N:
I fixed uploaded, except for one patch (04_sregs_init.diff). That was
introduced by previous maintainer. And I don't know what it does.
Then that's your homework :)
Thanks for the push ! I found out that it is an obsolete patch !
Previous maintainer had to remove it since 2.9.9e-pre1a. (I had to dig
into snapshot.debian.net to find out).
Good
Cheers,
--
Raphael Geissert - Debian Maintainer
www.debian.org - get.debian.net
--
To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: sl-modem (updated package)
The package appears to be lintian clean. Not really: $ lintian --pedantic -IE --show-overrides sl-modem*dsc W: sl-modem source: debhelper-but-no-misc-depends sl-modem-source I: sl-modem source: quilt-patch-missing-description modem_group.diff I: sl-modem source: quilt-patch-missing-description 02_dial_string_size.diff I: sl-modem source: quilt-patch-missing-description 03_Makefile_2.6.12.4.diff I: sl-modem source: quilt-patch-missing-description 04_sregs_init.diff I: sl-modem source: quilt-patch-missing-description 05_st7554_license.diff I: sl-modem source: quilt-patch-missing-description 06_slmodem-class-simple-to-class-meins.diff I: sl-modem source: quilt-patch-missing-description 08_ungrab_winmodem.diff I: sl-modem source: quilt-patch-missing-description 10_drop_privileges.diff I: sl-modem source: quilt-patch-missing-description 11_logfile.diff I: sl-modem source: quilt-patch-missing-description kernel-ver.diff I: sl-modem source: quilt-patch-missing-description README.diff I: sl-modem source: quilt-patch-missing-description debug_level.diff I: sl-modem source: quilt-patch-missing-description fortify_source.diff I: sl-modem source: quilt-patch-missing-description class_device.diff Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: sl-modem (updated package)
On Mon, 26 Jan 2009 13:08:53 -0600 Raphael Geissert atomo64+deb...@gmail.com wrote: The package appears to be lintian clean. Not really: $ lintian --pedantic -IE --show-overrides sl-modem*dsc W: sl-modem source: debhelper-but-no-misc-depends sl-modem-source That one is fine, but I'm concerned with your use of --pedantic. I: sl-modem source: quilt-patch-missing-description modem_group.diff Is that the result of --pedantic or just normal lintian? Raphael - are you saying that full compliance with the very new --pedantic option to lintian is now part of your sponsoring requirements? I'm not looking at this package in particular, but IMHO --pedantic needs quite a lot of care in handling - Russ admits that pedantic has less certainty than ordinary lintian checks with more room for false positives and false negatives. http://www.eyrie.org/~eagle/journal/2009-01/019.html People should only use --pendantic if they're willing to see tags that are inaccurate or don't fit their personal style and take them with a grain of salt. It might be worth qualifying your use of --pedantic as your own preference. Do you filter some of the messages from --pedantic? I know you wanted --pedantic and worked on the implementation, but --pedantic does have problems and the results of using --pedantic are, IMHO, highly unreliable and in need of filtering one a package-by-package basis. FTR, I won't be using --pedantic *unless* it reveals a particular issue that I would like to have fixed anyway, i.e. where lintian provides some help on how to fix the issue. -- Neil Williams = http://www.data-freedom.org/ http://www.linux.codehelp.co.uk/ http://e-mail.is-not-s.ms/ pgpIyIJjTBQLC.pgp Description: PGP signature
Re: RFS: sl-modem (updated package)
On Mon, Jan 26, 2009 at 07:41:08PM +, Neil Williams wrote: On Mon, 26 Jan 2009 13:08:53 -0600 Raphael Geissert atomo64+deb...@gmail.com wrote: The package appears to be lintian clean. Not really: $ lintian --pedantic -IE --show-overrides sl-modem*dsc W: sl-modem source: debhelper-but-no-misc-depends sl-modem-source That one is fine, but I'm concerned with your use of --pedantic. Sorry that I said that the package is lintian clean, I used the template that was in mentors.debian.net (seems that there is an old version of lintian there), and I totally forgot about this warning. I think that it is fine too, because that package actually builds another package (if module-assistant is used), or just builds some module files (if DKMS is used). I: sl-modem source: quilt-patch-missing-description modem_group.diff Is that the result of --pedantic or just normal lintian? Pedantic messages are prefixed with P: I fixed uploaded, except for one patch (04_sregs_init.diff). That was introduced by previous maintainer. And I don't know what it does. Again, please advise me about the use of usermod in the postinst. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net) GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: sl-modem (updated package)
Hi Dne Mon, 26 Jan 2009 19:41:08 + Neil Williams codeh...@debian.org napsal(a): On Mon, 26 Jan 2009 13:08:53 -0600 Raphael Geissert atomo64+deb...@gmail.com wrote: The package appears to be lintian clean. Not really: $ lintian --pedantic -IE --show-overrides sl-modem*dsc W: sl-modem source: debhelper-but-no-misc-depends sl-modem-source That one is fine, but I'm concerned with your use of --pedantic. I: sl-modem source: quilt-patch-missing-description modem_group.diff Is that the result of --pedantic or just normal lintian? That's result of -I and it exists for quite a long time. Pedantic tags start with P:. Raphael - are you saying that full compliance with the very new --pedantic option to lintian is now part of your sponsoring requirements? I can not speak for Raphael, but I also use --pedantic when checking packages to sponsor, but more like a pointers what to check than like real errors. -- Michal Čihař | http://cihar.com | http://blog.cihar.com signature.asc Description: PGP signature
Re: RFS: sl-modem (updated package)
Hi Neil, Neil Williams wrote: On Mon, 26 Jan 2009 13:08:53 -0600 Raphael Geissert atomo64+deb...@gmail.com wrote: The package appears to be lintian clean. Not really: $ lintian --pedantic -IE --show-overrides sl-modem*dsc W: sl-modem source: debhelper-but-no-misc-depends sl-modem-source That one is fine, but I'm concerned with your use of --pedantic. I: sl-modem source: quilt-patch-missing-description modem_group.diff Is that the result of --pedantic or just normal lintian? Michal already explained that pedantic tags are P, not I. In this case just demonstrates that the package is --pedantic clean as of lintian 2.0.0, nothing else. Raphael - are you saying that full compliance with the very new --pedantic option to lintian is now part of your sponsoring requirements? I'm not, yet, a DD so I still can't sponsor. But compliance with pedantic will be, at some extent, a requirement, yes. But please keep on reading before you comment on this. I'm not looking at this package in particular, but IMHO --pedantic needs quite a lot of care in handling - Russ admits that pedantic has less certainty than ordinary lintian checks with more room for false positives and false negatives. Those statements are true but also false, depends on the interpretations of each word. They are less certain or more likely to be false positives in the sense that for example no-upstream-changelog may be emitted even for multi bin packages, or even when upstream doesn't provide a changelog at all. http://www.eyrie.org/~eagle/journal/2009-01/019.html People should only use --pendantic if they're willing to see tags that are inaccurate or don't fit their personal style and take them with a grain of salt. Sure. It might be worth qualifying your use of --pedantic as your own preference. Do you filter some of the messages from --pedantic? Keep reading. I know you wanted --pedantic and worked on the implementation, but --pedantic does have problems and the results of using --pedantic are, IMHO, highly unreliable and in need of filtering one a package-by-package basis. FTR, I won't be using --pedantic *unless* it reveals a particular issue that I would like to have fixed anyway, i.e. where lintian provides some help on how to fix the issue. I plan to require an explanation to why the cause of the tag being emitted is not fixed/changed as suggested. There are currently only three tags: no-upstream-changelog no-homepage-field direct-changes-in-diff-but-no-patch-system As you can see the first two fit in the maintainer missed it or its upstream's problem case, while the last one is up to the maintainer, and would be happy if a good and strong explanation is provided as to not use a patch system nowadays. The following check requests have been considered to be implemented as pedantic: 497344, 497346, 474590, 409124, 127494, 236232, 339829, 119045, 483845, 42936. Note that some are indeed questionable but are a good start point for discussing the results with the maintainer, they are no necessarily meant to be just fix it because it's The Right Thing tags. At least that's my POV, others may of course differ. Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Re: RFS: sl-modem (updated package)
أحمد المحمودي wrote: On Mon, Jan 26, 2009 at 07:41:08PM +, Neil Williams wrote: On Mon, 26 Jan 2009 13:08:53 -0600 Raphael Geissert atomo64+deb...@gmail.com wrote: The package appears to be lintian clean. Not really: $ lintian --pedantic -IE --show-overrides sl-modem*dsc W: sl-modem source: debhelper-but-no-misc-depends sl-modem-source That one is fine, but I'm concerned with your use of --pedantic. Sorry that I said that the package is lintian clean, I used the template that was in mentors.debian.net (seems that there is an old version of lintian there), and I totally forgot about this warning. mentors.d.n is not perfect, and you should get used to running lintian on your own :). I think that it is fine too, because that package actually builds another package (if module-assistant is used), or just builds some module files (if DKMS is used). Have you read the tag's description? it is not as to what the package does. I: sl-modem source: quilt-patch-missing-description modem_group.diff Is that the result of --pedantic or just normal lintian? Pedantic messages are prefixed with P: I fixed uploaded, except for one patch (04_sregs_init.diff). That was introduced by previous maintainer. And I don't know what it does. Then that's your homework :) Again, please advise me about the use of usermod in the postinst. Looks fine, but I have one question: why did you disable the version check? Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
RFS: sl-modem (updated package)
Dear mentors, I am looking for a sponsor for the new version 2.9.11~20080817-2 of my package sl-modem. It builds these binary packages: sl-modem-daemon - SmartLink software modem daemon sl-modem-source - SmartLink software modem driver - module building source The package appears to be lintian clean. The upload would fix these bugs: 421867, 507340, 512332 I need advice with using usermod though (used to fix 507340). Also, I have added DKMS support. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/non-free/s/sl-modem - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/non-free/s/sl-modem/sl-modem_2.9.11~20080817-2.dsc I would be glad if someone uploaded this package for me. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net) GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27 -- To UNSUBSCRIBE, email to debian-mentors-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
RFS: sl-modem (updated package)
Dear mentors, I am looking for a sponsor for the new version 2.9.11~20080817-2 of my package sl-modem. It builds these binary packages: sl-modem-daemon - SmartLink software modem daemon sl-modem-source - SmartLink software modem driver - module building source The package appears to be lintian clean. The upload would fix these bugs: 507340 I need help with that fix though, to fix the problem for those upgrading sl-modem-daemon, I added this line to postinst: usermod --home /var/log/slmodemd Slmodemd now, when I install the package (even for the first time), this usermod gives a Seg fault. yet dpkg does continue installing it. The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/non-free/s/sl-modem - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/non-free/s/sl-modem/sl-modem_2.9.11~20080817-2.dsc I would be glad if someone uploaded this package for me. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer SySDSoft, Inc. GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net) GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
RFS: sl-modem (updated package)
Dear mentors, I am looking for a sponsor for the new version 2.9.11~20080817-1 of my package sl-modem. It builds these binary packages: sl-modem-daemon - SmartLink software modem daemon sl-modem-source - SmartLink software modem driver - module building source The package appears to be lintian clean. The upload would fix these bugs: 354908, 457637, 471888, 489289 The package can be found on mentors.debian.net: - URL: http://mentors.debian.net/debian/pool/non-free/s/sl-modem - Source repository: deb-src http://mentors.debian.net/debian unstable main contrib non-free - dget http://mentors.debian.net/debian/pool/non-free/s/sl-modem/sl-modem_2.9.11~20080817-1.dsc I would be glad if someone uploaded this package for me. -- أحمد المحمودي (Ahmed El-Mahmoudy) Digital design engineer SySDSoft, Inc. GPG KeyID: 0x9DCA0B27 (@ subkeys.pgp.net) GPG Fingerprint: 087D 3767 8CAC 65B1 8F6C 156E D325 C3C8 9DCA 0B27 -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
