Re: Bug#800406: RFS sayonara/0.8.2

[Ross Gammon]

Hi Lucio,

On 09/19/2016 11:13 PM, Lucio Carreras wrote:
> Hi Ross,
> 
> Maybe you remember, I currently see no chance to go on preparing
> Sayonara player for the Debian repositories. I simply don't have enough
> time. The distribution mechanism for Debian is complicated and when I
> find time again after a few weeks I have to start from the very
> beginning again. It's very time consuming and I cannot imagine how to
> handle this in the future. I'll go on uploading the program to the ppa
> and offer the source code on my website. Maybe there will be someone in
> the future who wants to take care of this task.
> 
> I have a lot of respect for all of you how to manage this all beside
> your jobs.

No problems. We all know how you feel sometimes - especially when
starting out. If I ever get a spare moment, I will take a look and see
if I can finish the package off and get it sponsored myself.

Once it is in the Debian archive, it is quite easy to maintain from that
point, as the workflow begins to stick in the brain. So I hope you will
keep an eye on the package in Debian, and re-consider later on.

Keep up the good work on the package upstream!

Ross



signature.asc
Description: OpenPGP digital signature

Re: Bug#800406: RFS sayonara/0.8.2

[Lucio Carreras]

Hi Ross,

Maybe you remember, I currently see no chance to go on preparing 
Sayonara player for the Debian repositories. I simply don't have enough 
time. The distribution mechanism for Debian is complicated and when I 
find time again after a few weeks I have to start from the very 
beginning again. It's very time consuming and I cannot imagine how to 
handle this in the future. I'll go on uploading the program to the ppa 
and offer the source code on my website. Maybe there will be someone in 
the future who wants to take care of this task.


I have a lot of respect for all of you how to manage this all beside 
your jobs.


Greetings,

Lucio


On 05/22/2016 10:03 AM, Ross Gammon wrote:

Hi Lucio,

On 05/13/2016 04:05 PM, Ross Gammon wrote:

Sorry - I was a bit busy this week. If Gianfranco says we are mostly
done, then it is probably time to join the pkg-multimedia team! Please
follow this page to join:
https://wiki.debian.org/DebianMultimedia/Join

Once I see saynora pushed to the alioth git repository, I will build,
install and have a play. If all looks good, it is probably time to
update the RFS bug to let Gianfranco know that we think it is ready for
sponsorship.

Now we have sayonara inside the Debian Multimedia repository, I think
there are only a few small things to tidy up:

1. Debian tag: Unfortunately when you import a .dsc, a Debian tag is
created against the debian (master) branch. This tag should reflect the
state of the repository when the package is uploaded. As sayonara has
not been uploaded yet, we should delete this tag (no-one else will have
pulled it yet, so no danger).
$ git push --delete origin debian/0.9.0-1
$ git tag -d debian/0.9.0-1
According to https://wiki.debian.org/DebianMultimedia/DevelopPackaging,
after upload the sponsor should tag the repository (sometimes it is
forgotten, so keep an eye out for that).

2. Maintainer: Also according to
https://wiki.debian.org/DebianMultimedia/DevelopPackaging, the
maintainer should be the Team, and interested team members (e.g. you)
should be "Uploader". Please update debian/control.

3. Package Short Description: This should start with "small" rather than
"Small" and does not need the full stop at the end (debian/control).
See:
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-desc-basics

4. Package Long Description: This looks like a list "It holds a lot of
features like .". It would be better if each new line in the list
started with "* ". Alternatively, it could be a standard paragraph with
lots of commas (e.g. It holds a lot of features like many supported
music and playlist formats, directory view, ). I think I prefer the
list.

5. Now that sayonara is in the Debian Multimedia Team repository, we
need Vcs fields in debian/control:
Vcs-Git: https://anonscm.debian.org/git/pkg-multimedia/sayonara.git
Vcs-Browser: https://anonscm.debian.org/cgit/pkg-multimedia/sayonara.git
This way, people can follow links from the package tracker to inspect
the repository, or find out how to clone it.

The package is still building here, and I would like to install it and
have a little play. Assuming nothing goes wrong with that, with the
above changes I think it is ready to ask a sponsor to take a look at it.

Regards,

Ross

Re: Bug#800406: RFS sayonara/0.8.2

[Niels Thykier]

Ross Gammon:
> On 05/22/2016 10:03 AM, Ross Gammon wrote:
>> The package is still building here,
> 
> [...]
> I: sayonara: hardening-no-pie usr/bin/sayonara
> I: sayonara: hardening-no-bindnow usr/bin/sayonara
> I: sayonara: hardening-no-bindnow usr/lib/sayonara/libsayonara_somafm.so
> I: sayonara: hardening-no-bindnow usr/lib/sayonara/libsayonara_soundcloud.so
> 
> Assuming the build system supports it, we should be able to enable these
> hardening options. See: https://wiki.debian.org/Hardening
> 

Hi,

Please be careful with the "+pie" since the package is building both
shared libs and executables.  Depending on the upstream build system's
it may "just work" or "break horribly".

See also:
 * https://lintian.debian.org/tags/hardening-no-pie.html
 * https://lists.debian.org/debian-devel/2016/05/msg00297.html

Thanks,
~Niels




signature.asc
Description: OpenPGP digital signature

Re: Bug#800406: RFS sayonara/0.8.2

[Ross Gammon]

On 05/22/2016 10:03 AM, Ross Gammon wrote:
> The package is still building here,

OK- Lintian has some complaints:
+++ lintian output +++
P: sayonara source: debian-watch-may-check-gpg-signature

As you are "upstream" this could probably be fixed, but can be left for
the sometine in the future.

I: sayonara: hardening-no-pie usr/bin/sayonara
I: sayonara: hardening-no-bindnow usr/bin/sayonara
I: sayonara: hardening-no-bindnow usr/lib/sayonara/libsayonara_somafm.so
I: sayonara: hardening-no-bindnow usr/lib/sayonara/libsayonara_soundcloud.so

Assuming the build system supports it, we should be able to enable these
hardening options. See: https://wiki.debian.org/Hardening

P: sayonara: no-upstream-changelog

You have an upstream changelog in the resources directory. This could be
installed by overriding dh_install_changelogs. You can always do an
internet search, or use https://codesearch.debian.net/ to find examples
of how it is done.

I: sayonara: description-synopsis-might-not-be-phrased-properly

Hopefully my suggestions in the last email make this go away.

W: sayonara: command-in-menu-file-and-desktop-file sayonara
usr/share/menu/sayonara:6

See:
https://lintian.debian.org/tags/command-in-menu-file-and-desktop-file.html

E: sayonara: postinst-does-not-call-updatemenus usr/share/menu/sayonara

This MUST be fixed before upload, as I think is will cause an automatic
rejection of the package? See:
https://lintian.debian.org/tags/postinst-does-not-call-updatemenus.html
Probably fixing the previous warning will make this go away.

 and I would like to install it and
> have a little play. Assuming nothing goes wrong with that, with the
> above changes I think it is ready to ask a sponsor to take a look at it.

This test will have to wait now as I must be somewhere else for a few hours.

Cheers,

Ross



signature.asc
Description: OpenPGP digital signature

Re: Bug#800406: RFS sayonara/0.8.2

[Ross Gammon]

Hi Lucio,

On 05/13/2016 04:05 PM, Ross Gammon wrote:
> 
> Sorry - I was a bit busy this week. If Gianfranco says we are mostly
> done, then it is probably time to join the pkg-multimedia team! Please
> follow this page to join:
> https://wiki.debian.org/DebianMultimedia/Join
> 
> Once I see saynora pushed to the alioth git repository, I will build,
> install and have a play. If all looks good, it is probably time to
> update the RFS bug to let Gianfranco know that we think it is ready for
> sponsorship.

Now we have sayonara inside the Debian Multimedia repository, I think
there are only a few small things to tidy up:

1. Debian tag: Unfortunately when you import a .dsc, a Debian tag is
created against the debian (master) branch. This tag should reflect the
state of the repository when the package is uploaded. As sayonara has
not been uploaded yet, we should delete this tag (no-one else will have
pulled it yet, so no danger).
$ git push --delete origin debian/0.9.0-1
$ git tag -d debian/0.9.0-1
According to https://wiki.debian.org/DebianMultimedia/DevelopPackaging,
after upload the sponsor should tag the repository (sometimes it is
forgotten, so keep an eye out for that).

2. Maintainer: Also according to
https://wiki.debian.org/DebianMultimedia/DevelopPackaging, the
maintainer should be the Team, and interested team members (e.g. you)
should be "Uploader". Please update debian/control.

3. Package Short Description: This should start with "small" rather than
"Small" and does not need the full stop at the end (debian/control).
See:
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-desc-basics

4. Package Long Description: This looks like a list "It holds a lot of
features like .". It would be better if each new line in the list
started with "* ". Alternatively, it could be a standard paragraph with
lots of commas (e.g. It holds a lot of features like many supported
music and playlist formats, directory view, ). I think I prefer the
list.

5. Now that sayonara is in the Debian Multimedia Team repository, we
need Vcs fields in debian/control:
Vcs-Git: https://anonscm.debian.org/git/pkg-multimedia/sayonara.git
Vcs-Browser: https://anonscm.debian.org/cgit/pkg-multimedia/sayonara.git
This way, people can follow links from the package tracker to inspect
the repository, or find out how to clone it.

The package is still building here, and I would like to install it and
have a little play. Assuming nothing goes wrong with that, with the
above changes I think it is ready to ask a sponsor to take a look at it.

Regards,

Ross



signature.asc
Description: OpenPGP digital signature

Re: Bug#800406: RFS sayonara/0.8.2

[Ross Gammon]

Hi Lucio,

On 05/11/2016 12:28 PM, Gianfranco Costamagna wrote:
>> >So the next step will be to join the multimedia-team?
> 
> please join it now, and put VCS fields under your package.
> (and ask me to create the repository if you want one)
> 
> I see some packages under pkg-multimedia umbrella have no VCS repository, so 
> I guess
> you can avoid that, because you seem to already be upstream

Sorry - I was a bit busy this week. If Gianfranco says we are mostly
done, then it is probably time to join the pkg-multimedia team! Please
follow this page to join:
https://wiki.debian.org/DebianMultimedia/Join

Once I see saynora pushed to the alioth git repository, I will build,
install and have a play. If all looks good, it is probably time to
update the RFS bug to let Gianfranco know that we think it is ready for
sponsorship.

Regards,

Ross




signature.asc
Description: OpenPGP digital signature

Re: Bug#800406: RFS sayonara/0.8.2

[Gianfranco Costamagna]

Hi,


>license.txt
>  * Removed license.txt
>  As some other distributions strictly want this file, I wanted to ask 
>if I may remove that file with a debian patch?


no you shouln't ever remove that file.
this is source of reject from ftpmasters.

You don't have to install it with make install,
so if you want to install it for other linux distros,
please override dh_auto_install and remove it

for sure in the source tarball it should be there

>Are there some further details I should check?


I think we are mostly good

>I have a question referring to the version numbering and bugfixes:
>At the moment I am used to fix bugs applying to all distributions in 
>upstream.
>The naming scheme of the version number currently is: 
>sayonara_{VERSION}+git{DATE}-{DEBIAN_REVISION}, e.g. 
>sayonara_0.8.3+git20160508-1.
>Bugfixes won't affect the version itself, but the git{DATE} part. So the 
>watch file will indicate that a new version is available.


well, what about calling them 0.8.3.1, 0.8.3.2 and so on?

if they are upstream bugfixes it is good to tag them from time to time, having 
a date
in the version scheme usually means "we are packaging upstream snapshots"
>If there are debian-specific changes I'll use quilt and the debian 
>revision number will increase. Is that common praxis?


yes, debian specific, cherry-picks from upstream, patches needed because of new 
tools
not yet upstreamed, and so on are usually under debian/patches, and 
dropped/refactored/changed/refreshed
when a new upstream version is imported.

>So the next step will be to join the multimedia-team?


please join it now, and put VCS fields under your package.
(and ask me to create the repository if you want one)

I see some packages under pkg-multimedia umbrella have no VCS repository, so I 
guess
you can avoid that, because you seem to already be upstream

cheers,

Gianfranco


On 05/04/2016 07:50 PM, Ross Gammon wrote:
> Hi Lucio,
>
> On 05/04/2016 11:25 AM, Lucio Carreras wrote:
>> Hello Gianfranco, hello Ross,
>>
>> unfortunately, the last message went to my spam folder so I just saw it
>> today. Gianfranco, thank you for having a look at the package. I will
>> correct those errors. But you are right, there are some some packaging
>> problems anyway.
> I had wondered... You are welcome to ask here on the mentors list if any
> of the packaging problems are proving difficult to fix. Don't be
> embarrassed - we have all asked stupid questions here, and learnt from
> other peoples questions. Glad it was the Spam folder and not the too
> hard basket :-)
>
 gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked up by 
 shibs:Depends?
>> Those libraries are loaded on runtime. The program will start without
>> them, but it won't work as intended. They are not available because the
>> build process does not depend on them.
> OK. Looked strange to me too once Gianfranco mentioned it (especially
> the sqlite library), but seems reasonable.
>
 please just call dh_auto_configure and patch the build system to 
 automatically take care of the flags.

 I think all the rules hacks can be dropped.
>> There was a reason for including these rules. But I'll try to get rid of
>> them.
>>
>> And thank you Ross for supporting the package. I guess, I'll need your
>> help from time to time.
> Sure. Once the package is almost ready for upload, I recommend joining
> the Debian Multimedia Team and maintaining the package there (in their
> git repository). I would be happy to co-maintain it with you. I will be
> hoping that you get so good at it that you won't need much help after a
> while :-)
>
> Cheers,
>
> Ross
>

Re: Bug#800406: RFS sayonara/0.8.2

[Lucio Carreras]

Hi Ross,

I carefully read through your instructions and uploaded the package to 
https://mentors.debian.net/package/sayonara


Additionally, I made changes in:

debian/control:
 * called wrap-and-sort
 * reduced dependencies to a minimum (the runtime dependencies have to 
stay the way they are, otherwise the database cannot be opened)
 * increased the standards-version to 3.9.8 (as it was proposed by the 
lintian output at the mentors page)


debian/watch:
 * Updated the watch file

debian/rules
 * Changed the build environment, so the debian/rules file is reduced 
to a minimum, too


debian/source/format
 * Changed to 3.0 (quilt)

Source code:
 * Added copyright header and owner to all source files
 * Removed spell errors due to the output of spellcheck --quiet-level=3 
(only for languages I am used to)

 * Removed shell scripts
 * Had a look at the files where flawfinder found potential errors
 * Checked for (/home, /opt, /srv) references

license.txt
 * Removed license.txt
 As some other distributions strictly want this file, I wanted to ask 
if I may remove that file with a debian patch?


Are there some further details I should check?

I have a question referring to the version numbering and bugfixes:
At the moment I am used to fix bugs applying to all distributions in 
upstream.
The naming scheme of the version number currently is: 
sayonara_{VERSION}+git{DATE}-{DEBIAN_REVISION}, e.g. 
sayonara_0.8.3+git20160508-1.
Bugfixes won't affect the version itself, but the git{DATE} part. So the 
watch file will indicate that a new version is available.


If there are debian-specific changes I'll use quilt and the debian 
revision number will increase. Is that common praxis?


So the next step will be to join the multimedia-team?

Greetings and have a nice Sunday,

Lucio


On 05/04/2016 07:50 PM, Ross Gammon wrote:

Hi Lucio,

On 05/04/2016 11:25 AM, Lucio Carreras wrote:

Hello Gianfranco, hello Ross,

unfortunately, the last message went to my spam folder so I just saw it
today. Gianfranco, thank you for having a look at the package. I will
correct those errors. But you are right, there are some some packaging
problems anyway.

I had wondered... You are welcome to ask here on the mentors list if any
of the packaging problems are proving difficult to fix. Don't be
embarrassed - we have all asked stupid questions here, and learnt from
other peoples questions. Glad it was the Spam folder and not the too
hard basket :-)


gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked up by 
shibs:Depends?

Those libraries are loaded on runtime. The program will start without
them, but it won't work as intended. They are not available because the
build process does not depend on them.

OK. Looked strange to me too once Gianfranco mentioned it (especially
the sqlite library), but seems reasonable.


please just call dh_auto_configure and patch the build system to automatically 
take care of the flags.

I think all the rules hacks can be dropped.

There was a reason for including these rules. But I'll try to get rid of
them.

And thank you Ross for supporting the package. I guess, I'll need your
help from time to time.

Sure. Once the package is almost ready for upload, I recommend joining
the Debian Multimedia Team and maintaining the package there (in their
git repository). I would be happy to co-maintain it with you. I will be
hoping that you get so good at it that you won't need much help after a
while :-)

Cheers,

Ross

Re: Bug#800406: RFS sayonara/0.8.2

[Gianfranco Costamagna]

Hi Lucio,


>Those libraries are loaded on runtime. The program will start without them, 
>but it won't work as intended. They are not available because the build 
>process does not depend on them. 


wonderful.

But you might drop many libraries from build-depends
qt5-default, qttools5-dev, qttools5-dev-tools, libqt5sql5-sqlite,


stuff such as
libqt5core5a, libqt5dbus5, libqt5network5, libqt5sql5, libqt5xml5 gets picked up
by the development libraries, avoding to have SONAME issues on transitions.


let me know if you have questions about the issues, leaving Ross to help you 
now :)

btw wrap-and-sort please :)
(you just need to run the command)
and between Description: and the start there should be a space
(I downloaded the package from the ppa, not sure if the git is different)


Gianfranco

2016-04-05 21:50 GMT+02:00 Gianfranco Costamagna 
:

control: owner -1 !
>control: tags -1 moreinfo
>
>
>Hi, lets review:
>(thanks Ross for the nice feedback, I'm adding something more on top of your 
>work)
>
>no orig tarball, please upload to mentors or push tags
>please run wrap-and-sort
>std version is 3.9.7
>libqt5core5a, libqt5dbus5, libqt5network5, libqt5sql5, ... <-- WRONG
>you need the development packages, not the libraries
>
>gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked
>up by shibs:Depends?
>
>license.txt <-- useless please remove
>debian/md5sum <-- useless and autogenerated, I think you need to better
>know how to create a clean upload.
>
>"mkdir -p build && cd build && cmake .. -DCMAKE_CXX_FLAGS="$(CXX_FLAGS)" 
>-DCMAKE_EXE_LINKER_FLAGS="$(LDFLAGS)" -DCMAKE_SHARED_LINKER_FLAGS="${LDFLAGS}" 
>-DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=RelWithDebInfo"
>please just call dh_auto_configure and patch the build system to automatically 
>take care of the flags.
>
>I think all the rules hacks can be dropped.
>
>many copyrights are missing
>./src/Components/DBus/resources/org.libmtp.mtpd.object.xml: Copyright (C) 2013 
>Philipp Schmidt 
>./src/Components/DBus/resources/org.libmtp.mtpd.folder.xml: Copyright (C) 2013 
>Philip Langdale 
>./src/Components/DBus/resources/org.libmtp.mtpd.folder.xml: Copyright (C) 2013 
>Philipp Schmidt 
>
>
>just to give a few examples
>
>./src/GUI/Player/SearchSlider.h: * Copyright (C) 2012
>./src/GUI/Player/SearchSlider.cpp: * Copyright (C) 2012
>
>
>copyright and there is no person owning it? (many other places have similar 
>issues)
>
>licenses seems good
>
>check-all-the-things
>$ codespell --quiet-level=3
>$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or 
>open any of the paths given.'
>$ find -type f \( -iname '*.sh' -o -iname '*.bash' -o -iname '*.zsh' \) -exec 
>shellcheck {} +
>$ flawfinder -Q -c .
>$ grep -Er '/(home|srv|opt)(\W|$)' .
>
>
>I didn't check lintian and to run the package, but a lot of work seems needed 
>there.
>
>cheers,
>
>Gianfranco
>
>
>
>
>
>
>Il Lunedì 22 Febbraio 2016 11:20, Lucio Carreras  ha 
>scritto:
>
>
>
>Hi Ross,
>
>> I have cloned your git repo to do the review, but in the future, I
>recommend that you sign up for an account on Debian Mentors, and upload your 
>package there.
>
>Done. I already uploaded the package, but there are some minor lintian issues 
>with the package type (native/not native) and the source/format type.
>But it was late yesterday and I will proceed today evening. 
>http://mentors.debian.net/package/sayonara When everything is alright I will 
>give a shout.
>
>>  I was a bit surprised to so much stuff in debian/rules,
>Yes, but I want to assure that the build runs out-of-tree. So one step leads 
>to the other. But in my opinion it's pretty clear what's going on.
>Nevertheless, there were some inaccuracies in the build file.
>
>I also revised the other files you mentioned in the debian directory.
>
>
>> I recommend joining the Debian Multimedia Team eventually. Then the
>Vcs fields can be finalised (surrently commented out). But lets improve
>the packaging a little bit more first.
>
>
>Yes, with pleasure. You will hear from me later.
>
>
>Thank you,
>
>Lucio
>
>
>
>
>
>2016-02-21 17:21 GMT+01:00 Ross Gammon :
>
>Hi Lucio,
>>
>>Sorry I did not spot this email after talking you into contacting Debian
>>Mentors :-)
>>
>>I am not a Debian Developer, so I cannot sponsor the package, but I will
>>write some comments inline below that will hopefully help you on your way.
>>
>>On 02/15/2016 11:30 AM, Lucio Carreras wrote:
>>> Dear Debian mentors,
>>>
>>> I am looking for a sponsor for the package "sayonara".
>>>
>>> * Package name: sayonara
>>> * Version: 0.8.2
>>> * Author: Lucio Carreras >> >
>>> * Url: http://www.sayonara-player.com
>>> * License: GPL3
>>> * Section: audio
>>>
>>> Sayonara is a clear and fast audio player with its main focus on
>>> managing your music library. 

Re: Bug#800406: RFS sayonara/0.8.2

[Ross Gammon]

Hi Lucio,

On 05/04/2016 11:25 AM, Lucio Carreras wrote:
> Hello Gianfranco, hello Ross,
> 
> unfortunately, the last message went to my spam folder so I just saw it
> today. Gianfranco, thank you for having a look at the package. I will
> correct those errors. But you are right, there are some some packaging
> problems anyway.

I had wondered... You are welcome to ask here on the mentors list if any
of the packaging problems are proving difficult to fix. Don't be
embarrassed - we have all asked stupid questions here, and learnt from
other peoples questions. Glad it was the Spam folder and not the too
hard basket :-)

> 
>>> gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked up by 
>>> shibs:Depends?
> 
> Those libraries are loaded on runtime. The program will start without
> them, but it won't work as intended. They are not available because the
> build process does not depend on them.

OK. Looked strange to me too once Gianfranco mentioned it (especially
the sqlite library), but seems reasonable.

> 
>>>please just call dh_auto_configure and patch the build system to 
>>>automatically take care of the flags.
>>>
>>>I think all the rules hacks can be dropped.
> There was a reason for including these rules. But I'll try to get rid of
> them.
> 
> And thank you Ross for supporting the package. I guess, I'll need your
> help from time to time.

Sure. Once the package is almost ready for upload, I recommend joining
the Debian Multimedia Team and maintaining the package there (in their
git repository). I would be happy to co-maintain it with you. I will be
hoping that you get so good at it that you won't need much help after a
while :-)

Cheers,

Ross



signature.asc
Description: OpenPGP digital signature

Re: Bug#800406: RFS sayonara/0.8.2

[Lucio Carreras]

Hello Gianfranco, hello Ross,

unfortunately, the last message went to my spam folder so I just saw it
today. Gianfranco, thank you for having a look at the package. I will
correct those errors. But you are right, there are some some packaging
problems anyway.

>> gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked up
by shibs:Depends?

Those libraries are loaded on runtime. The program will start without them,
but it won't work as intended. They are not available because the build
process does not depend on them.

>>please just call dh_auto_configure and patch the build system to
automatically take care of the flags.
>>
>>I think all the rules hacks can be dropped.
There was a reason for including these rules. But I'll try to get rid of
them.

And thank you Ross for supporting the package. I guess, I'll need your help
from time to time.

Greetings,
Lucio

2016-04-05 21:50 GMT+02:00 Gianfranco Costamagna <
costamagnagianfra...@yahoo.it>:

> control: owner -1 !
> control: tags -1 moreinfo
>
>
> Hi, lets review:
> (thanks Ross for the nice feedback, I'm adding something more on top of
> your work)
>
> no orig tarball, please upload to mentors or push tags
> please run wrap-and-sort
> std version is 3.9.7
> libqt5core5a, libqt5dbus5, libqt5network5, libqt5sql5, ... <-- WRONG
> you need the development packages, not the libraries
>
> gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked
> up by shibs:Depends?
>
> license.txt <-- useless please remove
> debian/md5sum <-- useless and autogenerated, I think you need to better
> know how to create a clean upload.
>
> "mkdir -p build && cd build && cmake .. -DCMAKE_CXX_FLAGS="$(CXX_FLAGS)"
> -DCMAKE_EXE_LINKER_FLAGS="$(LDFLAGS)"
> -DCMAKE_SHARED_LINKER_FLAGS="${LDFLAGS}" -DCMAKE_INSTALL_PREFIX=/usr
> -DCMAKE_BUILD_TYPE=RelWithDebInfo"
> please just call dh_auto_configure and patch the build system to
> automatically take care of the flags.
>
> I think all the rules hacks can be dropped.
>
> many copyrights are missing
> ./src/Components/DBus/resources/org.libmtp.mtpd.object.xml: Copyright (C)
> 2013 Philipp Schmidt 
> ./src/Components/DBus/resources/org.libmtp.mtpd.folder.xml: Copyright (C)
> 2013 Philip Langdale 
> ./src/Components/DBus/resources/org.libmtp.mtpd.folder.xml: Copyright (C)
> 2013 Philipp Schmidt 
>
>
> just to give a few examples
>
> ./src/GUI/Player/SearchSlider.h: * Copyright (C) 2012
> ./src/GUI/Player/SearchSlider.cpp: * Copyright (C) 2012
>
>
> copyright and there is no person owning it? (many other places have
> similar issues)
>
> licenses seems good
>
> check-all-the-things
> $ codespell --quiet-level=3
> $ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or
> open any of the paths given.'
> $ find -type f \( -iname '*.sh' -o -iname '*.bash' -o -iname '*.zsh' \)
> -exec shellcheck {} +
> $ flawfinder -Q -c .
> $ grep -Er '/(home|srv|opt)(\W|$)' .
>
>
> I didn't check lintian and to run the package, but a lot of work seems
> needed there.
>
> cheers,
>
> Gianfranco
>
>
>
>
>
> Il Lunedì 22 Febbraio 2016 11:20, Lucio Carreras 
> ha scritto:
>
>
>
> Hi Ross,
>
> > I have cloned your git repo to do the review, but in the future, I
> recommend that you sign up for an account on Debian Mentors, and upload
> your package there.
>
> Done. I already uploaded the package, but there are some minor lintian
> issues with the package type (native/not native) and the source/format type.
> But it was late yesterday and I will proceed today evening.
> http://mentors.debian.net/package/sayonara When everything is alright I
> will give a shout.
>
> >  I was a bit surprised to so much stuff in debian/rules,
> Yes, but I want to assure that the build runs out-of-tree. So one step
> leads to the other. But in my opinion it's pretty clear what's going on.
> Nevertheless, there were some inaccuracies in the build file.
>
> I also revised the other files you mentioned in the debian directory.
>
>
> > I recommend joining the Debian Multimedia Team eventually. Then the
> Vcs fields can be finalised (surrently commented out). But lets improve
> the packaging a little bit more first.
>
>
> Yes, with pleasure. You will hear from me later.
>
>
> Thank you,
>
> Lucio
>
>
>
>
>
> 2016-02-21 17:21 GMT+01:00 Ross Gammon :
>
> Hi Lucio,
> >
> >Sorry I did not spot this email after talking you into contacting Debian
> >Mentors :-)
> >
> >I am not a Debian Developer, so I cannot sponsor the package, but I will
> >write some comments inline below that will hopefully help you on your way.
> >
> >On 02/15/2016 11:30 AM, Lucio Carreras wrote:
> >> Dear Debian mentors,
> >>
> >> I am looking for a sponsor for the package "sayonara".
> >>
> >> * Package name: sayonara
> >> * Version: 0.8.2
> >> * Author: Lucio Carreras  >> >
> >> * Url: http://www.sayonara-player.com
> 

Re: Bug#800406: RFS sayonara/0.8.2

[Gianfranco Costamagna]

control: owner -1 !
control: tags -1 moreinfo


Hi, lets review:
(thanks Ross for the nice feedback, I'm adding something more on top of your 
work)

no orig tarball, please upload to mentors or push tags
please run wrap-and-sort
std version is 3.9.7
libqt5core5a, libqt5dbus5, libqt5network5, libqt5sql5, ... <-- WRONG
you need the development packages, not the libraries

gstreamer1.0-plugins-ugly, libqt5sql5-sqlite < -- aren't them picked
up by shibs:Depends?

license.txt <-- useless please remove
debian/md5sum <-- useless and autogenerated, I think you need to better
know how to create a clean upload.

"mkdir -p build && cd build && cmake .. -DCMAKE_CXX_FLAGS="$(CXX_FLAGS)" 
-DCMAKE_EXE_LINKER_FLAGS="$(LDFLAGS)" -DCMAKE_SHARED_LINKER_FLAGS="${LDFLAGS}" 
-DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_BUILD_TYPE=RelWithDebInfo"
please just call dh_auto_configure and patch the build system to automatically 
take care of the flags.

I think all the rules hacks can be dropped.

many copyrights are missing
./src/Components/DBus/resources/org.libmtp.mtpd.object.xml: Copyright (C) 2013 
Philipp Schmidt 
./src/Components/DBus/resources/org.libmtp.mtpd.folder.xml: Copyright (C) 2013 
Philip Langdale 
./src/Components/DBus/resources/org.libmtp.mtpd.folder.xml: Copyright (C) 2013 
Philipp Schmidt 


just to give a few examples

./src/GUI/Player/SearchSlider.h: * Copyright (C) 2012
./src/GUI/Player/SearchSlider.cpp: * Copyright (C) 2012


copyright and there is no person owning it? (many other places have similar 
issues)

licenses seems good

check-all-the-things
$ codespell --quiet-level=3
$ cppcheck -j1 --quiet -f . | grep -vF 'cppcheck: error: could not find or open 
any of the paths given.'
$ find -type f \( -iname '*.sh' -o -iname '*.bash' -o -iname '*.zsh' \) -exec 
shellcheck {} +
$ flawfinder -Q -c .
$ grep -Er '/(home|srv|opt)(\W|$)' .


I didn't check lintian and to run the package, but a lot of work seems needed 
there.

cheers,

Gianfranco





Il Lunedì 22 Febbraio 2016 11:20, Lucio Carreras  ha 
scritto:



Hi Ross,

> I have cloned your git repo to do the review, but in the future, I
recommend that you sign up for an account on Debian Mentors, and upload your 
package there.

Done. I already uploaded the package, but there are some minor lintian issues 
with the package type (native/not native) and the source/format type. 
But it was late yesterday and I will proceed today evening. 
http://mentors.debian.net/package/sayonara When everything is alright I will 
give a shout.

>  I was a bit surprised to so much stuff in debian/rules,
Yes, but I want to assure that the build runs out-of-tree. So one step leads to 
the other. But in my opinion it's pretty clear what's going on. 
Nevertheless, there were some inaccuracies in the build file.

I also revised the other files you mentioned in the debian directory.


> I recommend joining the Debian Multimedia Team eventually. Then the
Vcs fields can be finalised (surrently commented out). But lets improve
the packaging a little bit more first.


Yes, with pleasure. You will hear from me later.


Thank you,

Lucio





2016-02-21 17:21 GMT+01:00 Ross Gammon :

Hi Lucio,
>
>Sorry I did not spot this email after talking you into contacting Debian
>Mentors :-)
>
>I am not a Debian Developer, so I cannot sponsor the package, but I will
>write some comments inline below that will hopefully help you on your way.
>
>On 02/15/2016 11:30 AM, Lucio Carreras wrote:
>> Dear Debian mentors,
>>
>> I am looking for a sponsor for the package "sayonara".
>>
>> * Package name: sayonara
>> * Version: 0.8.2
>> * Author: Lucio Carreras > >
>> * Url: http://www.sayonara-player.com
>> * License: GPL3
>> * Section: audio
>>
>> Sayonara is a clear and fast audio player with its main focus on
>> managing your music library. There are many features for library
>> organization, like a tag editor or a special genre view. It also has
>> tabbed playlists, handles webstreams and podcasts, has a stream
>> recorder, a Soundcloud plugin and much more.
>>
>>
>> There's a git repository at
>>
>> https://git.sayonara-player.com/sayonara.git
>
>I have cloned your git repo to do the review, but in the future, I
>recommend that you sign up for an account on Debian Mentors, and upload
>your package there. This has some advantages:
>1. Some sponsors are used to this workflow and prefer to take packages
>from there (at least the first time)
>2. You go through a similar process to what you will go through when you
>are eventually granted upload permisions (it is good practise for later)
>3. The web interface gives a sponsor a good indication of the health of
>the package (e.g. number of lintian warnings) without having to download it.
>
>See Section 4 of mentors.debian.net/intro-maintainers
>
>> There also exist a Ubuntu PPA
>> 

Re: Bug#800406: RFS sayonara/0.8.2

[Lucio Carreras]

Hi Ross,

> I have cloned your git repo to do the review, but in the future, I
recommend that you sign up for an account on Debian Mentors, and upload
your package there.

Done. I already uploaded the package, but there are some minor lintian
issues with the package type (native/not native) and the source/format
type. But it was late yesterday and I will proceed today evening.
http://mentors.debian.net/package/sayonara When everything is alright I
will give a shout.

> I was a bit surprised to so much stuff in debian/rules,
Yes, but I want to assure that the build runs out-of-tree. So one step
leads to the other. But in my opinion it's pretty clear what's going on.
Nevertheless, there were some inaccuracies in the build file.

I also revised the other files you mentioned in the debian directory.

> I recommend joining the Debian Multimedia Team eventually. Then the
Vcs fields can be finalised (surrently commented out). But lets improve
the packaging a little bit more first.

Yes, with pleasure. You will hear from me later.

Thank you,
Lucio



2016-02-21 17:21 GMT+01:00 Ross Gammon :

> Hi Lucio,
>
> Sorry I did not spot this email after talking you into contacting Debian
> Mentors :-)
>
> I am not a Debian Developer, so I cannot sponsor the package, but I will
> write some comments inline below that will hopefully help you on your way.
>
> On 02/15/2016 11:30 AM, Lucio Carreras wrote:
> > Dear Debian mentors,
> >
> > I am looking for a sponsor for the package "sayonara".
> >
> > * Package name: sayonara
> > * Version: 0.8.2
> > * Author: Lucio Carreras  > >
> > * Url: http://www.sayonara-player.com
> > * License: GPL3
> > * Section: audio
> >
> > Sayonara is a clear and fast audio player with its main focus on
> > managing your music library. There are many features for library
> > organization, like a tag editor or a special genre view. It also has
> > tabbed playlists, handles webstreams and podcasts, has a stream
> > recorder, a Soundcloud plugin and much more.
> >
> >
> > There's a git repository at
> >
> > https://git.sayonara-player.com/sayonara.git
>
> I have cloned your git repo to do the review, but in the future, I
> recommend that you sign up for an account on Debian Mentors, and upload
> your package there. This has some advantages:
> 1. Some sponsors are used to this workflow and prefer to take packages
> from there (at least the first time)
> 2. You go through a similar process to what you will go through when you
> are eventually granted upload permisions (it is good practise for later)
> 3. The web interface gives a sponsor a good indication of the health of
> the package (e.g. number of lintian warnings) without having to download
> it.
>
> See Section 4 of mentors.debian.net/intro-maintainers
>
> > There also exist a Ubuntu PPA
> > (https://launchpad.net/~lucioc/+archive/ubuntu/sayonara) and so there
> > also exist Debian packages (available at the download section). The
> > source code in the git repository also contains a debian directory with
> > all neccessary files. It is also tested regularly with a Debian unstable
> > chroot, if there are any warnings or errors.
>
> This is a good sign. Some more detailed comments:
>
> debian/changelog:
> - As this will be the first upload to Debian, it is best that the
> changelog has one simple entry "Initial Release (Closes: # Number>)". This will allow the bug to be automatically closed when the
> package is uploaded to the archive. See
>
> https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-changelog
> - You have set the distribution to stable. New packages should always
> target "unstable". It will automatically migrate from there to "testing"
> (if there are no problems), and then one day be released as part of the
> next stable release.
>
> debian/control
> - I recommend joining the Debian Multimedia Team eventually. Then the
> Vcs fields can be finalised (surrently commented out). But lets improve
> the packaging a little bit more first.
> - A space between "Description:" and the short description would be nice
> - The long description should probably start with "Sayonara" rather than
> "Its" because it will not be clear if read without the short description.
>
> debian/copyright
> - The "License:" stanza should be the short name of the license (e.g.
> GPL-3+).
> - Then the complete license text should be included at the bottom.
> See https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
>
> debian/rules
> - I was a bit surprised to so much stuff in debian/rules, as most of the
> time the common build systems don't need a lot more than:
> %:
> dh $@
> It might be worth looking at tweaking your cmake build system (as you
> are also upstream) so that it is not necessary to override the clean,
> build & install targets in debian/rules. This would probably benefit
> other non Debian based Linux 

Re: Bug#800406: RFS sayonara/0.8.2

[Ross Gammon]

Hi Lucio,

Sorry I did not spot this email after talking you into contacting Debian
Mentors :-)

I am not a Debian Developer, so I cannot sponsor the package, but I will
write some comments inline below that will hopefully help you on your way.

On 02/15/2016 11:30 AM, Lucio Carreras wrote:
> Dear Debian mentors,
> 
> I am looking for a sponsor for the package "sayonara".
> 
> * Package name: sayonara
> * Version: 0.8.2
> * Author: Lucio Carreras  >
> * Url: http://www.sayonara-player.com
> * License: GPL3
> * Section: audio
> 
> Sayonara is a clear and fast audio player with its main focus on
> managing your music library. There are many features for library
> organization, like a tag editor or a special genre view. It also has
> tabbed playlists, handles webstreams and podcasts, has a stream
> recorder, a Soundcloud plugin and much more.
> 
> 
> There's a git repository at
> 
> https://git.sayonara-player.com/sayonara.git

I have cloned your git repo to do the review, but in the future, I
recommend that you sign up for an account on Debian Mentors, and upload
your package there. This has some advantages:
1. Some sponsors are used to this workflow and prefer to take packages
from there (at least the first time)
2. You go through a similar process to what you will go through when you
are eventually granted upload permisions (it is good practise for later)
3. The web interface gives a sponsor a good indication of the health of
the package (e.g. number of lintian warnings) without having to download it.

See Section 4 of mentors.debian.net/intro-maintainers

> There also exist a Ubuntu PPA
> (https://launchpad.net/~lucioc/+archive/ubuntu/sayonara) and so there
> also exist Debian packages (available at the download section). The
> source code in the git repository also contains a debian directory with
> all neccessary files. It is also tested regularly with a Debian unstable
> chroot, if there are any warnings or errors.

This is a good sign. Some more detailed comments:

debian/changelog:
- As this will be the first upload to Debian, it is best that the
changelog has one simple entry "Initial Release (Closes: #)". This will allow the bug to be automatically closed when the
package is uploaded to the archive. See
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-debian-changelog
- You have set the distribution to stable. New packages should always
target "unstable". It will automatically migrate from there to "testing"
(if there are no problems), and then one day be released as part of the
next stable release.

debian/control
- I recommend joining the Debian Multimedia Team eventually. Then the
Vcs fields can be finalised (surrently commented out). But lets improve
the packaging a little bit more first.
- A space between "Description:" and the short description would be nice
- The long description should probably start with "Sayonara" rather than
"Its" because it will not be clear if read without the short description.

debian/copyright
- The "License:" stanza should be the short name of the license (e.g.
GPL-3+).
- Then the complete license text should be included at the bottom.
See https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/

debian/rules
- I was a bit surprised to so much stuff in debian/rules, as most of the
time the common build systems don't need a lot more than:
%:
dh $@
It might be worth looking at tweaking your cmake build system (as you
are also upstream) so that it is not necessary to override the clean,
build & install targets in debian/rules. This would probably benefit
other non Debian based Linux Distros as well. Probably not critical -
depending on the sponsor though.

You are missing a watch file. This file watches for new tarballs on your
website, and alerts everyone when there is a new version waiting to be
packaged. See https://wiki.debian.org/debian/watch/

debian/README.Debian? This should probably be deleted. You will find a
sponsor much faster if you promise to maintain Saynora yourself (or in a
team). :-)

debian/md5sums - I am not sure this file is needed if building the
package happens the normal way with debhelper?

debian/license.txt - a license.txt in the root of the sourcecode, and
the summarised in debian/copyright should be enough. Please remove this
file.

The package is currently building. I will let you know later if there
are problems with that.

I hope that helps you on the way. If there is something in all that
which is not clear, or you need more help to fix it, just ask on the list.

Keep up the good work, and thanks for taking an interest in getting
Sayonara into Debian proper.

Regards,

Ross



signature.asc
Description: OpenPGP digital signature