Re: Python 3 Statsmodels & Pandas

2017-09-29 Thread Diane Trout
On Fri, 2017-09-29 at 22:05 +0100, Rebecca N. Palmer wrote:
> statsmodels passed NEW...and FTBFS with
> 
> dh: unable to load addon sphinxdoc: Can't locate 
> Debian/Debhelper/Sequence/sphinxdoc.pm in @INC
> That file is in the sphinx-common package, which suggests that at
> least 
> some of the sphinx dependencies need to be Build-Depends and not
> just 
> Build-Depends-Indep.

Oops.

I thought that it wouldn't try using sphinx when not building doc
packages. But apparently being listed in "dh --with" counts as being
used.

I wonder if it's better to filter sphinxdoc out of the dh line, install
sphinx-common, or just always install python3-sphinx?

I have some ideas of what to do, I should be able to fix this soon.

> 
> Meanwhile, pandas FTBFS with several failing tests (all involving 
> datetime) on arm*/mips*el and a broken attempt to skip a test (trying
> to 
> raise nose.SkipTest without importing nose) on mips/s390x.
> 

I don't know what was wrong with pandas & datetime. I was putting off 
/ hoping someone else would log into a porterbox to try to figure out
what's actually wrong.

As for nose, python{,3}-nose is listed a build-depends ? Why
is it failing on importing nose? it should either be there or it
shouldn't be running tests?

Diane



Re: Python 3 Statsmodels & Pandas

2017-09-29 Thread Rebecca N. Palmer

statsmodels passed NEW...and FTBFS with

dh: unable to load addon sphinxdoc: Can't locate 
Debian/Debhelper/Sequence/sphinxdoc.pm in @INC


That file is in the sphinx-common package, which suggests that at least 
some of the sphinx dependencies need to be Build-Depends and not just 
Build-Depends-Indep.


Meanwhile, pandas FTBFS with several failing tests (all involving 
datetime) on arm*/mips*el and a broken attempt to skip a test (trying to 
raise nose.SkipTest without importing nose) on mips/s390x.




RE:providing sphinx3-* binaries

2017-09-29 Thread PICCA Frederic-Emmanuel
Or just use the sphinx-generated Makefile if there is one:

Except that  when there is an autodoc in the documentation, I like to build the 
doc with all {interpreters}.
It is a sort of unit test

Cheers

Fred


Re: providing sphinx3-* binaries

2017-09-29 Thread Ghislain Vaillant

On 29/09/17 12:08, PICCA Frederic-Emmanuel wrote:

override_dh_sphinxdoc:
ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))

 
nodocs or nodoc

I alsa do something like this when there is extensions.

override_dh_sphinxdoc:
ifeq (,$(findstring nodoc, $(DEB_BUILD_OPTIONS)))
PYBUILD_SYSTEM=custom \
PYBUILD_BUILD_ARGS="cd docs && PYTHONPATH={build_dir} 
http_proxy='127.0.0.1:9' {interpreter} -m sphinx -N -bhtml source build/html" dh_auto_build  
# HTML generator
dh_installdocs "docs/build/html" -p python-gpyfft-doc
dh_sphinxdoc -O--buildsystem=pybuild
endif


Or just use the sphinx-generated Makefile if there is one:

override_dh_auto_clean:
dh_auto_clean
ifeq (,$(filter nodoc, $(DEB_BUILD_OPTIONS)))
$(MAKE) -C docs clean
endif

override_dh_auto_build: export http_proxy=127.0.0.1:9
override_dh_auto_build: export https_proxy=127.0.0.1:9
override_dh_auto_build:
dh_auto_build
ifeq (,$(filter nodoc, $(DEB_BUILD_OPTIONS)))
PYTHONPATH=$(CURDIR) $(MAKE) -C docs html
endif

And you're done. The intent is also clearer.

Ghis



RE:providing sphinx3-* binaries

2017-09-29 Thread PICCA Frederic-Emmanuel
Hello guyes.

> override_dh_sphinxdoc:
> ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))

nodocs or nodoc

I alsa do something like this when there is extensions.

override_dh_sphinxdoc:
ifeq (,$(findstring nodoc, $(DEB_BUILD_OPTIONS)))
PYBUILD_SYSTEM=custom \
PYBUILD_BUILD_ARGS="cd docs && PYTHONPATH={build_dir} 
http_proxy='127.0.0.1:9' {interpreter} -m sphinx -N -bhtml source build/html" 
dh_auto_build  # HTML generator
dh_installdocs "docs/build/html" -p python-gpyfft-doc
dh_sphinxdoc -O--buildsystem=pybuild
endif

cheers

Frederic


Re: providing sphinx3-* binaries

2017-09-29 Thread Thomas Goirand
Hi Antoine,

Thanks for your post.

On 09/27/2017 12:29 AM, Antoine Beaupré wrote:
>  6. there are currently packages depending on *both* python-sphinx and
> python3-sphinx. for me, that makes no sense at all: there is a
> single set of documentation files built in a package, and it must be
> on either one of those packages, but not both. if the software
> supports building with python3, then it should depend on
> python3-sphinx, if not, it should depend on python-sphinx. by
> switching to sphinx{,3} binary packages, this would make that
> distinction clearer as well.

It does make sense if the package is a sphinx extension, and it has
tests that you may want to run in both Python 2 and 3 cases. I do have a
few of these cases (even though I'm planning on switching to Python3
support only in the short term).

On 09/28/2017 02:27 PM, Antoine Beaupré wrote:
> A simple --with=sphinxdoc should be sufficient to build sphinx docs.
> We shouldn't expect upstream to do that step in setup.py, as it is
> rarely hooked into the main build.

I don't agree with this. I generally prefer to write things this way:

override_dh_sphinxdoc:
ifeq (,$(findstring nodocs, $(DEB_BUILD_OPTIONS)))
sphinx-build -b html doc/source \
  $(CURDIR)/debian/python-foo-doc/usr/share/doc/python-foo-doc/html
dh_sphinxdoc
endif

(sorry for the indentation above, lines are too short in emails)

This way, there's no need to pickup/copy the docs in doc/build, it ends
up directly in the package, ready for dh_sphinxdoc. If I need to add
some variables (for example to fix reproducibility), I can easily do it.
I will be switching to the "python3 -m sphinx" style soon, though that's
unrelated.

Over the years, I found using this method a way better than using
"python{3,} setup.py build_sphinx". I'd suggest you try my way too.

Cheers,

Thomas Goirand (zigo)