Re: RFS: harvestman web crawler - needs updation!
Piotr Ozarowski gmail.com> writes: > Looks very good to me. As I said before, I'm not a DD so I can't > sponsor it. Debian developers, please chip in! > If you want, you can also add these 2 lines to long description: > . > Homepage: http://harvestman.freezope.org/ > ^- don't miss this extra space (dev. ref. 6.2.4) Done that as well! With that space! :-) > PS Please remember to change XS-Python-Version from "2.4" to "current" > and "python-all-dev" to "python-dev" in Build-Depends-Indep after > python2.4 will become current (with next upstream version upload, > package will work without any changes with python2.4 as current so no > need to extra upload) I'll keep that in mind. Thanks. Kumar -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: harvestman web crawler - needs updation!
Kumar Appaiah ([EMAIL PROTECTED]): > And again, get it at: > http://kumar.travisbsd.org/debpackages/harvestman_1.4.6-3.dsc Looks very good to me. As I said before, I'm not a DD so I can't sponsor it. If you want, you can also add these 2 lines to long description: . Homepage: http://harvestman.freezope.org/ ^- don't miss this extra space (dev. ref. 6.2.4) PS Please remember to change XS-Python-Version from "2.4" to "current" and "python-all-dev" to "python-dev" in Build-Depends-Indep after python2.4 will become current (with next upstream version upload, package will work without any changes with python2.4 as current so no need to extra upload) -- -=[ Piotr Ozarowski ]=- -=[ http://www.ozarowski.pl ]=- pgps8OocEjE77.pgp Description: PGP signature
Re: RFS: harvestman web crawler - needs updation!
Kumar Appaiah ee.iitm.ac.in> writes: > Thanks a lot. And again, get it at: http://kumar.travisbsd.org/debpackages/harvestman_1.4.6-3.dsc Thanks! Kumar -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: harvestman web crawler - needs updation!
Piotr Ozarowski gmail.com> writes: > > > dh_fixperms will do the job > > > > Removed. > > Hmm... I pasted one line too much - config.xml file is installed with > dh_installexamples and thus permissions are not changed, please change > them manually as you did before (I hope you're not mad at me that I > didn't test it further; `find ...|chmod ...` changed permissions in upstream > sources as well, and thats why I didn't notice that before, sorry) I remember that I went through all this initially, and that is why I had that line. I'm was not too sure why you asked me to remove it, but didn't realise that it caused this because I forgot that it was needed! I have put it back now. > use: > find ./debian/harvestman/usr/ -name '*\.py' | xargs sed -i -e '1 s|^#\!.*python.*|#!/usr/bin/$(PYTHON)|' > > (you used "python2.4" again, with "$(PYTHON)" it will be easier when > current python will be greater than 2.4) Ah, missed that! It's OK now. > You're now making link to /usr/share/pycentral/..., please use: > dh_link -i /usr/lib/$(PYTHON)/site-packages/HarvestMan/harvestman.py /usr/bin/harvestman > instead (compiled files will be placed in /usr/lib/...) Done. > > Please get back to me for corrections. > > It's not very important, but if I were you, I would remove configure* > rules (they're not used) and collapse build-$(PYTHON), build-common and > build-common-stamp into build-stamp, same with install-$(PYTHON) / > install-prereq Done. > One more thing: please bump debhelper version in Build-Depends to > 5.0.37.3 (fixed python version in XS-Python-Version parsing issue) > Done. Now, I think there aren't too many things that need to be changed. But tell me if anything else is needed, and I shall do the needful. This discussion was fruitful, for two reasons. One is, I cleaned up rules. Two, the new policy takes time getting used to, but solves a lot of the problems with the old way of building Python packages, I feel. Thanks a lot. Kumar -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: harvestman web crawler - needs updation!
Kumar Appaiah ([EMAIL PROTECTED]): > Piotr Ozarowski gmail.com> writes: > > These lines are not needed: > > > > find ./doc |xargs chmod 644 > > find -name 'config.xml' | xargs chmod 644 > > > > dh_fixperms will do the job > > Removed. Hmm... I pasted one line too much - config.xml file is installed with dh_installexamples and thus permissions are not changed, please change them manually as you did before (I hope you're not mad at me that I didn't test it further; `find ...|chmod ...` changed permissions in upstream sources as well, and thats why I didn't notice that before, sorry) > > I don't know why, but dh_python didn't set hashbangs correctly (it's not > > changing them at all). I will try to investigate it later, for now please > > use > > sed again, sorry. > > Done. use: find ./debian/harvestman/usr/ -name '*\.py' | xargs sed -i -e '1 s|^#\!.*python.*|#!/usr/bin/$(PYTHON)|' (you used "python2.4" again, with "$(PYTHON)" it will be easier when current python will be greater than 2.4) > > * remove debian/harvestman.links file and use dh_link in debian/rules > > (you have hardcoded "python2.4" there) > > Sorry, missed that! Set it right now. You're now making link to /usr/share/pycentral/..., please use: dh_link -i /usr/lib/$(PYTHON)/site-packages/HarvestMan/harvestman.py /usr/bin/harvestman instead (compiled files will be placed in /usr/lib/...) > And many thanks for your patient response. The rules file looks a lot better > now! Heh, hope you will forgive me my mistakes as well ;-) > Please get back to me for corrections. It's not very important, but if I were you, I would remove configure* rules (they're not used) and collapse build-$(PYTHON), build-common and build-common-stamp into build-stamp, same with install-$(PYTHON) / install-prereq One more thing: please bump debhelper version in Build-Depends to 5.0.37.3 (fixed python version in XS-Python-Version parsing issue) -- -=[ Piotr Ozarowski ]=- -=[ http://www.ozarowski.pl ]=- pgpMeoScG1XaY.pgp Description: PGP signature
Re: RFS: harvestman web crawler - needs updation!
Piotr Ozarowski gmail.com> writes:
> $ lintian --version
> Lintian v1.23.22
> $ lintian ../harvestman_1.4.6-3.dsc
> E: harvestman source: debian-rules-missing-required-target binary-arch
I have added it.
> These lines are not needed:
>
> find ./doc |xargs chmod 644
> find -name 'config.xml' | xargs chmod 644
>
> dh_fixperms will do the job
Removed.
> Line ("install-$(PYTHON)" rule)
> find debian/harvestman -name '*.py[co]' -exec rm -f {} \;
> is also not needed, python-central will remove *.py[co] files automatically
> (please don't remove the one from clean rule)
Done.
> I don't know why, but dh_python didn't set hashbangs correctly (it's not
> changing them at all). I will try to investigate it later, for now please use
> sed again, sorry.
Done.
> * please update DH_COMPAT var. in debian/rules (you still have "4" there):
> (I recommend using debian/compat file instead, you will not have to export
> DH_COMPAT=5 in order to run dh_* manually without warnings/errors)
Done.
> * remove debian/harvestman.links file and use dh_link in debian/rules
> (you have hardcoded "python2.4" there)
Sorry, missed that! Set it right now.
> * dh_installchangelogs, dh_installdocs and dh_installexamples are called
twice, see
> install-$(PYTHON) and binary-indep rules
They are now run only once.
> BTW: it would be easier (at least for me ;-P) if you could provide direct link
> to .dsc file in your mails (I use dget to download all necessary files)
Done.
http://kumar.travisbsd.org/debpackages/harvestman_1.4.6-3.dsc
And many thanks for your patient response. The rules file looks a lot better
now!
Please get back to me for corrections.
Kumar
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: harvestman web crawler - needs updation!
Kumar Appaiah ([EMAIL PROTECTED]):
> Piotr Ozarowski gmail.com> writes:
> > * You've missed binary-arch rule in debian/rules (see lintian info)
>
> I don't think it's necessary for Arch-Indep packages, lintian doesn't complain
> on my system.
$ lintian --version
Lintian v1.23.22
$ lintian ../harvestman_1.4.6-3.dsc
E: harvestman source: debian-rules-missing-required-target binary-arch
build-arch is not optional, but since it's not needed in your package,
just add an empty rule.
> > * why are you using `find -name file | chmod 755` (and similar)?
> > Isn't `chmod 755 file` not good enough?
>
> Well, since I don't know whether there are subdirectories with more files.
> Bad,
> but doesn't hurt, does it? :-)
These lines are not needed:
find ./doc |xargs chmod 644
find -name 'config.xml' | xargs chmod 644
dh_fixperms will do the job
Line ("install-$(PYTHON)" rule)
find debian/harvestman -name '*.py[co]' -exec rm -f {} \;
is also not needed, python-central will remove *.py[co] files automatically
(please don't remove the one from clean rule)
> > * no need to use sed in order to change hashbang, pycentral will take
> > care of it
>
> Done.
I don't know why, but dh_python didn't set hashbangs correctly (it's not
changing them at all). I will try to investigate it later, for now please use
sed again, sorry.
> Hope things are better now. See http://kumar.travisbsd.org/debpackages
* please update DH_COMPAT var. in debian/rules (you still have "4" there):
(I recommend using debian/compat file instead, you will not have to export
DH_COMPAT=5 in order to run dh_* manually without warnings/errors)
* remove debian/harvestman.links file and use dh_link in debian/rules
(you have hardcoded "python2.4" there)
* dh_installchangelogs, dh_installdocs and dh_installexamples are called twice,
see
install-$(PYTHON) and binary-indep rules
BTW: it would be easier (at least for me ;-P) if you could provide direct link
to .dsc file in your mails (I use dget to download all necessary files)
--
-=[ Piotr Ozarowski ]=-
-=[ http://www.ozarowski.pl ]=-
pgpuGsAfPLjkU.pgp
Description: PGP signature
Re: RFS: harvestman web crawler - needs updation!
Piotr Ozarowski gmail.com> writes: > * Standards-Version is outdated (check upgrading-checklist.txt file) Changed. > * debian/pycompat file is missing (`echo "2" > debian/pycompat`) Done. > * debhelper should be moved to Build-Depends Done. > * You've missed binary-arch rule in debian/rules (see lintian info) I don't think it's necessary for Arch-Indep packages, lintian doesn't complain on my system. > * "current, >=2.4" will not work with current dh_python so putting > "2.4" in XS-Python-Version header is correct but why do you have > hardcoded python2.4 in debian/rules? Please use something like >PYTHON=$(shell pyversions -r) > and compile with $(PYTHON) instead of python2.4 Done. > * remove "Replaces: harvestman (<= 1.4.6-2)" line in control file, > it's the same package, right? Done. > * why are you using `find -name file | chmod 755` (and similar)? > Isn't `chmod 755 file` not good enough? Well, since I don't know whether there are subdirectories with more files. Bad, but doesn't hurt, does it? :-) > * no need to use sed in order to change hashbang, pycentral will take > care of it Done. > * IMHO putting docs list in debian/docs file instead of calling > dh_installdocs 4x is better idea (BTW: you can do it in one line) I have called it once. Hope things are better now. See http://kumar.travisbsd.org/debpackages Thanks. Kumar -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Re: RFS: harvestman web crawler - needs updation!
Kumar Appaiah ([EMAIL PROTECTED]): > Dear Debian developers, I'm not a DD, but maybe my comments will be useful [...] > In case there are problems, please let me know, so that I can correct > them as necessary. * Standards-Version is outdated (check upgrading-checklist.txt file) * debian/pycompat file is missing (`echo "2" > debian/pycompat`) * debhelper should be moved to Build-Depends * You've missed binary-arch rule in debian/rules (see lintian info) * "current, >=2.4" will not work with current dh_python so putting "2.4" in XS-Python-Version header is correct but why do you have hardcoded python2.4 in debian/rules? Please use something like PYTHON=$(shell pyversions -r) and compile with $(PYTHON) instead of python2.4 * remove "Replaces: harvestman (<= 1.4.6-2)" line in control file, it's the same package, right? * why are you using `find -name file | chmod 755` (and similar)? Isn't `chmod 755 file` not good enough? * no need to use sed in order to change hashbang, pycentral will take care of it * IMHO putting docs list in debian/docs file instead of calling dh_installdocs 4x is better idea (BTW: you can do it in one line) -- -=[ Piotr Ozarowski ]=- -=[ http://www.ozarowski.pl ]=- pgpOmyeAWnhGi.pgp Description: PGP signature
RFS: harvestman web crawler - needs updation!
Dear Debian developers, My package, harvestman, has been marked with a severe bug related to the new Python policy. I have made the necessary updation. Please check it out at: http://kumar.travisbsd.org/debpackages (1.4.6-3 is what you should get...) In case there are problems, please let me know, so that I can correct them as necessary. Thanks. Kumar -- Kumar Appaiah, 462, Jamuna Hostel, Indian Institute of Technology Madras, Chennai - 600 036 signature.asc Description: Digital signature
