Bug#1064159: bookworm-pu: package ebook-speaker/6.2.0-4+deb12u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bookworm
X-Debbugs-Cc: ebook-spea...@packages.debian.org
Control: affects -1 + src:ebook-speaker
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I have uploaded ebook-speaker_6.2.0-4+deb12u1 for inclusion in
bookworm.

[ Reason ]
As reported on
https://github.com/book-readers/ebook-speaker/issues/4
Some users see ebook-speaker just completely fail... just because their
login is longer than 8 characters. oldstable already had the issue.

[ Impact ]
Users with a login longer than 8 characters cannot use ebook-speaker.

[ Tests ]
This was tested manually.

[ Risks ]
The code is rather simple.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
The patch gets rid of the use of the cuserid() function which brings the
length limitation. Instead we just compare gids as int rather than
interating over the logins of the group, which won't pose such kind of
issues.

Thanks,
Samuel
diff -Nru ebook-speaker-6.2.0/debian/changelog 
ebook-speaker-6.2.0/debian/changelog
--- ebook-speaker-6.2.0/debian/changelog2022-01-08 18:01:53.0 
+0100
+++ ebook-speaker-6.2.0/debian/changelog2022-02-06 01:10:26.0 
+0100
@@ -1,3 +1,9 @@
+ebook-speaker (6.2.0-4+deb12u1) bookworm; urgency=medium
+
+  * patches/long-logins: Fix testing belonging to the audio group.
+
+ -- Samuel Thibault   Sun, 06 Feb 2022 01:10:26 +0100
+
 ebook-speaker (6.2.0-4) unstable; urgency=medium
 
   * control: Bump Standards-Version to 4.6.0 (no change)
diff -Nru ebook-speaker-6.2.0/debian/patches/long-logins 
ebook-speaker-6.2.0/debian/patches/long-logins
--- ebook-speaker-6.2.0/debian/patches/long-logins  1970-01-01 
01:00:00.0 +0100
+++ ebook-speaker-6.2.0/debian/patches/long-logins  2022-02-06 
01:10:26.0 +0100
@@ -0,0 +1,47 @@
+commit b29f4884e9a7637e09f93f8d53973c83a69670d9
+Author: Samuel Thibault 
+Date:   Sun Feb 11 21:32:24 2024 +0100
+
+Fix testing belonging to the audio group
+
+cuserid() is limited to L_cuserid characters, which is 9.  This means that
+users with a longer login were never seen as belonging to the group.
+
+Let us just replace with using getgroups, which allows
+- to actually check the current allowed groups,
+- to compare gids, which don't pose length limitations.
+
+Fixes #4
+
+diff --git a/src/common.c b/src/common.c
+index a580153..6658c40 100644
+--- a/src/common.c
 b/src/common.c
+@@ -911,17 +911,18 @@ void get_list_of_sound_devices (misc_t *misc, 
audio_info_t *sound_devices)
+char *str, *orig_language;
+struct group *grp;
+FILE *p;
++   int ngroups;
++
++   ngroups = getgroups (0, NULL);
++   gid_t groups[ngroups];
++   getgroups (ngroups, groups);
+ 
+grp = getgrnam ("audio");
+-   found = 0;
+-   for (g = 0; grp->gr_mem[g]; g++)
+-   {
+-  if (strcmp (grp->gr_mem[g], cuserid (NULL)) == 0)
+-  {
+- found = 1;
+- break;
+-  } // if
+-   } // for
++   found = getegid () == grp->gr_gid;
++
++   for (g = 0; !found && g < ngroups; g++)
++  found = groups[g] == grp->gr_gid;
++
+if (found == 0)
+{
+   beep ();
diff -Nru ebook-speaker-6.2.0/debian/patches/series 
ebook-speaker-6.2.0/debian/patches/series
--- ebook-speaker-6.2.0/debian/patches/series   2021-10-23 21:25:33.0 
+0200
+++ ebook-speaker-6.2.0/debian/patches/series   2022-02-06 01:10:26.0 
+0100
@@ -2,3 +2,4 @@
 path-fix
 format
 automake
+long-logins
diff -Nru ebook-speaker-6.2.0/debian/salsa-ci.yml 
ebook-speaker-6.2.0/debian/salsa-ci.yml
--- ebook-speaker-6.2.0/debian/salsa-ci.yml 2021-09-26 11:05:02.0 
+0200
+++ ebook-speaker-6.2.0/debian/salsa-ci.yml 2022-02-06 01:10:26.0 
+0100
@@ -3,6 +3,9 @@
   - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
   - 
https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
 
+variables:
+  RELEASE: bookworm
+
 test-crossbuild-arm64:
   allow_failure: false
 

Bug#1060165: RM: liblouisutdml/2.12.0-2

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: rm
X-Debbugs-Cc: liblouisut...@packages.debian.org
Control: affects -1 + src:liblouisutdml

Hello,

One month later, upstream liblouisutdml is failing to update to the
newer liblouis (3.28):

https://github.com/liblouis/liblouisutdml/issues/103

thus making it fail to build in unstable (#1058514) and its autopkgtest
failing with the newer liblouis, thus leading to an automatic request
for removal of liblouis (#1060148).

We really rather want to update liblouis and remove liblouisutdml from
testing rather than see liblouis stuck at 3.27.

Thanks,
Samuel

Bug#1059656: bookworm-pu: package espeak-ng/1.51+dfsg-10+deb12u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: espeak...@packages.debian.org
Control: affects -1 + src:espeak-ng

[ Reason ]
This upload provides fixes for CVEs. They are not a regression over
oldstable.

[ Impact ]
Blind users using the espeak-ng speech synthesis might be at risk when
e.g. reading a webpage that contains the CVE triggers.

[ Tests ]
CVE tests are getting added in the patch.

[ Risks ]
The code is relatively simple, comes from upstream, and has been in
testing since December 24th.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Change s]in *all* the changes)

The changes fix various use-after-free, unitialized buffers (which lead
to missing \0 terminators), and missing buffer bound checks.
diff -Nru espeak-ng-1.51+dfsg/debian/changelog 
espeak-ng-1.51+dfsg/debian/changelog
--- espeak-ng-1.51+dfsg/debian/changelog2023-01-26 01:09:47.0 
+0100
+++ espeak-ng-1.51+dfsg/debian/changelog2023-12-21 01:26:02.0 
+0100
@@ -1,3 +1,10 @@
+espeak-ng (1.51+dfsg-10+deb12u1) bookworm; urgency=medium
+
+  * patches/CVE: Fix CVE-2023-49990, CVE-2023-49991, CVE-2023-49992,
+CVE-2023-49993, CVE-2023-49994 (Closes: Bug#1059060)
+
+ -- Samuel Thibault   Thu, 21 Dec 2023 01:26:02 +0100
+
 espeak-ng (1.51+dfsg-10) unstable; urgency=medium
 
   * watch: Use API instead of releases page.
diff -Nru espeak-ng-1.51+dfsg/debian/patches/CVE 
espeak-ng-1.51+dfsg/debian/patches/CVE
--- espeak-ng-1.51+dfsg/debian/patches/CVE  1970-01-01 01:00:00.0 
+0100
+++ espeak-ng-1.51+dfsg/debian/patches/CVE  2023-12-21 01:26:02.0 
+0100
@@ -0,0 +1,326 @@
+commit 58f1e0b6a4e6aa55621c6f01118994d01fd6f68c
+Merge: f983e445 e7bcd3cc
+Author: Alexander Epaneshnikov 
+Date:   Sun Dec 17 15:29:30 2023 +0300
+
+tests: fix CVE crashes (#1846)
+
+Fixes: #1823, #1824, #1825, #1826, #1827
+
+- Add crash test and vectors provided by @SEU-SSL
+- Disallow dummy/null voice load (that causes incorrect translator
+initialization)
+- Fix empty `phondata` file load (that causes unitialized memory access)
+- Limit max word length for RemoveEnding (causes buffer overflow)
+- Limit punctlist initialization from embedded commands (buffer
+overflow)
+- Fix unitialized pitch in wavegen (DBZ and indexing problems)
+- Properly zeroize stack variables before use in TranslateClause and
+SetWordStress
+
+TODO (in nextup PR): add & fix more vectors from fuzzer.
+
+commit 9decedb8c229e1a4219baceaab7a3d656e889e31
+Author: Samuel Thibault 
+Date:   Thu Jun 30 00:50:18 2022 +0200
+
+Fix missing checks for EOF
+
+commit c4c05820c4a47369d5a81e4a506fe7abb2fa7ed6
+Author: Yury Popov 
+Date:   Sat Dec 16 19:24:51 2023 +0300
+
+tests: add CVE crash vectors
+
+commit e79405772cecf47053116aeaad10e64606292b14
+Author: Yury Popov 
+Date:   Sat Dec 16 23:55:03 2023 +0300
+
+voices: disallow dummy voice when not compiling
+
+commit 7d4ad3c2ae063cb08bfd606021bc323dfbadaba9
+Author: Yury Popov 
+Date:   Sat Dec 16 21:50:07 2023 +0300
+
+synthdata: fix empty file load
+
+commit b99f332c576eb49839613a55cfd3e0e1b5487191
+Author: Yury Popov 
+Date:   Sat Dec 16 22:45:15 2023 +0300
+
+dictionary: limit word length
+
+commit 1a7ecfc2f202438b17e742368f910e6099ce02b7
+Author: Yury Popov 
+Date:   Sat Dec 16 22:50:01 2023 +0300
+
+readclause: limit embedded punctlist length
+
+commit a5eb246debb51ba328ef399350dfcd5d87782245
+Author: Yury Popov 
+Date:   Sat Dec 16 23:03:16 2023 +0300
+
+wavegen: fix unitialized pitch
+
+commit 5f7db763e2eff1d8174d2b65a4bbe4b2a85c8a0c
+Author: Yury Popov 
+Date:   Sat Dec 16 23:17:45 2023 +0300
+
+translate: fix number_buf initialization
+
+commit e7bcd3cc1599ebb531bb62fc3007d3ce1dade167
+Author: Yury Popov 
+Date:   Sat Dec 16 23:26:07 2023 +0300
+
+dictionary: fix stack initialization
+
+---
+ src/libespeak-ng/dictionary.c  |4 
+ src/libespeak-ng/readclause.c  |   12 ++--
+ src/libespeak-ng/synthdata.c   |   18 ++
+ src/libespeak-ng/translate.c   |1 +
+ src/libespeak-ng/voices.c  |   20 
+ src/libespeak-ng/wavegen.c |9 ++---
+ tests/crash.test   |   17 +
+ tests/crash_vectors/cve-2023-49990.txt |1 +
+ tests/crash_vectors/cve-2023-49991.txt |1 +
+ tests/crash_vectors/cve-2023-49994.txt |1 +
+ 10 files changed, 63 insertions(+), 21 deletions(-)
+
+--- a/src/libespeak-ng/readclause.c
 b/src/libespeak-ng/readclause.c
+@@ -335,7 +335,7 @@ static int AnnouncePunctuation(Translato
+ 
+   if ((*bufix == 0) || (end_clause == 0) || 
(tr->langopts.param[LOPT_ANNOUNC

Bug#1056721: bookworm-pu: package speech-dispatcher-contrib/0.11.4-3+deb12u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: speech-dispatcher-cont...@packages.debian.org
Control: affects -1 + src:speech-dispatcher-contrib

Hello,

I have uploaded the attached changes for inclusion in bookworm.

Samuel

[ Reason ]
This is not really a bug but a missing feature :)

More and more blind users use arm64/armhf hardware, so that speech
synthesis availability becomes more and more important on that arch. The
French reseller of the voxin speech synthesis contacted us because they
wish to provide voxin support on arm64 & armhf, which boils down to
simply building the speech-dispatcher-voxin package on these archs. We'd
rather not have to wait for 1.5 years for this to become available when
no code change is actually needed.

(previously we didn't build it there because there was no support
available).

[ Impact ]
Without this update, it would be much more complex for our users to
install high-quality speech synthesis from voxin.

[ Tests ]
No code is affected

[ Risks ]
The change is trivial and not actually in the code

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
It just enables the arch for the package at stake.

(and actually build it by hand in a clean chroot since the whole package
depends on non-free packages).
diff -Nru speech-dispatcher-contrib-0.11.4/debian/changelog 
speech-dispatcher-contrib-0.11.4/debian/changelog
--- speech-dispatcher-contrib-0.11.4/debian/changelog   2023-04-27 
01:08:20.0 +0200
+++ speech-dispatcher-contrib-0.11.4/debian/changelog   2023-11-22 
18:37:46.0 +0100
@@ -1,3 +1,9 @@
+speech-dispatcher-contrib (0.11.4-3+deb12u1) bookworm; urgency=medium
+
+  * control: Enable voxin on armhf and arm64 archs.
+
+ -- Samuel Thibault   Wed, 22 Nov 2023 18:37:46 +0100
+
 speech-dispatcher-contrib (0.11.4-3) unstable; urgency=medium
 
   * control: Add missing breaks+replaces between speech-dispatcher-ivona and
diff -Nru speech-dispatcher-contrib-0.11.4/debian/control 
speech-dispatcher-contrib-0.11.4/debian/control
--- speech-dispatcher-contrib-0.11.4/debian/control 2023-04-27 
01:08:20.0 +0200
+++ speech-dispatcher-contrib-0.11.4/debian/control 2023-11-22 
18:37:46.0 +0100
@@ -140,7 +140,7 @@
  which needs to be installed separately.
 
 Package: speech-dispatcher-voxin
-Architecture: amd64 i386
+Architecture: arm64 armhf amd64 i386
 Multi-Arch: foreign
 Section: contrib/sound
 Depends:
diff -Nru speech-dispatcher-contrib-0.11.4/debian/salsa-ci.yml 
speech-dispatcher-contrib-0.11.4/debian/salsa-ci.yml
--- speech-dispatcher-contrib-0.11.4/debian/salsa-ci.yml2023-04-27 
01:00:31.0 +0200
+++ speech-dispatcher-contrib-0.11.4/debian/salsa-ci.yml2023-11-22 
18:37:46.0 +0100
@@ -9,5 +9,6 @@
 
 variables:
   SALSA_CI_REPROTEST_ENABLE_DIFFOSCOPE: 1
+  RELEASE: bookworm
 
 # vim: ts=2 sw=2 et sts=2 ft=yaml

Bug#1056204: nmu: texlive-bin_2023.20230311.66589-7

[Samuel Thibault]

Samuel Thibault, le sam. 18 nov. 2023 20:18:01 +0100, a ecrit:
> nmu texlive-bin_2023.20230311.66589-7 . ANY . unstable . -m "Rebuild against 
> new zlib"

I forgot to mention that this should of course be made dep-wait
zlib1g-dev (>= 1:1.3.dfsg-1) 



> Hello,
> 
> Since the upload of zlib1g 1:1.3.dfsg-1, installing texlive-binaries
> texlive-base fails:
> 
> fmtutil failed. Output has been stored in
> /tmp/fmtutil.ndDMEWN5
> 
> [...]
> 
> fmtutil: running `luatex -ini   -jobname=luatex -progname=luatex luatex.ini' 
> ...
> PANIC: unprotected error in call to Lua API (zlib library version does not 
> match - header: 1.2.13, library: 1.3)
> Aborted
> 
> And indeed texlive-bin checks the zlib version:
> 
> https://codesearch.debian.net/search?q=zlib+library+version+does+not+match=en
> 
> texlive-bin_2023.20230311.66589-7/texk/web2c/luatexdir/luazlib/lzlib.c
> 
> if (strncmp(version, ZLIB_VERSION, 4))
> {
> lua_pushfstring(L, "zlib library version does not match - header: %s, 
> library: %s", ZLIB_VERSION, version);
> lua_error(L);
> }
> 
> So a binnmu of the texlive-bin source package seems needed on all archs
> to fix installing texlive-binaries.
> 
> Samuel

Bug#1056204: nmu: texlive-bin_2023.20230311.66589-7

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: binnmu
X-Debbugs-Cc: texlive-...@packages.debian.org
Control: affects -1 + src:texlive-bin

nmu texlive-bin_2023.20230311.66589-7 . ANY . unstable . -m "Rebuild against 
new zlib"

Hello,

Since the upload of zlib1g 1:1.3.dfsg-1, installing texlive-binaries
texlive-base fails:

fmtutil failed. Output has been stored in
/tmp/fmtutil.ndDMEWN5

[...]

fmtutil: running `luatex -ini   -jobname=luatex -progname=luatex luatex.ini' ...
PANIC: unprotected error in call to Lua API (zlib library version does not 
match - header: 1.2.13, library: 1.3)
Aborted

And indeed texlive-bin checks the zlib version:

https://codesearch.debian.net/search?q=zlib+library+version+does+not+match=en

texlive-bin_2023.20230311.66589-7/texk/web2c/luatexdir/luazlib/lzlib.c

if (strncmp(version, ZLIB_VERSION, 4))
{
lua_pushfstring(L, "zlib library version does not match - header: %s, 
library: %s", ZLIB_VERSION, version);
lua_error(L);
}

So a binnmu of the texlive-bin source package seems needed on all archs
to fix installing texlive-binaries.

Samuel

Bug#1051569: bookworm-pu: package brltty/6.5-7+deb12u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: brl...@packages.debian.org
Control: affects -1 + src:brltty

Hello,

I have uploaded brltty/6.5-7+deb12u1 for inclusion in bookworm.

Samuel

[ Reason ]
As discussed on
https://www.freelists.org/post/orca/Braille-navigation-issues-with-Orca-441
with the brltty version installed in bookworm, if a user has the orca
and xbrlapi packages installed, but not the brltty-x11 package
installed, the braille navigation and cursor routing keys are not
working in the Orca screen reader. This is a regression in bookworm
compared to buster.

[ Impact ]
The user loses a lot of navigation convenience when e.g. browsing the
Internet, they cannot just "click" on a link (with the routing keys) to
follow it.

[ Tests ]
This was tested by hand and reported as fixed by the reporter.

[ Risks ]
The code is relatively simple.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]

The proposed fix is actually fixing the issue twice:

- it makes xbrlapi check whether the brltty-x11 package is
installed before starting brltty with the ba and a2 drivers.

- and it makes the missing of the brltty-x11 package (in case the user
started brltty by hand with the ba and a2 drivers) not consume the
braille key events out of orca's reach.
diff -Nru brltty-6.5/debian/changelog brltty-6.5/debian/changelog
--- brltty-6.5/debian/changelog 2023-04-06 01:27:28.0 +0200
+++ brltty-6.5/debian/changelog 2023-09-07 19:46:53.0 +0200
@@ -1,3 +1,12 @@
+brltty (6.5-7+deb12u1) bookworm; urgency=medium
+
+  * patches/git-xbrlapi: Fix ba+a2 load failure log flood, and failure to use
+braille shortcuts in Orca.
+  * patches/git-base-none-quality: Set quality to low or none for base and no
+screen drivers.
+
+ -- Samuel Thibault   Thu, 07 Sep 2023 19:46:53 +0200
+
 brltty (6.5-7) unstable; urgency=medium
 
   [ Remus-Gabriel Chelu ]
diff -Nru brltty-6.5/debian/patches/git-base-none-quality 
brltty-6.5/debian/patches/git-base-none-quality
--- brltty-6.5/debian/patches/git-base-none-quality 1970-01-01 
01:00:00.0 +0100
+++ brltty-6.5/debian/patches/git-base-none-quality 2023-09-07 
19:46:53.0 +0200
@@ -0,0 +1,42 @@
+commit aadd8a93de29fb1d7d47dbe91b815655e76ef5f8
+Author: Samuel Thibault 
+Date:   Tue Sep 5 00:00:56 2023 +0200
+
+screen: Set quality to low or none for base and no
+
+When e.g. brltty cannot load a screen driver, but can load the BrlAPI
+driver, we have to make sure to know that we have a low screen reading
+quality, otherwise the BrlAPI driver would consume braille keyboard
+events, without being able to do anything about them.
+
+This notably fixes cursor routing and braille panning in Orca when
+xbrlapi is installed but the a2 screen driver is not installed.
+
+diff --git a/Programs/scr_base.c b/Programs/scr_base.c
+index 23c7e4d1f..de867a7d5 100644
+--- a/Programs/scr_base.c
 b/Programs/scr_base.c
+@@ -149,6 +149,7 @@ refresh_BaseScreen (void) {
+ 
+ static void
+ describe_BaseScreen (ScreenDescription *description) {
++  description->quality = SCQ_NONE;
+   description->rows = 1;
+   description->cols = strlen(text_BaseScreen);
+   description->posx = 0;
+diff --git a/Programs/scr_driver.c b/Programs/scr_driver.c
+index 57e602b0b..416487471 100644
+--- a/Programs/scr_driver.c
 b/Programs/scr_driver.c
+@@ -81,6 +81,11 @@ describe_NoScreen (ScreenDescription *description) {
+ screenMessage = message;
+   }
+ 
++  if (screenMessage)
++description->quality = SCQ_LOW;
++  else
++description->quality = SCQ_NONE;
++
+   description->rows = 1;
+   description->cols = strlen(screenMessage);
+   description->posx = 0;
diff -Nru brltty-6.5/debian/patches/git-xbrlapi 
brltty-6.5/debian/patches/git-xbrlapi
--- brltty-6.5/debian/patches/git-xbrlapi   1970-01-01 01:00:00.0 
+0100
+++ brltty-6.5/debian/patches/git-xbrlapi   2023-09-07 19:46:53.0 
+0200
@@ -0,0 +1,35 @@
+https://github.com/brltty/brltty/pull/419
+
+commit 898350dcbe11bd46d2e3babffe0764169d0a0457
+Author: Samuel Thibault 
+Date:   Sat Jun 17 22:52:42 2023 +0200
+
+xbrlapi: Do not try to start brltty with ba+a2 when unavailable
+
+When a distribution ships them separately they may not be available, and
+brltty would then flood logs with driver load failure warning every 5
+seconds.
+
+diff --git a/Autostart/X11/90xbrlapi.in b/Autostart/X11/90xbrlapi.in
+index ecb2f5e57..cb3e3e5b3 100644
+--- a/Autostart/X11/90xbrlapi.in
 b/Autostart/X11/90xbrlapi.in
+@@ -2,6 +2,7 @@
+ 
+ prefix="@prefix@"
+ exec_prefix="@exec_prefix@"
++drivers_directory="@drivers_directory@"
+ program_di

Re: Upcoming D-I Bookworm RC 4 and pseudo-RC 5

[Samuel Thibault]

Cyril Brulebois, le sam. 03 juin 2023 20:07:05 +0200, a ecrit:
> Unless specifically requested, I don't plan on including the first two
> before Bookworm because we don't need it for release architectures. I
> /think/ hurd-i386 gets somewhat released from unstable, so that
> shouldn't matter…

Yes.

> not sure about ports architectures.

Ports don't have a testing either.

Samuel

Bug#1035648: unblock: lios/2.7.2-6

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: l...@packages.debian.org
Control: affects -1 + src:lios

Hello,

I have uploaded lios_2.7.2-6 for inclusion in bookworm.

[ Reason ]
As reported on Bug#1035379, upstream lios looks for available tesseract
languages by looking inside /usr/share/tesseract-ocr/tessdata, but on
Debian the data is stored in /usr/share/tesseract-ocr/5/tessdata.

The problem was already there in bullseye, in which we had a patch
to make it look in /usr/share/tesseract-ocr/4.00/tessdata, but when
tesseract was bumped to version 5, updating that patch was missed.

Of course, I had reported the issue upstream 5 years ago on
https://github.com/zendalona/lios/issues/6
but without answer so far.

[ Impact ]
Without this fix, the Optical Character Recognition (OCR) feature of
lios does not work, which makes it rather useless, since its purpose is
not only to scan, but particularly to run OCR.

[ Tests ]
This was tested by hand.

[ Risks ]
The code is very trivial.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock lios/2.7.2-6
diff -Nru lios-2.7.2/debian/changelog lios-2.7.2/debian/changelog
--- lios-2.7.2/debian/changelog 2023-04-03 23:22:12.0 +0200
+++ lios-2.7.2/debian/changelog 2023-05-07 02:13:46.0 +0200
@@ -1,3 +1,10 @@
+lios (2.7.2-6) unstable; urgency=medium
+
+  * patches/tesseract_langpath: Bump tesseract version to 5
+(Closes: Bug#1035379).
+
+ -- Samuel Thibault   Sun, 07 May 2023 02:13:46 +0200
+
 lios (2.7.2-5) unstable; urgency=medium
 
   * patches/preference-voice-list: Fix general preferences loading delay.
diff -Nru lios-2.7.2/debian/patches/tesseract_langpath 
lios-2.7.2/debian/patches/tesseract_langpath
--- lios-2.7.2/debian/patches/tesseract_langpath2023-04-03 
23:18:31.0 +0200
+++ lios-2.7.2/debian/patches/tesseract_langpath2023-05-07 
02:13:14.0 +0200
@@ -8,7 +8,7 @@
  
  TESSDATA_POSSIBLE_PATHS = [
"/usr/share/tesseract-ocr/tessdata",
-+  "/usr/share/tesseract-ocr/4.00/tessdata",
++  "/usr/share/tesseract-ocr/5/tessdata",
"/usr/share/tesseract/tessdata",
"/usr/share/tessdata",
"/usr/local/share/tesseract-ocr/tessdata",

Bug#1035628: unblock: java-atk-wrapper/0.40.0-3

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: java-atk-wrap...@packages.debian.org
Control: affects -1 + src:java-atk-wrapper

Hello,

I have uploaded java-atk-wrapper_0.40.0-3 for inclusion in bookworm.

[ Reason ]
There was a mistake in the upstream code in the test for presence of the
ATK_STATE_COLLAPSED feature in atk, fixed by this upload.

[ Impact ]
In the current bookworm, the treeviews of java applications are
currently inaccessible to blind users. For instance in mediathekview, in
the preference dialog box, the treeview on the left to browse between
panels of the box is inaccessible: users don't know which panel is
currently active, making such dialog box very tedious to work with,
one has to guess what panel is on. This is so for all treeviews, so
most preference dialog boxes of java applications, and treeviews in the
designs of java applications.

[ Tests ]
This was tested manually.

[ Risks ]
The code is very trivial, and comes from upstream
(well, I am upstream :) )

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

Thanks!

unblock java-atk-wrapper/0.40.0-3
diff -Nru java-atk-wrapper-0.40.0/debian/changelog 
java-atk-wrapper-0.40.0/debian/changelog
--- java-atk-wrapper-0.40.0/debian/changelog2022-04-04 20:36:56.0 
+0200
+++ java-atk-wrapper-0.40.0/debian/changelog2023-05-06 21:25:54.0 
+0200
@@ -1,3 +1,10 @@
+java-atk-wrapper (0.40.0-3) unstable; urgency=medium
+
+  * patches/ATK_STATE_COLLAPSED: Fix checking for ATK_STATE_COLLAPSED
+availability.
+
+ -- Samuel Thibault   Sat, 06 May 2023 21:25:54 +0200
+
 java-atk-wrapper (0.40.0-2) unstable; urgency=medium
 
   * control: Bump atk1.0 build-dep to get ATK_STATE_COLLAPSED.
diff -Nru java-atk-wrapper-0.40.0/debian/patches/ATK_STATE_COLLAPSED 
java-atk-wrapper-0.40.0/debian/patches/ATK_STATE_COLLAPSED
--- java-atk-wrapper-0.40.0/debian/patches/ATK_STATE_COLLAPSED  1970-01-01 
01:00:00.0 +0100
+++ java-atk-wrapper-0.40.0/debian/patches/ATK_STATE_COLLAPSED  2023-05-06 
21:25:19.0 +0200
@@ -0,0 +1,22 @@
+commit 5e90b12a7703e108d0183c86c2cf577271865afe
+Author: Samuel Thibault 
+Date:   Sat May 6 21:23:56 2023 +0200
+
+Fix checking for ATK_STATE_COLLAPSED
+
+ATK_STATE_COLLAPSED is not actually a macro, so replace #ifdef with a
+version check, since we know it appeared in atk 2.38.
+
+diff --git a/jni/src/jawutil.c b/jni/src/jawutil.c
+index a6c894c..8b2a16d 100644
+--- a/jni/src/jawutil.c
 b/jni/src/jawutil.c
+@@ -589,7 +589,7 @@ jaw_util_get_atk_state_type_from_java_state (JNIEnv 
*jniEnv, jobject jobj)
+ return ATK_STATE_CHECKED;
+ 
+   if (is_same_java_state( jniEnv, jobj, "COLLAPSED" ))
+-#ifdef ATK_STATE_COLLAPSED
++#if ATK_CHECK_VERSION (2,38,0)
+ return ATK_STATE_COLLAPSED;
+ #else
+ return ATK_STATE_INVALID;
diff -Nru java-atk-wrapper-0.40.0/debian/patches/series 
java-atk-wrapper-0.40.0/debian/patches/series
--- java-atk-wrapper-0.40.0/debian/patches/series   2022-03-29 
22:41:41.0 +0200
+++ java-atk-wrapper-0.40.0/debian/patches/series   2023-05-06 
21:25:54.0 +0200
@@ -1,3 +1,4 @@
 java-1.7
 
 atk-dep
+ATK_STATE_COLLAPSED
diff -Nru java-atk-wrapper-0.40.0/debian/salsa-ci.yml 
java-atk-wrapper-0.40.0/debian/salsa-ci.yml
--- java-atk-wrapper-0.40.0/debian/salsa-ci.yml 2021-09-26 10:00:44.0 
+0200
+++ java-atk-wrapper-0.40.0/debian/salsa-ci.yml 2022-05-27 00:53:20.0 
+0200
@@ -6,4 +6,7 @@
 test-crossbuild-arm64:
   allow_failure: false
 
+variables:
+  SALSA_CI_REPROTEST_ENABLE_DIFFOSCOPE: 1
+
 # vim: ts=2 sw=2 et sts=2 ft=yaml

Bug#1035016: unblock: eztrace/2.0+repack-12

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: eztr...@packages.debian.org
Control: affects -1 + src:eztrace

Hello,

I have uploaded eztrace_2.0+repack-12 to unstable, for
inclusion in bookworm.

[ Reason ]
As detailed in Bug#1034956, there is a missing breaks+replace between
the libeztrace0 package and the libeztrace-dev package.
What happened is that usr/lib/*/libeztrace-*.so (plugins) were
moved from the latter to the former in version 2.0-1, but adding
breaks replaces was missed.

[ Impact ]
The impact happens if libeztrace0 gets upgraded before libeztrace-dev:

| (Reading database ... 5608 files and directories currently installed.)
| Preparing to unpack .../libeztrace0_2.0+repack-11_amd64.deb ...
| Unpacking libeztrace0:amd64 (2.0+repack-11) over (1.1-10-2) ...
| dpkg: error processing archive ./libeztrace0_2.0+repack-11_amd64.deb 
(--unpack):
|  trying to overwrite '/usr/lib/x86_64-linux-gnu/libeztrace-memory.so', which 
is also in package libeztrace-dev:amd64 1.1-10-2
| dpkg-deb: error: paste subprocess was killed by signal (Broken pipe)

It usually doesn't happen in practice because since libeztrace-dev
depends on the same version of libeztrace0, apt would upgrade the latter
before the former.

[ Tests ]
This was tested by hand by installing libeztrace0 on a bullseye system
with --auto-deconfigure and with libeztrace-dev installed.

[ Risks ]
The code is very trivial.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

Thanks!

unblock eztrace/2.0+repack-12
diff -Nru eztrace-2.0+repack/debian/changelog 
eztrace-2.0+repack/debian/changelog
--- eztrace-2.0+repack/debian/changelog 2022-12-20 16:17:31.0 +0100
+++ eztrace-2.0+repack/debian/changelog 2023-04-27 16:07:04.0 +0200
@@ -1,3 +1,11 @@
+eztrace (2.0+repack-12) unstable; urgency=medium
+
+  * control: Add missing breaks+replaces between libeztrace0 and
+libeztrace-dev, missed when moving /usr/lib/*/*.so from the latter to the
+former (Closes: Bug#1034956)
+
+ -- Samuel Thibault   Thu, 27 Apr 2023 16:07:04 +0200
+
 eztrace (2.0+repack-11) unstable; urgency=medium
 
   * control: Always depend on otf2, eztrace now always requires it actually.
diff -Nru eztrace-2.0+repack/debian/control eztrace-2.0+repack/debian/control
--- eztrace-2.0+repack/debian/control   2022-12-20 16:17:31.0 +0100
+++ eztrace-2.0+repack/debian/control   2023-04-27 16:06:20.0 +0200
@@ -53,6 +53,8 @@
 Architecture: any
 Multi-Arch: same
 Depends: ${shlibs:Depends}, ${misc:Depends}
+Breaks: libeztrace-dev (<< 2.0-1)
+Replaces: libeztrace-dev (<< 2.0-1)
 Pre-Depends: ${misc:Pre-Depends}
 Description: Automatic execution trace generation for HPC - runtime libraries
  EZTrace is a tool that aims at generating automatically execution traces

Bug#1034898: unblock: speech-dispatcher-contrib/0.11.4-3

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: speech-dispatcher-cont...@packages.debian.org
Control: affects -1 + src:speech-dispatcher-contrib

Hello,

I have uploaded speech-dispatcher-contrib 0.11.4-3 to unstable, for
inclusion in bookworm.

[ Reason ]
As detailed in Bug#1034897, there is a missing breaks+replace between
the speech-dispatcher-ivona package and the speech-dispatcher package.
What happened is that /etc/speech-dispatcher/modules/ivona.conf was
moved from the latter to the former in version 0.10.2-3, but adding
breaks replaces was missed.

[ Impact ]
The impact is not that high since speech-dispatcher-ivona didn't exist
in bullseye, so provided that the user first upgrades the
speech-dispatcher package to the bookworm version, before attempting to
install speech-dispatcher-ivona, things will go fine (and no package
depends on speech-dispatcher-ivona so it cannot come through an
upgrade).

But if the user tries to install speech-dispatcher-ivona from bookworm
on a bullseye system, the conflict will hit dpkg:

| dpkg: error processing archive speech-dispatcher-ivona_0.11.4-1_amd64.deb 
(--unpack):
|  trying to overwrite '/etc/speech-dispatcher/modules/ivona.conf', which is 
also in package speech-dispatcher 0.10.2-2+deb11u2

[ Tests ]
This was tested by hand by installing
speech-dispatcher-ivona_0.11.4-1_amd64.deb on a bullseye system with
speech-dispatcher installed.

[ Risks ]
The code is very trivial.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

Thanks!

unblock speech-dispatcher-contrib/0.11.4-3
diff -Nru speech-dispatcher-contrib-0.11.4/debian/changelog 
speech-dispatcher-contrib-0.11.4/debian/changelog
--- speech-dispatcher-contrib-0.11.4/debian/changelog   2022-10-30 
23:06:55.0 +0100
+++ speech-dispatcher-contrib-0.11.4/debian/changelog   2023-04-27 
01:08:20.0 +0200
@@ -1,3 +1,11 @@
+speech-dispatcher-contrib (0.11.4-3) unstable; urgency=medium
+
+  * control: Add missing breaks+replaces between speech-dispatcher-ivona and
+speech-dispatcher, missed when moving ivona.conf from the latter to the
+former (Closes: Bug#1034897)
+
+ -- Samuel Thibault   Thu, 27 Apr 2023 01:08:20 +0200
+
 speech-dispatcher-contrib (0.11.4-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru speech-dispatcher-contrib-0.11.4/debian/control 
speech-dispatcher-contrib-0.11.4/debian/control
--- speech-dispatcher-contrib-0.11.4/debian/control 2022-10-30 
23:06:55.0 +0100
+++ speech-dispatcher-contrib-0.11.4/debian/control 2023-04-27 
01:08:20.0 +0200
@@ -176,6 +176,8 @@
  ${misc:Depends},
  speech-dispatcher (>= ${source:Upstream-Version}),
  speech-dispatcher (<< ${source:Upstream-Version}.0~)
+Breaks: speech-dispatcher (<< 0.10.2-3)
+Replaces: speech-dispatcher (<< 0.10.2-3)
 Description: Speech Dispatcher: Ivona output module
  Speech Dispatcher provides a device independent layer for speech synthesis.
  It supports various software and hardware speech synthesizers as

Bug#1034623: unblock: qtbase-opensource-src/5.15.8+dfsg-7

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: qtbase-opensource-...@packages.debian.org
Control: affects -1 + src:qtbase-opensource-src

Please unblock package qtbase-opensource-src, thanks!

[ Reason ]
This upload fixes the accessibility of Qt5 application started as root.
Bug#1033995

[ Impact ]
Normally users wouldn't run applications as root, but one notable
exception is the calamares installer, which is based on qt5 and runs as
root, and it currently is completely inaccessible to blind users, and
this fix makes it possible for blind users to use it.

[ Tests ]
This was tested by hand, as well as by upstream.

[ Risks ]
The code is quite simple. It went through a few iterations because of
the complexity of the initialization of Qt applications. In the end, the
solution that was commited upstream (using QMetaObject::invokeMethod
to delay initialization of accessibility) is very similar to another
upstream fix that had gone in in july 2022 and hasn't met any problems
since then.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock qtbase-opensource-src/5.15.8+dfsg-7
diff -Nru qtbase-opensource-src-5.15.8+dfsg/debian/changelog 
qtbase-opensource-src-5.15.8+dfsg/debian/changelog
--- qtbase-opensource-src-5.15.8+dfsg/debian/changelog  2023-02-27 
09:28:53.0 +0100
+++ qtbase-opensource-src-5.15.8+dfsg/debian/changelog  2023-04-13 
01:24:34.0 +0200
@@ -1,3 +1,31 @@
+qtbase-opensource-src (5.15.8+dfsg-7) unstable; urgency=medium
+
+  * Update a11y_root.diff. This time the code waits for Qt loop to process the
+check (Closes: #1033995, #1034160, #1034271).
+
+ -- Lisandro Damián Nicanor Pérez Meyer   Wed, 12 Apr 
2023 20:24:34 -0300
+
+qtbase-opensource-src (5.15.8+dfsg-6) unstable; urgency=medium
+
+  * Use the new, fixed version of a11y_root.diff from Samuel Thibault
+(again closes: #1033995).
+
+ -- Dmitry Shachnev   Tue, 11 Apr 2023 14:25:22 +0300
+
+qtbase-opensource-src (5.15.8+dfsg-5) unstable; urgency=medium
+
+  * Revert the last upload. Unfortunately, it caused regressions
+(closes: #1034160, #1034169, #1034191).
+
+ -- Dmitry Shachnev   Mon, 10 Apr 2023 23:58:16 +0300
+
+qtbase-opensource-src (5.15.8+dfsg-4) unstable; urgency=medium
+
+  * Add a patch to fix accessibility on XCB when running as root
+(closes: #1033995).
+
+ -- Dmitry Shachnev   Sun, 09 Apr 2023 21:23:36 +0300
+
 qtbase-opensource-src (5.15.8+dfsg-3) unstable; urgency=medium
 
   * Use ${DEB_HOST_GNU_TYPE} substitution in debian/qt5-qmake.install.
diff -Nru qtbase-opensource-src-5.15.8+dfsg/debian/patches/a11y_root.diff 
qtbase-opensource-src-5.15.8+dfsg/debian/patches/a11y_root.diff
--- qtbase-opensource-src-5.15.8+dfsg/debian/patches/a11y_root.diff 
1970-01-01 01:00:00.0 +0100
+++ qtbase-opensource-src-5.15.8+dfsg/debian/patches/a11y_root.diff 
2023-04-13 00:50:31.0 +0200
@@ -0,0 +1,33 @@
+Description: fix accessibility on XCB when running as root
+ Accessibility actually works when running applications as root, but we
+ would never properly connect, since the enabledChanged signal would be
+ emitted from the constructor in this case. So after connecting the
+ signal, check the value by hand to make sure not to miss the
+ notification.
+ .
+ Only applications running as root would be affected, because all other
+ applications would go through the asynchronous pattern of getting the
+ bus address from dbus instead.
+Origin: https://codereview.qt-project.org/c/qt/qtbase/+/205196
+Bug: https://bugs.debian.org/1033995
+Last-Update: 2023-04-12
+
+--- a/src/platformsupport/linuxaccessibility/bridge.cpp
 b/src/platformsupport/linuxaccessibility/bridge.cpp
+@@ -65,6 +65,16 @@ QSpiAccessibleBridge::QSpiAccessibleBrid
+ {
+ dbusConnection = new DBusConnection();
+ connect(dbusConnection, SIGNAL(enabledChanged(bool)), this, 
SLOT(enabledChanged(bool)));
++// Now that we have connected the signal, make sure we didn't miss a 
change,
++// e.g. when running as root or when AT_SPI_BUS_ADDRESS is set by hand.
++// But do that only on next loop, once dbus is really settled.
++QMetaObject::invokeMethod(
++this,
++[this] {
++if (dbusConnection->isEnabled())
++enabledChanged(true);
++},
++Qt::QueuedConnection);
+ }
+
+ void QSpiAccessibleBridge::enabledChanged(bool enabled)
diff -Nru qtbase-opensource-src-5.15.8+dfsg/debian/patches/series 
qtbase-opensource-src-5.15.8+dfsg/debian/patches/series
--- qtbase-opensource-src-5.15.8+dfsg/debian/patches/series 2023-02-27 
09:28:53.0 +0100
+++ qtbase-opensource-src-5.15.8+dfsg/debian/patches/series 2023-04-13 
00:57:07.0 +0200
@@ -29,3 +29,4 @@
 cross_build_mysql.diff
 cast_types_for_egl_x11_test.diff
 revert_startBlocking_removal.d

Bug#1033996: unblock: brltty/6.5-7

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: brl...@packages.debian.org
Control: affects -1 + src:brltty

Hello,

I have uploaded brltty/6.5-7 to unstable, to make it hopefully included
in bookworm.

[ Reason ]
It was reported on
http://brltty.app/pipermail/brltty/2023-March/019836.html
that cursor routing is not working at all any more in X, because of a
crash in the routing process that 6.5-7 fixes.

[ Impact ]
Cursor routing is the way for blind users to be very efficient. Just
like we can click with the mouse wherever we want in some text to bring
the cursor there, when a blind user is reading some text they can press
a little button above the letter to bring the cursor there. Currently
the cursor doesn't move at all, and thus blind users have lost their way
to be very efficient at editing text.

The problem only affects X, not the Linux console, but more and more
blind users have to migrate to X environments since java-script-enabled
websites can nowaday only be browsed with e.g. firefox.

[ Tests ]
This was tested manually.

[ Risks ]
The code is very trivial: just check for the pointer before freeing the
underlying resource.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

[ Other info ]
I also included a small pending d-i translation.

unblock brltty/6.5-7
diff -Nru brltty-6.5/debian/changelog brltty-6.5/debian/changelog
--- brltty-6.5/debian/changelog 2022-12-06 22:25:48.0 +0100
+++ brltty-6.5/debian/changelog 2023-04-06 01:27:28.0 +0200
@@ -1,3 +1,13 @@
+brltty (6.5-7) unstable; urgency=medium
+
+  [ Remus-Gabriel Chelu ]
+  * po/ro.po: Add Romanian debconf translation (Closes: Bug#1031150).
+
+  [ Samuel Thibault ]
+  * patches/atspi2-routing-crash.patch: Fix crash on cursor routing call.
+
+ -- Samuel Thibault   Thu, 06 Apr 2023 01:27:28 +0200
+
 brltty (6.5-6) unstable; urgency=medium
 
   * initramfs/hooks/brltty.in: Copy over brltty preferences into initramfs.
diff -Nru brltty-6.5/debian/patches/atspi2-routing-crash.patch 
brltty-6.5/debian/patches/atspi2-routing-crash.patch
--- brltty-6.5/debian/patches/atspi2-routing-crash.patch1970-01-01 
01:00:00.0 +0100
+++ brltty-6.5/debian/patches/atspi2-routing-crash.patch2023-04-06 
01:26:36.0 +0200
@@ -0,0 +1,40 @@
+commit 1d7515229f4283b2b6c1a74135be3eae2d9892cd
+Author: Samuel Thibault 
+Date:   Thu Apr 6 01:23:37 2023 +0200
+
+AtSpi2: Fix crash on routing request
+
+We would otherwise get, here with ubsan:
+
+brltty: report listener already registered: 5: a2CoreSelUpdated
+UndefinedBehaviorSanitizer:DEADLYSIGNAL
+==2087615==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 
0x (pc 0x56356b124850 bp 0x sp 0x7fcc4d9fdbd8 T2087615)
+==2087615==The signal is caused by a READ memory access.
+==2087615==Hint: address points to the zero page.
+#0 0x56356b124850 in unregisterReportListener 
/home/samy/brl/mielke-svn/brltty/Programs/./report.c:208:22
+#1 0x7fcc5233f0ab in destruct_AtSpi2Screen 
/home/samy/brl/mielke-svn/brltty/Drivers/Screen/AtSpi2/./a2_screen.c:1574:5
+#2 0x56356b15304d in destructRoutingScreen 
/home/samy/brl/mielke-svn/brltty/Programs/./scr.c:255:3
+#3 0x56356b1542e9 in startRoutingProcess 
/home/samy/brl/mielke-svn/brltty/Programs/./routing.c:498:9
+#4 0x56356b1542e9 in runRoutingThread 
/home/samy/brl/mielke-svn/brltty/Programs/./routing.c:543:17
+#5 0x56356b11f574 in runThreadFunction 
/home/samy/brl/mielke-svn/brltty/Programs/./thread.c:151:33
+#6 0x56356b11f857 in runThread 
/home/samy/brl/mielke-svn/brltty/Programs/./thread.c:46:18
+#7 0x7fcc4f9c8fd3 in start_thread nptl/./nptl/pthread_create.c:442:8
+#8 0x7fcc4fa4966b in clone3 
misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
+
+diff --git a/Drivers/Screen/AtSpi2/a2_screen.c 
b/Drivers/Screen/AtSpi2/a2_screen.c
+index d60a91c68..9d5ca1d23 100644
+--- a/Drivers/Screen/AtSpi2/a2_screen.c
 b/Drivers/Screen/AtSpi2/a2_screen.c
+@@ -1571,8 +1571,10 @@ destruct_AtSpi2Screen (void) {
+   brlttyDisableInterrupt();
+ #ifdef HAVE_PKG_X11
+   if (dpy) {
+-unregisterReportListener(coreSelUpdatedListener);
+-coreSelUpdatedListener = NULL;
++if (coreSelUpdatedListener) {
++  unregisterReportListener(coreSelUpdatedListener);
++  coreSelUpdatedListener = NULL;
++}
+ if (a2XWatch) {
+   asyncCancelRequest(a2XWatch);
+   a2XWatch = NULL;
diff -Nru brltty-6.5/debian/patches/series brltty-6.5/debian/patches/series
--- brltty-6.5/debian/patches/series2022-06-18 09:16:48.0 +0200
+++ brltty-6.5/debian/patches/series2023-04-06 01:26:36.0 +0200
@@ -2,3 +2,4 @@
 40-no-update-pot.patch
 41-java-bytecode-compat.patch
 disable-synth-callback.patch
+atspi2-routing

Bug#1033918: unblock: lios/2.7.2-5

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: l...@packages.debian.org
Control: affects -1 + src:lios

Hello,

I have uploaded lios/2.7.2-5 to unstable, to hopefully make it to
bookworm.

[ Reason ]
As reported on #990805 and #1033024, in the current version of lios when
opening the general preferences dialog box, lios stays stuck for a
couple minutes. This happens only when the espeak-ng package is
installed, in which case there are thousands of voices available for
the speech configuration part of this dialog box, thus making it very
long to load.

Upstream fixed the issue without telling me, we eventually found it was
fixed in a more recent upstream snapshot, and I picked up the upstream
commit for this, included in lios/2.7.2-5. The idea of the fix is to
separate the voices by language, so that the user first chooses among a
few hundred languages, and then chooses a voice person. This is enough
to make the dialog box load in a snap.

[ Impact ]
Without this new version, users will have to either remove the espeak-ng
package (but lios users are most often blind users so they do need it),
or they have to wait for several minutes when they want to change some
general preference.

[ Tests ]
This was tested manually as fixing the issue.

[ Risks ]
The code is relatively simple: in lios/speech.py, instead of having
list_voices return a plain list, it creates a dictionary sorted by
language. lios/preferences.py then contains an additional combobox, and
the logic is reworked around these to implement the two-step selection.

The upstream commit also includes selecting a default voice according to
the current locale. I prefered to avoid splitting it from the upstream
commit since the two parts seem related.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock lios/2.7.2-5
diff -Nru lios-2.7.2/debian/changelog lios-2.7.2/debian/changelog
--- lios-2.7.2/debian/changelog 2023-03-13 20:00:26.0 +0100
+++ lios-2.7.2/debian/changelog 2023-04-03 23:22:12.0 +0200
@@ -1,3 +1,10 @@
+lios (2.7.2-5) unstable; urgency=medium
+
+  * patches/preference-voice-list: Fix general preferences loading delay.
+(Closes: #990805, #1033024).
+
+ -- Samuel Thibault   Mon, 03 Apr 2023 23:22:12 +0200
+
 lios (2.7.2-4) unstable; urgency=medium
 
   * Upload fix to unstable, thanks Gunnar!
diff -Nru lios-2.7.2/debian/patches/preference-voice-list 
lios-2.7.2/debian/patches/preference-voice-list
--- lios-2.7.2/debian/patches/preference-voice-list 1970-01-01 
01:00:00.0 +0100
+++ lios-2.7.2/debian/patches/preference-voice-list 2023-04-03 
23:21:39.0 +0200
@@ -0,0 +1,232 @@
+commit 565afb783dc50d4ec7c9d1d6caf486c26f47d1fe
+Author: nalin.x.linux 
+Date:   Sun Aug 28 15:27:27 2022 +0530
+
+Preferences dialog startup fixed, speech person selection enabled, set 
default speech module and language using user's language
+
+---
+ lios/main.py|   10 -
+ lios/preferences.py |  104 
+++-
+ lios/speech.py  |   13 +-
+ 3 files changed, 112 insertions(+), 15 deletions(-)
+
+--- a/lios/main.py
 b/lios/main.py
+@@ -181,6 +181,7 @@ class linux_intelligent_ocr_solution():
+   #Load Preferences
+   self.preferences = preferences.lios_preferences()
+   self.preferences.set_from_file(macros.preferences_file_path)
++  self.preferences.set_default_speech_module_and_language()
+   self.preferences.set_avalable_scanner_drivers([ item.name for 
item in self.available_scanner_driver_list])
+   self.preferences.set_avalable_ocr_engines([ 
(item.name,item.get_available_languages())
+   
for item in self.available_ocr_engine_list ])
+@@ -1379,6 +1380,7 @@ pacman -S aspell-fr"""))
+ 
+   def restore_preferences(self,*data):
+   self.preferences.__init__()
++  self.preferences.set_default_speech_module_and_language()
+   self.make_preferences_effective()
+   self.notify_information(_("Preferences Restored"),0)
+   
+@@ -1441,8 +1443,12 @@ pacman -S aspell-fr"""))
+   self.is_reading = True
+   speaker = speech.Speech()
+   
speaker.set_output_module(speaker.list_output_modules()[self.preferences.speech_module])
+-  if(self.preferences.speech_module != -1 and 
len(speaker.list_voices()) > 1):
+-  
speaker.set_synthesis_voice(speaker.list_voices()[self.preferences.speech_language])
++  language_person_dict = 
speaker.get_language_person_dict()
++
++  if(se

Bug#1033476: unblock: lios/2.7.2-4

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: l...@packages.debian.org
Control: affects -1 + src:lios

Hello,

I have uploaded a fixed version of lios (thanks Gunnar Hjalmarsson!)

[ Reason ]
lios cannot start when gtk4 is installed, because lios is compatible
with gtk3 only, but was not specifying it to gi.

[ Impact ]
So a user would have to choose between installing applications depending
on gtk4 and installing lios.

[ Tests ]
It was tested manually and confirmed by the submitter.

[ Risks ]
The code is very trivial

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock lios/2.7.2-4
diff -Nru lios-2.7.2/debian/changelog lios-2.7.2/debian/changelog
--- lios-2.7.2/debian/changelog 2022-10-23 12:24:21.0 +0200
+++ lios-2.7.2/debian/changelog 2023-03-13 20:00:26.0 +0100
@@ -1,3 +1,17 @@
+lios (2.7.2-4) unstable; urgency=medium
+
+  * Upload fix to unstable, thanks Gunnar!
+
+ -- Samuel Thibault   Mon, 13 Mar 2023 20:00:26 +0100
+
+lios (2.7.2-3.1) experimental; urgency=medium
+
+  * Non-maintainer upload
+  * Use exact versions when importing Gtk and friends
+- Cherry picked upstream commit (closes: #1032895)
+
+ -- Gunnar Hjalmarsson   Mon, 13 Mar 2023 18:03:42 +0100
+
 lios (2.7.2-3) unstable; urgency=medium
 
   [ Samuel Thibault ]
diff -Nru lios-2.7.2/debian/patches/series lios-2.7.2/debian/patches/series
--- lios-2.7.2/debian/patches/series2020-02-09 00:13:30.0 +0100
+++ lios-2.7.2/debian/patches/series2023-03-13 19:57:48.0 +0100
@@ -1,2 +1,3 @@
 tesseract_langpath
 typo
+Use-exact-versions-when-importing-Gtk-and-friends.patch
diff -Nru 
lios-2.7.2/debian/patches/Use-exact-versions-when-importing-Gtk-and-friends.patch
 
lios-2.7.2/debian/patches/Use-exact-versions-when-importing-Gtk-and-friends.patch
--- 
lios-2.7.2/debian/patches/Use-exact-versions-when-importing-Gtk-and-friends.patch
   1970-01-01 01:00:00.0 +0100
+++ 
lios-2.7.2/debian/patches/Use-exact-versions-when-importing-Gtk-and-friends.patch
   2023-03-13 19:57:48.0 +0100
@@ -0,0 +1,274 @@
+From: Mikhail Rudenko 
+Date: Mon, 21 Jun 2021 21:29:30 +0300
+Subject: Use exact versions when importing Gtk and friends
+
+This is necessary in environments where Gtk-3 and Gtk-4 are both
+installed. Otherwise, multiple `AttributeError`s arise, e.g.
+
+```
+Traceback (most recent call last):
+  File "/usr/bin/lios", line 19, in 
+from lios.main import *
+  File "/usr/lib/python3.9/site-packages/lios/main.py", line 27, in 
+from lios import scanner, editor, imageview, cam, ocr, preferences, speech
+  File "/usr/lib/python3.9/site-packages/lios/editor.py", line 20, in 
+from lios.ui.gtk import text_view, tree_view, widget, dialog, 
file_chooser, containers, window
+  File "/usr/lib/python3.9/site-packages/lios/ui/gtk/widget.py", line 166, in 

+class Separator(Gtk.HSeparator):
+  File "/usr/lib/python3.9/site-packages/gi/overrides/__init__.py", line 32, 
in __getattr__
+return getattr(self._introspection_module, name)
+  File "/usr/lib/python3.9/site-packages/gi/module.py", line 123, in 
__getattr__
+raise AttributeError("%r object has no attribute %r" % (
+AttributeError: 'gi.repository.Gtk' object has no attribute 'HSeparator'
+```
+
+Origin: https://github.com/zendalona/lios/commit/73fc343c
+Bug-Debian: https://bugs.debian.org/1032895
+---
+ lios/cam.py | 5 +
+ lios/ui/gtk/about.py| 3 +++
+ lios/ui/gtk/containers.py   | 5 -
+ lios/ui/gtk/dialog.py   | 3 +++
+ lios/ui/gtk/drawing_area.py | 7 +--
+ lios/ui/gtk/file_chooser.py | 3 +++
+ lios/ui/gtk/icon_view.py| 4 
+ lios/ui/gtk/loop.py | 9 ++---
+ lios/ui/gtk/menu.py | 5 -
+ lios/ui/gtk/print_dialog.py | 3 +++
+ lios/ui/gtk/terminal.py | 3 +++
+ lios/ui/gtk/text_view.py| 3 +++
+ lios/ui/gtk/tree_view.py| 4 
+ lios/ui/gtk/widget.py   | 3 +++
+ lios/ui/gtk/window.py   | 4 
+ 15 files changed, 57 insertions(+), 7 deletions(-)
+
+diff --git a/lios/cam.py b/lios/cam.py
+index db0a06f..23087ad 100644
+--- a/lios/cam.py
 b/lios/cam.py
+@@ -16,6 +16,11 @@
+ #You should have received a copy of the GNU General Public License
+ #along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ ###
++
++import gi
++gi.require_version("Gtk", "3.0")
++gi.require_version('GstVideo', '1.0')
++
+ from gi.repository import GdkX11, GstVideo
+ from gi.repository import Gtk
+ from gi.repository import Gst
+diff --git a/lios/ui/gtk/about.py b/lios/ui/gtk/about.py
+index b98196c..cfd8e1e 100644
+--- a/lios/ui/gtk/about.py
 b/lios/ui/gtk/about

Bug#1033473: unblock: espeakup/1:0.90-13

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock
X-Debbugs-Cc: espea...@packages.debian.org
Control: affects -1 + src:espeakup

Hello,

I have uploaded version 1:0.90-13 of the espeakup package in unstable.

[ Reason ]
It introduces some more debugging logs in the debian installer, in case
several audio cards are detected, to make sure how the kernel calls
them, to make discussion about installation reports easier.

[ Impact ]
Without the change it will be less clear which cards the user has.
(it is quite common for blind users to have several sound cards)

[ Tests ]
It was tested manually.

[ Risks ]
The code is very trivial.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

Thanks!

unblock espeakup/1:0.90-13
diff -Nru espeakup-0.90/debian/changelog espeakup-0.90/debian/changelog
--- espeakup-0.90/debian/changelog  2022-11-29 01:13:54.0 +0100
+++ espeakup-0.90/debian/changelog  2023-03-08 00:09:40.0 +0100
@@ -1,3 +1,9 @@
+espeakup (1:0.90-13) unstable; urgency=medium
+
+  * espeakup-udeb.start: Log the number and ids of detected audio cards.
+
+ -- Samuel Thibault   Wed, 08 Mar 2023 00:09:40 +0100
+
 espeakup (1:0.90-12) unstable; urgency=medium
 
   * espeakup-udeb.restart: Avoid warning about missing mbrola voice in 
installer.
diff -Nru espeakup-0.90/debian/espeakup-udeb.start 
espeakup-0.90/debian/espeakup-udeb.start
--- espeakup-0.90/debian/espeakup-udeb.start2022-11-29 01:07:45.0 
+0100
+++ espeakup-0.90/debian/espeakup-udeb.start2023-03-08 00:06:48.0 
+0100
@@ -44,6 +44,8 @@
N=$(echo $IDS | wc -w)
 
echo "Found $N audio card(s)."
+   echo "Found $N audio card(s):" >> /var/log/espeakup.log
+   echo "$IDS" >> /var/log/espeakup.log
 
case $N in
1)

Re: Accepted wxwidgets3.2 3.2.2+dfsg-1 (source) into unstable

[Samuel Thibault]

Samuel Thibault, le lun. 13 févr. 2023 14:50:33 +0100, a ecrit:
> gregor herrmann, le lun. 13 févr. 2023 00:26:54 +0100, a ecrit:
> > On Mon, 13 Feb 2023 00:09:20 +0100, Cyril Brulebois wrote:
> > > Debian FTP Masters  (2023-02-11):
> > > > Format: 1.8
> > > > Date: Sat, 11 Feb 2023 13:15:16 -0500
> > > > Source: wxwidgets3.2
> > > > Architecture: source
> > > > Version: 3.2.2+dfsg-1
> > > > Distribution: unstable
> > > > Urgency: medium
> > > > Maintainer: wxWidgets Maintainers 
> > > > Changed-By: Scott Talbert 
> > > > Closes: 1028427
> > > > Changes:
> > > >  wxwidgets3.2 (3.2.2+dfsg-1) unstable; urgency=medium
> > > >  .
> > > >* d/watch: fix download URL when using GitHub API
> > > >* Update to new upstream release 3.2.2
> > > >* Add Breaks/Replaces to libwxgtk-gl3.2-1 (Closes: #1028427)
> > > 
> > > This seems to have made libalien-wxwidgets-perl uninstallable, as seen in
> > > my devel chroot but also for any systems, as mentioned on tracker:
> > >   https://tracker.debian.org/pkg/wxwidgets3.2
> > 
> > If we're lucky, a binNMU of libalien-wxwidgets-perl against
> > libwxgtk3.2-dev,libwxgtk-media3.2-dev 3.2.2 (and later of libwx-perl
> > against the rebuilt libalien-wxwidgets-perl) might be enough.
> > 
> > A local rebuild of libalien-wxwidgets-perl runs through, including
> > autopkgtests.
> > 
> > (I haven't tried the second step with libwx-perl.)
> 
> Building the two packages does fix the dependencies indeed.
> 
> Can these binnmus be scheduled please? So working on d-i doesn't stay
> stuck on this.
> 
> nmu libalien-wxwidgets-perl_0.69+dfsg-6 . ANY . unstable . -m "Rebuild 
> against libwxgtk3.2-dev 3.2.2+dfsg-1"

Thanks for this one, now installed :)


Now we need that one:

nmu libwx-perl_0.9932-8 . ANY . unstable . -m "Rebuild against libwxgtk3.2-dev 
3.2.2+dfsg-1"

Samuel

Re: Accepted wxwidgets3.2 3.2.2+dfsg-1 (source) into unstable

[Samuel Thibault]

gregor herrmann, le lun. 13 févr. 2023 00:26:54 +0100, a ecrit:
> On Mon, 13 Feb 2023 00:09:20 +0100, Cyril Brulebois wrote:
> > Debian FTP Masters  (2023-02-11):
> > > Format: 1.8
> > > Date: Sat, 11 Feb 2023 13:15:16 -0500
> > > Source: wxwidgets3.2
> > > Architecture: source
> > > Version: 3.2.2+dfsg-1
> > > Distribution: unstable
> > > Urgency: medium
> > > Maintainer: wxWidgets Maintainers 
> > > Changed-By: Scott Talbert 
> > > Closes: 1028427
> > > Changes:
> > >  wxwidgets3.2 (3.2.2+dfsg-1) unstable; urgency=medium
> > >  .
> > >* d/watch: fix download URL when using GitHub API
> > >* Update to new upstream release 3.2.2
> > >* Add Breaks/Replaces to libwxgtk-gl3.2-1 (Closes: #1028427)
> > 
> > This seems to have made libalien-wxwidgets-perl uninstallable, as seen in
> > my devel chroot but also for any systems, as mentioned on tracker:
> >   https://tracker.debian.org/pkg/wxwidgets3.2
> 
> If we're lucky, a binNMU of libalien-wxwidgets-perl against
> libwxgtk3.2-dev,libwxgtk-media3.2-dev 3.2.2 (and later of libwx-perl
> against the rebuilt libalien-wxwidgets-perl) might be enough.
> 
> A local rebuild of libalien-wxwidgets-perl runs through, including
> autopkgtests.
> 
> (I haven't tried the second step with libwx-perl.)

Building the two packages does fix the dependencies indeed.

Can these binnmus be scheduled please? So working on d-i doesn't stay
stuck on this.

nmu libalien-wxwidgets-perl_0.69+dfsg-6 . ANY . unstable . -m "Rebuild against 
libwxgtk3.2-dev 3.2.2+dfsg-1"

nmu libwx-perl_0.9932-8 . ANY . unstable . -m "Rebuild against libwxgtk3.2-dev 
3.2.2+dfsg-1"
with an extra depend on libalien-wxwidgets-perl (>= 0.69+dfsg-6+b1)

Samuel

Bug#1030264: bullseye-pu: package at-spi2-core/2.38.0-4+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu
X-Debbugs-Cc: at-spi2-c...@packages.debian.org
Control: affects -1 + src:at-spi2-core

[ Reason ]
stable is affected by bug #890833: under some conditions, the
at-spi2-core accessibility daemons don't manage to quit, and thus
on system shutdown, systemd stays stuck for 90s until giving up and
hard-killing it.

The exact conditions have not been determined, but anyway since there is
no state to save etc., it's fine with just killing it early, rather than
annoying users.

[ Impact ]
They may encounter a 90s delay on shutting down their computer.

[ Tests ]
As the conditions are rare, we couldn't test it.

[ Risks ]
The code is very trivial, it just sets a timeout.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
It just adds a TimeoutStopSec to the systemd unit. It sets it to 5s,
just like similar widgets of the gnome desktop.
diff -Nru at-spi2-core-2.38.0/debian/changelog 
at-spi2-core-2.38.0/debian/changelog
--- at-spi2-core-2.38.0/debian/changelog2021-04-22 13:10:24.0 
+0200
+++ at-spi2-core-2.38.0/debian/changelog2023-01-25 23:30:27.0 
+0100
@@ -1,3 +1,9 @@
+at-spi2-core (2.38.0-4+deb11u1) bullseye; urgency=medium
+
+  * patches/timeoutstop: Set stop timeout to 5s (Closes: #890833).
+
+ -- Samuel Thibault   Wed, 25 Jan 2023 23:30:27 +0100
+
 at-spi2-core (2.38.0-4) unstable; urgency=medium
 
   * Re-upload to get arch:all built on buildd.
diff -Nru at-spi2-core-2.38.0/debian/patches/series 
at-spi2-core-2.38.0/debian/patches/series
--- at-spi2-core-2.38.0/debian/patches/series   2021-04-22 00:09:27.0 
+0200
+++ at-spi2-core-2.38.0/debian/patches/series   2023-01-25 23:30:27.0 
+0100
@@ -3,3 +3,4 @@
 test_disable_teamspaces
 tests
 double-free
+timeoutstop
diff -Nru at-spi2-core-2.38.0/debian/patches/timeoutstop 
at-spi2-core-2.38.0/debian/patches/timeoutstop
--- at-spi2-core-2.38.0/debian/patches/timeoutstop  1970-01-01 
01:00:00.0 +0100
+++ at-spi2-core-2.38.0/debian/patches/timeoutstop  2023-01-25 
23:30:27.0 +0100
@@ -0,0 +1,27 @@
+commit 145f9c53ca9ed73d0edb39abac12141cd40a2526
+Author: Samuel Thibault 
+Date:   Wed Jan 25 20:07:12 2023 +0100
+
+at-spi-dbus-bus service: set stop timeout to 5s
+
+As reported on
+https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=890833
+
+sometimes the at-spi bus may hang, and system shutdown then gets stuck.
+We'd better avoid hanging the whole system shutdown just for this, and
+just wait for 5s, like many other gnome user service pieces.
+
+Of course, at-spi2-core shouldn't be getting stuck, but better avoid
+hurting people, which makes them tend to just disable accessibility...
+
+---
+ bus/at-spi-dbus-bus.service.in |1 +
+ 1 file changed, 1 insertion(+)
+
+--- a/bus/at-spi-dbus-bus.service.in
 b/bus/at-spi-dbus-bus.service.in
+@@ -5,3 +5,4 @@ Description=Accessibility services bus
+ Type=dbus
+ BusName=org.a11y.Bus
+ ExecStart=@libexecdir@/at-spi-bus-launcher
++TimeoutStopSec=5

Bug#1025204: bullseye-pu: package speech-dispatcher/0.10.2-2+deb11u2

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I'd like to have version 0.10.2-2+deb11u2 of speech-dispatcher uploaded
to bullseye.

[ Reason ]
As reported on

https://github.com/espeak-ng/espeak-ng/issues/1554

there is a longstanding buffer overflow issue in espeak-ng. It
appears to users as artifacts in the speech that makes it sometimes
less inteligible. But since they are due to a buffer overflow, the
consequences could actually be way worse, notably since in the context
of a screen reader using espeak-ng as speech synthesis, the data
produced in the buffer comes from e.g. whatever webpage that the user is
browsing, thus potential for security issues.

This is not a regression from oldstable, since the bug has basically
always been there.

[ Impact ]
If it is no included, users will still hear artifacts, and would also
potentially be exposed to security issues due to the buffer overflows.

[ Tests ]
We made manual tests that confirmed that the change fixes the issue.
We also confirmed the buffer overflow in espeak-ng's valgrind/asan CI.

[ Risks ]
The change is very trivial. It makes the speech synthesis processing a
bit more expensive, but that will be very lightweight.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
The patch simply lowers the audio buffer size from 3s to 300ms.

3s was originally chosen so that large chunks of audio are processed
at a time, but this is what is making espeak-ng overflow its synthesis
buffers.

The exact overflows should ideally be fixed in espeak-ng of course, but
apparently this will be very involved, and it is way simpler to just
make speech-dispatcher not request so large buffers. espeak-ng itself
defaults to 60ms, and on Windows NVDA uses 300ms and does not suffer
from buffer overflows. In practice, the overflows that we observed in

https://github.com/espeak-ng/espeak-ng/issues/1554

happens with buffer around 900ms. 300ms seems a fairly safe value while
being not too small so as to process not-so-small chunks of audio at a
time.

Samuel
diff --git a/debian/changelog b/debian/changelog
index 6fea892..b6120a2 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+speech-dispatcher (0.10.2-2+deb11u2) bullseye; urgency=medium
+
+  * patches/buffer_size: Reduce espeak buffer size to avoid synth artifacts.
+
+ -- Samuel Thibault   Wed, 30 Nov 2022 21:10:17 +0100
+
 speech-dispatcher (0.10.2-2+deb11u1) bullseye; urgency=medium
 
   * patches/generic-set-voice-name: Fix setting voice name for the generic
diff --git a/debian/patches/buffer_size b/debian/patches/buffer_size
new file mode 100644
index 000..2b13443
--- /dev/null
+++ b/debian/patches/buffer_size
@@ -0,0 +1,35 @@
+commit be4c3585ead45716b8f49300b50c30fdb6eee266
+Author: Alexander Epaneshnikov 
+Date:   Thu Nov 24 01:41:40 2022 +0300
+
+espeak: set buffer size to 300
+
+this fixes #793
+ref for buffer size: 
https://github.com/nvaccess/nvda/blob/a6fb2392083b5fa1bae926102135ad452746ad3c/source/synthDrivers/_espeak.py#L338
+
+diff --git a/config/modules/espeak-ng.conf b/config/modules/espeak-ng.conf
+index d02704e9..9677bc99 100644
+--- a/config/modules/espeak-ng.conf
 b/config/modules/espeak-ng.conf
+@@ -41,7 +41,7 @@ EspeakMaxRate 449
+ # -- Internal parameters --
+ 
+ # Number of ms of audio returned by the espeak callback function.
+-EspeakAudioChunkSize 3000
++EspeakAudioChunkSize 300
+ 
+ # Maximum number of samples to buffer in playback queue.
+ EspeakAudioQueueMaxSize 441000
+diff --git a/config/modules/espeak.conf b/config/modules/espeak.conf
+index 3abc422b..cbd453b7 100644
+--- a/config/modules/espeak.conf
 b/config/modules/espeak.conf
+@@ -41,7 +41,7 @@ EspeakMaxRate 449
+ # -- Internal parameters --
+ 
+ # Number of ms of audio returned by the espeak callback function.
+-EspeakAudioChunkSize 3000
++EspeakAudioChunkSize 300
+ 
+ # Maximum number of samples to buffer in playback queue.
+ EspeakAudioQueueMaxSize 441000
diff --git a/debian/patches/series b/debian/patches/series
index 1f09fb7..5619c8a 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -2,3 +2,4 @@ doc-figures
 systemd-debian
 mbrola-paths
 generic-set-voice-name
+buffer_size

Re: Status of Debian Installer Bookworm Alpha 1: 2 blockers

[Samuel Thibault]

Cyril Brulebois, le sam. 17 sept. 2022 02:21:27 +0200, a ecrit:
> Samuel Thibault  (2022-09-17):
> > Cyril Brulebois, le sam. 17 sept. 2022 01:41:52 +0200, a ecrit:
> > >   
> > > https://salsa.debian.org/installer-team/debian-installer/-/commit/23e4451d7132e3bac7bd589747a44a776ea69834
> > > 
> > > To get back on track with the release, I'm tempted to just revert that
> > > commit right away,
> > 
> > I have reverted it already :)
> > 
> > Discussion is going on in the corresponding MR, 
> > https://salsa.debian.org/installer-team/debian-installer/-/merge_requests/24
> 
> At this point, I'm not really interested in diving in each and every
> build-dep to figure out what makes sense and what doesn't. A partial
> revert that doesn't document what it reverts and what it doesn't…

All build-deps are reverted. The only pieces that I haven't reverted are
the no-op for normal builds:

+   -o APT::Architecture=$deb_host_arch \\

-ARCH=$(shell dpkg-architecture -qDEB_BUILD_ARCH)
+ARCH=$(shell dpkg-architecture -qDEB_HOST_ARCH)

Samuel

Re: Status of Debian Installer Bookworm Alpha 1: 2 blockers

[Samuel Thibault]

Hello,

Cyril Brulebois, le sam. 17 sept. 2022 01:41:52 +0200, a ecrit:
>   
> https://salsa.debian.org/installer-team/debian-installer/-/commit/23e4451d7132e3bac7bd589747a44a776ea69834
> 
> To get back on track with the release, I'm tempted to just revert that
> commit right away,

I have reverted it already :)

Discussion is going on in the corresponding MR, 
https://salsa.debian.org/installer-team/debian-installer/-/merge_requests/24

Samuel

Bug#1011287: bullseye-pu: package orca/3.38.2-2

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu

(the same was submitted for buster-pu)

[ Reason ]
The upload of webkit2gtk 2.36 into stable-sec and oldstable-sec
introduced severe accessibility regressions in stable and oldstable, the
upstream bug report is here:
https://gitlab.gnome.org/GNOME/orca/-/issues/244

[ Impact ]
This breaks structural navigation commands (“next/previous heading,
next/previous form field, list of all headings, list of all form fields,
etc., etc.”) which people use to make sense out of web pages which are
not making efforts to be accessible. It also breaks helper scripts that
Orca uses to make navigation smooth. In my tests, it was making Orca
completely silent in yelp for instance...

[ Tests ]
This was manually tested by usptream and in Debian.

[ Risks ]
The proposed changes come from upstream, and are very defensive, see the
attached changes and description below.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
git-webkitgtk1 just additionally accepts WebKitGTK as an alias for WebKitGtk,

git-webkitgtk2 catches an exception and logs a warning instead of making
orca completely silent.
diff -Nru orca-3.38.2/debian/changelog orca-3.38.2/debian/changelog
--- orca-3.38.2/debian/changelog2020-12-23 22:02:25.0 +0100
+++ orca-3.38.2/debian/changelog2022-05-19 15:50:44.0 +0200
@@ -1,3 +1,12 @@
+orca (3.38.2-2) bullseye; urgency=high
+
+  * debian/patches/git-webkitgtk1: Fix screen reading of webkitgtk 2.36 which
+changed its toolkit name
+  * debian/patches/git-webkitgtk2: Fix screen reading of webkitgtk 2.36 which
+doesn't implement Collection any more.
+
+ -- Samuel Thibault   Thu, 19 May 2022 15:50:44 +0200
+
 orca (3.38.2-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru orca-3.38.2/debian/patches/git-webkitgtk1 
orca-3.38.2/debian/patches/git-webkitgtk1
--- orca-3.38.2/debian/patches/git-webkitgtk1   1970-01-01 01:00:00.0 
+0100
+++ orca-3.38.2/debian/patches/git-webkitgtk1   2022-05-19 15:50:44.0 
+0200
@@ -0,0 +1,53 @@
+commit 957e11b3c232632ec0e781b5d765c3000bcd1fb4
+Author: Joanmarie Diggs 
+Date:   Tue May 17 12:21:11 2022 +0200
+
+Handle WebKitGtk's change in toolkit name casing
+
+WebKitGtk objects now expose the toolkit name as WebKitGTK. Our
+script mapping for toolkits should probably not be case sensitive.
+For the purpose of making newer releases of WebKitGtk still work
+with older, stable versions of Orca, this commit just handles
+the alternative casing for WebKitGtk.
+
+Note that in some cases (e.g. Yelp), native caret navigation via
+F7 does not seem to be reliably toggled. That is a feature of either
+the app or the toolkit; not of Orca. This commit does not impact that.
+
+See issue #244
+
+---
+ src/orca/script_manager.py  |3 +++
+ src/orca/scripts/toolkits/WebKitGtk/script_utilities.py |2 +-
+ 2 files changed, 4 insertions(+), 1 deletion(-)
+
+--- a/src/orca/script_manager.py
 b/src/orca/script_manager.py
+@@ -59,6 +59,8 @@ class ScriptManager:
+  'pluma': 'gedit',
+  'org.gnome.gedit': 'gedit',
+ }
++self._toolkitNames = \
++{'WebKitGTK': 'WebKitGtk'}
+ 
+ self.setActiveScript(None, "__init__")
+ self._desktop = pyatspi.Registry.getDesktop(0)
+@@ -135,6 +137,7 @@ class ScriptManager:
+ else:
+ attrs = dict([attr.split(':', 1) for attr in attributes])
+ name = attrs.get('toolkit', '')
++name = self._toolkitNames.get(name, name)
+ 
+ return name
+ 
+--- a/src/orca/scripts/toolkits/WebKitGtk/script_utilities.py
 b/src/orca/scripts/toolkits/WebKitGtk/script_utilities.py
+@@ -58,7 +58,7 @@ class Utilities(script_utilities.Utiliti
+ return False
+ 
+ attrs = self.objectAttributes(obj)
+-return attrs.get('toolkit', '') == 'WebKitGtk'
++return attrs.get('toolkit', '') in ['WebKitGtk', 'WebKitGTK']
+ 
+ def getCaretContext(self):
+ # TODO - JD: This is private, but it's only here temporarily until we
diff -Nru orca-3.38.2/debian/patches/git-webkitgtk2 
orca-3.38.2/debian/patches/git-webkitgtk2
--- orca-3.38.2/debian/patches/git-webkitgtk2   1970-01-01 01:00:00.0 
+0100
+++ orca-3.38.2/debian/patches/git-webkitgtk2   2022-05-19 15:50:44.0 
+0200
@@ -0,0 +1,43 @@
+commit e9d8a3e5faa71531a615002dc37bcfda12d15abb
+Author: Joanmarie Diggs 
+Date:   Tue May 17 14:14:09 2022 +0200
+
+Structural Navigation: Handle unimplemented collection interface error
+
+The collection interface is something applications and toolkits get
+"

Bug#1011286: buster-pu: package orca/3.30.1-2

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

(the same was submitted for bullseye-pu)

[ Reason ]
The upload of webkit2gtk 2.36 into stable-sec and oldstable-sec
introduced severe accessibility regressions in stable and oldstable, the
upstream bug report is here:
https://gitlab.gnome.org/GNOME/orca/-/issues/244

[ Impact ]
This breaks structural navigation commands (“next/previous heading,
next/previous form field, list of all headings, list of all form fields,
etc., etc.”) which people use to make sense out of web pages which are
not making efforts to be accessible. It also breaks helper scripts that
Orca uses to make navigation smooth. In my tests, it was making Orca
completely silent in yelp for instance...

[ Tests ]
This was manually tested by usptream and in Debian.

[ Risks ]
The proposed changes come from upstream, and are very defensive, see the
attached changes and description below.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
git-webkitgtk1 just additionally accepts WebKitGTK as an alias for WebKitGtk,

git-webkitgtk2 catches an exception and logs a warning instead of making
orca completely silent.
diff -Nru orca-3.30.1/debian/changelog orca-3.30.1/debian/changelog
--- orca-3.30.1/debian/changelog2018-10-20 12:36:06.0 +0200
+++ orca-3.30.1/debian/changelog2022-05-19 15:50:44.0 +0200
@@ -1,3 +1,12 @@
+orca (3.30.1-2) buster; urgency=high
+
+  * debian/patches/git-webkitgtk1: Fix screen reading of webkitgtk 2.36 which
+changed its toolkit name
+  * debian/patches/git-webkitgtk2: Fix screen reading of webkitgtk 2.36 which
+doesn't implement Collection any more.
+
+ -- Samuel Thibault   Thu, 19 May 2022 15:50:44 +0200
+
 orca (3.30.1-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru orca-3.30.1/debian/patches/git-webkitgtk1 
orca-3.30.1/debian/patches/git-webkitgtk1
--- orca-3.30.1/debian/patches/git-webkitgtk1   1970-01-01 01:00:00.0 
+0100
+++ orca-3.30.1/debian/patches/git-webkitgtk1   2022-05-19 15:50:44.0 
+0200
@@ -0,0 +1,53 @@
+commit 957e11b3c232632ec0e781b5d765c3000bcd1fb4
+Author: Joanmarie Diggs 
+Date:   Tue May 17 12:21:11 2022 +0200
+
+Handle WebKitGtk's change in toolkit name casing
+
+WebKitGtk objects now expose the toolkit name as WebKitGTK. Our
+script mapping for toolkits should probably not be case sensitive.
+For the purpose of making newer releases of WebKitGtk still work
+with older, stable versions of Orca, this commit just handles
+the alternative casing for WebKitGtk.
+
+Note that in some cases (e.g. Yelp), native caret navigation via
+F7 does not seem to be reliably toggled. That is a feature of either
+the app or the toolkit; not of Orca. This commit does not impact that.
+
+See issue #244
+
+---
+ src/orca/script_manager.py  |3 +++
+ src/orca/scripts/toolkits/WebKitGtk/script_utilities.py |2 +-
+ 2 files changed, 4 insertions(+), 1 deletion(-)
+
+--- a/src/orca/script_manager.py
 b/src/orca/script_manager.py
+@@ -56,6 +56,8 @@ class ScriptManager:
+  'mate-notification-daemon': 'notification-daemon',
+  'pluma':'gedit',
+ }
++self._toolkitNames = \
++{'WebKitGTK': 'WebKitGtk'}
+ 
+ self.setActiveScript(None, "__init__")
+ self._desktop = pyatspi.Registry.getDesktop(0)
+@@ -130,6 +132,7 @@ class ScriptManager:
+ else:
+ attrs = dict([attr.split(':', 1) for attr in attributes])
+ name = attrs.get('toolkit', '')
++name = self._toolkitNames.get(name, name)
+ 
+ return name
+ 
+--- a/src/orca/scripts/toolkits/WebKitGtk/script_utilities.py
 b/src/orca/scripts/toolkits/WebKitGtk/script_utilities.py
+@@ -61,7 +61,7 @@ class Utilities(script_utilities.Utiliti
+ attrs = dict([attr.split(':', 1) for attr in obj.getAttributes()])
+ except:
+ return False
+-return attrs.get('toolkit', '') == 'WebKitGtk'
++return attrs.get('toolkit', '') in ['WebKitGtk', 'WebKitGTK']
+ 
+ def getCaretContext(self):
+ # TODO - JD: This is private, but it's only here temporarily until we
diff -Nru orca-3.30.1/debian/patches/git-webkitgtk2 
orca-3.30.1/debian/patches/git-webkitgtk2
--- orca-3.30.1/debian/patches/git-webkitgtk2   1970-01-01 01:00:00.0 
+0100
+++ orca-3.30.1/debian/patches/git-webkitgtk2   2022-05-19 15:50:44.0 
+0200
@@ -0,0 +1,43 @@
+commit e9d8a3e5faa71531a615002dc37bcfda12d15abb
+Author: Joanmarie Diggs 
+Date:   Tue May 17 14:14:09 2022 +0200
+
+Structural Navigation: Handle unimplemented collection inter

Bug#1006192: bullseye-pu: package espeak-ng/1.50+dfsg-7+deb11u1

[Samuel Thibault]

Adam D. Barratt, le lun. 14 mars 2022 20:20:26 +, a ecrit:
> On Mon, 2022-02-21 at 00:07 +0100, Samuel Thibault wrote:
> > We tried to remove that sleep and it didn't seem to have any nasty
> > side effect. Upstream did commit the change and users are really
> > happy with the change that completely fixes the delay.
> 
> Does this have any impact on the udeb?

The same fix will be used there.

d-i doesn't usually spit out large amounts of text so the problem was
not really showing up there, the effect won't really be noticed.

Samuel

Bug#1006187: bullseye-pu: package espeakup/0.80-20+deb11u1

[Samuel Thibault]

Adam D. Barratt, le lun. 14 mars 2022 20:19:02 +, a ecrit:
> Control: tags -1 + confirmed d-i
> 
> On Sun, 2022-02-20 at 21:35 +0100, Samuel Thibault wrote:
> > Users have reported that when they are building large packages in
> > parallel, or generally loading the system a bit, the espeakup screen
> > reader becomes very laggy. This is because espeakup gets scheduled
> > only along other the parallel processes. Worse, if the system goes
> > OOM, espeakup might get killed by the OOM killer.
> > 
> > This is not a regression with respect to previous releases.
> > 
> > In the case of the brltty screen reader, we fixed this by making
> > brltty niced to -10 and its OOM score set to -900.
> 
> Does this have any impact on the udeb?

No because in d-i espeakup is started by hand, the systemd service file
is not installed in the .udeb.

d-i doesn't usually start large amounts of process in parallel so it's
not a problem there.

Samuel

Bug#1006192: bullseye-pu: package espeak-ng/1.50+dfsg-7+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I'd like to upload the attached changes to bullseye (already queued)

[ Reason ]
People have reported that when they work on the linux console with the
espeakup screen reader, if they e.g. cat a long file, and the reader
starts speaking it, and the user presses some key to interrupt the read,
the screen reader remains silent for several seconds before it speaks
anything again. That is because the speaking events for all the file
reading have still been queued and the speak cancellation just makes
them processed very quickly to flush the queue. Unfortunately there is a
little usleep(50ms) that is performed on each event processing. This is
a very old trick that was probably browntape-fixing some erroneous
condition. We tried to remove that sleep and it didn't seem to have any
nasty side effect. Upstream did commit the change and users are really
happy with the change that completely fixes the delay.

[ Impact ]
Any action that creates long outputs (catting a long file, running
dmesg, listing a long directory, etc.) introduce long latency even when
the user wants to stop the speaking.

[ Tests ]
This was tested manually by the reporters.

[ Risks ]
The code by itself is trivial. The sleep was probably meant to "fix"
something but it seems that that something doesn't exist any more.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
This just removes a spurious sleep.
diff -Nru espeak-ng-1.50+dfsg/debian/changelog 
espeak-ng-1.50+dfsg/debian/changelog
--- espeak-ng-1.50+dfsg/debian/changelog2020-08-02 01:26:35.0 
+0200
+++ espeak-ng-1.50+dfsg/debian/changelog2022-02-13 02:41:25.0 
+0100
@@ -1,3 +1,10 @@
+espeak-ng (1.50+dfsg-7+deb11u1) bullseye; urgency=medium
+
+  * patches/even-delay: Drop spurious 50ms delay while processing events, this
+adds potentially very long latency to canceling speech.
+
+ -- Samuel Thibault   Sun, 13 Feb 2022 02:41:25 +0100
+
 espeak-ng (1.50+dfsg-7) unstable; urgency=medium
 
   * patches/no-common: Fix build with gcc-10 (Closes: Bug#957181).
diff -Nru espeak-ng-1.50+dfsg/debian/patches/event-delay 
espeak-ng-1.50+dfsg/debian/patches/event-delay
--- espeak-ng-1.50+dfsg/debian/patches/event-delay  1970-01-01 
01:00:00.0 +0100
+++ espeak-ng-1.50+dfsg/debian/patches/event-delay  2022-02-13 
02:41:25.0 +0100
@@ -0,0 +1,29 @@
+https://github.com/espeak-ng/espeak-ng/pull/1077
+
+commit 977bff9a061fbd6b44835a6ce45ad887634ae068
+Author: Samuel Thibault 
+Date:   Sun Feb 13 02:54:00 2022 +0100
+
+event_notify: Remove spurious 50ms delay
+
+event_notify currently introduces an arbitrary 50ms delay between speech
+requests. This is usually unnoticed since it's small. But when
+cancelling a long series of events, they add up to potentially seconds
+of delays, while the user was precisely requesting to just cancel
+everything as fast as possible.
+
+This 50ms delay was probably meant to work around some issues elsewhere.
+If they are still there, they should be fixed, not worked around.
+
+diff --git a/src/libespeak-ng/event.c b/src/libespeak-ng/event.c
+index acf3a39e..5561fdbc 100644
+--- a/src/libespeak-ng/event.c
 b/src/libespeak-ng/event.c
+@@ -161,7 +161,6 @@ static void event_notify(espeak_EVENT *event)
+   events[0].type = espeakEVENT_SENTENCE;
+   my_callback(NULL, 0, events);
+   events[0].type = a_new_type;
+-  usleep(5);
+   }
+   my_callback(NULL, 0, events);
+   a_old_uid = event->unique_identifier;
diff -Nru espeak-ng-1.50+dfsg/debian/patches/series 
espeak-ng-1.50+dfsg/debian/patches/series
--- espeak-ng-1.50+dfsg/debian/patches/series   2020-04-18 22:16:12.0 
+0200
+++ espeak-ng-1.50+dfsg/debian/patches/series   2022-02-13 02:41:25.0 
+0100
@@ -6,3 +6,4 @@
 greek-rules
 fix-tests-bash
 no-common
+event-delay
diff -Nru espeak-ng-1.50+dfsg/debian/salsa-ci.yml 
espeak-ng-1.50+dfsg/debian/salsa-ci.yml
--- espeak-ng-1.50+dfsg/debian/salsa-ci.yml 1970-01-01 01:00:00.0 
+0100
+++ espeak-ng-1.50+dfsg/debian/salsa-ci.yml 2022-02-13 02:41:25.0 
+0100
@@ -0,0 +1,10 @@
+---
+include:
+  - https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/salsa-ci.yml
+  - 
https://salsa.debian.org/salsa-ci-team/pipeline/raw/master/pipeline-jobs.yml
+
+variables:
+  SALSA_CI_DISABLE_VERSION_BUMP: 1
+  RELEASE: bullseye
+
+# vim: ts=2 sw=2 et sts=2 ft=yaml

Bug#1006187: bullseye-pu: package espeakup/0.80-20+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I would like to upload the attached change to bullseye (already uploaded
to the queue).

[ Reason ]
Users have reported that when they are building large packages in
parallel, or generally loading the system a bit, the espeakup screen
reader becomes very laggy. This is because espeakup gets scheduled only
along other the parallel processes. Worse, if the system goes OOM,
espeakup might get killed by the OOM killer.

This is not a regression with respect to previous releases.

In the case of the brltty screen reader, we fixed this by making brltty
niced to -10 and its OOM score set to -900.

[ Impact ]
Users will keep seeing their screen reader potentially harmed by system
overload.

[ Tests ]
This was tested manually, and users reported that they can now load
their system without seeing the screen reader getting laggy.

[ Risks ]
The code is very trivial: two obvious lines of systemd service.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
This just sets the nice level to -10 and the OOM score to -900 for the
espeakup service.
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog  2021-04-04 14:33:26.0 +0200
+++ espeakup-0.80/debian/changelog  2022-01-08 16:59:23.0 +0100
@@ -1,3 +1,9 @@
+espeakup (1:0.80-20+deb11u1) stable; urgency=medium
+
+  * debian/espeakup.service: Protect espeakup from system overloads.
+
+ -- Samuel Thibault   Sat, 08 Jan 2022 16:59:23 +0100
+
 espeakup (1:0.80-20) unstable; urgency=medium
 
   * espeakup-udeb.finish-install: Carry over the alsa mixer levels into the
diff -Nru espeakup-0.80/debian/espeakup.service 
espeakup-0.80/debian/espeakup.service
--- espeakup-0.80/debian/espeakup.service   2020-04-29 02:48:49.0 
+0200
+++ espeakup-0.80/debian/espeakup.service   2022-01-08 16:59:23.0 
+0100
@@ -12,6 +12,8 @@
 ExecStart=/bin/sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V "${VOICE}"'
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=always
+Nice=-10
+OOMScoreAdjust=-900
 
 [Install]
 WantedBy=sound.target

Bug#995848: bullseye-pu: package brltty/6.3+dfsg-1+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu

Hello,

[ Reason ]
Bug#994729 was noticed only recently: when installing Debian with
sysvinit rather than systemd, Braille output wouldn't work in the X
session. This was probably already happening in the Stretch & Buster
releases. This is not a problem for systemd-based systems that already
have a fix since october 2016.

[ Impact ]
Blind users that use sysvinit-based Debian systems cannot use Braille
within X.

[ Tests ]
The original reporter of the bug tested the fix.

[ Risks ]
The code is trivial

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
The change simply makes the brltty sysvinit script wait for
local filesystems to be mounted before brltty can start, so that
/var/lib/BrlAPI is mounted and thus the BrlAPI socket is settled in the
right place, for polkit authentication to be working and thus the X
screen reader able to use it to display Braille output.
diff -Nru brltty-6.3+dfsg/debian/brltty.init brltty-6.3+dfsg/debian/brltty.init
--- brltty-6.3+dfsg/debian/brltty.init  2021-01-28 17:18:34.0 +0100
+++ brltty-6.3+dfsg/debian/brltty.init  2021-09-20 23:37:07.0 +0200
@@ -1,7 +1,7 @@
 #! /bin/sh
 ### BEGIN INIT INFO
 # Provides:  brltty
-# Required-Start:mountkernfs
+# Required-Start:mountkernfs $local_fs
 # Required-Stop: 
 # Should-Start:  udev
 # Should-Stop:
diff -Nru brltty-6.3+dfsg/debian/changelog brltty-6.3+dfsg/debian/changelog
--- brltty-6.3+dfsg/debian/changelog2021-01-28 17:45:12.0 +0100
+++ brltty-6.3+dfsg/debian/changelog2021-09-20 23:37:34.0 +0200
@@ -1,3 +1,11 @@
+brltty (6.3+dfsg-1+deb11u1) bullseye; urgency=medium
+
+  [ Gregory Nowak ]
+  * brltty.init: Make it wait for $local_fs, like the systemd service does.
+(Closes: Bug#994729)
+
+ -- Samuel Thibault   Mon, 20 Sep 2021 23:37:34 +0200
+
 brltty (6.3+dfsg-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru brltty-6.3+dfsg/debian/salsa-ci.yml 
brltty-6.3+dfsg/debian/salsa-ci.yml
--- brltty-6.3+dfsg/debian/salsa-ci.yml 2021-01-28 17:18:34.0 +0100
+++ brltty-6.3+dfsg/debian/salsa-ci.yml 2021-09-20 23:37:34.0 +0200
@@ -7,4 +7,7 @@
   # Disable reprotest until salsa-ci-team/pipeline#26 is resolved
   SALSA_CI_DISABLE_REPROTEST: 1
 
+  SALSA_CI_DISABLE_VERSION_BUMP: 1
+  RELEASE: bullseye
+
 # vim: ts=2 sw=2 et sts=2 ft=yaml

Bug#995062: bullseye-pu: package speech-dispatcher/0.10.2-2+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu

Hello,

[ Reason ]
We have recently noticed that one cannot choose between the various
mbrola speech synthesis voices in the orca screen reader.

This is not a regression from previous releases.

[ Impact ]
This prevents users from being able to switch between e.g. male/female
voices to efficiently mark different contents.

[ Tests ]
This was tested in a VM as well as on the end-user system where the bug
was noticed first.

[ Risks ]
The code is very simple: it just moves a single line of code, and adds a
few debugging prints to make sure this gets effect.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
The bug comes from the fact that there are several ways to specify the
voice to be used: either through language + voice type, or precise voice
name. The second way is of course very precise, but unfortunately it was
coming first, and thus overwritten by the other ways. The change is just
to use the voice name last, so that one takes precedence over the other
(more generic) types.
diff -Nru speech-dispatcher-0.10.2/debian/changelog 
speech-dispatcher-0.10.2/debian/changelog
--- speech-dispatcher-0.10.2/debian/changelog   2020-12-16 01:17:56.0 
+0100
+++ speech-dispatcher-0.10.2/debian/changelog   2021-09-19 15:55:15.0 
+0200
@@ -1,3 +1,10 @@
+speech-dispatcher (0.10.2-2+deb11u1) bullseye; urgency=medium
+
+  * patches/generic-set-voice-name: Fix setting voice name for the generic
+module.
+
+ -- Samuel Thibault   Sun, 19 Sep 2021 15:55:15 +0200
+
 speech-dispatcher (0.10.2-2) unstable; urgency=medium
 
   * speech-dispatcher: Handle moving configuration file from main package to
diff -Nru speech-dispatcher-0.10.2/debian/patches/generic-set-voice-name 
speech-dispatcher-0.10.2/debian/patches/generic-set-voice-name
--- speech-dispatcher-0.10.2/debian/patches/generic-set-voice-name  
1970-01-01 01:00:00.0 +0100
+++ speech-dispatcher-0.10.2/debian/patches/generic-set-voice-name  
2021-09-19 15:55:15.0 +0200
@@ -0,0 +1,41 @@
+commit 2aff49e3b8eb49dceb2c135025bc19cea6b0fd2e
+Author: Samuel Thibault 
+Date:   Sun Sep 19 15:52:31 2021 +0200
+
+generic: Set voice name after setting voice language and type
+
+E.g. when using various mbrola languages, we want to be able to specify
+a precise voice name. Setting the voice language/type after the voice
+name would override that choice.
+
+diff --git a/src/modules/generic.c b/src/modules/generic.c
+index 5072867d..b62cdb58 100644
+--- a/src/modules/generic.c
 b/src/modules/generic.c
+@@ -205,9 +205,9 @@ int module_speak(const gchar * data, size_t bytes, 
SPDMessageType msgtype)
+   DBG("Speaking when requested to write");
+   return 0;
+   }
+-  UPDATE_STRING_PARAMETER(voice.name, generic_set_synthesis_voice);
+   UPDATE_STRING_PARAMETER(voice.language, generic_set_language);
+   UPDATE_PARAMETER(voice_type, generic_set_voice);
++  UPDATE_STRING_PARAMETER(voice.name, generic_set_synthesis_voice);
+   UPDATE_PARAMETER(punctuation_mode, generic_set_punct);
+   UPDATE_PARAMETER(pitch, generic_set_pitch);
+   UPDATE_PARAMETER(pitch_range, generic_set_pitch_range);
+@@ -707,6 +707,7 @@ void generic_set_language(char *lang)
+ 
+ void generic_set_voice(SPDVoiceType voice)
+ {
++  DBG("Setting voice type %d", voice);
+   assert(generic_msg_language);
+   generic_msg_voice_str =
+   module_getvoice(generic_msg_language->code, voice);
+@@ -717,6 +718,7 @@ void generic_set_voice(SPDVoiceType voice)
+ 
+ void generic_set_synthesis_voice(char *name)
+ {
++  DBG("Setting voice name %s (%s)", name, msg_settings.voice.name);
+   assert(msg_settings.voice.name);
+   if (module_existsvoice(msg_settings.voice.name))
+   generic_msg_voice_str = msg_settings.voice.name;
diff -Nru speech-dispatcher-0.10.2/debian/patches/series 
speech-dispatcher-0.10.2/debian/patches/series
--- speech-dispatcher-0.10.2/debian/patches/series  2020-11-25 
00:43:56.0 +0100
+++ speech-dispatcher-0.10.2/debian/patches/series  2021-09-19 
15:55:15.0 +0200
@@ -1,3 +1,4 @@
 doc-figures
 systemd-debian
 mbrola-paths
+generic-set-voice-name

Bug#994023: buster-pu: package espeak-ng/1.49.2+dfsg-8+deb10u1

[Samuel Thibault]

Adam D. Barratt, le dim. 19 sept. 2021 11:08:25 +0100, a ecrit:
> On Fri, 2021-09-10 at 02:17 +0200, Samuel Thibault wrote:
> > [ Reason ]
> > Espeak-ng cannot drive the mbrola-fr4 speech synthesis voice if the
> > mbrola-fr1 package is not installed. This is because some of the mb-
> > fr4
> > espeak rules refer to the fr1 voice while they should be referring to
> > the fr4 voice. This was fixed some time ago in the newer espeak-ng
> > package, but the fix was not backported yet to buster.
> 
> This looks OK to me, but will need a KiBi-ack as espeak-ng produces a
> udeb; tagging and CCing appropriately.

FI the patched files are not shipped in the udeb :)

Samuel

Bug#994023: buster-pu: package espeak-ng/1.49.2+dfsg-8+deb10u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

Hello,

This is actually like #971944, but for espeak-ng (which is a newer
version of espeak that will eventually supersede it). Normally I
would have submitted them at the same time but it seems I missed doing
it.

[ Reason ]
Espeak-ng cannot drive the mbrola-fr4 speech synthesis voice if the
mbrola-fr1 package is not installed. This is because some of the mb-fr4
espeak rules refer to the fr1 voice while they should be referring to
the fr4 voice. This was fixed some time ago in the newer espeak-ng
package, but the fix was not backported yet to buster.

[ Impact ]
This was not a regression over previous distributions, but it's hard for
users to guess that espeak+mbrola-fr4 cannot work without the mbrola-fr1
package, I actually got hit by the issue in october 2020 and it took
me some time to realize the problem, even though I'm maintaining the
packages.

[ Tests ]
After installing speech-dispatcher, espeak-ng, and mbrola-fr4, but not
mbrola-fr1,

spd-say -O espeak-ng-mbrola-generic Bonjour

should be speaking "Bonjour"

I have just tested it in a buster chroot.

[ Risks ]
The change is trivial, as attached. It is already tested as working in
unstable and stable.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
They simply fix the fr1 reference into fr4.

Yes, the remaining reference to fr1_phtrans is on purpose, it is part of
the confusion between mbrola-fr1 and mbrola-fr4: fr1_phtrans is provided
by espeak-ng-data for both mbrola-fr1 and mbrola-fr4, it was actually
renamed to fr_phtrans in latest espeak-ng-data.
diff -Nru espeak-ng-1.49.2+dfsg/debian/changelog 
espeak-ng-1.49.2+dfsg/debian/changelog
--- espeak-ng-1.49.2+dfsg/debian/changelog  2018-11-14 00:01:43.0 
+0100
+++ espeak-ng-1.49.2+dfsg/debian/changelog  2021-09-10 01:34:50.0 
+0200
@@ -1,3 +1,10 @@
+espeak-ng (1.49.2+dfsg-8+deb10u1) buster; urgency=medium
+
+  * patches/mbrola-fr4: Fix using espeak with mbrola-fr4 when mbrola-fr1 is
+not installed.
+
+ -- Samuel Thibault   Fri, 10 Sep 2021 01:34:50 +0200
+
 espeak-ng (1.49.2+dfsg-8) unstable; urgency=medium
 
   * patches/fix-cancel: Do not open audio when audio speak mode is not
diff -Nru espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4 
espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4
--- espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4 1970-01-01 
01:00:00.0 +0100
+++ espeak-ng-1.49.2+dfsg/debian/patches/mbrola-fr4 2021-09-10 
01:34:34.0 +0200
@@ -0,0 +1,22 @@
+diff --git a/espeak-ng-data/voices/mb/mb-fr4 b/espeak-ng-data/voices/mb/mb-fr4
+index 8e3c392..6e459cc 100755
+--- a/espeak-ng-data/voices/mb/mb-fr4
 b/espeak-ng-data/voices/mb/mb-fr4
+@@ -5,5 +5,5 @@ gender female
+ dictrules 1
+ pitch 140 220
+ voicing 90
+-mbrola fr1 fr1_phtrans
++mbrola fr4 fr1_phtrans
+ 
+diff --git a/espeak-ng-data/voices/mb/mb-fr4-en 
b/espeak-ng-data/voices/mb/mb-fr4-en
+index 8126770..33817e5 100755
+--- a/espeak-ng-data/voices/mb/mb-fr4-en
 b/espeak-ng-data/voices/mb/mb-fr4-en
+@@ -5,5 +5,5 @@ gender female
+ dictrules 1
+ pitch 140 220
+ voicing 90
+-mbrola fr1 fr1_phtrans
++mbrola fr4 fr1_phtrans
+ 
diff -Nru espeak-ng-1.49.2+dfsg/debian/patches/series 
espeak-ng-1.49.2+dfsg/debian/patches/series
--- espeak-ng-1.49.2+dfsg/debian/patches/series 2018-11-13 01:17:49.0 
+0100
+++ espeak-ng-1.49.2+dfsg/debian/patches/series 2021-09-10 01:34:34.0 
+0200
@@ -6,3 +6,4 @@
 privacy
 lessgreat-punct
 nocancel
+mbrola-fr4

Bug#994022: bullseye-pu: package java-atk-wrapper/0.38.0-2+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

(this is the same content as for the buster update request for the same
package)

[ Reason ]
As reported on
https://lists.debian.org/debian-accessibility/2021/06/msg3.html
when from an Xorg sesssion one runs

systemctl lightdm restart

which thus restarts the X server, or when for some reason the X session
crashes and the user is back at the lightdm login screen, after logging
back in the java applications are not accessible with the Orca screen
reader.

This is because the user's dbus session bus survives the restart/crash,
which is on purpose as discussed in 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992990
and thus the accessibility at-spi stack survives the restart/crash,
which is fine for orca etc. but since a new X server is used, the
address of the at-spi stack is not stored any more as the AT_SPI_BUS
X root property. Non-java applications are fine with that since
nowadays they use the dbus session bus to find the at-spi stack bus.
java-atk-wrapper however was still not using that, and was still using
the AT_SPI_BUS X root property which is considered deprecated.

The proposed changes make java-atk-wrapper use the dbus session bus,
like other accessible applications. It is then not a problem any more
that the restarted user session has a new X server without the
AT_SPI_BUS X root property.

[ Impact ]
Whenever an X session crashes or lightdm is restarted, java applications
in the new user sessions are not accessible to blind people through the
Orca screen reader.

[ Tests ]
I tested it with some VMs on my laptop, and tested by the original
user reporter.

[ Risks ]
The code is quite simple, is committed upstream, and just follows the
current practice of all other accessible applicatoins.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
The code change the startup of java applications: if the AT_SPI_BUS X
root property is not found, they use dbus-send to achieve the standard
at-spi stack bus discovery.

[ Other info ]
This is the same request as for buster.
diff -Nru java-atk-wrapper-0.38.0/debian/changelog 
java-atk-wrapper-0.38.0/debian/changelog
--- java-atk-wrapper-0.38.0/debian/changelog2021-01-01 15:05:05.0 
+0100
+++ java-atk-wrapper-0.38.0/debian/changelog2021-08-26 02:50:17.0 
+0200
@@ -1,3 +1,9 @@
+java-atk-wrapper (0.38.0-2+deb11u1) bullseye; urgency=medium
+
+  * patches/dbus: Also detect at-spi through dbus.
+
+ -- Samuel Thibault   Thu, 26 Aug 2021 02:50:17 +0200
+
 java-atk-wrapper (0.38.0-2) unstable; urgency=medium
 
   [ Samuel Thibault ]
diff -Nru java-atk-wrapper-0.38.0/debian/patches/dbus 
java-atk-wrapper-0.38.0/debian/patches/dbus
--- java-atk-wrapper-0.38.0/debian/patches/dbus 1970-01-01 01:00:00.0 
+0100
+++ java-atk-wrapper-0.38.0/debian/patches/dbus 2021-08-26 02:50:17.0 
+0200
@@ -0,0 +1,50 @@
+commit 43576f265a16de8f1cd16c8a09d0e6a6006cbe3c
+Author: Samuel Thibault 
+Date:   Thu Aug 26 02:49:06 2021 +0200
+
+Also use dbus to detect accessibility being enabled
+
+This is required if for some reason the AT_SPI_BUS property is not set.
+That happens for instance if for some reason the dbus session bus (and thus
+the at-spi bus) is reused between X sessions.
+
+diff --git a/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in 
b/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
+index cb267fd..d91b985 100644
+--- a/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
 b/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
+@@ -32,6 +32,11 @@ import java.lang.management.*;
+ 
+ public class AtkWrapper {
+   static boolean accessibilityEnabled = false;
++  static void initAtk() {
++System.loadLibrary("atk-wrapper");
++if (AtkWrapper.initNativeLibrary())
++  accessibilityEnabled = true;
++  }
+   static {
+ try {
+   Process p = Runtime.getRuntime().exec("@XPROP@ -root");
+@@ -39,13 +44,20 @@ public class AtkWrapper {
+   String result;
+   while ((result = b.readLine()) != null) {
+ if (result.indexOf("AT_SPI_IOR") >= 0 || result.indexOf("AT_SPI_BUS") 
>= 0) {
+-  System.loadLibrary("atk-wrapper");
+-  if (AtkWrapper.initNativeLibrary())
+-accessibilityEnabled = true;
++  initAtk();
+   break;
+ }
+   }
+ 
++  if (!accessibilityEnabled) {
++p = Runtime.getRuntime().exec("dbus-send --session 
--dest=org.a11y.Bus --print-reply /org/a11y/bus org.a11y.Bus.GetAddress");
++b = new BufferedReader(new InputStreamReader (p.getInputStream ()));
++while ((b.readLine()) != null);
++p.waitFor();
++if (p.exitValue() == 0)

Bug#994021: buster-pu: package java-atk-wrapper/0.33.3-22+deb10u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

[ Reason ]
As reported on
https://lists.debian.org/debian-accessibility/2021/06/msg3.html
when from an Xorg sesssion one runs

systemctl lightdm restart

which thus restarts the X server, or when for some reason the X session
crashes and the user is back at the lightdm login screen, after logging
back in the java applications are not accessible with the Orca screen
reader.

This is because the user's dbus session bus survives the restart/crash,
which is on purpose as discussed in 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992990
and thus the accessibility at-spi stack survives the restart/crash,
which is fine for orca etc. but since a new X server is used, the
address of the at-spi stack is not stored any more as the AT_SPI_BUS
X root property. Non-java applications are fine with that since
nowadays they use the dbus session bus to find the at-spi stack bus.
java-atk-wrapper however was still not using that, and was still using
the AT_SPI_BUS X root property which is considered deprecated.

The proposed changes make java-atk-wrapper use the dbus session bus,
like other accessible applications. It is then not a problem any more
that the restarted user session has a new X server without the
AT_SPI_BUS X root property.

[ Impact ]
Whenever an X session crashes or lightdm is restarted, java applications
in the new user sessions are not accessible to blind people through the
Orca screen reader.

[ Tests ]
I tested it with some VMs on my laptop, and tested by the original
user reporter.

[ Risks ]
The code is quite simple, is committed upstream, and just follows the
current practice of all other accessible applicatoins.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
The code change the startup of java applications: if the AT_SPI_BUS X
root property is not found, they use dbus-send to achieve the standard
at-spi stack bus discovery.

[ Other info ]
I will also submit for a bullseye update.
diff -Nru java-atk-wrapper-0.33.3/debian/changelog 
java-atk-wrapper-0.33.3/debian/changelog
--- java-atk-wrapper-0.33.3/debian/changelog2019-04-04 22:51:05.0 
+0200
+++ java-atk-wrapper-0.33.3/debian/changelog2021-08-26 02:50:17.0 
+0200
@@ -1,3 +1,9 @@
+java-atk-wrapper (0.33.3-22+deb10u1) buster; urgency=medium
+
+  * patches/dbus: Also detect at-spi through dbus.
+
+ -- Samuel Thibault   Thu, 26 Aug 2021 02:50:17 +0200
+
 java-atk-wrapper (0.33.3-22) unstable; urgency=medium
 
   * patches/remove_component_listener: Fix memory leak (Closes: Bug#926420)
diff -Nru java-atk-wrapper-0.33.3/debian/patches/dbus 
java-atk-wrapper-0.33.3/debian/patches/dbus
--- java-atk-wrapper-0.33.3/debian/patches/dbus 1970-01-01 01:00:00.0 
+0100
+++ java-atk-wrapper-0.33.3/debian/patches/dbus 2021-08-26 02:50:17.0 
+0200
@@ -0,0 +1,50 @@
+commit 43576f265a16de8f1cd16c8a09d0e6a6006cbe3c
+Author: Samuel Thibault 
+Date:   Thu Aug 26 02:49:06 2021 +0200
+
+Also use dbus to detect accessibility being enabled
+
+This is required if for some reason the AT_SPI_BUS property is not set.
+That happens for instance if for some reason the dbus session bus (and thus
+the at-spi bus) is reused between X sessions.
+
+diff --git a/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in 
b/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
+index cb267fd..d91b985 100644
+--- a/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
 b/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
+@@ -32,6 +32,11 @@ import java.lang.management.*;
+ 
+ public class AtkWrapper {
+   static boolean accessibilityEnabled = false;
++  static void initAtk() {
++System.loadLibrary("atk-wrapper");
++if (AtkWrapper.initNativeLibrary())
++  accessibilityEnabled = true;
++  }
+   static {
+ try {
+   Process p = Runtime.getRuntime().exec("@XPROP@ -root");
+@@ -39,13 +44,20 @@ public class AtkWrapper {
+   String result;
+   while ((result = b.readLine()) != null) {
+ if (result.indexOf("AT_SPI_IOR") >= 0 || result.indexOf("AT_SPI_BUS") 
>= 0) {
+-  System.loadLibrary("atk-wrapper");
+-  if (AtkWrapper.initNativeLibrary())
+-accessibilityEnabled = true;
++  initAtk();
+   break;
+ }
+   }
+ 
++  if (!accessibilityEnabled) {
++p = Runtime.getRuntime().exec("dbus-send --session 
--dest=org.a11y.Bus --print-reply /org/a11y/bus org.a11y.Bus.GetAddress");
++b = new BufferedReader(new InputStreamReader (p.getInputStream ()));
++while ((b.readLine()) != null);
++p.waitFor();
++if (p.exitValue() == 0)

Bug#992978: buster-pu: package mbrola/3.3+dfsg-4+deb11u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: bullseye
User: release.debian@packages.debian.org
Usertags: pu

[ Reason ]
As of version 3.3, mbrola does not properly detect the end of file of
its input, and thus remains stuck when e.g. the espeakup daemon is
terminating and wants to cleanly terminate its mbrola child process.

This is a regression compared to buster, in which the relevant code was
quite different.

[ Impact ]
Restarting the espeakup screen reader daemon (e.g. at the very least on
upgrading from bullseye to bookworm) remains stuck, until systemd loses
patience (which takes a minute or so). In the meanwhile the computer is
speechless, thus unusable for the blind user.

[ Tests ]
This was tested manually in unstable.

[ Risks ]
The code is very simple.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
The do/while loop that keeps reading input data now breaks also when
feof(input) returns true.
diff -Nru mbrola-3.3+dfsg/debian/changelog mbrola-3.3+dfsg/debian/changelog
--- mbrola-3.3+dfsg/debian/changelog2021-01-01 17:16:15.0 +0100
+++ mbrola-3.3+dfsg/debian/changelog2021-08-25 22:20:51.0 +0200
@@ -1,3 +1,9 @@
+mbrola (3.3+dfsg-4+deb11u1) bullseye; urgency=medium
+
+  * patches/EOF: Fix detecting end of file.
+
+ -- Samuel Thibault   Wed, 25 Aug 2021 22:20:51 +0200
+
 mbrola (3.3+dfsg-4) unstable; urgency=medium
 
   * patches/flags: Fix passing hardening flags.
diff -Nru mbrola-3.3+dfsg/debian/patches/EOF mbrola-3.3+dfsg/debian/patches/EOF
--- mbrola-3.3+dfsg/debian/patches/EOF  1970-01-01 01:00:00.0 +0100
+++ mbrola-3.3+dfsg/debian/patches/EOF  2021-08-25 22:20:34.0 +0200
@@ -0,0 +1,24 @@
+https://github.com/numediart/MBROLA/pull/35
+
+commit 151763240cb170943e8cc050df8a1ae6347cb7bf
+Author: Samuel Thibault 
+Date:   Fri Aug 20 00:43:29 2021 +0200
+
+Fix detecting EOF
+
+fgets returns NULL on EOF as well, so we need to call feof to properly
+detect EOF.
+
+diff --git a/Parser/input_file.c b/Parser/input_file.c
+index eea2da2..ac3454d 100644
+--- a/Parser/input_file.c
 b/Parser/input_file.c
+@@ -38,7 +38,7 @@ static long readline_InputFile(Input* in, char *line, int 
size)
+ 
+   do
+   ret = fgets(line, size, (FILE*)in->self);
+-  while (ret == NULL && errno == EINTR);
++  while (ret == NULL && !feof((FILE*)in->self) && errno == EINTR);
+ 
+   return ret != NULL;
+ }
diff -Nru mbrola-3.3+dfsg/debian/patches/series 
mbrola-3.3+dfsg/debian/patches/series
--- mbrola-3.3+dfsg/debian/patches/series   2020-12-30 17:53:50.0 
+0100
+++ mbrola-3.3+dfsg/debian/patches/series   2021-08-25 22:20:34.0 
+0200
@@ -1,2 +1,3 @@
 intr
 flags
+EOF

Bug#990379: unblock: rdiff-backup/2.0.5-2

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Please unblock package rdiff-backup

rdiff-backup is a sort of rsync-like backup tool. It happens that the
version that will be shipped in Bullseye (2.0.5) has a network protocol
that is incompatible with that of the version that was shipped in Buster
(1.2.8). The details are in https://bugs.debian.org/975270

What I thus did was to upload a 2.0.5 version to buster-backports, so
that people can safely independently upgrade the rdiff-backup package on
all their buster systems, before upgrading their systems to bullseye at
their convenience.

[ Reason ]
The changes proposed here is just to explain this in the NEWS file.

[ Impact ]
If the NEWS entry is not added, the users will have to google out why
they got their backup broken, or worse, not notice that their backup got
broken.

[ Tests ]
[ Risks ]
This is a documentation-only change.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock rdiff-backup/2.0.5-2
diff -Nru rdiff-backup-2.0.5/debian/changelog 
rdiff-backup-2.0.5/debian/changelog
--- rdiff-backup-2.0.5/debian/changelog 2020-08-06 05:36:34.0 +0200
+++ rdiff-backup-2.0.5/debian/changelog 2021-06-27 22:47:12.0 +0200
@@ -1,3 +1,10 @@
+rdiff-backup (2.0.5-2) unstable; urgency=medium
+
+  * NEWS: Notify users that the network protocol of versions 1 and 2 of
+rdiff-backup are incompatible (Closes: #975270).
+
+ -- Samuel Thibault   Sun, 27 Jun 2021 22:47:12 +0200
+
 rdiff-backup (2.0.5-1) unstable; urgency=medium
 
   [ Otto Kekäläinen ]
diff -Nru rdiff-backup-2.0.5/debian/NEWS rdiff-backup-2.0.5/debian/NEWS
--- rdiff-backup-2.0.5/debian/NEWS  1970-01-01 01:00:00.0 +0100
+++ rdiff-backup-2.0.5/debian/NEWS  2021-06-27 22:47:12.0 +0200
@@ -0,0 +1,18 @@
+rdiff-backup (2.0.5-2) unstable; urgency=medium
+
+The network protocol of versions 1 and 2 of rdiff-backup are incompatible.
+This means that you must be running the same version (either 1 or 2) of
+rdiff-backup locally and remotely. Since Buster ships version 1.2.8 and
+Bullseye ships version 2.0.5, upgrading only the local system or only the
+remote system from Buster to Bullseye will break rdiff-backup runs between
+the two.
+
+For conveniency, version 2.0.5 of rdiff-backup is available in the
+buster-backports distribution, see https://backports.debian.org/
+This allows to first upgrade only the rdiff-backup package on Buster
+systems, and then independently upgrade systems to Bullseye at your
+convenience.
+
+ -- Samuel Thibault   Sun, 27 Jun 2021 22:47:12 +0200
+
+

Bug#987371: unblock: at-spi2-core/2.38.0-4

[Samuel Thibault]

Ah, formally speaking this would also need an ack for the d-i side.

Samuel

Samuel Thibault, le jeu. 22 avril 2021 18:33:05 +0200, a ecrit:
> Package: release.debian.org
> Severity: normal
> User: release.debian@packages.debian.org
> Usertags: unblock
> 
> Hello,
> 
> Please unblock package at-spi2-core
> 
> [ Reason ]
> The following bug report:
> https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/35
> explains that when using accerciser (the tool to investigate the
> accessibility of application), if one closes the application being
> investigated, accerciser crashes immediately. This is due to a missing
> unlink in the underlying at-spi2-core library, fixed by the proposed
> changes.
> 
> [ Impact ]
> People working on accessibility usually want to repeat
> stopping/restarting the application they hack on, and to avoid
> accerciser crashing they would have to remember to always switch
> accerciser toward another application before stopping/restarting their
> application. Or else have to restart accerciser each time. There is no
> real data loss here, but it's very inconvenient
> 
> [ Tests ]
> I could test by hand the behavior getting fixed, as well as the bug
> reporter. There is no automatic test covering that part of the code
> unfortunately, that is why it went mostly unnoticed so far.
> 
> [ Risks ]
> The code change is a one-liner, made by upstream.
> 
> [ Checklist ]
>   [X] all changes are documented in the d/changelog
>   [X] I reviewed all changes and I approve them
>   [X] attach debdiff against the package in testing
> 
> Thanks!
> 
> unblock at-spi2-core/2.38.0-4

> diff -Nru at-spi2-core-2.38.0/debian/changelog 
> at-spi2-core-2.38.0/debian/changelog
> --- at-spi2-core-2.38.0/debian/changelog  2020-09-12 23:07:32.0 
> +0200
> +++ at-spi2-core-2.38.0/debian/changelog  2021-04-22 13:10:24.0 
> +0200
> @@ -1,3 +1,16 @@
> +at-spi2-core (2.38.0-4) unstable; urgency=medium
> +
> +  * Re-upload to get arch:all built on buildd.
> +
> + -- Samuel Thibault   Thu, 22 Apr 2021 13:10:24 +0200
> +
> +at-spi2-core (2.38.0-3) unstable; urgency=medium
> +
> +  * patches/double-free: Fix double free. Fixes crash of accerciser when
> +closing an application.
> +
> + -- Samuel Thibault   Wed, 21 Apr 2021 23:44:28 +0200
> +
>  at-spi2-core (2.38.0-2) unstable; urgency=medium
>  
>* Upload to unstable.
> diff -Nru at-spi2-core-2.38.0/debian/patches/double-free 
> at-spi2-core-2.38.0/debian/patches/double-free
> --- at-spi2-core-2.38.0/debian/patches/double-free1970-01-01 
> 01:00:00.0 +0100
> +++ at-spi2-core-2.38.0/debian/patches/double-free2021-04-22 
> 00:09:27.0 +0200
> @@ -0,0 +1,24 @@
> +commit 0b551954386543e97370d97ea1b78dd096edb14e
> +Author: Mike Gorse 
> +Date:   Wed Apr 21 16:37:14 2021 -0500
> +
> +Fix double free when removing event listeners
> +
> +Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/35
> +
> +diff --git a/atspi/atspi-event-listener.c b/atspi/atspi-event-listener.c
> +index ca6828f..5455b58 100644
> +--- a/atspi/atspi-event-listener.c
>  b/atspi/atspi-event-listener.c
> +@@ -798,7 +798,10 @@ atspi_event_listener_deregister_from_callback 
> (AtspiEventListenerCB callback,
> +   DBusMessage *message, *reply;
> +   l = g_list_next (l);
> +   if (in_send)
> +-  pending_removals = g_list_append (pending_removals, e);
> ++  {
> ++pending_removals = g_list_remove (pending_removals, e);
> ++pending_removals = g_list_append (pending_removals, e);
> ++  }
> +   else
> + event_listeners = g_list_remove (event_listeners, e);
> +   for (i = 0; i < matchrule_array->len; i++)
> diff -Nru at-spi2-core-2.38.0/debian/patches/series 
> at-spi2-core-2.38.0/debian/patches/series
> --- at-spi2-core-2.38.0/debian/patches/series 2020-09-12 23:07:32.0 
> +0200
> +++ at-spi2-core-2.38.0/debian/patches/series 2021-04-22 00:09:27.0 
> +0200
> @@ -2,3 +2,4 @@
>  disable-test-that-needs-installed-dbus-service.patch
>  test_disable_teamspaces
>  tests
> +double-free

> ___
> Pkg-a11y-devel mailing list
> pkg-a11y-de...@alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-a11y-devel

Bug#987371: unblock: at-spi2-core/2.38.0-4

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Please unblock package at-spi2-core

[ Reason ]
The following bug report:
https://gitlab.gnome.org/GNOME/at-spi2-core/-/issues/35
explains that when using accerciser (the tool to investigate the
accessibility of application), if one closes the application being
investigated, accerciser crashes immediately. This is due to a missing
unlink in the underlying at-spi2-core library, fixed by the proposed
changes.

[ Impact ]
People working on accessibility usually want to repeat
stopping/restarting the application they hack on, and to avoid
accerciser crashing they would have to remember to always switch
accerciser toward another application before stopping/restarting their
application. Or else have to restart accerciser each time. There is no
real data loss here, but it's very inconvenient

[ Tests ]
I could test by hand the behavior getting fixed, as well as the bug
reporter. There is no automatic test covering that part of the code
unfortunately, that is why it went mostly unnoticed so far.

[ Risks ]
The code change is a one-liner, made by upstream.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

Thanks!

unblock at-spi2-core/2.38.0-4
diff -Nru at-spi2-core-2.38.0/debian/changelog 
at-spi2-core-2.38.0/debian/changelog
--- at-spi2-core-2.38.0/debian/changelog2020-09-12 23:07:32.0 
+0200
+++ at-spi2-core-2.38.0/debian/changelog2021-04-22 13:10:24.0 
+0200
@@ -1,3 +1,16 @@
+at-spi2-core (2.38.0-4) unstable; urgency=medium
+
+  * Re-upload to get arch:all built on buildd.
+
+ -- Samuel Thibault   Thu, 22 Apr 2021 13:10:24 +0200
+
+at-spi2-core (2.38.0-3) unstable; urgency=medium
+
+  * patches/double-free: Fix double free. Fixes crash of accerciser when
+closing an application.
+
+ -- Samuel Thibault   Wed, 21 Apr 2021 23:44:28 +0200
+
 at-spi2-core (2.38.0-2) unstable; urgency=medium
 
   * Upload to unstable.
diff -Nru at-spi2-core-2.38.0/debian/patches/double-free 
at-spi2-core-2.38.0/debian/patches/double-free
--- at-spi2-core-2.38.0/debian/patches/double-free  1970-01-01 
01:00:00.0 +0100
+++ at-spi2-core-2.38.0/debian/patches/double-free  2021-04-22 
00:09:27.0 +0200
@@ -0,0 +1,24 @@
+commit 0b551954386543e97370d97ea1b78dd096edb14e
+Author: Mike Gorse 
+Date:   Wed Apr 21 16:37:14 2021 -0500
+
+Fix double free when removing event listeners
+
+Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/35
+
+diff --git a/atspi/atspi-event-listener.c b/atspi/atspi-event-listener.c
+index ca6828f..5455b58 100644
+--- a/atspi/atspi-event-listener.c
 b/atspi/atspi-event-listener.c
+@@ -798,7 +798,10 @@ atspi_event_listener_deregister_from_callback 
(AtspiEventListenerCB callback,
+   DBusMessage *message, *reply;
+   l = g_list_next (l);
+   if (in_send)
+-  pending_removals = g_list_append (pending_removals, e);
++  {
++pending_removals = g_list_remove (pending_removals, e);
++pending_removals = g_list_append (pending_removals, e);
++  }
+   else
+ event_listeners = g_list_remove (event_listeners, e);
+   for (i = 0; i < matchrule_array->len; i++)
diff -Nru at-spi2-core-2.38.0/debian/patches/series 
at-spi2-core-2.38.0/debian/patches/series
--- at-spi2-core-2.38.0/debian/patches/series   2020-09-12 23:07:32.0 
+0200
+++ at-spi2-core-2.38.0/debian/patches/series   2021-04-22 00:09:27.0 
+0200
@@ -2,3 +2,4 @@
 disable-test-that-needs-installed-dbus-service.patch
 test_disable_teamspaces
 tests
+double-free

Bug#986367: unblock: espeakup/1:0.80-20

[Samuel Thibault]

Sebastian Ramacher, le mar. 06 avril 2021 21:43:50 +0200, a ecrit:
> >  apt-install espeakup alsa-utils || true
> >  
> > +mkdir -p /var/lock
> > +mkdir -p /var/lib/alsa
> > +if alsactl store
> > +then
> > +   cp /var/lib/alsa/asound.state /target/var/lib/alsa/ || true
> 
> Is /target/var/lib/alsa/ guaranteed to exist at this point or should it
> also be created?

The directory comes from alsa-utils, requested for installation just
above. If the directory doesn't exist it means that alsa-utils could not
be installed and thus copying the file will be useless anyway. That is
why if it fails then too bad, we can't do more anyway.

Samuel

Bug#986367: unblock: espeakup/1:0.80-20

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

I have uploaded the attach changes of espeakup to unstable, proposed for
inclusion for bullseye.

The complete discussion is on
https://lists.debian.org/debian-accessibility/2021/03/msg00019.html
which started with Bug#985666, currently assigned to pulseaudio.

[ Reason ]
During installation with speech synthesis enabled, users have the
capslock-1 / 2 keyboard shortcuts to change the volume of the sound card
used for synthesis. In the debian-installer context, these shortcuts not
only make espeakup change the synthesis volume for itself, but also the
global alsa mixer, to be sure to allow for the maximum volume that the
hardware can achieve. This level of control is however disabled in the
installed system, to avoid espeakup overriding users' fine-tuning in
amixer / alsamixer.

A user however reported that he didn't have sound in the installed
system, and we found out that this was because the sound level was too
low for him to hear, and the speakup shortcuts where not enough to get
it audible, precisely because in the installed system espeakup does not
change the global volume, which was too low.

The base problem is that the alsa-utils package sets volumes in the
installed system by default to 80%, which is considered not too high to
avoid breaking the user's ears, but apparently depending on the hardware
it can be too low for the user to be able to use the computer with a
speech synthesis and to even be able to raise the volume to make it
usable.

The proposed changes thus make espeakup running inside the installer
replicate the mixer settings into the installed system, so that the
volume levels that were reached through espeakup inside the installer
are pre-set for the reboot into the installed system to have them just
like during installation.

[ Impact ]
Without the change, depending on some hardware, users may see their
first reboot into the installed system with an inaudible speech
synthesis, making the installed system unusable.

[ Tests ]
I tested it by hand, and the user who reported the issue also tested it.

[ Risks ]
The code is basically 4 lines, and they are essentially either harmless
or their failing would be just ignored.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock espeakup/1:0.80-20

Thanks!
Samuel
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog  2020-11-09 20:39:46.0 +0100
+++ espeakup-0.80/debian/changelog  2021-04-04 14:33:26.0 +0200
@@ -1,3 +1,10 @@
+espeakup (1:0.80-20) unstable; urgency=medium
+
+  * espeakup-udeb.finish-install: Carry over the alsa mixer levels into the
+installed system.
+
+ -- Samuel Thibault   Sun, 04 Apr 2021 14:33:26 +0200
+
 espeakup (1:0.80-19) unstable; urgency=medium
 
   * patches/range: Really enable patch.
diff -Nru espeakup-0.80/debian/espeakup-udeb.finish-install 
espeakup-0.80/debian/espeakup-udeb.finish-install
--- espeakup-0.80/debian/espeakup-udeb.finish-install   2020-04-29 
02:48:49.0 +0200
+++ espeakup-0.80/debian/espeakup-udeb.finish-install   2021-04-04 
14:33:26.0 +0200
@@ -10,6 +10,13 @@
 
 apt-install espeakup alsa-utils || true
 
+mkdir -p /var/lock
+mkdir -p /var/lib/alsa
+if alsactl store
+then
+   cp /var/lib/alsa/asound.state /target/var/lib/alsa/ || true
+fi
+
 cp /usr/share/espeakup-udeb/espeakup.default /target/etc/default/espeakup
 sed -i -e "s/^VOICE=.*/VOICE=$VOICE/" /target/etc/default/espeakup
 [ -z "$ALSA_CARD" ] || sed -i -e "s/^# ALSA_CARD=.*/ALSA_CARD=\"$ALSA_CARD\"/" 
/target/etc/default/espeakup

Bug#985475: unblock: starpu/1.3.7+dfsg-3

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Please unblock package starpu

[ Reason ]
#985436 reported a broken symlink in libstarpu-dev which is due to a
mere missing dependency.

[ Impact ]
Without it, the user has to install the libstarpurm-1.3-1 binary package
by hand in addition to libstarpu-dev, so as to be able to link with
-lstarpurm

[ Tests ]
Issue detected by piupart, seen as fixed by piuparts.

[ Risks ]
Code is trivial: just an additional dependency that should have been
there from the start.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock starpu/1.3.7+dfsg-3
diff -Nru starpu-1.3.7+dfsg/debian/changelog starpu-1.3.7+dfsg/debian/changelog
--- starpu-1.3.7+dfsg/debian/changelog  2021-01-16 13:37:36.0 +0100
+++ starpu-1.3.7+dfsg/debian/changelog  2021-03-18 22:50:37.0 +0100
@@ -1,3 +1,10 @@
+starpu (1.3.7+dfsg-3) unstable; urgency=medium
+
+  * control: Make libstarpu-dev depend on libstarpurm-1.3-1
+(Closes: Bug#985436).
+
+ -- Samuel Thibault   Thu, 18 Mar 2021 22:50:37 +0100
+
 starpu (1.3.7+dfsg-2) unstable; urgency=medium
 
   * control: Fix libstarpurm providing libstarpu-anyrm.
diff -Nru starpu-1.3.7+dfsg/debian/control starpu-1.3.7+dfsg/debian/control
--- starpu-1.3.7+dfsg/debian/control2020-12-31 14:48:16.0 +0100
+++ starpu-1.3.7+dfsg/debian/control2021-03-18 22:49:38.0 +0100
@@ -30,7 +30,7 @@
 Package: libstarpu-dev
 Section: libdevel
 Architecture: any
-Depends: libstarpu-1.3-5 (= ${binary:Version}) | libstarpu-any-1.3-5, 
libstarpufft-1.3-2 (= ${binary:Version}) | libstarpu-anyfft-1.3-2, 
libstarpumpi-1.3-3 (= ${binary:Version}) | libstarpu-anympi-1.3-3, 
libsocl-1.3-0 (= ${binary:Version}) | libsocl-any-1.3-0, ${misc:Depends}, 
libhwloc-dev, opencl-headers, ocl-icd-opencl-dev
+Depends: libstarpu-1.3-5 (= ${binary:Version}) | libstarpu-any-1.3-5, 
libstarpufft-1.3-2 (= ${binary:Version}) | libstarpu-anyfft-1.3-2, 
libstarpumpi-1.3-3 (= ${binary:Version}) | libstarpu-anympi-1.3-3, 
libsocl-1.3-0 (= ${binary:Version}) | libsocl-any-1.3-0, libstarpurm-1.3-1 (= 
${binary:Version}) | libstarpu-anyrm-1.3-1, ${misc:Depends}, libhwloc-dev, 
opencl-headers, ocl-icd-opencl-dev
 Conflicts: libstarpu-contrib-dev
 Provides: libstarpu-any-dev
 Description: Task scheduler for heterogeneous multicore machines - dev

Bug#985274: unblock: hwloc-contrib/2.4.1+dfsg-2

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package hwloc-contrib

[ Reason ]
hwloc-contrib currently FTBFS due to #984984 : nvidia-alternative fixed
providing libnvidia-ml.so, and thus hwloc-contrib is now able to build
its nvml plugin but dh_missing complains that it was not configured to.

In the hwloc-contrib/2.4.1+dfsg-2 upload, I re-enabled installing
the nvml plugin, as the attached patch shows.

[ Impact ]
Without the nvml plugin, it is harder for hwloc-based applications to
determine the locality of GPUs in the system, and thus to optimize data
transfers and get efficient execution.

[ Tests ]
I have tested it on a system that has GPUs, the nvml location is
correct.

[ Risks ]
The code change is trivial :)
The consequence for systems without a GPU is just an nvmlInit() call
that will report that there is no nvml device. For systems with a GPU,
the nvml plugin just gets information from libnvidia-ml and stores it
for applications that would want it.

Alternatively, we could mark the nvml plugin as not-installed.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock hwloc-contrib/2.4.1+dfsg-2
diff -Nru hwloc-contrib-2.4.1+dfsg/debian/changelog 
hwloc-contrib-2.4.1+dfsg/debian/changelog
--- hwloc-contrib-2.4.1+dfsg/debian/changelog   2021-02-22 18:21:18.0 
+0100
+++ hwloc-contrib-2.4.1+dfsg/debian/changelog   2021-03-11 16:01:54.0 
+0100
@@ -1,3 +1,10 @@
+hwloc-contrib (2.4.1+dfsg-2) unstable; urgency=medium
+
+  * libhwloc-contrib-plugins.install: Install the nvml plugin again
+(Closes: Bug#984984)
+
+ -- Samuel Thibault   Thu, 11 Mar 2021 16:01:54 +0100
+
 hwloc-contrib (2.4.1+dfsg-1) unstable; urgency=medium
 
   * New upstream bugfix release.
diff -Nru hwloc-contrib-2.4.1+dfsg/debian/libhwloc-contrib-plugins.install 
hwloc-contrib-2.4.1+dfsg/debian/libhwloc-contrib-plugins.install
--- hwloc-contrib-2.4.1+dfsg/debian/libhwloc-contrib-plugins.install
2021-02-22 18:21:18.0 +0100
+++ hwloc-contrib-2.4.1+dfsg/debian/libhwloc-contrib-plugins.install
2021-03-11 16:01:54.0 +0100
@@ -1 +1,2 @@
 usr/lib/*/hwloc/hwloc_cuda.so
+usr/lib/*/hwloc/hwloc_nvml.so

Bug#985204: unblock: pyatspi/2.38.1-1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

I have uploaded the upstream bugfix version 2.38.1.

I'm sorry I didn't realize "key package" was spanning quite large, so
that update won't auto-propagate without explicit unblock, I thought
it would auto-propagate so just went on with packaging the new version
rather than just applying the fix (that said the new upstream version
contains only the fix, so it's possibly better to have the new upstream
version, so that users don't erroneously think that Debian doesn't have
the fix).

[ Reason ]
This version fixes (and brings actual code changes only for that):

https://gitlab.gnome.org/GNOME/pyatspi2/-/issues/6
https://gitlab.gnome.org/GNOME/pyatspi2/-/issues/7

[ Impact ]
Without it, blind users using orca can get completely stuck in the
situation mentioned in the bugs:

- Launch cawbird (a twitter client)
- Tab amongst links in the timeline

That alone completely hangs the Orca screen reader, leaving the whole
desktop unusable for the blind user, who basically has not choice but
reboot.

[ Tests ]
pyatspi has a full testsuite showing up as "runtests.sh" in the build
logs.

[ Risks ]
The change is actually trivial.

For reference I have attached the debdiff (called patch-complete),
but most of it is upstream update from autoconf 1.16.2 to 1.16.3. The
attached diff (called patch) is the content of the source after only
the dh_autoreconf step which thus normalizes the autoconf version,
and thus in which the autoconf part only shows the upstream version
number change. In the attached patch-realchange, I stripped the autoconf
upstream version number changes to show the real meat which boils down
to making a while loop never able to be infinite (twice):

@@ -296,7 +296,8 @@
 if acc is None:
 # guard against bad start condition
 return None
-while 1:
+tries = 0
+while tries < 100:
 if acc.parent is None:
 # stop if there is no parent and we haven't returned 
yet
 return None
@@ -306,6 +307,8 @@
 pass
 # move to the parent
 acc = acc.parent
+tries = tries + 1
+return None

 def getPath(acc):
 """

As a technical note: the problem here is with applications which have a
complex structure with parent/child relations that happen in a loop. The
100 limit means it won't support application that have more than 100
widget nesting levels, which I have never seen (usually at most 15-20).

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock pyatspi/2.38.1-1
diff -Nru pyatspi-2.38.0/aclocal.m4 pyatspi-2.38.1/aclocal.m4
--- pyatspi-2.38.0/aclocal.m4   2020-09-12 21:25:54.0 +0200
+++ pyatspi-2.38.1/aclocal.m4   2021-03-13 22:36:26.0 +0100
@@ -1,4 +1,4 @@
-# generated automatically by aclocal 1.16.2 -*- Autoconf -*-
+# generated automatically by aclocal 1.16.3 -*- Autoconf -*-
 
 # Copyright (C) 1996-2020 Free Software Foundation, Inc.
 
@@ -9407,7 +9407,7 @@
 [am__api_version='1.16'
 dnl Some users find AM_AUTOMAKE_VERSION and mistake it for a way to
 dnl require some minimum version.  Point them to the right macro.
-m4_if([$1], [1.16.2], [],
+m4_if([$1], [1.16.3], [],
   [AC_FATAL([Do not call $0, use AM_INIT_AUTOMAKE([$1]).])])dnl
 ])
 
@@ -9423,7 +9423,7 @@
 # Call AM_AUTOMAKE_VERSION and AM_AUTOMAKE_VERSION so they can be traced.
 # This function is AC_REQUIREd by AM_INIT_AUTOMAKE.
 AC_DEFUN([AM_SET_CURRENT_AUTOMAKE_VERSION],
-[AM_AUTOMAKE_VERSION([1.16.2])dnl
+[AM_AUTOMAKE_VERSION([1.16.3])dnl
 m4_ifndef([AC_AUTOCONF_VERSION],
   [m4_copy([m4_PACKAGE_VERSION], [AC_AUTOCONF_VERSION])])dnl
 _AM_AUTOCONF_VERSION(m4_defn([AC_AUTOCONF_VERSION]))])
@@ -9836,7 +9836,7 @@
 [_AM_SET_OPTIONS([$1])dnl
 dnl Diagnose old-style AC_INIT with new-style AM_AUTOMAKE_INIT.
 m4_if(
-  m4_ifdef([AC_PACKAGE_NAME], [ok]):m4_ifdef([AC_PACKAGE_VERSION], [ok]),
+  m4_ifset([AC_PACKAGE_NAME], [ok]):m4_ifset([AC_PACKAGE_VERSION], [ok]),
   [ok:ok],,
   [m4_fatal([AC_INIT should be called with package and version arguments])])dnl
  AC_SUBST([PACKAGE], ['AC_PACKAGE_TARNAME'])dnl
@@ -10075,12 +10075,7 @@
 [AC_REQUIRE([AM_AUX_DIR_EXPAND])dnl
 AC_REQUIRE_AUX_FILE([missing])dnl
 if test x"${MISSING+set}" != xset; then
-  case $am_aux_dir in
-  *\ * | *\*)
-MISSING="\${SHELL} \"$am_aux_dir/missing\"" ;;
-  *)
-MISSING="\${SHELL} $am_aux_dir/missing" ;;
-  esac
+  MISSING="\${SHELL} '$am_aux_dir/missing'"
 fi
 # Use eval to expand $SHELL
 if eval "$MISSING --is-lightweight"; then
@@ -10252,12 +10247,14 @@
 m4_default([$3], [AC_MSG_ERROR([no suitable Python interpreter found])])
   else
 
-  dnl Query Python for its version number.  Getting [:3] seems to be
-  dnl the best 

Bug#984899: buster-pu: package hwloc-contrib/1.11.12-3+deb10u1

[Samuel Thibault]

Adam D. Barratt, le mer. 10 mars 2021 21:25:27 +, a ecrit:
> On Wed, 2021-03-10 at 01:32 +0100, Samuel Thibault wrote:
> > I have uploaded a proposed 1.11.12-3+deb10u1 version of hwloc-contrib
> > for buster.
> 
> The amd64 package that was uploaded appears to have been built either
> on a system with backports enabled, or outside of a stable chroot -

Ah, yes, that was supposed to be the easy part since on my own machine,
but I must have picked the wrong chroot.

> I've just flagged that upload for rejection on that basis.

Thanks!

I have re-uploaded a fixed version. The .buildinfo files do show
packages coming from buster now.

Samuel

Bug#984899: buster-pu: package hwloc-contrib/1.11.12-3+deb10u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I have uploaded a proposed 1.11.12-3+deb10u1 version of hwloc-contrib
for buster.

[ Reason ]
PowerPC systems provide much better bandwidth between CPUs and NVIDIA
GPUs thanks to NVLink, they are thus currently very often used for
running NVIDIA GPUs (top500.org has a lot of them for instance). But
hwloc currently does not show NVIDIA GPUs on ppc64el because the
hwloc-contrib package is not getting built there.  This makes it much
harder for applications to determine the locality of GPUs in the system
and thus where to place data etc. to get efficient execution.

This is not a regression over oldstable, which did not have it built on
ppc64el either.

[ Impact ]
If this isn't included, people will have to build hwloc by hand to get
the locality information and thus efficient execution.

[ Tests ]
The hwloc-contrib package has a full testsuite which I could run on a
ppc64el system.

[ Risks ]
There is no risk for the only other arch (amd64), because the change
disables the libcuda1 build-dep only on ppc64el, and it drops libcuda
from the link of a test which is not getting shipped anyway.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
There is no libcuda1 on ppc64el, so this dependency had to be disabled.
This disables one test (cuda), but otherwise the functionalities of the
built package are the same.

The cudart test used to be linked against libcuda, but that was actually
spurious, upstream doesn't link it against libcuda any more since a long
time actually.

With regards,
Samuel
diff -Nru hwloc-contrib-1.11.12/debian/changelog 
hwloc-contrib-1.11.12/debian/changelog
--- hwloc-contrib-1.11.12/debian/changelog  2019-02-09 00:46:55.0 
+0100
+++ hwloc-contrib-1.11.12/debian/changelog  2021-03-10 00:22:29.0 
+0100
@@ -1,3 +1,11 @@
+hwloc-contrib (1.11.12-3+deb10u1) buster; urgency=medium
+
+  * control: Enable build on ppc64el with libcuda1 build-dep disabled.
+  * patches/cuda-ppc64el: Upstream fix for cudart test that does not actually
+need libcuda1.
+
+ -- Samuel Thibault   Wed, 10 Mar 2021 00:22:29 +0100
+
 hwloc-contrib (1.11.12-3) unstable; urgency=medium
 
   * control: Add libcuda1 dependency, not brought by nvidia-cuda-dev any more.
diff -Nru hwloc-contrib-1.11.12/debian/control 
hwloc-contrib-1.11.12/debian/control
--- hwloc-contrib-1.11.12/debian/control2019-02-09 00:46:06.0 
+0100
+++ hwloc-contrib-1.11.12/debian/control2021-03-09 23:55:17.0 
+0100
@@ -3,7 +3,7 @@
 Maintainer: Samuel Thibault 
 Build-Depends: debhelper (>= 9), libltdl-dev,
   valgrind [amd64 arm64 armhf i386 mips mipsel powerpc ppc64el s390x mips64el 
ppc64],
-  libx11-dev, libxext-dev, nvidia-cuda-dev, libcuda1, libxnvctrl-dev,
+  libx11-dev, libxext-dev, nvidia-cuda-dev, libcuda1 [!ppc64el], 
libxnvctrl-dev,
   libpciaccess-dev, pkg-config,
   libibverbs-dev [linux-any],
   ocl-icd-opencl-dev [!hurd-i386] | opencl-dev, opencl-headers,
@@ -18,7 +18,7 @@
 Vcs-Browser: https://github.com/open-mpi/hwloc-debian/tree/contrib
 
 Package: libhwloc-contrib-plugins
-Architecture: amd64
+Architecture: amd64 ppc64el
 Multi-Arch: same
 Depends: ${shlibs:Depends}, ${misc:Depends}, libhwloc5 (>= 
${source:Upstream-Version}~), libhwloc5 (<< ${source:Upstream-Version}A)
 Description: Hierarchical view of the machine - contrib plugins
diff -Nru hwloc-contrib-1.11.12/debian/patches/cuda-ppc64el 
hwloc-contrib-1.11.12/debian/patches/cuda-ppc64el
--- hwloc-contrib-1.11.12/debian/patches/cuda-ppc64el   1970-01-01 
01:00:00.0 +0100
+++ hwloc-contrib-1.11.12/debian/patches/cuda-ppc64el   2021-03-10 
00:21:15.0 +0100
@@ -0,0 +1,21 @@
+commit 542fb5677723e13980056ea5f1023b5120bd2e0d
+Author: Samuel Thibault 
+Date:   Wed Mar 10 00:20:05 2021 +0100
+
+tests/cudart: Do not link against libcuda
+
+ppc64el doesn't have libcuda and the cudart test does not need it anyway.
+
+diff --git a/tests/Makefile.am b/tests/Makefile.am
+index cc9ce5039..5129b8a34 100644
+--- a/tests/Makefile.am
 b/tests/Makefile.am
+@@ -104,7 +104,7 @@ openfabrics_verbs_LDADD = $(LDADD) -libverbs
+ myriexpress_LDADD = $(LDADD) -lmyriexpress
+ opencl_LDADD = $(LDADD) $(HWLOC_OPENCL_LIBS) $(HWLOC_OPENCL_LDFLAGS)
+ cuda_LDADD = $(LDADD) -lcuda
+-cudart_LDADD = $(LDADD) -lcuda -lcudart
++cudart_LDADD = $(LDADD) -lcudart
+ nvml_LDADD = $(LDADD) -lnvidia-ml
+ hwloc_bind_LDADD = $(LDADD)
+ if HWLOC_HAVE_PTHREAD
diff -Nru hwloc-contrib-1.11.12/debian/patches/series 
hwloc-contrib-1.11.12/debian/patches/series
--- hwloc-contrib-1.11.12/debian/patches/series 2019-02-09 00:46:08.0 
+0100
+++ hwloc-contrib-1.11.12/debian/patches/series 2021-03-10 00:02:11.0 
+0100

Bug#984617: unblock: lowmem/1.49

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

I have uploaded a new version of lowmem, see the attached patch.

[ Reason ]
This updates the memory levels at which the d-i enables low-memory
optimizations.

[ Impact ]
If this isn't getting updated, starting the d-i on an amd64 machine with
an amount of memory between 550MB and 780MB, with default parameters,
will try to install without any low-memory optimization, but that will
fail with OOM errors.

[ Tests ]
I tested the d-i image in each modified case.

[ Risks ]
The code change is trivial: it only changes the numerical level.

[ Checklist ]
  [X] all changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in testing

unblock lowmem/1.49

Thanks!
Samuel
diff -Nru lowmem-1.48/debian/changelog lowmem-1.49/debian/changelog
--- lowmem-1.48/debian/changelog2020-12-15 18:15:38.0 +0100
+++ lowmem-1.49/debian/changelog2021-03-03 02:21:13.0 +0100
@@ -1,3 +1,9 @@
+lowmem (1.49) unstable; urgency=medium
+
+  * debian-installer-startup.d/S15lowmem: Update minimum memory sizes.
+
+ -- Samuel Thibault   Wed, 03 Mar 2021 02:21:13 +0100
+
 lowmem (1.48) unstable; urgency=medium
 
   * Team upload
diff -Nru lowmem-1.48/debian-installer-startup.d/S15lowmem 
lowmem-1.49/debian-installer-startup.d/S15lowmem
--- lowmem-1.48/debian-installer-startup.d/S15lowmem2019-06-02 
14:21:18.0 +0200
+++ lowmem-1.49/debian-installer-startup.d/S15lowmem2021-03-03 
02:15:44.0 +0100
@@ -25,9 +25,9 @@
min=39
;;
amd64)
-   level1=483 # MT=494300, qemu: -m 550
-   level2=273 # MT=279260, qemu: -m 300
-   min=145# MT=148188, qemu: -m 170
+   level1=737 # MT=754108, qemu: -m 780
+   level2=424 # MT=433340, qemu: -m 460
+   min=316# MT=322748, qemu: -m 350
;;
arm|armel|armhf)
# Update needed
@@ -42,9 +42,9 @@
min=18
;;
i386)
-   level1=386 # MT=394604, qemu: -m 400
-   level2=237 # MT=242628, qemu: -m 250
-   min=109# MT=110956, qemu: -m 120
+   level1=466 # MT=478056, qemu: -m 485
+   level2=348 # MT=356312, qemu: -m 365
+   min=269# MT=275220, qemu: -m 285
;;
mips)
# Update needed
@@ -89,9 +89,9 @@
min=30# MT=30040, qemu: -m 90
;;
hurd-i386)
-   level1=499 # qemu: -m 500
-   level2=409 # qemu: -m 410
-   min=389# qemu: -m 390
+   level1=600 # MT=614208, qemu: -m 600
+   level2=480 # MT=491328, qemu: -m 480
+   min=475# MT=486208, qemu: -m 475
;;
*)
level1=64
diff -Nru lowmem-1.48/README lowmem-1.49/README
--- lowmem-1.48/README  2019-10-13 20:07:57.0 +0200
+++ lowmem-1.49/README  2021-03-03 02:06:22.0 +0100
@@ -131,13 +131,16 @@
 devices).
 
 In both cases, you need to set min to absolute minimum amount of memory needed
-for an install, booting with lowmem=2, partitioning by hand, etc.
+for an install, booting with lowmem=2, loading only the nic-modules udeb,
+partitioning by hand, etc.
 
 Ideally, constraints should be tested for both netboot and businesscard images
 (businesscard CD will use slightly more memory before partitioning that netinst
 because of mirror selection).
 
-NB: the minimum value should be update in the manual in build/arch-options
+NB: the minimum value should be updated in the manual in build/arch-options
+
+NB: the minimum value should be updated in 
debian-installer/build/boot/x86/f2.txt
 
 NB: the minimum memory required to run the graphical installer must
 also be tested. See rootskel (debian-installer.d/S60frontend).

Bug#972814: buster-pu: package pcaudiolib/1.1-3+deb10u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

Hello,

[ Reason ]
It was reported on the speakup mailing list that some people were
getting speak mixture when e.g. moving fast between lines. More
precisely, the speak for a line would not stop fast enough before the
speak for the next line would happen. We could determine that it is
due to pcaudiolib letting pulseaudio and alsa use a long audio buffer,
which thus keeps getting played. In order to stop audio processing soon
enough, a smaller buffer needs to be set, just like speech-dispatcher
does. This is a regression with respect to Debian 8 in which espeakup
was not using pcaudiolib.

[ Impact ]
Some users are saying that this makes using espeakup very tedious,
others say that it is unusable and have downgraded to Debian 8.

Yes, the user bug report latency is that long :/ ...

[ Tests ]
One way to trigger this is to run espeakup in qemu, play some audio
in some VT to keep the audio card and the dmix plugin up, and run
espeakup. Using speakup+7 and speakup+9 to switch between lines, one can
notice the mixture of the lines speaks.

[ Risks ]
The code only changes the buffering parameters requested from alsa and
pulseaudio, all other parameters are left unchanged.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
This patches the alsa and pulseaudio backends. It makes the alsa backend
call snd_pcm_hw_params_set_buffer_size_near with 10ms worth of audio. It
makes the pulseaudio backend pass a non-default buffer attr structure.

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.9.0 (SMP w/8 CPU threads)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

-- 
Samuel
  bien s?r que ?a convient mieux ? tout le monde
  enfin, dans la mesure o? tout le monde c'est comme moi
 -+- le consensus, c'est facile -+-
diff -Nru pcaudiolib-1.1/debian/changelog pcaudiolib-1.1/debian/changelog
--- pcaudiolib-1.1/debian/changelog 2018-10-23 18:33:37.0 +0200
+++ pcaudiolib-1.1/debian/changelog 2020-10-24 11:37:02.0 +0200
@@ -1,3 +1,9 @@
+pcaudiolib (1.1-3+deb10u1) buster; urgency=medium
+
+  * patches/cancel: Cap cancellation latency to 10ms.
+
+ -- Samuel Thibault   Sat, 24 Oct 2020 11:37:02 +0200
+
 pcaudiolib (1.1-3) unstable; urgency=medium
 
   * control: Bump Standards-Version to 4.2.0 (no changes).
diff -Nru pcaudiolib-1.1/debian/patches/cancel 
pcaudiolib-1.1/debian/patches/cancel
--- pcaudiolib-1.1/debian/patches/cancel1970-01-01 01:00:00.0 
+0100
+++ pcaudiolib-1.1/debian/patches/cancel2020-10-18 23:06:20.0 
+0200
@@ -0,0 +1,79 @@
+Submitted: https://github.com/espeak-ng/pcaudiolib/pull/6
+commited
+
+commit a41d46e816d2cbcd93564c42b65a87af547bcb2d
+Author: Samuel Thibault 
+Date:   Sun Oct 11 17:34:57 2020 +0200
+
+Fix cancellation snappiness
+
+Screen reader users report getting late cancellation, or even mixtures
+of speech. This is because the default buffering parameters of alsa or
+pulseaudio are relatively large.
+
+This change sets alsa and pulseaudio buffer sizes to 10ms worth of audio,
+which is the human snappiness perception limit.
+
+diff --git a/src/alsa.c b/src/alsa.c
+index 64d5a90..c856788 100644
+--- a/src/alsa.c
 b/src/alsa.c
+@@ -99,6 +99,7 @@ alsa_object_open(struct audio_object *object,
+ 
+   snd_pcm_hw_params_t *params = NULL;
+   snd_pcm_hw_params_malloc();
++  snd_pcm_uframes_t bufsize = (rate * channels * LATENCY) / 1000;
+ 
+   int err = 0;
+   if ((err = snd_pcm_open(>handle, self->device ? self->device : 
"default", SND_PCM_STREAM_PLAYBACK, 0)) < 0)
+@@ -113,6 +114,8 @@ alsa_object_open(struct audio_object *object,
+   goto error;
+   if ((err = snd_pcm_hw_params_set_channels(self->handle, params, 
channels)) < 0)
+   goto error;
++  if ((err = snd_pcm_hw_params_set_buffer_size_near(self->handle, params, 
)) < 0)
++  goto error;
+   if ((err = snd_pcm_hw_params(self->handle, params)) < 0)
+   goto error;
+   if ((err = snd_pcm_prepare(self->handle)) < 0)
+diff --git a/src/audio_priv.h b/src/audio_pr

Bug#971944: buster-pu: package espeak/1.48.04+dfsg-7+deb10u1

[Samuel Thibault]

Adam D. Barratt, le ven. 16 oct. 2020 17:44:29 +0100, a ecrit:
> On Sat, 2020-10-10 at 12:07 +0200, Samuel Thibault wrote:
> > Espeak cannot drive the mbrola-fr4 speech synthesis voice if the
> > mbrola-fr1 package is not installed. This is because some of the mb-
> > fr4 espeak rules refer to the fr1 voice while they should be
> > referring to the fr4 voice. This was fixed some time ago in the newer
> > espeak-ng package, but the fix was not backported yet to espeak.
> [...]
> > Yes, the remaining reference to fr1_phtrans is on purpose, it is part
> > of the confusion between mbrola-fr1 and mbrola-fr4: fr1_phtrans is
> > provided by espeak-data for both mbrola-fr1 and mbrola-fr4, it was
> > actually renamed to fr_phtrans in espeak-ng-data.
> 
> This looks fine to me, but will need a KiBi-ack as espeak produces a
> udeb.

Ah, I didn't think about it because these files are not actually shipped
in the udeb :)

$ ar p espeak-data-udeb_1.48.04+dfsg-7_amd64.udeb data.tar.xz | tar tJ | grep mb
$ ar p espeak-data-udeb_1.48.04+dfsg-7+deb10u1_amd64.udeb data.tar.xz | tar tJ 
| grep mb
$ 

Samuel

Bug#971944: buster-pu: package espeak/1.48.04+dfsg-7+deb10u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

Hello,

[ Reason ]
Espeak cannot drive the mbrola-fr4 speech synthesis voice if the
mbrola-fr1 package is not installed. This is because some of the mb-fr4
espeak rules refer to the fr1 voice while they should be referring to
the fr4 voice. This was fixed some time ago in the newer espeak-ng
package, but the fix was not backported yet to espeak.

[ Impact ]
This was not a regression over oldstable, but it's hard for users to
guess that espeak+mbrola-fr4 cannot work without the mbrola-fr1 package,
I actually got hit by the issue a week ago and it took me some time to
realize the problem, even though I'm maintaining the packages.

[ Tests ]
After installing speech-dispatcher, espeak, and mbrola-fr4, but not
mbrola-fr1,

spd-say -O espeak-mbrola-generic Bonjour

should be speaking "Bonjour"

[ Risks ]
The change is trivial, as attached. It is already tested as working in
unstable.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
They simply fix the fr1 reference into fr4.

Yes, the remaining reference to fr1_phtrans is on purpose, it is part of
the confusion between mbrola-fr1 and mbrola-fr4: fr1_phtrans is provided
by espeak-data for both mbrola-fr1 and mbrola-fr4, it was actually
renamed to fr_phtrans in espeak-ng-data.

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.8.0 (SMP w/8 CPU threads)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru espeak-1.48.04+dfsg/debian/changelog 
espeak-1.48.04+dfsg/debian/changelog
--- espeak-1.48.04+dfsg/debian/changelog2018-10-23 18:26:10.0 
+0200
+++ espeak-1.48.04+dfsg/debian/changelog2020-10-10 11:26:41.0 
+0200
@@ -1,3 +1,10 @@
+espeak (1.48.04+dfsg-7+deb10u1) buster; urgency=medium
+
+  * patches/mbrola-fr4: Fix using espeak with mbrola-fr4 when mbrola-fr1 is
+not installed.
+
+ -- Samuel Thibault   Sat, 10 Oct 2020 11:26:41 +0200
+
 espeak (1.48.04+dfsg-7) unstable; urgency=medium
 
   * control: Bump Standards-Version to 4.2.0 (no changes).
diff -Nru espeak-1.48.04+dfsg/debian/patches/mbrola-fr4 
espeak-1.48.04+dfsg/debian/patches/mbrola-fr4
--- espeak-1.48.04+dfsg/debian/patches/mbrola-fr4   1970-01-01 
01:00:00.0 +0100
+++ espeak-1.48.04+dfsg/debian/patches/mbrola-fr4   2020-10-07 
22:53:16.0 +0200
@@ -0,0 +1,22 @@
+diff --git a/espeak-data/voices/mb/mb-fr4 b/espeak-data/voices/mb/mb-fr4
+index 8e3c392..6e459cc 100755
+--- a/espeak-data/voices/mb/mb-fr4
 b/espeak-data/voices/mb/mb-fr4
+@@ -5,5 +5,5 @@ gender female
+ dictrules 1
+ pitch 140 220
+ voicing 90
+-mbrola fr1 fr1_phtrans
++mbrola fr4 fr1_phtrans
+ 
+diff --git a/espeak-data/voices/mb/mb-fr4-en b/espeak-data/voices/mb/mb-fr4-en
+index 8126770..33817e5 100755
+--- a/espeak-data/voices/mb/mb-fr4-en
 b/espeak-data/voices/mb/mb-fr4-en
+@@ -5,5 +5,5 @@ gender female
+ dictrules 1
+ pitch 140 220
+ voicing 90
+-mbrola fr1 fr1_phtrans
++mbrola fr4 fr1_phtrans
+ 
diff -Nru espeak-1.48.04+dfsg/debian/patches/series 
espeak-1.48.04+dfsg/debian/patches/series
--- espeak-1.48.04+dfsg/debian/patches/series   2016-09-11 02:42:30.0 
+0200
+++ espeak-1.48.04+dfsg/debian/patches/series   2020-10-07 22:53:16.0 
+0200
@@ -3,3 +3,4 @@
 fpic
 char_cast
 path
+mbrola-fr4

Bug#959431: buster-pu: package speech-dispatcher/0.9.0-5+deb10u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I have uploaded the attached change for buster.

The story dates back with #697637 and LP #1208826 which noted that
speech dispatcher requests very low latency (1ms) from pulseaudio to get
the maximum snappiness of speech feedback. This was frowned upon as
eating more CPU than needed, and patched over to increase the request to
20ms in version 0.8-1 of speech-dispatcher, as well as in upstream. That
patch however was not complete, it missed the attached change to
actually change the configuration default, so the requested latency
remained 1ms by default.

This was not so much a problem beyond a bit more battery drain so
far. But with more recent releases of pulseaudio, apparently data
transfer management with ALSA got bogus, to the point that this 1ms
request is currently making pulseaudio step over itself, which I
reported upstream:

https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/issues/871

The end-user visible result is that on computer start, the speech is
disturbed, scratchy, making it unusable, we have heard this with various
audio cards. This solves over time, once pulseaudio determines that it
gets underruns and should increase the latency beyond 1ms, but that can
take from seconds to minutes, thus really a pain for the user who just
wants to use the computer. I have proposed to upstream some patch to try
to detect the underruns more quickly, but I don't know pulseaudio enough
to determine whether it is safe.

That's why I'm proposing to just really increase the latency request in
speech-dispatcher (as was already planned to save battery) to avoid the
pulseaudio bug in Buster.

Samuel

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldstable-proposed-updates-debug'), (500, 
'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), 
(500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.6.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru speech-dispatcher-0.9.0/debian/changelog 
speech-dispatcher-0.9.0/debian/changelog
--- speech-dispatcher-0.9.0/debian/changelog2019-02-20 13:22:57.0 
+0100
+++ speech-dispatcher-0.9.0/debian/changelog2020-05-02 12:05:06.0 
+0200
@@ -1,3 +1,10 @@
+speech-dispatcher (0.9.0-5+deb10u1) buster; urgency=medium
+
+  * patches/pulseaudio-latency: Fix default pulseaudio latency which triggers
+pulseaudio scratchy output.
+
+ -- Samuel Thibault   Sat, 02 May 2020 12:05:06 +0200
+
 speech-dispatcher (0.9.0-5) unstable; urgency=medium
 
   * control: Do not require exactly the same binary version of
diff -Nru speech-dispatcher-0.9.0/debian/patches/pulseaudio-latency 
speech-dispatcher-0.9.0/debian/patches/pulseaudio-latency
--- speech-dispatcher-0.9.0/debian/patches/pulseaudio-latency   1970-01-01 
01:00:00.0 +0100
+++ speech-dispatcher-0.9.0/debian/patches/pulseaudio-latency   2020-05-02 
12:00:39.0 +0200
@@ -0,0 +1,13 @@
+diff --git a/src/server/configuration.c b/src/server/configuration.c
+index 2d6cfaca..3623e342 100644
+--- a/src/server/configuration.c
 b/src/server/configuration.c
+@@ -473,7 +473,7 @@ void load_default_global_set_options()
+   GlobalFDSet.audio_alsa_device = g_strdup("default");
+   GlobalFDSet.audio_nas_server = g_strdup("tcp/localhost:5450");
+   GlobalFDSet.audio_pulse_server = g_strdup("default");
+-  GlobalFDSet.audio_pulse_min_length = 100;
++  GlobalFDSet.audio_pulse_min_length = 1764;
+ 
+   SpeechdOptions.max_history_messages = 1;
+ 
diff -Nru speech-dispatcher-0.9.0/debian/patches/series 
speech-dispatcher-0.9.0/debian/patches/series
--- speech-dispatcher-0.9.0/debian/patches/series   2019-02-20 
13:22:53.0 +0100
+++ speech-dispatcher-0.9.0/debian/patches/series   2020-05-02 
12:00:48.0 +0200
@@ -2,3 +2,4 @@
 systemd-debian
 mbrola-paths
 ibmtts-shim
+pulseaudio-latency

Bug#954757: buster-pu: package brltty/5.6-10+deb10u1

[Samuel Thibault]

Adam D. Barratt, le sam. 18 avril 2020 11:33:46 +0100, a ecrit:
> On Mon, 2020-03-23 at 00:30 +0100, Samuel Thibault wrote:
> > I would like to upload the attached changes to buster, they are
> > already in buster-p-u.
> 
> Well, no, they're in stable-new. :)

Ah, I don't know the details of the p-u terminology

> This looks OK to me, but will need a KiBi-ack as brltty builds a udeb.

The change is in the brlapi part of brltty, which is not actually
enabled in the udeb.

Samuel

Bug#954757: buster-pu: package brltty/5.6-10+deb10u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: buster
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I would like to upload the attached changes to buster, they are already
in buster-p-u.

The story is that Orca was recently enhanced to support Braille device
unplug/replug, by periodically trying to reconnect to brltty to
determine whether a Braille device was plugged. Brltty however used to
be noisy about this in the syslogs, which ends up making /var/log/syslog
grow quite fast. The attached trivial change, commited upstream and
already migrated to testing since 17th March, reduces the verbosity of
the message, thus avoiding the /var/log/syslog growth.

This is not actually fixing a bug in Buster itself, but some people try
to install newer versions of Orca in their Buster box, and then hit the
issue.

Samuel

-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-proposed-updates-debug'), (500, 'testing-proposed-updates'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldstable-proposed-updates-debug'), (500, 
'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), 
(500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.5.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
void packerFlushTheToiletFirstThingInTheMorning( void* arg )
 -+- chromium's source code -+-
diff -Nru brltty-5.6/debian/changelog brltty-5.6/debian/changelog
--- brltty-5.6/debian/changelog 2019-02-03 23:04:56.0 +0100
+++ brltty-5.6/debian/changelog 2019-02-03 23:04:56.0 +0100
@@ -1,3 +1,10 @@
+brltty (5.6-10+deb10u1) buster; urgency=medium
+
+  * patches/log-spam: Avoid spamming log with recent Orca which tries to
+reconnect periodically.
+
+ -- Samuel Thibault   Sun, 03 Feb 2019 23:04:56 +0100
+
 brltty (5.6-10) unstable; urgency=medium
 
   * debian/brltty-udeb.udev.rules: Fix hd detection
diff -Nru brltty-5.6/debian/patches/log-spam brltty-5.6/debian/patches/log-spam
--- brltty-5.6/debian/patches/log-spam  1970-01-01 01:00:00.0 +0100
+++ brltty-5.6/debian/patches/log-spam  2019-02-03 23:04:56.0 +0100
@@ -0,0 +1,22 @@
+commit 6e04998b89fd9270f396c53560a3abca85d3e8f8
+Author: Samuel Thibault 
+Date:   Thu Jul 4 20:02:20 2019 +0200
+
+Reduce log level of API client connection
+
+To avoid spamming system logs when Orca tries to reconnect periodically
+until a braille device is connected.
+
+diff --git a/Programs/brlapi_server.c b/Programs/brlapi_server.c
+index 7fc9953b8..7809304c1 100644
+--- a/Programs/brlapi_server.c
 b/Programs/brlapi_server.c
+@@ -2406,7 +2406,7 @@ THREAD_FUNCTION(runServer) {
+ #ifdef __MINGW32__
+ }
+ #endif /* __MINGW32__ */
+-logMessage(LOG_NOTICE, "BrlAPI connection fd=%"PRIfd" accepted: %s", 
resfd, source);
++logMessage(LOG_INFO, "BrlAPI connection fd=%"PRIfd" accepted: %s", 
resfd, source);
+ 
+ if (unauthConnections >= UNAUTH_LIMIT) {
+   writeError(resfd, BRLAPI_ERROR_CONNREFUSED);
diff -Nru brltty-5.6/debian/patches/series brltty-5.6/debian/patches/series
--- brltty-5.6/debian/patches/series2019-01-26 23:04:32.0 +0100
+++ brltty-5.6/debian/patches/series2019-02-03 23:04:56.0 +0100
@@ -9,3 +9,4 @@
 git-new_hedomobiline_usbid
 atspi2-shutdown
 policykit-fix
+log-spam

Bug#946281: transition: liblouis

[Samuel Thibault]

Hello,

Paul Gevers, le ven. 06 déc. 2019 21:09:01 +0100, a ecrit:
> On 06-12-2019 17:15, Samuel Thibault wrote:
> > Upstream of liblouis cleaned the library interface in version 3.12,
> > leading to a bump from liblouis19 to liblouis20. I am thus requesting
> > a transition slot. The only build rdeps are brltty, liblouisxml and
> > liblouisutdml, which I could check as building and running fine.
> 
> Please go ahead.

It is now in.

Samuel

Bug#946281: transition: liblouis

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: transition

Hello,

Upstream of liblouis cleaned the library interface in version 3.12,
leading to a bump from liblouis19 to liblouis20. I am thus requesting
a transition slot. The only build rdeps are brltty, liblouisxml and
liblouisutdml, which I could check as building and running fine.

Samuel

Ben file:

title = "liblouis";
is_affected = .depends ~ "liblouis19" | .depends ~ "liblouis20";
is_good = .depends ~ "liblouis20";
is_bad = .depends ~ "liblouis19";


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldstable-proposed-updates-debug'), (500, 
'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), 
(500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.4.0 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#945113: transition: hwloc

[Samuel Thibault]

Paul Gevers, le jeu. 28 nov. 2019 10:12:57 +0100, a ecrit:
> On 28-11-2019 09:24, Samuel Thibault wrote:
> > compile-examples FAIL stderr: /usr/bin/ld: warning: libhwloc.so.5, 
> > needed by /usr/lib/x86_64-linux-gnu/librsb.so, may conflict with 
> > libhwloc.so.15
> 
[...]
> so far I haven't
> figured out what we exactly want, let alone implement it.

Ok, I see.

> So, I don't think the situation is very bad at this moment. In this case
> the test doesn't fail by itself, the reason why the autopkgtest fails is
> due to a WARNING on stderr. The autopkgtest of librsb follows the
> default behavior of failing on output to strerr, which, in cases like
> this shows that could be the wrong setting for this package if the test
> is otherwise showing that the package works.

The package works only by luck, the warning does indicate that something
wrong is happening. I do think that in the case of hwloc it could very
well crash, because structures have changed between hwloc1 and hwloc2.

Personally I almost always leave the stderr check, because most often
they are a sign of something wrong happening, and we want to fix it
somewhere, even if it is harmless for the test at case.

Perhaps what we are lacking here is a button for the maintainer of the
migrating package and the maintainer of the failing package to be able
to say "never mind, this is fine", and/or another to say "please retry
this with all to-be-migrated packages". That could cover most of the
cases, without the debian-release team having to delve into them.

Samuel

Bug#945113: transition: hwloc

[Samuel Thibault]

FYI,

https://tracker.debian.org/pkg/hwloc
https://ci.debian.net/data/autopkgtest/testing/amd64/libr/librsb/3524853/log.gz

shows that autopkgtest fails in testing for librsb, thus blocking
the libhwloc.so.5 -> libhwloc.so.15 transition, but that's actually
_because_ of the transition:

[...]
Get:7 http://deb.debian.org/debian testing/main amd64 librsb0 amd64 
1.2.0.8+dfsg-1 [687 kB]
[...]
compile-examples FAIL stderr: /usr/bin/ld: warning: libhwloc.so.5, needed 
by /usr/lib/x86_64-linux-gnu/librsb.so, may conflict with libhwloc.so.15

i.e. it installed the non-rebuilt librsb0 1.2.0.8+dfsg-1 from testing
and then noticed the conflict warning.  If it was installing the rebuilt
librsb 1.2.0.8+dfsg-1+b1 from unstable (which will migrate to testing
along hwloc) it would not get the warning and thus succeed.

I don't know if such a case is known by the release and CI team, just
making sure here.

Samuel

Bug#945113: transition: hwloc

[Samuel Thibault]

Samuel Thibault, le mar. 26 nov. 2019 14:51:12 +0100, a ecrit:
> Emilio Pozuelo Monfort, le mar. 26 nov. 2019 12:07:35 +0100, a ecrit:
> > On 19/11/2019 22:06, Samuel Thibault wrote:
> > > Version 2 of hwloc introduces a soname bump. It also introduces
> > > incompatible API changes, but with the latest upload of openmpi, I could
> > > check that all packages that build with and actually use libhwloc-dev (a
> > > dozen) now build fine with hwloc 2 (available in experimental). I'm thus
> > > requesting a transition slot for hwloc 2.
> > 
> > Go ahead.
> 
> It is now ACCEPTED.

FYI, I have bin-only-uploaded starpu-contrib by hand (it depends on the
non-free CUDA).

Samuel

Bug#945113: transition: hwloc

[Samuel Thibault]

Emilio Pozuelo Monfort, le mar. 26 nov. 2019 12:07:35 +0100, a ecrit:
> On 19/11/2019 22:06, Samuel Thibault wrote:
> > Version 2 of hwloc introduces a soname bump. It also introduces
> > incompatible API changes, but with the latest upload of openmpi, I could
> > check that all packages that build with and actually use libhwloc-dev (a
> > dozen) now build fine with hwloc 2 (available in experimental). I'm thus
> > requesting a transition slot for hwloc 2.
> 
> Go ahead.

It is now ACCEPTED.

Thanks!
Samuel

Bug#945113: transition: hwloc

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: transition

Hello,

Version 2 of hwloc introduces a soname bump. It also introduces
incompatible API changes, but with the latest upload of openmpi, I could
check that all packages that build with and actually use libhwloc-dev (a
dozen) now build fine with hwloc 2 (available in experimental). I'm thus
requesting a transition slot for hwloc 2.

Samuel

Ben file:

title = "hwloc";
is_affected = .depends ~ "libhwloc5" | .depends ~ "libhwloc15";
is_good = .depends ~ "libhwloc15";
is_bad = .depends ~ "libhwloc5";


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 
'oldstable-proposed-updates-debug'), (500, 'oldstable-proposed-updates'), (500, 
'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 'stable'), 
(500, 'oldstable'), (1, 'experimental-debug'), (1, 'buildd-experimental'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.3.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Bug#941237: transition: brltty

[Samuel Thibault]

Emilio Pozuelo Monfort, le sam. 12 oct. 2019 15:45:15 +0200, a ecrit:
> On 26/09/2019 23:20, Samuel Thibault wrote:
> > Package: release.debian.org
> > Severity: normal
> > User: release.debian@packages.debian.org
> > Usertags: transition
> > 
> > Hello,
> > 
> > I'd like to upload brltty which introduces libbrlapi0.7 instead of
> > libbrlapi0.6. The only rdep is qemu, which builds fine against it.
> 
> Sure, please go ahead.

Thanks, it's now in!

Samuel

Bug#941237: transition: brltty

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: transition

Hello,

I'd like to upload brltty which introduces libbrlapi0.7 instead of
libbrlapi0.6. The only rdep is qemu, which builds fine against it.

Ben file:

title = "brltty";
is_affected = .depends ~ "libbrlapi0.6" | .depends ~ "libbrlapi0.7";
is_good = .depends ~ "libbrlapi0.7";
is_bad = .depends ~ "libbrlapi0.6";


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldstable-proposed-updates-debug'), (500, 
'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), 
(500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.3.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
 muhahaha...
 ya un train qui part de Perrache à 14h57
 qui passe à Part-Dieu à 15h10
 si je le prends à Perrache, je suis en zone bleue
 si je le prends à Part-Dieu, je suis en zone blanche
 donc je vais le prendre à Perrache *mais* à Part-Dieu ;-)
 -+- #ens-mim - vive la SNCF -+-

Bug#940817: transition: liblouis

[Samuel Thibault]

Paul Gevers, le lun. 23 sept. 2019 21:51:06 +0200, a ecrit:
> On 21-09-2019 00:20, Samuel Thibault wrote:
> > Samuel Thibault, le ven. 20 sept. 2019 10:30:36 +0200, a ecrit:
> >> The new liblouis release (3.11.0) changed its ABI. I have checked
> >> the rdeps, they build and run fine, except liblouisutdml, which uses
> >> internal functions of liblouis. I have uploaded to experimental the new
> >> upstream release of liblouisutdml (2.8.0) which fixes compatibility with
> >> liblouis, it has no rdeps.
> > 
> > I forgot to mention that the new liblouisutdml doesn't build with the
> > old liblouis. That's why they have to go together, I can't upload
> > liblouisutdml to unstable yet.
> 
> Please go ahead.

They are now in.

Samuel

Bug#940817: transition: liblouis

[Samuel Thibault]

Samuel Thibault, le ven. 20 sept. 2019 10:30:36 +0200, a ecrit:
> The new liblouis release (3.11.0) changed its ABI. I have checked
> the rdeps, they build and run fine, except liblouisutdml, which uses
> internal functions of liblouis. I have uploaded to experimental the new
> upstream release of liblouisutdml (2.8.0) which fixes compatibility with
> liblouis, it has no rdeps.

I forgot to mention that the new liblouisutdml doesn't build with the
old liblouis. That's why they have to go together, I can't upload
liblouisutdml to unstable yet.

Samuel

Bug#940817: transition: liblouis

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: transition

Hello,

The new liblouis release (3.11.0) changed its ABI. I have checked
the rdeps, they build and run fine, except liblouisutdml, which uses
internal functions of liblouis. I have uploaded to experimental the new
upstream release of liblouisutdml (2.8.0) which fixes compatibility with
liblouis, it has no rdeps. Both liblouis and liblouisutdml build fine in
experimental on all release archs.

So to summarize, the new versions of liblouis and liblouisutdml would
have to migrate together, along the rebuilds of rdeps of liblouis.

Samuel

Ben file:

title = "liblouis";
is_affected = .depends ~ "liblouis17" | .depends ~ "liblouis19";
is_good = .depends ~ "liblouis19";
is_bad = .depends ~ "liblouis17";


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldstable-proposed-updates-debug'), (500, 
'oldstable-proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), 
(500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.3.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
"c'est pas nous qui sommes à la rue, c'est la rue qui est à nous"

Bug#931386: stretch-pu: package fribidi/0.19.7-1.1

[Samuel Thibault]

Jonathan Wiltshire, le sam. 27 juil. 2019 20:36:00 -0300, a ecrit:
> On Wed, Jul 03, 2019 at 07:36:55PM +0200, Samuel Thibault wrote:
> > As reported on #917909, the text-based debian installer support for
> > right-to-left languages is completely broken, only due to a path
> > mismatch. This was fixed in Buster in January with the attached change,
> > which I have uploaded to stretch as 0.19.7-1.1, could you accept it?
> 
> That's an unusual version; did you mean to +deb9u1 it instead?

Oops, sorry about this.  I have reuploaded it as 0.19.7-1+deb9u1 with
the attached changes.

Samuel
diff -Nru fribidi-0.19.7/debian/changelog fribidi-0.19.7/debian/changelog
--- fribidi-0.19.7/debian/changelog 2015-08-12 07:32:03.0 +0200
+++ fribidi-0.19.7/debian/changelog 2019-06-08 22:39:38.0 +0200
@@ -1,3 +1,12 @@
+fribidi (0.19.7-1+deb9u1) stretch; urgency=medium
+
+  * Non-maintainer upload.
+  * libfribidi0-udeb: Fix right-to-left output in textual version of
+d-i by installing the shared library files into a multi-arch libdir
+    (Closes: #917909).
+
+ -- Samuel Thibault   Sat, 08 Jun 2019 22:39:38 +0200
+
 fribidi (0.19.7-1) unstable; urgency=medium
 
   * New upstream release.
diff -Nru fribidi-0.19.7/debian/libfribidi0-udeb.install 
fribidi-0.19.7/debian/libfribidi0-udeb.install
--- fribidi-0.19.7/debian/libfribidi0-udeb.install  2015-08-12 
07:32:03.0 +0200
+++ fribidi-0.19.7/debian/libfribidi0-udeb.install  2019-06-08 
22:39:38.0 +0200
@@ -1 +1 @@
-usr/lib/*/libfribidi.so.* lib
+usr/lib/*/libfribidi.so.*

Bug#931386: stretch-pu: package fribidi/0.19.7-1.1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hello,

As reported on #917909, the text-based debian installer support for
right-to-left languages is completely broken, only due to a path
mismatch. This was fixed in Buster in January with the attached change,
which I have uploaded to stretch as 0.19.7-1.1, could you accept it?

Thanks,
Samuel

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
commit 8469bfead9515ab3644f1769a1ff51466ba8ffee
Author: Samuel Thibault 
Date:   Mon Jul 1 02:31:02 2019 +0200

Fix crash on XkbSetMap

Some devices may not have keyboard information.

Fixes #574

diff --git a/xkb/xkb.c b/xkb/xkb.c
index 764079506..9bd45a34a 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -2383,6 +2383,9 @@ _XkbSetMapChecks(ClientPtr client, DeviceIntPtr dev, 
xkbSetMapReq * req,
 XkbSymMapPtr map;
 int i;
 
+if (!dev->key)
+return 0;
+
 xkbi = dev->key->xkbInfo;
 xkb = xkbi->desc;
 
@@ -2495,6 +2498,9 @@ _XkbSetMap(ClientPtr client, DeviceIntPtr dev, 
xkbSetMapReq * req, char *values)
 XkbSrvInfoPtr xkbi;
 XkbDescPtr xkb;
 
+if (!dev->key)
+return Success;
+
 xkbi = dev->key->xkbInfo;
 xkb = xkbi->desc;
 
commit fabc4219622f3c0b41b1cb897c46e092377059e3
Author: Samuel Thibault 
Date:   Mon Jul 1 02:33:26 2019 +0200

Fix crash on XkbSetMap

Since group_info and width are used for the key actions allocations,
when modifying them we need to take care of reallocation key actions if
needed.

diff --git a/xkb/xkb.c b/xkb/xkb.c
index 9bd45a34a..3162574a4 100644
--- a/xkb/xkb.c
+++ b/xkb/xkb.c
@@ -2110,6 +2110,9 @@ SetKeySyms(ClientPtr client,
 }
 }
 }
+if (XkbKeyHasActions(xkb, i + req->firstKeySym))
+XkbResizeKeyActions(xkb, i + req->firstKeySym,
+XkbNumGroups(wire->groupInfo) * wire->width);
 oldMap->kt_index[0] = wire->ktIndex[0];
 oldMap->kt_index[1] = wire->ktIndex[1];
 oldMap->kt_index[2] = wire->ktIndex[2];

Bug#930493: unblock: lowmem/1.47

[Samuel Thibault]

Hello,

Cyril Brulebois, le sam. 22 juin 2019 19:13:10 +0200, a ecrit:
>  - there are some RAM requirements mentioned in the manual as well,
>should there be an update there as well? Someone mentioned [1] on
>IRC lately.
> 
>  1. https://www.debian.org/releases/stable/amd64/ch02s05.html.en

I updated them in the d-i manual repo, yes.

Samuel

Bug#930494: unblock: rootskel/1.131

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

As mentioned in #930493, I have re-measured the minimum memory
contraints of d-i, and the g-i part is in rootskel, as attached here,
could you unblock it?

unblock rootskel/1.131

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru rootskel-1.129/debian/changelog rootskel-1.131/debian/changelog
--- rootskel-1.129/debian/changelog 2019-04-20 02:24:53.0 +0200
+++ rootskel-1.131/debian/changelog 2019-06-13 21:28:44.0 +0200
@@ -1,3 +1,24 @@
+rootskel (1.131) unstable; urgency=medium
+
+  * Team upload
+  * Remove spurious files.
+
+ -- Samuel Thibault   Thu, 13 Jun 2019 21:28:44 +0200
+
+rootskel (1.130) unstable; urgency=medium
+
+  * Team upload
+
+  [ Cyril Brulebois ]
+  * Remove Christian Perrier from Uploaders, with many thanks for all
+his contributions over the years! (Closes: #927486)
+
+  [ Samuel Thibault ]
+  * src/lib/debian-installer.d/S60frontend: Update gtk memory limit, now with
+encryption support which eats a lot.
+
+ -- Samuel Thibault   Thu, 13 Jun 2019 20:39:11 +0200
+
 rootskel (1.129) unstable; urgency=medium
 
   * S50entropy-source: start haveged when appropriate, to avoid entropy
diff -Nru rootskel-1.129/debian/control rootskel-1.131/debian/control
--- rootskel-1.129/debian/control   2019-03-08 15:21:53.0 +0100
+++ rootskel-1.131/debian/control   2019-06-02 13:29:14.0 +0200
@@ -2,7 +2,7 @@
 Section: debian-installer
 Priority: standard
 Maintainer: Debian Install System Team 
-Uploaders: Colin Watson , Bastian Blank 
, Christian Perrier , Steve McIntyre 
<93...@debian.org>
+Uploaders: Colin Watson , Bastian Blank 
, Steve McIntyre <93...@debian.org>
 Build-Depends: debhelper (>= 9), dpkg-dev (>= 1.7.0), linux-libc-dev (>= 
2.6.38) [linux-any]
 Vcs-Browser: https://salsa.debian.org/installer-team/rootskel
 Vcs-Git: https://salsa.debian.org/installer-team/rootskel.git
diff -Nru rootskel-1.129/src/lib/debian-installer.d/S60frontend 
rootskel-1.131/src/lib/debian-installer.d/S60frontend
--- rootskel-1.129/src/lib/debian-installer.d/S60frontend   2017-02-11 
22:24:40.0 +0100
+++ rootskel-1.131/src/lib/debian-installer.d/S60frontend   2019-06-02 
13:28:52.0 +0200
@@ -31,14 +31,14 @@
case "$(archdetect)" in
# Tested with Uyghur
powerpc/*|amd64/*)
-   local MEMLIMIT=310 ;;   # is 316864kB, qemu -m 327
+   local MEMLIMIT=766 ;;   # is 783460kB, qemu -m 800
kfreebsd-amd64/*)
# See Bug#783775 for derivation.
local MEMLIMIT=144 ;;   # is 147456kB, qemu -m 256
hurd-i386/*)
local MEMLIMIT=750 ;;   #  qemu -m 750
*)
-   local MEMLIMIT=281 ;;   # is 287732kB, qemu -m 293
+   local MEMLIMIT=534 ;;   # is 546188kB, qemu -m 550
esac
 
if [ $(get_mem) -lt $MEMLIMIT ] ; then

Bug#930493: unblock: lowmem/1.47

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Now that things have settled down, I have re-measured the minimum memory
contraints of d-i and thus uploaded a new version of lowmem with the
attached changes, could you unblock it?

It can be noted that the minimum have changed quite a lot because I
changed the test a bit: we were not testing with encryption support
previously, and it happens to require quite a lot of memory.

I have also added ignoring a lintian error about missing translations,
since lowmem conditions are precisely when we want to drop translations
:)

unblock lowmem/1.47

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
 r: et la marmotte, elle écrit un papier IPDPS
diff -Nru lowmem-1.46/debian/changelog lowmem-1.47/debian/changelog
--- lowmem-1.46/debian/changelog2018-08-28 18:00:17.0 +0200
+++ lowmem-1.47/debian/changelog2019-06-13 20:28:13.0 +0200
@@ -1,3 +1,17 @@
+lowmem (1.47) unstable; urgency=medium
+
+  * Team upload
+
+  [ Cyril Brulebois ]
+  * Remove Christian Perrier from Uploaders, with many thanks for all
+his contributions over the years! (Closes: #927570)
+
+  [ Samuel Thibault ]
+  * Update limits.
+  * source.lintian-overrides: Ignore untranslated templates.
+
+ -- Samuel Thibault   Thu, 13 Jun 2019 20:28:13 +0200
+
 lowmem (1.46) unstable; urgency=medium
 
   * Team upload
diff -Nru lowmem-1.46/debian/control lowmem-1.47/debian/control
--- lowmem-1.46/debian/control  2018-08-10 21:22:39.0 +0200
+++ lowmem-1.47/debian/control  2019-06-02 14:23:59.0 +0200
@@ -2,7 +2,6 @@
 Section: debian-installer
 Priority: optional
 Maintainer: Debian Install System Team 
-Uploaders: Christian Perrier 
 Build-Depends: debhelper (>= 9), dpkg-dev (>= 1.9.0)
 Vcs-Browser: https://salsa.debian.org/installer-team/lowmem
 Vcs-Git: https://salsa.debian.org/installer-team/lowmem.git
diff -Nru lowmem-1.46/debian/source.lintian-overrides 
lowmem-1.47/debian/source.lintian-overrides
--- lowmem-1.46/debian/source.lintian-overrides 2018-08-10 21:22:39.0 
+0200
+++ lowmem-1.47/debian/source.lintian-overrides 2019-06-13 20:28:13.0 
+0200
@@ -1 +1,2 @@
 lowmem source: not-using-po-debconf
+lowmem source: untranslatable-debconf-templates
diff -Nru lowmem-1.46/debian-installer-startup.d/S15lowmem 
lowmem-1.47/debian-installer-startup.d/S15lowmem
--- lowmem-1.46/debian-installer-startup.d/S15lowmem2018-08-10 
21:22:39.0 +0200
+++ lowmem-1.47/debian-installer-startup.d/S15lowmem2019-06-02 
14:21:18.0 +0200
@@ -25,9 +25,9 @@
min=39
;;
amd64)
-   level1=163 # MT=166348, qemu: -m 178
-   level2=163 # MT=166348, qemu: -m 178
-   min=163# MT=166348, qemu: -m 178
+   level1=483 # MT=494300, qemu: -m 550
+   level2=273 # MT=279260, qemu: -m 300
+   min=145# MT=148188, qemu: -m 170
;;
arm|armel|armhf)
# Update needed
@@ -42,9 +42,9 @@
min=18
;;
i386)
-   level1=135 # MT=137688, qemu: -m 145
-   level2=135 # MT=137688, qemu: -m 145
-   min=135# MT=137688, qemu: -m 145
+   level1=386 # MT=394604, qemu: -m 400
+   level2=237 # MT=242628, qemu: -m 250
+   min=109# MT=110956, qemu: -m 120
;;
mips)
# Update needed
@@ -88,11 +88,10 @@
level2=44 # MT=44376, qemu: -m 104
min=30# MT=30040, qemu: -m 90
;;
-   # Update needed
hurd-i386)
level1=499 # qemu: -m 500
level2=409 # qemu: -m 410
-   min=364# qemu: -m 365
+   min=389# qemu: -m 390
;;
*)
level1=64
diff -Nru lowmem-1.46/README lowmem-1.47/README
--- lowmem-1.46/README  2018-08-10 21:22:39.0 +0200
+++ lowmem-1.47/README  2

Bug#929859: unblock: speech-dispatcher-contrib/0.9.0-7

[Samuel Thibault]

Andreas Beckmann, le sam. 08 juin 2019 23:24:20 +0200, a ecrit:
> On Sun, 2 Jun 2019 01:27:15 +0200 Samuel Thibault 
> wrote:
> > As reported on Bug#929856, the pico speech synthesis from
> > speech-dispatcher-pico will not be usable just because the package does
> > not ship the pico.conf file which used to be shipped by the now-removed
> > speech-dispatcher-contrib package. This is fixed in version 0.9.0-7 as
> > shown in attached patch.
> 
> Doesn't this need Breaks+Replaces?

It already has it, from the time when the module got moved from
speech-dispatcher-contrib to speech-dispatcher-pico.

Samuel

Bug#929171: unblock: espeakup/1:0.80-15

[Samuel Thibault]

Samuel Thibault, le mer. 05 juin 2019 22:16:00 +0200, a ecrit:
> Cyril Brulebois, le mar. 04 juin 2019 06:31:23 +0200, a ecrit:
> > Speaking of error messages, we're also getting invalid commands from
> > amixer. Is that expected/known/tracked somewhere? (I think I've been
> > seeing this for months, maybe years.)
> 
> I think I have always seen them, they are coming from 
> alsa-utils-udeb's /usr/share/alsa/utils.sh
> Before multi-card they used to be not visible because only shown
> briefly. The screen reader is not active when they trigger, so it's not
> actually hurting users.

It seems to be benign: utils.sh is just trying to set an apparently
read-only control and probably just needs to filter out the error,
reported on Bug#930226.

Samuel

Bug#930135: unblock: speech-dispatcher-contrib/0.9.0-8

[Samuel Thibault]

Hello,

Paul Gevers, le sam. 08 juin 2019 11:55:53 +0200, a ecrit:
> This can't be properly unblocked yet, as speech-dispatcher-contrib
> doesn't autobuild and you only uploaded source

Oh, right. amd64/i386 are now accepted.

Samuel

Bug#930135: unblock: speech-dispatcher-contrib/0.9.0-8

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

As reported in #930132, when using the baratinoo speech synthesis, none
of the character spelling triggered by Orca works. So for instance, the
character feedback while typing and character feedback while moving
along text are not working, making the synthesis way less useful for
daily workflow.

This was fixed upstream by a one-liner, as the attached debdiff shows
(which also fixes the previously-requested changelog fixup), could you
unblock it?

unblock speech-dispatcher-contrib/0.9.0-8

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
J'ai beaucoup de mal a lire fcola quand il y a toutes les annonces de howto :
les annonces interessantes sont noyees dans les howto. Ca serait pas mal
de degager toute cette pollution dans un autre groupe.
  JLM in Guide du linuxien pervers : "Cachez ces doc que je ne saurais voir"
diff -Nru speech-dispatcher-contrib-0.9.0/debian/changelog 
speech-dispatcher-contrib-0.9.0/debian/changelog
--- speech-dispatcher-contrib-0.9.0/debian/changelog2019-06-02 
00:29:03.0 +0200
+++ speech-dispatcher-contrib-0.9.0/debian/changelog2019-06-07 
18:59:02.0 +0200
@@ -1,6 +1,14 @@
+speech-dispatcher-contrib (0.9.0-8) unstable; urgency=medium
+
+  * patches/git-baratinoo-char: cherry-pick upstream fix for spelling
+characters with the baratinoo synthesis (Closes: Bug#930132).
+
+ -- Samuel Thibault   Fri, 07 Jun 2019 18:59:02 +0200
+
 speech-dispatcher-contrib (0.9.0-7) unstable; urgency=medium
 
   * speech-dispatcher-pico.install: Ship pico.conf (Closes: Bug#929856).
+  * control: Fix description of speech-dispatcher-baratinoo.
 
  -- Samuel Thibault   Sun, 02 Jun 2019 00:29:03 +0200
 
diff -Nru speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char 
speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char
--- speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char   
1970-01-01 01:00:00.0 +0100
+++ speech-dispatcher-contrib-0.9.0/debian/patches/git-baratinoo-char   
2019-06-07 18:48:06.0 +0200
@@ -0,0 +1,19 @@
+commit 8018ad3ac98a93a0f64adeca79b0877e9d59e655
+Author: Samuel Thibault 
+Date:   Mon Apr 15 17:41:30 2019 +0200
+
+baratinoo: do not assume that CHAR commands contain SSML
+
+diff --git a/src/modules/baratinoo.c b/src/modules/baratinoo.c
+index 46fdec17..e1fd64b9 100644
+--- a/src/modules/baratinoo.c
 b/src/modules/baratinoo.c
+@@ -472,7 +472,7 @@ int module_speak(gchar *data, size_t bytes, SPDMessageType 
msgtype)
+   case SPD_MSGTYPE_SPELL: /* FIXME: use \spell one day? */
+   case SPD_MSGTYPE_CHAR:
+   g_string_append(buffer, "\\sayas<{characters}");
+-  append_ssml_as_proprietary(engine, buffer, data, bytes);
++  g_string_append_len(buffer, data, bytes);
+   g_string_append(buffer, "\\sayas>{}");
+   break;
+   default: /* FIXME: */
diff -Nru speech-dispatcher-contrib-0.9.0/debian/patches/series 
speech-dispatcher-contrib-0.9.0/debian/patches/series
--- speech-dispatcher-contrib-0.9.0/debian/patches/series   2019-05-18 
17:13:38.0 +0200
+++ speech-dispatcher-contrib-0.9.0/debian/patches/series   2019-06-07 
18:48:13.0 +0200
@@ -2,3 +2,4 @@
 systemd-debian
 mbrola-paths
 ibmtts-shim
+git-baratinoo-char

Bug#929171: unblock: espeakup/1:0.80-15

[Samuel Thibault]

Cyril Brulebois, le mar. 04 juin 2019 06:31:23 +0200, a ecrit:
> Testing multi-cards support (-soundhw all), I'm seeing errors that are
> likely due to busybox's sleep not supporting decimal numbers (“sleep
> 0.1” is called).
> 
> Not a regression if I'm reading the diff correctly, but might be worth
> fixing at some point…

Uh, indeed.  I'll see that post-Buster.

> Speaking of error messages, we're also getting invalid commands from
> amixer. Is that expected/known/tracked somewhere? (I think I've been
> seeing this for months, maybe years.)

I think I have always seen them, they are coming from 
alsa-utils-udeb's /usr/share/alsa/utils.sh
Before multi-card they used to be not visible because only shown
briefly. The screen reader is not active when they trigger, so it's not
actually hurting users.

Keeping that also in my todo list.

Samuel

Bug#929859: unblock: speech-dispatcher-contrib/0.9.0-7

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

As reported on Bug#929856, the pico speech synthesis from
speech-dispatcher-pico will not be usable just because the package does
not ship the pico.conf file which used to be shipped by the now-removed
speech-dispatcher-contrib package. This is fixed in version 0.9.0-7 as
shown in attached patch.

(along with a typo fix in the description of the
speech-dispatcher-baratinoo package, which was copied from the kali
package but not fixed accordingly).

Could you unblock this?

unblock speech-dispatcher-contrib/0.9.0-7

-- System Information:
Debian Release: 10.0
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru speech-dispatcher-contrib-0.9.0/debian/changelog 
speech-dispatcher-contrib-0.9.0/debian/changelog
--- speech-dispatcher-contrib-0.9.0/debian/changelog2019-02-21 
19:08:40.0 +0100
+++ speech-dispatcher-contrib-0.9.0/debian/changelog2019-06-02 
00:29:03.0 +0200
@@ -1,3 +1,9 @@
+speech-dispatcher-contrib (0.9.0-7) unstable; urgency=medium
+
+  * speech-dispatcher-pico.install: Ship pico.conf (Closes: Bug#929856).
+
+ -- Samuel Thibault   Sun, 02 Jun 2019 00:29:03 +0200
+
 speech-dispatcher-contrib (0.9.0-6) unstable; urgency=medium
 
   * control: Fix speech-dispatcher-audio-plugins dependency.
diff -Nru speech-dispatcher-contrib-0.9.0/debian/control 
speech-dispatcher-contrib-0.9.0/debian/control
--- speech-dispatcher-contrib-0.9.0/debian/control  2019-02-21 
19:08:40.0 +0100
+++ speech-dispatcher-contrib-0.9.0/debian/control  2019-06-02 
00:29:03.0 +0200
@@ -105,8 +105,8 @@
  independent way, therefore freeing the application programmer from
  having to yet again reinvent the wheel.
  .
- This package contains the output module for the Baratinoo speech synthesizer,
- also called Kali, which needs to be installed separately.
+ This package contains the output module for the Kali speech synthesizer,
+ which needs to be installed separately.
 
 Package: speech-dispatcher-ibmtts
 Architecture: i386
diff -Nru 
speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-contrib.install 
speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-contrib.install
--- speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-contrib.install
2019-01-01 20:55:13.0 +0100
+++ speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-contrib.install
1970-01-01 01:00:00.0 +0100
@@ -1,3 +0,0 @@
-/usr/lib/speech-dispatcher-modules/sd_pico
-/usr/share/speech-dispatcher/conf/modules/pico.conf
-/etc/speech-dispatcher/modules/pico.conf
diff -Nru speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-pico.install 
speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-pico.install
--- speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-pico.install   
2019-01-26 20:40:14.0 +0100
+++ speech-dispatcher-contrib-0.9.0/debian/speech-dispatcher-pico.install   
2019-06-02 00:10:33.0 +0200
@@ -1 +1,3 @@
 usr/lib/speech-dispatcher-modules/sd_pico
+usr/share/speech-dispatcher/conf/modules/pico.conf
+etc/speech-dispatcher/modules/pico.conf

Bug#929132: unblock (pre-approval): dbus/1.12.14-1

[Samuel Thibault]

Hello,

Simon McVittie, le jeu. 30 mai 2019 19:04:49 +0100, a ecrit:
> The only change that I think could possibly cause regressions
> for d-i's use case (AT-SPI)

d-i doesn't use AT-SPI yet actually.

Samuel

Bug#929171: unblock: espeakup/1:0.80-15

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

As reported on Bug#929169, “the Linux kernel in Buster seems to take
much longer (as much as 12s!) to detect some sound card such as the
widespread Intel HDA. The current timeout in espeakup-udeb is thus way
too short, and makes the Debian installer useless for blind people
having such audio cards.”

In version 1:0.80-15 (debdiff attached) I have thus made the timeout
longer. A proper solution would be to make espeakup startup event-based,
but that would be very involved at this stage of development.

This version was confirmed to be fixing the issue on a few user systems.

Samuel

unblock espeakup/1:0.80-15

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
Be warned that typing \fBkillall \fIname\fP may not have the desired
effect on non-Linux systems, especially when done by a privileged user.
(From the killall manual page)
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog  2019-03-29 17:03:23.0 +0100
+++ espeakup-0.80/debian/changelog  2019-05-18 16:37:19.0 +0200
@@ -1,3 +1,9 @@
+espeakup (1:0.80-15) unstable; urgency=medium
+
+  * debian/espeakup-udeb.start: Wait longer for sound cards...
+
+ -- Samuel Thibault   Sat, 18 May 2019 16:37:19 +0200
+
 espeakup (1:0.80-14) unstable; urgency=medium
 
   * rules: Restart espeakup after upgrade (Closes: Bug#925973).
diff -Nru espeakup-0.80/debian/espeakup-udeb.start 
espeakup-0.80/debian/espeakup-udeb.start
--- espeakup-0.80/debian/espeakup-udeb.start2019-03-29 17:03:23.0 
+0100
+++ espeakup-0.80/debian/espeakup-udeb.start2019-05-18 16:35:42.0 
+0200
@@ -7,14 +7,39 @@
 
 if lsmod | grep -q speakup_soft; then
# Give drivers some time to detect boards :/
-   sleep 2
-   IDS=$(echo $BASE/card*/id)
-   N=$(echo $IDS | wc -w)
-   case $N in
-   0)
-   echo No sound card detected, can not do software speech 
synthesis... Press enter to continue anyway.
-   read
-   ;;
+   sleep 1
+   S=1
+   while true
+   do
+   IDS=$(echo $BASE/card*/id)
+   if [ "$IDS" = "$BASE/card*/id" ]; then
+   if [ "$S" -ge 3 ]; then
+   echo "No sound card detected after $S 
seconds..."
+   fi
+   if [ "$S" -lt 30 ]; then
+   # We have seen cards taking as much as 12s to 
get initialized...
+   sleep 1
+   S=$((S+1))
+   continue
+   else
+   echo "Can not do software speech synthesis... 
Press enter to continue anyway."
+   read
+   break
+   fi
+   fi
+
+   # Sleep again as much, in case more cards are to come :/
+   echo "Waiting for $S more seconds for any other card..."
+   sleep $S
+
+   . /usr/share/alsa/utils.sh
+   preinit_levels all
+   sanify_levels all
+
+   IDS=$(echo $BASE/card*/id)
+   N=$(echo $IDS | wc -w)
+
+   case $N in
1)
# Just one card, can not be wrong
echo $(strip $IDS) > /var/run/espeakup.card
@@ -51,5 +76,8 @@
done
echo "$CARD" > /var/run/espeakup.card
ALSA_CARD=$(cat /sys/class/sound/card$CARD/id) 
/usr/bin/espeakup -V en >> /var/log/espeakup.log 2>&1
-   esac
+   esac
+
+   break
+   done
 fi

Bug#928779: unblock: jing-trang/20151127+dfsg-3

[Samuel Thibault]

Hello,

Paul Gevers, le sam. 11 mai 2019 07:38:31 +0200, a ecrit:
> On 11-05-2019 00:40, Samuel Thibault wrote:
> > unblock jing-trang/20151127+dfsg-3
> 
> Unblocked. Thanks.
> 
> By the way, are you in the power to schedule binNMU's and did you try
> that for this package? We got notified of a rejected binNMU by ftp-master.

Yes, and yes.
(I was surprised that binNMUs would not work for arch:all packages).

Samuel

Bug#928779: unblock: jing-trang/20151127+dfsg-3

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package jing-trang

In #928020 it was requested to rebuild jing-trang against unicode-data
12.1.0~pre1-2. Since this only contains an arch:all package, I had to
make a source upload even if without any change, as shown in the
attached debdiff.

unblock jing-trang/20151127+dfsg-3

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.1.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
* x remarque qu'avec un peu de volonté, on peut faire du code de porc
dans d'importe quel langage Turing-complet
 -+- x sur #ens-mim - codons porc -+-
diff -Nru jing-trang-20151127+dfsg/debian/changelog 
jing-trang-20151127+dfsg/debian/changelog
--- jing-trang-20151127+dfsg/debian/changelog   2019-01-04 00:16:22.0 
+0100
+++ jing-trang-20151127+dfsg/debian/changelog   2019-05-10 23:14:34.0 
+0200
@@ -1,3 +1,10 @@
+jing-trang (20151127+dfsg-3) unstable; urgency=medium
+
+  * Rebuild against unicode-data 12.1.0~pre1-2
+  * No source change.
+
+ -- Samuel Thibault   Fri, 10 May 2019 23:14:34 +0200
+
 jing-trang (20151127+dfsg-2) unstable; urgency=medium
 
   [ Samuel Thibault ]

Bug#928123: unblock: lios/2.7-3

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Please unblock package lios

lios is a graphical interface for performing OCR.

A user reported lios as very partially working on his KDE-based
system. He could run OCR over a whole image, but not select a piece of
the image to e.g. extract columns etc. This is merely due to a missing
dependency on python3-gi-cairo.

Alongside, he reported issues with divisions by zero which have already
been fixed upstream, and lios also not finding his German dictionary
(thus severily limiting the OCR desambiguation capabilities in German),
due to mere typos in the language list.

Eventually, when gnome-icon-theme is not installed the menu icons are
bogus, so this also pulls them.

unblock lios/2.7-3

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
Linux, c'est simple : ça s'adresse à une machine qui est parfois un peu
maraboutée mais qui d'habitude n'a pas d'états d'âme. Sur Usenet y'a
plein d'humains et de primates, et ça devient vraiment gore par moment.
-+- TP in : Guide du linuxien pervers - "Le linuxien a-t-il une âme ?" -+-
diff -Nru lios-2.7/debian/changelog lios-2.7/debian/changelog
--- lios-2.7/debian/changelog   2018-04-29 12:27:19.0 +0200
+++ lios-2.7/debian/changelog   2019-04-28 17:07:47.0 +0200
@@ -1,3 +1,12 @@
+lios (2.7-3) unstable; urgency=medium
+
+  * patches/div0: Avoid division by zero on no selection.
+  * patches/typo: Fix german language ISO code.
+  * control: Add missing python3-gi-cairo dependency (Closes: Bug#927770),
+and recommend gnome-icon-theme to get menu icons.
+
+ -- Samuel Thibault   Sun, 28 Apr 2019 17:07:47 +0200
+
 lios (2.7-2) unstable; urgency=medium
 
   * Add missing gir1.2-gstreamer-1.0 dependency (Closes: Bug#895673).
diff -Nru lios-2.7/debian/control lios-2.7/debian/control
--- lios-2.7/debian/control 2018-04-28 17:02:59.0 +0200
+++ lios-2.7/debian/control 2019-04-28 14:18:23.0 +0200
@@ -11,7 +11,8 @@
 
 Package: lios
 Architecture: all
-Depends: ${python3:Depends}, ${misc:Depends}, python3-gi, gir1.2-gtk-3.0, 
gir1.2-gst-plugins-base-1.0, gir1.2-gstreamer-1.0, gir1.2-vte-2.91, 
python3-sane, python3-speechd, tesseract-ocr, imagemagick, espeak, 
poppler-utils, python3-enchant, aspell-en
+Depends: ${python3:Depends}, ${misc:Depends}, python3-gi, gir1.2-gtk-3.0, 
gir1.2-gst-plugins-base-1.0, gir1.2-gstreamer-1.0, gir1.2-vte-2.91, 
python3-sane, python3-speechd, tesseract-ocr, imagemagick, espeak, 
poppler-utils, python3-enchant, aspell-en, python3-gi-cairo
+Recommends: gnome-icon-theme
 Suggests: cuneiform
 Description: Linux intelligent OCR solution
  Lios provides a graphical interface on top of the Cuneiform and
diff -Nru lios-2.7/debian/patches/div0 lios-2.7/debian/patches/div0
--- lios-2.7/debian/patches/div01970-01-01 01:00:00.0 +0100
+++ lios-2.7/debian/patches/div02019-04-28 17:06:40.0 +0200
@@ -0,0 +1,162 @@
+Part of this is already upstream, the other part has been submitted to
+https://gitlab.com/Nalin-x-Linux/lios-3/merge_requests/5
+---
+ lios/main.py |  126 
+++
+ 1 file changed, 67 insertions(+), 59 deletions(-)
+
+--- a/lios/main.py
 b/lios/main.py
+@@ -1099,27 +1099,29 @@ class linux_intelligent_ocr_solution():
+   #self.make_ocr_widgets_inactive(lock=True)
+   #self.make_preferences_widgets_inactive(lock=True)
+   #self.make_image_widgets_inactive(lock=True)
+-  progress_step = 1/len(self.iconview.get_selected_item_names())
+-  progress = 0;
+-  mode = self.preferences.mode_of_rotation
+-  angle = self.preferences.rotation_angle
+-  for item in self.iconview.get_selected_item_names():
+-  self.notify_information(_("Running OCR on selected 
image {}")
+-  .format(item))
+-  
+-  #self.announce(_("Recognising 
{}").format(self.liststore_images[item[0]][1]))
+-  progress = progress + progress_step;
+-  text,angle = self.ocr(item,mode,angle)
+-  
sel

Bug#926422: unblock: java-atk-wrapper/0.33.3-22

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Please unblock package java-atk-wrapper. As shown in Bug#926420, it has
a strong memory leak and performance issue, as raised upstream on
https://bugzilla.gnome.org/show_bug.cgi?id=791970 and 
https://issues.apache.org/jira/browse/NETBEANS-861
It does not make applications really crash, but the latter report says
it makes the netbeans UI really unresponsive.

unblock java-atk-wrapper/0.33.3-22

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
diff -Nru java-atk-wrapper-0.33.3/debian/changelog 
java-atk-wrapper-0.33.3/debian/changelog
--- java-atk-wrapper-0.33.3/debian/changelog2018-05-02 23:06:45.0 
+0200
+++ java-atk-wrapper-0.33.3/debian/changelog2019-04-04 22:51:05.0 
+0200
@@ -1,3 +1,9 @@
+java-atk-wrapper (0.33.3-22) unstable; urgency=medium
+
+  * patches/remove_component_listener: Fix memory leak (Closes: Bug#926420)
+
+ -- Samuel Thibault   Thu, 04 Apr 2019 22:51:05 +0200
+
 java-atk-wrapper (0.33.3-21) unstable; urgency=medium
 
   * Bump Standards-Version to 4.1.4 (no changes).
diff -Nru java-atk-wrapper-0.33.3/debian/patches/remove_component_listener 
java-atk-wrapper-0.33.3/debian/patches/remove_component_listener
--- java-atk-wrapper-0.33.3/debian/patches/remove_component_listener
1970-01-01 01:00:00.0 +0100
+++ java-atk-wrapper-0.33.3/debian/patches/remove_component_listener
2019-04-04 22:50:49.0 +0200
@@ -0,0 +1,23 @@
+commit f9faf04a88685d6759c18572988876215332086a
+Author: Samuel Thibault 
+Date:   Tue Apr 2 19:55:13 2019 +0200
+
+Fix removing component listener
+
+instead of adding it again.
+
+Fixes https://bugzilla.gnome.org/show_bug.cgi?id=791970
+
+diff --git a/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in 
b/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
+index 0fbb196..3463a59 100644
+--- a/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
 b/wrapper/org/GNOME/Accessibility/AtkWrapper.java.in
+@@ -306,7 +306,7 @@ public class AtkWrapper {
+   case ContainerEvent.COMPONENT_REMOVED:
+   {
+   java.awt.Component c = ((ContainerEvent)e).getChild();
+-c.addComponentListener(componentAdapter);
++c.removeComponentListener(componentAdapter);
+ break;
+   }
+ 
diff -Nru java-atk-wrapper-0.33.3/debian/patches/series 
java-atk-wrapper-0.33.3/debian/patches/series
--- java-atk-wrapper-0.33.3/debian/patches/series   2018-05-02 
22:58:28.0 +0200
+++ java-atk-wrapper-0.33.3/debian/patches/series   2019-04-04 
22:51:05.0 +0200
@@ -19,4 +19,6 @@
 GC
 parameters
 coords
+remove_component_listener
+
 nojavah

Bug#926206: unblock: espeakup/1:0.80-14

[Samuel Thibault]

Package: release.debian.org
Severity: normal
User: release.debian@packages.debian.org
Usertags: unblock

Hello,

Please unblock package espeakup: as reported in Bug#925973, the current
version of espeakup would stop it on preinst and start it on postinst.
For a screen reader for blind users this is really bad because if
anything goes wrong in between, the user is left without a screen
reader. We should thus pass --restart-after-upgrade to dh_systemd_start
to just restart the screen reader after successful upgrade.

Cc-ing kibi because of the udeb: this doesn't have any effect on the
udeb.

unblock espeakup/1:0.80-14

Thanks!

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.0.0 (SMP w/8 CPU cores)
Kernel taint flags: TAINT_CRAP, TAINT_OOT_MODULE
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
il y a 10 catégories de personnes dans le monde : ceux qui comprennent le
binaire, et ceux qui ne le comprennent pas
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog  2019-02-20 15:44:59.0 +0100
+++ espeakup-0.80/debian/changelog  2019-03-29 17:03:23.0 +0100
@@ -1,3 +1,9 @@
+espeakup (1:0.80-14) unstable; urgency=medium
+
+  * rules: Restart espeakup after upgrade (Closes: Bug#925973).
+
+ -- Samuel Thibault   Fri, 29 Mar 2019 17:03:23 +0100
+
 espeakup (1:0.80-13) unstable; urgency=medium
 
   * debian/espeakup.finish-install: Fix writing down card id.
diff -Nru espeakup-0.80/debian/rules espeakup-0.80/debian/rules
--- espeakup-0.80/debian/rules  2019-01-01 17:07:20.0 +0100
+++ espeakup-0.80/debian/rules  2019-03-29 17:03:23.0 +0100
@@ -41,3 +41,6 @@
 override_dh_gencontrol:
echo 'espeak-ng:Version=$(ESPEAK_NG_VERSION)' >> 
debian/espeakup-udeb.substvars
dh_gencontrol
+
+override_dh_systemd_start:
+   dh_systemd_start --restart-after-upgrade

Bug#922974: unblock: nvidia-graphics-drivers/410.93-2

[Samuel Thibault]

Hello,

Andreas Beckmann, le mer. 27 févr. 2019 16:09:15 +0100, a ecrit:
> On Fri, 22 Feb 2019 15:12:17 +0100 Andreas Beckmann  wrote:
> > nvidia-graphics-drivers seems to need a force-hint since it drops the
> > driver parts for i386 and armhf (and the libraries for armhf as well).
> > This makes the arch:all meta-package hashcat-nvidia uninstallable on
> > i386 (since nvidia-smi is gone).
> 
> Hi,
> 
> I'd like to see this sorted out before I upload a new upstream release
> to unstable. Or are there more blockers for the migration that I'm
> currently not aware of? (Cruft packages should not be an issue.)
> 
> There is also #922976 which suggests hashcat to restrict to amd64 and/or
> add alternative dependencies to the respective packages from the 390xx
> legacy driver.

For information, the hashcat-nvidia which has the issue is just
a leaf meta-package with popcon 30, which is just a convenience
package for installing both hashcat and nvidia-opencl-icd which
provides acceleration (hashcat can work without it). The nvidia-smi
dependency is merely for getting the number of GPUs for inclusion in the
tab-completion help.

I don't think anybody still with an i386 system is using this
meta-package, so making it uninstallable on i386 shouldn't hurt anybody
(and we can easily fix that during the freeze).

Samuel

Bug#913942: espeakup 0.80-5+deb9u3 flagged for acceptance

[Samuel Thibault]

Mattia Rizzolo, le dim. 27 janv. 2019 10:50:18 +0100, a ecrit:
> On Sun, Jan 27, 2019 at 10:02:14AM +0100, Samuel Thibault wrote:
> > Adam D Barratt, le ven. 07 déc. 2018 20:04:21 +, a ecrit:
> > > The upload referenced by this bug report has been flagged for acceptance 
> > > into the proposed-updates queue for Debian stretch.
> > 
> > Mmm, I don't see it in debian 9.7?!
> 
> 9.7 was a mini point release which contained only an updated apt, so the
> whole point of 9.7 was to fix 
> https://security-tracker.debian.org/tracker/CVE-2019-3462

Ah, ok, sorry for the noise.

Samuel

Bug#913942: espeakup 0.80-5+deb9u3 flagged for acceptance

[Samuel Thibault]

Hello,

Adam D Barratt, le ven. 07 déc. 2018 20:04:21 +, a ecrit:
> The upload referenced by this bug report has been flagged for acceptance into 
> the proposed-updates queue for Debian stretch.
> 
> Thanks for your contribution!
> 
> Upload details
> ==
> 
> Package: espeakup
> Version: 0.80-5+deb9u3
> 
> Explanation: debian/espeakup.service: Fix compatibility with older versions 
> of systemd

Mmm, I don't see it in debian 9.7?!

Samuel

Bug#913942: stretch-pu: package espeakup/1:0.80-5+deb9u3

[Samuel Thibault]

Cyril Brulebois, le lun. 03 déc. 2018 10:50:06 +0100, a ecrit:
> Julien Cristau  (2018-12-03):
> > > +espeakup (1:0.80-5+deb9u3) stretch; urgency=high
> > > +
> > > +  * debian/espeakup.service: Fix compatibility with older versions of 
> > > systemd
> > > +(Closes: Bug#913453). Also fix starting with empty voice language.
> > > +
> > > + -- Samuel Thibault   Sun, 11 Nov 2018 17:43:08 
> > > +0100
> > > +
> > >  espeakup (1:0.80-5+deb9u2) stretch; urgency=medium
> > >  
> > >* debian/espeakup.service: Automatically load speakup_soft on daemon
> > 
> > Go ahead, thanks.  This will need a d-i ack.
> 
> No objections, thanks.

It is now uploaded, thanks!

Samuel

Bug#913942: stretch-pu: package espeakup/1:0.80-5+deb9u3

[Samuel Thibault]

Samuel Thibault, le sam. 17 nov. 2018 11:44:19 +0100, a ecrit:
> The 1:0.80-5+deb9u3 version I'm proposing has now been tested by the bug
> reporter and others.

(and the change is already in buster)

Samuel

Bug#913942: stretch-pu: package espeakup/1:0.80-5+deb9u3

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I would like to upload to stretch the attached changes.

The 1:0.80-5+deb9u2 upload that got in Debian 9.6 was meant to fix
the installability of the espeakup package on systems with default
configuration.  The change was tested fine in sid then buster.  It
however seems it didn't get enough testing in stretch, and it actually
breaks there :/ because systemd there is stricter on the ExecStart
content, which resulted to Bug#913453, effectively breaking speech
synthesis for non-sighted users :/  Also, when $VOICE is empty, in the
stretch version of espeakup the missing parameter gets a command line
parsing error.

The 1:0.80-5+deb9u3 version I'm proposing has now been tested by the bug
reporter and others.

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'proposed-updates-debug'), (500, 
'proposed-updates'), (500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 
'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), 
(1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Init: systemd (via /run/systemd/system)
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog  2018-11-02 00:39:25.0 +0100
+++ espeakup-0.80/debian/changelog  2018-11-11 17:43:08.0 +0100
@@ -1,3 +1,10 @@
+espeakup (1:0.80-5+deb9u3) stretch; urgency=high
+
+  * debian/espeakup.service: Fix compatibility with older versions of systemd
+(Closes: Bug#913453). Also fix starting with empty voice language.
+
+ -- Samuel Thibault   Sun, 11 Nov 2018 17:43:08 +0100
+
 espeakup (1:0.80-5+deb9u2) stretch; urgency=medium
 
   * debian/espeakup.service: Automatically load speakup_soft on daemon
diff -Nru espeakup-0.80/debian/espeakup.service 
espeakup-0.80/debian/espeakup.service
--- espeakup-0.80/debian/espeakup.service   2018-11-02 00:38:55.0 
+0100
+++ espeakup-0.80/debian/espeakup.service   2018-11-11 17:43:08.0 
+0100
@@ -9,7 +9,7 @@
 PIDFile=/run/espeakup.pid
 Environment="VOICE= ALSA_CARD="
 EnvironmentFile=-/etc/default/espeakup
-ExecStart=sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V ${VOICE}'
+ExecStart=/bin/sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V "${VOICE}"'
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=always
 

Bug#912629: stretch-pu: package espeakup/1:0.80-5+deb9u2

[Samuel Thibault]

Cyril Brulebois, le dim. 04 nov. 2018 15:32:19 +0100, a ecrit:
> Samuel Thibault  (2018-11-02):
> > Adam D. Barratt, le ven. 02 nov. 2018 21:12:37 +, a ecrit:
> > > I'm OK with this, but because espeakup builds a udeb this officially
> > > needs a KiBi-ack (although fwiw I'm assuming the changes don't actually
> > > end up affecting the installer's use).
> > 
> > Indeed, the systemd service is not used inside the installer.
> 
> Right, no objections.

It's now uploaded.

Samuel

Bug#912629: stretch-pu: package espeakup/1:0.80-5+deb9u2

[Samuel Thibault]

Adam D. Barratt, le ven. 02 nov. 2018 21:12:37 +, a ecrit:
> I'm OK with this, but because espeakup builds a udeb this officially
> needs a KiBi-ack (although fwiw I'm assuming the changes don't actually
> end up affecting the installer's use).

Indeed, the systemd service is not used inside the installer.

Samuel

Bug#912629: stretch-pu: package espeakup/1:0.80-5+deb9u2

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: stretch a11y
User: release.debian@packages.debian.org
Usertags: pu

Hello,

We would like to upload the attached change to espeakup in Stretch.

The story is that the init.d script for espeakup used to avoid starting
espeakup if the kernel speakup_soft module is not loaded. When a systemd
service was introduced during for Stretch, that part was not ported
(making a service automatically disabled when a kernel module is not
loaded does not seem to be implemented in systemd), which means that
when installing the espeakup package on a system which doesn't have
speakup_soft loaded, the service start fails, and thus the package
fails to configure. We do not really want to make the espeakup daemon
itself stop reporting an error in such case, and it seems that users'
preference is that the espeakup service just loads the require module
itself anyway, which is what is implemented in the attached changes and
has been used in sid for a week then in testing for a week.

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'testing-debug'), (500, 
'stable-debug'), (500, 'proposed-updates-debug'), (500, 'proposed-updates'), 
(500, 'oldoldstable'), (500, 'buildd-unstable'), (500, 'unstable'), (500, 
'testing'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental-debug'), (1, 
'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.19.0 (SMP w/8 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

-- 
Samuel
"...Deep Hack Mode--that mysterious and frightening state of
consciousness where Mortal Users fear to tread."
(By Matt Welsh)
diff -Nru espeakup-0.80/debian/changelog espeakup-0.80/debian/changelog
--- espeakup-0.80/debian/changelog  2017-12-17 16:35:19.0 +0100
+++ espeakup-0.80/debian/changelog  2018-11-02 00:39:25.0 +0100
@@ -1,3 +1,10 @@
+espeakup (1:0.80-5+deb9u2) stretch; urgency=medium
+
+  * debian/espeakup.service: Automatically load speakup_soft on daemon
+startup.
+
+ -- Samuel Thibault   Fri, 02 Nov 2018 00:39:25 +0100
+
 espeakup (1:0.80-5+deb9u1) stretch; urgency=medium
 
   * debian/espeakup-udeb.start: Fix case where card 0 does not have an id or
diff -Nru espeakup-0.80/debian/espeakup.service 
espeakup-0.80/debian/espeakup.service
--- espeakup-0.80/debian/espeakup.service   2017-12-17 16:35:19.0 
+0100
+++ espeakup-0.80/debian/espeakup.service   2018-11-02 00:38:55.0 
+0100
@@ -9,7 +9,7 @@
 PIDFile=/run/espeakup.pid
 Environment="VOICE= ALSA_CARD="
 EnvironmentFile=-/etc/default/espeakup
-ExecStart=/usr/bin/espeakup -V ${VOICE}
+ExecStart=sh -c 'modprobe speakup_soft && /usr/bin/espeakup -V ${VOICE}'
 ExecReload=/bin/kill -HUP $MAINPID
 Restart=always
 

Re: Re-evaluating architecture inclusion in unstable/experimental

[Samuel Thibault]

Svante Signell, le lun. 03 sept. 2018 01:18:20 +0200, a ecrit:
> On Mon, 2018-09-03 at 01:07 +0200, Samuel Thibault wrote:
> > 
> > > So has the debian patch been submitted in #900240 upstream by you or 
> > > Petter
> > > Reinholdtsen yet? I don't believe so!
> > 
> > I don't think so either, it'd be marked forwarded. That doesn't mean you
> > can't help with it.
> 
> Regardless who is submitting patches upstream, two problem remains:
> 1) The delay until upstream makes a new release.

Nope, the maintainer said he was happy to cherry-pick.

> 2) The delay until the Debian Maintainer creates an updated package from that
> release (if ever). Example: emacs26

Again, cherry-pick don't need to wait for the introduction of the new
release to Debian.

> And how many maintainers do cherry-pick patches accepted upstream, very few 
> :( 

Here the maintainer explicitly said we would happily do it.

Samuel

Re: Re-evaluating architecture inclusion in unstable/experimental

[Samuel Thibault]

Svante Signell, le lun. 03 sept. 2018 01:06:11 +0200, a ecrit:
> On Mon, 2018-09-03 at 00:19 +0200, Samuel Thibault wrote:
> > Felix Geyer wrote:
> > > I suggest that instead you respond to questions on bugs you opened.
> > > I'm not interested in maintaining patches for things that clearly
> > > belong upstream.  Once upstream has reviewed the changes I'm happy to
> > > cherry-pick them.
> 
> This is a comment on the Hurd bug, #900200, not the kfreebsd one, #905138.

That doesn't mean the comment doesn't hold generally.

> And I did not open that bug, you did!

That doesn't mean you can't help with it.

> > And I agree with it (and also one of the reasons why I didn't just
> > NMU-ed cmake with the hurd patch).
> 
> So has the debian patch been submitted in #900240 upstream by you or Petter
> Reinholdtsen yet? I don't believe so!

I don't think so either, it'd be marked forwarded. That doesn't mean you
can't help with it.

Samuel

Re: Re-evaluating architecture inclusion in unstable/experimental

[Samuel Thibault]

Svante Signell, le dim. 02 sept. 2018 23:39:08 +0200, a ecrit:
> On Sun, 2018-09-02 at 19:46 +0200, Samuel Thibault wrote:
> > Svante Signell, le dim. 02 sept. 2018 19:45:19 +0200, a ecrit:
> > > On Sun, 2018-09-02 at 15:21 +0200, Samuel Thibault wrote:
> > > 
> > > > 
> > > > > The statistics and graphs available on the debian-ports page[1] may
> > > > > provide some objective statistics or reflection on the actual
> > > > > suitability of your architecture's continued inclusion.
> > > > >  [1]: https://buildd.debian.org/stats/
> > > > 
> > > > Such statistics are really difficult to get any real conclusion from.
> > > > Sometimes 10% packages are missing just for one tricky nonLinux-specific
> > > > issue in one package.
> > > 
> > > Correct: One example is cmake for both hurd-i386 and kfreebsd-any.
> > > It does not even have to be tricky.
> > 
> > If it's not tricky, a NMU should be able to fix it easily.
> 
> I'm sorry Samuel, I asked both you and James Clarke, Cc:ed, for help on this
> issue and you both said it was not possible to NMU cmake, even if you are both
> DD's.

For my part, I was not talking about that patch, but about the
hurd-related patches.

For others, I can simply quote what was said:

Felix Geyer wrote:
> I suggest that instead you respond to questions on bugs you opened.
> I'm not interested in maintaining patches for things that clearly
> belong upstream.  Once upstream has reviewed the changes I'm happy to
> cherry-pick them.

And I agree with it (and also one of the reasons why I didn't just
NMU-ed cmake with the hurd patch).

> I think that the power of a package maintainer is far too big, making it
> possible to reject/ignore important and other bugs, especially with patches, 
> for
> non-released architectures (and effectively block NMUs).

He is not rejecting things, he is saying that belongs to upstream, which
is true.  Help with that and things will flow.

> I think the next step would be to bring the responsibilities and commitments 
> of
> a Package Maintainer to the TC,

Nope.

> Maybe the recent salvaging of packages could be helpful in the future
> regarding this problem.

Nope.

Samuel

Re: Re-evaluating architecture inclusion in unstable/experimental

[Samuel Thibault]

Svante Signell, le dim. 02 sept. 2018 19:45:19 +0200, a ecrit:
> On Sun, 2018-09-02 at 15:21 +0200, Samuel Thibault wrote:
> 
> > 
> > > The statistics and graphs available on the debian-ports page[1] may
> > > provide some objective statistics or reflection on the actual
> > > suitability of your architecture's continued inclusion.
> > >  [1]: https://buildd.debian.org/stats/
> > 
> > Such statistics are really difficult to get any real conclusion from.
> > Sometimes 10% packages are missing just for one tricky nonLinux-specific
> > issue in one package.
> 
> Correct: One example is cmake for both hurd-i386 and kfreebsd-any.
> It does not even have to be tricky.

If it's not tricky, a NMU should be able to fix it easily.

Samuel

Re: Re-evaluating architecture inclusion in unstable/experimental

[Samuel Thibault]

Hello,

Luke W Faraone, le lun. 27 août 2018 00:33:58 -0700, a ecrit:
> So, in the first instance, would you like to continue being part of
> unstable/experimental?

Well, I can simply point at what we said last time (IIRC) the question
was raised, here are the importants point we see in being on debian
instead of debian-ports:

https://lists.debian.org/debian-devel/2015/05/msg00070.html


Samuel Thibault wrote for the debian-hurd team:
> * Appearing on packages' and maintainers' PTS
> pages like http://buildd.debian.org/bash and
> https://buildd.debian.org/sthiba...@debian.org

This has been changed since then: debian-ports architectures show up
there.


> * Getting binNMUs from d-release transitions

I believe this is also now done for debian-ports architectures? This
really saves a lot of duplicate work for porters.


> * Appearing on http://release.debian.org/transitions/ and
> https://qa.debian.org/dose/debcheck/unstable_main/index.html
> We're fine with d-release not looking at the hurd column. But *we*
> however do look at it, and would be sad to completely lose that. It
> could be in a completely separate page or column, that would not pose
> problem.

I don't know if we have this for debian-ports?


> * Being considered as "second-class citizen"

As said at the time, this is rather already the case.



Luke W Faraone, le lun. 27 août 2018 00:33:58 -0700, a ecrit:
> As outlined on the Debian Archive Criteria page[0], the key points to
> consider are whether the architecture has been part of a stable release,
> whether it is *likely* to be part of a stable release, as well as
> whether it currently has a sensible number of active maintainers.

Considering how even quite a few Linux architectures ports are not
making it, I don't think we could say it likely that hurd-i386 be part
of a stable release.

> Whilst you may be happy to continue the work of maintaining the port
> regardless, don't forget that excess or otherwise unnecessary
> architectures involve a shared maintenance burden as well as incurring
> non-trivial requirements on mirror/Debian resources.

Concerning mirroring, it is indeed useless to mirror hurd-i386
worldwide. Considering maintenance burden, I'm a bit afraid of here
simply moving the load from the ftpmaster team to the debian-ports
ftpmaster team. I don't know the details, so can't say, I'm just Cc-ing
both teams.

> The statistics and graphs available on the debian-ports page[1] may
> provide some objective statistics or reflection on the actual
> suitability of your architecture's continued inclusion.

>  [1]: https://buildd.debian.org/stats/

Such statistics are really difficult to get any real conclusion from.
Sometimes 10% packages are missing just for one tricky nonLinux-specific
issue in one package.

Samuel

Bug#899050: stretch-pu: package accerciser/3.22.0-2

[Samuel Thibault]

Hello,

Adam D. Barratt, le dim. 26 août 2018 15:00:23 +0100, a ecrit:
> On 2018-05-18 18:42, Samuel Thibault wrote:
> > Accerciser is a debugging tool for accessibility (think of it as an
> > accessibility inspector)
> > 
> > The version of accerciser currently in stable is actually basically
> > unusable due to bugs #848119 and #875629. The first prevents the python
> > console from working, thus preventing from hardcode debugging. The
> > second prevents from actually selecting a widget to inspect when not
> > using a desktop compositor, thus preventing basically everything.  The
> > fixes have been tested for a long time in "testing", and are forwarded
> > upstream.
> 
> Please go ahead;

It's now uploaded.

Samuel

Bug#905232: stretch-pu: package brltty/5.4-7+deb9u1

[Samuel Thibault]

Adam D. Barratt, le ven. 17 août 2018 16:18:05 +0100, a ecrit:
> On Wed, 2018-08-01 at 19:09 +0200, Samuel Thibault wrote:
> > The story is that the policykit-1 package was patched in unstable
> > with 0.115/Fix-CVE-2018-1116-Trusting-client-supplied-UID.patch
> > to fix a CVE, and we have noticed that it completely breaks polkit
> > authentication in brlapi, which means that braille does not work in
> > graphical sessions, reported as bug #905058.  This is actually due to
> > a misuse of the polkit API in brltty, which only got to pose problem
> > with the addition of that policykit patch. A brltty fix has been
> > uploaded to unstable so the issue is fixed there.  policykit
> > maintainers however plan to upload their patch to stretch, so we need
> > to upload the brltty fix in stretch too.
> 
> Thanks for fixing this. As brltty produces a udeb, this needs a KiBi-
> ack; tagged and CCing accordingly.

Well, the brltty udeb doesn't contain polkit support, so it should be a
no-op, but better have KiBi aware of the new version indeed :)

Samuel

Bug#905232: stretch-pu: package brltty/5.4-7+deb9u1

[Samuel Thibault]

Package: release.debian.org
Severity: normal
Tags: stretch
User: release.debian@packages.debian.org
Usertags: pu

Hello,

I have uploaded the attached proposed change for stretch.

The story is that the policykit-1 package was patched in unstable with
0.115/Fix-CVE-2018-1116-Trusting-client-supplied-UID.patch
to fix a CVE, and we have noticed that it completely breaks polkit
authentication in brlapi, which means that braille does not work in
graphical sessions, reported as bug #905058.  This is actually due to a
misuse of the polkit API in brltty, which only got to pose problem
with the addition of that policykit patch. A brltty fix has been
uploaded to unstable so the issue is fixed there.  policykit maintainers
however plan to upload their patch to stretch, so we need to upload the
brltty fix in stretch too.

Samuel

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable-debug'), (500, 
'testing-debug'), (500, 'stable-debug'), (500, 'oldoldstable'), (500, 
'buildd-unstable'), (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 
'experimental-debug'), (1, 'buildd-experimental'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.17.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), 
LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
diff -Nru brltty-5.4/debian/changelog brltty-5.4/debian/changelog
--- brltty-5.4/debian/changelog 2017-03-12 15:31:57.0 +0100
+++ brltty-5.4/debian/changelog 2018-08-01 18:14:54.0 +0200
@@ -1,3 +1,9 @@
+brltty (5.4-7+deb9u1) stretch; urgency=medium
+
+  * patches/policykit-fix: Fix polkit authentication (Closes: #905058).
+
+ -- Samuel Thibault   Wed, 01 Aug 2018 18:14:54 +0200
+
 brltty (5.4-7) unstable; urgency=medium
 
   * git-vario-ultra-restart.patch: Fix baum driver restarting when typing too
diff -Nru brltty-5.4/debian/patches/policykit-fix 
brltty-5.4/debian/patches/policykit-fix
--- brltty-5.4/debian/patches/policykit-fix 1970-01-01 01:00:00.0 
+0100
+++ brltty-5.4/debian/patches/policykit-fix 2018-08-01 18:14:54.0 
+0200
@@ -0,0 +1,22 @@
+commit b185abebde8880209c1735e90bc09ed0fce5d9a0
+Author: Samuel Thibault 
+Date:   Wed Aug 1 18:09:16 2018 +0200
+
+Polkit auth: fix authentication failure with CVE-2018-1116 fix
+
+Tell polkit_unix_process_new_for_owner to get process start
+time from /proc, so it matches what the CVE-2018-1116 fix finds.
+
+diff --git a/Programs/auth.c b/Programs/auth.c
+index 26914bf5b..9ad2c63ae 100644
+--- a/Programs/auth.c
 b/Programs/auth.c
+@@ -510,7 +510,7 @@ authPolkit_server (AuthDescriptor *auth, FileDescriptor 
fd, void *data) {
+   if (getsockopt(fd, SOL_SOCKET, SO_PEERCRED, , ) != -1) {
+ logMessage(LOG_DEBUG, "attempting to authenticate pid %d via polkit", 
cred.pid);
+ 
+-PolkitSubject *subject = polkit_unix_process_new_for_owner(cred.pid, -1, 
cred.uid);
++PolkitSubject *subject = polkit_unix_process_new_for_owner(cred.pid, 0, 
cred.uid);
+ if (subject) {
+   GError *error_local = NULL;
+ 
diff -Nru brltty-5.4/debian/patches/series brltty-5.4/debian/patches/series
--- brltty-5.4/debian/patches/series2017-03-12 15:31:57.0 +0100
+++ brltty-5.4/debian/patches/series2018-08-01 18:14:54.0 +0200
@@ -15,3 +15,4 @@
 xbrlapi-nospam.patch
 git-vario-ultra-restart.patch
 disable-synth-callback.patch
+policykit-fix