Bug#770627: pre-approval: unblock: dpkg/1.17.22
clone 771417 -1 retitle -1 dbus: Please (consider) switch(ing) to no-await triggers reassign -1 dbus found -1 1.8.12-1 # /Potential/ jessie blocker severity -1 serious thanks @dbus maintainers, please review the feasibility of switching to no-await triggers (see bottom of my email). If not feasible, the new bug against dbus can be downgraded to wishlist. @apt+dpkg maintainers, please review the middle part. On 2014-11-30 02:52, Guillem Jover wrote: Hi! On Sat, 2014-11-29 at 12:20:45 +0100, Niels Thykier wrote: [...] I just saw #771417, which claims dpkg to have made a regression. I have pulling my unblock until you have had a look at it. Sure. As I mentioned on the bug, this is two issues in apt (#765687 and #771428) and a minor one in dpkg (#771417), which I knew already but forgot to mention on the unblock request. @apt + dpkg, for you: The situation right now: * [apt] #765687 is closed in sid (due to be unblocked) * [apt] #765687 has David saying known issue with dpkg 1.17.21 and cannot be fixed in APT (with that version of dpkg) * [dpkg] #771417 has Guillem saying minor cosmetic issue that cannot be fixed for Jessie. Does this mean that apt/1.0.9.4 and dpkg/1.17.22 will just work(tm) or do one of apt/dpkg need another update? I got unblock requests for both packages right now of which neither are active. What about ordering of the upgrades? Do apt need to be upgraded before dpkg (or vice versa) for this to work? Personally, I am not fond of the idea of having to (potentially) fix all packages using regular (await?) triggers. That said, I am willing to accept one or two fixes for trigger-consuming packages if it will improve the upgrade experience. As I said on the bug, this is just a cosmetic issue, and because it should only happen due to problems elsewhere, I didn't consider it worth fixing for 1.17.x. @dbus: This part is for you. If this cannot be fixed in apt proper (due to requiring it to self-upgrade), then it should be fixable by switching dbus to noawaiting trigger directives (which I think would be correct regardless). Thanks, Guillem Thanks, ~Niels -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/548006a7.5030...@thykier.net
Processed: Re: Bug#770627: pre-approval: unblock: dpkg/1.17.22
Processing control commands: reopen -1 Bug #770627 {Done: Niels Thykier ni...@thykier.net} [release.debian.org] pre-approval: unblock: dpkg/1.17.22 Bug reopened Ignoring request to alter fixed versions of bug #770627 to the same values previously set -- 770627: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770627 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/handler.s.b770627.141726005523299.transcr...@bugs.debian.org
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Control: reopen -1 On 2014-11-28 04:23, Guillem Jover wrote: Hi! On Tue, 2014-11-25 at 08:05:00 +0100, Niels Thykier wrote: Other than that, please go ahead and upload to unstable and notify us once it has been accepted. dpkg 1.17.22 has now been accepted in the archive. Thanks, Guillem Hi, I just saw #771417, which claims dpkg to have made a regression. I have pulling my unblock until you have had a look at it. ~Niels -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/5479ac0d.8030...@thykier.net
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Hi! On Sat, 2014-11-29 at 12:20:45 +0100, Niels Thykier wrote: Control: reopen -1 On 2014-11-28 04:23, Guillem Jover wrote: On Tue, 2014-11-25 at 08:05:00 +0100, Niels Thykier wrote: Other than that, please go ahead and upload to unstable and notify us once it has been accepted. dpkg 1.17.22 has now been accepted in the archive. I just saw #771417, which claims dpkg to have made a regression. I have pulling my unblock until you have had a look at it. Sure. As I mentioned on the bug, this is two issues in apt (#765687 and #771428) and a minor one in dpkg (#771417), which I knew already but forgot to mention on the unblock request. As I said on the bug, this is just a cosmetic issue, and because it should only happen due to problems elsewhere, I didn't consider it worth fixing for 1.17.x. If this cannot be fixed in apt proper (due to requiring it to self-upgrade), then it should be fixable by switching dbus to noawaiting trigger directives (which I think would be correct regardless). Thanks, Guillem -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141130015216.ga19...@gaara.hadrons.org
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Hi! On Sat, 2014-11-29 at 12:20:45 +0100, Niels Thykier wrote: Control: reopen -1 On 2014-11-28 04:23, Guillem Jover wrote: On Tue, 2014-11-25 at 08:05:00 +0100, Niels Thykier wrote: Other than that, please go ahead and upload to unstable and notify us once it has been accepted. dpkg 1.17.22 has now been accepted in the archive. I just saw #771417, which claims dpkg to have made a regression. I have pulling my unblock until you have had a look at it. Oh, almost forgot, there's been also https://lists.debian.org/debian-dpkg/2014/11/msg00053.html, which got introduced in 1.17.22, but that's just part of the problem, there's several other instances in the codebase, affecting compat field names, triggers and conffile handling on versions going as far as the one in stable. So I can finish up a fix for a quickish .23, or just queue it for when the translations deadline is over. Personally I don't think this is urgent. Thanks, Guillem -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141130021004.ga23...@gaara.hadrons.org
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Hi! On Thu, 2014-11-27 at 08:15:02 +0100, Niels Thykier wrote: On 2014-11-27 04:07, Guillem Jover wrote: I'd rather upload 1.17.22 right away to get those fixes into the archive, and prepare a translations-only 1.17.23, but I'll be glad to act on any upload plans that you are comfortable with. Agreed, please do that. I also strongly prefer more testing of dpkg plus a translation-only update afterwards to shorter testing time and rushed translations. With a CfT today/tomorrow with 14 days, we are looking the 12th of December. With a couple of days latency, we will be looking the 16th of December for the (hopefully) finally dpkg upload for Jessie. How do that sound? I am curious since I want to keep track of the (potential) blockers for the release. Sounds perfect! Will be proceeding with that plan then. Thanks, Guillem -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141127145554.gb27...@gaara.hadrons.org
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Hi! On Tue, 2014-11-25 at 08:05:00 +0100, Niels Thykier wrote: Other than that, please go ahead and upload to unstable and notify us once it has been accepted. dpkg 1.17.22 has now been accepted in the archive. Thanks, Guillem -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141128032337.ga3...@gaara.hadrons.org
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Control: tags -1 - moreinfo On Tue, 2014-11-25 at 08:05:00 +0100, Niels Thykier wrote: Control: tags -1 confirmed moreinfo On Sat, 22 Nov 2014 19:26:44 +0100 Guillem Jover guil...@debian.org wrote: Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock I can see some of the patches modify an existing changelog; I assume that only contains the before mentioned translation updates. Yes, some where already in git master, few others where pending in my push. They are all in master now. IRT the string changes done in this version of dpkg, have they already been fixed in git, or you called for a translation update? Right, I was waiting for the approval, to avoid having to possibly revert. I'll probably upload tomorrow, waiting for some of the fast translators that might commit directly. Given the current freeze policy, I'm not sure though what to set the deadline for the CfT (which to be fair I should have sent long ago :/), and if a subsequent translations-only upload (1.17.23) would be allowed after the 5th of Dec, if that should be the CfT deadline, or if I should defer 1.17.22 until translation updates come in? (I thought there was some confusion regarding the freeze policy and translation and doc only uploads? Not sure if it got clarified though.) I'd rather upload 1.17.22 right away to get those fixes into the archive, and prepare a translations-only 1.17.23, but I'll be glad to act on any upload plans that you are comfortable with. Other than that, please go ahead and upload to unstable and notify us once it has been accepted. Thanks! Will notify when the package hits the archive. Regards, Guillem -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20141127030730.ga6...@gaara.hadrons.org
Bug#770627: pre-approval: unblock: dpkg/1.17.22
On 2014-11-27 04:07, Guillem Jover wrote: Control: tags -1 - moreinfo On Tue, 2014-11-25 at 08:05:00 +0100, Niels Thykier wrote: Control: tags -1 confirmed moreinfo [...] I can see some of the patches modify an existing changelog; I assume that only contains the before mentioned translation updates. Yes, some where already in git master, few others where pending in my push. They are all in master now. Excellent, just double checking. IRT the string changes done in this version of dpkg, have they already been fixed in git, or you called for a translation update? [...] I'd rather upload 1.17.22 right away to get those fixes into the archive, and prepare a translations-only 1.17.23, but I'll be glad to act on any upload plans that you are comfortable with. Agreed, please do that. I also strongly prefer more testing of dpkg plus a translation-only update afterwards to shorter testing time and rushed translations. With a CfT today/tomorrow with 14 days, we are looking the 12th of December. With a couple of days latency, we will be looking the 16th of December for the (hopefully) finally dpkg upload for Jessie. How do that sound? I am curious since I want to keep track of the (potential) blockers for the release. Other than that, please go ahead and upload to unstable and notify us once it has been accepted. Thanks! Will notify when the package hits the archive. Regards, Guillem Thanks, ~Niels signature.asc Description: OpenPGP digital signature
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Control: tags -1 confirmed moreinfo On Sat, 22 Nov 2014 19:26:44 +0100 Guillem Jover guil...@debian.org wrote: Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Hi! I'd like to upload dpkg 1.17.22 with the following changes. I've excluded and filtered translation changes. I'm including a patch series instead of a debdiff, because it should be clearer and easier to spot specific changes you might not want to approve? This passes all unit tests, and the functional tests (which I've fixed to comply) from https://anonscm.debian.org/cgit/dpkg/dpkg-tests.git. In addition, I've got some status files that trigger some of the bugs, that I've not yet synthetized, which work fine with the new dpkg. I've also been running this on my main system with daily upgrades for over a week now. Thanks, Guillem Hi Guillem, I can see some of the patches modify an existing changelog; I assume that only contains the before mentioned translation updates. IRT the string changes done in this version of dpkg, have they already been fixed in git, or you called for a translation update? Other than that, please go ahead and upload to unstable and notify us once it has been accepted. ~Niels -- To UNSUBSCRIBE, email to debian-release-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54742a1c.6010...@thykier.net
Bug#770627: pre-approval: unblock: dpkg/1.17.22
Package: release.debian.org Severity: normal User: release.debian@packages.debian.org Usertags: unblock Hi! I'd like to upload dpkg 1.17.22 with the following changes. I've excluded and filtered translation changes. I'm including a patch series instead of a debdiff, because it should be clearer and easier to spot specific changes you might not want to approve? This passes all unit tests, and the functional tests (which I've fixed to comply) from https://anonscm.debian.org/cgit/dpkg/dpkg-tests.git. In addition, I've got some status files that trigger some of the bugs, that I've not yet synthetized, which work fine with the new dpkg. I've also been running this on my main system with daily upgrades for over a week now. Thanks, Guillem From 2d3adc759c37bf73c12730c79b73dc26ca171c7d Mon Sep 17 00:00:00 2001 From: Guillem Jover guil...@debian.org Date: Thu, 6 Nov 2014 18:13:27 +0100 Subject: [PATCH 01/12] man: Add when dpkg-deb --ctrl-tarfile got introduced Missed in commit 03c0873bd720a4f93db0cc4764fa98d3dbcadede. --- debian/changelog| 3 +++ man/dpkg-deb.1 | 2 +- man/po/de.po| 12 +++- man/po/dpkg-man.pot | 8 man/po/es.po| 8 man/po/fr.po| 12 ++-- man/po/hu.po| 8 man/po/it.po| 8 man/po/ja.po| 8 man/po/pl.po| 8 man/po/pt_BR.po | 8 man/po/ru.po| 8 man/po/sv.po| 14 +++--- 13 files changed, 56 insertions(+), 51 deletions(-) diff --git a/debian/changelog b/debian/changelog index a02a208..7e34751 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,5 +1,8 @@ dpkg (1.17.22) UNRELEASED; urgency=low + [ Guillem Jover ] + * Add version introducing --ctrl-tarfile in dpkg-deb(1) man page. + [ Updated programs translations ] * German (Sven Joachim). * French (Sébastien Poher). diff --git a/man/dpkg-deb.1 b/man/dpkg-deb.1 index 09c066c..c5038ec 100644 --- a/man/dpkg-deb.1 +++ b/man/dpkg-deb.1 @@ -174,7 +174,7 @@ The target directory (but not its parents) will be created if necessary. Extracts the control data from a binary package and sends it to standard output in .B tar -format. Together with +format (since dpkg 1.17.14). Together with .BR tar (1) this can be used to extract a particular control file from a package archive. The input archive will always be processed sequentially. -- 2.1.3 From e04dd68c0a36e465a656a9e78830dcf28e455242 Mon Sep 17 00:00:00 2001 From: Guillem Jover guil...@debian.org Date: Mon, 17 Nov 2014 00:55:20 +0100 Subject: [PATCH 02/12] man: Bump minimal version for dir_to_symlink and symlink_to_dir commands The minimal version for dir_to_symlink with all current features is 1.17.13, and for symlink_to_dir is 1.17.14. But to make it simpler, let's just say the latter. This also avoids unnecessary translator work. Missed in commits 7fe9dcdd57c083180a7994957d1e5217d28e970a and a92a3ac5056363e9c21c48187f6ff965481742f4. Closes: #769843 --- debian/changelog | 2 ++ man/dpkg-maintscript-helper.1 | 4 ++-- man/po/de.po | 10 +- man/po/fr.po | 10 +- man/po/sv.po | 10 +- 5 files changed, 19 insertions(+), 17 deletions(-) diff --git a/debian/changelog b/debian/changelog index 7e34751..ec5b9cd 100644 --- a/debian/changelog +++ b/debian/changelog @@ -2,6 +2,8 @@ dpkg (1.17.22) UNRELEASED; urgency=low [ Guillem Jover ] * Add version introducing --ctrl-tarfile in dpkg-deb(1) man page. + * Bump minimal version for dir_to_symlink and symlink_to_dir commands +to 1.17.14 in dpkg-maintscript-helper(1) man page. Closes: #769843 [ Updated programs translations ] * German (Sven Joachim). diff --git a/man/dpkg-maintscript-helper.1 b/man/dpkg-maintscript-helper.1 index 908083d..85185ac 100644 --- a/man/dpkg-maintscript-helper.1 +++ b/man/dpkg-maintscript-helper.1 @@ -230,9 +230,9 @@ using it unconditionally requires a pre-dependency to ensure that the required version of \fBdpkg\fP has been unpacked before. The required version depends on the command used, for \fBrm_conffile\fP and \fBmv_conffile\fP it is 1.15.7.2, for \fBsymlink_to_dir\fP and \fBdir_to_symlink\fP -it is 1.17.5: +it is 1.17.14: .P -\fBPre\-Depends:\fP dpkg (= 1.17.5) +\fBPre\-Depends:\fP dpkg (= 1.17.14) .P But in many cases the operation done by the program is not critical for the package, and instead of using a pre-dependency we can call the -- 2.1.3 From a213746672a3e12a8ef6b86ccf04594bf30e8fba Mon Sep 17 00:00:00 2001 From: Guillem Jover guil...@debian.org Date: Sun, 9 Nov 2014 00:51:42 +0100 Subject: [PATCH 03/12] debian: Reintroduce u-a, dpkg-divert and dpkg-statoverride compat symlinks There are still packages using those paths, but the relevant lintian check did not list any, so these got removed prematurely. --- Makefile.am | 1 + TODO | 2 ++