Re: Pandas new version
On Wed, 06 Feb 2019, Yaroslav Halchenko wrote: ... > = ERRORS > == > _ ERROR collecting > tests/indexes/datetimes/test_tools.py __ > /usr/lib/python2.7/dist-packages/pluggy/hooks.py:284: in __call__ > return self._hookexec(self, self.get_hookimpls(), kwargs) > /usr/lib/python2.7/dist-packages/pluggy/manager.py:67: in _hookexec > return self._inner_hookexec(hook, methods, kwargs) > /usr/lib/python2.7/dist-packages/pluggy/manager.py:61: in > firstresult=hook.spec.opts.get("firstresult") if hook.spec else False, > /usr/lib/python2.7/dist-packages/_pytest/python.py:224: in > pytest_pycollect_makeitem > res = list(collector._genfunctions(name, obj)) > /usr/lib/python2.7/dist-packages/_pytest/python.py:409: in _genfunctions > self.ihook.pytest_generate_tests(metafunc=metafunc) > /usr/lib/python2.7/dist-packages/pluggy/hooks.py:284: in __call__ > return self._hookexec(self, self.get_hookimpls(), kwargs) > /usr/lib/python2.7/dist-packages/pluggy/manager.py:67: in _hookexec > return self._inner_hookexec(hook, methods, kwargs) > /usr/lib/python2.7/dist-packages/pluggy/manager.py:61: in > firstresult=hook.spec.opts.get("firstresult") if hook.spec else False, > /usr/lib/python2.7/dist-packages/_pytest/python.py:133: in > pytest_generate_tests > metafunc.parametrize(*marker.args, **marker.kwargs) > /usr/lib/python2.7/dist-packages/_pytest/python.py:973: in parametrize > param_index, > /usr/lib/python2.7/dist-packages/_pytest/python.py:841: in setmulti2 > self._checkargnotcontained(arg) > /usr/lib/python2.7/dist-packages/_pytest/python.py:825: in > _checkargnotcontained > raise ValueError("duplicate %r" % (arg,)) > E ValueError: duplicate 'box' Seems one seems to relate to pytest version -- with the most recent 4.? (installed via pip) it disappears if I add --continue-on-collection-errors to pytest invocation, I am ending up with ~50 failing tests :-( and 3 errors. pushed my changes and now waiting for another "cleanish" run where I actually store full output since I ran out of terminal buffer to get all those errors for analysis. I think part of the problem is upstream chasing bleeding edges for pytest/numpy/etc in their CI setups and thus loosing idea on how well pandas behaves on existing deployments. E.g. this pytest 4.0 issue - versioned dependency was boosted solely to speed up conda's dependencies resolution... heh heh -- Yaroslav O. Halchenko Center for Open Neuroscience http://centerforopenneuroscience.org Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755 Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419 WWW: http://www.linkedin.com/in/yarik
Re: Pandas new version
any clues on this odd thing? https://github.com/pandas-dev/pandas/issues/25197 (citing here verbatim and entirely) While updating debian package for pandas 0.24.1 running into this odd error with pytest during collection. Just wondered if someone might have an immediate clue so I don't waste too much time trying to catch the ghost (pytest pkg is 3.10.1-2): ``` collected 47434 items / 2 errors / 778 deselected / 3 skipped = ERRORS == _ ERROR collecting tests/indexes/datetimes/test_tools.py __ /usr/lib/python2.7/dist-packages/pluggy/hooks.py:284: in __call__ return self._hookexec(self, self.get_hookimpls(), kwargs) /usr/lib/python2.7/dist-packages/pluggy/manager.py:67: in _hookexec return self._inner_hookexec(hook, methods, kwargs) /usr/lib/python2.7/dist-packages/pluggy/manager.py:61: in firstresult=hook.spec.opts.get("firstresult") if hook.spec else False, /usr/lib/python2.7/dist-packages/_pytest/python.py:224: in pytest_pycollect_makeitem res = list(collector._genfunctions(name, obj)) /usr/lib/python2.7/dist-packages/_pytest/python.py:409: in _genfunctions self.ihook.pytest_generate_tests(metafunc=metafunc) /usr/lib/python2.7/dist-packages/pluggy/hooks.py:284: in __call__ return self._hookexec(self, self.get_hookimpls(), kwargs) /usr/lib/python2.7/dist-packages/pluggy/manager.py:67: in _hookexec return self._inner_hookexec(hook, methods, kwargs) /usr/lib/python2.7/dist-packages/pluggy/manager.py:61: in firstresult=hook.spec.opts.get("firstresult") if hook.spec else False, /usr/lib/python2.7/dist-packages/_pytest/python.py:133: in pytest_generate_tests metafunc.parametrize(*marker.args, **marker.kwargs) /usr/lib/python2.7/dist-packages/_pytest/python.py:973: in parametrize param_index, /usr/lib/python2.7/dist-packages/_pytest/python.py:841: in setmulti2 self._checkargnotcontained(arg) /usr/lib/python2.7/dist-packages/_pytest/python.py:825: in _checkargnotcontained raise ValueError("duplicate %r" % (arg,)) E ValueError: duplicate 'box' __ ERROR collecting tests/resample/test_base.py ___ In test_resample_empty_dataframe_all_ts: function uses no argument '_index_factory' ! Interrupted: 2 errors during collection ! === 3 skipped, 778 deselected, 2 error in 37.76 seconds === ``` All of it with versions etc (click to expand) ``` echo "backend : Agg" >| /build/pandas-0.24.1/build/matplotlibrc : # Run unittests here against installed pandas echo "2.7" | grep -q '^3' && PY=3 || PY=2.7; \ export PYTHONPATH=`/bin/ls -d $PWD/debian/tmp/usr/lib/python$PY/*/`; \ export MPLCONFIGDIR=/build/pandas-0.24.1/build HOME=/build/pandas-0.24.1/build; \ cd build/; \ python2.7 -c 'import pandas as pd; pd.show_versions()'; \ LOCALE_OVERRIDE=C xvfb-run -a -s "-screen 0 1280x1024x24 -noreset" \ python2.7 -m pytest -s -v -m "not single and not network and not disabled "$PYTHONPATH/pandas; INSTALLED VERSIONS -- commit: None python: 2.7.15.final.0 python-bits: 64 OS: Linux OS-release: 4.18.0-0.bpo.1-amd64 machine: x86_64 processor: byteorder: little LC_ALL: C LANG: C LOCALE: None.None pandas: 0.24.1 pytest: 3.10.1 pip: None setuptools: 40.7.1 Cython: 0.29.2 numpy: 1.16.1 scipy: 1.1.0 pyarrow: None xarray: None IPython: 5.8.0 sphinx: 1.8.3 patsy: None dateutil: 2.7.3 pytz: 2018.9 blosc: None bottleneck: None tables: 3.4.4 numexpr: 2.6.9 feather: None matplotlib: 2.2.3 openpyxl: 2.4.9 xlrd: 1.1.0 xlwt: 1.3.0 xlsxwriter: 1.1.2 lxml.etree: 4.3.0 bs4: 4.7.1 html5lib: 1.0.1 sqlalchemy: None pymysql: None psycopg2: None jinja2: 2.10 s3fs: None fastparquet: None pandas_gbq: None pandas_datareader: None gcsfs: None === test session starts === platform linux2 -- Python 2.7.15+, pytest-3.10.1, py-1.7.0, pluggy-0.8.0 -- /usr/bin/python2.7 cachedir: .pytest_cache hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/build/pandas-0.24.1/build/.hypothesis/examples') rootdir: /tmp/buildd/pandas-0.24.1, inifile: setup.cfg plugins: hypothesis-3.71.11 collected 47434 items / 2 errors / 778 deselected / 3 skipped = ERRORS == _ ERROR collecting tests/indexes/datetimes/test_tools.py __ /usr/lib/python2.7/dist-packages/pluggy/hooks.py:284: in __call__ return self._hookexec(self, self.get_hookimpls(), kwargs)
Re: Pandas new version
On Wed, 06 Feb 2019, Ole Streicher wrote: > Yaroslav Halchenko writes: > >> And it also does not solve the problem that updating can introduce > >> regressions in reverse dependencies, which is not the best thing we can > >> do just before freeze. But finally you are the maintainer, if you think > >> that updating is the way to go, just do it ;-) > > Is there any other commit you would like to push on top of your recent > > 721fcf98d4b79d146a92a8d8def8dee1daecb4c0 > > ? > No; I don't have time to look into this until tomorrow night. If you are > going to fix, I will enjoy a free evening ;-) ok, let's see where I would get, I will keep pushing -- Yaroslav O. Halchenko Center for Open Neuroscience http://centerforopenneuroscience.org Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755 Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419 WWW: http://www.linkedin.com/in/yarik
Re: Pandas new version
Yaroslav Halchenko writes: >> And it also does not solve the problem that updating can introduce >> regressions in reverse dependencies, which is not the best thing we can >> do just before freeze. But finally you are the maintainer, if you think >> that updating is the way to go, just do it ;-) > > Is there any other commit you would like to push on top of your recent > 721fcf98d4b79d146a92a8d8def8dee1daecb4c0 > ? No; I don't have time to look into this until tomorrow night. If you are going to fix, I will enjoy a free evening ;-) Cheers Ole
Re: Pandas new version
On Wed, 06 Feb 2019, Ole Streicher wrote: > Yaroslav Halchenko writes: > > On Tue, 05 Feb 2019, Ole Streicher wrote: > >> "Rebecca N. Palmer" writes: > >> > Has anyone checked whether this would break pandas' reverse dependencies? > >> I didn't yet. I just tried to update the packaging to 0.24, which > >> however has a number of test failures, which would need to be discussed > >> with upstream first. > > if not sever - I guess could be patched to be skipped for now and then > > patches picked up to address them? or it was too many/too deep? > If you want: please do it as you like. My own workflow is to first > discuss all failures with upstream, especially when I can't estimate > the impact - sometimes it may be even fault of the package. There were it is the same approach I am taking usually > about ten failures, which makes this already quite an effort. Especially > since I did not work closely with upstream so far (so I don't know them > well, and they don't know me) -- this communication should IMO be done > by the regular maintainer. And, as I wrote, the package rules are a bit > complicated, so I don't want to touch them before they are simplified > (which would add more efforts on top of that). Bringing the other stuff > to gbp standards (pristine-tar etc.) even more. I have been using gbp for it for long time, and there is debian/gbp.conf with all needed settings. pristine-tar is just an option, and I kept burning myself with it too often to rely on it, original author (Joey Hess) even recommended abandoning it at some point in the past. > And it also does not solve the problem that updating can introduce > regressions in reverse dependencies, which is not the best thing we can > do just before freeze. But finally you are the maintainer, if you think > that updating is the way to go, just do it ;-) Is there any other commit you would like to push on top of your recent 721fcf98d4b79d146a92a8d8def8dee1daecb4c0 ? -- Yaroslav O. Halchenko Center for Open Neuroscience http://centerforopenneuroscience.org Dartmouth College, 419 Moore Hall, Hinman Box 6207, Hanover, NH 03755 Phone: +1 (603) 646-9834 Fax: +1 (603) 646-1419 WWW: http://www.linkedin.com/in/yarik