Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread Greg Wooledge
On Mon, Nov 14, 2022 at 08:44:54PM -, Curt wrote:
> On 2022-11-14,   wrote:
> >
> >> https://gitlab.com/muttmua/mutt/-/issues/428
> >
> > Is there a non-javascript-ey way to look at those issues?
> >
> 
> 
> Mutt crashes with SIGSEGV when uid -variable is NULL in 
> pgp_gpgme_extrace_keys().
> 
> Found in Mutt 2.0.5 (Debian 11 + 2.0.5-4.1+deb11u1).
> 
> Reproducible in:
> 
> 2.1.4 (Ubuntu 22.04LTS + binary package 2.1.4-1ubuntu1.1)
> 2.2.6 (Debian 11 + 2.2.6 tarball)
> 2.2.7 (Debian 11 + stable git source)
> Public mailing list archive to problematic mail here (I can provide mbox file 
> from my own archive).
> 
> Simple workaround (crypt-gpgme.c):
> 
> 2425   if (!more)
> 2426+  {
> 2427+if ( uid == NULL )
> 2428+{
> 2429+  err=1;
> 2430+  break;
> 2431+}
> 2432 fprintf (*fp, "%s %5.5s %d/%8s %s %s\n", more ? "sub" : "pub",
> 2433   gpgme_pubkey_algo_name (subkey->pubkey_algo), 
> subkey->length,
> 2434   shortid, date, uid->uid);
> 2435+  }
> 2436   else

Well... I've made a local mutt package with this applied, and I'll see
how it goes.  I didn't save any of the landmine emails, but I'm guessing
there'll be more.



Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread Curt
On 2022-11-14,   wrote:
>
>> https://gitlab.com/muttmua/mutt/-/issues/428
>
> Is there a non-javascript-ey way to look at those issues?
>


Mutt crashes with SIGSEGV when uid -variable is NULL in 
pgp_gpgme_extrace_keys().

Found in Mutt 2.0.5 (Debian 11 + 2.0.5-4.1+deb11u1).

Reproducible in:

2.1.4 (Ubuntu 22.04LTS + binary package 2.1.4-1ubuntu1.1)
2.2.6 (Debian 11 + 2.2.6 tarball)
2.2.7 (Debian 11 + stable git source)
Public mailing list archive to problematic mail here (I can provide mbox file 
from my own archive).

Simple workaround (crypt-gpgme.c):

2425   if (!more)
2426+  {
2427+if ( uid == NULL )
2428+{
2429+  err=1;
2430+  break;
2431+}
2432 fprintf (*fp, "%s %5.5s %d/%8s %s %s\n", more ? "sub" : "pub",
2433   gpgme_pubkey_algo_name (subkey->pubkey_algo), 
subkey->length,
2434   shortid, date, uid->uid);
2435+  }
2436   else





Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread tomas
On Mon, Nov 14, 2022 at 05:46:25PM +0100, Sven Joachim wrote:
> On 2022-11-14 11:39 -0500, Greg Wooledge wrote:
> 
> > If anyone figures out a way to make mutt NOT segfault when reading this
> > type of email, I'd love to hear it.
> 
> Upgrading to 2.2.8 or later should do the trick.  I can confirm that
> mutt 2.2.9-1 in unstable no longer segfaults displaying the message in
> question.

Thanks!

(btw, Gökşin's new message segfaults my mutt, Mutt 2.0.5 (2021-01-21) too)

> https://gitlab.com/muttmua/mutt/-/issues/428

Is there a non-javascript-ey way to look at those issues?

Cheers
-- 
t


signature.asc
Description: PGP signature


Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread David Wright
On Mon 14 Nov 2022 at 11:39:11 (-0500), Greg Wooledge wrote:
> On Mon, Nov 14, 2022 at 07:33:00PM +0300, Gökşin Akdeniz wrote:
> > 14.11.2022 15:26 tarihinde Anssi Saari yazdı:
> > > 
> > > So does mutt try to check the PGP signature in Gökşin's message and
> > > crash due to that or some other issue?
> > > 
> > 
> > I use Thunderbird for reading, composing,sending e-mail and signing and
> > encrypting, decrypting e-mail messages.
> > 
> > Probably it is why mutt and GnuPG had troubles.
> 
> This message also caused mutt to segfault when I tried to open it and
> read it.  I can press L from the index to reply-to-list, which I'm
> doing now.  But I can't read the original.
> 
> If anyone figures out a way to make mutt NOT segfault when reading this
> type of email, I'd love to hear it.

No problem here on bullseye with mutt "Mutt/2.0.5 (2021-01-21)", but
that might be because I'm unconcerned about checking signatures, so
something might be uninstalled or unconfigured. Here's what I see
when Gökşin Akdeniz's second message is read:

--✄

Date: Mon, 14 Nov 2022 19:33:00 +0300
From: Gökşin Akdeniz 
Subject: Re: Causing segmentations fault; Was: Re: No Public Key
X-Original-To: deb...@lionunicorn.co.uk
X-Original-To: lists-debian-u...@bendel.debian.org

[-- PGP output follows (current time: Mon Nov 14 11:05:42 2022) --]
gpg: keyblock resource '/usr/share/keyrings/debian-keyring.pgp': No such file 
or directory
gpg: Signature made Mon Nov 14 10:33:00 2022 CST
gpg:using EDDSA key 9BD18DF7E46ECBFB0E468C6D648AAD2AAA3BAD5F
gpg: Can't check signature: No public key
[-- End of PGP output --]

[-- The following data is signed --]

Subject: Re: Causing segmentations fault; Was: Re: No Public Key

[-- Attachment #1 --]
[-- Type: multipart/mixed, Encoding: 7bit, Size: 9.0K --]

[-- Attachment #1 --]
[-- Type: text/plain, Encoding: base64, Size: 0.5K --]



14.11.2022 15:26 tarihinde Anssi Saari yazdı:

>
> So does mutt try to check the PGP signature in Gökşin's message and
> crash due to that or some other issue?
>

I use Thunderbird for reading, composing,sending e-mail and signing and
encrypting, decrypting e-mail messages.

Probably it is why mutt and GnuPG had troubles.

[-- Attachment #2: OpenPGP public key --]
[-- Type: application/pgp-keys, Encoding: quoted-printable, Size: 8.1K --]

[-- PGP output follows (current time: Mon Nov 14 11:05:42 2022) --]
gpg: keyblock resource '/usr/share/keyrings/debian-keyring.pgp': No such file 
or directory
[-- End of PGP output --]

[-- BEGIN PGP PUBLIC KEY BLOCK --]
pub   ed25519 2022-02-13 [SC] [expires: 2023-02-13]
  9BD18DF7E46ECBFB0E468C6D648AAD2AAA3BAD5F
uid   Gökşin Akdeniz (*BSD User, GNU/Linux User, eniXma Founder, eniXma 
Author, Scholar)
+
sub   cv25519 2022-02-13 [E] [expires: 2023-02-13]
pub   rsa4096 2020-02-08 [SCEA] [revoked: 2021-03-29]
  D33E279317FA00ACB438E040F4E1EEA55B6F910A
sub   rsa4096 2020-02-08 [E] [revoked: 2021-03-29]
pub   rsa2048 2015-01-06 [SCEA] [revoked: 2016-05-04]
  5584E544E1541B128ADD4802DDC4D6DAAC7DCCF7
sub   rsa2048 2015-01-06 [E] [revoked: 2016-05-04]
pub   rsa4096 2019-02-06 [SCEA] [revoked: 2020-02-08]
  00E7125AF1F0BD88BAB4D5E9443D65289EFEC656
sub   rsa4096 2019-02-06 [E] [revoked: 2020-02-08]

[-- END PGP PUBLIC KEY BLOCK --]



[-- End of signed data --]

--✄

Make of that what you will.

Cheers,
David.


Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread Sven Joachim
On 2022-11-14 11:39 -0500, Greg Wooledge wrote:

> If anyone figures out a way to make mutt NOT segfault when reading this
> type of email, I'd love to hear it.

Upgrading to 2.2.8 or later should do the trick.  I can confirm that
mutt 2.2.9-1 in unstable no longer segfaults displaying the message in
question.

https://gitlab.com/muttmua/mutt/-/issues/428

Cheers,
   Sven



Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread Greg Wooledge
On Mon, Nov 14, 2022 at 07:33:00PM +0300, Gökşin Akdeniz wrote:
> 
> 
> 14.11.2022 15:26 tarihinde Anssi Saari yazdı:
> 
> > 
> > So does mutt try to check the PGP signature in Gökşin's message and
> > crash due to that or some other issue?
> > 
> 
> I use Thunderbird for reading, composing,sending e-mail and signing and
> encrypting, decrypting e-mail messages.
> 
> Probably it is why mutt and GnuPG had troubles.

This message also caused mutt to segfault when I tried to open it and
read it.  I can press L from the index to reply-to-list, which I'm
doing now.  But I can't read the original.

If anyone figures out a way to make mutt NOT segfault when reading this
type of email, I'd love to hear it.



Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread Gökşin Akdeniz



14.11.2022 15:26 tarihinde Anssi Saari yazdı:



So does mutt try to check the PGP signature in Gökşin's message and
crash due to that or some other issue?



I use Thunderbird for reading, composing,sending e-mail and signing and 
encrypting, decrypting e-mail messages.


Probably it is why mutt and GnuPG had troubles.


OpenPGP_0x648AAD2AAA3BAD5F_and_old_rev.asc
Description: OpenPGP public key


OpenPGP_signature
Description: OpenPGP digital signature


Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread Anssi Saari
steve  writes:

> Le 14-11-2022, à 08:58:02 +0100, to...@tuxteam.de a écrit :
>
>>On Mon, Nov 14, 2022 at 08:51:47AM +0100, Henning Follmann wrote:
>>
>>[...]
>>
>>> Mutt crashes trying to open this post (while opening gnupg).
>>> That's weird.
>>
>>Confirmed.
>
> Here too.
>
> mutt 2.2.7 (2022-08-07)

So does mutt try to check the PGP signature in Gökşin's message and
crash due to that or some other issue?



Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread Thomas Pircher

Henning Follmann wrote:

Mutt crashes trying to open this post (while opening gnupg).
That's weird.


When I save the message as attachment, and run gnupg over it, I get this
error message

| gpg: CRC error; 3B73F1 - DC33B7
| gpg: quoted printable character in armor - probably a buggy MTA has been used

GnuPG exits with error code 2. I guess mutt does gpg not expect to fail.

Thomas



Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-14 Thread steve

Le 14-11-2022, à 08:58:02 +0100, to...@tuxteam.de a écrit :


On Mon, Nov 14, 2022 at 08:51:47AM +0100, Henning Follmann wrote:

[...]


Mutt crashes trying to open this post (while opening gnupg).
That's weird.


Confirmed.


Here too.

mutt 2.2.7 (2022-08-07)



Re: Causing segmentations fault; Was: Re: No Public Key

2022-11-13 Thread tomas
On Mon, Nov 14, 2022 at 08:51:47AM +0100, Henning Follmann wrote:

[...]

> Mutt crashes trying to open this post (while opening gnupg).
> That's weird.

Confirmed.

Cheers
-- 
t


signature.asc
Description: PGP signature