Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
I just decided that I will go for dhewm3 as package name. -- tobi Ok, I fixed that in the yaml + added try_repack_from: [/usr/local/share/dhewm3]. I compiled dhewm3 with a modified config.h #define BUILD_DATADIR /usr/share/games/doom3 the game run fine, so far so good. The Classic Doom3 mod in doom3-classic-data loads correctly, then dhewm3 segfaults after 1 second of play :-( The list of needed files on dhewm3 FAQ seems not very accurate; I ran the binary through my strace wrapper (in make-template) and the game??.pk4 are of course needed too. Didn't try 'Ressurection Of Evil' (d3xp) expansion yet. Note, there's no pak000 on the DVD... I'll check this again, I have one file that is 525767Mb Alexandre -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/20345064.an6R6ikuia@antec
Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Hi Alexandre, Am Sonntag, den 15.02.2015, 09:04 +0100 schrieb Alexandre Detiste: I just decided that I will go for dhewm3 as package name. -- tobi Ok, I fixed that in the yaml + added try_repack_from: [/usr/local/share/dhewm3]. I compiled dhewm3 with a modified config.h #define BUILD_DATADIR /usr/share/games/doom3 the game run fine, so far so good. I'll just pushed a new doom3.yaml to the gbp repository which reflects my actual packaging. The package is also setup to looks in /usr/share/games/doom3 and will auto-update the gamedata if neccessary. (But maybe you can take a look at my commit -- It seemed to ignore the longname for the RoE expansion pack, the resulting package doom3-resurrection-data had as Description: Doom 3 (original or BFG Edition) -- I expected to gdp to use the longname specified in its packages: specification; I worked around by specifiing it in the doom3-resurrection-data.control.in, which I had anyway to specify the correct dependencies on the game logic *.so) The Classic Doom3 mod in doom3-classic-data loads correctly, then dhewm3 segfaults after 1 second of play :-( The list of needed files on dhewm3 FAQ seems not very accurate; I ran the binary through my strace wrapper (in make-template) and the game??.pk4 are of course needed too. Regarding the gmae??.pk4 -- they seem not to be needed; my copy runs without them. Could it be that the game engine tries to load stuff from it when it sees it? As game01.pk4 seems to contains a gamex86.so, this could be the cause of the crash.. (only speculations, I didn't try) Below I paste ls -la /usr/share/games/doom3/* -- this works here. Didn't try 'Ressurection Of Evil' (d3xp) expansion yet. Note, there's no pak000 on the DVD... I'll check this again, I have one file that is 525767Mb Alexandre The dhewm3 packge is now in NEW, the repository here: https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-games/dhewm3.git Regarding the d3xp' pak000 -- ignore my mumbling, I found the pak000 now on another CD. The earlier one was only the original game, but already included the patch already. That apperantly confused me. Now I'll start working on the gbp part for the bfg edition... -- tobi tobi@edoras:~$ ls -la /usr/share/games/doom3/* /usr/share/games/doom3/base: insgesamt 1519632 drwxr-xr-x 2 root root 4096 Feb 14 16:55 . drwxr-xr-x 4 root root 4096 Feb 14 19:13 .. -rw-r--r-- 1 root root 353159257 Jul 11 2004 pak000.pk4 -rw-r--r-- 1 root root 229649726 Jul 8 2004 pak001.pk4 -rw-r--r-- 1 root root 416937674 Jul 8 2004 pak002.pk4 -rw-r--r-- 1 root root 317590154 Jul 8 2004 pak003.pk4 -rw-r--r-- 1 root root 237752384 Jul 6 2004 pak004.pk4 -rw-r--r-- 1 root root552334 Feb 15 2005 pak005.pk4 -rw-r--r-- 1 root root218751 Feb 15 2005 pak006.pk4 -rw-r--r-- 1 root root192031 Apr 27 2005 pak007.pk4 -rw-r--r-- 1 root root 12243 Jan 17 2007 pak008.pk4 /usr/share/games/doom3/d3xp: insgesamt 525880 drwxr-xr-x 2 root root 4096 Feb 14 16:55 . drwxr-xr-x 4 root root 4096 Feb 14 19:13 .. -rw-r--r-- 1 root root 538385153 Feb 8 2005 pak000.pk4 -rw-r--r-- 1 root root 99336 Apr 7 2005 pak001.pk4 -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1424002190.5746.16.ca...@debian.org
Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
On 15/02/15 11:38, Tobias Frost wrote: +Recommends: dhewm3-d3xp You could use 'debian: engine: dhewm3-d3xp', assuming dhewm3-d3xp Depends on any other parts of dhewm3 that it needs. Alternatively, you could bundle together the open-source bits for both the base game and RoE in one .deb, just like Quake 3 + Team Arena, and use symlinks or TryExec to hide the RoE launcher if the RoE data is not installed. On 15/02/15 12:09, Tobias Frost wrote: (But maybe you can take a look at my commit -- It seemed to ignore the longname for the RoE expansion pack, the resulting package doom3-resurrection-data had as Description: Doom 3 (original or BFG Edition) -- I expected to gdp to use the longname specified in its packages: specification; I worked around by specifiing it in the doom3-resurrection-data.control.in, which I had anyway to specify the correct dependencies on the game logic *.so) This logic: if package.expansion_for: short_desc = 'extra data for ' + self.longname else: short_desc = 'data for ' + longname is not great when self.longname is something like Doom 3 (original or BFG edition). We would probably get better results by using short_desc = 'data for ' + longname unconditionally. We could maybe also replace: if package.expansion_for: long_desc += ' Expansion: ' + longname else: long_desc += ' Game: ' + longname with: if package.expansion_for: game_name = self.packages[package.expansion_for].longname or self.longname long_desc += ' Game: ' + game_name + '\n' long_desc += ' Expansion: ' + longname else: long_desc += ' Game: ' + longname Regards, S -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54e0a2f9.4080...@debian.org
Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Hi Simon, Am Sonntag, den 15.02.2015, 13:45 + schrieb Simon McVittie: On 15/02/15 11:38, Tobias Frost wrote: +Recommends: dhewm3-d3xp You could use 'debian: engine: dhewm3-d3xp', assuming dhewm3-d3xp Depends on any other parts of dhewm3 that it needs. Tried that, but I liked the feature of gdp to recognize that this is an extension and that you'll need both. I just saw that you merged Alexandres branch and I notices that the game*.pk4 are installed too. Don't do that it works here without and it seems that Alexandre had crashed as the engine tried to load the so in one of those. The attached patch removes those. -- tobi diff --git a/data/doom3.yaml b/data/doom3.yaml index 8973e25..f232114 100644 --- a/data/doom3.yaml +++ b/data/doom3.yaml @@ -13,10 +13,6 @@ packages: steam: id: 9050 install: -- base/game00.pk4 -- base/game01.pk4 -- base/game02.pk4 -- base/game03.pk4 - base/pak000.pk4 - base/pak001.pk4 - base/pak002.pk4 @@ -37,9 +33,6 @@ packages: id: 9070 install_to: usr/share/games/doom3 install: -- d3xp/game01.pk4 -- d3xp/game02.pk4 -- d3xp/game03.pk4 - d3xp/pak000.pk4 - d3xp/pak001.pk4 @@ -839,16 +832,10 @@ files: unpack: format: 7z provides: -- base/game01.pk4 -- base/game02.pk4 -- base/game03.pk4 - base/pak005.pk4 - base/pak006.pk4 - base/pak007.pk4 - base/pak008.pk4 -- d3xp/game01.pk4 -- d3xp/game02.pk4 -- d3xp/game03.pk4 - d3xp/pak001.pk4 classic_doom_3_1.3.1.exe: @@ -902,10 +889,6 @@ files: cksums: | 3705538269 21145838 doom3-linux-1.3.1.1304.x86.run - 698551627 963485base/game00.pk4 - 1740423552 1542504 base/game01.pk4 - 143642192 1789687 base/game02.pk4 - 3855177723 965775base/game03.pk4 3020409499 353159257 base/pak000.pk4 1437100813 229649726 base/pak001.pk4 2513550240 416937674 base/pak002.pk4 @@ -916,9 +899,6 @@ cksums: | 1446435975 192031base/pak007.pk4 3955608439 12243 base/pak008.pk4 _ 17811 License.txt - 691409431 1645741 d3xp/game01.pk4 - 255066 1888500 d3xp/game02.pk4 - 1141627363 1035335 d3xp/game03.pk4 1892025358 99336 d3xp/pak001.pk4 _ 50cdoom/Classic Doom 3.url @@ -1636,10 +1616,6 @@ cksums: | md5sums: | 6325f0936f59420d33668754032141cb doom3-linux-1.3.1.1304.x86.run - 0a2843d900347a0bf8c2b556ff8652b2 base/game00.pk4 - 197f85d31672a7fb5a145e88e0ab3519 base/game01.pk4 - 425173e95a5a4115127662077e4e877b base/game02.pk4 - 882c1b0aaad0bf62dde6df43048a base/game03.pk4 71b8d37b2444d3d86a36fd61783844fe base/pak000.pk4 4bc4f3ba04ec2b4f4837be40e840a3c1 base/pak001.pk4 fa84069e9642ad9aa4b49624150cc345 base/pak002.pk4 @@ -1650,9 +1626,6 @@ md5sums: | 6319f086f930ec1618ab09b4c20c268c base/pak007.pk4 28750b7841de9453eb335bad6841a2a5 base/pak008.pk4 0e6dea0e5505da10e8fdf6c98a76271a License.txt - 5a83710af3530b4fb4ed86c19b9a1b2a d3xp/game01.pk4 - 4ecfcd51e4b45534fc1968b1b69619d4 d3xp/game02.pk4 - eb9b5260b8695a764832a30e32ded796 d3xp/game03.pk4 a883fef0fd10aadeb73d34c462ff865d d3xp/pak000.pk4 06fc9be965e345587064056bf22236d2 d3xp/pak001.pk4 @@ -2392,14 +2365,7 @@ sha1sums: | de543a0369dbae3d4181f2c727085adb89ef3531 base/pak006.pk4 662a4014dabe26bcdd988877fadaff7d6a09725c base/pak007.pk4 c50bf2c97e989aa19ad27fe62e67c5cfc6ae2a8b base/pak008.pk4 - 8514ef18e32b157e07a45400d6283ef5f555bc80 base/game00.pk4 - 711948baf6fa62aa8325ddfee4370282911977dd base/game01.pk4 - 4b5e447c1fe0b9f87865e6b638a93e055e3c5e16 base/game02.pk4 - 5efc59540da641f58b17a1d410cee37ef95d3d46 base/game03.pk4 846b7e0d931d48d08ee45cf226a5dbe7dba59861 License.txt - 97d21648b424f1f6f8c11456166fd6e38e24abe0 d3xp/game01.pk4 - 22c7f6117043b2ddd10d9076336cce67bfd15a90 d3xp/game02.pk4 - 46230705a87cf88f1fa4a6094abc3c7cdf1ab428 d3xp/game03.pk4 0d9ca3d4532c0d412fbb64ab2885f52ef8852594 d3xp/pak001.pk4 7fdba41af0521cdb815cad272499b888a348acfd cdoom/Classic Doom 3.url @@ -3129,10 +3095,6 @@ sha1sums: | sha256sums: | 2f90dff20f2d3c0c47f17b3d6d45c4f0e7d27b986bf6084f21b85180cd1e03b4 doom3-linux-1.3.1.1304.x86.run - 637985b519a35afb20bb4fa93e31fd3d4789bfaf75135b1ac3b15120cb4acc11 base/game00.pk4 - 510ed64ea6866f6c75d9d72a5e2735b863e4dfb559ac390b5b24a37f8ddd7813 base/game01.pk4 - 69ab195967817b0e22dbf8ab126ff073cfb56332c327da6789736e3074b73cc4 base/game02.pk4 - 25454a2d05204f09795ade93aac849cb119daf27395516704eb7bb9ea36cf9f6 base/game03.pk4 220513bba8cc51191738b52b4ea320cd3376736e13147e240aa503622aa926ce base/pak000.pk4 dc85da3d731793f2973ffb7ef31be17057e88dee0b1157531c7f26a7b33c8fc0 base/pak001.pk4 52d50dc300c87c484a0d7bc28c64777cafd7d581a91b5eeb6222991e328b7f1c base/pak002.pk4 @@ -3143,9 +3105,6 @@ sha256sums: | e5d57ede9def75c7cbb0542ceef6ad56147c9a2162c8517f716410b9092965a0 base/pak007.pk4
Bug#764200: : Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
I notice you packaged dhewm3 (the engine) and dhewm3-doom3 (the game-code) as separate binary packages. Is there any reason to separate them? Would someone ever want to install dhewm3 but not dhewm3-doom3? Maybe someone would want to play the Classic Doom3 mod without even owning the original Doom3 game... But the License.txt forbids it 'This modification is only for use with a legitimate version of the game Doom 3, created by id Software.'; so I also don't see the point of splitting dhewm3-doom3 (=base.so) out of dhewm3 I just saw that you merged Alexandres branch and I notices that the game*.pk4 are installed too. Don't do that it works here without and it seems that Alexandre had crashed as the engine tried to load the so in one of those. The attached patch removes those. Dropped them, thanks. Thansk for fixing this. These indeed only contained binary code (gamex86.dll, gamex86.so,...) Segfault with Classic mod remains even after removing those, and the ones supplied with this mod: - cdoom/cdoom_dll.pk4 = gamex86.dll - cdoom/cdoom_linux.pk4 = gamex86.so - cdoom/cdoom_mac.pk4 = game.dylib We'd need a dhewm3-classic package with a 'cdoom.so' to make it work ? cdoom/fan_extras/cdoomsource_131/readme.txt syas: Simply install a fresh copy of the Doom 3 1.3.1 SDK and unzip the contents of this package into the /src/ directory. -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/59345374.7prNGafIRE@antec
Bug#764200: : Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
On 15/02/15 22:40, Alexandre Detiste wrote: I notice you packaged dhewm3 (the engine) and dhewm3-doom3 (the game-code) as separate binary packages. Is there any reason to separate them? Would someone ever want to install dhewm3 but not dhewm3-doom3? Maybe someone would want to play the Classic Doom3 mod without even owning the original Doom3 game... But the License.txt forbids it Even if there are OpenArena- or Urban-Terror-style standalone games running on the Doom 3 engine, how big is the Doom 3 game-code compared with those games? ioquake3 can be used to play a standalone game like OpenArena, which does not need the Quake III Arena or Team Arena game-code (it ships its own modified version of the GPL'd game-code), but I ship the Q3A and Q3TA game-code as part of ioquake3 anyway. For OpenArena players, it's unnecessary - but it's approximately 3MiB, which is tiny compared with the 411MiB of assets (mostly textures) needed to play OpenArena. With that sort of ratio, splitting it out into its own binary package seems pointless. S -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54e12343.6030...@debian.org
Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
On 15/02/15 18:09, Tobias Frost wrote: Am Sonntag, den 15.02.2015, 13:45 + schrieb Simon McVittie: On 15/02/15 11:38, Tobias Frost wrote: +Recommends: dhewm3-d3xp You could use 'debian: engine: dhewm3-d3xp', assuming dhewm3-d3xp Depends on any other parts of dhewm3 that it needs. Tried that, but I liked the feature of gdp to recognize that this is an extension and that you'll need both. I don't think that actually conflicts with declaring the engine to be different? I notice you packaged dhewm3 (the engine) and dhewm3-doom3 (the game-code) as separate binary packages. Is there any reason to separate them? Would someone ever want to install dhewm3 but not dhewm3-doom3? Similarly, is there a reason not to bundle d3xp game-code in with the dhewm3 engine? Presumably it's really small when compared with the *.pk4 you need to run the thing. (That was my reasoning for including the optional Quake III Team Arena game-code in ioquake3.) I just saw that you merged Alexandres branch and I notices that the game*.pk4 are installed too. Don't do that it works here without and it seems that Alexandre had crashed as the engine tried to load the so in one of those. The attached patch removes those. Dropped them, thanks. S -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54e10699.5030...@debian.org
Bug#764200: : Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Am Sonntag, den 15.02.2015, 23:40 +0100 schrieb Alexandre Detiste: I notice you packaged dhewm3 (the engine) and dhewm3-doom3 (the game-code) as separate binary packages. Is there any reason to separate them? Would someone ever want to install dhewm3 but not dhewm3-doom3? With that I try to underline a better split between true free and contrib packages -- the engine truely free and the so's contrib. (Ok, the game logic is also GPL but it needs data.. But AFAIS you could also base a mod on the game logic) (Hell, we'd need a SDK, a libdhewm3-dev too, And you get multiarch. (though I need still to tag it, because I did not test it yet) Maybe someone would want to play the Classic Doom3 mod without even owning the original Doom3 game... But the License.txt forbids it 'This modification is only for use with a legitimate version of the game Doom 3, created by id Software.'; so I also don't see the point of splitting dhewm3-doom3 (=base.so) out of dhewm3 I just saw that you merged Alexandres branch and I notices that the game*.pk4 are installed too. Don't do that it works here without and it seems that Alexandre had crashed as the engine tried to load the so in one of those. The attached patch removes those. Dropped them, thanks. Thansk for fixing this. These indeed only contained binary code (gamex86.dll, gamex86.so,...) Segfault with Classic mod remains even after removing those, and the ones supplied with this mod: - cdoom/cdoom_dll.pk4 = gamex86.dll - cdoom/cdoom_linux.pk4 = gamex86.so - cdoom/cdoom_mac.pk4 = game.dylib We'd need a dhewm3-classic package with a 'cdoom.so' to make it work ? Probably. However licensing is clear: You cannot use it with dhewm3, as it is not from id-soft. Maybe we could contact the author to see if they are willing to relax this by clearifing that they are ok with GPL'ed forks with the origin at id soft. I see some source code where they claim to include changed files from the SDK (but didnt check the details) cdoom/fan_extras/cdoomsource_131/readme.txt syas: Simply install a fresh copy of the Doom 3 1.3.1 SDK and unzip the contents of this package into the /src/ directory. Have to got to work now, see you -- tobi -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1424067736.9145.16.ca...@debian.org
Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Regarding the d3xp' pak000 -- ignore my mumbling, I found the pak000 now on another CD. The earlier one was only the original game, but already included the patch already. That apperantly confused me. -- tobi /usr/share/games/doom3/d3xp: -rw-r--r-- 1 root root 538385153 Feb 8 2005 pak000.pk4 -rw-r--r-- 1 root root 99336 Apr 7 2005 pak001.pk4 Ok, I've added this one file to my repo. git diff -U0 HEAD~1 diff --git a/data/doom3.yaml b/data/doom3.yaml index f232114..801a63e 100644 --- a/data/doom3.yaml +++ b/data/doom3.yaml @@ -901,0 +902 @@ cksums: | + 2831166546 538385153 d3xp/pak000.pk4 @@ -2368,0 +2370 @@ sha1sums: | + 4a40e1f4ef41341a122d405930a6edb825b720e9 d3xp/pak000.pk4 @@ -3107,0 +3110 @@ sha256sums: | + b5236ac25be28e1cb6021e54dfff595ac569eaea350c199f2eb5b6ba0df67f08 d3xp/pak000.pk4 -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/14100851.VzIcaMIPdj@antec
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Am Montag, den 09.02.2015, 11:25 + schrieb Simon McVittie: On 08/02/15 18:47, Alexandre Detiste wrote: I would personally have just called the engine package dhewm3 (like the way I packaged ioquake3, iortcw and openjk), but it's up to you. I just decided that I will go for dhewm3 as package name. -- tobi -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1423859421.4975.0.ca...@debian.org
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Am Sonntag, den 08.02.2015, 19:47 +0100 schrieb Alexandre Detiste: Le samedi 7 février 2015, 18:07:34 Tobias Frost a écrit : Am Samstag, den 07.02.2015, 15:21 + schrieb Simon McVittie: I'm happy to merge a patch, but I don't have Doom 3 (either the original or the BFG edition) so someone else will have to contribute the necessary file-list and checksums. As I own both, maybe I can help here. Gianfranco gave me some instructions how to generate the yaml file, but I'm not sure if it's complete and what else is required. (It's still building, so I follow up later) Thansk for the files, I only needed to remove the references to doom.wad, doom2.wad and nerve.wad; these are already handled by other yaml files. note sure what's the effect... but the bfg edition includes those games as well, so they also need to be installed. -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1423514618.934.3.ca...@debian.org
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
On 08/02/15 18:47, Alexandre Detiste wrote: Thansk for the files, I only needed to remove the references to doom.wad, doom2.wad and nerve.wad; these are already handled by other yaml files. Some review: +packages: ... +install_to: usr/share/games/dhewm3 I would rather have new games consistently install their data to the default location (/usr/share/games/PACKAGENAME) or some other engine-agnostic location, and use configuration or symlinks in the game engine package (or the game wrapper package like src:quake, where the engine and the game are not a 1:1 match) where necessary to get that data loaded. Remember that the packages produced by game-data-packager are not automatically updated for newer g-d-p versions, so 99% of users will probably build them once and never touch them again. It would be a shame if switching from dhewm3 to some other Doom3 engine (e.g. if iodoom3 becomes a better option in future) broke g-d-p's data packages. In this case I think I would have both D3 and D3:ROE install to usr/share/games/doom3-data, and have D3:BFG install to usr/share/games/doom3-bfg-data. + doom3-data: +debian: + engine: doom3-dhewm3 I would personally have just called the engine package dhewm3 (like the way I packaged ioquake3, iortcw and openjk), but it's up to you. +install_to: usr/share/games/doom3bfg Again, I'd have used doom3-bfg-data here. If the upstream versions of dhewm3 and rbdoom3bfg, or the proprietary Linux binaries from id Software (if any), have default search paths in /usr/share or /usr/local, you can use try_repack_from: (see quake3.yaml) to add those to g-d-p's list. That might help to automate the process for some people. Regards, S -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54d89917.2070...@debian.org
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Le lundi 9 février 2015, 11:25:11 Simon McVittie a écrit :
On 08/02/15 18:47, Alexandre Detiste wrote:
Thansk for the files, I only needed to remove the references to doom.wad,
doom2.wad
and nerve.wad; these are already handled by other yaml files.
Some review:
+packages:
...
+install_to: usr/share/games/dhewm3
I would rather have new games consistently install their data to the
default location (/usr/share/games/PACKAGENAME)
I agree, but this -data in package name sounds completely extraneous,
why not use /usr/share/games/PACKAGENAME.rstrip('-data') instead as default ?
This would stick with what the other games do;
even the free ones like neverball-data for exampe.
tchet@antec:~$ ls /usr/share/games/ | wc -l
56
tchet@antec:~$ ls /usr/share/games/ -l | grep data
drwxr-xr-x 3 root root 20480 jan 22 18:43 game-data-packager
drwxr-xr-x 4 root root 4096 jan 13 22:57 quake3-data
drwxr-xr-x 3 root root 4096 jan 28 12:37 quake3-team-arena-data
drwxr-xr-x 3 root root 4096 déc 31 12:08 rtcw-data
(and quake3-data is a link-farmed from quake3 anyway)
engine-agnostic location
ok, so doom3.yaml should be changed and the two engines too.
In this case I think I would have both D3 and D3:ROE install to
usr/share/games/doom3-data, and have D3:BFG install to
usr/share/games/doom3-bfg-data.
--
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/3023201.Y1GnqtMaK2@antec
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
On 09/02/15 11:43, Alexandre Detiste wrote:
Le lundi 9 février 2015, 11:25:11 Simon McVittie a écrit :
I would rather have new games consistently install their data to the
default location (/usr/share/games/PACKAGENAME)
I agree, but this -data in package name sounds completely extraneous,
why not use /usr/share/games/PACKAGENAME.rstrip('-data') instead as default
?
rstrip doesn't work like you think it does, but I get the general idea.
I used PACKAGENAME instead of (PACKAGENAME with any trailing -data
removed) because when you're making an essentially arbitrary design
choice, I think there's value in choosing the option that is easiest to
document. However, I do see your point, and removing -data by default
would also be OK (but please do not break existing games).
game-data-packager-produced packages are a bit special, because they are
non-distributable and difficult to update. As a result, I would like to
encourage this rule of thumb: g-d-p-produced packages are a container
for proprietary data files that we cannot legally ship, and nothing
more; all cleverness, and in particular anything that could possibly
have a bug, should happen somewhere else. If we can eventually end up
with most -data packages literally only having
/usr/share/games/PACKAGE and /usr/share/doc/PACKAGE, that illustrates
that rule rather well.
Adding .desktop files and icons for Doom WADs and ScummVM/ResidualVM
games does stretch that rule, because .desktop files can have bugs (e.g.
lack of Keywords, or a low-quality icon). I would be tempted to put the
.desktop files in ScummVM and ResidualVM, with a TryExec pointing to a
dummy executable in the relevant -data package, although for ScummVM
that does get into difficult issues of should these be in contrib? and
I don't think we necessarily want a contrib equivalent of src:quake just
for the .desktop files.
(and quake3-data is a link-farmed from quake3 anyway)
As described on
https://github.com/a-detiste/game-data-packager/commit/e432de5f39822f01bae078e454fbfb43341ea72d
there is a reason why I did it like this: quake3-data now ships the Team
Arena part of the patch as well as the baseq3 part (because otherwise,
gdp would potentially have to download the patch twice, once for the Q3
parts and once for the TA parts) but it is a bad idea to put
missionpack/*.pk3 in the engine's search path if we don't have the
complete set.
In this case I think I would have both D3 and D3:ROE install to
usr/share/games/doom3-data, and have D3:BFG install to
usr/share/games/doom3-bfg-data.
Without -data would be fine too.
S
--
To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Archive: https://lists.debian.org/54d8b50c.9070...@debian.org
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Le samedi 7 février 2015, 18:07:34 Tobias Frost a écrit : Am Samstag, den 07.02.2015, 15:21 + schrieb Simon McVittie: I'm happy to merge a patch, but I don't have Doom 3 (either the original or the BFG edition) so someone else will have to contribute the necessary file-list and checksums. As I own both, maybe I can help here. Gianfranco gave me some instructions how to generate the yaml file, but I'm not sure if it's complete and what else is required. (It's still building, so I follow up later) Thansk for the files, I only needed to remove the references to doom.wad, doom2.wad and nerve.wad; these are already handled by other yaml files. For dhewm3 I'd suggest using package names doom3-data, doom3-resurrection-data, doom3-demo-data; for the BFG edition I'd suggest doom3-bfg-data. There will be no doom3-demo-data as it is not supported by upstream. I think it'd be OK to put them both in doom3.yaml though. It's the same game after all :-) , is the better_version: appropriate as for Wolfenstein 3D ? We could also package this popular expansion: http://doomwiki.org/wiki/Classic_Doom_for_Doom_3 (doom3-classic-data) -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/3498300.JL1uYp2TEc@antec
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Am Sonntag, den 08.02.2015, 19:47 +0100 schrieb Alexandre Detiste: We could also package this popular expansion: http://doomwiki.org/wiki/Classic_Doom_for_Doom_3 (doom3-classic-data) Good idea, but AFAIK this is not compatible with Doom 3 BFG Edition! - Fabian -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1423460651.8353.17.ca...@greffrath.com
Bug#764200: Bug#777338: Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
Le lundi 9 février 2015, 06:44:11 Fabian Greffrath a écrit : Am Sonntag, den 08.02.2015, 19:47 +0100 schrieb Alexandre Detiste: We could also package this popular expansion: http://doomwiki.org/wiki/Classic_Doom_for_Doom_3 (doom3-classic-data) Good idea, but AFAIK this is not compatible with Doom 3 BFG Edition! So, I revert what I said about the better_version:; if there are mods you can play with original Doom3, but not BFG edition; it is worth having both. -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/1859452.6sMcPBQfAb@antec
Bug#764200: Bug#777338: game-data-packager: please add support for Doom3 BFG
On 07/02/15 14:58, Alexandre Detiste wrote: Please add support for Doom3 BFG The engine is already packaged and waiting in the NEW queue: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=764200 I'm happy to merge a patch, but I don't have Doom 3 (either the original or the BFG edition) so someone else will have to contribute the necessary file-list and checksums. Am I right in thinking that the original and BFG editions are incompatible, and will require separate engines and data files if Debian will eventually support both? (I ask because this influences how it should look in game-data-packager.) S -- To UNSUBSCRIBE, email to debian-wnpp-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org Archive: https://lists.debian.org/54d62d8e.80...@debian.org
