[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
@andyrock: thanks for the work, some comments: - could you try opening an upstream bug for the list help item for the current selected panel, who knows they might like the idea there - the patch doesn't build: shell/control-center.c:239: undefined reference to `cc_panel_get_display_name' this function doesn't seem to be defined in the upstream source? - Close should be Quit (I said I would change it locally but if you update the patch you can as well do that with the update) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Description changed: When fixing this bug, also take a look at bug #1130722 at the same time if possible. -- In Raring, the 'Calculator' app should have the following menu items: === Edit === Copy Paste - Undo Redo - Preferences - - Close + Quit === Mode === Basic Advanced Financial Programming === Help === Contents About In Raring, the 'System Settings' app should have the following menu items: === Help === Contents [Optional link to help doc for the currently selected settings panel] - - Close + Quit -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
Thanks, I'm looking at that one, but it would be nice if design could reply to the question about Quit vs Close before we upload... -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Patch added: unity_menus.diff https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1131664/+attachment/3713502/+files/unity_menus.diff -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
Thanks, that seems good. Design question, shouldn't Close be Quit rather? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Branch linked: lp:ubuntu/saucy-proposed/gnome-calculator -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
This bug was fixed in the package gnome-calculator - 1:3.8.2-1ubuntu3 --- gnome-calculator (1:3.8.2-1ubuntu3) saucy; urgency=low * debian/patches/unity_classic_menubar.patch: - use a classic menu layout under Unity, the gnome-shell simplified menu doesn't work great for Unity (lp: #1131664) -- Sebastien Bacher seb...@ubuntu.com Fri, 07 Jun 2013 18:18:04 +0200 ** Changed in: gnome-calculator (Ubuntu) Status: In Progress = Fix Released -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Changed in: gnome-control-center (Ubuntu) Status: Triaged = In Progress ** Changed in: gnome-control-center (Ubuntu) Assignee: (unassigned) = Andrea Azzarone (andyrock) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Changed in: gnome-calculator (Ubuntu) Assignee: (unassigned) = Andrea Azzarone (andyrock) ** Changed in: gnome-calculator (Ubuntu) Status: Triaged = In Progress -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Patch added: unity_menu.diff https://bugs.launchpad.net/ubuntu/+source/gnome-calculator/+bug/1131664/+attachment/3695482/+files/unity_menu.diff -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
The attachment unity_menu.diff seems to be a patch. If it isn't, please remove the patch flag from the attachment, remove the patch tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
Thanks andyrock, we try to change the behaviour of programs we patch only under unity, do you think you could make it use the standard menubar only if XDG_CURRENT_DESKTOP=Unity and use the upstream one otherwise? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
Ok I updated the patch. ** Patch added: gnome-calculator.diff https://bugs.launchpad.net/ayatana-design/+bug/1131664/+attachment/3695618/+files/gnome-calculator.diff -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Changed in: gnome-control-center (Ubuntu) Assignee: Michael Terry (mterry) = (unassigned) ** Changed in: gnome-calculator (Ubuntu) Assignee: Michael Terry (mterry) = (unassigned) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Package changed: gcalctool (Ubuntu) = gnome-calculator (Ubuntu) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
For System Settings, I'm not sure HelpContents is what we want. For GNOME-provided panels, the Help button points to more specific help if available. For instance, clicking Help when you are looking at the User panel shows you a locally installed version of https://help.ubuntu.com/stable/ubuntu-help/user-accounts.html -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gcalctool in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1131664] Re: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity
** Description changed: When fixing this bug, also take a look at bug #1130722 at the same time if possible. -- In Raring, the 'Calculator' app should have the following menu items: === Edit === Copy Paste - Undo Redo - Preferences - Close === Mode === Basic Advanced Financial Programming === Help === Contents About - -- + In Raring, the 'System Settings' app should have the following menu items: === Help === Contents + [Optional link to help doc for the currently selected settings panel] + - Close -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gcalctool in Ubuntu. https://bugs.launchpad.net/bugs/1131664 Title: Patch the menus of the 'Calculator' and 'System Settings' apps to fit with Unity To manage notifications about this bug go to: https://bugs.launchpad.net/ayatana-design/+bug/1131664/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
