[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

[Bruce Pieterse]

** Changed in: ubuntu-gnome
   Status: Triaged => Fix Released

** Changed in: ubuntu-gnome
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

[Launchpad Bug Tracker]

This bug was fixed in the package gdm - 3.10.0.1-0ubuntu3.2

---
gdm (3.10.0.1-0ubuntu3.2) trusty; urgency=medium

  * debian/gdm.init - removed extra unmatched "fi" line 78 (LP: #1315442)
 -- Scott Sanbar    Fri, 03 Apr 2015 05:03:26 -0500

** Changed in: gdm (Ubuntu Trusty)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

[Tim]

tested gdm from proposed on up to date trusty, and gdm starts as
expected with starting with "/etc/init.d/gdm start"

** Tags removed: removal-candidate verification-needed
** Tags added: verification-done

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

[Brian Murray]

Because nobody seems to have verified the fix in Trusty.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

[Bruce Pieterse]

I asked the reporter in bug #1472341 to provide an update on the failed
package installation. Is there any reason this fix has not been released
to Trusty yet?

** Changed in: ubuntu-gnome
   Status: New => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

[Mathew Hodson]

** Changed in: gdm (Ubuntu Utopic)
   Status: Fix Committed => Won't Fix

** Changed in: gdm (Ubuntu Utopic)
   Importance: Undecided => Low

** Changed in: gdm (Ubuntu Trusty)
   Importance: Undecided => Low

** Changed in: gdm (Ubuntu)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra "fi" in /etc/init.d/gdm

[Tim]

the above issue is not related to the fix in  this sru

** Tags removed: verification-failed

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra "fi" in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Brian Murray]

The fix has already been released in Vivid.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Mathew Hodson]

** Tags added: trusty

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Tim]

** Changed in: ubuntu-gnome
Milestone: vivid = trusty.3

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

The fix in comment #7 was for vivid specifically.  I will be creating
debdiff patches for trusty and utopic as well

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

I uploaded a wrong debdiff in the previous comment as a patch (#10).
Included in this comment is the correct patch for the comment #10.

** Patch added: utopic fix for LP: #1315442 - removed line 78 (extra fi) - 
tested on Ubuntu-Gnome utopic
   
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4365128/+files/gdm_3.10.0.1-0ubuntu7.2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

I have made a fix (patch) for this bug for utopic, tested on Ubuntu-
Gnome utopic and attached it as gdm_3.10.0.1-0ubuntu7.2.debdiff to this
comment:

This is a very simple change to the code in debian/gdm.init - I removed
line 78 which has an extra unmatched fi

Tested as follows:
Built binaries using sbuild in latest utopic environment on a trusty machine. 
Fired up an Ubuntu-Gnome utopic 14.10 release build LiveCD in a virtual 
machine. Verified the bug failure on the plain vanilla utopic LiveCD as follows:

/etc/init.d/gdm
(gave syntax error)

If I changed directories to /etc/init.d and did ./gdm the script did
not do anything - just returned.  Also, /etc/init.d/gdm start worked
fine.  Still, the error did occur as indicated above.

Copied all the .deb files from the utopic sbuild on the trusty build
machine onto the Ubuntu-Gnome utopic livecd vm. Installed the four .deb
files using dpkg -i ... Install succeeded, and visually inspecting
/etc/init.d/gdm showed original line 78 was indeed removed. Typed:

/etc/init.d/gdm
(worked as expected - no syntax error)
/etc/init.d/gdm start
(worked as expected - no syntax error)

This confirms that the bug fix works for the 14.10 utopic release
version of Ubuntu-Gnome.

** Patch removed: vivid fix for LP: #1315442 - removed line 73 (extra fi) - 
tested on Ubuntu-Gnome vivid
   
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364854/+files/gdm_3.14.1-0ubuntu3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

I have made a fix (patch) for this bug for trusty, tested on Ubuntu-
Gnome trusty and attached it as trusty-gdm_3.10.0.1-0ubuntu3.2.debdiff
to this comment:

This is a very simple change to the code in debian/gdm.init - I removed
line 78 which has an extra unmatched fi

Tested as follows:
Built binaries using sbuild in latest trusty environment on a trusty machine. 
Fired up an Ubuntu-Gnome trusty 14.04.2 release build LiveCD in a virtual 
machine. Verified the bug failure on the plain vanilla vivid LiveCD as follows:

cd /etc/init.d
./gdm
(gave syntax error)
./gdm start
(gave syntax error)

Copied all the .deb files from the trusty sbuild on the trusty build
machine onto the Ubuntu-Gnome trusty livecd vm. Installed the four .deb
files using dpkg -i ... Install succeeded, and visually inspecting
/etc/init.d/gdm showed original line 78 was indeed removed. Typed:

cd /etc/init.d
./gdm
(worked as expected - no syntax error)
./gdm start
(worked as expected - no syntax error)

This confirms that the bug fix works for the 14.04.2 release version of
Ubuntu-Gnome.

** Patch added: trusty fix for LP: #1315442 - removed line 73 (extra fi) - 
tested on Ubuntu-Gnome trusty
   
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364972/+files/trusty-gdm_3.10.0.1-0ubuntu3.2.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

I somehow must have deleted the vivid patch referenced in the fix in
comment #7 above.  I have attached it here:  vivid-
gdm_3.14.1-0ubuntu3.debdiff

** Patch added: vivid fix for LP: #1315442 - removed line 73 (extra fi) - 
tested on Ubuntu-Gnome vivid
   
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4365455/+files/vivid-gdm_3.14.1-0ubuntu3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Launchpad Bug Tracker]

This bug was fixed in the package gdm - 3.14.1-0ubuntu3

---
gdm (3.14.1-0ubuntu3) vivid; urgency=medium

  * debian/gdm.init - removed extra unmatched fi line 73 (LP: #1315442)
 -- Scott Sanbar scott.san...@gmail.com   Thu, 02 Apr 2015 17:39:18 -0500

** Changed in: gdm (Ubuntu)
   Status: Confirmed = Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Adam Conrad]

Hello Owen, or anyone else affected,

Accepted gdm into trusty-proposed. The package will build now and be
available at
https://launchpad.net/ubuntu/+source/gdm/3.10.0.1-0ubuntu3.2 in a few
hours, and then in the -proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: gdm (Ubuntu Trusty)
   Status: Confirmed = Fix Committed

** Tags added: verification-needed

** Changed in: gdm (Ubuntu Utopic)
   Status: New = Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

Re: [Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

No problem - what about vivid?

Thanks!  I had fun!

Scott

On Fri, Apr 3, 2015 at 7:44 PM, Tim t...@feathertop.org wrote:

 Thanks for the fix Scott!

  I have uploaded to trusty and utopic, please add the SRU paperwork when
 you can.

 --
 You received this bug notification because you are subscribed to the bug
 report.
 https://bugs.launchpad.net/bugs/1315442

 Title:
   Extra fi in /etc/init.d/gdm

 Status in Ubuntu GNOME:
   New
 Status in gdm package in Ubuntu:
   Fix Released
 Status in gdm source package in Trusty:
   Confirmed
 Status in gdm source package in Utopic:
   New

 Bug description:
   Ubuntu release 14.04 LTS
   gdm 3.10.0.1-0ubuntu3

   I just tried to start gdm with /etc/init.d/gdm start  and got the
   message:

   /etc/init.d/gdm: 79: /etc/init.d/gdm: Syntax error: fi unexpected
   (expecting })

   I'm aware of service(8) but cjwatson said I should report this as a
   bug anyway!

   Owen

 To manage notifications about this bug go to:
 https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions


-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Launchpad Bug Tracker]

** Branch linked: lp:ubuntu/trusty-proposed/gdm

** Branch linked: lp:ubuntu/utopic-proposed/gdm

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Tim]

Thanks for the fix Scott!

 I have uploaded to trusty and utopic, please add the SRU paperwork when
you can.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

** Description changed:

  Ubuntu release 14.04 LTS
  gdm 3.10.0.1-0ubuntu3
  
  I just tried to start gdm with /etc/init.d/gdm start  and got the
  message:
  
  /etc/init.d/gdm: 79: /etc/init.d/gdm: Syntax error: fi unexpected
  (expecting })
  
  I'm aware of service(8) but cjwatson said I should report this as a bug
  anyway!
  
  Owen
+ 
+ SRU Information:
+ 
+ [Impact]
+ 
+  * Anyone who tries to use the sysv style /etc/init.d/gdm script to control
+gdm may get a syntax error which disallows the script from running,
+bombing out to the command line with an unfriendly error
+ 
+  * This problem effects vivid, utopic and trusty.  Without this fix
+backported, the functionality of the sysv style script for controlling
+the gdm service is broken under certain circumstances.  The resulting
+unfriendly error is also unprofessional and gives a feeling of
+brokenness to Ubuntu in all three of these releases, including the
+ones to be backported to.
+ 
+  * This upload is a series of three patches.  The syntax error
+results from a single line in each of the debian/gdm.init files which get
+installed as the /etc/init.d/gdm shell script.  The problem is an extra
+unmatched fi that results in a syntax error if the corresponding line
+is interpreted
+ 
+ [Test Case]
+ 
+  * To test the fix in vivid, type the following commands before and after
+the updated package is installed:
+ 
+cd /etc/init.d
+sudo ./gdm
+ 
+If the script exits with a syntax error before the package with
+the fix is installed, you have verified the bug.
+ 
+If the script exits with a syntax error after the package is installed,
+the fix did not work.
+If the script does not indicate a syntax error after the package
+is installed, the fix worked
+ 
+To test the fix on utopic, do the identical test as in vivid above
+but instead use the following single command to invoke the script:
+ 
+sudo /etc/init.d/gdm
+ 
+To test the fix on trusty, do the test as in vivid and utopic,
+but use the following commands to change directories and invoke
+the script:
+ 
+cd /etc/init.d
+sudo ./gdm
+sudo ./gdm start
+ 
+In this case, both times you run the script it should exit with
+the syntax error before installing the package and neither time
+after installing the package.
+ 
+ [Regression Potential]
+ 
+  * Any scripts which may call this script which happen to mistakenly
+rely on it to fail could perhaps behave differently, with unknown
+results possible
+ 
+ [Other Info]
+  
+  * Using or not using sudo before each command may affect the tests
+with varying output that may be unexpected.  In all cases, however,
+if the script bombs on a syntax error happens mentioning a line number
+and fi the test definitely either verified the bug or definitively
+showed the package did not fix the bug (or was not installed correctly).
+ 
+A situation which arose during the testing is that depending on the
+whether the patch is on vivid, utopic or trusty, calling the script
+in different ways (fully qualified path vs. changing the current
+directory to /etc/init.d and using ./gdm, for instance, or
+including or not including the 'start' parameter) causes the
+test to behave differently, for instance failing silently or working
+depending on how the script is called even with the syntax error present. 
+This is why there are different command lines for each version of the
+patch for testing.
+ 
+I did some tracing on why this happened, and the reasons seem buried deep
+within the trees of scripts called beneath /etc/init.d/gdm and are outside
+the scope of this fix and do not invalidate this fix.  This fix deals
+with a simple top level shell script syntax error that can be successfully
+tested for as indicated above.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Launchpad Bug Tracker]

** Branch linked: lp:ubuntu/vivid-proposed/gdm

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Scott Sanbar]

I have made a fix for this bug and attached it as a debdiff to this
comment:

This is a very simple change to the code in debian/gdm.init - I remove
line 73 which has an extra unmatched fi

Tested as follows:
Built binaries using sbuild in latest vivid environment on a trusty machine.  
Fired up an Ubuntu-Gnome vivid daily build (current for 4/2/2015) LiveCD in a 
virtual machine.  Verified the bug failure on the plain vanilla vivid LiveCD as 
follows:

cd /etc/init.d
./gdm

Could not get the failure with ./gdm start like mentioned in the bug
report - had to leave out start

Copied all the .deb files from the vivid sbuild on the trusty machine
onto the Ubuntu-Gnome vivid vm.  Installed the four .deb files using
dpkg -i ...  Install succeeded, and visually inspecting
/etc/init.d/gdm showed line 73 was indeed removed.  Typed:

cd /etc/init.d
./gdm

At the command prompt and got no error about fi - just showed the
informational message about usage (because I left out start).  This
confirms that the bug is fixed for the current version of vivid.

** Patch added: Fix for LP: #1315442 - removed line 73 (extra fi) - tested 
on Ubuntu-Gnome vivid
   
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+attachment/4364854/+files/gdm_3.14.1-0ubuntu3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Adam Conrad]

** Tags added: patch

** Also affects: gdm (Ubuntu Utopic)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: gdm (Ubuntu Trusty)
   Status: New = Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Tim]

** Also affects: ubuntu-gnome
   Importance: Undecided
   Status: New

** Changed in: ubuntu-gnome
Milestone: None = vivid

** Also affects: gdm (Ubuntu Trusty)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Juan Pablo]

The solution proposed by #2 indeed works.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Cheddie Merai]

Do sudo gedit /etc/init.d/gdm then look at the bottom of the gedit
window where you see sh, Tab Width, Ln. That's what you're looking for
Ln which means line number.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[kira]

how can i goto line. i dont see any number :(

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Evan Wiley]

Goto line 79 and comment out the extra fi. all works good after

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1315442] Re: Extra fi in /etc/init.d/gdm

[Launchpad Bug Tracker]

Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: gdm (Ubuntu)
   Status: New = Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm in Ubuntu.
https://bugs.launchpad.net/bugs/1315442

Title:
  Extra fi in /etc/init.d/gdm

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/gdm/+bug/1315442/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs