[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
The attachment "gnome-control-center_3.18.2-1ubuntu4.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team. [This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.] ** Tags added: patch -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
And the screenshot ** Attachment added: "finalFix.png" https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+attachment/4541649/+files/finalFix.png -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Ok, so here again, with the debdiff. ** Patch added: "gnome-control-center_3.18.2-1ubuntu4.debdiff" https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+attachment/4541648/+files/gnome-control-center_3.18.2-1ubuntu4.debdiff -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
did you update the callback? GtkButton wont have an activate-link signal. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
Re: [Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Hey Tim, so I got the following problem: The input sources button is a linkbutton, which is not changeable into a normal button without loosing its ability to open the other panel. However, it seems to be not possible to change the design of this linkbutton to make it look like a normal button. I asked on StackOverflow how to do this, here is the link: http://stackoverflow.com/questions/34495313/set-the-style-of-gtklinkbuttons But maybe you can help me earlier/better :) -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
I did, turned it to activate signal. But then, clicking the button just does nothing. So I tried changing the design of the LinkButton, without success :( -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
AWESOME! THAT DID IT! :) Didn't run the program under the newly installed Ubuntu Gnome yet, but as the source code is the most recent from pull-lp-source and I didn't do any changes to the layout of the program, it should look good in GNOME. Will submit this now to launchpad with bzr. ** Attachment added: "fixx.png" https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+attachment/4541528/+files/fixx.png -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
I think "activate" is actually fired on double click for GtkButton, you probably want to use "clicked" -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
** Branch linked: lp:~indielives010/gnome-control-center/gnome-control- center -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
but you left the old button as well ;( that is the wrong branch, if you want to use bzr then it is lp:~ubuntu- desktop/gnome-control-center/ubuntu otherwise make a debdiff against the ubuntu source from pull-lp-source. either way you changes need to be done as a quilt patch! -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
** Branch linked: lp:~indielives010/gnome-control- center/fixKeyboardPanelLayout -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Ok, finally done :) Moved the LinkButton to the header, screenshot appended. The new branch is here: https://code.launchpad.net/~indielives010/gnome-control-center/fixKeyboardPanelLayout ** Attachment added: "designFixed.png" https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+attachment/4540847/+files/designFixed.png -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
actually seems I was wrong about the frame size, they do jump around a bit, so its probably ok as it. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
A few nitpicks - Use a normal button, not the link button - You seem to have broken the frame/window size of the keyboard panel, this should always remain the same as all other panels. - It needs to be based on the xenial/3.18 branch, this is not something we could backport to trusty - Screenshots are far more useful if they use all defaults, such as button layouts, fonts etc. Grab screenshots in a live session if need be. Further the keyboard settings have been moved into universal-access panel for 3.20 https://git.gnome.org/browse/gnome-control-center/commit/?id=1f192985ef1e18792151c1479be1f3c96c8f4f4c -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
That screenshot looks the same as the last one ;( Also what help button, I hope you are not comparing it the Ubuntu "Language Support" panel, that is not included in gnome-control-center anymore with 16.04 -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Here is the look of gnome-control-center in adwaita, the buttons design fits the others like the Help Button in the Language Panel. ** Attachment added: "FixAppliedAdwaita.png" https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1525402/+attachment/4538816/+files/FixAppliedAdwaita.png ** Branch linked: lp:~ubuntu-desktop/gnome-control-center/ubuntu -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Can you attach a screenshot when using adwaita. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Fix commited: https://code.launchpad.net/~indielives010/gnome-control- center/fixKeyboardPanelLayout/+merge/281088 ** Changed in: gnome-control-center (Ubuntu) Status: In Progress => Fix Committed ** Attachment added: "New design" https://bugs.launchpad.net/ubuntu/+source/gnome-control-center/+bug/1525402/+attachment/4538314/+files/Fix_Applied -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
** Branch linked: lp:~indielives010/gnome-control- center/fixKeyboardPanelLayout -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Missed you on IRC, Have a look through all the other panels and see what they do with buttons. -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
** Changed in: ubuntu-gnome Status: Confirmed => In Progress -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
** Changed in: gnome-control-center (Ubuntu) Assignee: (unassigned) => Robert Hönig (indielives010) ** Changed in: gnome-control-center (Ubuntu) Status: Triaged => In Progress ** Changed in: ubuntu-gnome Status: In Progress => Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
** Changed in: ubuntu-gnome Milestone: None => xenial ** Changed in: gnome-control-center (Ubuntu) Importance: Undecided => Low ** Changed in: gnome-control-center (Ubuntu) Status: Confirmed => Triaged -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Pretty sure that has been like that for most of ever, however I do agree this looks out of place. This should be fixed in co-ordination with upstream. ** Changed in: gnome-control-center (Ubuntu) Importance: Low => Wishlist -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: gnome-control-center (Ubuntu) Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
I can reproduce this bug with Ubuntu 16.04. Here, just the text changed, but not its appearance: It now says Text Entry Steps to reproduce: 1. Run gnome-control-center 2. Switch to Keyboard Panel, look in the lower left corner. ** Attachment added: "TextEntryKeyboard.png" https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+attachment/4533696/+files/TextEntryKeyboard.png ** Changed in: ubuntu-gnome Status: New => Confirmed -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 1525402] Re: "Input Sources" button looks really out of place in Keyboard settings
** Summary changed: - "Input Sources" button looks out of place in Keyboard settings + "Input Sources" button looks really out of place in Keyboard settings -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to gnome-control-center in Ubuntu. https://bugs.launchpad.net/bugs/1525402 Title: "Input Sources" button looks really out of place in Keyboard settings To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu-gnome/+bug/1525402/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
