[Bug 1662031] Re: Switching language and format broken

[Launchpad Bug Tracker]

** Merge proposal linked:
   
https://code.launchpad.net/~canonical-desktop-team/ubuntu/+source/gdm3/+git/gdm3/+merge/349818

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/gdm/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Launchpad Bug Tracker]

** Merge proposal linked:
   
https://code.launchpad.net/~canonical-desktop-team/ubuntu/+source/gdm3/+git/gdm3/+merge/348784

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/gdm/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Bug Watch Updater]

** Changed in: gdm
   Status: Unknown => Expired

** Changed in: gdm
   Importance: Unknown => Medium

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/gdm/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

** Also affects: gdm via
   https://bugzilla.gnome.org/show_bug.cgi?id=788762
   Importance: Unknown
   Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/gdm/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Launchpad Bug Tracker]

This bug was fixed in the package gdm3 - 3.26.1-3ubuntu2

---
gdm3 (3.26.1-3ubuntu2) artful; urgency=medium

  * debian/patches/ubuntu_dont_set_language_env.patch:
- Don't run the set_up_session_language() function, since it
  overrides variable values set by ~/.pam_environment
  (LP: #1662031). Thanks to Olivier Tilloy for debugging!

 -- Gunnar Hjalmarsson   Wed, 11 Oct 2017 13:20:09
+0200

** Changed in: gdm3 (Ubuntu Artful)
   Status: In Progress => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

See conversation on the upstream bug report. It turns out calling
set_up_session_language() earlier (e.g. in on_setup_complete_cb) doesn't
fix the problem: gdm_session_start_session() calls send_environment(),
which overrides the environment set up by pam with the values from
/etc/default/locale again.

I guess not calling set_up_session_language() at all is the correct fix
in our case.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Sebastien Bacher]

** Changed in: gdm3 (Ubuntu Artful)
 Assignee: Sebastien Bacher (seb128) => Olivier Tilloy (osomon)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

I filed https://bugzilla.gnome.org/show_bug.cgi?id=788762 to continue
the conversation upstream.

** Bug watch added: GNOME Bug Tracker #788762
   https://bugzilla.gnome.org/show_bug.cgi?id=788762

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Sebastien Bacher]

the function has been added to fix
https://bugzilla.gnome.org/show_bug.cgi?id=709105

** Bug watch added: GNOME Bug Tracker #709105
   https://bugzilla.gnome.org/show_bug.cgi?id=709105

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

And I can confirm that the packages in Gunnar's PPA appear to fix the
issue here, without any visible regression, from my limited testing.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

Yep, suspicious indeed. I built gdm3 with that function disabled:

https://launchpad.net/~gunnarhj/+archive/ubuntu/gdm3

And yes, that's it. You nailed it Olivier; thanks a lot!

Why didn't I see it when looking at that file many months ago... :(
Anyway, I have submitted a MP.

** Changed in: gdm3 (Ubuntu Artful)
   Status: Confirmed => In Progress

** No longer affects: gnome-control-center (Ubuntu Artful)

** No longer affects: gnome-control-center (Ubuntu)

** No longer affects: accountsservice (Ubuntu Artful)

** No longer affects: accountsservice (Ubuntu)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Launchpad Bug Tracker]

** Branch linked: lp:~gunnarhj/gdm/language-switching

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

I added a FOOBAR variable to both ~/.pam_environment and
/etc/default/locale, with different values in each file, and after
logging in the value is the one from ~/.pam_environment. So I don't
think gdm sources /etc/default/locale after ~/.pam_environment. However
variables LANG, LANGUAGE and LC_* appear to be overridden by the values
in /etc/default/locale, and set_up_session_language() in daemon/gdm-
session.c (https://git.gnome.org/browse/gdm/tree/daemon/gdm-
session.c#n2488) looks suspicious in that regard.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

/usr/share/language-tools/save-to-pam-env is the script that writes to
~/.pam_environment with an incorrect syntax.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

/etc/pam.d/gdm-launch-environment is run as user gdm, so it's not what
we're interested in.

/etc/pam.d/gdm-password appears to be what sets the environment upon
user login.

When adding some logging to that module, I'm seeing the following:

pam_env(gdm-password:session): username=ubuntu
pam_env(gdm-password:session): user env path: /home/ubuntu/.pam_environment
pam_env(gdm-password:session): parsing config file
pam_env(gdm-password:session): remove variable "LANGUAGE=fr_FR:en_GB:en"
pam_env(gdm-password:session): remove variable "LANG=fr_FR.UTF-8"

It turns out, "VARIABLE=value" is not the correct syntax for 
~/.pam_environment. The expected syntax is "VARIABLE [DEFAULT=[value]] 
[OVERRIDE=[value]]" (man pam_env.conf).
And indeed if I modify ~/.pam_environment to conform to that syntax, I'm seeing 
this instead:

pam_env(gdm-password:session): pam_putenv("LANGUAGE=fr_FR:en_GB:en")
pam_env(gdm-password:session): pam_putenv("LANG=fr_FR.UTF-8")

That doesn't seem to fix the overall issue though, as the values of
LANGUAGE and LANG are still those from /etc/default/locale after logging
in.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

Wonder if there is a problem with this code:

https://git.gnome.org/browse/gdm/tree/daemon/gdm-session-worker.c#n993

@Steve: gdm3 seems to not read ~/.pam_environment. Do you possibly have
an idea off the top of your head?

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

In /etc/pam.d/gdm-launch-environment:

session requiredpam_env.so readenv=1 user_readenv=1
envfile=/etc/default/locale

In pam_env.c (handle_env function), the env should be set from
/etc/default/locale and then overridden by ~/.pam_environment. If I add
the 'debug' parameter to the module invokation, I see only the calls to
pam_putenv corresponding to /etc/default/locale, which means that for
some reason to be determined ~/.pam_environment is not being sourced.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

I didn't click "Apply System-Wide". When I changed the language in g-c-c
/etc/default/locale was written to (LANG and LANGUAGE were updated). I
agree that this is unexpected behaviour though, I wouldn't expect the
current user's setting to be applied system-wide unless explicitly
requested.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

To clarify: I used the g-c-c interface to switch language. If I had
clicked "Manage Installed Languages" to open Language Support and then
clicked "Apply System-Wide", /etc/default/locale would have been updated
too. But that 'does not count'. Language Support is available to work
around the fact that installation of new languages from g-c-c does not
work currently.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

The /etc/default/locale file was not altered when I just tested on an
updated artful.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

Olivier: Is /etc/default/locale written to also?? That's not what
Sebastien and I observed. I'll go to a (relatively) fresh artful install
and recheck then.

If that's the case, the issue may not be so urgent. But it's poor
design, since it means that if a user changes language, s/he changes it
for all users on the system.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Olivier Tilloy]

Testing in an up-to-date artful VM, when switching languages in g-c-c,
both LANG and LANGUAGE are updated in both ~/.pam_environment and
/etc/default/locale.

That VM is an artful install that has been updated daily, not an upgrade
from a previous release.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

If nobody figures out what makes the variables in ~/.pam_environment be
overridden by the variables in /etc/default/locale, I'm thinking of an
ugly hack which may work.

~/.pam_environment is maintained by /usr/share/language-tools/save-to-
pam-env. In case of a GNOME desktop we could make that file write to
~/.profile as well.

** Also affects: accountsservice (Ubuntu)
   Importance: Undecided
   Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Will Cooke]

** Also affects: gnome-control-center (Ubuntu Artful)
   Importance: Undecided
   Status: New

** Also affects: gdm3 (Ubuntu Artful)
   Importance: High
   Status: Confirmed

** Changed in: gdm3 (Ubuntu Artful)
 Assignee: (unassigned) => Sebastien Bacher (seb128)

** Changed in: gnome-control-center (Ubuntu Artful)
 Assignee: (unassigned) => Sebastien Bacher (seb128)

** Tags removed: rls-aa-incoming

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

** Tags added: rls-aa-incoming

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1662031] Re: Switching language and format broken

[Gunnar Hjalmarsson]

This issue is present on an artful daily build as well. gdm3 somehow
overrides variables set by ~/.pam_environment. (With lightdm it works as
expected.)

It should be noticed that the issue is present whether g-c-c or
language-selector is used to change the display language.

** Changed in: gdm3 (Ubuntu)
   Importance: Undecided => High

** Changed in: gdm3 (Ubuntu)
   Status: New => Confirmed

** Changed in: gdm3 (Ubuntu)
Milestone: None => ubuntu-17.10

** Tags added: gnome-17.10

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to gdm3 in Ubuntu.
https://bugs.launchpad.net/bugs/1662031

Title:
  Switching language and format broken

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome/+bug/1662031/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs