[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-23 Thread Launchpad Bug Tracker
This bug was fixed in the package nautilus - 1:3.26.4-0ubuntu9

---
nautilus (1:3.26.4-0ubuntu9) disco; urgency=medium

  * d/p/0016-search-engine-add-a-recent-search-engine-listing-Gtk.patch:
- Fix double deref introduced in the previous upload (LP: #1804260)

 -- Julian Andres Klode   Fri, 23 Nov 2018 09:41:50
+0100

** Changed in: nautilus (Ubuntu)
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-23 Thread Julian Andres Klode
** Changed in: nautilus (Ubuntu)
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-22 Thread Sebastien Bacher
** Changed in: nautilus (Ubuntu)
 Assignee: Marco Trevisan (Treviño) (3v1n0) => Julian Andres Klode (juliank)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-22 Thread Launchpad Bug Tracker
** Merge proposal linked:
   
https://code.launchpad.net/~juliank/ubuntu/+source/nautilus/+git/nautilus/+merge/359188

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-22 Thread Julian Andres Klode
** Changed in: nautilus (Ubuntu)
   Status: Triaged => In Progress

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-22 Thread Julian Andres Klode
Oh, I'm wrong about search_thread_add_hits_idle, as the object is ref'ed
before the idle callback is added. Which is a bit strange, but works
(I'd provide a search_hits_data_free that unrefs the -> recent and just
use that on the entire search_hits).

The recent_thread_func clearly is an oversight though.

** Changed in: nautilus (Ubuntu)
   Status: Confirmed => Triaged

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-22 Thread Julian Andres Klode
The bug seems to be wrong reference counting of the
NautilusSearchEngineRecent, and both search_thread_add_hits_idle and
recent_thread_func have been changed in the last upload to have code
that looks like this:

search_thread_add_hits_idle:
g_autoptr (NautilusSearchEngineRecent) self = search_hits->recent;

recent_thread_func:
g_autoptr (NautilusSearchEngineRecent) self = NAUTILUS_SEARCH_ENGINE_RECENT 
(user_data);

however, recent_thread_func (unlike search_thread_add_hits_idle) did not
lose the g_object_unref (self); at the end so it decrements once more
than it did before.


I do think search_thread_add_hits_idle is wrong as well, and needs to be
  g_autoptr (NautilusSearchEngineRecent) self = 
g_object_ref(search_hits->recent);
or just
  NautilusSearchEngineRecent *self = search_hits->recent;

as you are just providing an alias to that field, so why are you
decrementing it once every time you call this function?

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-22 Thread Sebastien Bacher
K, weird that we didn't get previous reports, or maybe the signature
change. Feel free to unassign yourself if you prefer/are busy enough
with other things

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-21 Thread Treviño
Seb, not sure... Since it seems related to locate search engine which I
didn't touch for a while...

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-21 Thread Julian Andres Klode
I did not do anything I can remember, it just happened in the
background.

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-21 Thread Sebastien Bacher
Marco, seems like it could be due to some of your recent changes?

** Changed in: nautilus (Ubuntu)
   Importance: Low => High

** Changed in: nautilus (Ubuntu)
 Assignee: (unassigned) => Marco Trevisan (Treviño) (3v1n0)

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-21 Thread Sebastien Bacher
@Julian, do you remember what you did to trigger the bug?

** Changed in: nautilus (Ubuntu)
   Importance: Undecided => Low

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-20 Thread Julian Andres Klode
This has 12 reports on errors.ubuntu.com so far, the latest one probably
mine...

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs

[Bug 1804260] Re: /usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

2018-11-20 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users.

** Changed in: nautilus (Ubuntu)
   Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to nautilus in Ubuntu.
https://bugs.launchpad.net/bugs/1804260

Title:
  
/usr/bin/nautilus:11:g_type_check_instance_is_fundamentally_a:g_object_unref:nautilus_search_engine_finalize:g_object_unref:g_closure_invoke

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nautilus/+bug/1804260/+subscriptions

-- 
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs