[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
Okay, here's attempt #2. This one integrates the script into the build process instead. I didn't do this at first, since I wasn't sure if whoever was building the package would always have the same /etc/lsb-release info as the target distribution. Am I being too pedantic adding 'mktemp' and 'sed' to build-depends? I think the build scripts already used 'sed'. Maybe the dependency is buried elsewhere already. (lsb-release was already a dependency.) ** Attachment added: Patch to modify default prefs file with the correct useragent string during build process http://launchpadlibrarian.net/26405344/23_lsb_useragent.patch -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
Modified patch to not require sed, or a helper script. ** Attachment added: Patch to modify default prefs file with the correct useragent string during build process (without using sed or a helper script!) http://launchpadlibrarian.net/26409331/23_lsb_useragent.patch -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
please use lsb_release -s -c for the general.useragent.vendorComment text. besides from that its ok. Please include a changelog entry in your diff (aka full debdiff). -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
... and here's the debdiff. (with a small bug fix as well) ** Attachment added: debdiff to correct epiphany useragent string http://launchpadlibrarian.net/26411305/epiphany_lsb_useragent_debdiff.patch -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
Okay, I think I've really got it now. Better debdiff attached. Sorry for the spam. ** Attachment added: debd http://launchpadlibrarian.net/26412707/epiphany_lsb_release_good_debdiff.patch -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
This bug was fixed in the package epiphany-browser - 2.26.1-0ubuntu2 --- epiphany-browser (2.26.1-0ubuntu2) karmic; urgency=low * Fix default prefs file to use info from lsb_release (LP: #332253) -- Mike Pontillo ponti...@gmail.com Wed, 06 May 2009 15:30:31 -0700 ** Changed in: epiphany-browser (Ubuntu) Status: In Progress = Fix Released -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
using postinst commands is the wrong way you can simply ship a .js with the pacakge or patch the source as debian is doing -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
there is probably no need to bother using lsb values, static versions should work or use those in the rules to build the .js at build time rather -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
I had a feeling that might be the case, but based on Alexander's suggestion above, I wasn't sure where the best place to modify the .js file would be. If Debian already has this same fix in native code, then I agree, that's the way to go. We could use the same script at the time of packaging rather than the time of installation. (But would 'lsb_release' always return the correct values when the .js file is being packaged? I assume there are other ways to get that data for the architecture the package is being generated for, but pre-determining it seems like more of a hack.) We could use a similar postinst script to generate a separate .js file with the current lsb_release info, and modify the default default- prefs.js to comment out the lines that set the values to empty strings. -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
I've never worked with Debian packages (other than with checkinstall) before, but would something like this do the trick? The script depends on: echo mktemp lsb_release cut sed cat rm It unconditionally replaces the default user-agent string every time the script is run. I tested the script itself and it works for me. (user-agent came back as Mozilla/5.0 (X11; U; Linux i686; en; rv:1.9.0.10) Gecko/20080528 Ubuntu/9.04 (jaunty) Epiphany/2.22 Firefox/3.0) ** Attachment added: postinst script for epiphany-browser-data to set the user agent http://launchpadlibrarian.net/26298199/epiphany-browser-data.postinst -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
** Changed in: epiphany-browser (Ubuntu) Status: Confirmed = In Progress ** Changed in: epiphany-browser (Ubuntu) Assignee: Ubuntu Desktop Bugs (desktop-bugs) = Mike Pontillo (mpontillo) -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
e.g. put the prefs in /usr/share/epiphany-browser/default-prefs.js -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
the prefs you need to set are: general.useragent.vendor=Ubuntu (get this from lsb_release -i) general.useragent.vendorComment=jaunty (get this from lsb_release -c) general.useragent.vendorSub=9.04 (get this from lsb_release -r) -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
thank you for your bug report, that would be a nice task for a new contributor to work on ** Changed in: epiphany-browser (Ubuntu) Importance: Low = Wishlist Assignee: (unassigned) = Ubuntu Desktop Bugs (desktop-bugs) Status: New = Confirmed -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
** Changed in: epiphany-browser (Ubuntu) Importance: Undecided = Low -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 332253] Re: Epiphany doesn't mention Ubuntu in user agent string
** Description changed: Binary package hint: epiphany-browser The Wine project is trying to streamline their download page by detecting the distribution of visitors. However, Epiphany doesn't - mention Ubuntu in the user agent string, so it's impossible to detect. + mention Ubuntu in the user agent string, so Epiphany users will get the + non-streamlined download page. - http://www.winehq.org/pipermail/wine-devel/2009-February/073411.html + Epiphany is using the useragent string + Mozilla/5.0 (X11; U; Linux x86_64; en; rv:1.9.0.6) Gecko/20080528 Epiphany/2.22 Firefox/3.0 + but firefox puts the distro in between the Gecko and the browser name + Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.6) Gecko/2009020911 Ubuntu/8.10 (intrepid) Firefox/3.0.6 + + It would be nice if Epiphany did the same. + + See also http://www.winehq.org/pipermail/wine- + devel/2009-February/073411.html Ubuntu 8.10 x86-64 Epiphany 2.24.1 -- Epiphany doesn't mention Ubuntu in user agent string https://bugs.launchpad.net/bugs/332253 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to epiphany-browser in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
