[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Changed in: rhythmbox Status: New => Expired -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in Ubuntu. https://bugs.launchpad.net/bugs/445141 Title: Podcasts don't download if the files are all the same filename. To manage notifications about this bug go to: https://bugs.launchpad.net/rhythmbox/+bug/445141/+subscriptions -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Hi, I'm using Rhytmbox 0.12.8 in a computer with Ubuntu 10.04 installed. I installed Rhythmbox from the official repositories. Today I've tried to add the following podcasts: http://feeds.feedburner.com/coffeebreakfrench and http://feeds.feedburner.com/coffeebreakspanish but the files are not downloaded with the right name (for example file are saved as http---feedproxy.google.com--r-coffeebreakfrench--5-NyjQ-KhK-sE-cbf-306-basic.mp3 instead of cbf-306-basic.mp3). How can I get the right names working? I've read that the bug seems to be solved. Cheers, -Luca -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. https://bugs.launchpad.net/bugs/445141 Title: Podcasts don't download if the files are all the same filename. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
@Luca: I'm no authority on this but your situation looks strange. The filename you are seeing is constructed as a result of the patch that was submitted to fix the bug. However, for you podcast it shouldn't fall back to the escaped uri filename because gvfs-info reports that stardard::edit-name is set, which means edit-name should be taken as the filename (since copy-name is not set). I would look at the debug output when downloading any of those podcasts: run rhythmbox -d. Sidenote re my comment #19: it seems people do care about filenames. But handling podcasts with episodes with identical copy-name's (and/or edit- name's) still needs to be resolved. Perhaps a new bug needs to be submitted? -- You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. https://bugs.launchpad.net/bugs/445141 Title: Podcasts don't download if the files are all the same filename. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
The fix above seems to cover one case, but there's another that I just stumbled
upon. The standard::copy-name attribute might not be set by the gvfs backend.
In that case, currently, we fall back to edit-name attribute (and only if
that's not set either -- to escaped URI). That causes the original undesired
behavior that prompted this bug report: podcasts with non-unique file
attributes/file names are unusable. Here's a real example:
$ gvfs-info http://computersciencepodcast.com/download-mp3/1/episode.mp3
display name: episode.mp3
edit name: episode.mp3
...
attributes:
...
standard::display-name: episode.mp3
standard::edit-name: episode.mp3
A fix for this particular case could be to fall back to the escaped URI
and not to edit-name attr when copy-name is not set (see trivial patch
for this below). However, that wouldn't really cure the real issue: it
would be nice if Rhythmbox were robust against non-unique file
attributes (ie, even if they are set) and file names on podcasts. Of
course, this is a problem of podcast creators, but it might still make
sense to work around it, esp. since in the canonical Rhythmbox user
doesn't care about filenames of saved podcasts at all. A patch for this
is not included but seems simple as well -- just always use the current
fall-back-to-URI path for the local filename.
Patch to not fall back on edit-name when copy-name is null (for real
example above):
diff --git rhythmbox-0.13.0git20100819.orig/podcast/rb-podcast-manager.c
rhythmbox-0.13.0git20100819.no-copy-name/podcast/rb-podcast-manager.c
index a972490..d195684 100644
--- rhythmbox-0.13.0git20100819.orig/podcast/rb-podcast-manager.c
+++ rhythmbox-0.13.0git20100819.no-copy-name/podcast/rb-podcast-manager.c
@@ -769,14 +769,7 @@ download_podcast (GFileInfo *src_info,
RBPodcastManagerInfo *data)
if (src_info != NULL) {
data-download_size = g_file_info_get_attribute_uint64
(src_info, G_FILE_ATTRIBUTE_STANDARD_SIZE);
-
local_file_name = g_file_info_get_attribute_as_string
(src_info, G_FILE_ATTRIBUTE_STANDARD_COPY_NAME);
- if (local_file_name == NULL) {
- /* probably shouldn't be using this, but the gvfs http
backend doesn't
-* set the copy name (yet)
-*/
- local_file_name = g_strdup (g_file_info_get_edit_name
(src_info));
- }
g_object_unref (src_info);
}
--
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to rhythmbox in ubuntu.
https://bugs.launchpad.net/bugs/445141
Title:
Podcasts don't download if the files are all the same filename.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
This bug was fixed in the package rhythmbox - 0.12.8-0ubuntu7 --- rhythmbox (0.12.8-0ubuntu7) lucid-proposed; urgency=low * debian/control: - Update Vcs-Bzr link * debian/patches/07_use_escaped_podcast_uri.patch: - Handle podcasts that have sound files with the same basename (LP: #445141) -- Robert Ancell robert.anc...@canonical.com Tue, 22 Jun 2010 17:06:19 +1000 ** Changed in: rhythmbox (Ubuntu Lucid) Status: Fix Committed = Fix Released -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Tags added: verification-done ** Tags removed: verification-needed -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
@NoBugs!, did you try a development version of Rhythmbox? When you run a newer version it migrates the database to the new format, when you return to an older version you will get the error you saw. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Yeah, I actually tried the package from Maverick 10.10 before I tried the Lucid-proposed. That must have been the problem. I went back to the old rhythmbox 0.12.8-0ubuntu6, I still get the could not load the music database error every time I run it. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Removed the old database with: rm ~/.local/share/rhythmbox/rhythmdb.xml then it rebuilds the database, and works fine. The lucid-proposed update works, those podcasts download correctly, thank you for fixing it :) -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Accepted rhythmbox into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance! ** Tags added: verification-needed -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Branch linked: lp:ubuntu/lucid-proposed/rhythmbox -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Could not load the music database The database was created by a later version of Rhythmbox. This version of Rhythmbox cannot read the database. I get this error on the new lucid-proposed Rhythmbox, it always shows that error and reloads all music, and it doesn't show my previously subscribed podcasts. Other than that, it works, bug is fixed :) -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Branch linked: lp:~ubuntu-desktop/rhythmbox/ubuntu -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
This bug was fixed in the package rhythmbox - 0.12.8git20100616-0ubuntu3 --- rhythmbox (0.12.8git20100616-0ubuntu3) maverick; urgency=low * 05_use_escaped_podcast_uri.patch: - Handle podcasts that have sound files with the same basename (LP: #445141) -- Robert Ancell robert.anc...@canonical.com Tue, 22 Jun 2010 16:34:28 +1000 ** Changed in: rhythmbox (Ubuntu) Status: Triaged = Fix Released -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Branch linked: lp:~ubuntu-desktop/rhythmbox/lucid -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Proposing for Lucid:
- The change only affects new podcasts that are downloaded
- Test case:
1. Open Rhythmbox
2. Add
http://deimos3.apple.com/WebObjects/Core.woa/Feed/cmu.edu.1335575211.01335575214
as a podcast (Ctrl+P)
3. Download 2 tracks in the podcast
4. Confirm the tracks are different (in the current version they will be the
same)
Patch:
diff --git a/podcast/rb-podcast-manager.c b/podcast/rb-podcast-manager.c
index c220bf2..c23c320 100644
--- a/podcast/rb-podcast-manager.c
+++ b/podcast/rb-podcast-manager.c
@@ -29,6 +29,7 @@
#include config.h
#include string.h
+#include ctype.h
#define __USE_XOPEN
#include time.h
@@ -790,9 +791,15 @@ download_podcast (GFileInfo *src_info,
RBPodcastManagerInfo *data)
}
if (local_file_name == NULL) {
- /* fall back to the basename from the original URI */
- local_file_name = g_file_get_basename (data-source);
- rb_debug (didn't get a filename from the file info request;
using basename %s, local_file_name);
+ char *c;
+
+ /* fall back to the escaped URI */
+ local_file_name = g_file_get_uri (data-source);
+ for (c = local_file_name; *c; c++) {
+ if (!isalnum (*c) *c != '.')
+ *c = '-';
+ }
+ rb_debug (didn't get a filename from the file info request;
using escaped uri %s, local_file_name);
}
/* if the filename ends with the query string from the original URI,
--
--
Podcasts don't download if the files are all the same filename.
https://bugs.launchpad.net/bugs/445141
You received this bug notification because you are a member of Ubuntu
Desktop Bugs, which is subscribed to rhythmbox in ubuntu.
--
desktop-bugs mailing list
desktop-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Also affects: rhythmbox (Ubuntu Lucid) Importance: Undecided Status: New ** Changed in: rhythmbox (Ubuntu Lucid) Importance: Undecided = Low ** Changed in: rhythmbox (Ubuntu Lucid) Status: New = Fix Committed ** Changed in: rhythmbox (Ubuntu Lucid) Assignee: (unassigned) = Robert Ancell (robert-ancell) -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Branch linked: lp:ubuntu/rhythmbox -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Changed in: rhythmbox Status: Unknown = New -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
In Rhythmbox 0.12.8 On Ubuntu 10.04 I have the same problem with this podcast (French, about IT): http://podcast.bfmradio.fr/channel9/BFMchannel9.xml Each episode consists of 2 files with the same name in the same folder. So only the first one is correctly downloaded and not the second one. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
I also tried disabling Rhythmbox plugins, that doesn't help... still have this problem in 10.04. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
That 60-second science podcast breaks in rhythmbox, I also noticed the download meter shows 130% and above while it is downloading!? Then it doesn't show up as downloaded at all. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
I've subscribed to SciAm 60-seconds science: http://rss.sciam.com/sciam/60secsciencepodcast The feed contains URLs that are actually redirects, which is very common among podcasts. In RB 0.12.5 running on Karmic there's no problem: the saved file name is the final redirected name. In RB 0.12.8 running in Lucid, the saved file name is always podcast.mp3, lame! Strangely enough, I tried doing this on Lucid: $ sudo apt-get -t karmic install rhythmbox trying to downgrade my RB. But the RB 0.12.5 installed this way still carries the bug ... I'm so confused! -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Any progress on this bug? I noticed gPodder didn't have a problem with podcasts like this, can the gPodder downloader be integrated somehow into rhythmbox? -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Bug watch added: GNOME Bug Tracker #600504 https://bugzilla.gnome.org/show_bug.cgi?id=600504 ** Also affects: rhythmbox via https://bugzilla.gnome.org/show_bug.cgi?id=600504 Importance: Unknown Status: Unknown ** Changed in: rhythmbox (Ubuntu) Status: Confirmed = Triaged -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Changed in: rhythmbox (Ubuntu) Status: New = Confirmed -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
I had this bug too. And when I deleted the podcast, including all the files, Rythmbox crashed. Deleting Podcast excluding files went fine. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Robert could you have a look to this one? ** Changed in: rhythmbox (Ubuntu) Status: Incomplete = New ** Changed in: rhythmbox (Ubuntu) Assignee: Ubuntu Desktop Bugs (desktop-bugs) = Robert Ancell (robert-ancell) -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
I think the source of the problem is somewhere around line 764 of rb-podcast-manager.c. local_file_name shouldn't be just the end file name, but the full url, otherwise all podcast downloads will overwrite the same enclosure.mp3. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
Thanks for the report, could you provide an example to the report? Thanks. ** Changed in: rhythmbox (Ubuntu) Importance: Undecided = Low ** Changed in: rhythmbox (Ubuntu) Status: New = Incomplete ** Changed in: rhythmbox (Ubuntu) Assignee: (unassigned) = Ubuntu Desktop Bugs (desktop-bugs) -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
As an example, try adding this podcast (or almost any other itunesU based podcast) http://deimos3.apple.com/WebObjects/Core.woa/Feed/cmu.edu.1335575211.01335575214 Now right click, download an episode, then right click another, download, repeat... Notice that it says several episodes are downloaded, yet when you play them they are actually all the same one. Also, go to the podcast's folder, it will only have one file, named enclosure. -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is a bug assignee. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
[Bug 445141] Re: Podcasts don't download if the files are all the same filename.
** Tags added: likely-dup -- Podcasts don't download if the files are all the same filename. https://bugs.launchpad.net/bugs/445141 You received this bug notification because you are a member of Ubuntu Desktop Bugs, which is subscribed to rhythmbox in ubuntu. -- desktop-bugs mailing list desktop-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/desktop-bugs
