Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[John D. Ament]

Just a late night thought.  What about bumping the major versions for both
to indicate the incompatibility?  It gives volunteers the option to back
port features if needed to the current release lines.

On Oct 19, 2016 17:10, "John D. Ament"  wrote:

Well, I think the difference is that internally 5.x uses Camel for routing
in addition to the camel component.  Any camel integration for Artemis is
external.

John


On Wed, Oct 19, 2016 at 5:02 PM Clebert Suconic 
wrote:

> For artemis: I have used JDK 1.8 last release I built. I believe
> Martyn also used 1.8 on the releases he deployed.
>
> All the apache CIs for Artemis are using JDK 1.8 afaik. (will double
> check later)
>
> I have some internal CIs on my dev env that are also using 1.8.
>
> The only thing we didn't do is the require JVM on compilation. Would
> there be any issues on Camel?
>
> On Wed, Oct 19, 2016 at 2:55 PM, Christopher Shannon
>  wrote:
> > Well we do need 1.8 so we can use Camel 2.18 and fix OSGi stuff in 5.15.
> > And I figured it would be a bit odd if 5.x upgraded but Artemis didn't
> > upgrade.
> >
> >
> > On Wed, Oct 19, 2016 at 1:28 PM, Clebert Suconic <
> clebert.suco...@gmail.com>
> > wrote:
> >
> >> man... I'm messed up today.. wrong thread ... (on my previous message)
> >>
> >> anyways... If we can keep 1.7 for now and move it when we need it?
> >>
> >> I'm already using JDK 1.8 for dev, and I believe everybody is... all
> >> the CIs are on JDK 1.8, but from time to time I check on 1.7 just to
> >> be sure.
> >>
> >>
> >> My main concern is with clients.. from time to time I see users
> >> needing JDK 1.LD on clients.
> >>
> >>
> >>
> >> On Wed, Oct 19, 2016 at 1:26 PM, Clebert Suconic
> >>  wrote:
> >> > Actually, this was originally written by @CSchneider :)  ...
> >> >
> >> > On Wed, Oct 19, 2016 at 8:44 AM, Christopher Shannon
> >> >  wrote:
> >> >> With the release of Camel 2.18 I thought now was a good time to
> propose
> >> >> this.  I think for the ActiveMQ 5.15 release we should bump the
> required
> >> >> Java version to Java 8 as this will allow us to use Camel 2.18 so we
> can
> >> >> finally fix our OSGi module and drop the deprecated Spring DM
> entirely.
> >> >> This release probably won't go out until sometime next year and by
> that
> >> >> time JDK 9 should be either released or close to being released and
> JDK
> >> 7
> >> >> will have had its last public update nearly 2 years ago.
> >> >>
> >> >> Also, I figure we might as well do the same thing for Artemis.
> >> >>
> >> >> Any objections or reasons to stick with Java 7?
> >> >
> >> >
> >> >
> >> > --
> >> > Clebert Suconic
> >>
> >>
> >>
> >> --
> >> Clebert Suconic
> >>
>
>
>
> --
> Clebert Suconic
>

[GitHub] activemq-artemis issue #850: [ARTEMIS-802] Broker does not throw exception o...

[bayern39]

Github user bayern39 commented on the issue:

https://github.com/apache/activemq-artemis/pull/850
  
@jbertram  OK,I will take it next time!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #851: [ARTEMIS-708] Incorrect ConcurrentHashSet.remov...

[bayern39]

Github user bayern39 commented on the issue:

https://github.com/apache/activemq-artemis/pull/851
  
@clebertsuconic  It looks good for me.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[Clebert Suconic]

For artemis: I have used JDK 1.8 last release I built. I believe
Martyn also used 1.8 on the releases he deployed.

All the apache CIs for Artemis are using JDK 1.8 afaik. (will double
check later)

I have some internal CIs on my dev env that are also using 1.8.

The only thing we didn't do is the require JVM on compilation. Would
there be any issues on Camel?

On Wed, Oct 19, 2016 at 2:55 PM, Christopher Shannon
 wrote:
> Well we do need 1.8 so we can use Camel 2.18 and fix OSGi stuff in 5.15.
> And I figured it would be a bit odd if 5.x upgraded but Artemis didn't
> upgrade.
>
>
> On Wed, Oct 19, 2016 at 1:28 PM, Clebert Suconic 
> wrote:
>
>> man... I'm messed up today.. wrong thread ... (on my previous message)
>>
>> anyways... If we can keep 1.7 for now and move it when we need it?
>>
>> I'm already using JDK 1.8 for dev, and I believe everybody is... all
>> the CIs are on JDK 1.8, but from time to time I check on 1.7 just to
>> be sure.
>>
>>
>> My main concern is with clients.. from time to time I see users
>> needing JDK 1.LD on clients.
>>
>>
>>
>> On Wed, Oct 19, 2016 at 1:26 PM, Clebert Suconic
>>  wrote:
>> > Actually, this was originally written by @CSchneider :)  ...
>> >
>> > On Wed, Oct 19, 2016 at 8:44 AM, Christopher Shannon
>> >  wrote:
>> >> With the release of Camel 2.18 I thought now was a good time to propose
>> >> this.  I think for the ActiveMQ 5.15 release we should bump the required
>> >> Java version to Java 8 as this will allow us to use Camel 2.18 so we can
>> >> finally fix our OSGi module and drop the deprecated Spring DM entirely.
>> >> This release probably won't go out until sometime next year and by that
>> >> time JDK 9 should be either released or close to being released and JDK
>> 7
>> >> will have had its last public update nearly 2 years ago.
>> >>
>> >> Also, I figure we might as well do the same thing for Artemis.
>> >>
>> >> Any objections or reasons to stick with Java 7?
>> >
>> >
>> >
>> > --
>> > Clebert Suconic
>>
>>
>>
>> --
>> Clebert Suconic
>>



-- 
Clebert Suconic

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/839
  
@graben  I have merged, after I reverted some of the bad code I made you 
do. Can you check please?

And sorry about that.. I really thought the ProtocolTracker was externally 
used.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #839: ARTEMIS-793 Improvement to OSGi integrat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/839


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #851: [ARTEMIS-708] Incorrect ConcurrentHashSet.remov...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/851
  
@bayern39 I have added a commit on top of yours.. take a look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

[graben]

Github user graben commented on the issue:

https://github.com/apache/activemq-artemis/pull/839
  
@clebertsuconic That's fine with me 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/839
  
@graben I actually just asked this on the dev-list


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/839
  
@graben I thought ProtocolTracker was part of the API. it's for internal 
use only.

We could have renamed it as much as we wanted. Since I'm the one who messed 
up I will fix this one :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #850: [ARTEMIS-802] Broker does not throw exce...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/850


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #851: [ARTEMIS-708] Incorrect ConcurrentHashSe...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/851


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #850: [ARTEMIS-802] Broker does not throw exception o...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/850
  
Just for consistency's sake, can you remove the square brackets from around 
the JIRA?  Back in the old days those were required for tracking commits, but 
they aren't needed with current tools.

Also, can you add a simple test to ensure the new functionality is working 
as expected and that if it changes inadvertently in the future we'll catch it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[John D. Ament]

But then no one can claim Artemis is 6.x... 

On Oct 19, 2016 15:17, "Clebert Suconic"  wrote:

> ok, lets do it then. +1
>
> On Wed, Oct 19, 2016 at 2:55 PM, Christopher Shannon
>  wrote:
> > Well we do need 1.8 so we can use Camel 2.18 and fix OSGi stuff in 5.15.
> > And I figured it would be a bit odd if 5.x upgraded but Artemis didn't
> > upgrade.
> >
> >
> > On Wed, Oct 19, 2016 at 1:28 PM, Clebert Suconic <
> clebert.suco...@gmail.com>
> > wrote:
> >
> >> man... I'm messed up today.. wrong thread ... (on my previous message)
> >>
> >> anyways... If we can keep 1.7 for now and move it when we need it?
> >>
> >> I'm already using JDK 1.8 for dev, and I believe everybody is... all
> >> the CIs are on JDK 1.8, but from time to time I check on 1.7 just to
> >> be sure.
> >>
> >>
> >> My main concern is with clients.. from time to time I see users
> >> needing JDK 1.LD on clients.
> >>
> >>
> >>
> >> On Wed, Oct 19, 2016 at 1:26 PM, Clebert Suconic
> >>  wrote:
> >> > Actually, this was originally written by @CSchneider :)  ...
> >> >
> >> > On Wed, Oct 19, 2016 at 8:44 AM, Christopher Shannon
> >> >  wrote:
> >> >> With the release of Camel 2.18 I thought now was a good time to
> propose
> >> >> this.  I think for the ActiveMQ 5.15 release we should bump the
> required
> >> >> Java version to Java 8 as this will allow us to use Camel 2.18 so we
> can
> >> >> finally fix our OSGi module and drop the deprecated Spring DM
> entirely.
> >> >> This release probably won't go out until sometime next year and by
> that
> >> >> time JDK 9 should be either released or close to being released and
> JDK
> >> 7
> >> >> will have had its last public update nearly 2 years ago.
> >> >>
> >> >> Also, I figure we might as well do the same thing for Artemis.
> >> >>
> >> >> Any objections or reasons to stick with Java 7?
> >> >
> >> >
> >> >
> >> > --
> >> > Clebert Suconic
> >>
> >>
> >>
> >> --
> >> Clebert Suconic
> >>
>
>
>
> --
> Clebert Suconic
>

[GitHub] activemq-artemis issue #780: ARTEMIS-735 Refactoring of JUnit Tests in artem...

[jbertram]

Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/780
  
Any update on this PR?  It not only needs to be squashed, but the commit 
message needs to be amended to follow the 50/72 pattern discussed in the 
[Hacking 
Guide](https://github.com/apache/activemq-artemis/blob/master/docs/hacking-guide/en/maintainers.md#commit-messages).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[Christopher Shannon]

Well we do need 1.8 so we can use Camel 2.18 and fix OSGi stuff in 5.15.
And I figured it would be a bit odd if 5.x upgraded but Artemis didn't
upgrade.


On Wed, Oct 19, 2016 at 1:28 PM, Clebert Suconic 
wrote:

> man... I'm messed up today.. wrong thread ... (on my previous message)
>
> anyways... If we can keep 1.7 for now and move it when we need it?
>
> I'm already using JDK 1.8 for dev, and I believe everybody is... all
> the CIs are on JDK 1.8, but from time to time I check on 1.7 just to
> be sure.
>
>
> My main concern is with clients.. from time to time I see users
> needing JDK 1.LD on clients.
>
>
>
> On Wed, Oct 19, 2016 at 1:26 PM, Clebert Suconic
>  wrote:
> > Actually, this was originally written by @CSchneider :)  ...
> >
> > On Wed, Oct 19, 2016 at 8:44 AM, Christopher Shannon
> >  wrote:
> >> With the release of Camel 2.18 I thought now was a good time to propose
> >> this.  I think for the ActiveMQ 5.15 release we should bump the required
> >> Java version to Java 8 as this will allow us to use Camel 2.18 so we can
> >> finally fix our OSGi module and drop the deprecated Spring DM entirely.
> >> This release probably won't go out until sometime next year and by that
> >> time JDK 9 should be either released or close to being released and JDK
> 7
> >> will have had its last public update nearly 2 years ago.
> >>
> >> Also, I figure we might as well do the same thing for Artemis.
> >>
> >> Any objections or reasons to stick with Java 7?
> >
> >
> >
> > --
> > Clebert Suconic
>
>
>
> --
> Clebert Suconic
>

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/849


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[Clebert Suconic]

Actually, this was originally written by @CSchneider :)  ...

On Wed, Oct 19, 2016 at 8:44 AM, Christopher Shannon
 wrote:
> With the release of Camel 2.18 I thought now was a good time to propose
> this.  I think for the ActiveMQ 5.15 release we should bump the required
> Java version to Java 8 as this will allow us to use Camel 2.18 so we can
> finally fix our OSGi module and drop the deprecated Spring DM entirely.
> This release probably won't go out until sometime next year and by that
> time JDK 9 should be either released or close to being released and JDK 7
> will have had its last public update nearly 2 years ago.
>
> Also, I figure we might as well do the same thing for Artemis.
>
> Any objections or reasons to stick with Java 7?



-- 
Clebert Suconic

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[Clebert Suconic]

man... I'm messed up today.. wrong thread ... (on my previous message)

anyways... If we can keep 1.7 for now and move it when we need it?

I'm already using JDK 1.8 for dev, and I believe everybody is... all
the CIs are on JDK 1.8, but from time to time I check on 1.7 just to
be sure.


My main concern is with clients.. from time to time I see users
needing JDK 1.LD on clients.



On Wed, Oct 19, 2016 at 1:26 PM, Clebert Suconic
 wrote:
> Actually, this was originally written by @CSchneider :)  ...
>
> On Wed, Oct 19, 2016 at 8:44 AM, Christopher Shannon
>  wrote:
>> With the release of Camel 2.18 I thought now was a good time to propose
>> this.  I think for the ActiveMQ 5.15 release we should bump the required
>> Java version to Java 8 as this will allow us to use Camel 2.18 so we can
>> finally fix our OSGi module and drop the deprecated Spring DM entirely.
>> This release probably won't go out until sometime next year and by that
>> time JDK 9 should be either released or close to being released and JDK 7
>> will have had its last public update nearly 2 years ago.
>>
>> Also, I figure we might as well do the same thing for Artemis.
>>
>> Any objections or reasons to stick with Java 7?
>
>
>
> --
> Clebert Suconic



-- 
Clebert Suconic

Re: artemis-server-osgi/ProtocolTracker

[Clebert Suconic]

actually.. @CShneider (Christian Schneider)...

On Wed, Oct 19, 2016 at 1:11 PM, Clebert Suconic
 wrote:
> @Cshanon: The class ProtocolTrackerCallback on artemis-server-osgi, is
> it part of an API or it's for internal usage only?
>
>
> There's an open PR around OSGI* and I asked a few changed because it
> would "break" the APi.. but it seems this is intentionally just for
> the OsgiBroker itself, being internal API and not consumed by users.
>
>
> I'm still learning my ways through OSGI, so it's better to ask than
> break anything.
>
>
> *= https://github.com/apache/activemq-artemis/pull/839
>
>
> --
> Clebert Suconic



-- 
Clebert Suconic

artemis-server-osgi/ProtocolTracker

[Clebert Suconic]

@Cshanon: The class ProtocolTrackerCallback on artemis-server-osgi, is
it part of an API or it's for internal usage only?


There's an open PR around OSGI* and I asked a few changed because it
would "break" the APi.. but it seems this is intentionally just for
the OsgiBroker itself, being internal API and not consumed by users.


I'm still learning my ways through OSGI, so it's better to ask than
break anything.


*= https://github.com/apache/activemq-artemis/pull/839


-- 
Clebert Suconic

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[Jim Gomes]

+1 for 8.

On Wed, Oct 19, 2016, 6:54 AM Timothy Bish  wrote:

> +1  time to move on to 8
>
> On 10/19/2016 08:44 AM, Christopher Shannon wrote:
> > With the release of Camel 2.18 I thought now was a good time to propose
> > this.  I think for the ActiveMQ 5.15 release we should bump the required
> > Java version to Java 8 as this will allow us to use Camel 2.18 so we can
> > finally fix our OSGi module and drop the deprecated Spring DM entirely.
> > This release probably won't go out until sometime next year and by that
> > time JDK 9 should be either released or close to being released and JDK 7
> > will have had its last public update nearly 2 years ago.
> >
> > Also, I figure we might as well do the same thing for Artemis.
> >
> > Any objections or reasons to stick with Java 7?
> >
>
>
> --
> Tim Bish
> twitter: @tabish121
> blog: http://timbish.blogspot.com/
>
>

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[Timothy Bish]

+1  time to move on to 8

On 10/19/2016 08:44 AM, Christopher Shannon wrote:

With the release of Camel 2.18 I thought now was a good time to propose
this.  I think for the ActiveMQ 5.15 release we should bump the required
Java version to Java 8 as this will allow us to use Camel 2.18 so we can
finally fix our OSGi module and drop the deprecated Spring DM entirely.
This release probably won't go out until sometime next year and by that
time JDK 9 should be either released or close to being released and JDK 7
will have had its last public update nearly 2 years ago.

Also, I figure we might as well do the same thing for Artemis.

Any objections or reasons to stick with Java 7?




--
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[John D. Ament]

+1 sounds good.

On Oct 19, 2016 09:49, "Claus Ibsen"  wrote:

> +1 to upgrade to Java 8
>
> On Wed, Oct 19, 2016 at 2:44 PM, Christopher Shannon
>  wrote:
> > With the release of Camel 2.18 I thought now was a good time to propose
> > this.  I think for the ActiveMQ 5.15 release we should bump the required
> > Java version to Java 8 as this will allow us to use Camel 2.18 so we can
> > finally fix our OSGi module and drop the deprecated Spring DM entirely.
> > This release probably won't go out until sometime next year and by that
> > time JDK 9 should be either released or close to being released and JDK 7
> > will have had its last public update nearly 2 years ago.
> >
> > Also, I figure we might as well do the same thing for Artemis.
> >
> > Any objections or reasons to stick with Java 7?
>
>
>
> --
> Claus Ibsen
> -
> http://davsclaus.com @davsclaus
> Camel in Action 2: https://www.manning.com/ibsen2
>

Openwire: New line character in message

[ActiveMQ Investigation]

Hello,

I am using openwire. When I receive FIX message, I am getting new line
character in beginning and end of the message from ActiveMQ broker.

Is there anyway to avoid these chr(10):

Message received:

Whole message [
35=AS|755=yaj314|70=yaj314|71=2|795=yaj314|794=8|87=3|857=1|54=2|55=MKS|48=GB0031274896|207=XLON|22=4|53=51|6=4.3359|15=GBP|453=1|448=WINS|447=D|452=1|75=20160219|60=20160219-11:44:55|63=0|64=20160223|78=1|79=507ZBIM|80=51|153=4.3359|154=221.13|120=GBP
]

Way it should be:
Whole message
[35=AS|755=yaj314|70=yaj314|71=2|795=yaj314|794=8|87=3|857=1|54=2|55=MKS|48=GB0031274896|207=XLON|22=4|53=51|6=4.3359|15=GBP|453=1|448=WINS|447=D|452=1|75=20160219|60=20160219-11:44:55|63=0|64=20160223|78=1|79=507ZBIM|80=51|153=4.3359|154=221.13|120=GBP]

Problem is that GBP gets a new line. Instead of removing them for every
message, is there any config on ActiveMQ side to say that don't receive new
line. OR I am missing some bit here.

We don't have two messages coming togather to delimit by new line so it's a
bit of trouble to remove these new line everytime.

Your help will be appreciated.



Thanks
AJ



--
View this message in context: 
http://activemq.2283324.n4.nabble.com/Openwire-New-line-character-in-message-tp4718083.html
Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.

Re: [DISCUSS] Require Java 8 for 5.15 and Artemis

[Claus Ibsen]

+1 to upgrade to Java 8

On Wed, Oct 19, 2016 at 2:44 PM, Christopher Shannon
 wrote:
> With the release of Camel 2.18 I thought now was a good time to propose
> this.  I think for the ActiveMQ 5.15 release we should bump the required
> Java version to Java 8 as this will allow us to use Camel 2.18 so we can
> finally fix our OSGi module and drop the deprecated Spring DM entirely.
> This release probably won't go out until sometime next year and by that
> time JDK 9 should be either released or close to being released and JDK 7
> will have had its last public update nearly 2 years ago.
>
> Also, I figure we might as well do the same thing for Artemis.
>
> Any objections or reasons to stick with Java 7?



-- 
Claus Ibsen
-
http://davsclaus.com @davsclaus
Camel in Action 2: https://www.manning.com/ibsen2

[DISCUSS] Require Java 8 for 5.15 and Artemis

[Christopher Shannon]

With the release of Camel 2.18 I thought now was a good time to propose
this.  I think for the ActiveMQ 5.15 release we should bump the required
Java version to Java 8 as this will allow us to use Camel 2.18 so we can
finally fix our OSGi module and drop the deprecated Spring DM entirely.
This release probably won't go out until sometime next year and by that
time JDK 9 should be either released or close to being released and JDK 7
will have had its last public update nearly 2 years ago.

Also, I figure we might as well do the same thing for Artemis.

Any objections or reasons to stick with Java 7?

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

[TomasHofman]

Github user TomasHofman commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/849#discussion_r84056887
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
 ---
@@ -290,9 +292,19 @@ public int getServerVersion() {
 
@Override
public ClientSession.AddressQuery addressQuery(final SimpleString 
address) throws ActiveMQException {
-  SessionBindingQueryResponseMessage_V3 response = 
(SessionBindingQueryResponseMessage_V3) sessionChannel.sendBlocking(new 
SessionBindingQueryMessage(address), PacketImpl.SESS_BINDINGQUERY_RESP_V3);
-
-  return new AddressQueryImpl(response.isExists(), 
response.getQueueNames(), response.isAutoCreateJmsQueues(), 
response.isAutoCreateJmsTopics());
+  if (sessionChannel.supports(PacketImpl.SESS_BINDINGQUERY_RESP_V3)) {
--- End diff --

I checked and failing tests are passing on my local machine when using 
original commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #849: ARTEMIS-805 old JMS clients failing on n...

[TomasHofman]

Github user TomasHofman commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/849#discussion_r84055604
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/ActiveMQSessionContext.java
 ---
@@ -290,9 +292,19 @@ public int getServerVersion() {
 
@Override
public ClientSession.AddressQuery addressQuery(final SimpleString 
address) throws ActiveMQException {
-  SessionBindingQueryResponseMessage_V3 response = 
(SessionBindingQueryResponseMessage_V3) sessionChannel.sendBlocking(new 
SessionBindingQueryMessage(address), PacketImpl.SESS_BINDINGQUERY_RESP_V3);
-
-  return new AddressQueryImpl(response.isExists(), 
response.getQueueNames(), response.isAutoCreateJmsQueues(), 
response.isAutoCreateJmsTopics());
+  if (sessionChannel.supports(PacketImpl.SESS_BINDINGQUERY_RESP_V3)) {
--- End diff --

```sessionChannel.supports()``` doesn't give correct results, I think I was 
trying that. The problem was that ```connection.getClientVersion()``` returned 
zero in ```ChannelImpl.supports()```, hence I was comparing version numbers 
directly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #839: ARTEMIS-793 Improvement to OSGi integration

[graben]

Github user graben commented on the issue:

https://github.com/apache/activemq-artemis/pull/839
  
I love checkstyle. :) I thought about the actual implementation and did 
some small refactorings. Now I think it fits best. But we may think about 
synchronizing in callback as they are called in separate threads.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #851: [ARTEMIS-708] Incorrect ConcurrentHashSe...

[bayern39]

GitHub user bayern39 opened a pull request:

https://github.com/apache/activemq-artemis/pull/851

[ARTEMIS-708]  Incorrect ConcurrentHashSet.remove call in 
QueueImpl.DelayedAddRedistributor.run

https://issues.apache.org/jira/browse/ARTEMIS-708

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bayern39/activemq-artemis ARTEMIS-708

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/851.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #851


commit 3dfa5db96a5522553f34537d8b355433163a9ed5
Author: bayern39 
Date:   2016-10-19T07:53:10Z

[ARTEMIS-708] Incorrect ConcurrentHashSet.remove call in 
QueueImpl.DelayedAddRedistributor.run




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #847: ARTEMIS-808 use privileges to stop executor

[jmesnil]

Github user jmesnil commented on the issue:

https://github.com/apache/activemq-artemis/pull/847
  
@jbertram thanks, I checked that with that changes our tests with security 
manager pass again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---