[GitHub] activemq pull request #257: Misc. fixes

2017-07-28 Thread dtrebbien 
GitHub user dtrebbien opened a pull request:

https://github.com/apache/activemq/pull/257

Misc. fixes

While testing my [SLF4J Helper](http://plugins.netbeans.org/plugin/72557/) 
plugin for NetBeans IDE, I found some fixes and minor improvements that can be 
made.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dtrebbien/activemq misc-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq/pull/257.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #257


commit 2897dd09d3109b05251617059b53f785d1dc9b9e
Author: Daniel Trebbien 
Date:   2017-07-29T01:43:41Z

Utilize parameterized logging and remove calls to toString()

As suggested in the SLF4J FAQ: 
https://www.slf4j.org/faq.html#logging_performance
parameterized logging can improve the efficiency of logger calls when
logging at the specified level is disabled.

In addition, per the FAQ: https://www.slf4j.org/faq.html#paramException
since SLF4J 1.6.0 it is possible to use parameterized logging and also
log an exception/throwable.

toString() is called automatically: 
https://www.slf4j.org/faq.html#string_contents

These changes were suggested by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/

commit 9c11c24a0f270202812328be679262310c0166b4
Author: Daniel Trebbien 
Date:   2017-07-29T01:58:05Z

Fix some incorrect SLF4J logger calls

In some cases, there were an inconsistent number of formatting anchors.

In other cases, formatting anchors were used, but because the
trace/debug/info/warn/error(String, Throwable) variant was used, the
string is a message string rather than a format string.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/

commit 5eca75a870b11b7d1cda2233231092c8a1dc5291
Author: Daniel Trebbien 
Date:   2017-07-29T02:18:26Z

Fix an apparent copy/paste typo

commit 4133cc3df872e9cf5732cd85ea7ef271b0876c73
Author: Daniel Trebbien 
Date:   2017-07-29T02:23:27Z

Fix some typos

commit 4b83641a2b55afa5c29e350480bb52bb09c70584
Author: Daniel Trebbien 
Date:   2017-07-29T02:24:59Z

Use simpler SLF4J API functions

Eliminates the need to construct a new (temporary) Object array object.

These changes were suggested by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/

commit 1cc482568d4c21065880c0f4294ce6aecdb956f7
Author: Daniel Trebbien 
Date:   2017-07-29T02:28:18Z

Reformat some code

commit a582b84e0f159e667020b4a7975d66edc4173506
Author: Daniel Trebbien 
Date:   2017-07-29T02:29:42Z

Mark boolean 'debug' fields as transient

commit 62ee55a43ecfab05428579f78dd505a629bd6b95
Author: Daniel Trebbien 
Date:   2017-07-29T02:32:59Z

Mark `staticCache' final

This fixes a warning in NetBeans IDE about synchronizing on a non-final
field.

commit 4a337d380093f533dad621d388585841cffa0dc1
Author: Daniel Trebbien 
Date:   2017-07-29T02:47:35Z

Fix inconsistent 'info'-level logger calls

Some calls to info() were guarded by checks that logging at the trace
level is enabled.

These issues were found by SLF4J Helper for NetBeans IDE:
http://plugins.netbeans.org/plugin/72557/




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1427: [ARTEMIS-1309] Import johnzon.core pack...

2017-07-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1427


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1423: ARTEMIS-1299 support commas in RA conne...

2017-07-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1423


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1422: ARTEMIS-1306 clarify identity for authn...

2017-07-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1422: ARTEMIS-1306 clarify identity for authn failur...

2017-07-28 Thread clebertsuconic 
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1422
  
don't forget to close the jira :)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #1385: ARTEMIS-1270 Management Console - Hawtio Solut...

2017-07-28 Thread clebertsuconic 
Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1385
  
I will merge this then.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[RESULT] Apache Artemis 2.2.0

2017-07-28 Thread Clebert Suconic 
Vote for the Apache ActiveMQ Artemis 2.2.0 has passed with 7 Votes,

binding:
Clebert Suconic
Timothy Bish
Christopher Shannon
Martyn Taylor


non binding:
Michael Andre Pearce
Francesco Nigro
John Ament


Thanks for the support and taking time for the vote.

I will update the website and upload everything on Monday July-31st.



Clebert

[GitHub] activemq-artemis issue #1428: ARTEMIS-1308: Delegate acknowlegde to ClientMe...

2017-07-28 Thread jbertram 
Github user jbertram commented on the issue:

https://github.com/apache/activemq-artemis/pull/1428
  
How will the ack get to the broker if you don't commit the session?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1428: ARTEMIS-1308: Delegate acknowlegde to C...

2017-07-28 Thread michaelandrepearce 
GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1428

ARTEMIS-1308: Delegate acknowlegde to ClientMessage

ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1308

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1428


commit a1887fb8271e1e660d16683f4dc6a62309feeaf4
Author: Michael Andre Pearce 
Date:   2017-07-28T13:27:29Z

ARTEMIS-1308: Delegate acknowlegde to ClientMessage

ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1427: [ARTEMIS-1309] Import johnzon.core pack...

2017-07-28 Thread jbonofre 
GitHub user jbonofre opened a pull request:

https://github.com/apache/activemq-artemis/pull/1427

[ARTEMIS-1309] Import johnzon.core package in the artemis-server-osgi…

… bundle

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbonofre/activemq-artemis ARTEMIS-1309

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1427.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1427


commit b4ba347152fc638b7f72957a59e8bc4baec96ef4
Author: Jean-Baptiste Onofré 
Date:   2017-07-28T15:03:27Z

[ARTEMIS-1309] Import johnzon.core package in the artemis-server-osgi bundle




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [VOTE] Apache Artemis 2.2.0

2017-07-28 Thread Martyn Taylor 
+1

On Wed, Jul 26, 2017 at 8:28 PM, Christopher Shannon <
christopher.l.shan...@gmail.com> wrote:

> +1
>
> On Wed, Jul 26, 2017 at 1:26 PM, nigro_franz  wrote:
>
> > +1
> >
> > * Built from source and ran tests
> > * Ran from binary vs a load generator
> >
> >
> >
> > --
> > View this message in context: http://activemq.2283324.n4.
> > nabble.com/VOTE-Apache-Artemis-2-2-0-tp4728886p4728940.html
> > Sent from the ActiveMQ - Dev mailing list archive at Nabble.com.
> >
>

[GitHub] activemq-artemis pull request #1426: ARTEMIS-1305 Server frozen during shutd...

2017-07-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1426


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1424: fixed some minor typos in description w...

2017-07-28 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1424


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1425: ARTEMIS-1308: Delegate acknowlegde to C...

2017-07-28 Thread michaelandrepearce 
Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1425


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1426: ARTEMIS-1305 Server frozen during shutd...

2017-07-28 Thread clebertsuconic 
GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1426

ARTEMIS-1305 Server frozen during shutdown on Resource Adapter

this is a better fix than the previous one

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis ARTEMIS-1305

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1426.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1426


commit 019eff8309a3cd80f0f90c2fc0c224b8c0dd45b5
Author: Clebert Suconic 
Date:   2017-07-28T13:38:19Z

ARTEMIS-1305 Server frozen during shutdown on Resource Adapter

this is a better fix than the previous one




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1425: ARTEMIS-1308: Delegate acknowlegde to C...

2017-07-28 Thread michaelandrepearce 
GitHub user michaelandrepearce opened a pull request:

https://github.com/apache/activemq-artemis/pull/1425

ARTEMIS-1308: Delegate acknowlegde to ClientMessage

ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/michaelandrepearce/activemq-artemis 
ARTEMIS-1308

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1425.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1425


commit 676d2cdd7c0c7184c2828a2e07d431793b559ad7
Author: Michael Andre Pearce 
Date:   2017-07-28T13:27:29Z

ARTEMIS-1308: Delegate acknowlegde to ClientMessage

ActiveMQMessage acknowledge should delegate to ClientMessage acknowledge




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #1424: fixed some minor typos in description w...

2017-07-28 Thread pgfox 
GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/1424

fixed some minor typos in description within option annotations



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis cli_desc_typos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1424.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1424


commit 4edb750165a8d8c27e4126e3e5b0ed0a321c40f7
Author: Pat Fox 
Date:   2017-07-28T13:00:59Z

fixed some minor typos in cli description annotations




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---