[GitHub] activemq-artemis issue #1552: ARTEMIS-1438 Upgrade hawtio to 1.5.3

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1552
  
I'll let you handle it. :) (I'll be on holidays next week)


---

[GitHub] activemq-artemis issue #1552: ARTEMIS-1438 Upgrade hawtio to 1.5.3

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1552
  
I'll try look into this issue this week, so then we can upgrade unless you 
want to give it a go? 


---

[GitHub] activemq-artemis issue #1552: ARTEMIS-1438 Upgrade hawtio to 1.5.3

[gaohoward]

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1552
  
Sorry I didn't notice we had this issue. The blank page occurs when you 
start broker up and go
http://localhost:8161/console, it points to a page full of JS scripts. It 
supposed to show the login page, but instead it's blank (I tested on ubuntu 
with FF and Chrome). 

Let me close this PR until we have a solution.



---

[GitHub] activemq-artemis pull request #1552: ARTEMIS-1438 Upgrade hawtio to 1.5.3

[gaohoward]

Github user gaohoward closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1552


---

[GitHub] activemq-artemis issue #1552: ARTEMIS-1438 Upgrade hawtio to 1.5.3

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1552
  
Also where do you note a blank page? Is it on initial login for very first 
time? If so originally we had a welcome page, this was deactived by @mtaylor as 
the initial page wasn't very good, if that is the issue maybe we create a 
better welcome page?


---

[GitHub] activemq-artemis issue #1552: ARTEMIS-1438 Upgrade hawtio to 1.5.3

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1552
  
Doing this also updates jvm plugin that exposes oracle flight recorder, 
which during the initial work caused a -1 , this is why we regressed the 
version to .0 on purpose.

 will need to find a way to disable the jfr parts of the jvm plugin, before 
we can do this upgrade. I would suggest looking at maybe making an override 


---

[GitHub] activemq-artemis pull request #1552: ARTEMIS-1438 Upgrade hawtio to 1.5.3

[gaohoward]

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/1552

ARTEMIS-1438 Upgrade hawtio to 1.5.3

To fix the management console blank page issue

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis 
bmaster_hawtio_upgrade

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1552


commit b6eb59bfebb1a81244ec8b8c20833b1a67bb325b
Author: Howard Gao 
Date:   2017-09-26T01:10:03Z

ARTEMIS-1438 Upgrade hawtio to 1.5.3
To fix the management console blank page issue




---

Re: [DISCUSS] release process improvements

[Robbie Gemmell]

I just left the echo statement in as it was an extra little separator :)

I actually already removed the file from the scripts dir earlier, I
didn't think folks would really use it other than for the release and
thats covered by the one in the dist repo now.

I already mentioned on the JIRA, but as im sending this anyway...there
was a new file that didn't make the website update commit, it will
need an 'svn add'.

On 25 September 2017 at 19:24, Clebert Suconic
 wrote:
> Looks good... I will merge the changes...
>
>
> just one [funny] thing about my original script:
>
>
> this print here:
>
>
>   echo $theFile
>
>
>
> It was a debug statement that I forgot to remove it... I will remove
> it from the artemis prepare one.
>
>
> And also,  should I keep the download-release.sh on the scripts or should it 
> go?
>
> On Mon, Sep 25, 2017 at 1:29 PM, Robbie Gemmell
>  wrote:
>> I've raised https://issues.apache.org/jira/browse/ARTEMIS-1437 with a
>> patch for the website around fixing this and some other issues, plus
>> splitting the older releases out to their own page, if folks could
>> take a look and see what they think.
>>
>> Robbie
>>
>> On 18 September 2017 at 16:58, Robbie Gemmell  
>> wrote:
>>> The links for some of the older 1.5.x releases on the site seem to be
>>> broken also, still pointing to the main dist release or mirrors rather
>>> than the archive where the files are now.
>>>
>>> The download page should also be linking to the checksums, but
>>> currently only links to the signatures.
>>>
>>> On 18 September 2017 at 16:42, Timothy Bish  wrote:
 On 09/18/2017 11:35 AM, Clebert Suconic wrote:
>
> Talking about releases... I know there's a policy to archive
> releases... Tim Bish had once archived a couple of ActiveMQ
> releases...
>
>
> It's time to archive a few in Artemis now. (...will look for docs)
>
>
> I could do it next week.. unless someone do it before me. (I'm not
> really working this week)


 You should be archiving the previous release on each new release. Archiving
 is done by removing the release from dist.apache.org and updating the
 website download links for that release to point to archive.apache.org

 The current dist site appears to not have been cleaned up, so you need to
 remove 1.5.4, 2.0.0, 2.1.0 and 2.2.0 and update your download links to be 
 in
 compliance with Apache processes.

>
> On Sat, Sep 16, 2017 at 6:14 AM, Robbie Gemmell
>  wrote:
>>
>> Yep. I'm not sure exactly how much longer than this it has been the
>> recommendation, but after noticing we started swapping each component
>> at Qpid over to using SHA512 checksums in March as they each get
>> released. Most have changed over now, though still a couple final less
>> frequently released bits left to go.
>>
>> If people are concerned at dropping the SHA1 outright we could always
>> have both, perhaps for a time as a form of switchover period. I don't
>> personally think thats really necessary.
>>
>> Robbie
>>
>> On 15 September 2017 at 21:18, Timothy Bish  wrote:
>>>
>>> On 09/15/2017 03:59 PM, Clebert Suconic wrote:

 Just for my education. Why you Decided to drop downloading the .sha1
 and
 are creating a new one?

 All the other downloads we have are using the .sha1?


 --
 Tim Bish
 twitter: @tabish121
 blog: http://timbish.blogspot.com/

>
>
>
> --
> Clebert Suconic

Re: [DISCUSS] release process improvements

[Clebert Suconic]

Looks good... I will merge the changes...


just one [funny] thing about my original script:


this print here:


  echo $theFile



It was a debug statement that I forgot to remove it... I will remove
it from the artemis prepare one.


And also,  should I keep the download-release.sh on the scripts or should it go?

On Mon, Sep 25, 2017 at 1:29 PM, Robbie Gemmell
 wrote:
> I've raised https://issues.apache.org/jira/browse/ARTEMIS-1437 with a
> patch for the website around fixing this and some other issues, plus
> splitting the older releases out to their own page, if folks could
> take a look and see what they think.
>
> Robbie
>
> On 18 September 2017 at 16:58, Robbie Gemmell  
> wrote:
>> The links for some of the older 1.5.x releases on the site seem to be
>> broken also, still pointing to the main dist release or mirrors rather
>> than the archive where the files are now.
>>
>> The download page should also be linking to the checksums, but
>> currently only links to the signatures.
>>
>> On 18 September 2017 at 16:42, Timothy Bish  wrote:
>>> On 09/18/2017 11:35 AM, Clebert Suconic wrote:

 Talking about releases... I know there's a policy to archive
 releases... Tim Bish had once archived a couple of ActiveMQ
 releases...


 It's time to archive a few in Artemis now. (...will look for docs)


 I could do it next week.. unless someone do it before me. (I'm not
 really working this week)
>>>
>>>
>>> You should be archiving the previous release on each new release. Archiving
>>> is done by removing the release from dist.apache.org and updating the
>>> website download links for that release to point to archive.apache.org
>>>
>>> The current dist site appears to not have been cleaned up, so you need to
>>> remove 1.5.4, 2.0.0, 2.1.0 and 2.2.0 and update your download links to be in
>>> compliance with Apache processes.
>>>

 On Sat, Sep 16, 2017 at 6:14 AM, Robbie Gemmell
  wrote:
>
> Yep. I'm not sure exactly how much longer than this it has been the
> recommendation, but after noticing we started swapping each component
> at Qpid over to using SHA512 checksums in March as they each get
> released. Most have changed over now, though still a couple final less
> frequently released bits left to go.
>
> If people are concerned at dropping the SHA1 outright we could always
> have both, perhaps for a time as a form of switchover period. I don't
> personally think thats really necessary.
>
> Robbie
>
> On 15 September 2017 at 21:18, Timothy Bish  wrote:
>>
>> On 09/15/2017 03:59 PM, Clebert Suconic wrote:
>>>
>>> Just for my education. Why you Decided to drop downloading the .sha1
>>> and
>>> are creating a new one?
>>>
>>> All the other downloads we have are using the .sha1?
>>>
>>>
>>> --
>>> Tim Bish
>>> twitter: @tabish121
>>> blog: http://timbish.blogspot.com/
>>>



-- 
Clebert Suconic

Re: [DISCUSS] release process improvements

[Robbie Gemmell]

I've raised https://issues.apache.org/jira/browse/ARTEMIS-1437 with a
patch for the website around fixing this and some other issues, plus
splitting the older releases out to their own page, if folks could
take a look and see what they think.

Robbie

On 18 September 2017 at 16:58, Robbie Gemmell  wrote:
> The links for some of the older 1.5.x releases on the site seem to be
> broken also, still pointing to the main dist release or mirrors rather
> than the archive where the files are now.
>
> The download page should also be linking to the checksums, but
> currently only links to the signatures.
>
> On 18 September 2017 at 16:42, Timothy Bish  wrote:
>> On 09/18/2017 11:35 AM, Clebert Suconic wrote:
>>>
>>> Talking about releases... I know there's a policy to archive
>>> releases... Tim Bish had once archived a couple of ActiveMQ
>>> releases...
>>>
>>>
>>> It's time to archive a few in Artemis now. (...will look for docs)
>>>
>>>
>>> I could do it next week.. unless someone do it before me. (I'm not
>>> really working this week)
>>
>>
>> You should be archiving the previous release on each new release. Archiving
>> is done by removing the release from dist.apache.org and updating the
>> website download links for that release to point to archive.apache.org
>>
>> The current dist site appears to not have been cleaned up, so you need to
>> remove 1.5.4, 2.0.0, 2.1.0 and 2.2.0 and update your download links to be in
>> compliance with Apache processes.
>>
>>>
>>> On Sat, Sep 16, 2017 at 6:14 AM, Robbie Gemmell
>>>  wrote:

 Yep. I'm not sure exactly how much longer than this it has been the
 recommendation, but after noticing we started swapping each component
 at Qpid over to using SHA512 checksums in March as they each get
 released. Most have changed over now, though still a couple final less
 frequently released bits left to go.

 If people are concerned at dropping the SHA1 outright we could always
 have both, perhaps for a time as a form of switchover period. I don't
 personally think thats really necessary.

 Robbie

 On 15 September 2017 at 21:18, Timothy Bish  wrote:
>
> On 09/15/2017 03:59 PM, Clebert Suconic wrote:
>>
>> Just for my education. Why you Decided to drop downloading the .sha1
>> and
>> are creating a new one?
>>
>> All the other downloads we have are using the .sha1?
>>
>>
>> --
>> Tim Bish
>> twitter: @tabish121
>> blog: http://timbish.blogspot.com/
>>

Re: [DISCUSS] release process improvements

[Robbie Gemmell]

I've made some similar updates to the script for artemis, and
similarly moved it into a new area in the dist dev repo, at
https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/

I raised https://github.com/apache/activemq-artemis/pull/1551 to
update the artemis release guide accordingly with details of how to
stage the release bits in the dev area before the vote and add them to
the release area after it passes.

Robbie

On 22 September 2017 at 06:00, Clebert Suconic
 wrote:
> +1
>
> On Thu, Sep 21, 2017 at 10:09 AM Robbie Gemmell 
> wrote:
>
>> Tim created a variant of the helper script for use in doing ActiveMQ
>> 5.x releases, and did an initial update of the release guide details
>> based on that.
>>
>> When discussing some updates with him that I could do to finish off
>> the release guide changes, it occurred to me it would be a lot easier
>> to just put the script into the dist dev area, which he also liked.
>> I've made some tweaks to the script and added it in a new subdir for
>> staging the 5.x releases at:
>> https://dist.apache.org/repos/dist/dev/activemq/activemq/
>>
>> I've updated release guide instructions accordingly, showing how to
>> stage the release bits in the dev area before the vote and add them to
>> the release area after it passes:
>> https://cwiki.apache.org/confluence/display/ACTIVEMQ/Release+Guide
>>
>> I thought I'd run this by everyone to see what you think, I believe
>> doing the same for Artemis under
>> https://dist.apache.org/repos/dist/dev/activemq/artemis/ would
>> similarly improve things further there too, and can do that next if
>> folks are happy.
>>
>> Robbie
>>
>> On 15 September 2017 at 16:55, Robbie Gemmell 
>> wrote:
>> > I tweaked the helper script to verify the downloaded tar/zip files
>> > using their downloaded signature, then update the downloaded .md5 file
>> > with filename info so it can verify easily with CLI tools, dropped
>> > downloading the .sha1 and generated a new .sha512, and then at the end
>> > verifies all the checksums as a sanity check (somewhat superfluous for
>> > the SHA512, but doesn't hurt).
>> >
>> >
>> https://github.com/apache/activemq-artemis/commit/b7b2960e1f1870246f0c113f56d22cfc0f7a4269
>> >
>> > If folks are happy with this I can update the instructions at
>> > https://github.com/apache/activemq-artemis/blob/master/RELEASING.md to
>> > reflect the slight process changes needed.
>> >
>> > Robbie
>> >
>> > On 14 September 2017 at 15:32, Clebert Suconic
>> >  wrote:
>> >> I thought about checking the sum. Didn't have time.
>> >>
>> >> I would check the files created by nexus Instead of creating new ones
>> >> thought.
>> >>
>> >>
>> >> Feel free to tweak the script.  I will be out for a week.  I will just
>> >> finish the release and I will be away for a week.
>> >>
>> >> On Thu, Sep 14, 2017 at 5:48 AM Robbie Gemmell <
>> robbie.gemm...@gmail.com>
>> >> wrote:
>> >>
>> >>> Script looks good, though I'd tweak it a little to cover the eased
>> >>> checksum verification and supplying a SHA512 one (more below).
>> >>>
>> >>> I agree that similar changes would be good for the ActiveMQ 5 releases
>> >>> also, thats the main reason I didn't just detail things on the Artemis
>> >>> 2.3.0 vote thread.
>> >>>
>> >>> Back to the script, I'd suggest tweaking it to add a check that the
>> >>> signature verifies to ensure the downloaded files are ok, then rather
>> >>> than download the .sha1 I'd have it generate a .sha512 file instead,
>> >>> and would similarly update/regenerate the .md5 file to embed filename
>> >>> info so it verifies easily with the CLI tooling. E.g:
>> >>>
>> >>> gpg --verify $theFile.asc
>> >>> md5sum $theFile > $theFile.md5
>> >>> sha512sum $theFile > $theFile.sha512
>> >>>
>> >>> Then testers and end users downloading the checksum files can just
>> >>> verify them with the -c flags on the CLI tools, e.g you can check all
>> >>> the checksums with just:
>> >>> md5sum -c *.md5
>> >>> sha512sum -c *.sha512
>> >>>
>> >>> On 13 September 2017 at 23:36, Clebert Suconic
>> >>>  wrote:
>> >>> > Ok, fair enough... I can see this as a process improvement.
>> >>> >
>> >>> > I wasn't just understanding what you were proposing clearly enough.
>> >>> >
>> >>> > I just added this script here:
>> >>> >
>> >>>
>> https://github.com/apache/activemq-artemis/blob/master/scripts/download-release.sh
>> >>> >
>> >>> >
>> >>> > I didn't update the RELEASE.md yet...
>> >>> >
>> >>> >
>> >>> > I would add that during the release, you use the download-release
>> from
>> >>> > the staged mvn repo using that script into the dev area.
>> >>> > The vote would have the staged download on dev, and we just make a
>> >>> > simple copy from one place to the other.. and remove the previous
>> >>> > thing.
>> >>> >
>> >>> >
>> >>> > But I think this should be also done on ActiveMQ 5 releases.

[GitHub] activemq-artemis pull request #1551: NO-JIRA: update release guide to use di...

[gemmellr]

GitHub user gemmellr opened a pull request:

https://github.com/apache/activemq-artemis/pull/1551

NO-JIRA: update release guide to use dist dev repo

Updates the release guide based on improvements discussion on the dev list 
around use of new helper script at 
https://dist.apache.org/repos/dist/dev/activemq/activemq-artemis/

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gemmellr/activemq-artemis update-release-guide

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1551.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1551


commit b4ac0faee800743af1f048e6e7698a749ed62569
Author: Robbie Gemmell 
Date:   2017-09-25T16:11:48Z

NO-JIRA: update release guide to use dist dev repo




---

[GitHub] activemq-artemis issue #1543: NO-JIRA update StatQueue to allow greater_than...

[pgfox]

Github user pgfox commented on the issue:

https://github.com/apache/activemq-artemis/pull/1543
  
sure, will do that, thanks @clebertsuconic 


---

[GitHub] activemq-artemis issue #1536: ARTEMIS-1422 fix RedeployTest after match chan...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1536
  
@jbertram I closed this one since @michaelandrepearce sent another fix.

let me know if you have any considerations about it please.


---

[GitHub] activemq-artemis pull request #1536: ARTEMIS-1422 fix RedeployTest after mat...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1536


---

[GitHub] activemq-artemis pull request #1537: ARTEMIS-1422 Fix match change to suppor...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1537


---

Re: [VOTE] Apache ActiveMQ 5.15.1

[Timothy Bish]

On 09/25/2017 10:00 AM, Christopher Shannon wrote:

Hi Everyone,

I have created the ActiveMQ 5.15.1 release and it's ready for a vote.
This release uses the new process based on the discussion from last
week.

The list of resolved issues is here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12341031

You can get the release artifacts here:
https://dist.apache.org/repos/dist/dev/activemq/activemq/5.15.1/

Maven repository is at:
https://repository.apache.org/content/repositories/orgapacheactivemq-1149/

Source tag: 
https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=commit;h=37227fbf8bf2308d45dddb169483864007ef5560

Please vote to approve this release.  The vote will remain open for 72 hours.

[ ] +1 Release the binary as Apache ActiveMQ 5.15.1
[ ] -1 (provide specific comments)

Here's my +1


+1

* Checked validated signatures and checksums
* Checked for license and notice files in the archives
* Extracted binary broker archive and ran the broker, tested against 
Qpid JMS example and exercised the Web Console.
* Built from source and ran the sanity test profile as well as the full 
AMQP test suite.



--
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/

[GitHub] activemq-artemis pull request #1539: MQTT work

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1539


---

Re: [VOTE] Apache ActiveMQ 5.15.1

[Robbie Gemmell]

On 25 September 2017 at 15:00, Christopher Shannon
 wrote:
> Hi Everyone,
>
> I have created the ActiveMQ 5.15.1 release and it's ready for a vote.
> This release uses the new process based on the discussion from last
> week.
>
> The list of resolved issues is here:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12341031
>
> You can get the release artifacts here:
> https://dist.apache.org/repos/dist/dev/activemq/activemq/5.15.1/
>
> Maven repository is at:
> https://repository.apache.org/content/repositories/orgapacheactivemq-1149/
>
> Source tag: 
> https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=commit;h=37227fbf8bf2308d45dddb169483864007ef5560
>
> Please vote to approve this release.  The vote will remain open for 72 hours.
>
> [ ] +1 Release the binary as Apache ActiveMQ 5.15.1
> [ ] -1 (provide specific comments)
>
> Here's my +1

+1 (non-binding)

I checked things out as follows:
- Verified the signature and checksum files.
- Checked for licence and notice files being present in the archives.
- Ran the source build (only, no tests).
- Started the broker from the tar.gz binary archive and ran some AMQP
client examples against it.
- Used the maven staging repo to run the Qpid JMS master build+tests
against the updated broker.

Robbie

[GitHub] activemq-artemis pull request #1540: ARTEMIS-1398 NPE on null pwd from MQTT ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1540


---

[GitHub] activemq-artemis issue #1543: NO-JIRA update StatQueue to allow greater_than...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1543
  
This change warrants a JIRA with an improvement status. (it's not a feature 
per se... so this alone shouldn't bump the release requires into 1.5.. but it's 
definitely nice to have a JIRA.

Can you amend it?


---

[GitHub] activemq-artemis pull request #1549: ARTEMIS-1433 adding AddressMemoryUsage(...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1549


---

[GitHub] activemq-artemis pull request #1547: [ARTMIS-1431] Adapt transport configura...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1547


---

[GitHub] activemq-artemis pull request #1546: [ARTMIS-1431] Adapt transport configura...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1546


---

[GitHub] activemq-artemis pull request #1550: ARTEMIS-1435 - provide default jolokia-...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1550


---

[VOTE] Apache ActiveMQ 5.15.1

[Christopher Shannon]

Hi Everyone,

I have created the ActiveMQ 5.15.1 release and it's ready for a vote.
This release uses the new process based on the discussion from last
week.

The list of resolved issues is here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311210=12341031

You can get the release artifacts here:
https://dist.apache.org/repos/dist/dev/activemq/activemq/5.15.1/

Maven repository is at:
https://repository.apache.org/content/repositories/orgapacheactivemq-1149/

Source tag: 
https://git-wip-us.apache.org/repos/asf?p=activemq.git;a=commit;h=37227fbf8bf2308d45dddb169483864007ef5560

Please vote to approve this release.  The vote will remain open for 72 hours.

[ ] +1 Release the binary as Apache ActiveMQ 5.15.1
[ ] -1 (provide specific comments)

Here's my +1