[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1641
  
Haha no def not given up, :)

I'll open a new PR once it's been checked by the user that it works, ill 
work on docs and extra tests in mean time. I'll have to create a jira and amend 
commit text anyhow.


---

[GitHub] activemq-artemis pull request #1642: NO-JIRA - minor updates to sample, so i...

[pgfox]

GitHub user pgfox opened a pull request:

https://github.com/apache/activemq-artemis/pull/1642

NO-JIRA - minor updates to sample, so it works as described in comments

The LargeMessageExample was not working as described in docs: 

- FILESIZE was set to 1 MiB instead of 2 GiB
I had a look at the previous change to FILE_SIZE and my guess is the change 
was included in a commit as an oversight.  Please let me know if the file size 
was meant to be reduced and I will modify the PR to reflect that.

- ?minLargeMessageSize=10240 was omitted from URL.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pgfox/activemq-artemis large_message_example

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1642.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1642


commit 86b8a92e5fa8fede771ea07a47e186657dad4694
Author: Pat Fox 
Date:   2017-11-04T17:18:30Z

NO-JIRA - minor updates to sample, so it works as described in comments




---

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1641
  
@michaelandrepearce I thought you had given up.. :) 

also, the thing is.. if you close it... later you will need to open a new 
PR...
github doesn't do well when the head changed against your closed PR.. I 
haven't seen it working at least. (maybe the behaviour has changed).

If you want to close it now.. and open a new one later .. it's up to you.


---

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1641
  
Should I leave it open whilst I do that then? @clebertsuconic? Also do you 
think I should seperate documentation from the fix/improvement then?


---

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1641
  
*refactors


---

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1641
  
Still needs work, eg need to add tests so it doesn’t get regressed in 
future etc, add some documentation like there is in 5.x. Also I’d like 
@spaction to check it fixes it for him incase it doesn’t and I need to do 
some further refractors 


---

[GitHub] activemq-artemis issue #1641: Sorting issue with BeanUtils picking up set/ge...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1641
  
Why close it ?


---

Re: [VOTE] Apache ActiveMQ Artemis 2.4.0

[Michael André Pearce]

+1

Have performed some standard load and latency tests on physical servers, no 
negative regressions seen in gathered metrics.

Also performed some basic failover cases in ha setup.

Have checked with both Artemis core and amqp client no new issues seen some 
historic resolved.

Thanks Justin for the release :)


Sent from my iPhone

> On 3 Nov 2017, at 00:41, Clebert Suconic  wrote:
> 
> +1
> 
> Ran a few examples and tests. checked tags...
> 
> Nice one Justin!
> 
>> On Wed, Nov 1, 2017 at 5:21 PM, Timothy Bish  wrote:
>>> On 11/01/2017 02:53 AM, Justin Bertram wrote:
>>> 
>>> I would like to propose an Apache ActiveMQ Artemis 2.4.0 release.
>>> 
>>> We had these new features and improvements added as part of 2.4.0:
>>> 
>>> [ARTEMIS-534] - Allow JMX configuration from broker.xml
>>> [ARTEMIS-1447] - JDBC NodeManager to support JDBC HA Shared Store
>>> [ARTEMIS-1428] - Allow configuration of max frame payload length for STOMP
>>> web-socket
>>> [ARTEMIS-1463] - Implement rbac of management objects
>>> 
>>> The release notes can be found here:
>>> 
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12341540=12315920
>>> 
>>> Source and binary distributions can be found here:
>>> https://repository.apache.org/content/repositories/
>>> orgapacheactivemq-1153/org/apache/activemq/apache-artemis/2.4.0/
>>> 
>>> The Maven repository is here:
>>> https://repository.apache.org/content/repositories/orgapacheactivemq-1153
>>> 
>>> In case you want to give it a try with the maven repo on examples:
>>> http://activemq.apache.org/artemis/docs/latest/hacking-
>>> guide/validating-releases.html
>>> 
>>> The source tag:
>>> https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.
>>> git;a=tag;h=refs/tags/2.4.0
>>> 
>>> I will update the website after the vote has passed.
>>> 
>>> 
>>> [ ] +1 approve the release as Apache Artemis 2.4.0
>>> [ ] +0 no opinion
>>> [ ] -1 disapprove (and reason why)
>>> 
>>> Here's my +1
>>> 
>>> 
>>> Justin
>>> 
>> +1
>> 
>> * Validated signatures and checksums
>> * checked for license and notice files in the archives
>> * Created new broker instance from the binary package and ran it, check that
>> web console worked
>> * Ran some Qpid JMS client examples against the running broker
>> * Built from source and ran some of the tests including the AMQP tests in
>> the integration suite.
>> * Checked using mvn apache-rat:check that no missing license headers were
>> found.
>> 
>> 
>> --
>> Tim Bish
>> twitter: @tabish121
>> blog: http://timbish.blogspot.com/
>> 
> 
> 
> 
> -- 
> Clebert Suconic

[GitHub] activemq-artemis issue #1628: ARTEMIS-1364: Enable internal sorting in Hawti...

[michaelandrepearce]

Github user michaelandrepearce commented on the issue:

https://github.com/apache/activemq-artemis/pull/1628
  
@mtaylor i think we were looking at pushing sort down to broker as will be 
more elements than in FE table when many queues/address etc. Could you confirm? 


---

[GitHub] activemq-artemis pull request #1641: Sorting issue with BeanUtils picking up...

[michaelandrepearce]

Github user michaelandrepearce closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1641


---