[GitHub] activemq-artemis issue #1982: JUnit rules to be usable against external secu...

[mohamnag]

Github user mohamnag commented on the issue:

https://github.com/apache/activemq-artemis/pull/1982
  
@clebertsuconic I tried this week to find some time doing so, but it was a 
busy one. Will try to do it on weekend.


---

[GitHub] activemq-artemis pull request #1995: [ARTEMIS-1770] Log warning when connect...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1995


---

[GitHub] activemq-artemis pull request #1995: [ARTEMIS-1770] Log warning when connect...

[rstancel]

GitHub user rstancel opened a pull request:

https://github.com/apache/activemq-artemis/pull/1995

[ARTEMIS-1770] Log warning when connection is closed

Jira: https://issues.apache.org/jira/browse/ARTEMIS-1770

Master PR: https://github.com/apache/activemq-artemis/pull/1990

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rstancel/jboss-activemq-artemis 
ARTEMIS-1770_1.x

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1995.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1995






---

[GitHub] activemq-artemis pull request #1994: ARTEMIS-1787 Openwire message should no...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1994

ARTEMIS-1787 Openwire message should not contain internal property



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1787

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1994.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1994


commit 0210fee3bc3731e3173f012987bfd9d9f2965958
Author: Stanislav Knot 
Date:   2018-04-05T16:01:41Z

ARTEMIS-1787 Openwire message should not contain internal property




---

[GitHub] activemq-artemis pull request #1993: ARTEMIS-618 Using proper block size on ...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1993


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1990


---

[GitHub] activemq-artemis pull request #1986: ARTEMIS-1653 Allow database tables to b...

[franz1981]

Github user franz1981 closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1986


---

[GitHub] activemq-artemis pull request #1986: ARTEMIS-1653 Allow database tables to b...

[franz1981]

Github user franz1981 commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1986#discussion_r179441774
  
--- Diff: 
artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/drivers/AbstractJDBCDriver.java
 ---
@@ -191,9 +191,18 @@ private void createTableIfNotExists(String tableName, 
String... sqls) throws SQL
 } else {
try (Statement statement = connection.createStatement();
  ResultSet cntRs = 
statement.executeQuery(sqlProvider.getCountJournalRecordsSQL())) {
-  if (rs.next() && rs.getInt(1) > 0) {
+  int rows;
+  if (cntRs.next() && (rows = cntRs.getInt(1)) > 0) {
  logger.tracef("Table %s did exist but is not empty. 
Skipping initialization.", tableName);
+ if (logger.isDebugEnabled()) {
+final long expectedRows = 
Stream.of(sqls).map(String::toUpperCase).filter(sql -> sql.contains("INSERT 
INTO")).count();
--- End diff --

@clebertsuconic PLease do not merge it yet...because on DB2 it is creating 
some problems


---

[GitHub] activemq-artemis issue #1987: ARTEMIS-1781 Connector parameters not backward...

[TomasHofman]

Github user TomasHofman commented on the issue:

https://github.com/apache/activemq-artemis/pull/1987
  
@clebertsuconic I added my attempt at compatibility test.


---

[GitHub] activemq-artemis pull request #1990: [ARTEMIS-1770] Log warning instead of s...

[rstancel]

Github user rstancel commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1990#discussion_r179361706
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/client/impl/ClientSessionImpl.java
 ---
@@ -1539,6 +1540,8 @@ public void end(final Xid xid, final int flags) 
throws XAException {
 startCall();
 try {
sessionContext.xaEnd(xid, flags);
+} catch (ActiveMQNotConnectedException ex) {
+   
ActiveMQClientLogger.LOGGER.connectionClosedWarn(ex.getType(), ex.getMessage());
--- End diff --

@clebertsuconic Done.


---