[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[ingo1121]

Github user ingo1121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
Hi!

Sorry for the mess with the git tree!

 

I have some question, though: 

 

1.  What is your normal build procedure? On my fork, I’ve made a Jenkins 
job, that just does a ”mvn install” ob the root directory; no profiles or 
anything. Is that reasonable?
2.  I tried to make a ”full example” integration test; by running 
”mvn -Pexamples verify” on the examples directory. Unfortuatly it quickly 
runs out of steam (both on Windows and RHEL). Is this something that should be 
fixed? Should I register a JIRA? I notice that a lot of Java processes are left 
behind…

 

Regards

Ingemar

 

 

Från: clebertsuconic  
Skickat: den 3 april 2018 00:52
Till: apache/activemq-artemis 
Kopia: ingo1121 ; Mention 
Ämne: Re: [apache/activemq-artemis] ARTEMIS-1749 - Fixes the 
ssl-enabled-crl-mqtt (#1983)

 

I fixed it.. but your PR was way too messed up. if I had merged your 
merges.. we would have created a mess on master. please no merge commits on PRs.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub 
 , 
or mute the thread 

 .  

 




---

[GitHub] activemq-artemis pull request #1975: [ARTEMIS-1761] Log warning if cluster i...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1975#discussion_r179841255
  
--- Diff: 
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/BridgeImpl.java
 ---
@@ -930,9 +930,7 @@ protected void connect() {
scheduleRetryConnectFixedTimeout(this.retryInterval);
return;
 } else {
-   if (logger.isDebugEnabled()) {
-  logger.debug("Bridge " + this + " is unable to connect 
to destination. Retrying", e);
--- End diff --

Can you still keep the log.debug?

Didn't I see you doing this somewhere else? is that the same issue?


---

[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt

[ingo1121]

Github user ingo1121 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1983
  
Been absent on vacation. Back now. Sorry if i messed up the revision-tree!

 Anyway, now the examples in Windows is, is far as I can judge, consistent 
with examples on RHEL7. 


---

[GitHub] activemq-artemis issue #1994: ARTEMIS-1787 Openwire message should not conta...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1994
  
same thing I asked on the JIRA. Why it shouldn't? why only on noLocal?

trying to get some context on the why it should not be included...


it would be nice to include such thing on the commit description please.


---

[GitHub] activemq-artemis pull request #1998: ARTEMIS-1701 strip zone id from IPv6 ho...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1998


---

[GitHub] activemq-artemis pull request #1996: ARTEMIS-1776 Blocked Bridge is not resu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1996


---

[GitHub] activemq-artemis pull request #1998: ARTEMIS-1701 strip zone id from IPv6 ho...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/1998

ARTEMIS-1701 strip zone id from IPv6 host



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1701

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1998.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1998


commit 5725f7e2fa995ad554535baf58a7aa9917836a00
Author: Justin Bertram 
Date:   2018-02-23T21:05:00Z

ARTEMIS-1701 strip zone id from IPv6 host




---

[GitHub] activemq-artemis issue #1997: ARTEMIS-1653 Allow database tables to be creat...

[franz1981]

Github user franz1981 commented on the issue:

https://github.com/apache/activemq-artemis/pull/1997
  
@clebertsuconic @nlippke I know that the failing COUNT sounds weird, but it 
is quite simple to be reproduced with DB2 through the test attached :+1: 


---

[GitHub] activemq-artemis pull request #1997: ARTEMIS-1653 Allow database tables to b...

[franz1981]

GitHub user franz1981 opened a pull request:

https://github.com/apache/activemq-artemis/pull/1997

ARTEMIS-1653 Allow database tables to be created externally

The previous commit about this feature wasn't using the row count query
ResultSet.
The mechanics has been changed to allow the row count query
to fail, because DROP and CREATE aren't transactional and immediate
in most DBMS.
It includes a test that stress its mechanics if used with DBMS like
DB2 10.5 and Oracle 12c.
Additional checks and logs have been added to trace each steps.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/franz1981/activemq-artemis ARTEMIS-1653

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1997.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1997


commit 1e2b5270854ba19a87a3ba0fa308751ce9cc5122
Author: Francesco Nigro 
Date:   2018-04-03T08:11:04Z

ARTEMIS-1653 Allow database tables to be created externally

The previous commit about this feature wasn't using the row count query
ResultSet.
The mechanics has been changed to allow the row count query
to fail, because DROP and CREATE aren't transactional and immediate
in most DBMS.
It includes a test that stress its mechanics if used with DBMS like
DB2 10.5 and Oracle 12c.
Additional checks and logs have been added to trace each steps.




---

[GitHub] activemq-artemis pull request #1996: ARTEMIS-1776 Blocked Bridge is not resu...

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/1996

ARTEMIS-1776 Blocked Bridge is not resuming after reconnect

This is still part of ARTEMIS-1776 fix, which still part of the same 
release as we are on now.
Hence I'm not opening a new JIRA for this one.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis bridge

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1996.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1996


commit 91ed6e3a726b58d04d4155543f1701c6ee0d0ba2
Author: Clebert Suconic 
Date:   2018-04-06T14:00:43Z

ARTEMIS-1776 Blocked Bridge is not resuming after reconnect

This is still part of ARTEMIS-1776 fix, which still part of the same 
release as we are on now.
Hence I'm not opening a new JIRA for this one.




---

Re: How is proton-j used?

[Justin Bertram]

Proton-J is used to support the AMQP protocol. If you don't have any need
for AMQP support then I think you'll be safe removing it.

Also, this question should have gone to the "user" list.


Justin

On Fri, Apr 6, 2018 at 8:22 AM, William Hodges 
wrote:

> Hello all,
>
> I tried to post this message on the forum but I got a reply that it was
> not delivered. Hopefully, this will reach the mailing list.
>
>
> I need to remove the proton-j jar in the lib/optional/ directory but I'm
> not sure how that will affect ActiveMQ. My testing after removing the jar
> has been successful but I'm worried there are certain use-cases that will
> break it.
>
> How is the proton-j jar being used by ActiveMQ? Under what circumstances
> would removing this jar negatively affect ActiveMQ?
>
> Thanks!
>
> William Hodges
> Platform Research & Development
> william.hod...@sas.com
> (919)531-4739 x14739
>
>

How is proton-j used?

[William Hodges]

Hello all,

I tried to post this message on the forum but I got a reply that it was not 
delivered. Hopefully, this will reach the mailing list.


I need to remove the proton-j jar in the lib/optional/ directory but I'm not 
sure how that will affect ActiveMQ. My testing after removing the jar has been 
successful but I'm worried there are certain use-cases that will break it.

How is the proton-j jar being used by ActiveMQ? Under what circumstances would 
removing this jar negatively affect ActiveMQ?

Thanks!

William Hodges
Platform Research & Development
william.hod...@sas.com
(919)531-4739 x14739

How is proton-j used?

[wihodg]

I'm need to remove the proton-j jar in the lib/optional/ directory but I'm
not sure how that will affect ActiveMQ. My testing after removing the jar
has been successful but I'm worried there are certain use-cases that will
break it.

How is the proton-j jar being used by ActiveMQ? Under what circumstances
would removing this jar negatively affect ActiveMQ?



--
Sent from: http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html