[GitHub] activemq-artemis pull request #2070: NO-JIRA fix race in OpenWire temp queue...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2070


---

[GitHub] activemq-artemis issue #2069: NO-JIRA Adding checks for spawned servers on t...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2069
  
Yeah. It’s a typo. Will fix it. 


---

[GitHub] activemq-artemis pull request #2069: NO-JIRA Adding checks for spawned serve...

[jbertram]

Github user jbertram commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2069#discussion_r185966600
  
--- Diff: 
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/util/SpawnedTestBased.java
 ---
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.util;
+
+import org.junit.Rule;
+
+public class SpawnedTestBased extends ActiveMQTestBase {
--- End diff --

A bit of a nit-pick, but shouldn't this be `SpawnedTestBase` (i.e. no "d" 
on the end)?


---

[GitHub] activemq-artemis pull request #2070: NO-JIRA fix race in OpenWire temp queue...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/2070

NO-JIRA fix race in OpenWire temp queue test



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis master_work

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2070.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2070


commit b22c74e90c4ecf614a337ba345ee581ea7164861
Author: Justin Bertram 
Date:   2018-05-03T23:51:57Z

NO-JIRA fix race in OpenWire temp queue test




---

[GitHub] activemq-artemis pull request #2069: NO-JIRA Adding checks for spawned serve...

[clebertsuconic]

GitHub user clebertsuconic opened a pull request:

https://github.com/apache/activemq-artemis/pull/2069

NO-JIRA Adding checks for spawned servers on the testsuite



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/clebertsuconic/activemq-artemis spawn

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2069.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2069


commit 9ee073fb26629b2abc139da0ff44d07e08fdda76
Author: Clebert Suconic 
Date:   2018-05-03T01:04:29Z

NO-JIRA Adding checks for spawned servers on the testsuite




---

[GitHub] activemq-artemis pull request #2068: ARTEMIS-1848 auto-delete auto-created q...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2068


---

[GitHub] activemq-artemis issue #2060: ARTEMIS-1768: Fix handling of internalSession ...

[graben]

Github user graben commented on the issue:

https://github.com/apache/activemq-artemis/pull/2060
  
@clebertsuconic  can you also close ARTEMIS-1768? I unfortunately have no 
rights on this project to do it myself.


---

[GitHub] activemq-artemis pull request #2068: ARTEMIS-1848 auto-delete auto-created q...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/2068

ARTEMIS-1848 auto-delete auto-created queue for OpenWire



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1848

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2068.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2068


commit 25b6f36efd41c07bc35b090062f7b36db4f7406e
Author: Justin Bertram 
Date:   2018-05-03T17:18:51Z

ARTEMIS-1848 auto-delete auto-created queue for OpenWire




---

[GitHub] activemq-artemis pull request #2067: ARTEMIS-1847 Update to Netty 4.1.24.Fin...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2067


---

[GitHub] activemq-artemis issue #2067: ARTEMIS-1847 Update to Netty 4.1.24.Final

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2067
  
@tabish121 I'm fixing the checkstyle I broke with my last merge


---

[GitHub] activemq-artemis pull request #2067: ARTEMIS-1847 Update to Netty 4.1.24.Fin...

[tabish121]

GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/2067

ARTEMIS-1847 Update to Netty 4.1.24.Final



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1847

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2067.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2067


commit c62e467971216539fe82da7e00be1bf2972d211b
Author: Timothy Bish 
Date:   2018-05-03T16:57:15Z

ARTEMIS-1847 Update to Netty 4.1.24.Final




---

[GitHub] activemq-artemis pull request #2010: ARTEMIS-1801 removing null-unchecked de...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2010


---

[GitHub] activemq-artemis issue #2041: ARTEMIS-1825 Live-backup topology not correctl...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2041
  
@mtaylor / @andytaylor  / @michaelandrepearce  I didn't work on this module 
a lot... can you guys check on this?


---

[GitHub] activemq-artemis pull request #2035: [ARTEMIS-1819] Missing fields on listAl...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2035


---

[GitHub] activemq-artemis pull request #2051: ARTEMIS-1836 Bug with broker when runni...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2051


---

[GitHub] activemq-artemis pull request #2060: ARTEMIS-1768: Fix handling of internalS...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2060


---

[GitHub] activemq-artemis pull request #2057: ARTEMIS-1659 add test for reload on ina...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2057


---

[GitHub] activemq-artemis issue #2060: ARTEMIS-1768: Fix handling of internalSession ...

[clebertsuconic]

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2060
  
@graben thanks a lot!


---

[GitHub] activemq-artemis pull request #2063: [ARTEMIS-1844] Fix opening SSL connecti...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2063


---

[GitHub] activemq-artemis pull request #2064: ARTEMIS-1843 Update Qpid JMS 0.32.0 and...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2064


---

[GitHub] activemq-artemis pull request #2065: ARTEMIS-1846 fix activemq.usemaskedpass...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2065


---

Re: [HEADS-UP] 2.5.1 in one week

[Clebert Suconic]

Meanwhile please set your fixes as 2.5.1... i will rename it as 2.6.0
before releasing as everything is already filtered there.

On Thu, May 3, 2018 at 12:04 PM, Clebert Suconic
 wrote:
> From the entire set.. we only have fixes.. and 4 enhancements...
> (previously existent features).
>
> I would prefer saving 2.6.0 for a more substantial release.. but if
> you guys still prefer calling 2.6.0 I'm fine with that.
>
> On Thu, May 3, 2018 at 11:02 AM, Robbie Gemmell
>  wrote:
>> I see there are some updates retargetting JIRA version at 2.5.1 from
>> 2.6.0. I think the changes on master are now more suited to the
>> release being versioned as 2.6.0. There are plenty of changes in the
>> time since 2.5.0 that would have suited 2.5.x releases, but there
>> seems to be enough others in there now that might better fit a 2.6.0
>> due to adding new functionality etc.
>>
>> Thoughts?
>>
>> Robbie
>>
>> On 26 April 2018 at 22:46, Clebert Suconic  wrote:
>>> Little snafu today... I'm dealing with a failure in
>>> org.apache.activemq.artemis.tests.integration.openwire.amq.RedeliveryPolicyTest.testRedeliveryPolicyPerDestination
>>>
>>> will send the vote soon.
>>>
>>> On Wed, Apr 25, 2018 at 9:24 PM, Clebert Suconic
>>>  wrote:
 I will cut it tomorrow.  I won’t merge anything until it’s out.

 @Commiters please don’t break Anything today :)

 @everyvody if there is anything you want Merged or committed tomorrow let 
 me
 know.

 On Wed, Apr 25, 2018 at 4:41 PM pwjenkins
  wrote:
>
> Are you on track to release by the end of April?
>
>
>
> --
> Sent from:
> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

 --
 Clebert Suconic
>>>
>>>
>>>
>>> --
>>> Clebert Suconic
>
>
>
> --
> Clebert Suconic



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #2066: [ARTEMIS-1845]Timestamp header field sh...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2066


---

Re: [HEADS-UP] 2.5.1 in one week

[Clebert Suconic]

>From the entire set.. we only have fixes.. and 4 enhancements...
(previously existent features).

I would prefer saving 2.6.0 for a more substantial release.. but if
you guys still prefer calling 2.6.0 I'm fine with that.

On Thu, May 3, 2018 at 11:02 AM, Robbie Gemmell
 wrote:
> I see there are some updates retargetting JIRA version at 2.5.1 from
> 2.6.0. I think the changes on master are now more suited to the
> release being versioned as 2.6.0. There are plenty of changes in the
> time since 2.5.0 that would have suited 2.5.x releases, but there
> seems to be enough others in there now that might better fit a 2.6.0
> due to adding new functionality etc.
>
> Thoughts?
>
> Robbie
>
> On 26 April 2018 at 22:46, Clebert Suconic  wrote:
>> Little snafu today... I'm dealing with a failure in
>> org.apache.activemq.artemis.tests.integration.openwire.amq.RedeliveryPolicyTest.testRedeliveryPolicyPerDestination
>>
>> will send the vote soon.
>>
>> On Wed, Apr 25, 2018 at 9:24 PM, Clebert Suconic
>>  wrote:
>>> I will cut it tomorrow.  I won’t merge anything until it’s out.
>>>
>>> @Commiters please don’t break Anything today :)
>>>
>>> @everyvody if there is anything you want Merged or committed tomorrow let me
>>> know.
>>>
>>> On Wed, Apr 25, 2018 at 4:41 PM pwjenkins
>>>  wrote:

 Are you on track to release by the end of April?



 --
 Sent from:
 http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
>>>
>>> --
>>> Clebert Suconic
>>
>>
>>
>> --
>> Clebert Suconic



-- 
Clebert Suconic

[GitHub] activemq-artemis pull request #2066: [ARTEMIS-1845]Timestamp header field sh...

[shailendra14k]

GitHub user shailendra14k opened a pull request:

https://github.com/apache/activemq-artemis/pull/2066

[ARTEMIS-1845]Timestamp header field should display in human readable 
format on console.

JIRA :- https://issues.apache.org/jira/browse/ARTEMIS-1845

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shailendra14k/activemq-artemis ARTEMIS-1845

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2066


commit 59e87b646dbd2bbdfde6329c9fc08da1a73b0d3a
Author: Shailendra Kumar Singh 
Date:   2018-05-03T15:39:50Z

[ARTEMIS-1845]Timestamp header field should display in human readable 
format on console.




---

Re: [HEADS-UP] 2.5.1 in one week

[Timothy Bish]

On 05/03/2018 11:02 AM, Robbie Gemmell wrote:

I see there are some updates retargetting JIRA version at 2.5.1 from
2.6.0. I think the changes on master are now more suited to the
release being versioned as 2.6.0. There are plenty of changes in the
time since 2.5.0 that would have suited 2.5.x releases, but there
seems to be enough others in there now that might better fit a 2.6.0
due to adding new functionality etc.

Thoughts?

Robbie


Agreed, given the amount of changes a 2.6.0 release would make more 
sense unless 2.5.1 is only a cherry-picking of critical fixes and not 
the entire set of changes currently on master.



On 26 April 2018 at 22:46, Clebert Suconic  wrote:

Little snafu today... I'm dealing with a failure in
org.apache.activemq.artemis.tests.integration.openwire.amq.RedeliveryPolicyTest.testRedeliveryPolicyPerDestination

will send the vote soon.

On Wed, Apr 25, 2018 at 9:24 PM, Clebert Suconic
 wrote:

I will cut it tomorrow.  I won’t merge anything until it’s out.

@Commiters please don’t break Anything today :)

@everyvody if there is anything you want Merged or committed tomorrow let me
know.

On Wed, Apr 25, 2018 at 4:41 PM pwjenkins
 wrote:

Are you on track to release by the end of April?



--
Sent from:
http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html

--
Clebert Suconic



--
Clebert Suconic



--
Tim Bish
twitter: @tabish121
blog: http://timbish.blogspot.com/

[GitHub] activemq-artemis pull request #2065: ARTEMIS-1846 fix activemq.usemaskedpass...

[jbertram]

GitHub user jbertram opened a pull request:

https://github.com/apache/activemq-artemis/pull/2065

ARTEMIS-1846 fix activemq.usemaskedpassword in URL



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1846

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2065.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2065


commit c0c4ed67a1d9feaabdb70df6205b776923f31fca
Author: Justin Bertram 
Date:   2018-05-03T15:28:05Z

ARTEMIS-1846 fix activemq.usemaskedpassword in URL




---

[GitHub] activemq-artemis pull request #2064: ARTEMIS-1843 Update Qpid JMS 0.32.0 and...

[tabish121]

GitHub user tabish121 opened a pull request:

https://github.com/apache/activemq-artemis/pull/2064

ARTEMIS-1843 Update Qpid JMS 0.32.0 and Proton-j 0.27.1

Use new no copy variants for the delivery send and receive and make
use of the ReadableBuffer type that is now used to convery tranfer
payloads without a copy.  Also set max outgoing frame size to match
the configured maxFrameSize for the AMQP protocol head to avoid the
case where an overly large frame can be written instead of chunking
a large message.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tabish121/activemq-artemis ARTEMIS-1843

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2064


commit 04d5d6a33b6cf589ea96fd325e15b678aadc49c8
Author: Timothy Bish 
Date:   2018-03-27T21:09:48Z

ARTEMIS-1843 Update Qpid JMS 0.32.0  and Proton-j 0.27.1

Use new no copy variants for the delivery send and receive and make
use of the ReadableBuffer type that is now used to convery tranfer
payloads without a copy.  Also set max outgoing frame size to match
the configured maxFrameSize for the AMQP protocol head to avoid the
case where an overly large frame can be written instead of chunking
a large message.




---

Re: [HEADS-UP] 2.5.1 in one week

[Robbie Gemmell]

I see there are some updates retargetting JIRA version at 2.5.1 from
2.6.0. I think the changes on master are now more suited to the
release being versioned as 2.6.0. There are plenty of changes in the
time since 2.5.0 that would have suited 2.5.x releases, but there
seems to be enough others in there now that might better fit a 2.6.0
due to adding new functionality etc.

Thoughts?

Robbie

On 26 April 2018 at 22:46, Clebert Suconic  wrote:
> Little snafu today... I'm dealing with a failure in
> org.apache.activemq.artemis.tests.integration.openwire.amq.RedeliveryPolicyTest.testRedeliveryPolicyPerDestination
>
> will send the vote soon.
>
> On Wed, Apr 25, 2018 at 9:24 PM, Clebert Suconic
>  wrote:
>> I will cut it tomorrow.  I won’t merge anything until it’s out.
>>
>> @Commiters please don’t break Anything today :)
>>
>> @everyvody if there is anything you want Merged or committed tomorrow let me
>> know.
>>
>> On Wed, Apr 25, 2018 at 4:41 PM pwjenkins
>>  wrote:
>>>
>>> Are you on track to release by the end of April?
>>>
>>>
>>>
>>> --
>>> Sent from:
>>> http://activemq.2283324.n4.nabble.com/ActiveMQ-Dev-f2368404.html
>>
>> --
>> Clebert Suconic
>
>
>
> --
> Clebert Suconic

[GitHub] activemq-artemis pull request #2063: [ART] Fix opening SSL connection in IBM...

[rstancel]

GitHub user rstancel opened a pull request:

https://github.com/apache/activemq-artemis/pull/2063

[ART] Fix opening SSL connection in IBM JDK in tests



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/rstancel/jboss-activemq-artemis ARTEMIS-1844

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2063.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2063


commit 2390e3020c8aa195e34c8c04fc3da09f778116dc
Author: Radovan Stancel 
Date:   2018-05-03T08:31:21Z

[ARTEMIS-1844] Fix opening SSL connection in IBM JDK in tests




---

[GitHub] activemq-artemis pull request #2061: ARTEMIS-1842 make sure quorum vote loop...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2061


---

[GitHub] activemq-artemis issue #2061: ARTEMIS-1842 make sure quorum vote loops exits

[mtaylor]

Github user mtaylor commented on the issue:

https://github.com/apache/activemq-artemis/pull/2061
  
@franz1981 I can see the issue here, merging.


---