[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt
Github user ingo1121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1983 Hi! Sorry for the mess with the git tree! I have some question, though: 1. What is your normal build procedure? On my fork, Iâve made a Jenkins job, that just does a âmvn installâ ob the root directory; no profiles or anything. Is that reasonable? 2. I tried to make a âfull exampleâ integration test; by running âmvn -Pexamples verifyâ on the examples directory. Unfortuatly it quickly runs out of steam (both on Windows and RHEL). Is this something that should be fixed? Should I register a JIRA? I notice that a lot of Java processes are left behind⦠Regards Ingemar FrÃ¥n: clebertsuconic <notificati...@github.com> Skickat: den 3 april 2018 00:52 Till: apache/activemq-artemis <activemq-arte...@noreply.github.com> Kopia: ingo1121 <inge...@lupusani.se>; Mention <ment...@noreply.github.com> Ãmne: Re: [apache/activemq-artemis] ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt (#1983) I fixed it.. but your PR was way too messed up. if I had merged your merges.. we would have created a mess on master. please no merge commits on PRs. â You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://github.com/apache/activemq-artemis/pull/1983#issuecomment-378071239> , or mute the thread <https://github.com/notifications/unsubscribe-auth/AVmUYj66_W5-JmAwnvwSRDYeaoh0m8TDks5tkqt4gaJpZM4TBFTa> . <https://github.com/notifications/beacon/AVmUYowcdPo2x9tuPC1ZkI5SiknEElKeks5tkqt4gaJpZM4TBFTa.gif> ---
[GitHub] activemq-artemis issue #1983: ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt
Github user ingo1121 commented on the issue: https://github.com/apache/activemq-artemis/pull/1983 Been absent on vacation. Back now. Sorry if i messed up the revision-tree! Anyway, now the examples in Windows is, is far as I can judge, consistent with examples on RHEL7. ---
[GitHub] activemq-artemis pull request #1983: ARTEMIS-1749 - Fixes the ssl-enabled-cr...
GitHub user ingo1121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1983 ARTEMIS-1749 - Fixes the ssl-enabled-crl-mqtt Also, this is a pretty obvious fix. Doesn't quite fix ssl-enabled-dual-authentication , though,, You can merge this pull request into a Git repository by running: $ git pull https://github.com/ingo1121/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1983.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1983 commit 1e1bd29268714ce48b88c9fc09300fc19d61c32a Author: Ingemar Allqvist <ingemar@...> Date: 2018-03-29T11:46:40Z Added missing variable commit f75af1c09ac1ea5cef6697b249fb2da5cabd4e04 Author: Ingemar Allqvist <ingemar@...> Date: 2018-03-29T11:50:05Z Merge remote-tracking branch 'upstream/master' commit 0f3add95592fab4204f0f9d306240911ca90ea34 Author: Ingemar Allqvist <ingemar@...> Date: 2018-03-29T20:15:55Z Merge remote-tracking branch 'upstream/master' commit ad54423b927bc1726cf7293d3790ac4e9719aaf1 Author: Ingemar Allqvist <ingemar@...> Date: 2018-03-29T20:55:45Z This is obviously wrong - but it doesn't seem to be enough ---
[GitHub] activemq-artemis pull request #1981: ARTEMIS-1749 - missing avariable in Win...
GitHub user ingo1121 opened a pull request: https://github.com/apache/activemq-artemis/pull/1981 ARTEMIS-1749 - missing avariable in Windows Profile An obvious fix is the missing definition of ARTEMIS_ETC_INSTANCE, in the Windows "artemis.profile.cmd" You can merge this pull request into a Git repository by running: $ git pull https://github.com/ingo1121/activemq-artemis master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/activemq-artemis/pull/1981.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1981 commit 1e1bd29268714ce48b88c9fc09300fc19d61c32a Author: Ingemar Allqvist <ingemar@...> Date: 2018-03-29T11:46:40Z Added missing variable commit f75af1c09ac1ea5cef6697b249fb2da5cabd4e04 Author: Ingemar Allqvist <ingemar@...> Date: 2018-03-29T11:50:05Z Merge remote-tracking branch 'upstream/master' ---
