[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160340487
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws
Exception {
server.stop();
}
+
+ @Test
+ public void testHandshakeTimeoutWithValueSet() throws Exception {
+ JMSServerManager jmsServer;
--- End diff --
Aha. Thank you :)
---
[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160195533
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws
Exception {
server.stop();
}
+
+ @Test
+ public void testHandshakeTimeoutWithValueSet() throws Exception {
+ JMSServerManager jmsServer;
--- End diff --
The problematic use-case wasn't necessarily with a configuration file, but
simply using a URL (which can be done programmatically). I changed the test a
bit before I merged it. It's a bit simpler this way.
---
[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user asfgit closed the pull request at: https://github.com/apache/activemq-artemis/pull/1750 ---
[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user stanlyDoge commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r160086429
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws
Exception {
server.stop();
}
+
+ @Test
+ public void testHandshakeTimeoutWithValueSet() throws Exception {
+ JMSServerManager jmsServer;
--- End diff --
Good point with JMSServerManager, thanks.
The issue is about unability to set timeout value using conf file so using
it is intentional. Setting this value programmatically is done
[here](https://github.com/apache/activemq-artemis/pull/1534/files#diff-70ef2b6fc0b6f5e37ea6023acce65b8c).
Or did you think anything else?
---
[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r159896349
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws
Exception {
server.stop();
}
+
+ @Test
+ public void testHandshakeTimeoutWithValueSet() throws Exception {
+ JMSServerManager jmsServer;
--- End diff --
Or don't even use a configuration file and just programmatically configure
the acceptor.
---
[GitHub] activemq-artemis pull request #1750: ARTEMIS-1581 fix handshake-timeout prop...
Github user jbertram commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/1750#discussion_r159895861
--- Diff:
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/jms/server/config/JMSConfigurationTest.java
---
@@ -97,4 +111,56 @@ public void testSetupJMSConfiguration() throws
Exception {
server.stop();
}
+
+ @Test
+ public void testHandshakeTimeoutWithValueSet() throws Exception {
+ JMSServerManager jmsServer;
--- End diff --
The JMSServerManager is deprecated so it's probably best not to use it in
new tests. Check out the "embedded-simple" example for how to programmatically
instantiate a broker with a configuration file.
---
