[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[stanlyDoge]

Github user stanlyDoge closed the pull request at:

https://github.com/apache/activemq-artemis/pull/1775


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[mtaylor]

Github user mtaylor commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1775#discussion_r162352945
  
--- Diff: 
artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
@@ -2790,6 +2790,14 @@

 
 
+
--- End diff --

This is so that any override can be switched to OFF. 


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[stanlyDoge]

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1775#discussion_r162343251
  
--- Diff: 
artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
@@ -2790,6 +2790,14 @@

 
 
+
--- End diff --

Please, would you be so patient and explain me, how to do this? I have 
implemented enum (in latest commit), but I don't think so it is what you 
intended.


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1775#discussion_r162269947
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V2.java
 ---
@@ -25,16 +25,21 @@
 
protected boolean autoCreateQueues;
 
+   protected boolean autoCreateQueuesDurable;
--- End diff --

I personally don't see why this is needed at all, if this is meant to be a 
server side change only.


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1775#discussion_r162269523
  
--- Diff: 
artemis-server/src/main/resources/schema/artemis-configuration.xsd ---
@@ -2790,6 +2790,14 @@

 
 
+
--- End diff --

please make this an enum, currently this is just true or false, and 
overrides the durablitly no matter what in code. (default behaviour should be 
existing behaviour)


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1775#discussion_r162269219
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/server/QueueQueryResult.java
 ---
@@ -55,13 +57,19 @@ public QueueQueryResult(final SimpleString name,
final int consumerCount,
final long messageCount,
final boolean autoCreateQueues,
+   final boolean autoCreateQueuesDurable,
final boolean exists,
final boolean autoCreated,
final boolean purgeOnNoConsumers,
final RoutingType routingType,
final int maxConsumers) {
+
   this.durable = durable;
 
+  if (autoCreateQueues) {
+ this.durable = autoCreateQueuesDurable;
--- End diff --

As noted this should be an enum, and only override, if enum is not null, 
currently his just overrides the value with no option to not override.


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[michaelandrepearce]

Github user michaelandrepearce commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1775#discussion_r162268544
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/client/ClientSession.java
 ---
@@ -66,6 +66,11 @@
*/
   boolean isAutoCreateQueues();
 
+  /**
+   * Returns true if auto-create-queues-durable for this 
address is set to true, false else.
+   */
+  boolean isAutoCreateQueuesDurable();
--- End diff --

Can we make this enum please as per comments.


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[clebertsuconic]

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1775#discussion_r162131538
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/SessionBindingQueryResponseMessage_V2.java
 ---
@@ -25,16 +25,21 @@
 
protected boolean autoCreateQueues;
 
+   protected boolean autoCreateQueuesDurable;
--- End diff --

Why you are adding this if this is not being written anywhere?

Also... this change is wrong.. you would need a _V5 with the new field 
being written...

But honestly... there has been so any versions on 
SessionBindingQueryResponse... can you add a V5 with a hashMap for new fields? 
in the future we would just add more metadata instead of changing the packet.


---

[GitHub] activemq-artemis pull request #1775: ARTEMIS-1587 Add setting to control the...

[stanlyDoge]

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/1775

ARTEMIS-1587 Add setting to control the queue durable property for au…

…to-created addresses

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis ARTEMIS-1587

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/1775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1775


commit 5873e5b8d7d506c50f978b846f4f11520431ae99
Author: Stanislav Knot 
Date:   2018-01-09T10:47:10Z

ARTEMIS-1587 Add setting to control the queue durable property for 
auto-created addresses




---