DO NOT REPLY [Bug 32792] New: - Invalid boolean test in Calling Target(s) msg of Ant task
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32792. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32792 Summary: Invalid boolean test in Calling Target(s) msg of Ant task Product: Ant Version: 1.7Alpha (nightly) Platform: PC OS/Version: Windows 2000 Status: NEW Severity: normal Priority: P2 Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] The Ant task has a boolean test to display [default] when no explicit targets are provided. Right now, the message's boolean test is backwards so [default] displays when you specify a target. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32792] - Invalid boolean test in Calling Target(s) msg of Ant task
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32792. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32792 --- Additional Comments From [EMAIL PROTECTED] 2004-12-22 03:56 --- Created an attachment (id=13816) -- (http://issues.apache.org/bugzilla/attachment.cgi?id=13816action=view) Corrects boolean check so that the log message correctly appears. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
AW: [GUMP@brutus]: Project test-ant (in module ant) failed
Testcase: testNoFileJUnitNoFrames(org.apache.tools.ant.taskdefs.optional.junit.JUnitRe portTest): Caused an ERROR javax.xml.transform.TransformerFactoryConfigurationError: Provider for javax.xml.transform.TransformerFactory cannot be found /home/gump/workspaces2/public/workspace/ant/src/etc/testcases/taskdefs/optio nal/junitreport.xml:14: javax.xml.transform.TransformerFactoryConfigurationError: Provider for javax.xml.transform.TransformerFactory cannot be found at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:105) at org.apache.tools.ant.Task.perform(Task.java:366) at org.apache.tools.ant.Target.execute(Target.java:341) at org.apache.tools.ant.Target.performTasks(Target.java:369) at org.apache.tools.ant.Project.executeSortedTargets(Project.java:1243) -Ursprüngliche Nachricht- Von: Gump Integration Build [mailto:[EMAIL PROTECTED] Gesendet am: Mittwoch, 22. Dezember 2004 04:36 An: [EMAIL PROTECTED] Betreff: [EMAIL PROTECTED]: Project test-ant (in module ant) failed
[GUMP@brutus]: Project test-ant (in module ant) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at [EMAIL PROTECTED] Project test-ant has an issue affecting its community integration. This issue affects 1 projects, and has been outstanding for 2 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - test-ant : Java based build tool Full details are available at: http://brutus.apache.org/gump/public/ant/test-ant/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -INFO- Optional dependency rhino prerequisite failed with reason build failed -INFO- Optional dependency bsh prerequisite failed with reason build failed -INFO- Optional dependency jakarta-tomcat-4.0 prerequisite failed with reason build failed -INFO- Optional dependency xalan failed with reason build failed -INFO- Failed with reason build failed The following work was performed: http://brutus.apache.org/gump/public/ant/test-ant/gump_work/build_ant_test-ant.html Work Name: build_ant_test-ant (Type: Build) Work ended in a state of : Failed Elapsed: 6 mins 18 secs Command Line: java -Djava.awt.headless=true -Xbootclasspath/p:/usr/local/gump/public/workspace/xml-xerces2/java/build/xercesImpl.jar:/usr/local/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar:serializer-gump-22122004.jar:/usr/local/gump/public/workspace/xml-xalan/java/build/xalan-unbundled.jar org.apache.tools.ant.Main -Dgump.merge=/home/gump/workspaces2/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dtest.haltonfailure=false -Dant.home=/usr/local/gump/public/workspace/ant/dist run-tests [Working Directory: /usr/local/gump/public/workspace/ant] CLASSPATH:
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java
peterreilly2004/12/22 01:47:37 Modified:src/main/org/apache/tools/ant/taskdefs Ant.java Log: Invalid boolean test in Calling Target(s) msg of Ant task PR: 32792 Obtained from: Kevin Greiner Revision ChangesPath 1.112 +1 -1 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Ant.java,v retrieving revision 1.111 retrieving revision 1.112 diff -u -r1.111 -r1.112 --- Ant.java 14 Dec 2004 23:51:27 - 1.111 +++ Ant.java 22 Dec 2004 09:47:37 - 1.112 @@ -309,7 +309,7 @@ antFile = file.getAbsolutePath(); log(calling target(s) -+ ((locals.size() == 0) ? locals.toString() : [default]) ++ ((locals.size() 0) ? locals.toString() : [default]) + in build file + antFile, Project.MSG_VERBOSE); newProject.setUserProperty(ant.file , antFile); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Ant.java
peterreilly2004/12/22 01:47:56 Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH Ant.java Log: sync Revision ChangesPath No revision No revision 1.92.2.11 +1 -1 ant/src/main/org/apache/tools/ant/taskdefs/Ant.java Index: Ant.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/Ant.java,v retrieving revision 1.92.2.10 retrieving revision 1.92.2.11 diff -u -r1.92.2.10 -r1.92.2.11 --- Ant.java 14 Dec 2004 23:48:01 - 1.92.2.10 +++ Ant.java 22 Dec 2004 09:47:56 - 1.92.2.11 @@ -309,7 +309,7 @@ antFile = file.getAbsolutePath(); log(calling target(s) -+ ((locals.size() == 0) ? locals.toString() : [default]) ++ ((locals.size() 0) ? locals.toString() : [default]) + in build file + antFile, Project.MSG_VERBOSE); newProject.setUserProperty(ant.file , antFile); - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32792] - Invalid boolean test in Calling Target(s) msg of Ant task
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32792. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32792 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED Target Milestone|--- |1.6.3 --- Additional Comments From [EMAIL PROTECTED] 2004-12-22 10:48 --- Thanks for the report and patch, this is now fixed in cvs. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[Patch] Change to one of the MSVSS methods
A small change to reduce the complexity of the code (at least according
to PMD).
- only one return
- explicitly uses MSVSSConstants
I was actually looking for a bug (#20128) as I thought it'd be a trivial
fix, but I couldn't find it and got distracted by this.
Kev
Index: MSVSS.java
===
RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSS.java,v
retrieving revision 1.42
diff -u -r1.42 MSVSS.java
--- MSVSS.java 17 Dec 2004 10:19:20 - 1.42
+++ MSVSS.java 22 Dec 2004 11:08:50 -
@@ -452,43 +452,36 @@
protected String getUser() {
return user != null ? FLAG_USER + user : ;
}
-
+
/**
* Gets the version string. This can be to-from -VLbuild2~Lbuild1, from
* ~Lbuild1 or to -VLbuild2.
* @return An empty string if neither tolabel or fromlabel are set.
*/
protected String getVersionLabel() {
-if (fromLabel == null toLabel == null) {
-return ;
-}
-if (fromLabel != null toLabel != null) {
-if (fromLabel.length() 31) {
+ StringBuffer sb = new StringBuffer();
+ if (toLabel != null) {
+ if (toLabel.length() 31) {
+ toLabel = toLabel.substring(0, 30);
+ log(ToLabel is longer than 31 characters, truncated to:
++ toLabel, Project.MSG_WARN);
+ }
+ sb.append(MSVSSConstants.FLAG_VERSION_LABEL);
+ sb.append(toLabel);
+ }
+ if (fromLabel != null) {
+ if (fromLabel.length() 31) {
fromLabel = fromLabel.substring(0, 30);
log(FromLabel is longer than 31 characters, truncated to:
-+ fromLabel, Project.MSG_WARN);
++ fromLabel, Project.MSG_WARN);
}
-if (toLabel.length() 31) {
-toLabel = toLabel.substring(0, 30);
-log(ToLabel is longer than 31 characters, truncated to:
-+ toLabel, Project.MSG_WARN);
-}
-return FLAG_VERSION_LABEL + toLabel + VALUE_FROMLABEL + fromLabel;
-} else if (fromLabel != null) {
-if (fromLabel.length() 31) {
-fromLabel = fromLabel.substring(0, 30);
-log(FromLabel is longer than 31 characters, truncated to:
-+ fromLabel, Project.MSG_WARN);
-}
-return FLAG_VERSION + VALUE_FROMLABEL + fromLabel;
-} else {
-if (toLabel.length() 31) {
-toLabel = toLabel.substring(0, 30);
-log(ToLabel is longer than 31 characters, truncated to:
-+ toLabel, Project.MSG_WARN);
-}
-return FLAG_VERSION_LABEL + toLabel;
-}
+ if (toLabel == null) {
+ sb.append(MSVSSConstants.FLAG_VERSION);
+ }
+ sb.append(MSVSSConstants.VALUE_FROMLABEL);
+ sb.append(fromLabel);
+ }
+ return sb.toString();
}
/**
Index: MSVSSTest.java
===
RCS file: MSVSSTest.java
diff -N MSVSSTest.java
--- /dev/null 1 Jan 1970 00:00:00 -
+++ MSVSSTest.java 1 Jan 1970 00:00:00 -
@@ -0,0 +1,142 @@
+/*
+ * Created on Dec 22, 2004
+ *
+ */
+package org.apache.tools.ant.taskdefs.optional.vss;
+
+import org.apache.tools.ant.Project;
+
+import junit.framework.Test;
+import junit.framework.TestCase;
+import junit.framework.TestSuite;
+
+/**
+ * @author kj
+ *
+ */
+public class MSVSSTest extends TestCase {
+
+ private String date = 2002;
+ private String version = 1;
+
+ private String toLabel;
+ private String fromLabel;
+ /*
+ * @see TestCase#setUp()
+ */
+ protected void setUp() throws Exception {
+ super.setUp();
+ }
+
+ /*
+ * @see TestCase#tearDown()
+ */
+ protected void tearDown() throws Exception {
+ super.tearDown();
+ }
+
+ /**
+ * Gets the version string. This can be to-from -VLbuild2~Lbuild1, from
+ * ~Lbuild1 or to -VLbuild2.
+ * @return An empty string if neither tolabel or fromlabel are set.
+ */
+public String getVersionLabelTwo() {
+ StringBuffer sb = new StringBuffer();
+ if (toLabel != null) {
+ if (toLabel.length() 31) {
+ toLabel = toLabel.substring(0, 30);
+ }
+ sb.append(MSVSSConstants.FLAG_VERSION_LABEL);
+ sb.append(toLabel);
+ }
+ if (fromLabel != null) {
+ if (fromLabel.length() 31) {
+fromLabel = fromLabel.substring(0, 30);
+}
+ if (toLabel == null) {
+ sb.append(MSVSSConstants.FLAG_VERSION);
+ }
+ sb.append(MSVSSConstants.VALUE_FROMLABEL);
+ sb.append(fromLabel);
+ }
+ return sb.toString();
+}
+
+//old code
+protected String getVersionLabel() {
+if (fromLabel == null toLabel == null) {
+return ;
+}
+if (fromLabel != null toLabel != null) {
+if (fromLabel.length() 31) {
+
[Patch] Added a basic MSVSSStatus task
- not tested, no VSS to test against
- incomplete, only supports -U and -R switches
- change to MSVSSConstants
Kev
Index: MSVSSConstants.java
===
RCS file: /home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/vss/MSVSSConstants.java,v
retrieving revision 1.7
diff -u -r1.7 MSVSSConstants.java
--- MSVSSConstants.java 9 Mar 2004 16:48:40 - 1.7
+++ MSVSSConstants.java 22 Dec 2004 11:46:36 -
@@ -42,6 +42,8 @@
String COMMAND_HISTORY = History;
/** The 'Create' command */
String COMMAND_CREATE = Create;
+/** The 'Status' command */
+String COMMAND_STATUS = Status;
/** The brief style flag */
String STYLE_BRIEF = brief;
Index: MSVSSSTATUS.java
===
RCS file: MSVSSSTATUS.java
diff -N MSVSSSTATUS.java
--- /dev/null 1 Jan 1970 00:00:00 -
+++ MSVSSSTATUS.java 1 Jan 1970 00:00:00 -
@@ -0,0 +1,72 @@
+/*
+ * Copyright 2000-2004 The Apache Software Foundation
+ *
+ * Licensed under the Apache License, Version 2.0 (the License);
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package org.apache.tools.ant.taskdefs.optional.vss;
+
+import org.apache.tools.ant.BuildException;
+import org.apache.tools.ant.types.Commandline;
+
+/**
+ * Perform Status commands from Microsoft Visual SourceSafe.
+ *
+ * @ant.task name=vssstatus category=scm
+ */
+public class MSVSSSTATUS extends MSVSS {
+
+ /**
+ * Builds a command line to execute ss.
+ * @return The constructed commandline.
+ */
+ Commandline buildCmdLine() {
+ Commandline commandLine = new Commandline();
+
+ // build the command line from what we got the format is
+// ss Status [VSS items] [-H] [-I-] [-N] [-O] [-P[project]] [-R] [-U[username]] [-Y] [-?]
+// as specified in the SS.EXE help
+commandLine.setExecutable(getSSCommand());
+commandLine.createArgument().setValue(COMMAND_STATUS);
+
+if (getVsspath() == null) {
+throw new BuildException(vsspath attribute must be set!, getLocation());
+}
+commandLine.createArgument().setValue(getVsspath());
+//XXX still loads of options to add including [VSS items]
+//this is just a first pass - I can't test here - no VSS
+//-U
+commandLine.createArgument().setValue(getUser());
+//-R
+commandLine.createArgument().setValue(getRecursive());
+return commandLine;
+ }
+
+ /**
+ * Set the option to recurse through all the project files
+ * @param recursive to recurse through project
+ */
+public void setRecursiveStatus(final boolean recursive) {
+ super.setInternalRecursive(recursive);
+}
+
+/**
+ * Set the option to check file status by user
+ * @param User The user to check.
+ */
+public void setUser(final String user) {
+ super.setInternalUser(user);
+}
+
+
+}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32798] New: - duplicate case label, but normal compiles do.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32798.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=32798
Summary: duplicate case label, but normal compiles do.
Product: Ant
Version: 1.6.2
Platform: Sun
OS/Version: Solaris
Status: NEW
Severity: normal
Priority: P1
Component: Other
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
switch(letra) {
case 'â':
case 'ä':
case 'à':
case 'å':
case 'á':
case 'ã':
letra = 'a';
break;
}
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend DependTest.java
conor 2004/12/22 06:08:23
Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/depend
DependTest.java
Log:
JDM 1.5 compiler is much smarter than previous versions in the handling of
class references which should improve the performance of depend
The test has been changed to work with either, allowing eitehr one or two
files
PR: 32557
Revision ChangesPath
1.16 +2 -2
ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java
Index: DependTest.java
===
RCS file:
/home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -w -u -r1.15 -r1.16
--- DependTest.java 16 Dec 2004 14:01:39 - 1.15
+++ DependTest.java 22 Dec 2004 14:08:23 - 1.16
@@ -71,8 +71,8 @@
public void testClosure() {
executeTarget(testclosure);
Hashtable files = getResultFiles();
-assertEquals(Depend did not leave correct number of files, 2,
-files.size());
+assertTrue(Depend did not leave correct number of files,
+files.size() = 2);
assertTrue(Result did not contain D.class,
files.containsKey(D.class));
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32557] - DependTest.testClosure fails under JDK 1.5
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32557.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=32557
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution||FIXED
Target Milestone|--- |1.7
--- Additional Comments From [EMAIL PROTECTED] 2004-12-22 15:11 ---
JDK 1.5 is much smarter when it comes to handling the code in one of the test
files.
public class E {
E() {
System.out.println(A.class);
}
}
In JDK 1.5, thie uses a class reference in the produced class file to A, rather
than a string reference as used in previous versions. The code for the above has
gone from:
{
static java.lang.Class class$A;
Synthetic: true
E();
Code:
Stack=3, Locals=1, Args_size=1
0: aload_0
1: invokespecial #6; //Method java/lang/Object.init:()V
4: getstatic #7; //Field java/lang/System.out:Ljava/io/PrintStream;
7: getstatic #8; //Field class$A:Ljava/lang/Class;
10: ifnonnull 25
13: ldc #9; //String A
15: invokestatic#10; //Method
class$:(Ljava/lang/String;)Ljava/lang/Class;
18: dup
19: putstatic #8; //Field class$A:Ljava/lang/Class;
22: goto28
25: getstatic #8; //Field class$A:Ljava/lang/Class;
28: invokevirtual #11; //Method
java/io/PrintStream.println:(Ljava/lang/Object;)V
31: return
static java.lang.Class class$(java.lang.String);
Code:
Stack=3, Locals=2, Args_size=1
0: aload_0
1: invokestatic#1; //Method
java/lang/Class.forName:(Ljava/lang/String;)Ljava/lang/Class;
4: areturn
5: astore_1
6: new #3; //class java/lang/NoClassDefFoundError
9: dup
10: aload_1
11: invokevirtual #4; //Method
java/lang/ClassNotFoundException.getMessage:()Ljava/lang/String;
14: invokespecial #5; //Method
java/lang/NoClassDefFoundError.init:(Ljava/lang/String;)V
17: athrow
Exception table:
from to target type
0 4 5 Class java/lang/ClassNotFoundException
Synthetic: true
}
to
E();
Code:
Stack=2, Locals=1, Args_size=1
0: aload_0
1: invokespecial #1; //Method java/lang/Object.init:()V
4: getstatic #2; //Field java/lang/System.out:Ljava/io/PrintStream;
7: ldc_w #3; //class A
10: invokevirtual #4; //Method
java/io/PrintStream.println:(Ljava/lang/Object;)V
13: return
}
Quite an improvment.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32798] - duplicate case label, but normal compiles do.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32798. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32798 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2004-12-22 16:58 --- Not duplicate and not an ant issue -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32802] New: - invalid empty zip file created with manifest
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32802. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32802 Summary: invalid empty zip file created with manifest Product: Ant Version: 1.6.2 Platform: PC OS/Version: Windows 2000 Status: NEW Severity: major Priority: P2 Component: Core tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] with this project file project name=blub default=build basedir=. target name=build jar jarfile=api.jar manifest=MANIFEST.MF duplicate=preserve fileset dir=com include name=**/*.class/ /fileset /jar /target /project I am getting a totally empty jar file which cannot be opened with java.util.Zip.ZipFile if the directory com is empty. This is similar to bug 31530. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug, or are watching the assignee. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32557] - DependTest.testClosure fails under JDK 1.5
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32557. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32557 --- Additional Comments From [EMAIL PROTECTED] 2004-12-22 17:14 --- Is it just the test that is fixed, or the task? If the latter, might be a good 1.6.3 candidate. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32804] New: - check version of Ant
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32804.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=32804
Summary: check version of Ant
Product: Ant
Version: 1.6.2
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Core tasks
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
It would be nice to have possibility to check version of Ant in build.xml script
(that is needed when there is uneducated customer which is ignoring requirements
of ant/java versions described in document - so we have to put 'fail' in ant
script to stop doing stupid thing by the customer)
Currently there are used too tricks (what I found):
- based on checking if pointed class exists (like MacroDef from 1.6);
- using contains + ${ant.version}
But both have cause (or can) some problems, for example class can be moved in
future versions.
Below is small proposal of checkVersion task:
checkVersion name=ant.version.number value=- + = += -=(means less greater
equal, greater equal) version here, i.e. +=1.6.1 property=property name to set
when condition not met/
Idea is that it can be used for any version checking which follows standard
pattern: number.number.number. Additional needed extension is
'ant.version.number' which returns just the number.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
DO NOT REPLY [Bug 32557] - DependTest.testClosure fails under JDK 1.5
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=32557. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=32557 --- Additional Comments From [EMAIL PROTECTED] 2004-12-22 23:09 --- Only the test code has changed. The only implication of this bug is that under JDK 1.5+, the depend code, as it currently stands, will perform a little bit better than under previous JDKs. A source file which contains a reference to a class of the form A.class will generate a classfile with a class reference to A. Sice depend uses class references to build its dependency model, under JDK 1.5, that model will be more accurate. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend DependTest.java
Hi,
this test case would now also pass if no class has been found at all, is
that intentional?
Kind Regards, Martijn
[EMAIL PROTECTED] wrote:
conor 2004/12/22 06:08:23
Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/depend
DependTest.java
Log:
JDM 1.5 compiler is much smarter than previous versions in the handling of
class references which should improve the performance of depend
The test has been changed to work with either, allowing eitehr one or two files
PR: 32557
Revision ChangesPath
1.16 +2 -2 ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java
Index: DependTest.java
===
RCS file: /home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -w -u -r1.15 -r1.16
--- DependTest.java 16 Dec 2004 14:01:39 - 1.15
+++ DependTest.java 22 Dec 2004 14:08:23 - 1.16
@@ -71,8 +71,8 @@
public void testClosure() {
executeTarget(testclosure);
Hashtable files = getResultFiles();
-assertEquals(Depend did not leave correct number of files, 2,
-files.size());
+assertTrue(Depend did not leave correct number of files,
+files.size() = 2);
assertTrue(Result did not contain D.class,
files.containsKey(D.class));
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend DependTest.java
yes, there is an additional test to ensure the class D remains.
Conor
Martijn Kruithof wrote:
Hi,
this test case would now also pass if no class has been found at all, is
that intentional?
Kind Regards, Martijn
[EMAIL PROTECTED] wrote:
conor 2004/12/22 06:08:23
Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/depend
DependTest.java
Log:
JDM 1.5 compiler is much smarter than previous versions in the
handling of
class references which should improve the performance of depend
The test has been changed to work with either, allowing eitehr one or
two files
PR:32557
Revision ChangesPath
1.16 +2 -2
ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java
Index: DependTest.java
===
RCS file:
/home/cvs/ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend/DependTest.java,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -w -u -r1.15 -r1.16
--- DependTest.java16 Dec 2004 14:01:39 -1.15
+++ DependTest.java22 Dec 2004 14:08:23 -1.16
@@ -71,8 +71,8 @@
public void testClosure() {
executeTarget(testclosure);
Hashtable files = getResultFiles();
-assertEquals(Depend did not leave correct number of files, 2,
-files.size());
+assertTrue(Depend did not leave correct number of files,
+files.size() = 2);
assertTrue(Result did not contain D.class,
files.containsKey(D.class));
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
