Re: support for symlinks
On 2010-10-27, Max Birkoff wrote: I would like to add support for symlinks to: org.apache.tools.tar.TarEntry and friends. I'd recommend you'd put that effort into the tar classes in Apache Commons Compress http://commons.apache.org/compress/ instead. The tar and zip classes of Ant are really only a subset of the compress classes and I'd expect Ant's copy of the classes will only get the parts merged that are useful to the existing Ant tasks. Personally I would prefer enhancing the compress Antlib http://ant.apache.org/antlibs/compress/index.html rather than the core tasks as well - the core tasks carry to much baggage of backwards compatibility ti keep IMHO. I have examined the archives at: http://news.gmane.org/gmane.comp.jakarta.ant.devel/ and cannot see the matter discussed there. There is at least one bugzilla issue raised for it. Before sending patches, I would like to determine if there is a reason that this has not been supported in the TarEntry class; Those who have been working on the code didn't need symlink support and those who needed it never provided patches 8-) it appears that the proper constants are present in TarConstants and I can get at the linkflag through the writeEntryHeader method. It is true that it doesn't seem to be too difficult. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ReviewBoard for Ant?
On 2010-10-26, Jesse Glick wrote: On 10/26/2010 11:12 AM, Stefan Bodewig wrote: I've never used it, but nothing stops us from giving it a try. OK, I filed: https://issues.apache.org/jira/browse/INFRA-3104 Seems to be there now, although I have no idea what to do with it now. Wait for a case where a review could be useful, I guess. So far I haven't been able to register with the site, though. Interesting. I was able to register OK. My fault. I use the RequestPolicy Firefox addin and didn't realize the register page contained a captcha (RP suppressed the content from recaptcha and google). Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
class BuildTimeoutException extends BuildException
I'm thinking we need a specific class BuildTimeoutException that extends BuildException -Java.java looks for the specific error message Timeout: killed the sub-process in Exec.java to recognise a timeout, and doesn't even share the constant string across classes. -my own code looks for Parallel execution timed out in a test run and inserts a more meaningful message. I propose 1. a new BuildTimeoutException 2. Exec, Parallel and other things that can timeout raise it. 3. Calling code in the Ant codebase can look for this. 4. we leave the error strings alone for fear of #4 irritates me, I'd like some details about which subprocess got killed, but if we are searching for the string in Ant's own codebase, then we can be confident that others will be doing the same trick as well. I'll do the coding... -Steve - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: class BuildTimeoutException extends BuildException
On 27/10/10 11:01, Steve Loughran wrote: I'm thinking we need a specific class BuildTimeoutException that extends BuildException I'll do the coding... Of course, there is a well documented exception of just that name in org.apache.tools.ant.taskdefs.optional.testing Which implies that I should really 1. move that into the core codebase 2. retain a subclass in that location, though that really confuses code: class BuildTimeoutException extends org.apache.tools.ant.BuildTimeoutException Better to have some new Exception name like BuildOperationTimeoutException to eliminate confusion - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: class BuildTimeoutException extends BuildException
On 2010-10-27, Steve Loughran wrote: On 27/10/10 11:01, Steve Loughran wrote: I'm thinking we need a specific class BuildTimeoutException that extends BuildException I'll do the coding... Of course, there is a well documented exception of just that name in org.apache.tools.ant.taskdefs.optional.testing And I thought that was dead 8-) Better to have some new Exception name +1 like BuildOperationTimeoutException to eliminate confusion TimeoutException? Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: class BuildTimeoutException extends BuildException
On 10/27/2010 06:01 AM, Steve Loughran wrote: 4. we leave the error strings alone for fear of [...fear itself?] #4 irritates me, I'd like some details about which subprocess got killed, but if we are searching for the string in Ant's own codebase, then we can be confident that others will be doing the same trick as well. Possible hack: leave Throwable.detailMessage ~ getMessage() alone, but add extra fields getters for the info about the subprocess, and override getLocalizedMessage() to include that information. Then the richer info will be shown in a stack trace, but other code checking e.getMessage() will not be broken. The only problem would be foreign code checking e.toString(), since this also uses getLocalizedMessage(), but I will bet people would naturally look at getMessage() instead. - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: Ivy and IvyDE release notes
I almost forgot myself I have suggest this change. As there were no objection, I have put it into place for IvyDE. Nicolas Le 20 août 2010 à 15:49, Nicolas Lalevée a écrit : I would like to make the release of Ivy and IvyDE easier. Today the release notes of IvyDE are in different places: * the raw list of bug fixes and new features is in CHANGES.txt * there is a RELEASE_NOTES.txt which contains has soon as it is released: ** the list of bugs and features, copied from CHANGES.txt, ** the list of contributors, extracted from CHANGES.txt, ** a teaser of the new features, extracted from CHANGES.txt, * there is a release_notes.html in doc in the release branch, which is a manual html adaptation of the RELEASE_NOTES.txt So first I would like to get rid of CHANGES.txt. Each bug fix or new feature, the committer will be responsible to update the RELEASE_NOTES.txt/release-notes.html instead of the CHANGES.txt. We could be also a little bit more verbose about the actual change made, like it is done for Ant's WHATSNEW. We will loose the history of changes, but I don't think this is an issue. WDYT ? Then there is the html versus the txt version. We should only keep one. I like having it online, with links to Jira, so I would prefer having the html version. WDYT ? Last but not least, there is exactly the same duplicates in Ivy release process. Do we want to remove duplicates in Ivy release process too ? I would like to. Nicolas - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ReviewBoard for Ant?
Le 26 oct. 2010 à 16:36, Jesse Glick a écrit : Would this be useful? https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the It seems we often have in-progress patches that need to be tweaked a bit before use. I think it can be useful for complex patch too. (I could have used this on #34748; I was accustomed to just creating a Mercurial branch or patch queue for experimental work, but have found that to be a disaster in Subversion.) I do use mercurial to be able to commit offline. For instance it was useful for the last batch of commit I did on Ivy and IvyDE. I had to patch hgsubversion though [1]. Nicolas [1] https://bitbucket.org/durin42/hgsubversion/issue/203/wait-before-pull-in-push - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: svn commit: r1028013 - in /ant/ivy/core/trunk: ./ doc/ doc/use/ src/java/org/apache/ivy/ant/ test/java/org/apache/ivy/ant/ test/repositories/1/org2/mod2.1/ivys/ test/repositories/1/org2/mod2.1/jar
Le 27 oct. 2010 à 23:47, Maarten Coene a écrit : Nicolas, Very nice :-) Is this related to https://issues.apache.org/jira/browse/IVY-334 ? I didn't knew about this issue, but it is definitively related. What I have implemented is for an inline mode only, but it can definitively be improved to support also an ivy.xml. Nicolas Maarten - Original Message From: Nicolas Lalevée nicolas.lale...@hibnet.org To: dev@ant.apache.org Sent: Wed, October 27, 2010 6:50:27 PM Subject: Re: svn commit: r1028013 - in /ant/ivy/core/trunk: ./ doc/ doc/use/ src/java/org/apache/ivy/ant/ test/java/org/apache/ivy/ant/ test/repositories/1/org2/mod2.1/ivys/ test/repositories/1/org2/mod2.1/jars/ test/repositories/1/org2/mod2.2/ivys/ test/repositori... As you may see, I have updated the ant version used because resources used in the new feature introduced are since Ant 1.7.0. I haven't changed Ivy's requirement on Ant though. For me Ivy is still requiring Ant 1.6, and can even work with earlier versions. Only if the user want to use this new ivy:resources feature, it will require to have an Ant 1.7 minimum. Nicolas Le 27 oct. 2010 à 17:57, hi...@apache.org a écrit : Author: hibou Date: Wed Oct 27 15:57:36 2010 New Revision: 1028013 URL: http://svn.apache.org/viewvc?rev=1028013view=rev Log: New Ivy Ant datatype: a resource collection compute from an Ivy resolve. The basic implementation work, but is not yet a complete clone/merge of ivy:resolve and ivy.xml's dependencies Added: ant/ivy/core/trunk/doc/use/resources.html ant/ivy/core/trunk/src/java/org/apache/ivy/ant/IvyDependency.java ant/ivy/core/trunk/src/java/org/apache/ivy/ant/IvyResources.java ant/ivy/core/trunk/test/java/org/apache/ivy/ant/IvyResourcesTest.java ant/ivy/core/trunk/test/repositories/1/org2/mod2.1/ivys/ivy-0.7.xml ant/ivy/core/trunk/test/repositories/1/org2/mod2.1/jars/mod2.1-0.7.jar ant/ivy/core/trunk/test/repositories/1/org2/mod2.2/ivys/ivy-0.10.xml ant/ivy/core/trunk/test/repositories/1/org2/mod2.2/jars/mod2.2-0.10.jar Modified: ant/ivy/core/trunk/doc/toc.json ant/ivy/core/trunk/ivy.xml ant/ivy/core/trunk/src/java/org/apache/ivy/ant/AntMessageLogger.java ant/ivy/core/trunk/src/java/org/apache/ivy/ant/IvyAntSettings.java ant/ivy/core/trunk/src/java/org/apache/ivy/ant/IvyTask.java ant/ivy/core/trunk/src/java/org/apache/ivy/ant/antlib.xml Modified: ant/ivy/core/trunk/doc/toc.json URL: http://svn.apache.org/viewvc/ant/ivy/core/trunk/doc/toc.json?rev=1028013r1=1028012r2=1028013view=diff - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: class BuildTimeoutException extends BuildException
On 10/27/10 12:33 PM, Steve Loughran wrote: I'm thinking of being ruthless and doing the move on the basis that that funtest task was never documented (my fault) and therefore doesn't exist, we can move it without guilt. Therefore I am now thinking of -move the existing BuildTimeoutException -upgrade Parallel, Exec and Java to use it, retaining the string -upgrade Funtest to catch it from Parallel and add a more useful error message (one that prints the timeout parameters). -steve I Sounds good, Antoine - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
