[GitHub] ant-ivy issue #51: Fix some string comparisons with ==

[jaikiran]

Github user jaikiran commented on the issue:

https://github.com/apache/ant-ivy/pull/51
  
Thanks for the PR. This has now been merged. I had to fix the 
`ModuleDescriptorMemoryCacheTest` which got exposed by (valid) changes in this 
PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant-ivy pull request #51: Fix some string comparisons with ==

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/ant-ivy/pull/51


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Ivy 2.5 and generics

[Gintautas Grigelionis]

Hi, I hope you're doing well and not (yet) on vacation :-) I just opened
PR-52, which should conclude large-scale code changes and prepare the field
for more focused discussion regarding the API.

Gintas

2017-06-20 14:06 GMT+02:00 Gintautas Grigelionis :

> I left out the generification of Filter, because NoFilter is a singleton.
> I'll be leaving out attribute Maps (global or local), because their values
> can be Strings or Matchers (this is where the story with IvyDE started, I
> was not sure what to expect from one such Map).
>
> Anything else that is pretty unambiguous can be generified just to clear
> out the room. Once that is done, the remaining cases must be thoroughly
> discussed. I added binary compatibility checks to stress the point that
> generification does not break binary compatibility as long as erasures stay
> the same.
>
> Gintas
>
> 2017-06-20 13:35 GMT+02:00 Jaikiran Pai :
>
>> Gintas, can you list the exact nature of changes for some specific
>> classes that you think this effort might involve? I know you already sent
>> me some samples, but it would be good if the rest know what kind of changes
>> are involved.
>>
>> Personally, my opinion on this is - if it’s internal implementation
>> details that this change involves (like private fields or methods of
>> certain classes), it’s fine to do that in the upcoming release. But if it’s
>> more than that, then IMO, we should hold on to that for a bit and evaluate
>> it in some subsequent release so that we don’t do too many changes without
>> evaluating the kind of impact it has on the external libraries that use Ivy.
>>
>> Ultimately, I believe this will come down to a case-by-case basis.
>>
>> -Jaikiran
>>
>> On 19-Jun-2017, at 10:12 AM, Gintautas Grigelionis <
>> g.grigelio...@gmail.com> wrote:
>>
>> During a discussion about goals for Ivy 2.5, I mentioned generics [1].
>> I was looking into the matter because I was investigating how IvyDE hooks
>> into Ivy and I didn't quite like what I saw.
>> I'd like to generify Ivy as much as possible for 2.5 (staying binary
>> compatible, of course) so that decisions for the next release could be
>> more
>> informed.
>>
>> Should you agree, I'd finish the work with two more commits (one for core
>> and one for plugins package) -- I pushed two commits already that ended up
>> in PR #45.
>>
>> Now, I'll digress, but I believe it's worth mentioning. Apart from
>> generics, there's one last thing I'd like to have in Ivy 2.5, and that's
>> SVG in Ivy reports. I only heard one opinion (which was positive) about
>> the
>> non-limbless ant in vectorised Ivy logo, and no protests, so I take it as
>> a
>> silent approval :-) BTW I hope asciidoc can inline SVG in HTML, although
>> some repeating icons would better be placed in CSS (as mentioned in
>> comments to PR #39).
>>
>> [1]
>> http://mail-archives.apache.org/mod_mbox/ant-dev/201705.mbox
>> /%3CCALVNWHXiZPVJmKimTB9Qxo9u6%2BNX%2Br7Kpmk3uvZvqtUxLQpekQ%
>> 40mail.gmail.com%3E
>>
>> Gintas
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
>> For additional commands, e-mail: dev-h...@ant.apache.org
>>
>>
>

[GitHub] ant-ivy pull request #52: Generics in core

[twogee]

GitHub user twogee opened a pull request:

https://github.com/apache/ant-ivy/pull/52

Generics in core

This is as far as I can get without significant changes to API.
Any remaining points of contention are annotated by `@SuppressWarnings` 
(and I'm not proud of what `NoFilter` looks like).
If you need proof that arrays of generics are broken, just change `List` 
back to `T[]` in `ModuleRules` and watch the fireworks.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant-ivy generics-in-core

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant-ivy/pull/52.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #52


commit cce62bb298d2af097a6b595a6f3f058ae6c4d3b7
Author: twogee 
Date:   2017-07-06T06:04:24Z

Add generics and Java 7 syntax to core

commit 91668c1ce81f396558be2e04542a9d95dbaed103
Author: twogee 
Date:   2017-07-09T10:01:05Z

Checkstyle




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Bug report for Ant [2017/07/09]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 5003|Opn|Blk|2001-11-21|exec task does not return after executed command f|
| 6606|Opn|Enh|2002-02-21|META-BUG problems with delegating classloaders|
| 7552|Opn|Cri|2002-03-28|Invalid task cache in targets |
| 7712|New|Enh|2002-04-03|Provide patternset support for VSSGET task?   |
| 8294|New|Enh|2002-04-19|: Allow  and  to app|
| 8866|New|Enh|2002-05-07|Signal handling in java task  |
| 8895|New|Enh|2002-05-08|ant and/or antcall should support forking |
| 8972|New|Enh|2002-05-10|allow property expansion in  property v|
| 8981|New|Enh|2002-05-10|Tar task command additional features  |
| 9294|New|Enh|2002-05-21|[PATCH] optional/j2ee/ServerDeploy OC4J Support   |
| 9995|Ass|Enh|2002-06-19|MKS Source Integrity tasks|
|10020|New|Enh|2002-06-19|'s dependency behaviour should be more con|
|10231|New|Enh|2002-06-25|Need access to current file in SQLExec|
|10283|New|Enh|2002-06-27|Add a destfile to the uptodate task   |
|10402|New|Enh|2002-07-02|adding the ability of html like whitespace preserv|
|3|New|Enh|2002-07-24|keytool task  |
|11560|Opn|Enh|2002-08-08|Taskdef does not apply reverseLoader policy on sta|
|12267|New|Enh|2002-09-03|Add ability to unzip into separate folders|
|12292|New|Enh|2002-09-04|[PATCH] enable  tag inside tar|
|12334|New|Enh|2002-09-05|REQUEST: Ant task doesn't allow attachment of a bu|
|12518|New|Enh|2002-09-11|Gunzip & BUnZip2 add filesets, patternsets, and ov|
|12765|New|Enh|2002-09-18|"rmdir" and "deltree" patches for ftp task enhance|
|12964|New|Enh|2002-09-24|ANTLR only takes one input file at a time |
|13047|Inf|Enh|2002-09-26|Support for  and  on O|
|13371|New|Enh|2002-10-07|[PATCH] Contributed new CvsExportDiff task|
|13847|New|Nor|2002-10-22|pvcs task: wrong option (-r) specified for get (sh|
|13934|New|Enh|2002-10-24|Translate task shouldn't load default locale prope|
|13939|New|Enh|2002-10-24|Translate task should have better key matching cap|
|14320|New|Enh|2002-11-06|copy fileset followsymlinks="false" does not copy |
|14393|New|Enh|2002-11-08|Support use of jndi within ant|
|14512|New|Enh|2002-11-13|Allow creating database connection similar to