Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-10 Thread Jaikiran Pai 


On 10/04/18 12:27 AM, Gintautas Grigelionis wrote:

2018-04-08 16:13 GMT+00:00 Stefan Bodewig :


I don't believe woking well tested code rots. Code rot is something that
happends when code doesn't get adapted to changing environments or
requirements. This is not the case here.


I wrote earlier that I was about to review the unit tests.
I was particularly unhappy about the root-property hack for an ancient
deficiency in Surefire.
I checked some of the mail discussions, but couldn't find any relevant 
details about this. Can you explain what the root-property hack is? I 
also don't understand how Surefire is related to our tests, which are 
run using the junit and ant-unit framework. If I missed some previous 
discussion, please pointme to it and I'll read up on that.



I consider my previous commits a sort of a groundwork for refactorisation
of JUnit tests.
Considering the commits that have been made (even just considering only 
the Ant ones), I don't see how those relate to some plan to refactor 
JUnit tests.


-Jaikiran

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2018-04-10 Thread bodewig 
Github user bodewig commented on the pull request:


https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28515176
  
In src/main/org/apache/tools/ant/util/LazyHashtable.java:
In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:
you are correct, sorry for the noise.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2018-04-10 Thread bodewig 
Github user bodewig commented on the pull request:


https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28515126
  
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java:
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 99:
`isJavaIdentifierStart` != `isJavaIdentifierPart` :-)


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2018-04-10 Thread twogee 
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/dccbf1fcec0fc4e0812e8906494b15a1301ac32a#commitcomment-28509355
  
In src/main/org/apache/tools/ant/util/LazyHashtable.java:
In src/main/org/apache/tools/ant/util/LazyHashtable.java on line 32:
It does not, generics are erased from signature.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #:

2018-04-10 Thread twogee 
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/4b14d85f11b9a7728dcd2d9420551fd28bf8f45e#commitcomment-28507789
  
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java:
In src/main/org/apache/tools/ant/util/ScriptRunnerBase.java on line 99:
I believe that it is the same test as the one continued in the loop.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org