Re: [RESULT] move over to gitbox.apache.org

2018-12-16 Thread Stefan Bodewig
On 2018-12-16, Stefan Bodewig wrote:

> the vote has passed and I've opened
> https://issues.apache.org/jira/browse/INFRA-17455

We now should be at gitbox, will check later today.

This means you need to change or add remotes and can decide whether to
use gitbox.apache.org or github when pushing changes.

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[RESULT] move over to gitbox.apache.org

2018-12-16 Thread Stefan Bodewig
Hi all

the vote has passed and I've opened
https://issues.apache.org/jira/browse/INFRA-17455

Thanks

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-12-16 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692461
  
In src/main/org/apache/tools/ant/types/ModuleVersion.java:
In src/main/org/apache/tools/ant/types/ModuleVersion.java on line 51:
no @param for number


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-12-16 Thread bodewig
Github user bodewig commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692386
  
fixed with 876376a8d - many thanks for catching this @twogee 


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-12-16 Thread twogee
Github user twogee commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692367
  
Thanks, perhaps it's time for [multi-release 
jars](https://maven.apache.org/plugins/maven-compiler-plugin/multirelease.html)?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org



[GitHub] ant pull request #:

2018-12-16 Thread bodewig
Github user bodewig commented on the pull request:


https://github.com/apache/ant/commit/343dff90f2a06a14a5e3d8f787de87d4446af3d9#commitcomment-31692317
  
I'll take care of it.


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org