[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...
Github user aprelev closed the pull request at: https://github.com/apache/ant-ivy/pull/73 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...
Github user aprelev commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/73#discussion_r207675516 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String qName, String branch = attributes.getValue("branch"); String revision = attributes.getValue("revision"); Map extraAttributes = new HashMap<>(); --- End diff -- It was, until I reused code for attributes extraction from `ExtendableItemHelper`. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant-ivy pull request #73: IVY-1104 Include attributes qualifiers in the XML ...
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/73#discussion_r207669472 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -193,16 +193,8 @@ public void startElement(String uri, String localName, String qName, String branch = attributes.getValue("branch"); String revision = attributes.getValue("revision"); Map extraAttributes = new HashMap<>(); --- End diff -- Is this Map used? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org