[GitHub] ant pull request #78: A new CharSet type to hold available Charset names

[twogee]

Github user twogee closed the pull request at:

https://github.com/apache/ant/pull/78


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #78: A new CharSet type to hold available Charset names

[twogee]

Github user twogee commented on a diff in the pull request:

https://github.com/apache/ant/pull/78#discussion_r232795363
  
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import org.apache.tools.ant.BuildException;
+import org.junit.Test;
+
+import java.util.Arrays;
+
+public class CharSetTest {
+@Test
+public void testCorrectNames() {
+String[] expected = {"UTF-8", "ISO-8859-1", "037", "us", "IBM500"};
+Arrays.stream(expected).forEach(new CharSet()::setValue);
+}
+
+@Test(expected = BuildException.class)
+public void testNonExistentNames() {
+String[] nonexistent = {"mojibake", "dummy"};
+Arrays.stream(nonexistent).forEach(new CharSet()::setValue);
--- End diff --

I was lazy... 😁 the tests are properly parameterised now


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #78: A new CharSet type to hold available Charset names

[bodewig]

Github user bodewig commented on a diff in the pull request:

https://github.com/apache/ant/pull/78#discussion_r232673446
  
--- Diff: src/tests/junit/org/apache/tools/ant/types/CharSetTest.java ---
@@ -0,0 +1,20 @@
+package org.apache.tools.ant.types;
+
+import org.apache.tools.ant.BuildException;
+import org.junit.Test;
+
+import java.util.Arrays;
+
+public class CharSetTest {
+@Test
+public void testCorrectNames() {
+String[] expected = {"UTF-8", "ISO-8859-1", "037", "us", "IBM500"};
+Arrays.stream(expected).forEach(new CharSet()::setValue);
+}
+
+@Test(expected = BuildException.class)
+public void testNonExistentNames() {
+String[] nonexistent = {"mojibake", "dummy"};
+Arrays.stream(nonexistent).forEach(new CharSet()::setValue);
--- End diff --

is the test for "dummy" ever going to be run?


---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant pull request #78: A new CharSet type to hold available Charset names

[twogee]

GitHub user twogee opened a pull request:

https://github.com/apache/ant/pull/78

A new CharSet type to hold available Charset names

I believe that might be useful when validating "encoding" (or "charset") 
attributes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/twogee/ant charset-type

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ant/pull/78.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #78


commit 033d68c7f6ecf382f84eec5ab0c2bb91eb9bd6fb
Author: twogee 
Date:   2018-11-06T21:27:55Z

A new CharSet type to hold available Charset names




---

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org