[jira] [Commented] (ANY23-167) Microdata itemscope properties incorrectly attached
[ https://issues.apache.org/jira/browse/ANY23-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753904#comment-16753904 ] David Cockbill commented on ANY23-167: -- I was not sure where to ask the question, but I'm awaiting this fix in a proper release. Does anyone know when Version 2.3 is to be release; or failing that is it a case of subscribing and asking on the Dev mailing list. Thanks in advance. > Microdata itemscope properties incorrectly attached > --- > > Key: ANY23-167 > URL: https://issues.apache.org/jira/browse/ANY23-167 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Reporter: Ruben Verborgh >Assignee: Hans Brende >Priority: Major > Labels: microdata > Fix For: 2.3 > > > In some cases, Microdata properties inside an itemscope are attached to the > parent object. > For instance: http://ruben.verborgh.org/tmp/schemaorg-test.html > http://any23.org/any23/?uri=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Note how a separate Person entity is recognized, > but property values themselves are attached to the BlogPosting entity instead > of the Person entity. > Also the properties familyName and givenName are incorrectly identified as > http://schema.org/BlogPosting/familyName and > http://schema.org/BlogPosting/givenName, > while they should be http://schema.org/familyName and > http://schema.org/givenName. > The Structured Data Testing Tool shows the correct interpretation: > http://www.google.com/webmasters/tools/richsnippets?q=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Also note the wrong name "http:/schema.orgPerson" instead of > "http:/schema.org/Person". This seems to happen because the quotes around the > attribute are missing in the HTML source (I can file another issue for that > if needed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ANY23-167) Microdata itemscope properties incorrectly attached
[ https://issues.apache.org/jira/browse/ANY23-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436708#comment-16436708 ] Hudson commented on ANY23-167: -- SUCCESS: Integrated in Jenkins build Any23-trunk #1557 (See [https://builds.apache.org/job/Any23-trunk/1557/]) ANY23-167 fixed: parent itemscopes inherited all properties from child (hans: rev 8f0db89ea1c4ca1c9c59d740b5ee4fe687957e5a) * (edit) core/src/main/java/org/apache/any23/extractor/microdata/MicrodataExtractor.java * (edit) test-resources/src/test/resources/microdata/microdata-nested-expected.nquads * (edit) test-resources/src/test/resources/microdata/microdata-nested-expected.properties * (edit) test-resources/src/test/resources/microdata/microdata-json-serialization.json * (edit) core/src/main/java/org/apache/any23/extractor/microdata/MicrodataParser.java * (edit) test-resources/src/test/resources/microdata/microdata-richsnippet-expected.nquads * (edit) test-resources/src/test/resources/microdata/5.2.1-non-normative-example-1-expected.nquads > Microdata itemscope properties incorrectly attached > --- > > Key: ANY23-167 > URL: https://issues.apache.org/jira/browse/ANY23-167 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Reporter: Ruben Verborgh >Assignee: Hans Brende >Priority: Major > Labels: microdata > Fix For: 2.3 > > > In some cases, Microdata properties inside an itemscope are attached to the > parent object. > For instance: http://ruben.verborgh.org/tmp/schemaorg-test.html > http://any23.org/any23/?uri=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Note how a separate Person entity is recognized, > but property values themselves are attached to the BlogPosting entity instead > of the Person entity. > Also the properties familyName and givenName are incorrectly identified as > http://schema.org/BlogPosting/familyName and > http://schema.org/BlogPosting/givenName, > while they should be http://schema.org/familyName and > http://schema.org/givenName. > The Structured Data Testing Tool shows the correct interpretation: > http://www.google.com/webmasters/tools/richsnippets?q=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Also note the wrong name "http:/schema.orgPerson" instead of > "http:/schema.org/Person". This seems to happen because the quotes around the > attribute are missing in the HTML source (I can file another issue for that > if needed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ANY23-167) Microdata itemscope properties incorrectly attached
[ https://issues.apache.org/jira/browse/ANY23-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436470#comment-16436470 ] ASF GitHub Bot commented on ANY23-167: -- Github user asfgit closed the pull request at: https://github.com/apache/any23/pull/74 > Microdata itemscope properties incorrectly attached > --- > > Key: ANY23-167 > URL: https://issues.apache.org/jira/browse/ANY23-167 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Reporter: Ruben Verborgh >Assignee: Hans Brende >Priority: Major > Labels: microdata > Fix For: 2.3 > > > In some cases, Microdata properties inside an itemscope are attached to the > parent object. > For instance: http://ruben.verborgh.org/tmp/schemaorg-test.html > http://any23.org/any23/?uri=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Note how a separate Person entity is recognized, > but property values themselves are attached to the BlogPosting entity instead > of the Person entity. > Also the properties familyName and givenName are incorrectly identified as > http://schema.org/BlogPosting/familyName and > http://schema.org/BlogPosting/givenName, > while they should be http://schema.org/familyName and > http://schema.org/givenName. > The Structured Data Testing Tool shows the correct interpretation: > http://www.google.com/webmasters/tools/richsnippets?q=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Also note the wrong name "http:/schema.orgPerson" instead of > "http:/schema.org/Person". This seems to happen because the quotes around the > attribute are missing in the HTML source (I can file another issue for that > if needed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ANY23-167) Microdata itemscope properties incorrectly attached
[ https://issues.apache.org/jira/browse/ANY23-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436466#comment-16436466 ] ASF GitHub Bot commented on ANY23-167: -- GitHub user HansBrende opened a pull request: https://github.com/apache/any23/pull/74 ANY23-167 fixed: parent itemscopes inherited all properties from child itemscopes mvn clean test -> all tests pass (after modifying tests that were testing for incorrect behavior). You can merge this pull request into a Git repository by running: $ git pull https://github.com/HansBrende/any23 ANY23-167 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/any23/pull/74.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #74 commit 8f0db89ea1c4ca1c9c59d740b5ee4fe687957e5a Author: HansDate: 2018-04-12T23:12:02Z ANY23-167 fixed: parent itemscopes inherited all properties from child itemscopes > Microdata itemscope properties incorrectly attached > --- > > Key: ANY23-167 > URL: https://issues.apache.org/jira/browse/ANY23-167 > Project: Apache Any23 > Issue Type: Bug > Components: microdata >Reporter: Ruben Verborgh >Assignee: Hans Brende >Priority: Major > Labels: microdata > Fix For: 2.3 > > > In some cases, Microdata properties inside an itemscope are attached to the > parent object. > For instance: http://ruben.verborgh.org/tmp/schemaorg-test.html > http://any23.org/any23/?uri=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Note how a separate Person entity is recognized, > but property values themselves are attached to the BlogPosting entity instead > of the Person entity. > Also the properties familyName and givenName are incorrectly identified as > http://schema.org/BlogPosting/familyName and > http://schema.org/BlogPosting/givenName, > while they should be http://schema.org/familyName and > http://schema.org/givenName. > The Structured Data Testing Tool shows the correct interpretation: > http://www.google.com/webmasters/tools/richsnippets?q=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html > Also note the wrong name "http:/schema.orgPerson" instead of > "http:/schema.org/Person". This seems to happen because the quotes around the > attribute are missing in the HTML source (I can file another issue for that > if needed). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ANY23-167) Microdata itemscope properties incorrectly attached
[ https://issues.apache.org/jira/browse/ANY23-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13748970#comment-13748970 ] Lewis John McGibbney commented on ANY23-167: Hi Ruben thanks for reporting. I wonder if you would like to try working on a solution? I am not personally using the Microdata aspect of Any23 therefore contributions on this area would be very welcome indeed. Microdata itemscope properties incorrectly attached --- Key: ANY23-167 URL: https://issues.apache.org/jira/browse/ANY23-167 Project: Apache Any23 Issue Type: Bug Reporter: Ruben Verborgh Labels: microdata In some cases, Microdata properties inside an itemscope are attached to the parent object. For instance: http://ruben.verborgh.org/tmp/schemaorg-test.html http://any23.org/any23/?uri=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html Note how a separate Person entity is recognized, but property values themselves are attached to the BlogPosting entity instead of the Person entity. Also the properties familyName and givenName are incorrectly identified as http://schema.org/BlogPosting/familyName and http://schema.org/BlogPosting/givenName, while they should be http://schema.org/familyName and http://schema.org/givenName. The Structured Data Testing Tool shows the correct interpretation: http://www.google.com/webmasters/tools/richsnippets?q=http%3A%2F%2Fruben.verborgh.org%2Ftmp%2Fschemaorg-test.html Also note the wrong name http:/schema.orgPerson instead of http:/schema.org/Person. This seems to happen because the quotes around the attribute are missing in the HTML source (I can file another issue for that if needed). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira