[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Thomas Weise (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446471#comment-15446471
 ] 

Thomas Weise commented on APEXMALHAR-2206:
--

Yogi, I don't think we need to see this in the change log. I would also suggest 
that in the future we commit fixes to unreleased work against the original JIRA.

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Yogi Devendra (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15445329#comment-15445329
 ] 

Yogi Devendra commented on APEXMALHAR-2206:
---

Should we mark fix version as 3.5.0 for this ticket?

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440530#comment-15440530
 ] 

ASF GitHub Bot commented on APEXMALHAR-2206:


Github user asfgit closed the pull request at:

https://github.com/apache/apex-malhar/pull/384


> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440495#comment-15440495
 ] 

ASF GitHub Bot commented on APEXMALHAR-2206:


GitHub user yogidevendra reopened a pull request:

https://github.com/apache/apex-malhar/pull/384

APEXMALHAR-2206 : Application tests fixes

1. Fixing placement for lc.shutdown()
2. Disabling log messages for console output in JsonFormatterTest.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yogidevendra/apex-malhar 
APEXMALHAR-2206-test-fixes-polishing

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/apex-malhar/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #384


commit edf9635e005a6366341438970cbcd8a21416f106
Author: yogidevendra 
Date:   2016-08-26T16:14:04Z

APEXMALHAR-2206 : Application tests fixes

1. Fixing placement for lc.shutdown()
2. Disabling log messages for console output in JsonFormatterTest.

3. Incorporating review comments




> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439335#comment-15439335
 ] 

ASF GitHub Bot commented on APEXMALHAR-2206:


GitHub user yogidevendra opened a pull request:

https://github.com/apache/apex-malhar/pull/384

APEXMALHAR-2206 : Application tests fixes

1. Fixing placement for lc.shutdown()
2. Disabling log messages for console output in JsonFormatterTest.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yogidevendra/apex-malhar 
APEXMALHAR-2206-test-fixes-polishing

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/apex-malhar/pull/384.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #384


commit d6232d7d4a5d247a86f7124d52f8f1f3fee6587b
Author: yogidevendra 
Date:   2016-08-26T16:14:04Z

APEXMALHAR-2206 : Application tests fixes

1. Fixing placement for lc.shutdown()
2. Disabling log messages for console output in JsonFormatterTest.




> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Thomas Weise (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439313#comment-15439313
 ] 

Thomas Weise commented on APEXMALHAR-2206:
--

Another example of useless test:  lc.run(2000);// runs for 2 seconds and quits

Please file JIRA, this looks like something Shubham should work on.

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Yogi Devendra (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439309#comment-15439309
 ] 

Yogi Devendra commented on APEXMALHAR-2206:
---

Yes. It has 

ConsoleOutputOperator output = dag.addOperator("output", new 
ConsoleOutputOperator());
  output.setDebug(true);



> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Thomas Weise (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439306#comment-15439306
 ] 

Thomas Weise commented on APEXMALHAR-2206:
--

com.datatorrent.lib.formatter.JsonFormatterTest?

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Thomas Weise (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439293#comment-15439293
 ] 

Thomas Weise commented on APEXMALHAR-2206:
--

There is a lot of console output in the CI that seems to be added recently:
{code}
{"adId":1234,"campaignId":2319483,"sizes":["250x350","800x600"],"startDate":"Fri,
 1 Jan 2016 00:00:00","endDate":"01-Feb-2016","desc":"ad"}
2016-08-26 15:44:31,872 [3/output:ConsoleOutputOperator] INFO  
io.ConsoleOutputOperator process - 
{"adId":1234,"campaignId":2319483,"sizes":["250x350","800x600"],"startDate":"Fri,
 1 Jan 2016 00:00:00","endDate":"01-Feb-2016","desc":"ad"}
{"adId":1234,"campaignId":2319483,"sizes":["250x350","800x600"],"startDate":"Fri,
 1 Jan 2016 00:00:00","endDate":"01-Feb-2016","desc":"ad"}
2016-08-26 15:44:31,873 [3/output:ConsoleOutputOperator] INFO  
io.ConsoleOutputOperator process - 
{"adId":1234,"campaignId":2319483,"sizes":["250x350","800x600"],"startDate":"Fri,
 1 Jan 2016 00:00:00","endDate":"01-Feb-2016","desc":"ad"}
{code} 

We need to get rid of it.

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Thomas Weise (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439236#comment-15439236
 ] 

Thomas Weise commented on APEXMALHAR-2206:
--

I would suggest to ask the author of the code to fix it or otherwise it will 
never happen. I consider this a bug in the test and not a nice to have. It is 
important to have useful tests that execute reliably in the CI.

The placement of shutdown after assertion is also a problem with the change you 
pushed, see comment on the PR. 

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Yogi Devendra (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439220#comment-15439220
 ] 

Yogi Devendra commented on APEXMALHAR-2206:
---

I propose to create separate newbie ticket for each occurrence of anti pattern. 

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Yogi Devendra (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439215#comment-15439215
 ] 

Yogi Devendra commented on APEXMALHAR-2206:
---

Problem regarding anti pattern in the unit test case where we don't check for 
presence of results while waiting for arbitrary amount of time is not 
considered in the scope of this ticket.

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (APEXMALHAR-2206) Some Application tests taking too long

[Thomas Weise (JIRA)]

[ 
https://issues.apache.org/jira/browse/APEXMALHAR-2206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439124#comment-15439124
 ] 

Thomas Weise commented on APEXMALHAR-2206:
--

[~devendra] can you please look at the PR comments and address them. Also, have 
you looked for other tests that may potentially have the same issue?

> Some Application tests taking too long
> --
>
> Key: APEXMALHAR-2206
> URL: https://issues.apache.org/jira/browse/APEXMALHAR-2206
> Project: Apache Apex Malhar
>  Issue Type: Bug
>Reporter: Bhupesh Chawda
>Assignee: Yogi Devendra
>Priority: Minor
>
> Some Application Tests seems to be running for a long time.
> Additionally the size of the target folder increases too much ~ 2GB



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)