[jira] [Commented] (ARIES-1908) aries.spi-fly:upgrade to asm 7.1 so that can work with JDK12|JDK13
[ https://issues.apache.org/jira/browse/ARIES-1908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16806470#comment-16806470 ] Freeman Fang commented on ARIES-1908: - PR is https://github.com/apache/aries/pull/98/ > aries.spi-fly:upgrade to asm 7.1 so that can work with JDK12|JDK13 > -- > > Key: ARIES-1908 > URL: https://issues.apache.org/jira/browse/ARIES-1908 > Project: Aries > Issue Type: Task > Components: SPI Fly >Affects Versions: spifly-1.2 >Reporter: Freeman Fang >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARIES-1908) aries.spi-fly:upgrade to asm 7.1 so that can work with JDK12|JDK13
Freeman Fang created ARIES-1908: --- Summary: aries.spi-fly:upgrade to asm 7.1 so that can work with JDK12|JDK13 Key: ARIES-1908 URL: https://issues.apache.org/jira/browse/ARIES-1908 Project: Aries Issue Type: Task Components: SPI Fly Affects Versions: spifly-1.2 Reporter: Freeman Fang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARIES-1905) aries.proxy:upgrade to asm 7.1 so that can work with JDK12|JDK13
[ https://issues.apache.org/jira/browse/ARIES-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated ARIES-1905: Summary: aries.proxy:upgrade to asm 7.1 so that can work with JDK12|JDK13 (was: aries.proxy:upgrade to asm 7.1 so that can work with JDK12) > aries.proxy:upgrade to asm 7.1 so that can work with JDK12|JDK13 > > > Key: ARIES-1905 > URL: https://issues.apache.org/jira/browse/ARIES-1905 > Project: Aries > Issue Type: Task > Components: Proxy > Reporter: Freeman Fang >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARIES-1905) aries.proxy:upgrade to asm 7.1 so that can work with JDK12
[ https://issues.apache.org/jira/browse/ARIES-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated ARIES-1905: Component/s: Proxy > aries.proxy:upgrade to asm 7.1 so that can work with JDK12 > -- > > Key: ARIES-1905 > URL: https://issues.apache.org/jira/browse/ARIES-1905 > Project: Aries > Issue Type: Task > Components: Proxy > Reporter: Freeman Fang >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ARIES-1905) aries.proxy:upgrade to asm 7.1 so that can work with JDK12
[ https://issues.apache.org/jira/browse/ARIES-1905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797020#comment-16797020 ] Freeman Fang commented on ARIES-1905: - PR is https://github.com/apache/aries/pull/97 > aries.proxy:upgrade to asm 7.1 so that can work with JDK12 > -- > > Key: ARIES-1905 > URL: https://issues.apache.org/jira/browse/ARIES-1905 > Project: Aries > Issue Type: Task > Reporter: Freeman Fang >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARIES-1905) aries.proxy:upgrade to asm 7.1 so that can work with JDK12
Freeman Fang created ARIES-1905: --- Summary: aries.proxy:upgrade to asm 7.1 so that can work with JDK12 Key: ARIES-1905 URL: https://issues.apache.org/jira/browse/ARIES-1905 Project: Aries Issue Type: Task Reporter: Freeman Fang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARIES-1797) ensure proxy-impl can work with ASM 6.1 plus
[
https://issues.apache.org/jira/browse/ARIES-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Freeman Fang updated ARIES-1797:
Description:
In asm 6.1, the GeneratorAdapter.case method changed to
{code:java}
public void cast(final Type from, final Type to) {
if (from != to) {
if (from == Type.DOUBLE_TYPE) {
if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.D2F);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.D2L);
} else {
mv.visitInsn(Opcodes.D2I);
cast(Type.INT_TYPE, to);
}
} else if (from == Type.FLOAT_TYPE) {
if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.F2D);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.F2L);
} else {
mv.visitInsn(Opcodes.F2I);
cast(Type.INT_TYPE, to);
}
} else if (from == Type.LONG_TYPE) {
if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.L2D);
} else if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.L2F);
} else {
mv.visitInsn(Opcodes.L2I);
cast(Type.INT_TYPE, to);
}
} else {
if (to == Type.BYTE_TYPE) {
mv.visitInsn(Opcodes.I2B);
} else if (to == Type.CHAR_TYPE) {
mv.visitInsn(Opcodes.I2C);
} else if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.I2D);
} else if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.I2F);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.I2L);
} else if (to == Type.SHORT_TYPE) {
mv.visitInsn(Opcodes.I2S);
} else {
throw new IllegalArgumentException();
}
}
}
}
{code}
Compared with previous version, it added a
{code:java}
} else {
throw new IllegalArgumentException();
}
{code}
at the end, however, this break the current logic in proxy-impl, which if
"cast" not take effect, can still go with "unbox", we should revise proxy-impl
a bit to honor the change in ASM 6.1. Ensure proxy-impl can work with ASM 6.1
on the classpath or in the OSGi container
was:
In asm 6.1, the GeneratorAdapter.case method changed to
{code}
public void cast(final Type from, final Type to) {
if (from != to) {
if (from == Type.DOUBLE_TYPE) {
if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.D2F);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.D2L);
} else {
mv.visitInsn(Opcodes.D2I);
cast(Type.INT_TYPE, to);
}
} else if (from == Type.FLOAT_TYPE) {
if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.F2D);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.F2L);
} else {
mv.visitInsn(Opcodes.F2I);
cast(Type.INT_TYPE, to);
}
} else if (from == Type.LONG_TYPE) {
if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.L2D);
} else if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.L2F);
} else {
mv.visitInsn(Opcodes.L2I);
cast(Type.INT_TYPE, to);
}
} else {
if (to == Type.BYTE_TYPE) {
mv.visitInsn(Opcodes.I2B);
} else if (to == Type.CHAR_TYPE) {
mv.visitInsn(Opcodes.I2C);
} else if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.I2D);
} else if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.I2F);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.I2L);
} else if (to == Type.SHORT_TYPE) {
mv.visitInsn(Opcodes.I2S);
} else {
throw new IllegalArgumentException();
}
}
}
}
{code}
Compared with previous version, it added a
{code}
} else {
throw new IllegalArgumentException();
}
{code}
at the end, however, this break the current logic in proxy-impl, with if "cast"
not take effect, can still go with "unbox", we should revise proxy-impl a bit
to honor the change in ASM 6.1. Ensure proxy-impl can work with ASM 6.1 on the
classpath or in the OSGi container
> ensure proxy-impl can work with ASM 6.1 plus
>
>
> Key: ARIES-1797
> URL: https://issues.apache.org/jira/browse/ARIES-1797
> Project: Aries
> Issue Type: Improvement
>Reporter: Freeman Fang
>Priority: Major
> Attachments: ARIES-1797.patch
>
>
> In asm 6.1, the GeneratorAdapter.case method changed to
> {code:java}
> public void cast(final Type from, final Type to) {
> if (from != to) {
> if (from == Type.DOUBLE_TYPE) {
>
[jira] [Updated] (ARIES-1797) ensure proxy-impl can work with ASM 6.1 plus
[
https://issues.apache.org/jira/browse/ARIES-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Freeman Fang updated ARIES-1797:
Attachment: ARIES-1797.patch
> ensure proxy-impl can work with ASM 6.1 plus
>
>
> Key: ARIES-1797
> URL: https://issues.apache.org/jira/browse/ARIES-1797
> Project: Aries
> Issue Type: Improvement
> Reporter: Freeman Fang
>Priority: Major
> Attachments: ARIES-1797.patch
>
>
> In asm 6.1, the GeneratorAdapter.case method changed to
> {code}
> public void cast(final Type from, final Type to) {
> if (from != to) {
> if (from == Type.DOUBLE_TYPE) {
> if (to == Type.FLOAT_TYPE) {
> mv.visitInsn(Opcodes.D2F);
> } else if (to == Type.LONG_TYPE) {
> mv.visitInsn(Opcodes.D2L);
> } else {
> mv.visitInsn(Opcodes.D2I);
> cast(Type.INT_TYPE, to);
> }
> } else if (from == Type.FLOAT_TYPE) {
> if (to == Type.DOUBLE_TYPE) {
> mv.visitInsn(Opcodes.F2D);
> } else if (to == Type.LONG_TYPE) {
> mv.visitInsn(Opcodes.F2L);
> } else {
> mv.visitInsn(Opcodes.F2I);
> cast(Type.INT_TYPE, to);
> }
> } else if (from == Type.LONG_TYPE) {
> if (to == Type.DOUBLE_TYPE) {
> mv.visitInsn(Opcodes.L2D);
> } else if (to == Type.FLOAT_TYPE) {
> mv.visitInsn(Opcodes.L2F);
> } else {
> mv.visitInsn(Opcodes.L2I);
> cast(Type.INT_TYPE, to);
> }
> } else {
> if (to == Type.BYTE_TYPE) {
> mv.visitInsn(Opcodes.I2B);
> } else if (to == Type.CHAR_TYPE) {
> mv.visitInsn(Opcodes.I2C);
> } else if (to == Type.DOUBLE_TYPE) {
> mv.visitInsn(Opcodes.I2D);
> } else if (to == Type.FLOAT_TYPE) {
> mv.visitInsn(Opcodes.I2F);
> } else if (to == Type.LONG_TYPE) {
> mv.visitInsn(Opcodes.I2L);
> } else if (to == Type.SHORT_TYPE) {
> mv.visitInsn(Opcodes.I2S);
> } else {
> throw new IllegalArgumentException();
> }
> }
> }
> }
> {code}
>
> Compared with previous version, it added a
> {code}
> } else {
> throw new IllegalArgumentException();
> }
> {code}
> at the end, however, this break the current logic in proxy-impl, with if
> "cast" not take effect, can still go with "unbox", we should revise
> proxy-impl a bit to honor the change in ASM 6.1. Ensure proxy-impl can work
> with ASM 6.1 on the classpath or in the OSGi container
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1797) ensure proxy-impl can work with ASM 6.1 plus
[
https://issues.apache.org/jira/browse/ARIES-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463282#comment-16463282
]
Freeman Fang commented on ARIES-1797:
-
attached a suggested patch
> ensure proxy-impl can work with ASM 6.1 plus
>
>
> Key: ARIES-1797
> URL: https://issues.apache.org/jira/browse/ARIES-1797
> Project: Aries
> Issue Type: Improvement
> Reporter: Freeman Fang
>Priority: Major
> Attachments: ARIES-1797.patch
>
>
> In asm 6.1, the GeneratorAdapter.case method changed to
> {code:java}
> public void cast(final Type from, final Type to) {
> if (from != to) {
> if (from == Type.DOUBLE_TYPE) {
> if (to == Type.FLOAT_TYPE) {
> mv.visitInsn(Opcodes.D2F);
> } else if (to == Type.LONG_TYPE) {
> mv.visitInsn(Opcodes.D2L);
> } else {
> mv.visitInsn(Opcodes.D2I);
> cast(Type.INT_TYPE, to);
> }
> } else if (from == Type.FLOAT_TYPE) {
> if (to == Type.DOUBLE_TYPE) {
> mv.visitInsn(Opcodes.F2D);
> } else if (to == Type.LONG_TYPE) {
> mv.visitInsn(Opcodes.F2L);
> } else {
> mv.visitInsn(Opcodes.F2I);
> cast(Type.INT_TYPE, to);
> }
> } else if (from == Type.LONG_TYPE) {
> if (to == Type.DOUBLE_TYPE) {
> mv.visitInsn(Opcodes.L2D);
> } else if (to == Type.FLOAT_TYPE) {
> mv.visitInsn(Opcodes.L2F);
> } else {
> mv.visitInsn(Opcodes.L2I);
> cast(Type.INT_TYPE, to);
> }
> } else {
> if (to == Type.BYTE_TYPE) {
> mv.visitInsn(Opcodes.I2B);
> } else if (to == Type.CHAR_TYPE) {
> mv.visitInsn(Opcodes.I2C);
> } else if (to == Type.DOUBLE_TYPE) {
> mv.visitInsn(Opcodes.I2D);
> } else if (to == Type.FLOAT_TYPE) {
> mv.visitInsn(Opcodes.I2F);
> } else if (to == Type.LONG_TYPE) {
> mv.visitInsn(Opcodes.I2L);
> } else if (to == Type.SHORT_TYPE) {
> mv.visitInsn(Opcodes.I2S);
> } else {
> throw new IllegalArgumentException();
> }
> }
> }
> }
> {code}
>
> Compared with previous version, it added a
> {code:java}
> } else {
> throw new IllegalArgumentException();
> }
> {code}
> at the end, however, this break the current logic in proxy-impl, which if
> "cast" not take effect, can still go with "unbox", we should revise
> proxy-impl a bit to honor the change in ASM 6.1. Ensure proxy-impl can work
> with ASM 6.1 on the classpath or in the OSGi container
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (ARIES-1797) ensure proxy-impl can work with ASM 6.1 plus
Freeman Fang created ARIES-1797:
---
Summary: ensure proxy-impl can work with ASM 6.1 plus
Key: ARIES-1797
URL: https://issues.apache.org/jira/browse/ARIES-1797
Project: Aries
Issue Type: Improvement
Reporter: Freeman Fang
In asm 6.1, the GeneratorAdapter.case method changed to
{code}
public void cast(final Type from, final Type to) {
if (from != to) {
if (from == Type.DOUBLE_TYPE) {
if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.D2F);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.D2L);
} else {
mv.visitInsn(Opcodes.D2I);
cast(Type.INT_TYPE, to);
}
} else if (from == Type.FLOAT_TYPE) {
if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.F2D);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.F2L);
} else {
mv.visitInsn(Opcodes.F2I);
cast(Type.INT_TYPE, to);
}
} else if (from == Type.LONG_TYPE) {
if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.L2D);
} else if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.L2F);
} else {
mv.visitInsn(Opcodes.L2I);
cast(Type.INT_TYPE, to);
}
} else {
if (to == Type.BYTE_TYPE) {
mv.visitInsn(Opcodes.I2B);
} else if (to == Type.CHAR_TYPE) {
mv.visitInsn(Opcodes.I2C);
} else if (to == Type.DOUBLE_TYPE) {
mv.visitInsn(Opcodes.I2D);
} else if (to == Type.FLOAT_TYPE) {
mv.visitInsn(Opcodes.I2F);
} else if (to == Type.LONG_TYPE) {
mv.visitInsn(Opcodes.I2L);
} else if (to == Type.SHORT_TYPE) {
mv.visitInsn(Opcodes.I2S);
} else {
throw new IllegalArgumentException();
}
}
}
}
{code}
Compared with previous version, it added a
{code}
} else {
throw new IllegalArgumentException();
}
{code}
at the end, however, this break the current logic in proxy-impl, with if "cast"
not take effect, can still go with "unbox", we should revise proxy-impl a bit
to honor the change in ASM 6.1. Ensure proxy-impl can work with ASM 6.1 on the
classpath or in the OSGi container
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (ARIES-1796) avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl with java10
[ https://issues.apache.org/jira/browse/ARIES-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16451919#comment-16451919 ] Freeman Fang commented on ARIES-1796: - attached a suggest patch > avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl > with java10 > > > Key: ARIES-1796 > URL: https://issues.apache.org/jira/browse/ARIES-1796 > Project: Aries > Issue Type: Task >Reporter: Freeman Fang >Priority: Major > Attachments: ARIES-1796.patch > > > If we run blueprint enabled bundle in Karaf in java10, we can see this > exception. > The ProxyUtils class cannot recognize the java10 class version 54 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARIES-1796) avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl with java10
[ https://issues.apache.org/jira/browse/ARIES-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated ARIES-1796: Attachment: ARIES-1796.patch > avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl > with java10 > > > Key: ARIES-1796 > URL: https://issues.apache.org/jira/browse/ARIES-1796 > Project: Aries > Issue Type: Task >Reporter: Freeman Fang >Priority: Major > Attachments: ARIES-1796.patch > > > If we run blueprint enabled bundle in Karaf in java10, we can see this > exception. > The ProxyUtils class cannot recognize the java10 class version 54 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARIES-1796) avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl with java10
[ https://issues.apache.org/jira/browse/ARIES-1796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated ARIES-1796: Description: If we run blueprint enabled bundle in Karaf in java10, we can see this exception. The ProxyUtils class cannot recognize the java10 class version 54 > avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl > with java10 > > > Key: ARIES-1796 > URL: https://issues.apache.org/jira/browse/ARIES-1796 > Project: Aries > Issue Type: Task >Reporter: Freeman Fang >Priority: Major > > If we run blueprint enabled bundle in Karaf in java10, we can see this > exception. > The ProxyUtils class cannot recognize the java10 class version 54 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ARIES-1796) avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl with java10
Freeman Fang created ARIES-1796: --- Summary: avoid IllegalArgumentException "Invalid Java version 54" when use proxy-impl with java10 Key: ARIES-1796 URL: https://issues.apache.org/jira/browse/ARIES-1796 Project: Aries Issue Type: Task Reporter: Freeman Fang -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (ARIES-1761) ensure we inject BundleContext to the beans which need it
[ https://issues.apache.org/jira/browse/ARIES-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated ARIES-1761: Attachment: ARIES-1761.patch a patch is attached > ensure we inject BundleContext to the beans which need it > - > > Key: ARIES-1761 > URL: https://issues.apache.org/jira/browse/ARIES-1761 > Project: Aries > Issue Type: Bug > Components: Blueprint >Affects Versions: blueprint-spring-0.5.0 >Reporter: Freeman Fang > Attachments: ARIES-1761.patch > > > With the old spring-dm, there's a "BundleContextAware" interface, any bean > implements this interface can get BundleContext injected. > With the new aries-blueprint-spring, we should follow similar pattern, like > check if a bean has setBundleContext method, if so, just inject the > BundleContext into the bean, so that the application bundles with work with > spring-dm can also work with aries-blueprint-spring -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (ARIES-1761) ensure we inject BundleContext to the beans which need it
Freeman Fang created ARIES-1761: --- Summary: ensure we inject BundleContext to the beans which need it Key: ARIES-1761 URL: https://issues.apache.org/jira/browse/ARIES-1761 Project: Aries Issue Type: Bug Components: Blueprint Affects Versions: blueprint-spring-0.5.0 Reporter: Freeman Fang With the old spring-dm, there's a "BundleContextAware" interface, any bean implements this interface can get BundleContext injected. With the new aries-blueprint-spring, we should follow similar pattern, like check if a bean has setBundleContext method, if so, just inject the BundleContext into the bean, so that the application bundles with work with spring-dm can also work with aries-blueprint-spring -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Re: [VOTE] Release Blueprint-Core 1.7.1
+1 (non-binding) － Freeman(Yue) Fang Red Hat, Inc. FuseSource is now part of Red Hat > On Oct 7, 2016, at 11:25 PM, Guillaume Nodet wrote: > > I've staged a release for vote to fix ARIES-1503 (once again)... > > Staging repository: > https://repository.apache.org/content/repositories/orgapachearies-1080 > > Release notes: > [ARIES-1503] Wrap bad behaving NamespaceHandlers to fix their behavior > > Please review and vote, > Guillaume > > -- > > Guillaume Nodet > > Red Hat, Open Source Integration > > Email: gno...@redhat.com > Web: http://fusesource.com > Blog: http://gnodet.blogspot.com/
[jira] [Commented] (ARIES-1546) make proxy-impl works with java9
[ https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393357#comment-15393357 ] Freeman Fang commented on ARIES-1546: - Hi Guillaume, I attached a new patch. In this patch I create a SystemModuleClassLoader other than extend the AsmProxyManager.MultiClassLoader, as we need use SystemModuleClassLoader as fallback in several places. Also upgrade asm version to 6.0_ALPHA which can work with java9. All tests in proxy-impl passed with both java8 and java9, please let me know if this patch is OK. Thanks Freeman > make proxy-impl works with java9 > > > Key: ARIES-1546 > URL: https://issues.apache.org/jira/browse/ARIES-1546 > Project: Aries > Issue Type: Improvement > Components: Proxy > Reporter: Freeman Fang >Assignee: Guillaume Nodet > Attachments: ARIES-1546-new.patch, ARIES-1546.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARIES-1546) make proxy-impl works with java9
[ https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated ARIES-1546: Attachment: ARIES-1546-new.patch > make proxy-impl works with java9 > > > Key: ARIES-1546 > URL: https://issues.apache.org/jira/browse/ARIES-1546 > Project: Aries > Issue Type: Improvement > Components: Proxy > Reporter: Freeman Fang >Assignee: Guillaume Nodet > Attachments: ARIES-1546-new.patch, ARIES-1546.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1546) make proxy-impl works with java9
[ https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392912#comment-15392912 ] Freeman Fang commented on ARIES-1546: - All tests passed, will attach another patch soon. Thanks! > make proxy-impl works with java9 > > > Key: ARIES-1546 > URL: https://issues.apache.org/jira/browse/ARIES-1546 > Project: Aries > Issue Type: Improvement > Components: Proxy > Reporter: Freeman Fang >Assignee: Guillaume Nodet > Attachments: ARIES-1546.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1546) make proxy-impl works with java9
[
https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392069#comment-15392069
]
Freeman Fang commented on ARIES-1546:
-
Hi Guillaume,
Thanks for looking into this patch.
The original purpose of this patch isn't build proxy impl with java9, still
build with java8 but can run it with java9 in Karaf. Like we have proxy-impl
dependency in Karaf, and if we build/run Karaf with java9, this patch fix issue
we hit in Karaf with java9.
Anyway, I just did some experimental for building proxy-impl with java9, with
some more classloader.getResourceAsStream change, I get most tests passed, but
still have 4 failed
{code}
InterfaceProxyingTest.testGetProxyInstance2:122 » UnableToProxy
java.lang.Clas...
InterfaceProxyingTest.testHandlesObjectMethods:223 » UnableToProxy
java.lang.C...
WovenProxyPlusSubclassGeneratorTest.testAddingInterfacesToClass:219 »
UnableToProxy
WovenSubclassGeneratorTest.testAddingInterfacesToClass:200 » UnableToProxy
jav...
{code}
And the cause are same
{code}
org.apache.aries.proxy.UnableToProxyException: java.lang.ClassFormatError:
Absent Code attribute in method that is not native or abstract in class file
Proxyd262d56c_3a5c_4ff8_a417_93fe3554cc36
at java.lang.ClassLoader.defineClass1(java.base@9-ea/Native Method)
at
java.lang.ClassLoader.defineClass(java.base@9-ea/ClassLoader.java:942)
at
org.apache.aries.proxy.impl.interfaces.ProxyClassLoader.createProxyClass(ProxyClassLoader.java:160)
at
org.apache.aries.proxy.impl.interfaces.InterfaceProxyGenerator.getProxyInstance(InterfaceProxyGenerator.java:97)
{code}
FYI, I'm still on it and hopefully I will attach a new patch soon.
Best Regards
Freeman
> make proxy-impl works with java9
>
>
> Key: ARIES-1546
> URL: https://issues.apache.org/jira/browse/ARIES-1546
> Project: Aries
> Issue Type: Improvement
> Components: Proxy
>Reporter: Freeman Fang
>Assignee: Guillaume Nodet
> Attachments: ARIES-1546.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (ARIES-1546) make proxy-impl works with java9
[ https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363846#comment-15363846 ] Freeman Fang commented on ARIES-1546: - Hello Team, Could someone review and apply this patch? This is important to make Karaf run with java9. Thanks Freeman > make proxy-impl works with java9 > > > Key: ARIES-1546 > URL: https://issues.apache.org/jira/browse/ARIES-1546 > Project: Aries > Issue Type: Improvement > Components: Proxy > Reporter: Freeman Fang > Attachments: ARIES-1546.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1546) make proxy-impl works with java9
[ https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15273802#comment-15273802 ] Freeman Fang commented on ARIES-1546: - No, it won't cause any backward compatible issue as I use reflection here. > make proxy-impl works with java9 > > > Key: ARIES-1546 > URL: https://issues.apache.org/jira/browse/ARIES-1546 > Project: Aries > Issue Type: Improvement > Components: Proxy >Reporter: Freeman Fang > Attachments: ARIES-1546.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (ARIES-1546) make proxy-impl works with java9
[ https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Freeman Fang updated ARIES-1546: Attachment: ARIES-1546.patch > make proxy-impl works with java9 > > > Key: ARIES-1546 > URL: https://issues.apache.org/jira/browse/ARIES-1546 > Project: Aries > Issue Type: Improvement > Components: Proxy > Reporter: Freeman Fang > Attachments: ARIES-1546.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1546) make proxy-impl works with java9
[ https://issues.apache.org/jira/browse/ARIES-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271985#comment-15271985 ] Freeman Fang commented on ARIES-1546: - Hi Team, I'm working on building and running Karaf with java9, and found that currently can't run aries proxy-impl with java9 yet. The major problem is that in Java9, the ClassLoader.getResourceAsStream(String name) would return null which prevent to load the bytecode from java system modules. I will append a patch to fix this, using reflection way to use java9 api Module.getResourceAsStream to make it work if detect the JVM is java9. Best Regards Freeman > make proxy-impl works with java9 > > > Key: ARIES-1546 > URL: https://issues.apache.org/jira/browse/ARIES-1546 > Project: Aries > Issue Type: Improvement > Components: Proxy >Reporter: Freeman Fang > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARIES-1546) make proxy-impl works with java9
Freeman Fang created ARIES-1546: --- Summary: make proxy-impl works with java9 Key: ARIES-1546 URL: https://issues.apache.org/jira/browse/ARIES-1546 Project: Aries Issue Type: Improvement Components: Proxy Reporter: Freeman Fang -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (ARIES-1545) make proxy-impl works with java9
Freeman Fang created ARIES-1545: --- Summary: make proxy-impl works with java9 Key: ARIES-1545 URL: https://issues.apache.org/jira/browse/ARIES-1545 Project: Aries Issue Type: Improvement Components: Proxy Reporter: Freeman Fang -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (ARIES-1186) Upgrade to ASM 5 for Java 8 support
[
https://issues.apache.org/jira/browse/ARIES-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995995#comment-13995995
]
Freeman Fang edited comment on ARIES-1186 at 5/13/14 3:53 AM:
--
Hi Harald,
Thanks for the patch, seems Karaf|Aries Java8 support become more and more hot
now.
Just one question, I saw you have some changes like
{code}
-super(cv);
+super(ASM4, cv);
{code}
in your patch, shouldn't it be the Opcodes.ASM5 here as we are upgrading to
ASM5, so that the ASM api version should be ASM5, right?
If so, there are also several places in proxy-impl module should use
Opcodes.ASM5 instead of Opcodes.ASM4.
Cheers
Freeman
was (Author: ffang):
Hi Harald,
Thanks for the patch, seems Karaf|Aries Java8 support become more and more hot
now.
Just one question, I saw you have some changes like
-super(cv);
+super(ASM4, cv);
in your patch, shouldn't it be the Opcodes.ASM5 here as we are upgrading to
ASM5, so that the ASM api version should be ASM5, right?
If so, there are also several places in proxy-impl module should use
Opcodes.ASM5 instead of Opcodes.ASM4.
Cheers
Freeman
> Upgrade to ASM 5 for Java 8 support
> ---
>
> Key: ARIES-1186
> URL: https://issues.apache.org/jira/browse/ARIES-1186
> Project: Aries
> Issue Type: Improvement
> Components: Proxy
>Affects Versions: proxy-impl-1.0.2
>Reporter: Harald Wellmann
>Priority: Critical
>
> Aries Proxy does not work under Java 8, since it depends on ASM 4 which does
> not support Java 8.
> This is currently a blocker for working with Karaf 3.0.1 under Java 8. (Karaf
> contains Aries Proxy Impl 1.0.2).
> Upgrading to ASM 5.0.2 requires changing a few {{super()}} calls in Aries
> subclasses of ASM classes.
> I tried a local build of Aries Proxy Impl 1.0.3-SNAPSHOT with these changes,
> and the result seems to be ok for Karaf.
> The larger part of the issue on Aries side is the dependency on a prehistoric
> version of Pax Exam which depends on Pax Runner (with additional
> configuration tweaks from Aries) which does not support Java 8 either, so I
> haven't been able to run the Proxy integration tests.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ARIES-1186) Upgrade to ASM 5 for Java 8 support
[
https://issues.apache.org/jira/browse/ARIES-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997107#comment-13997107
]
Freeman Fang commented on ARIES-1186:
-
Thanks Guillaume, Harald for this clarification.
> Upgrade to ASM 5 for Java 8 support
> ---
>
> Key: ARIES-1186
> URL: https://issues.apache.org/jira/browse/ARIES-1186
> Project: Aries
> Issue Type: Improvement
> Components: Proxy
>Affects Versions: proxy-impl-1.0.2
>Reporter: Harald Wellmann
>Priority: Critical
>
> Aries Proxy does not work under Java 8, since it depends on ASM 4 which does
> not support Java 8.
> This is currently a blocker for working with Karaf 3.0.1 under Java 8. (Karaf
> contains Aries Proxy Impl 1.0.2).
> Upgrading to ASM 5.0.2 requires changing a few {{super()}} calls in Aries
> subclasses of ASM classes.
> I tried a local build of Aries Proxy Impl 1.0.3-SNAPSHOT with these changes,
> and the result seems to be ok for Karaf.
> The larger part of the issue on Aries side is the dependency on a prehistoric
> version of Pax Exam which depends on Pax Runner (with additional
> configuration tweaks from Aries) which does not support Java 8 either, so I
> haven't been able to run the Proxy integration tests.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (ARIES-1186) Upgrade to ASM 5 for Java 8 support
[
https://issues.apache.org/jira/browse/ARIES-1186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995995#comment-13995995
]
Freeman Fang commented on ARIES-1186:
-
Hi Harald,
Thanks for the patch, seems Karaf|Aries Java8 support become more and more hot
now.
Just one question, I saw you have some changes like
-super(cv);
+super(ASM4, cv);
in your patch, shouldn't it be the Opcodes.ASM5 here as we are upgrading to
ASM5, so that the ASM api version should be ASM5, right?
If so, there are also several places in proxy-impl module should use
Opcodes.ASM5 instead of Opcodes.ASM4.
Cheers
Freeman
> Upgrade to ASM 5 for Java 8 support
> ---
>
> Key: ARIES-1186
> URL: https://issues.apache.org/jira/browse/ARIES-1186
> Project: Aries
> Issue Type: Improvement
> Components: Proxy
>Affects Versions: proxy-impl-1.0.2
>Reporter: Harald Wellmann
>Priority: Critical
>
> Aries Proxy does not work under Java 8, since it depends on ASM 4 which does
> not support Java 8.
> This is currently a blocker for working with Karaf 3.0.1 under Java 8. (Karaf
> contains Aries Proxy Impl 1.0.2).
> Upgrading to ASM 5.0.2 requires changing a few {{super()}} calls in Aries
> subclasses of ASM classes.
> I tried a local build of Aries Proxy Impl 1.0.3-SNAPSHOT with these changes,
> and the result seems to be ok for Karaf.
> The larger part of the issue on Aries side is the dependency on a prehistoric
> version of Pax Exam which depends on Pax Runner (with additional
> configuration tweaks from Aries) which does not support Java 8 either, so I
> haven't been able to run the Proxy integration tests.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
Re: Plans for release of aries blueprint 0.4.1?
+1 Freeman On 2012-4-13, at 上午12:10, Guillaume Nodet wrote: Fwiw, I have a local fork of the 0.3.x aries maintenance branch which we could use as a basis for releasing our own version of the code if we need. I think that would be beneficial for the Karaf 2.x branches where we could get a bunch a bug fixes that we can't otherwise access. I know Geronimo has already released forked Aries code, (I suppose because of the exact same issue) so I don't think that's a real problem: http://repo1.maven.org/maven2/org/apache/geronimo/ext/aries/blueprint/org.apache.aries.blueprint/ Thoughts ? On Thu, Apr 12, 2012 at 17:18, Holly Cummins wrote: Hi, Unless it's based on a branch from an older blueprint level, I'm fairly sure that releasing blueprint 0.4.1 isn't much less work than releasing 1.0.0. The reason is that the new blueprint code will only resolve against a new version of the util bundle. No existing bundles will resolve against the new util bundle, so any bundles with a util dependency will also need to be re-released. This is pretty wretched, but such issues should go away once we're using version numbers above 1. I'm going slightly slower with the 1.0.0 work than I could because I'm making sure that all the 1.0.0 bundles work together; at the moment I'm unpicking a problem with the application deployment tests and recent testsupport bundles, for example. This could be deferred until after the first 1.0.0 bundles roll off the assembly line, depending how urgently Karaf need a new release. I think it's neater to do things as I am, but pragmatism and neatness aren't always friends. In either case, a new release hasn't been forgotten, and I am working away at it. :) Holly On 11 Apr 2012, at 19:33, "Yonker, Jonathan" > wrote: Hello, From reading through the mailing list, it appears that I'm not the only one with this question, but I still have to ask. Is there currently any timeline for the 0.4.1 release? It appears that all issues in JIRA were resolved quite a while ago, so it appears that the only problem are the release problems that I've been reading about on the mailing list. The project that I'm working on runs on Karaf and we're eagerly awaiting some of the bugfixes from the 0.4.x branch, but Karaf is waiting for 0.4.1 before they upgrade from 0.3.1 ( https://issues.apache.org/** jira/browse/KARAF-988 <https://issues.apache.org/jira/browse/KARAF-988 >). Does anyone have a good guess on the feasibility of releasing 0.4.1 rather than just going right to 1.0? Thanks for any updates you can provide! Thanks, Jon -- Guillaume Nodet Blog: http://gnodet.blogspot.com/ FuseSource, Integration everywhere http://fusesource.com - Freeman Fang FuseSource Email:ff...@fusesource.com Web: fusesource.com Twitter: freemanfang Blog: http://freemanfang.blogspot.com http://blog.sina.com.cn/u/1473905042 weibo: http://weibo.com/u/1473905042
