[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681340#comment-14681340 ] Tom De Wolf commented on ARIES-1368: John, is it not possible to have the testsupport release 2.0.0? It is rather urgent for our customer to be able to adopt subsystems. Otherwise we might have to drop aries subsystems completely which I would not prefer. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.0.0, subsystem-core-1.1.0, subsystem-core-1.2.0, subsystem-2.0.2, subsystem-2.0.1 Reporter: Wouter Bancken Assignee: John Ross Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14681765#comment-14681765 ] John Ross commented on ARIES-1368: -- I changed line 73 of OsgiIdentityCapability from IdentityNamespace.TYPE_BUNDLE); to manifest.getHeader(Constants.FRAGMENT_HOST) == null ? IdentityNamespace.TYPE_BUNDLE : IdentityNamespace.TYPE_FRAGMENT); in order to correctly identify fragments from bundles. Testing for the existence of the Fragment-Host header is sufficient for identifying a bundle as a fragment. However, this did not fix the problem. Upon further debugging, it looks like the Fragment-Host requirement is not being included as part of the corresponding resource which results in an improper resolution. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.0.0, subsystem-core-1.1.0, subsystem-core-1.2.0, subsystem-2.0.2, subsystem-2.0.1 Reporter: Wouter Bancken Assignee: John Ross Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662913#comment-14662913 ] Tom De Wolf commented on ARIES-1368: John, there is indeed no reason we could not upgrade to the latest release. I've updated our code base and aside from the reported problems we can use it. So getting this fixed and in an 2.0.3 release including maybe some extra bugfixes and upgrade to aries util 1.1.1 would be great. The latter also solve an issue we have when using subsystems. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661827#comment-14661827 ] John Ross commented on ARIES-1368: -- OsgiIdentityCapability.OsgiIdentityCapability(Resource, BundleManifest) will identify all bundles as type osgi.bundle via the osgi.identity capability. For fragments, the type should be osgi.fragment. Looking at the call hierarchy (attached), the evident consequences are the following. (1) Fragments will be misidentified as bundles within the subsystem's local repository. This means fragments will not be discovered within the local repository when searching by osgi.identity requirement. I'm not sure if this is actually ever done as part of installation. (2) Fragments will be misidentified as bundles within the subsystem's Subsystem-Content header if generated by the system rather than supplied by the ESA provider. I do not believe this would affect how the fragment is ultimately installed into the runtime since the framework will generate its own osgi.identity capability. It's not clear to me how this issue would manifest itself at runtime. Wouter, what are the specific symptoms you were experiencing? BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661848#comment-14661848 ] John Ross commented on ARIES-1368: -- I believe this issue would manifest itself when the Subsystem-Content header is generated by the system and the fragments are provided by a remote repository. The system would be searching for a resource of type osgi.bundle rather than osgi.fragment, and presumably the remote repository would have the correct type. Another manifestation would be when the ESA provider specifies the Subsystem-Content header themselves using the correct type and packages the fragment in the ESA itself. In this case, the system would be searching for a resource of type osgi.fragment, but the type would actually be osgi.bundle in the local repository. I believe everything would work correctly if (1) the Subsystem-Content header is generated by the system, and (2) the fragments are packaged as part of the ESA. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14661899#comment-14661899 ] Tom De Wolf commented on ARIES-1368: John, the problem manifests itself when you use the maven esa plugin and generate an esa in which the fragment is included. Installing such a subsystem does not work as it does not recognize the fragment as fragment. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662200#comment-14662200 ] John Ross commented on ARIES-1368: -- Thanks, Tom. If you look at OSGI-INF/SUBSYSTEM.MF contained within your attached ESA file, you will see the following: Subsystem-Content: be.aca.test-service-fragment;type=osgi.fragment;version=[1.0.1.SNAPSHOT,1.0.1.SNAPSHOT];start-order:=1 It is the declaration of the type, which I emphasize is correct, that is causing the issue in your case, which corresponds to (2) in my previous comment of https://issues.apache.org/jira/browse/ARIES-1368?focusedCommentId=14661827page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14661827. I presume this is being generated by the plugin. A workaround would be to either remove the type from Subsystem-Content or the entire header itself; however, this will be fixed as part of a future release. For example, the following modification should work: Subsystem-Content: be.aca.test-service-fragment;version=[1.0.1.SNAPSHOT,1.0.1.SNAPSHOT];start-order:=1 BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662230#comment-14662230 ] Tom De Wolf commented on ARIES-1368: Ok, thank you for explaining this. When can we expect to have the fix for this integrated in a new version of the subsystems library? The workaround would imply manually writing out subsystem manifests and no longer generate them using the maven plugin which we would like to keep. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662252#comment-14662252 ] John Ross commented on ARIES-1368: -- Wouter indicated version subsystem-core-1.2.0, although this issue affects all currently released versions. The current release is version subsystem-core-2.0.2. The next release from trunk would be subsystem-core-2.0.3 or subsystem-core-2.1.0 depending on the scope of other fixed defects that would be included. Is there any reason you could not move up to the latest release? BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662280#comment-14662280 ] John Ross commented on ARIES-1368: -- I've written a test case that reproduces the second manifestation referenced in comment https://issues.apache.org/jira/browse/ARIES-1368?focusedCommentId=14661848page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14661848. The issue cannot be reproduced unless the Subsystem-Content header with a declared type of osgi.fragment is explicitly provided. I will also implement a test case for the first manifestation mentioned in that same comment. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (ARIES-1368) BundleResource is not able to compute capabilities for fragments
[ https://issues.apache.org/jira/browse/ARIES-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662324#comment-14662324 ] John Ross commented on ARIES-1368: -- I've implemented the second test case and it fails as expected. BundleResource is not able to compute capabilities for fragments Key: ARIES-1368 URL: https://issues.apache.org/jira/browse/ARIES-1368 Project: Aries Issue Type: Bug Components: Subsystem Affects Versions: subsystem-core-1.2.0 Reporter: Wouter Bancken Attachments: OsgiIdentityCapability.OsgiIdentityCapability(Resource,BundleManifest)-CallHierarchy.jpg, test-service-fragment-subsystem-1.0.1-SNAPSHOT.esa The computeOsgiIdentityCapability method of the BundleResource is not able to compute capabilities for fragments (only for bundles). This is caused by the fact that the BundleResource is hardcoded to always assume a type of osgi.bundle without inspecting the manifest. Link to mailinglist thread: http://mail-archives.apache.org/mod_mbox/aries-user/201508.mbox/%3CCAL5nZgTOVhdAPYYFOmuV%3DPquAz1a4n_D1Rd3RBrTfu2znCSjKA%40mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v6.3.4#6332)
