Re: [VOTE] Versioning plugin 0.2.0
+1 David On 25 May 2014 12:44, Daniel Kulp dk...@apache.org wrote: With my own vote, I only have two votes. Can I get another PMC member to look at this? Thanks! Dan On May 19, 2014, at 1:15 PM, Daniel Kulp dk...@apache.org wrote: This is a vote to release 0.2.0 of the versioning plugin. The main change for this plugin is to support both Maven 3.0.x and 3.1.x/3.2.x by flipping from using Aether directly to using the Maven provided API’s. When released and rolled out throughout the rest of the build, we should hopefully be able to build Aries with a more modern version of Maven. Tag: https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.versioning-0.2.0/ Staging repo: https://repository.apache.org/content/repositories/orgapachearies-1000/org/apache/aries/versioning/ -- Daniel Kulp dk...@apache.org - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com -- Daniel Kulp dk...@apache.org - http://dankulp.com/blog Talend Community Coder - http://coders.talend.com
Re: Welcome our newest committers....
Thanks all guys, I would like to commit some stuff today, but I would like your approval/feedback: - ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by default. I don't think it makes sense to still maintain Java5 (as it's EOL). The current patch that I provided upgrade and compile with Java7, but use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by default. Any objection ? - ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies. - ARIES-1047: I've updated Aries JPA to support JPA 2.1 using geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been released and it's only available as a SNAPSHOT for now. I asked to Guillaume if he can make a release, and he said, he will. So I will commit as soon as geronimo-jpa_2.1 is on central. - ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to ASM 5.0.2 and support Java8, especially in Proxy and SpiFly. Any objection ? By the way, on Jira, I'm not able to assign Jira to myself, or change Jira. Can you give the permission for that please ? Thanks ! Regards JB On 05/25/2014 02:55 PM, Daniel Kulp wrote: The Aries PMC has voted in two new committers: Jean-Baptiste Onofré Christian Schneider Congratulations to them and many thanks for the contributions! -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: [VOTE] Versioning plugin 0.2.0
+1 (non binding) Regards JB On 05/19/2014 07:15 PM, Daniel Kulp wrote: This is a vote to release 0.2.0 of the versioning plugin. The main change for this plugin is to support both Maven 3.0.x and 3.1.x/3.2.x by flipping from using Aether directly to using the Maven provided API’s. When released and rolled out throughout the rest of the build, we should hopefully be able to build Aries with a more modern version of Maven. Tag: https://svn.apache.org/repos/asf/aries/tags/org.apache.aries.versioning-0.2.0/ Staging repo: https://repository.apache.org/content/repositories/orgapachearies-1000/org/apache/aries/versioning/ -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Welcome our newest committers....
Hi all I am very interested about the issue ARIES-1047. Please check releated issue ARIES-1134 and my commit https://github.com/ggerla/aries/commit/8fa3a46c3eff7abe893d3e859300c4cf807d5490 I think that is a good start point. regards Giuseppe 2014-05-26 11:04 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net: Thanks all guys, I would like to commit some stuff today, but I would like your approval/feedback: - ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by default. I don't think it makes sense to still maintain Java5 (as it's EOL). The current patch that I provided upgrade and compile with Java7, but use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by default. Any objection ? - ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies. - ARIES-1047: I've updated Aries JPA to support JPA 2.1 using geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been released and it's only available as a SNAPSHOT for now. I asked to Guillaume if he can make a release, and he said, he will. So I will commit as soon as geronimo-jpa_2.1 is on central. - ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to ASM 5.0.2 and support Java8, especially in Proxy and SpiFly. Any objection ? By the way, on Jira, I'm not able to assign Jira to myself, or change Jira. Can you give the permission for that please ? Thanks ! Regards JB On 05/25/2014 02:55 PM, Daniel Kulp wrote: The Aries PMC has voted in two new committers: Jean-Baptiste Onofré Christian Schneider Congratulations to them and many thanks for the contributions! -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
[jira] [Updated] (ARIES-1185) SPI Fly does not work with Java 8
[ https://issues.apache.org/jira/browse/ARIES-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Bosschaert updated ARIES-1185: Assignee: (was: David Bosschaert) SPI Fly does not work with Java 8 - Key: ARIES-1185 URL: https://issues.apache.org/jira/browse/ARIES-1185 Project: Aries Issue Type: Bug Reporter: David Bosschaert The SPI Fly component does not work with Java 8 due to the ASM version being used not being compatible with Java 8. Upgrading ASM to the latest version should fix the issue. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Welcome our newest committers....
Hi JB, On 26 May 2014 09:04, Jean-Baptiste Onofré j...@nanthrax.net wrote: - ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to ASM 5.0.2 and support Java8, especially in Proxy and SpiFly. Great - this should hopefully address ARIES-1185 as well! Thanks! David
Re: Welcome our newest committers....
Hi Giusseppe, I've already done JPA 2.1 support. I submitted the pull request, and we are good. You can take a look in ARIES-1047 (the pull request is in comment). Regards JB On 05/26/2014 11:13 AM, Giuseppe Gerla wrote: Hi all I am very interested about the issue ARIES-1047. Please check releated issue ARIES-1134 and my commit https://github.com/ggerla/aries/commit/8fa3a46c3eff7abe893d3e859300c4cf807d5490 I think that is a good start point. regards Giuseppe 2014-05-26 11:04 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net: Thanks all guys, I would like to commit some stuff today, but I would like your approval/feedback: - ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by default. I don't think it makes sense to still maintain Java5 (as it's EOL). The current patch that I provided upgrade and compile with Java7, but use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by default. Any objection ? - ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies. - ARIES-1047: I've updated Aries JPA to support JPA 2.1 using geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been released and it's only available as a SNAPSHOT for now. I asked to Guillaume if he can make a release, and he said, he will. So I will commit as soon as geronimo-jpa_2.1 is on central. - ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to ASM 5.0.2 and support Java8, especially in Proxy and SpiFly. Any objection ? By the way, on Jira, I'm not able to assign Jira to myself, or change Jira. Can you give the permission for that please ? Thanks ! Regards JB On 05/25/2014 02:55 PM, Daniel Kulp wrote: The Aries PMC has voted in two new committers: Jean-Baptiste Onofré Christian Schneider Congratulations to them and many thanks for the contributions! -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Welcome our newest committers....
On 26 May 2014, at 10:04, Jean-Baptiste Onofré j...@nanthrax.net wrote: Thanks all guys, I would like to commit some stuff today, but I would like your approval/feedback: - ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by default. I don't think it makes sense to still maintain Java5 (as it's EOL). The current patch that I provided upgrade and compile with Java7, but use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by default. Any objection ? I recommend OSGi 4.3.1, as that has full support for Java7 - the 4.3.0 spec jars were built with a target of “jsr14” which Java7 doesn’t recognise: https://mail.osgi.org/pipermail/osgi-dev/2011-August/003223.html - ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies. - ARIES-1047: I've updated Aries JPA to support JPA 2.1 using geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been released and it's only available as a SNAPSHOT for now. I asked to Guillaume if he can make a release, and he said, he will. So I will commit as soon as geronimo-jpa_2.1 is on central. - ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to ASM 5.0.2 and support Java8, especially in Proxy and SpiFly. Any objection ? By the way, on Jira, I'm not able to assign Jira to myself, or change Jira. Can you give the permission for that please ? Thanks ! Regards JB On 05/25/2014 02:55 PM, Daniel Kulp wrote: The Aries PMC has voted in two new committers: Jean-Baptiste Onofré Christian Schneider Congratulations to them and many thanks for the contributions! -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Welcome our newest committers....
Hi JB For now I was able to see the commit via web. I see that there are no tests of the features of version 2.0 and 2.1. The persistence.xml refer to JPA 1.0 xsi: schemaLocation = http://java.sun.com/xml/ns/persistence http://java.sun.com/xml/ns/persistence/persistence_1_0.xsd; version = 1.0 therefore do not test the new code implemented. I hope to do a diff during the day to give you more feedback Thanks Regards Giuseppe 2014-05-26 12:45 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net: Hi Giusseppe, I've already done JPA 2.1 support. I submitted the pull request, and we are good. You can take a look in ARIES-1047 (the pull request is in comment). Regards JB On 05/26/2014 11:13 AM, Giuseppe Gerla wrote: Hi all I am very interested about the issue ARIES-1047. Please check releated issue ARIES-1134 and my commit https://github.com/ggerla/aries/commit/8fa3a46c3eff7abe893d3e859300c4 cf807d5490 I think that is a good start point. regards Giuseppe 2014-05-26 11:04 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net: Thanks all guys, I would like to commit some stuff today, but I would like your approval/feedback: - ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by default. I don't think it makes sense to still maintain Java5 (as it's EOL). The current patch that I provided upgrade and compile with Java7, but use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by default. Any objection ? - ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies. - ARIES-1047: I've updated Aries JPA to support JPA 2.1 using geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been released and it's only available as a SNAPSHOT for now. I asked to Guillaume if he can make a release, and he said, he will. So I will commit as soon as geronimo-jpa_2.1 is on central. - ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to ASM 5.0.2 and support Java8, especially in Proxy and SpiFly. Any objection ? By the way, on Jira, I'm not able to assign Jira to myself, or change Jira. Can you give the permission for that please ? Thanks ! Regards JB On 05/25/2014 02:55 PM, Daniel Kulp wrote: The Aries PMC has voted in two new committers: Jean-Baptiste Onofré Christian Schneider Congratulations to them and many thanks for the contributions! -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
Re: Welcome our newest committers....
Hi JB
I make a diff between your commit and my commit.
A general consideration to make is that in all pom files in the
import-package section the javax.persistence version should
be [1.0.0,2.2.0) and not [1.0.0,3.0.0).
By code point of view I see following main difference:
- In JTAEntityManager.java you force the isJoinedToTransaction methid to
return true. From my point of view is more correct following code
EntityManager em = getPersistenceContext(false);
try {
return em.isJoinedToTransaction();
} finally {
if(em == detachedManager)
em.clear();
}
- In ManagedPersistenceContextFactory.java you have implemented last five
methods in the file to force return null. I think is better to throw
UnsupportedOperationException
- In EclipseLinkProviderService.java you don't override and implement
public void generateSchema(PersistenceUnitInfo arg0, Map arg1);
public boolean generateSchema(String arg0, Map arg1);
- In the pom of jpa-container-eclipselink-adapter bundle the version of
Eclipselink is 2.1.0 but to support JPA 2.1 you have to use = 2.5.0
(related to previous point)
- In the pom of jpa-container-testbundle-eclipselink bundle the version of
Eclipselink is 2.1.0 but to support JPA 2.1 you have to use = 2.5.0
(related to previous point)
- In all itest bundle it is important to update the pax-exam configuration
to use geronimo-jpa_2.1_spec if you want to test new implementation
- In all itest bundle it is important to update the openjpa version to
2.2.2 and update pax-exam configuration to use this version of openjpa (we
are waiting openjpa 2.4 to support JPA 2.1)
- In the pom of jpa-container-itest bundle you can update
the org.apache.aries.blueprint.core version to 1.4.0
- In the pom of jpa-container-itest bundle you can update all aries bundle
version dependency
I hope that my explanation was clear and can help you.
Regards
Giuseppe
2014-05-26 13:55 GMT+02:00 Giuseppe Gerla giuseppe.ge...@gmail.com:
Hi JB
For now I was able to see the commit via web. I see that there are no
tests of the features of version 2.0 and 2.1.
The persistence.xml refer to JPA 1.0
xsi: schemaLocation = http://java.sun.com/xml/ns/persistence
http://java.sun.com/xml/ns/persistence/persistence_1_0.xsd; version =
1.0
therefore do not test the new code implemented.
I hope to do a diff during the day to give you more feedback
Thanks
Regards
Giuseppe
2014-05-26 12:45 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net:
Hi Giusseppe,
I've already done JPA 2.1 support. I submitted the pull request, and we
are good. You can take a look in ARIES-1047 (the pull request is in
comment).
Regards
JB
On 05/26/2014 11:13 AM, Giuseppe Gerla wrote:
Hi all
I am very interested about the issue ARIES-1047. Please check releated
issue ARIES-1134 and my commit
https://github.com/ggerla/aries/commit/8fa3a46c3eff7abe893d3e859300c4
cf807d5490
I think that is a good start point.
regards
Giuseppe
2014-05-26 11:04 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net:
Thanks all guys,
I would like to commit some stuff today, but I would like your
approval/feedback:
- ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by
default. I don't think it makes sense to still maintain Java5 (as it's
EOL). The current patch that I provided upgrade and compile with Java7,
but
use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by
default. Any objection ?
- ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies.
- ARIES-1047: I've updated Aries JPA to support JPA 2.1 using
geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been
released and it's only available as a SNAPSHOT for now. I asked to
Guillaume if he can make a release, and he said, he will. So I will
commit
as soon as geronimo-jpa_2.1 is on central.
- ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to
ASM
5.0.2 and support Java8, especially in Proxy and SpiFly.
Any objection ?
By the way, on Jira, I'm not able to assign Jira to myself, or change
Jira. Can you give the permission for that please ?
Thanks !
Regards
JB
On 05/25/2014 02:55 PM, Daniel Kulp wrote:
The Aries PMC has voted in two new committers:
Jean-Baptiste Onofré
Christian Schneider
Congratulations to them and many thanks for the contributions!
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
[jira] [Commented] (ARIES-1185) SPI Fly does not work with Java 8
[ https://issues.apache.org/jira/browse/ARIES-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008826#comment-14008826 ] Harald Wellmann commented on ARIES-1185: BTW, I've just hacked and tested this locally. Upgrading to ASM 5.0.2 appears to be enough indeed. The POMs need some tweaking to build under Java 7 or 8. I can submit a pull request if desired. As a workaround, users can modify the Import-Package header (e.g. using Pax URL Wrap) to include ASM 5.x. SPI Fly does not work with Java 8 - Key: ARIES-1185 URL: https://issues.apache.org/jira/browse/ARIES-1185 Project: Aries Issue Type: Bug Reporter: David Bosschaert The SPI Fly component does not work with Java 8 due to the ASM version being used not being compatible with Java 8. Upgrading ASM to the latest version should fix the issue. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (ARIES-1194) Update jmx integration tests to pax exam 3.4.0
Christian Schneider created ARIES-1194: -- Summary: Update jmx integration tests to pax exam 3.4.0 Key: ARIES-1194 URL: https://issues.apache.org/jira/browse/ARIES-1194 Project: Aries Issue Type: Improvement Components: JMX Reporter: Christian Schneider -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ARIES-1185) SPI Fly does not work with Java 8
[ https://issues.apache.org/jira/browse/ARIES-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008959#comment-14008959 ] Jean-Baptiste Onofré commented on ARIES-1185: - Yes, it's what I did (with ARIES-1006 to build on Java7/8). Thanks for the double check Harald. SPI Fly does not work with Java 8 - Key: ARIES-1185 URL: https://issues.apache.org/jira/browse/ARIES-1185 Project: Aries Issue Type: Bug Reporter: David Bosschaert The SPI Fly component does not work with Java 8 due to the ASM version being used not being compatible with Java 8. Upgrading ASM to the latest version should fix the issue. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (ARIES-1185) SPI Fly does not work with Java 8
[ https://issues.apache.org/jira/browse/ARIES-1185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14008962#comment-14008962 ] Jean-Baptiste Onofré commented on ARIES-1185: - By the way, I sent an e-mail this morning on the aries dev mailing list to approve my push: I'm waiting for a feedback. SPI Fly does not work with Java 8 - Key: ARIES-1185 URL: https://issues.apache.org/jira/browse/ARIES-1185 Project: Aries Issue Type: Bug Reporter: David Bosschaert The SPI Fly component does not work with Java 8 due to the ASM version being used not being compatible with Java 8. Upgrading ASM to the latest version should fix the issue. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (ARIES-1194) Update jmx integration tests to pax exam 3.4.0
[ https://issues.apache.org/jira/browse/ARIES-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider reassigned ARIES-1194: -- Assignee: Christian Schneider Update jmx integration tests to pax exam 3.4.0 -- Key: ARIES-1194 URL: https://issues.apache.org/jira/browse/ARIES-1194 Project: Aries Issue Type: Improvement Components: JMX Reporter: Christian Schneider Assignee: Christian Schneider -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (ARIES-1194) Update jmx integration tests to pax exam 3.4.0
[ https://issues.apache.org/jira/browse/ARIES-1194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved ARIES-1194. Resolution: Fixed Update jmx integration tests to pax exam 3.4.0 -- Key: ARIES-1194 URL: https://issues.apache.org/jira/browse/ARIES-1194 Project: Aries Issue Type: Improvement Components: JMX Reporter: Christian Schneider Assignee: Christian Schneider -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (ARIES-1190) Update aries proxy integration tests to pax exam 3
[ https://issues.apache.org/jira/browse/ARIES-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved ARIES-1190. Resolution: Fixed Update aries proxy integration tests to pax exam 3 -- Key: ARIES-1190 URL: https://issues.apache.org/jira/browse/ARIES-1190 Project: Aries Issue Type: Improvement Components: Proxy Reporter: Christian Schneider Assignee: Christian Schneider -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (ARIES-1190) Update aries proxy integration tests to pax exam 3
[ https://issues.apache.org/jira/browse/ARIES-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider reassigned ARIES-1190: -- Assignee: Christian Schneider Update aries proxy integration tests to pax exam 3 -- Key: ARIES-1190 URL: https://issues.apache.org/jira/browse/ARIES-1190 Project: Aries Issue Type: Improvement Components: Proxy Reporter: Christian Schneider Assignee: Christian Schneider -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (ARIES-1184) Update blueprint integration tests to pax exam 3.4.0
[ https://issues.apache.org/jira/browse/ARIES-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved ARIES-1184. Resolution: Fixed Assignee: Christian Schneider Update blueprint integration tests to pax exam 3.4.0 Key: ARIES-1184 URL: https://issues.apache.org/jira/browse/ARIES-1184 Project: Aries Issue Type: Improvement Components: Blueprint Reporter: Christian Schneider Assignee: Christian Schneider Attachments: ARIES-1184-1.patch Currently blueprint itests still use pax exam 1.4.0 which is deprecated for some time. We should update the itests to use pax exam 3.4.0. I found that the pax exam dependency is defined in the aries parent pom. Ultimately we should also change the dependency there but for this issue I will define the pax exam version in the blueprint itests to keep this upgrade isolated. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (ARIES-1189) Update transaction integration tests to pax exam 3
[ https://issues.apache.org/jira/browse/ARIES-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved ARIES-1189. Resolution: Fixed Assignee: Christian Schneider Update transaction integration tests to pax exam 3 -- Key: ARIES-1189 URL: https://issues.apache.org/jira/browse/ARIES-1189 Project: Aries Issue Type: Improvement Components: Transaction Reporter: Christian Schneider Assignee: Christian Schneider -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Resolved] (ARIES-1188) Remove pax exam dependency from org.apache.aries.testsupport.unit
[ https://issues.apache.org/jira/browse/ARIES-1188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider resolved ARIES-1188. Resolution: Fixed Assignee: Christian Schneider Remove pax exam dependency from org.apache.aries.testsupport.unit - Key: ARIES-1188 URL: https://issues.apache.org/jira/browse/ARIES-1188 Project: Aries Issue Type: Improvement Reporter: Christian Schneider Assignee: Christian Schneider Like described in http://mail-archives.apache.org/mod_mbox/aries-dev/201405.mbox/%3C5370E1EA.9040008%40die-schneider.net%3E I propose to remove the pax exam dependency from org.apache.aries.testsupport.unit. So some reasons why I think this makes sense: - testsupport is used in many aries projects. Many of these do not need the pax exam depdenency. So the dependency binds all these project to a particular pax exam version and increases coupling - pax exam is only needed for two classes in test support. ExtraOptions and AbstractIntegrationTest. ExtraOptions is not really necessary with newer pax exam versions as most of the features are available directly in the pax exam DSL. AbstractIntegrationTest just uses the pax exam @Inject. In pax exam 3 this is replaced with javax @Inject. So this dependency is not necessary anymore. As far as I know this means we need a new major version of testsupport as we remove a public class. I will provide a patch. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Assigned] (ARIES-1183) Small refactorings
[ https://issues.apache.org/jira/browse/ARIES-1183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Schneider reassigned ARIES-1183: -- Assignee: Christian Schneider Small refactorings --- Key: ARIES-1183 URL: https://issues.apache.org/jira/browse/ARIES-1183 Project: Aries Issue Type: Improvement Components: JNDI Affects Versions: jndi-url-1.1.0 Reporter: Christian Schneider Assignee: Christian Schneider Fix For: jndi-url-1.1.0 Attachments: ARIES-1183-1.patch Some small refactorings of jndi url to remove duplications, make code more concise and easier to understand. -- This message was sent by Atlassian JIRA (v6.2#6252)
Re: Welcome our newest committers....
Thanks for the update Giuseppe,
For the version range, I'm not 100% sure as the next JPA version will be
3.0.0 (not 2.2.0). So actually, both is correct.
For all updates, I'm just waiting the geronimo-jpa_2.1 release to complete.
Regards
JB
On 05/26/2014 02:54 PM, Giuseppe Gerla wrote:
Hi JB
I make a diff between your commit and my commit.
A general consideration to make is that in all pom files in the
import-package section the javax.persistence version should
be [1.0.0,2.2.0) and not [1.0.0,3.0.0).
By code point of view I see following main difference:
- In JTAEntityManager.java you force the isJoinedToTransaction methid to
return true. From my point of view is more correct following code
EntityManager em = getPersistenceContext(false);
try {
return em.isJoinedToTransaction();
} finally {
if(em == detachedManager)
em.clear();
}
- In ManagedPersistenceContextFactory.java you have implemented last five
methods in the file to force return null. I think is better to throw
UnsupportedOperationException
- In EclipseLinkProviderService.java you don't override and implement
public void generateSchema(PersistenceUnitInfo arg0, Map arg1);
public boolean generateSchema(String arg0, Map arg1);
- In the pom of jpa-container-eclipselink-adapter bundle the version of
Eclipselink is 2.1.0 but to support JPA 2.1 you have to use = 2.5.0
(related to previous point)
- In the pom of jpa-container-testbundle-eclipselink bundle the version of
Eclipselink is 2.1.0 but to support JPA 2.1 you have to use = 2.5.0
(related to previous point)
- In all itest bundle it is important to update the pax-exam configuration
to use geronimo-jpa_2.1_spec if you want to test new implementation
- In all itest bundle it is important to update the openjpa version to
2.2.2 and update pax-exam configuration to use this version of openjpa (we
are waiting openjpa 2.4 to support JPA 2.1)
- In the pom of jpa-container-itest bundle you can update
the org.apache.aries.blueprint.core version to 1.4.0
- In the pom of jpa-container-itest bundle you can update all aries bundle
version dependency
I hope that my explanation was clear and can help you.
Regards
Giuseppe
2014-05-26 13:55 GMT+02:00 Giuseppe Gerla giuseppe.ge...@gmail.com:
Hi JB
For now I was able to see the commit via web. I see that there are no
tests of the features of version 2.0 and 2.1.
The persistence.xml refer to JPA 1.0
xsi: schemaLocation = http://java.sun.com/xml/ns/persistence
http://java.sun.com/xml/ns/persistence/persistence_1_0.xsd; version =
1.0
therefore do not test the new code implemented.
I hope to do a diff during the day to give you more feedback
Thanks
Regards
Giuseppe
2014-05-26 12:45 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net:
Hi Giusseppe,
I've already done JPA 2.1 support. I submitted the pull request, and we
are good. You can take a look in ARIES-1047 (the pull request is in
comment).
Regards
JB
On 05/26/2014 11:13 AM, Giuseppe Gerla wrote:
Hi all
I am very interested about the issue ARIES-1047. Please check releated
issue ARIES-1134 and my commit
https://github.com/ggerla/aries/commit/8fa3a46c3eff7abe893d3e859300c4
cf807d5490
I think that is a good start point.
regards
Giuseppe
2014-05-26 11:04 GMT+02:00 Jean-Baptiste Onofré j...@nanthrax.net:
Thanks all guys,
I would like to commit some stuff today, but I would like your
approval/feedback:
- ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by
default. I don't think it makes sense to still maintain Java5 (as it's
EOL). The current patch that I provided upgrade and compile with Java7,
but
use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by
default. Any objection ?
- ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies.
- ARIES-1047: I've updated Aries JPA to support JPA 2.1 using
geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been
released and it's only available as a SNAPSHOT for now. I asked to
Guillaume if he can make a release, and he said, he will. So I will
commit
as soon as geronimo-jpa_2.1 is on central.
- ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to
ASM
5.0.2 and support Java8, especially in Proxy and SpiFly.
Any objection ?
By the way, on Jira, I'm not able to assign Jira to myself, or change
Jira. Can you give the permission for that please ?
Thanks !
Regards
JB
On 05/25/2014 02:55 PM, Daniel Kulp wrote:
The Aries PMC has voted in two new committers:
Jean-Baptiste Onofré
Christian Schneider
Congratulations to them and many thanks for the contributions!
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
--
Jean-Baptiste Onofré
jbono...@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: Welcome our newest committers....
Hi Stuart, correct, (actually, it's what I thought ;)). Regards JB On 05/26/2014 01:09 PM, Stuart McCulloch wrote: On 26 May 2014, at 10:04, Jean-Baptiste Onofré j...@nanthrax.net wrote: Thanks all guys, I would like to commit some stuff today, but I would like your approval/feedback: - ARIES-1006: I refactored the parent to use Java7 and OSGi 4.3.0 by default. I don't think it makes sense to still maintain Java5 (as it's EOL). The current patch that I provided upgrade and compile with Java7, but use OSGi 4.2.0. I'm working on a new patch adding OSGi 4.3.0 support by default. Any objection ? I recommend OSGi 4.3.1, as that has full support for Java7 - the 4.3.0 spec jars were built with a target of “jsr14” which Java7 doesn’t recognise: https://mail.osgi.org/pipermail/osgi-dev/2011-August/003223.html - ARIES-1177: upgrade to Apache POM 14 and upgrade some dependencies. - ARIES-1047: I've updated Aries JPA to support JPA 2.1 using geronimo-jpa_2.1 spec. Unfortunately, geronimo-jpa_2.1 has not been released and it's only available as a SNAPSHOT for now. I asked to Guillaume if he can make a release, and he said, he will. So I will commit as soon as geronimo-jpa_2.1 is on central. - ARIES-1180, ARIES-1179: I have a set of patches ready to upgrade to ASM 5.0.2 and support Java8, especially in Proxy and SpiFly. Any objection ? By the way, on Jira, I'm not able to assign Jira to myself, or change Jira. Can you give the permission for that please ? Thanks ! Regards JB On 05/25/2014 02:55 PM, Daniel Kulp wrote: The Aries PMC has voted in two new committers: Jean-Baptiste Onofré Christian Schneider Congratulations to them and many thanks for the contributions! -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com -- Jean-Baptiste Onofré jbono...@apache.org http://blog.nanthrax.net Talend - http://www.talend.com
