[jira] [Assigned] (ATLAS-4267) Quick Search : AggregationMetrics is incorrect with some special characters

2021-04-28 Thread Pinal (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal reassigned ATLAS-4267:


Assignee: Pinal

> Quick Search : AggregationMetrics is incorrect with some special characters
> ---
>
> Key: ATLAS-4267
> URL: https://issues.apache.org/jira/browse/ATLAS-4267
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 3.0.0
>Reporter: Pinal Shah
>Assignee: Pinal
>Priority: Major
>
> Quick search with attribute filter :
> qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
> empty AggregationMetrics
> whereas with "default.datagen_table_sensitive_725_1" has right 
> AggregationMetrics. __ 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (ATLAS-2694) Avro schema typedef and support for Avro schema evolution in Atlas

2021-04-28 Thread Oshin Sharel Britto (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335149#comment-17335149
 ] 

Oshin Sharel Britto edited comment on ATLAS-2694 at 4/29/21, 5:09 AM:
--

[~barbara] Is there a parser already to convert from the Avro schema to the 
Avro schema AtlasEntity? I couldn't find it. Could you please help? :)


was (Author: obritto):
[~barbara] Is there a parser already to convert from the Avro schema to the 
Avro schema AtlasEntity? I couldn't find it. Could you please help?

> Avro schema typedef and support for Avro schema evolution  in Atlas
> ---
>
> Key: ATLAS-2694
> URL: https://issues.apache.org/jira/browse/ATLAS-2694
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Reporter: Srikanth Venkat
>Assignee: Barbara Eckman
>Priority: Critical
> Fix For: 1.0.0
>
> Attachments: ATLAS-2694-2.patch, ATLAS-2694.patch, 
> avro_atlas_types_08.json
>
>
> Currently the base types in Atlas do not include Avro schemas. It would be 
> nice to add typedef for Avro schema and any associated metadata to support 
> schema evolution.
>  * For example, Avro_schema type supports:
>  ** All avro types, both primitive and complex, including union types, as 
> fields of schema
>  ** All types have doc strings and defaults
>  ** A field of a schema can be another schema
>  ** Indefinite nesting of records, arrays.
>  ** Associated entities array attribute contains pointers to all datasets 
> that reflect the avro schema
>  ** Fully expanded avroNotation for use in serDe
>  ** Schema evolution features such as isLatest (Boolean) and version number
>  * Schema evolution Process
>  ** Input: avro schema
>  ** Output: new version of avro schema
>  ** Compatibility: FULL, BACKWARD, FORWARD, NONE
>  ** IsBreakingChange (Boolean): does the change produce an incompatible 
> schema? (ie its compatibility is not “FULL”)
>  *



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-2694) Avro schema typedef and support for Avro schema evolution in Atlas

2021-04-28 Thread Oshin Sharel Britto (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17335149#comment-17335149
 ] 

Oshin Sharel Britto commented on ATLAS-2694:


[~barbara] Is there a parser already to convert from the Avro schema to the 
Avro schema AtlasEntity? I couldn't find it. Could you please help?

> Avro schema typedef and support for Avro schema evolution  in Atlas
> ---
>
> Key: ATLAS-2694
> URL: https://issues.apache.org/jira/browse/ATLAS-2694
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Reporter: Srikanth Venkat
>Assignee: Barbara Eckman
>Priority: Critical
> Fix For: 1.0.0
>
> Attachments: ATLAS-2694-2.patch, ATLAS-2694.patch, 
> avro_atlas_types_08.json
>
>
> Currently the base types in Atlas do not include Avro schemas. It would be 
> nice to add typedef for Avro schema and any associated metadata to support 
> schema evolution.
>  * For example, Avro_schema type supports:
>  ** All avro types, both primitive and complex, including union types, as 
> fields of schema
>  ** All types have doc strings and defaults
>  ** A field of a schema can be another schema
>  ** Indefinite nesting of records, arrays.
>  ** Associated entities array attribute contains pointers to all datasets 
> that reflect the avro schema
>  ** Fully expanded avroNotation for use in serDe
>  ** Schema evolution features such as isLatest (Boolean) and version number
>  * Schema evolution Process
>  ** Input: avro schema
>  ** Output: new version of avro schema
>  ** Compatibility: FULL, BACKWARD, FORWARD, NONE
>  ** IsBreakingChange (Boolean): does the change produce an incompatible 
> schema? (ie its compatibility is not “FULL”)
>  *



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222904
---


Ship it!




Ship It!

- Dharshana MK


On April 29, 2021, 4:09 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 29, 2021, 4:09 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/7/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 
> already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 
> already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": 
> "{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
---

(Updated April 29, 2021, 4:09 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261


Repository: atlas


Description
---

ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
4fa1538df 
  
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
b12c0b803 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
f5789a712 


Diff: https://reviews.apache.org/r/73304/diff/7/


Testing (updated)
---

{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 
already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already 
exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": 
"{\"termGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}


Thanks,

Sidharth Mishra

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
---

(Updated April 29, 2021, 4:07 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261


Repository: atlas


Description
---

ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
4fa1538df 
  
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
b12c0b803 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
f5789a712 


Diff: https://reviews.apache.org/r/73304/diff/7/

Changes: https://reviews.apache.org/r/73304/diff/6-7/


Testing
---

{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 
already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already 
exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": 
"{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}


Thanks,

Sidharth Mishra

[jira] [Created] (ATLAS-4267) Quick Search : AggregationMetrics is incorrect with some special characters

2021-04-28 Thread Pinal Shah (Jira) 
Pinal Shah created ATLAS-4267:
-

 Summary: Quick Search : AggregationMetrics is incorrect with some 
special characters
 Key: ATLAS-4267
 URL: https://issues.apache.org/jira/browse/ATLAS-4267
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 3.0.0
Reporter: Pinal Shah


Quick search with attribute filter :

qualifiedName - beginsWith - "default.datagen_table_sensitive_725_1."  has 
empty AggregationMetrics

whereas with "default.datagen_table_sensitive_725_1" has right 
AggregationMetrics. __ 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222903
---


Ship it!




Ship It!

- Sarath Subramanian


On April 28, 2021, 6:36 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 28, 2021, 6:36 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/6/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 
> already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 
> already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": 
> "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK 


> On April 28, 2021, 1:02 p.m., Dharshana MK wrote:
> > Thanks Sidharth Mishra
> > We can obtain the qualified name from the input but getting the guid is 
> > tricky
> > Can we also pass the guid of the term created in the response "remarks"?
> > 
> > GET /v2/glossary
> > POST /v2/glossary
> > POST /v2/glossary/categories
> > POST /v2/glossary/category
> > POST /v2/glossary/import
> > POST /v2/glossary/term
> > POST /v2/glossary/terms
> > DELETE /v2/glossary/{glossaryGuid}
> > GET /v2/glossary/{glossaryGuid}
> > PUT /v2/glossary/{glossaryGuid}
> > DELETE /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/category/{categoryGuid}
> > PUT /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/import/template
> > DELETE /v2/glossary/term/{termGuid}
> > GET /v2/glossary/term/{termGuid}
> > PUT /v2/glossary/term/{termGuid}
> > GET /v2/glossary/{glossaryGuid}/categories
> > GET /v2/glossary/{glossaryGuid}/detailed
> > PUT /v2/glossary/{glossaryGuid}/partial
> > GET /v2/glossary/{glossaryGuid}/terms
> > PUT /v2/glossary/category/{categoryGuid}/partial
> > GET /v2/glossary/category/{categoryGuid}/related
> > GET /v2/glossary/category/{categoryGuid}/terms
> > PUT /v2/glossary/term/{termGuid}/partial
> > DELETE /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/assignedEntities
> > POST /v2/glossary/terms/{termGuid}/assignedEntities
> > PUT /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/related
> > GET /v2/glossary/{glossaryGuid}/categories/headers
> > GET /v2/glossary/{glossaryGuid}/terms/headers
> > 
> > From the available list of apis it will be difficult to get the complete 
> > details just by using the qualified name as we do not have a GET on 
> > /v2/glossary/terms
> > 
> > But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we 
> > might get the complete details.
> > 
> > Even customers might face this.
> > 
> > Thoughts?
> 
> Sidharth Mishra wrote:
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 
> already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 
> already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": 
> "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }

you meant termGuid?


- Dharshana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222895
---


On April 29, 2021, 1:36 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 29, 2021, 1:36 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/6/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 
> already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 
> already exists"
> }
> ],
>

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222901
---


Ship it!




Ship It!

- Dharshana MK


On April 29, 2021, 1:36 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 29, 2021, 1:36 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   
> intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java
>  PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/6/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 
> already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 
> already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": 
> "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
> }
> ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
---

(Updated April 29, 2021, 1:36 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261


Repository: atlas


Description
---

ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
4fa1538df 
  
intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTermHeader.java 
PRE-CREATION 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
b12c0b803 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
f5789a712 


Diff: https://reviews.apache.org/r/73304/diff/6/

Changes: https://reviews.apache.org/r/73304/diff/5-6/


Testing
---

{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 
already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already 
exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": 
"{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}


Thanks,

Sidharth Mishra

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra 


> On April 28, 2021, 1:02 p.m., Dharshana MK wrote:
> > Thanks Sidharth Mishra
> > We can obtain the qualified name from the input but getting the guid is 
> > tricky
> > Can we also pass the guid of the term created in the response "remarks"?
> > 
> > GET /v2/glossary
> > POST /v2/glossary
> > POST /v2/glossary/categories
> > POST /v2/glossary/category
> > POST /v2/glossary/import
> > POST /v2/glossary/term
> > POST /v2/glossary/terms
> > DELETE /v2/glossary/{glossaryGuid}
> > GET /v2/glossary/{glossaryGuid}
> > PUT /v2/glossary/{glossaryGuid}
> > DELETE /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/category/{categoryGuid}
> > PUT /v2/glossary/category/{categoryGuid}
> > GET /v2/glossary/import/template
> > DELETE /v2/glossary/term/{termGuid}
> > GET /v2/glossary/term/{termGuid}
> > PUT /v2/glossary/term/{termGuid}
> > GET /v2/glossary/{glossaryGuid}/categories
> > GET /v2/glossary/{glossaryGuid}/detailed
> > PUT /v2/glossary/{glossaryGuid}/partial
> > GET /v2/glossary/{glossaryGuid}/terms
> > PUT /v2/glossary/category/{categoryGuid}/partial
> > GET /v2/glossary/category/{categoryGuid}/related
> > GET /v2/glossary/category/{categoryGuid}/terms
> > PUT /v2/glossary/term/{termGuid}/partial
> > DELETE /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/assignedEntities
> > POST /v2/glossary/terms/{termGuid}/assignedEntities
> > PUT /v2/glossary/terms/{termGuid}/assignedEntities
> > GET /v2/glossary/terms/{termGuid}/related
> > GET /v2/glossary/{glossaryGuid}/categories/headers
> > GET /v2/glossary/{glossaryGuid}/terms/headers
> > 
> > From the available list of apis it will be difficult to get the complete 
> > details just by using the qualified name as we do not have a GET on 
> > /v2/glossary/terms
> > 
> > But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we 
> > might get the complete details.
> > 
> > Even customers might face this.
> > 
> > Thoughts?

{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 
already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already 
exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": 
"{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}


- Sidharth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222895
---


On April 29, 2021, 1:35 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 29, 2021, 1:35 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/5/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Banking9",
> "childObjectName": "Payable",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Payable@Banking9 
> already exists"
> },
> {
> "parentObjectName": "Auto9",
> "childObjectName": "Steering",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Steering@Auto9 
> already exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking16",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": 
> "{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
>

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/
---

(Updated April 29, 2021, 1:35 a.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4261
https://issues.apache.org/jira/browse/ATLAS-4261


Repository: atlas


Description
---

ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
  intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
4fa1538df 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
b12c0b803 
  repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
f5789a712 


Diff: https://reviews.apache.org/r/73304/diff/5/


Testing (updated)
---

{
"failedImportInfoList": [
{
"parentObjectName": "Banking9",
"childObjectName": "Payable",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Payable@Banking9 
already exists"
},
{
"parentObjectName": "Auto9",
"childObjectName": "Steering",
"importStatus": "FAILED",
"remarks": "Glossary term with qualifiedName Steering@Auto9 already 
exists"
}
],
"successImportInfoList": [
{
"parentObjectName": "Banking16",
"childObjectName": "Receivable",
"importStatus": "SUCCESS",
"remarks": 
"{\"glossaryGuid\":\"f4f4c97a-7937-4639-8c3d-bdd46f0a6ed8\",\"qualifiedName\":\"Receivable@Banking16\"}"
}
]
}


Thanks,

Sidharth Mishra

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Sidharth Mishra 


> On April 28, 2021, 4:37 a.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 1186 (patched)
> > 
> >
> > this method is unused, please review remove.

I have not uploaded the new patch which was using this. Now uploaded the new one


- Sidharth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222891
---


On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 28, 2021, 1:30 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/5/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already 
> exists"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Brake",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Brake@Auto already 
> exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "Receivable@Banking4"
> },
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "Payable@Banking4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "Steering@Auto4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Paint",
> "importStatus": "SUCCESS",
> "remarks": "Paint@Auto4"
> }
> ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-28 Thread chaitali 


> On April 27, 2021, 5:32 a.m., Pinal Shah wrote:
> > distro/src/bin/atlas_start.py
> > Line 135 (original), 138 (patched)
> > 
> >
> > What happens if the collection name, updated in properties already 
> > exists in solr
> > Can we restrict this from not allowing to point old collection?

I have added a comment in application.properties file for this.


- chaitali


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222873
---


On April 28, 2021, 5:39 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated April 28, 2021, 5:39 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
>   repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
> PRE-CREATION 
>   
> tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java
>  37565188e 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/8/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-28 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 28, 2021, 5:39 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
37565188e 


Diff: https://reviews.apache.org/r/73249/diff/8/

Changes: https://reviews.apache.org/r/73249/diff/7-8/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

2021-04-28 Thread chaitali 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 28, 2021, 4:30 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 4df38a5e6 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 05b078416 
  repository/src/test/java/org/apache/atlas/TestSolrConfigurableNames.java 
PRE-CREATION 
  
tools/atlas-index-repair/src/main/java/org/apache/atlas/tools/RepairIndex.java 
37565188e 


Diff: https://reviews.apache.org/r/73249/diff/7/

Changes: https://reviews.apache.org/r/73249/diff/6-7/


Testing
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222895
---



Thanks Sidharth Mishra
We can obtain the qualified name from the input but getting the guid is tricky
Can we also pass the guid of the term created in the response "remarks"?

GET /v2/glossary
POST /v2/glossary
POST /v2/glossary/categories
POST /v2/glossary/category
POST /v2/glossary/import
POST /v2/glossary/term
POST /v2/glossary/terms
DELETE /v2/glossary/{glossaryGuid}
GET /v2/glossary/{glossaryGuid}
PUT /v2/glossary/{glossaryGuid}
DELETE /v2/glossary/category/{categoryGuid}
GET /v2/glossary/category/{categoryGuid}
PUT /v2/glossary/category/{categoryGuid}
GET /v2/glossary/import/template
DELETE /v2/glossary/term/{termGuid}
GET /v2/glossary/term/{termGuid}
PUT /v2/glossary/term/{termGuid}
GET /v2/glossary/{glossaryGuid}/categories
GET /v2/glossary/{glossaryGuid}/detailed
PUT /v2/glossary/{glossaryGuid}/partial
GET /v2/glossary/{glossaryGuid}/terms
PUT /v2/glossary/category/{categoryGuid}/partial
GET /v2/glossary/category/{categoryGuid}/related
GET /v2/glossary/category/{categoryGuid}/terms
PUT /v2/glossary/term/{termGuid}/partial
DELETE /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/assignedEntities
POST /v2/glossary/terms/{termGuid}/assignedEntities
PUT /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/related
GET /v2/glossary/{glossaryGuid}/categories/headers
GET /v2/glossary/{glossaryGuid}/terms/headers

>From the available list of apis it will be difficult to get the complete 
>details just by using the qualified name as we do not have a GET on 
>/v2/glossary/terms

But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we 
might get the complete details.

Even customers might face this.

Thoughts?

- Dharshana MK


On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 28, 2021, 1:30 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/5/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already 
> exists"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Brake",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Brake@Auto already 
> exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "Receivable@Banking4"
> },
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "Payable@Banking4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "Steering@Auto4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Paint",
> "importStatus": "SUCCESS",
> "remarks": "Paint@Auto4"
> }
> ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73304: ATLAS-4261: Bulk Glossary Import Response and Failed Error Message Improvements

2021-04-28 Thread Dharshana MK 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222894
---



Thanks Sidharth Mishra
We can obtain the qualified name from the input but getting the guild is tricky
Can we also pass the guid of the term created?

GET /v2/glossary
POST /v2/glossary
POST /v2/glossary/categories
POST /v2/glossary/category
POST /v2/glossary/import
POST /v2/glossary/term
POST /v2/glossary/terms
DELETE /v2/glossary/{glossaryGuid}
GET /v2/glossary/{glossaryGuid}
PUT /v2/glossary/{glossaryGuid}
DELETE /v2/glossary/category/{categoryGuid}
GET /v2/glossary/category/{categoryGuid}
PUT /v2/glossary/category/{categoryGuid}
GET /v2/glossary/import/template
DELETE /v2/glossary/term/{termGuid}
GET /v2/glossary/term/{termGuid}
PUT /v2/glossary/term/{termGuid}
GET /v2/glossary/{glossaryGuid}/categories
GET /v2/glossary/{glossaryGuid}/detailed
PUT /v2/glossary/{glossaryGuid}/partial
GET /v2/glossary/{glossaryGuid}/terms
PUT /v2/glossary/category/{categoryGuid}/partial
GET /v2/glossary/category/{categoryGuid}/related
GET /v2/glossary/category/{categoryGuid}/terms
PUT /v2/glossary/term/{termGuid}/partial
DELETE /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/assignedEntities
POST /v2/glossary/terms/{termGuid}/assignedEntities
PUT /v2/glossary/terms/{termGuid}/assignedEntities
GET /v2/glossary/terms/{termGuid}/related
GET /v2/glossary/{glossaryGuid}/categories/headers
GET /v2/glossary/{glossaryGuid}/terms/headers

>From the available list of apis it will be difficult to get the complete 
>details just by using the qualified name as we do not have a GET on 
>/v2/glossary/terms

But if the term guid is passed to GET /v2/glossary/term/{termGuid}, then we 
might get the complete details.

Even customers might face this.

Thoughts?

- Dharshana MK


On April 28, 2021, 1:30 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73304/
> ---
> 
> (Updated April 28, 2021, 1:30 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4261
> https://issues.apache.org/jira/browse/ATLAS-4261
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4261: Bulk Glossary Import Response and Failed Error Message 
> Improvements
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 5ef62d310 
>   intg/src/main/java/org/apache/atlas/model/glossary/AtlasGlossaryTerm.java 
> 4fa1538df 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> b12c0b803 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> f5789a712 
> 
> 
> Diff: https://reviews.apache.org/r/73304/diff/5/
> 
> 
> Testing
> ---
> 
> {
> "failedImportInfoList": [
> {
> "parentObjectName": "Auto",
> "childObjectName": "Price",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Price@Auto already 
> exists"
> },
> {
> "parentObjectName": "Auto",
> "childObjectName": "Brake",
> "importStatus": "FAILED",
> "remarks": "Glossary term with qualifiedName Brake@Auto already 
> exists"
> }
> ],
> "successImportInfoList": [
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Receivable",
> "importStatus": "SUCCESS",
> "remarks": "Receivable@Banking4"
> },
> {
> "parentObjectName": "Banking4",
> "childObjectName": "Payable",
> "importStatus": "SUCCESS",
> "remarks": "Payable@Banking4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Steering",
> "importStatus": "SUCCESS",
> "remarks": "Steering@Auto4"
> },
> {
> "parentObjectName": "Auto4",
> "childObjectName": "Paint",
> "importStatus": "SUCCESS",
> "remarks": "Paint@Auto4"
> }
> ]
> }
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73290: ATLAS-4251: Upgrade luceneMatchVersion in Solr configs

2021-04-28 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73290/#review222893
---




distro/src/conf/solr/solrconfig.xml
Line 38 (original), 38 (patched)


luceneMatchVersion 8.4.1 is corresponding to solr.version 8.6.3?


- Pinal Shah


On April 21, 2021, 3:05 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73290/
> ---
> 
> (Updated April 21, 2021, 3:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4251
> https://issues.apache.org/jira/browse/ATLAS-4251
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Altas' Solr config currently has luceneMatchVersion as 5.0.0
> 
> This improvement will upgrade it to 8.4.1
> 
> 
> Diffs
> -
> 
>   dev-support/atlas-docker/config/solr/solrconfig.xml 21d19ef19 
>   distro/src/conf/solr/solrconfig.xml 21d19ef19 
>   repository/src/test/resources/solr/core-template/solrconfig.xml 9264f99d4 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 977ebc49c 
> 
> 
> Diff: https://reviews.apache.org/r/73290/diff/1/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> Pre-commit build - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/511/consoleFull
>  (IN PROGRESS)
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

[jira] [Updated] (ATLAS-4266) [Atlas: Glossary Term Bulk Import] Import fails with success state

2021-04-28 Thread Dharshana M Krishnamoorthy (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4266:
--
Description: 
The following is a complete failure scenario, where the user inputs blank 
spaces, here the import fails with complete failure, but the status is *200* ok

*Scenario*: Import Blank glossary and terms
{code:java}
GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, 
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
" ", " "{code}
*Observation:*
{code:java}
{
  "failedImportInfoList":[
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
},
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
}
  ]
}{code}
!Screenshot 2021-04-28 at 5.00.33 PM.png|width=597,height=399! There is only 
failure report in the response

!Screenshot 2021-04-28 at 5.00.33 PM.png|width=854,height=570!

 

 

  was:
The following is a complete failure scenario, where the user inputs blank 
spaces, here the import fails with complete failure, but the status is *200* ok

*Scenario*: Import Blank glossary and terms
{code:java}
GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, 
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
" ", " "{code}
*Observation:*
{code:java}
{
  "failedImportInfoList":[
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
},
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
}
  ]
}{code}
!Screenshot 2021-04-28 at 4.34.30 PM.png|width=546,height=217!


> [Atlas: Glossary Term Bulk Import] Import fails with success state
> --
>
> Key: ATLAS-4266
> URL: https://issues.apache.org/jira/browse/ATLAS-4266
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2021-04-28 at 4.34.30 PM.png, Screenshot 
> 2021-04-28 at 5.00.33 PM.png, Screenshot 2021-04-28 at 5.00.33 PM.png
>
>
> The following is a complete failure scenario, where the user inputs blank 
> spaces, here the import fails with complete failure, but the status is *200* 
> ok
> *Scenario*: Import Blank glossary and terms
> {code:java}
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
> Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
> Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, 
> TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> " ", " "{code}
> *Observation:*
> {code:java}
> {
>   "failedImportInfoList":[
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> },
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> }
>   ]
> }{code}
> !Screenshot 2021-04-28 at 5.00.33 PM.png|width=597,height=399! There is only 
> failure report in the response
> !Screenshot 2021-04-28 at 5.00.33 PM.png|width=854,height=570!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4266) [Atlas: Glossary Term Bulk Import] Import fails with success state

2021-04-28 Thread Dharshana M Krishnamoorthy (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4266:
--
Attachment: Screenshot 2021-04-28 at 5.00.33 PM.png

> [Atlas: Glossary Term Bulk Import] Import fails with success state
> --
>
> Key: ATLAS-4266
> URL: https://issues.apache.org/jira/browse/ATLAS-4266
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2021-04-28 at 4.34.30 PM.png, Screenshot 
> 2021-04-28 at 5.00.33 PM.png, Screenshot 2021-04-28 at 5.00.33 PM.png
>
>
> The following is a complete failure scenario, where the user inputs blank 
> spaces, here the import fails with complete failure, but the status is *200* 
> ok
> *Scenario*: Import Blank glossary and terms
> {code:java}
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
> Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
> Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, 
> TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> " ", " "{code}
> *Observation:*
> {code:java}
> {
>   "failedImportInfoList":[
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> },
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> }
>   ]
> }{code}
> !Screenshot 2021-04-28 at 4.34.30 PM.png|width=546,height=217!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4266) [Atlas: Glossary Term Bulk Import] Import fails with success state

2021-04-28 Thread Dharshana M Krishnamoorthy (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4266:
--
Attachment: Screenshot 2021-04-28 at 5.00.33 PM.png

> [Atlas: Glossary Term Bulk Import] Import fails with success state
> --
>
> Key: ATLAS-4266
> URL: https://issues.apache.org/jira/browse/ATLAS-4266
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2021-04-28 at 4.34.30 PM.png, Screenshot 
> 2021-04-28 at 5.00.33 PM.png, Screenshot 2021-04-28 at 5.00.33 PM.png
>
>
> The following is a complete failure scenario, where the user inputs blank 
> spaces, here the import fails with complete failure, but the status is *200* 
> ok
> *Scenario*: Import Blank glossary and terms
> {code:java}
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
> Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
> Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, 
> TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> " ", " "{code}
> *Observation:*
> {code:java}
> {
>   "failedImportInfoList":[
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> },
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> }
>   ]
> }{code}
> !Screenshot 2021-04-28 at 4.34.30 PM.png|width=546,height=217!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4012) Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1

2021-04-28 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334672#comment-17334672
 ] 

ASF subversion and git services commented on ATLAS-4012:


Commit e6e1cb59601dde67da31fbf587b5116d91787021 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e6e1cb5 ]

ATLAS-4012: UI Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1 #2

Signed-off-by: Nikhil Bonte 
(cherry picked from commit 183c076b78e6f7e25cae48f961cb2c40846de179)


> Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1
> ---
>
> Key: ATLAS-4012
> URL: https://issues.apache.org/jira/browse/ATLAS-4012
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4012-2-UI-Atlas-Upgrade-bootstrap-to-3.4.1-or-.patch, 
> 0001-ATLAS-4012-UI-Atlas-Upgrade-bootstrap-to-3.4.1-or-4..patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4012) Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1

2021-04-28 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17334670#comment-17334670
 ] 

ASF subversion and git services commented on ATLAS-4012:


Commit 183c076b78e6f7e25cae48f961cb2c40846de179 in atlas's branch 
refs/heads/master from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=183c076 ]

ATLAS-4012: UI Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1 #2

Signed-off-by: Nikhil Bonte 


> Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1
> ---
>
> Key: ATLAS-4012
> URL: https://issues.apache.org/jira/browse/ATLAS-4012
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4012-2-UI-Atlas-Upgrade-bootstrap-to-3.4.1-or-.patch, 
> 0001-ATLAS-4012-UI-Atlas-Upgrade-bootstrap-to-3.4.1-or-4..patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4266) [Atlas: Glossary Term Bulk Import] Import fails with success state

2021-04-28 Thread Dharshana M Krishnamoorthy (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4266:
--
Attachment: Screenshot 2021-04-28 at 4.34.30 PM.png

> [Atlas: Glossary Term Bulk Import] Import fails with success state
> --
>
> Key: ATLAS-4266
> URL: https://issues.apache.org/jira/browse/ATLAS-4266
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2021-04-28 at 4.34.30 PM.png
>
>
> The following is a complete failure scenario, where the user inputs blank 
> spaces, here the import fails with complete failure, but the status is *200* 
> ok
> *Scenario*: Import Blank glossary and terms
> {code:java}
> GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
> Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
> Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, 
> TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> " ", " "{code}
> *Observation:*
> {code:java}
> {
>   "failedImportInfoList":[
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> },
> {
>   "parentObjectName":"",
>   "childObjectName":null,
>   "importStatus":"FAILED",
>   "remarks":"The GlossaryName is blank for the record : [ ,  ]"
> }
>   ]
> }{code}
> !Screenshot 2021-04-28 at 4.34.30 PM.png|width=546,height=217!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4266) [Atlas: Glossary Term Bulk Import] Import fails with success state

2021-04-28 Thread Dharshana M Krishnamoorthy (Jira) 
Dharshana M Krishnamoorthy created ATLAS-4266:
-

 Summary: [Atlas: Glossary Term Bulk Import] Import fails with 
success state
 Key: ATLAS-4266
 URL: https://issues.apache.org/jira/browse/ATLAS-4266
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy
 Attachments: Screenshot 2021-04-28 at 4.34.30 PM.png

The following is a complete failure scenario, where the user inputs blank 
spaces, here the import fails with complete failure, but the status is *200* ok

*Scenario*: Import Blank glossary and terms
{code:java}
GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, 
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
" ", " "{code}
*Observation:*
{code:java}
{
  "failedImportInfoList":[
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
},
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
}
  ]
}{code}
!Screenshot 2021-04-28 at 4.34.30 PM.png|width=546,height=217!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4265) [Atlas: Glossary Term Bulk Import]: Error message is displayed twice for an error in bulk import

2021-04-28 Thread Dharshana M Krishnamoorthy (Jira) 
Dharshana M Krishnamoorthy created ATLAS-4265:
-

 Summary: [Atlas: Glossary Term Bulk Import]: Error message is 
displayed twice for an error in bulk import
 Key: ATLAS-4265
 URL: https://issues.apache.org/jira/browse/ATLAS-4265
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core, atlas-webui
Reporter: Dharshana M Krishnamoorthy
 Attachments: Screenshot 2021-04-28 at 4.34.30 PM.png

Scenario: Import Blank glossary and terms
{code:java}
GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, 
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
" ", " "{code}
*Observation:*
{code:java}
{
  "failedImportInfoList":[
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
},
{
  "parentObjectName":"",
  "childObjectName":null,
  "importStatus":"FAILED",
  "remarks":"The GlossaryName is blank for the record : [ ,  ]"
}
  ]
}{code}
!Screenshot 2021-04-28 at 4.34.30 PM.png|width=546,height=217!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4264) SqoopHook throwing an error

2021-04-28 Thread Arpit Shah (Jira) 
Arpit Shah created ATLAS-4264:
-

 Summary: SqoopHook throwing an error
 Key: ATLAS-4264
 URL: https://issues.apache.org/jira/browse/ATLAS-4264
 Project: Atlas
  Issue Type: Bug
  Components: sqoop-integration
Affects Versions: 2.1.0
 Environment: Linux
Reporter: Arpit Shah


Hi all,

I am exploring the apache atlas. I am trying to configure sqoop hook for Atlas 
but facing the error.

I have configured Apache Atlas 2.1.0 with Hbase and elasticsearch.

I am using sqoop 1.4.7 with Hadoop version 3.3.0.

I have followed all the steps for configuring SqoopHook mentioned in the atlas 
doc.

 

I am facing the below error after the successful completion of the map-reduce 
job.

 

 

org.apache.atlas.AtlasException: Failed to load application properties

    at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:147)

    at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:100)

    at org.apache.atlas.hook.AtlasHook.(AtlasHook.java:80)

    at org.apache.atlas.sqoop.hook.SqoopHook.(SqoopHook.java:82)

    at java.lang.Class.forName0(Native Method)

    at java.lang.Class.forName(Class.java:264)

    at 
org.apache.sqoop.mapreduce.PublishJobData.publishJobData(PublishJobData.java:46)

    at 
org.apache.sqoop.mapreduce.ImportJobBase.runImport(ImportJobBase.java:284)

    at org.apache.sqoop.manager.SqlManager.importTable(SqlManager.java:692)

    at 
org.apache.sqoop.manager.MySQLManager.importTable(MySQLManager.java:127)

    at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:520)

    at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:628)

    at org.apache.sqoop.Sqoop.run(Sqoop.java:147)

    at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)

    at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:183)

    at org.apache.sqoop.Sqoop.runTool(Sqoop.java:234)

    at org.apache.sqoop.Sqoop.runTool(Sqoop.java:243)

    at org.apache.sqoop.Sqoop.main(Sqoop.java:252)

Caused by: org.apache.commons.configuration.ConversionException: 
'atlas.graph.index.search.max-result-set-size' doesn't map to a List object: 
50, a java.lang.Integer

    at 
org.apache.commons.configuration.AbstractConfiguration.getList(AbstractConfiguration.java:1144)

    at 
org.apache.commons.configuration.AbstractConfiguration.getList(AbstractConfiguration.java:1109)

    at 
org.apache.commons.configuration.AbstractConfiguration.interpolatedConfiguration(AbstractConfiguration.java:1274)

    at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:142)

    ... 17 more

Exception in thread "main" java.lang.ExceptionInInitializerError

    at org.apache.atlas.sqoop.hook.SqoopHook.(SqoopHook.java:82)

    at java.lang.Class.forName0(Native Method)

    at java.lang.Class.forName(Class.java:264)

    at 
org.apache.sqoop.mapreduce.PublishJobData.publishJobData(PublishJobData.java:46)

    at 
org.apache.sqoop.mapreduce.ImportJobBase.runImport(ImportJobBase.java:284)

    at org.apache.sqoop.manager.SqlManager.importTable(SqlManager.java:692)

    at 
org.apache.sqoop.manager.MySQLManager.importTable(MySQLManager.java:127)

    at org.apache.sqoop.tool.ImportTool.importTable(ImportTool.java:520)

    at org.apache.sqoop.tool.ImportTool.run(ImportTool.java:628)

    at org.apache.sqoop.Sqoop.run(Sqoop.java:147)

    at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)

    at org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:183)

    at org.apache.sqoop.Sqoop.runTool(Sqoop.java:234)

    at org.apache.sqoop.Sqoop.runTool(Sqoop.java:243)

    at org.apache.sqoop.Sqoop.main(Sqoop.java:252)

Caused by: java.lang.NullPointerException

    at org.apache.atlas.hook.AtlasHook.(AtlasHook.java:85)

    ... 15 more



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [atlas] vladhlinsky commented on a change in pull request #137: ATLAS-4263: Fix KafkaUtils to always enclose property values in double-quotes

2021-04-28 Thread GitBox 


vladhlinsky commented on a change in pull request #137:
URL: https://github.com/apache/atlas/pull/137#discussion_r621897707



##
File path: common/src/main/java/org/apache/atlas/utils/KafkaUtils.java
##
@@ -318,20 +318,9 @@ static String surroundWithQuotes(String optionVal) {
 return optionVal;
 }
 
-String ret = optionVal;
-
-// For property values which have special chars like "@" or "/", we 
need to enclose it in
-// double quotes, so that Kafka can parse it
-// If the property is already enclosed in double quotes, then do 
nothing.
-if (optionVal.indexOf(0) != '"' && 
optionVal.indexOf(optionVal.length() - 1) != '"') {

Review comment:
   Probably, the `charAt` method could be used instead of `indexOf` , but I 
think we should omit this check at all, since the option value may contain 
double quotes at the beginning/at the end or in the middle of the string.
   Thus, the following option values look valid to me:
   ```
   user1
   "user2
   user3"
   user"4
   "user5" (the actual value is "user5", not user5)
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org