Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

2018-06-05 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/#review204318
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 5, 2018, 7:25 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67410/
> ---
> 
> (Updated June 5, 2018, 7:25 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Ruchi Solani, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2730
> https://issues.apache.org/jira/browse/ATLAS-2730
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes validation of classifcation TimeBoundry date time 
> timezone during addclassification and updateClassifcation of entity.
> 
> 
> Diffs
> -
> 
>   intg/pom.xml 57803bd6e 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> abacd7864 
>   intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
> 0badfcf92 
>   pom.xml 87ca5dd5f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  5e33cf59f 
> 
> 
> Diff: https://reviews.apache.org/r/67410/diff/4/
> 
> 
> Testing
> ---
> 
> Tested adding / updating classifcation with / invalid / without 
> TimeBoundry/datetime timezeone from UI and from API.
> Existing UT and IT passing.
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

2018-06-04 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 4, 2018, 12:32 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch adds missing licence file in new class.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/DatetimeUtilTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/3/

Changes: https://reviews.apache.org/r/67410/diff/2-3/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

2018-06-04 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/
---

(Updated June 4, 2018, 11:44 a.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, Ruchi 
Solani, and Sarath Subramanian.


Changes
---

This patch includes fix to handle review comments and UTs to test 
validateTimeBoundry(timeBoundary) method.


Bugs: ATLAS-2730
https://issues.apache.org/jira/browse/ATLAS-2730


Repository: atlas


Description
---

This patch includes validation of classifcation TimeBoundry date time timezone 
during addclassification and updateClassifcation of entity.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
  repository/pom.xml a6ee43f61 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 5e33cf59f 
  repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java PRE-CREATION 
  repository/src/test/java/org/apache/atlas/utils/DatetimeUtilTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/67410/diff/2/

Changes: https://reviews.apache.org/r/67410/diff/1-2/


Testing
---

Tested adding / updating classifcation with / invalid / without 
TimeBoundry/datetime timezeone from UI and from API.
Existing UT and IT passing.
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console


Thanks,

Nixon Rodrigues

Re: Review Request 67410: ATLAS-2730 : TimeBoundry date time validation during addclassification and updateClassifcation of entity.

2018-06-02 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67410/#review204220
---




repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java
Lines 36 (patched)


- ValidateTimeBoundry() ==> validateTimeBoundry()
- replace startDate/endDate/timeZonStr with "TimeBoundary timeBoundary"



repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java
Lines 39 (patched)


startDate and endDate can be null. It is not an error condition. Only 
validation required is that, when both values are specified, startDate should 
not be later than endDate.



repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java
Lines 44 (patched)


timeZone can be null or empty - which is treated as local-timezone.


- Madhan Neethiraj


On June 1, 2018, 12:29 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67410/
> ---
> 
> (Updated June 1, 2018, 12:29 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, 
> Ruchi Solani, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2730
> https://issues.apache.org/jira/browse/ATLAS-2730
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch includes validation of classifcation TimeBoundry date time 
> timezone during addclassification and updateClassifcation of entity.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 06b43458b 
>   repository/pom.xml a6ee43f61 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  5e33cf59f 
>   repository/src/main/java/org/apache/atlas/util/DateTimeUtil.java 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67410/diff/1/
> 
> 
> Testing
> ---
> 
> Tested adding / updating classifcation with / invalid / without 
> TimeBoundry/datetime timezeone from UI and from API.
> Existing UT and IT passing.
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/462/console
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>