Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-10 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/#review220283
---


Ship it!




Ship It!

- Sarath Subramanian


On April 10, 2020, 2:24 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72317/
> ---
> 
> (Updated April 10, 2020, 2:24 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3709
> https://issues.apache.org/jira/browse/ATLAS-3709
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Resolved issues in conjunction with Business Metadata attributes.
> Also handled index populate for Business Metadata attributes at the time of 
> start up.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  647e304 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java
>  814b9f5 
> 
> 
> Diff: https://reviews.apache.org/r/72317/diff/3/
> 
> 
> Testing
> ---
> 
> Pre-commit 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console
> 
> Pre-commit 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1793/console
> 
> Pre-commit 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1801/console
> 
> 
> Manual testing done.
> 
> CASE:1
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. add another attribute "attr2" in "BM1" (search weight 9)
> 7. associate "attr2" to "hdfsentity1"
> 8. check in quick search and suggestions
> 
> 
> CASE:2
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. add another attribute "attr2" in "BM1" (search weight 10)
> 7. associate "attr2" to "hdfsentity1"
> 8. check in quick search and suggestions for "attr1" and "attr2" values
> 
> 
> CASE:3
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. create another Busines meatadata "BM2" 
> 7. add attribute "attr2" in "BM2" (search weight 9)
> 8. associate "attr2" to "hdfsentity1"
> 9. check in quick search and suggestions for "attr1" and "attr2" values
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-10 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/
---

(Updated April 10, 2020, 9:24 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Some code refactoring


Bugs: ATLAS-3709
https://issues.apache.org/jira/browse/ATLAS-3709


Repository: atlas


Description
---

Resolved issues in conjunction with Business Metadata attributes.
Also handled index populate for Business Metadata attributes at the time of 
start up.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 647e304 
  
repository/src/main/java/org/apache/atlas/repository/graph/SolrIndexHelper.java 
814b9f5 


Diff: https://reviews.apache.org/r/72317/diff/3/

Changes: https://reviews.apache.org/r/72317/diff/2-3/


Testing
---

Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console

Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1793/console


Manual testing done.

CASE:1
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. add another attribute "attr2" in "BM1" (search weight 9)
7. associate "attr2" to "hdfsentity1"
8. check in quick search and suggestions


CASE:2
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. add another attribute "attr2" in "BM1" (search weight 10)
7. associate "attr2" to "hdfsentity1"
8. check in quick search and suggestions for "attr1" and "attr2" values


CASE:3
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. create another Busines meatadata "BM2" 
7. add attribute "attr2" in "BM2" (search weight 9)
8. associate "attr2" to "hdfsentity1"
9. check in quick search and suggestions for "attr1" and "attr2" values


Thanks,

Mandar Ambawane

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-09 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/
---

(Updated April 9, 2020, 8:32 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3709
https://issues.apache.org/jira/browse/ATLAS-3709


Repository: atlas


Description
---

Resolved issues in conjunction with Business Metadata attributes.
Also handled index populate for Business Metadata attributes at the time of 
start up.


Diffs
-

  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 647e304 


Diff: https://reviews.apache.org/r/72317/diff/2/


Testing (updated)
---

Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console

Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1793/console


Manual testing done.

CASE:1
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. add another attribute "attr2" in "BM1" (search weight 9)
7. associate "attr2" to "hdfsentity1"
8. check in quick search and suggestions


CASE:2
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. add another attribute "attr2" in "BM1" (search weight 10)
7. associate "attr2" to "hdfsentity1"
8. check in quick search and suggestions for "attr1" and "attr2" values


CASE:3
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. create another Busines meatadata "BM2" 
7. add attribute "attr2" in "BM2" (search weight 9)
8. associate "attr2" to "hdfsentity1"
9. check in quick search and suggestions for "attr1" and "attr2" values


Thanks,

Mandar Ambawane

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-08 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/
---

(Updated April 8, 2020, 2:15 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-3709
https://issues.apache.org/jira/browse/ATLAS-3709


Repository: atlas


Description
---

Resolved issues in conjunction with Business Metadata attributes.
Also handled index populate for Business Metadata attributes at the time of 
start up.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 647e304 


Diff: https://reviews.apache.org/r/72317/diff/2/

Changes: https://reviews.apache.org/r/72317/diff/1-2/


Testing
---

Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console

Manual testing done.

CASE:1
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. add another attribute "attr2" in "BM1" (search weight 9)
7. associate "attr2" to "hdfsentity1"
8. check in quick search and suggestions


CASE:2
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. add another attribute "attr2" in "BM1" (search weight 10)
7. associate "attr2" to "hdfsentity1"
8. check in quick search and suggestions for "attr1" and "attr2" values


CASE:3
1. create Busines meatadata "BM1" 
2. add one attribute "attr1" in "BM1" (search weight 9)
3. create one entity "hdfsentity1"
4. associate "attr1" to "hdfsentity1"
5. check in quick search and suggestions for "attr1" value

6. create another Busines meatadata "BM2" 
7. add attribute "attr2" in "BM2" (search weight 9)
8. associate "attr2" to "hdfsentity1"
9. check in quick search and suggestions for "attr1" and "attr2" values


Thanks,

Mandar Ambawane

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-08 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/#review220248
---




intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java
Lines 1000 (patched)


code duplicated. Try to combine with for loop above for 
'ttr.getAllEntityTypes()' line #984



repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
Lines 214 (patched)


code duplicated. Try to use 'changedTypeDefs' to include 
'changedBusinessMetadataDefs'


- Sarath Subramanian


On April 6, 2020, 11:20 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72317/
> ---
> 
> (Updated April 6, 2020, 11:20 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3709
> https://issues.apache.org/jira/browse/ATLAS-3709
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Resolved issues in conjunction with Business Metadata attributes.
> Also handled index populate for Business Metadata attributes at the time of 
> start up.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  647e304 
> 
> 
> Diff: https://reviews.apache.org/r/72317/diff/1/
> 
> 
> Testing
> ---
> 
> Pre-commit 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console
> 
> Manual testing done.
> 
> CASE:1
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. add another attribute "attr2" in "BM1" (search weight 9)
> 7. associate "attr2" to "hdfsentity1"
> 8. check in quick search and suggestions
> 
> 
> CASE:2
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. add another attribute "attr2" in "BM1" (search weight 10)
> 7. associate "attr2" to "hdfsentity1"
> 8. check in quick search and suggestions for "attr1" and "attr2" values
> 
> 
> CASE:3
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. create another Busines meatadata "BM2" 
> 7. add attribute "attr2" in "BM2" (search weight 9)
> 8. associate "attr2" to "hdfsentity1"
> 9. check in quick search and suggestions for "attr1" and "attr2" values
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-07 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/#review220236
---


Ship it!




Ship It!

- Sidharth Mishra


On April 7, 2020, 6:20 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72317/
> ---
> 
> (Updated April 7, 2020, 6:20 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3709
> https://issues.apache.org/jira/browse/ATLAS-3709
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Resolved issues in conjunction with Business Metadata attributes.
> Also handled index populate for Business Metadata attributes at the time of 
> start up.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  647e304 
> 
> 
> Diff: https://reviews.apache.org/r/72317/diff/1/
> 
> 
> Testing
> ---
> 
> Pre-commit 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console
> 
> Manual testing done.
> 
> CASE:1
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. add another attribute "attr2" in "BM1" (search weight 9)
> 7. associate "attr2" to "hdfsentity1"
> 8. check in quick search and suggestions
> 
> 
> CASE:2
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. add another attribute "attr2" in "BM1" (search weight 10)
> 7. associate "attr2" to "hdfsentity1"
> 8. check in quick search and suggestions for "attr1" and "attr2" values
> 
> 
> CASE:3
> 1. create Busines meatadata "BM1" 
> 2. add one attribute "attr1" in "BM1" (search weight 9)
> 3. create one entity "hdfsentity1"
> 4. associate "attr1" to "hdfsentity1"
> 5. check in quick search and suggestions for "attr1" value
> 
> 6. create another Busines meatadata "BM2" 
> 7. add attribute "attr2" in "BM2" (search weight 9)
> 8. associate "attr2" to "hdfsentity1"
> 9. check in quick search and suggestions for "attr1" and "attr2" values
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-03 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72317/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3709
https://issues.apache.org/jira/browse/ATLAS-3709


Repository: atlas


Description
---

Resolved issues in conjunction with Business Metadata attributes.
Also handled index populate for Business Metadata attributes at the time of 
start up.


Diffs
-

  intg/src/main/java/org/apache/atlas/listener/ChangedTypeDefs.java 58e889a 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 9df89a2 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 647e304 


Diff: https://reviews.apache.org/r/72317/diff/1/


Testing
---

Manual testing done.

Pre-commit https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1784/console


Thanks,

Mandar Ambawane